[00:02:18] (CR) Awight: [C: 2] "Aha, tinyblob *is* 255 chars." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/152145 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG) [00:02:26] (Merged) jenkins-bot: Schema change for comments on changes for logs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/152145 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG) [00:03:26] AndyRussG: can I merge https://gerrit.wikimedia.org/r/#/c/153385/ or are you still working on it? [00:06:41] awight: not quits set but almost, thanks! [00:06:56] (CR) Awight: "Luxurious, thanks! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144991 (owner: Ejegg) [00:07:44] BTW, regarding the column width in UI log tables, it's hardcoded in pixels in PHP all over [00:08:17] So I was all like, when in Rome... [00:11:05] Fair point! they'll be coming to feed us to the lions soon enough :p [00:12:24] coding in PHP is already like having one of these giant Q-tips to fend off the demons, http://mimg.ugo.com/200712/25222/cuts/american-gladiators_288x288.jpg [00:15:55] (PS1) Awight: typo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153550 [00:16:25] ejegg: ^^ aaargh even unit testing cannot save me now [00:18:38] awight: hahahaha [00:18:39] oh crap, I should have caught that in review [00:19:03] awight: upcoming patch is just the rebase [00:19:48] (PS3) AndyRussG: Add comments on changes, for logs and revisions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) [00:20:35] (CR) AndyRussG: "PS3: rebaaaaaasing..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG) [00:21:11] ejegg: there are many ways to lop off own foot, which won't be caught by review. [00:21:27] I guess the whole art is in making them look innocuous [00:22:12] (CR) Awight: "This will be great to have, thanks for going all out!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 (owner: Ejegg) [00:22:27] ejegg: one comment on ^^, I wonder if this was testing code? [00:24:11] just a stub [00:24:25] won't need that till we're marking silverpop bounces [00:24:37] k np [00:24:37] but was using the old constructor anyway [00:24:43] replacing with //TODO [00:26:17] ejegg: I don't see your response to my comment about https://gerrit.wikimedia.org/r/#/c/151574/8/sites/all/modules/thank_you/generators/RenderTranslatedPage.php,unified [00:26:21] line 93 [00:26:30] Just that it will be harder to fix later... [00:26:43] I think we should give the info comment some inherent semantics [00:26:45] like json [00:27:06] OK, that's a good point [00:27:23] meh whatever, we can always regenerate the templates... [00:27:35] also true [00:28:57] (CR) Awight: [C: 2] Track thank you emails to CiviMail (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151574 (owner: Ejegg) [00:33:27] (CR) Awight: [C: 2] "Woohoo!" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/152208 (owner: Ejegg) [00:34:13] (PS9) Ejegg: Track thank you emails to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151574 [00:34:15] (PS8) Ejegg: Classes to track external mailings to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 [00:34:17] (PS3) Ejegg: Add activity records for individual thank you emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/152208 [00:34:19] (PS3) Ejegg: Tests for CiviMail helpers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153426 [00:34:25] ejegg: can I has review, https://gerrit.wikimedia.org/r/#/c/153550/ [00:34:54] (CR) Ejegg: [C: 2] typo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153550 (owner: Awight) [00:35:31] oh man, didn't mean to rebase all of those [00:35:34] ejegg: generally if you're rebasing, try to use the Rebase button in gerrit, cos then it comments about [00:35:37] oh hah [00:35:41] nvm then! [00:35:43] aha [00:35:55] * awight stores criticism in buffer :p [00:36:10] just wanted to tack that stub fix onto the last one [00:36:16] (PS9) Awight: Classes to track external mailings to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 (owner: Ejegg) [00:36:22] (CR) Awight: [C: 2] Classes to track external mailings to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 (owner: Ejegg) [00:36:38] (PS10) Awight: Track thank you emails to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151574 (owner: Ejegg) [00:37:02] (PS4) Awight: Add activity records for individual thank you emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/152208 (owner: Ejegg) [00:37:17] (PS4) Awight: Tests for CiviMail helpers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153426 (owner: Ejegg) [00:37:19] thanks for the re-review! [00:37:41] no, thank you :p [00:38:19] (PS1) Awight: typo [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/153551 [00:38:27] (CR) Awight: [C: 2] typo [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/153551 (owner: Awight) [00:44:30] (PS1) Awight: Revert "Transaction around recurring Globalcollect charge" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153552 [00:44:42] ejegg: another snafu ^^ [00:45:01] eek. Where'd you catch that one? [00:46:07] deployed it :( [00:46:25] *then* thought about the implications [00:48:28] hrm, what's the issue? [00:48:53] one of the things we're doing inside the transaction is to mark the subscription as failed [00:48:55] oh, that it's a db thing plus a queue thing [00:49:13] so, when the thing gets rolled back, it looks successful [00:49:22] ahh, right [00:49:40] A db and a queue walk into a bar. The bartender says... [00:49:40] amusingly, the code ran the same suscription 250 times, which kept us... safer than if there had been a counter-bug r something. [00:49:53] oh, not really putting anything on the queue, just using the import fn [00:50:29] wait, why the same one? [00:51:13] ah that's a good question. might be a separate bug. [00:52:04] urgh I'll just disable the job... and go off duty ;) [00:52:38] huh. i'll see if i can spot it tmw morning [00:52:43] have a good evening [00:53:29] ejegg: ok thanks! [00:56:44] (PS4) AndyRussG: Add comments on changes, for logs and revisions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) [00:59:04] (CR) AndyRussG: "Thanks much!!!!" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG) [15:49:55] (CR) Ejegg: [C: 2] Revert "Transaction around recurring Globalcollect charge" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153552 (owner: Awight) [15:53:39] (CR) Ejegg: [C: 2] assert different donations have unique contacts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/149539 (owner: Awight) [15:59:02] ejegg: thx, I'm gonna deploy the recurring transaction reversion fyi [15:59:33] oof, I should investigate why it ran over the same subscription every iteration, too... [15:59:57] ejegg: on second thought, back to side job :) [16:03:14] heh [16:04:00] yeah, i hadn't seen anything obvious for thatrepeat