[00:11:45] <grrrit-wm>	 (PS2) Ssmith: Add timepickers and inform user of selection [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154201
[00:11:51] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Add timepickers and inform user of selection [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154201 (owner: Ssmith)
[03:56:09] <grrrit-wm>	 (PS1) EBernhardson: Use correct field names with addExtensionUpdate [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/154231
[09:11:04] <grrrit-wm>	 (CR) Raimond Spekking: [C: 2 V: 2] Localisation updates from https://translatewiki.net. [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/154165 (owner: L10n-bot)
[09:11:42] <grrrit-wm>	 (CR) Raimond Spekking: [C: 2 V: 2] Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/154162 (owner: L10n-bot)
[11:50:40] <grrrit-wm>	 (CR) Qgil: "Is this changeset waiting for reviewers or is it still WIP?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/99266 (owner: Awight)
[11:53:58] <grrrit-wm>	 (CR) Qgil: [C: -1] "Is this changeset waiting for reviewers or is it still WIP?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/104141 (owner: Awight)
[16:11:35] <grrrit-wm>	 (PS1) Ejegg: WP: Put stripped email in MerchantReference2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154282
[16:40:01] <ejegg>	 oh no, gerrit's bored of us!
[17:26:46] <ejegg>	 awight: were you using some cool transliteration thing for your dedup diff?
[17:27:03] <ejegg>	 i mean dedupe review
[17:39:47] <ejegg>	 atgo: for the WorldPay transcoding card, do you know if we need to transliterate kanji and such, or just eastern european and cyrillic type scripts that have straightforward equivalents?
[17:40:01] <ejegg>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1766
[17:55:47] <awight>	 ejegg: omg yeah I don't think transliteration is a win
[17:57:19] <ejegg>	 OK, then just strip out anything that can't be converted directly to western encoding equiv?
[17:57:42] <ejegg>	 Or replace with question marks, which is what the PHP fn I'm using for eastern european does with kanji
[17:58:12] <awight>	 ugh nok
[19:21:02] <awight|mtg>	 ejegg: no, I have no transliteration magick.  It is an evil and impossible practice tho
[19:21:18] <awight|mtg>	 ejegg: but-- I thought the issue was transcoding, not transliteration??
[19:21:49] <awight|fud>	 yeah that card says transcoding
[19:22:37] <ejegg>	 Oh, is there some way to transcode kanji into iso8859-1?
[19:23:38] <awight|fud>	 ejegg: err.  umm..
[19:24:13] <awight|fud>	 oof, we are effed.
[19:25:30] <ejegg>	 For characters like the eastern european accented consonents that have no iso8859-1 representation, i thought it would at least be nice to have the consonent sans hacek, which you can get with iconv('UTF-8', 'ISO-8859-1//TRANSLIT', 'stuff')
[19:26:10] <awight|fud>	 eergh.  It would be good to call WorldPay out on this, IMO.
[19:26:30] <ejegg>	 yeah, actually we'd have to convert the whole XML post
[19:26:35] <awight|fud>	 really away now
[19:26:40] <ejegg>	 enjoy lunch
[19:38:15] <grrrit-wm>	 (PS1) Ssmith: List filters dynamically [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154310
[19:38:21] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] List filters dynamically [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154310 (owner: Ssmith)
[19:57:45] <awight>	 ejegg: sorry to slow you down, WorldPay will almost certainly refuse to fix anything on their end, so you're probably right that transliteration is the only solution.
[20:00:30] <ejegg>	 It would have to be the whole XML post though, since putting the iso8859 accented characters back into a UTF8 XML doc will screw it up before we even send it out.  So that will be trickier than the single-field munging I'm doing.
[20:01:13] <awight>	 I think xml has an explicit charset declaration, so you can encode the entire document as lat1?
[20:01:38] <ejegg>	 right-oh.
[20:01:56] <awight>	 I see, but it will take more extensive DonationInterface munging
[20:02:02] <ejegg>	 yeah
[20:08:35] <ejegg>	 awight: is this appropriate use of staging vars and the stage_ function? https://gerrit.wikimedia.org/r/#/c/154282/
[20:09:05] <ejegg>	 i need to get set up to hit the WP testing endpoint
[20:13:41] <awight>	 ejegg: yeah for sure!
[20:13:51] <ejegg>	 thanks!
[20:14:22] <awight>	 There was some theory about replacing the at-sign with another punctuation, but I think I prefer what you've done here.
[20:14:38] <grrrit-wm>	 (CR) Awight: WP: Put stripped email in MerchantReference2 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154282 (owner: Ejegg)
[20:15:42] <ejegg>	 looked like + was rejected too, so I figured I'd choose the least offensive separator
[20:19:46] <awight>	 hah!  Yeah I don't know how we choose these winning payment processors...
[20:20:57] <awight>	 Jeff_Green: hey, did you succeed in reviving the recurring alert?  https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1186
[20:21:13] <awight>	 I think we're wondering, is it alive, and is the threshold set to something very low?
[20:21:25] <Jeff_Green>	 oh
[20:22:13] <Jeff_Green>	 OK missing_thank_yous=1: recurring_gc_contribs_missed=384:  recurring_gc_failures_missed=0: recurring_gc_jobs_required=1014:  recurring_gc_schedule_sanity=0 
[20:22:36] <awight>	 hah missing_thank_yous>11,000 so that's funny
[20:22:45] <grrrit-wm>	 (PS2) Ejegg: WorldPay: Put stripped email in MerchantReference2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154282
[20:22:50] <awight>	 Jeff_Green: are those the thresholds?
[20:23:06] <Jeff_Green>	 no. getting those now
[20:23:27] <awight>	 those are alert outputs, then?
[20:24:05] <grrrit-wm>	 (CR) Ejegg: "fixed copypasta" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154282 (owner: Ejegg)
[20:24:30] <Jeff_Green>	 see email
[20:24:39] <ejegg>	 ugh, you have to specifically comment on the old patch set to publish inline replies?
[20:24:54] <awight>	 ejegg: yep :-/
[20:25:10] <grrrit-wm>	 (CR) Ejegg: "fixed copypasta" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154282 (owner: Ejegg)
[20:25:29] <awight>	 Jeff_Green: oh wow, thanks.  Is that stuff coming from puppet / puppet-priv / elsewhere?
[20:25:55] <Jeff_Green>	 regular puppet, hardcoded in the script :-)
[20:26:05] <awight>	 woot :p
[20:26:18] <awight>	 so, we're hoping to set the recurring_gc_contribs_missed threshold to very low.
[20:26:41] <awight>	 But currently I've disabled the job for misbehavior, so... I'll ping u when we can set that threshold.
[20:26:46] <awight>	 Where do the alerts go?
[20:26:57] <Jeff_Green>	 i think they go to fr-tech only
[20:30:58] <awight>	 Jeff_Green: I've never seen one.  I guess that's a good thing...
[20:31:03] <Jeff_Green>	 ha
[20:31:29] <awight>	 Jeff_Green: so ahem, that's perl then.  What executes it?
[20:31:45] <awight>	 It would be nice to have a mini doc on this, one day.
[20:31:51] <Jeff_Green>	 the nagios_nsca script
[20:32:00] <Jeff_Green>	 which runs on every machine in frack
[20:32:00] <awight>	 ok thx
[20:32:01] <Jeff_Green>	 on cron
[20:32:27] <Jeff_Green>	 it runs nagios plugins as specified in /etc/nagios_nsca.conf and injects them to the nsca master
[20:34:21] <grrrit-wm>	 (CR) Awight: [C: 2] WorldPay: Put stripped email in MerchantReference2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154282 (owner: Ejegg)
[20:34:33] <grrrit-wm>	 (Merged) jenkins-bot: WorldPay: Put stripped email in MerchantReference2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154282 (owner: Ejegg)
[20:37:05] <grrrit-wm>	 (CR) Awight: [C: 2] "Cool!" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154310 (owner: Ssmith)
[20:37:36] <grrrit-wm>	 (CR) Awight: "@pizzacat: needs manual rebase" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151137 (owner: Ssmith)
[20:38:40] <grrrit-wm>	 (CR) Awight: [C: -1] "Just dinging for the gitignore thing" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151237 (owner: Ssmith)
[20:39:02] <grrrit-wm>	 (CR) Awight: [C: 2] Show selected submenus for filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151256 (owner: Ssmith)
[20:39:25] <grrrit-wm>	 (CR) Awight: [C: 2] Fix checkbox padding [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/153860 (owner: Ssmith)
[20:40:32] <grrrit-wm>	 (CR) Awight: [C: 2] Add timepickers and inform user of selection [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154201 (owner: Ssmith)
[20:52:10] <awight>	 ejegg|away: I'm finding really scary behavior with the CRM phpunit tests...
[20:52:23] <awight>	 lemme know if you have a minute to help
[20:53:36] <awight>	 There's something in phpunit which converts "undefined variable" notices into an exception, and it's not working on the first test of any suite.
[20:56:23] <awight>	 pizzzacat: hey, you have a rebase issue beginning at https://gerrit.wikimedia.org/r/151137
[20:56:26] <awight>	 sorry!
[20:56:43] <awight>	 also, want to finish that node_modules thing we were working on?
[20:57:01] <pizzzacat>	 yes
[21:14:00] <atgo__>	 awight what's the link for the sql queries?
[21:15:30] <awight>	 atgo: https://collab.wikimedia.org/wiki/Fundraising/Engineering/Fun_SQL_Queries
[21:15:37] <atgo>	 thanks!
[21:15:43] <awight>	 atgo: I have ten minutes available at any time u need
[21:16:00] <atgo>	 sure.. i think it's probably good for me to just get familiar now and then when i'm back we can do more teaching
[21:16:09] <atgo>	 i don't promise to actually retain much if we do it now and then i leave for 2 weeks :)
[21:16:28] * awight tee-hees
[21:16:43] <awight>	 preparing to Burn out, I see
[21:18:41] <ejegg>	 awight: weird behavior - let me try to reproduce.  any patch set you want me to look at for that?
[21:18:55] <ejegg>	 that was re: phpunit
[21:20:01] <AndyRussG>	 awight: atgo: ejegg: Hi everyone... Quick ?: for the schema change for CentralNotice infrastructure, I should only put meta as the affected wiki on the bug? https://bugzilla.wikimedia.org/enter_bug.cgi
[21:20:19] <ejegg>	 awight: oh man, i wouldn't be suprised if it had to do with that TemporaryErrorScope BS
[21:21:22] <AndyRussG>	 (^ just realized that link does nothing...)
[21:21:39] <atgo>	 ha yeah.. i'm poking around. i have no idea.. awight?
[21:22:04] <AndyRussG>	 This is the one really: https://bugzilla.wikimedia.org/enter_bug.cgi?assigned_to=wikibugs-l%40lists.wikimedia.org&attach_text=&blocked=49188&bug_file_loc=http%3A%2F%2F&bug_severity=normal&bug_status=NEW&cf_browser=---&cf_platform=---
[21:22:04] <AndyRussG>	 &comment=Short%20description%3A%0D%0A%0D%0AWhich%20wikis%20are%20affected%3A%0D%0A%0D%0AWhich%20tables%3A%0D%0A%0D%0AWhat%20is%20the%20change%20to%20those%20tables%3A%0D%0A%0D%0ALinks%20to%20gerrit%20changes%20and%2For%20other%20related%20bug%20reports.&component=General%2FUnknown&contenttypeentry=&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&data=&dependson=&description=&flag_type-
[21:22:04] <AndyRussG>	 3=X&form_name=enter_bug&keywords=schema-change%2C%20&maketemplate=Remember%20values%20as%20bookmarkable%20template&op_sys=All&product=Wikimedia&rep_platform=All&short_desc=&target_milestone=---&version=unspecified
[21:22:45] <atgo>	 errrm
[21:22:49] <atgo>	 bit.ly?
[21:22:53] <atgo>	 tinyurl?
[21:24:06] <AndyRussG>	 It's so much more impressive like that, no?
[21:24:23] <atgo>	 and so much more impossible to click on
[21:24:25] <atgo>	 :P
[21:24:33] <AndyRussG>	 One sec
[21:24:56] <AndyRussG>	 http://bit.ly/VsVE63
[21:25:24] <atgo>	 hey cc
[21:25:26] <atgo>	 ccogdill:
[21:25:29] <awight>	 AndyRussG: yeah the only affected wiki should be meta
[21:25:31] <atgo>	 oh man. that was a mess.
[21:25:38] <AndyRussG>	 awight: thanks!
[21:25:41] <ccogdill>	 yeah atgo?
[21:25:43] <awight>	 and: lol URL
[21:25:54] <atgo>	 ccogdill: did you see the email from sebastiaan 8 days ago about some SEPA transactions coming through?
[21:25:55] <awight>	 ejegg: I think it's Drupal replacing PHPUnit's error handler
[21:25:59] <AndyRussG>	 atgo: sorry
[21:26:03] <AndyRussG>	 :(
[21:26:04] <awight>	 could be civi or drupal, actually
[21:26:12] <atgo>	 he no worries... i meant my typing AndyRussG
[21:26:12] <ccogdill>	 yeah
[21:26:21] <atgo>	 so... i'm not entirely sure what to do with that
[21:26:32] <ccogdill>	 haha
[21:26:33] <ccogdill>	 let me find it
[21:26:37] <atgo>	 the-wub thinks it's all shut down. i don't think katie even turned it on in production
[21:26:49] <atgo>	 have you.. heard anything?
[21:27:18] <awight>	 atgo: eergh, fwiw I was supposed to shut DD down on the backend and did not
[21:27:29] <grrrit-wm>	 (PS2) Ssmith: Fix checkbox padding [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/153860
[21:27:31] <grrrit-wm>	 (PS2) Ssmith: Better time period selection panel [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151237
[21:27:32] <atgo>	 awight: that might explain it
[21:27:33] <grrrit-wm>	 (PS2) Ssmith: List filters dynamically [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154310
[21:27:35] <grrrit-wm>	 (PS2) Ssmith: Change modal selections for time period choices [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151137
[21:27:36] <atgo>	 that needs to happen.
[21:27:37] <grrrit-wm>	 (PS2) Ssmith: Show selected submenus for filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151256
[21:27:39] <grrrit-wm>	 (PS3) Ssmith: Add timepickers and inform user of selection [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154201
[21:27:47] <awight>	 flood!!
[21:27:49] <atgo>	 pizzzacat blowing up irc
[21:27:59] <atgo>	 yeah awight... that's really important that that get shut off.
[21:28:01] <ejegg>	 that TemporaryErrorScope definitely does replace it, but i'm not sure if it's in effect where you're seeing the issue
[21:28:04] <AndyRussG>	 no wonder she logged out before doing that
[21:28:15] <atgo>	 when were you supposed to do that?
[21:28:21] <atgo>	 july 30 or so?
[21:28:57] <atgo>	 i mean we shouldn't be sending anyone there from the front end, but still...
[21:29:03] <ccogdill>	 sorry atgo, got distracted rereading that email. by have you heard anything, do you mean from GC?
[21:29:13] <atgo>	 or from donors attempting to use DD
[21:29:14] <ccogdill>	 I haven’t noticed any DD transactions coming through
[21:29:16] <ccogdill>	 nope
[21:29:21] <ccogdill>	 just 1 guy asking if he could
[21:29:29] <ccogdill>	 want me to run a report in GC and see
[21:29:30] <ccogdill>	 ?
[21:29:52] <atgo>	 i'm doing that right now
[21:30:06] <atgo>	 they're all our standard form amounts
[21:30:08] <ccogdill>	 is Phoebe saying recurrings are the ones that kept going?
[21:30:13] <atgo>	 where are these people getting these forms?
[21:30:21] <atgo>	 oh maybe
[21:30:41] <ccogdill>	 I didn’t get the attachment she’s referencing so I’m not sure
[21:30:53] <ccogdill>	 can you send it to me? I can look up the transactions she’s talking about to see
[21:32:08] <atgo>	 we think it might be the recurring jobs
[21:32:38] <ccogdill>	 merci!
[21:32:41] <ccogdill>	 checking now
[21:32:44] <atgo_>	 thanks
[21:33:00] <atgo_>	 yeah from the console it look slike they stopped on the 11, which is when awight shut down recurring for another reason
[21:33:33] <ccogdill>	 yeah atgo, you can tell by the effort ID that they’re reccuring
[21:33:47] <atgo_>	 ok. oy
[21:34:07] <atgo_>	 AndyRussG: standup?
[21:34:54] <ccogdill>	 so the good news is, I think all the ones that weren’t rejected are pending at status 600
[21:34:58] <ccogdill>	 they’ll never process
[21:40:39] <grrrit-wm>	 (CR) Hashar: [C: 1 V: 1] "Confirmed the updater columns names now matches the ones from the patches files." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/154231 (owner: EBernhardson)
[21:48:14] <ejegg>	 awight: noon next Wednesday OK?
[21:51:12] <awight>	 ejegg: yep!
[21:51:37] <spagewmf>	 awight: the patch is https://gerrit.wikimedia.org/r/#/c/154231/
[21:51:50] <spagewmf>	 beta labs failing
[21:52:32] <ejegg>	 rockin
[21:53:04] <awight>	 AndyRussG: ^^ u aware of this?
[21:53:06] <spagewmf>	 ejegg or you could +2 it, anyone who groks CentralNotice
[21:54:39] <grrrit-wm>	 (CR) Awight: [C: 2] "OK Thanks for finding this!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/154231 (owner: EBernhardson)
[21:54:46] <spagewmf>	 thanks!
[22:00:03] <atgo_>	 hey pizzzacat do you want either of those 2 new cards to be in the current sprint?
[22:00:13] <atgo_>	 (which ends wednesday)
[22:00:56] <pizzzacat>	 it's ok to put them in the next sprint
[22:01:03] <pizzzacat>	 :)
[22:01:19] <pizzzacat>	 I may or may not start them earlier
[22:01:21] <pizzzacat>	 but yeah
[22:01:35] <pizzzacat>	 they def. won't get done by wednesday
[22:05:41] <AndyRussG>	 awight: Yes I did see it
[22:05:49] <atgo_>	 cool
[22:06:09] <atgo_>	 awight: once coinbase has their sftp, will there be add'l tech work? just writing up a status update on the project
[22:07:18] <awight>	 atgo_: yep.  maybe 2 points of difficult
[22:07:21] <atgo_>	 cool thanks
[22:07:28] <AndyRussG>	 awight: woops just looking closely... "beta labs failing"???
[22:07:29] <awight>	 atgo_: hey, can you paste me one of the bad dd order IDs
[22:07:48] <atgo_>	 awight:  yeah.. it'll take a sec
[22:07:49] <awight>	 AndyRussG: yeah it was something about the schema migration--the column name we were checking for was wrong
[22:07:52] <AndyRussG>	 I killed beta labs?
[22:07:53] <atgo_>	 why does my name always add a _?
[22:07:54] <awight>	 it's fixed now though
[22:07:55] <awight>	 hehe
[22:08:07] <AndyRussG>	 atgo_: it's the second you
[22:08:19] <atgo>	 awight: 9611903905
[22:08:26] <awight>	 atgo_: cos your client constantly disconnects and reconnects, and you aren't allowed to take the name of someone who is only recently deceased
[22:08:29] <awight>	 thx!
[22:08:35] <atgo>	 grumble
[22:09:32] <awight>	 atgo: but yeah, your client should be able to help you set your name back after the ghost expires
[22:10:08] <AndyRussG>	 It also happens when IRC does some weird ancient network "split" think, I think
[22:10:18] <AndyRussG>	 "thing, I think", I meant
[22:11:39] <atgo>	 awight:  do you need more from gc console?
[22:12:02] <awight>	 atgo: no, thx!
[22:12:22] <awight>	 ccogdill: just to confirm, I'm about to cancel all active DD recurring subscriptions in Civi
[22:12:53] <AndyRussG>	 awight: was beta labs really failing 'cos of that? I do remember those parameters and thinking that they didn't necessarily follow the column name exactly... Hmmm many apologies in any case 8p
[22:13:13] <AndyRussG>	 I did test it locally too
[22:13:31] <awight>	 AndyRussG: oh wow, really?  thought the column name was actually used
[22:13:46] <ccogdill>	 awesome awight, sounds good to me
[22:13:50] <awight>	 But not sure what kind of fail thay're talking about
[22:13:53] <AndyRussG>	 Well it looks now like it is, and that I was wrong
[22:14:04] <ccogdill>	 probably good to have you do that before I send the email saying they won’t process
[22:14:06] <awight>	 AndyRussG: All I can imagine is that the upgrade job would fail the second time
[22:14:13] <awight>	 oh.  that's what it must have been
[22:14:17] <awight>	 ccogdill: hehe yes perfect
[22:14:25] <atgo>	 ccogdill fwiw we haven't been processing them anyway since non-sepa flows don't work
[22:14:26] <AndyRussG>	 Aaaah maybe that's it yeah
[22:14:34] <ccogdill>	 yeah
[22:14:43] <ccogdill>	 it looked like they all failed one way or another
[22:14:47] <ccogdill>	 I’m not worried about it!
[22:15:02] <awight>	 ccogdill: atgo says many are "pending" still.  yikes!
[22:15:07] <ccogdill>	 yeah
[22:15:09] <ccogdill>	 at 600
[22:15:15] <atgo>	 yeah they are, but they won't go through
[22:15:20] <ccogdill>	 at least it’s a dead-end kind of pending
[22:15:20] <atgo>	 we need to shut it down fo sho
[22:15:33] <ccogdill>	 only I can process them  :x
[22:16:38] <awight>	 ccogdill: done, 463 cancellations
[22:16:47] <ccogdill>	 woo!
[22:16:49] <ccogdill>	 so wait...
[22:17:03] <ccogdill>	 there were only 463 active DD recurrings?
[22:17:16] <ccogdill>	 that query I ran to get my list for the email had a little over 600
[22:17:24] <ccogdill>	 do you think my list was wrong?
[22:17:52] <awight>	 ccogdill: I found 838 total, and 463 were not already cancelled.
[22:17:57] <ccogdill>	 hmmmm
[22:18:04] <awight>	 Where did you run the query?
[22:18:06] <awight>	 silverpop?
[22:18:09] <ccogdill>	 civi
[22:18:21] <ccogdill>	 this was the thing in mingle #1871
[22:18:24] <awight>	 ccogdill: do you have that list stored somewhere?
[22:18:34] <ccogdill>	 mmm… in silverpop
[22:18:37] <AndyRussG>	 awight: yeah that's it, it fails when you re-run update.php... Thanks!!!
[22:18:39] <ccogdill>	 want me to put in in fileserv
[22:18:45] <ccogdill>	 ?
[22:18:59] <awight>	 AndyRussG: or, I think since they were starting with a brand-new schema, the first run of update failed
[22:19:04] <awight>	 ccogdill: sure thx
[22:19:16] <awight>	 ccogdill: meanwhile, I'll actually read your query now
[22:19:24] <ccogdill>	 :)
[22:19:27] <AndyRussG>	 I just tried applying it locally on my local schema that's already updated, and it died
[22:19:45] <awight>	 ccogdill: maybe it's the date range :-/
[22:19:52] <ccogdill>	 yeah
[22:20:02] <AndyRussG>	 Function: DatabaseBase::sourceFile( /home/home/Wikimedia/CentralNotice/infrastructure/extensions/CentralNotice/patches/patch-template-logging-comments.sql )
[22:20:02] <AndyRussG>	 Error: 1060 Duplicate column name 'tmplog_comment' (localhost)
[22:20:03] <awight>	 wait, but... more?
[22:20:12] <awight>	 AndyRussG: yep, ok we are not crazy :p
[22:20:21] <ccogdill>	 would you just do 7/1 - present?
[22:20:35] <awight>	 ccogdill: I... don't know what I would do in Civi
[22:20:39] <ccogdill>	 hah
[22:21:04] <ccogdill>	 is this a mysql situation or ?
[22:21:22] <awight>	 ccogdill: I did my query in mysql
[22:21:33] <awight>	 so I can compare with your list and see what happened
[22:21:49] <ccogdill>	 k
[22:22:43] <AndyRussG>	 As is... clearly stated in the commit message...
[22:24:38] * awight adjusts collar
[22:24:46] <grrrit-wm>	 (CR) AndyRussG: "Big woops, apologies & thanks!!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/154231 (owner: EBernhardson)
[22:25:33] <ccogdill>	 okay awight it’s in the Silverpop queries folder in fundraising fileserv
[22:25:47] <awight>	 ccogdill: rad, I'll look at this in a bit thx!
[22:25:49] <ccogdill>	 the file name is long, but it’s the only one that starts with DDrecurring
[22:25:52] <ccogdill>	 thank yoU!
[22:56:56] <awight>	 ccogdill: OK, I can get a list of 631 subscriptions which... pretty much match yours.
[22:57:05] <ccogdill>	 yep
[22:57:07] <ccogdill>	 awesome!
[22:57:13] <ccogdill>	 okay, that makes me feel better
[22:57:21] <ccogdill>	 thank you for double checking
[22:58:03] <awight>	 Unfortunately, I destroyed the data which would let me check why only 463 were not already cancelled
[22:59:54] <ccogdill>	 haha
[22:59:57] <ccogdill>	 I think that’s okay
[23:04:43] <grrrit-wm>	 (PS1) Awight: Prevent Drupal from taking over PHPUnit's error handler [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/154357
[23:04:48] <awight>	 ejegg: nasty one! ^^
[23:05:43] <awight>	 HAH none of our tests pass now.
[23:24:27] <grrrit-wm>	 (PS1) Awight: Fix totally mangled recurring code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/154361
[23:24:29] <grrrit-wm>	 (PS1) Awight: fix typo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/154362
[23:56:54] <awight>	 AndyRussG: did you have any luck with phpunit's "test doubles"?
[23:57:36] <awight>	 It looks like it doesn't actually override autoloading, so you need to pass your mock object into the code under test directly?
[23:57:37] <AndyRussG>	 awight: test doubles and me are best buddies
[23:57:57] <awight>	 hehehe now I have seen you lie
[23:58:12] <AndyRussG>	 There's a whole bunch of methods available via $this
[23:58:22] <AndyRussG>	 Simplest one is $this->getMock
[23:58:26] <AndyRussG>	 Is that what you're talking about?
[23:58:35] <awight>	 yeah, I'm reading http://phpunit.de/manual/4.1/en/test-doubles.html
[23:58:50] <awight>	 but for example I want to intercept sent emails...
[23:59:04] <awight>	 so I guess I'd need to already have dependency injection or something :-/
[23:59:48] <AndyRussG>	 Hmmm