[00:00:08] Well you do need some way to get your mocks into the code you're testing [00:00:14] There are lots of options fortunately [00:00:39] The hardest case I've found is when you need to mock something gotten via a static method [00:00:57] If not, there's usually a way. Note that you can also semi-mock the class you're actually testing [00:01:20] AndyRussG: oh interesting. thanks, you've given me some ideas [00:01:42] Mocking in php is just subclassing on the fly and overriding methods with stubs [00:02:20] If you like you can create a mock that overrrides just a few methods that you may need to return mocks, and test the real code using that [00:02:51] Another option is creating a subclass with some custom test code just for the test [00:02:55] That's pretty cool [00:03:15] I do wish I could replace all instances globally, but sigh [00:03:24] Mmm it often does the job, so it seems [00:03:31] If you have a pastebin or the like I can comment [00:03:49] Don't worry I'll jump it to the front of my to-do list [00:04:00] lol yes that was a terrifying sight today [00:05:15] Heh sorry about that [00:05:37] I got second-hand stress [00:05:44] not your fault [00:08:05] Ohhhh I didn't know [00:08:28] Don't worry I'll try not to stress about it [00:08:49] :p thank you for being so understanding of my condition after seeing your todo list [00:10:00] plesae do feel free to pastebin me your testable [00:10:33] not much to show yet, but I might! [00:10:33] mhh sorry that sounded awful [00:10:46] K sounds good [00:12:28] atgo__: and atgo___: are underscore-happy [00:38:22] (PS8) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 [00:38:27] (CR) jenkins-bot: [V: -1] WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 (owner: Awight) [00:46:56] icinga has registered a complaint FYI [00:47:01]

PROBLEM - check_fundraising_jobs on db1025 is CRITICAL: CRITICAL missing_thank_yous=1: recurring_gc_contribs_missed=1003: recurring_gc_failures_missed=266 [critical =50]: recurring_gc_jobs_required=1014: recurring_gc_schedule_sanity=0 [00:47:32] i guess gc == garbage collection? [00:52:27] greg-g, who to ping? [01:06:24] helo, we are not sure if/how important this is, but [01:06:28] recurring_gc_failures_missed=266 [01:06:39] over 50 and Icinga starts talking about that [01:07:00] https://icinga.wikimedia.org/cgi-bin/icinga/history.cgi?host=db1025&service=check_fundraising_jobs [01:18:56] Jeff_Green, there's an FR icinga alert every ~5 min [01:19:29] mutante, i mentioned here first and then tried #-operations when here was quiet :) [01:19:52] jeremyb: i just saw that in the bot logfile, after followin the topic link, hah [01:35:41] jeremyb: yeah, I'm not sure why that just started [01:36:34] I just tweaked the alert threshold for now, hopefully it will be stable until the fr-tech folks return, otherwise it'll blow up my phone again