[00:03:44] (CR) Awight: "@ejegg: Yeah u can search for checks by source_name='Offline importer: AzlChecksFile', for terrible example... Also, gateway = arizonaloc" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153416 (owner: Awight) [00:10:17] (PS1) Awight: pacify tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/155473 [17:41:13] ejegg: Ping! [17:41:51] Hi K4! [17:42:02] Hey ejegg. :) How's it going? [17:42:43] Pretty good. Working outdoors is nice [17:42:51] ...jealous. [17:43:02] I should do that at home sometime. [17:43:16] Just plugging away at bulk email importing - need a bunch of different methods from the ty mails for the sake of efficiency [17:43:35] ah, cool. [17:43:45] are you dug out from under the avalanche of stuff that accumulated during your vaca? [17:43:50] Not really! [17:44:03] But, I'm not up to my eyeballs anymore. [17:44:07] It's more neck level. [17:44:07] Making progress at least? [17:44:10] nice [17:44:34] You can tease me about working outside in February [17:44:43] So, I thought I'd ask before I get back to it, if you need anything from me today. [17:44:50] You know, before I evaporate again. [17:45:13] At some point I want to hit the test Worldpay site with the transcoded stuff [17:45:31] I think it's pretty safe, but I'm just curious [17:45:34] Ah! I thought I remembered something, but I couldn't remember what it was. [17:46:03] a bunch of the worldpay docs are encrypted. Anne had the pw for one of them [17:46:14] and of course they don't have our test user password in them [17:46:20] I think I have that here. [17:46:35] pm me? [17:46:54] To you have the Off the Record chat encryption thingy all set up? [17:47:06] oh shoot, not yet. Will do that. [17:47:21] Yeah, you'll probably need that at odd intervals for a while. :) [17:47:34] in the meantime, any general stuff you can tell me about hitting their test site? [17:47:52] I assume I'll have to do the full-connection VPN to go through hq [17:48:05] Hmm... I don't actually remember if you need that or not. [17:48:16] Some of the gateways whitelist IPs, and some just... don't. [17:48:27] Globalcollect does. [17:48:38] WP, I can't remember. [17:50:08] sweet, irssi otr plugin is in ubuntu repos [17:51:44] Oh, btw, does 10GB/year of full text TY messages in Civi's Activity table worry you overmuch? [17:53:31] bah. irssi crashing every time I try to /load otr [17:53:51] ejegg: Ah... 10GB/year? Nah. [17:54:13] Cool [17:54:18] I mean... I'd like to have a plan for destroying that data in place when we start collecting it, though. [17:54:23] they're about 4kb each [17:55:02] Can we do something like... plan to keep the full emails for 6 months or something, and have a destroy job up and running? [17:55:03] DELETE FROM civicrm_activity? Or you mean like policy on retention time? [17:55:11] Both, actually. [17:55:25] Yeah, destroy job wouldn't be too hard. [17:56:12] The activity table itself has a date on it. Hmm, let me make sure we can tell TY activities apart from stuff we want to retain [17:56:54] So leave the record that they've been thanked, but replace the full text with *expired* or something? [20:28:02] (CR) Ejegg: [C: 2] pacify tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/155473 (owner: Awight) [20:29:03] (CR) Ejegg: [C: 2] Remove unused hooks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153416 (owner: Awight) [20:29:27] (PS3) Ejegg: Move HTML->plaintext conversion down to Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153422 (owner: Awight) [20:35:48] (CR) Ejegg: "Maybe split out the 'to' change? Not sure why it's there." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153422 (owner: Awight) [20:45:27] (CR) Ejegg: [C: 2] Use public instead of var in classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154596 (owner: Addshore) [20:45:44] (Merged) jenkins-bot: Use public instead of var in classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154596 (owner: Addshore) [20:46:00] (CR) Ejegg: [C: 2] Fix @returns >> @return phpdoc [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154492 (owner: Addshore) [20:46:11] (Merged) jenkins-bot: Fix @returns >> @return phpdoc [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/154492 (owner: Addshore) [22:46:33] K4-713: ejegg: anytime you have a minute, I have a few questions about CN and card 29 that.. maybe you can help me with? Specifically: I'm looking at making a unified way of displaying campaigns (notices) and using that for both Special:CentralNotice and the campaigns list that I'm adding on banner pages [22:46:45] Does that sound like it makes sense? [22:47:07] It could be a pager [22:47:34] Looking at Special:CentralNotice I see that campaigns are just blurted out no holds bared, I dunno if paging would kill anyone's workflow [22:48:16] seems like a good idea [22:48:22] Hmm... [22:48:35] We should probably talk to CN users before we make changes there. [22:48:59] K [22:49:08] luckily there's a list for that [22:49:10] Just to make sure we're not screwing anybody up more than we're helping them. [22:49:31] And, yes: There is a list for that. :) [22:49:38] It could also be a pager but with no limit, just making it a pager might make it more standard-MW-ish [22:49:40] https://lists.wikimedia.org/mailman/listinfo/centralnotice-admins [22:49:49] AndyRussG: Are you on that list? [22:50:15] K4-713: Ah no, I did hear there was a list and that I should be on it, but then I could find it, thanks jeremyb [22:50:27] and K4-713 and ejegg [22:50:55] I could look into whether making it a pager, even without using the limit function, makes any sense [22:51:42] Fantastic. :) I'd suggest coming up with a couple different options to present to the list, but I think I tend to front-load these conversations more than most, so... up to you how you want to broach the topic, really. [22:52:14] OK [22:53:18] Maybe I can look first at the easiest solution technically that involves the least amount of unsolicited UI changes, and if that might mean easily turning the long list of campaigns into a paged list, then I'll ask about it. Make sense? [22:53:46] easiest cleanish technical solution, I guess I mean [22:54:08] Yep! And to answer the first question, I think you are correct to want to unify the UI. [22:54:23] Cool thanks! [22:55:26] The other thing is that I see in SpecialCentralNotice.php, in the part that builds up the list of campaigns, there's an TODO that says, "TODO: refactor to use Campaign::getCampaigns." [22:55:40] (L337) [22:55:49] AndyRussG: The only thing I want to point out here, though, is that I'd be a little surprised to see too many banners that had more than... two campaigns. [22:55:58] Then again, that's a total wild guess. [22:56:13] Yes I did hear that from awight, probably none have less than 5 [22:56:22] Wonderbanner. [22:56:36] Yeah, that would be... odd. [22:56:37] Fantasticampaign! [22:56:42] :D [22:56:51] So I turn to Campaigns::getCampaigns() and I kinda don't get it [22:57:19] I am unlikely to be terribly helpful there. [22:57:45] Well... more helpful than some other random php dev. [22:57:58] :) [22:58:13] I'm just trying to think if it makes sense to follow that TODO [22:58:23] How old is it? [22:58:28] Ah good quesiton [22:58:43] Also, who said. :) [22:59:27] * AndyRussG checks [23:00:58] * AndyRussG googles gerrit change id [23:01:36] See, this is why I like netbeans so much. [23:01:42] left-click and it's all there. [23:02:25] I got the git log, just can't see who did the exact PS [23:02:52] git blame? [23:02:58] Yes [23:04:02] The TODO was said by awight in August 2013 [23:04:07] https://gerrit.wikimedia.org/r/#/c/78340/ [23:04:39] (Adam's change but Matt uploaded the last PS, so I had to diff the PS's) [23:04:55] In that case, it's relatively likely to be at least moderately helpful advice. :) [23:05:03] Yeah [23:05:36] I mean, what I don't get about that method on Campaigns is that it's a static getObectName method on an object that apparently represents a DB row [23:05:59] But instead of returning a list of objects it returns just a list of ids [23:06:31] And so I don't see how it would be really useful where the TODO appears [23:06:41] But maybe there was a dastardly plan that I'm not yet aware of [23:06:47] Oh, probably. [23:06:50] I mean, there usually is. [23:06:55] heheh [23:07:02] NEway sorry to be long-winded about it, I guess I should just ask Adam [23:07:26] Noooo worries. Ping me whenever. [23:08:53] GAH, python! [23:08:57] (PS1) Ssmith: Add oauth/passportJS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155658 [23:09:02] (CR) jenkins-bot: [V: -1] Add oauth/passportJS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155658 (owner: Ssmith) [23:09:05] K4-713: Watch out for the fangs [23:09:35] marktraceurWMF: Seriously. [23:10:01] ...and the whitespace. [23:10:05] :[ [23:10:44] awight would probably be upset if I re-wrote this entire job in php. [23:10:54] Eh, he'll get over it [23:10:58] K4-713: OK, thanks much! :) I mean also if you have more comments please let me know, again much appreciated [23:11:43] Yeah Python is neat and tidy like a padded cell [23:12:19] Then again, I still can't figure out why people run screaming from XML parsing in php. [23:12:46] Apparently it's icky. [23:12:52] * K4-713 shrugs [23:21:19] Well, they run screaming to the padded cell! [23:23:03] Hah! They totally do. [23:24:10] Too bad it's full of pythons. [23:48:15] :p [23:50:14] (PS4) Ejegg: Transliterate Worldpay post to ISO-8859-1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/155190 [23:50:35] (CR) jenkins-bot: [V: -1] Transliterate Worldpay post to ISO-8859-1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/155190 (owner: Ejegg)