[05:43:34] (PS1) Hoo man: Only register and assign "centralnotice-admin" if needed [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/156077 [05:45:29] (CR) Hoo man: "Untested" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/156077 (owner: Hoo man) [05:46:51] (CR) Alex Monk: [C: -1] "Shouldn't the wgAvailableRights entry stay where it is?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/156077 (owner: Hoo man) [05:49:19] (CR) Hoo man: "Maybe... but why?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/156077 (owner: Hoo man) [10:25:53] (Abandoned) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151840 (owner: Hashar) [16:33:54] (CR) Alex Monk: "Don't things like CentralAuth's global group permissions require it to be on the wiki where rights are being granted from?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/156077 (owner: Hoo man) [16:38:05] (PS1) AndyRussG: WIP Pager for campaigns on campaigns and banner pages [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/156140 [16:39:26] (CR) AndyRussG: "Lines commented out are slated for removal..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/156140 (owner: AndyRussG) [16:43:36] (CR) Ejegg: "The included tests pass with either method, but testing more complex scripts would yield different results. This just means that when we " (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/155190 (owner: Ejegg) [16:44:31] (CR) Hoo man: "I think we do that in another way via configuration as that also works for extensions not deployed on meta (eg. FlaggedRevisions). That's" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/156077 (owner: Hoo man) [17:16:07] (PS3) Awight: WIP device filtering in GlobalAllocation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/63100 [17:16:09] (CR) jenkins-bot: [V: -1] WIP device filtering in GlobalAllocation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/63100 (owner: Awight) [17:16:17] (CR) Awight: "@qgil: thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/63100 (owner: Awight) [17:22:32] (PS1) Ssmith: Add sequelize package and connect to db [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156147 [17:22:39] (CR) jenkins-bot: [V: -1] Add sequelize package and connect to db [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156147 (owner: Ssmith) [17:23:08] (PS4) Awight: Move HTML->plaintext conversion down to Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153422 [17:33:14] (PS1) Awight: Also, support multiple 'to' addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156150 [17:34:43] (PS9) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 [17:35:28] (PS10) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 [17:35:30] (PS2) Awight: Support multiple 'to' addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156150 [17:40:44] (CR) Ejegg: [C: 2] Move HTML->plaintext conversion down to Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153422 (owner: Awight) [17:41:36] (CR) Awight: [C: -1] "I don't understand--PHP emits a warning when the file is missing, not an exception." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/155079 (owner: Ejegg) [17:45:29] (CR) Awight: [C: -1] "Unbalanced element typo, I think." (2 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151137 (owner: Ssmith) [17:47:01] (CR) Awight: [C: 2] "OIC, you fixed in the next patchset." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151137 (owner: Ssmith) [17:48:36] (CR) Awight: [C: 2] "But, don't .gitignore submodules!" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151237 (owner: Ssmith) [17:48:54] (CR) jenkins-bot: [V: -1] Better time period selection panel [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151237 (owner: Ssmith) [17:48:56] (CR) jenkins-bot: [V: -1] Show selected submenus for filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151256 (owner: Ssmith) [17:52:31] (CR) Awight: [C: 2] List filters dynamically [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154310 (owner: Ssmith) [17:52:56] (CR) Awight: [C: 2] Fix checkbox padding [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/153860 (owner: Ssmith) [17:53:15] (CR) jenkins-bot: [V: -1] Better time period selection panel [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151237 (owner: Ssmith) [17:53:17] (CR) jenkins-bot: [V: -1] Show selected submenus for filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151256 (owner: Ssmith) [17:53:19] (CR) jenkins-bot: [V: -1] Fix checkbox padding [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/153860 (owner: Ssmith) [17:53:21] (CR) jenkins-bot: [V: -1] Add timepickers and inform user of selection [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154201 (owner: Ssmith) [17:53:23] (CR) jenkins-bot: [V: -1] List filters dynamically [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154310 (owner: Ssmith) [17:53:25] (CR) jenkins-bot: [V: -1] Parameterize date-picker [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154971 (owner: Ssmith) [17:53:27] (CR) jenkins-bot: [V: -1] Fix widget width [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155299 (owner: Ssmith) [17:53:29] (CR) jenkins-bot: [V: -1] Fix expressJS error with deprecated app configure [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155396 (owner: Ssmith) [17:53:51] (CR) Awight: [V: 2] Better time period selection panel [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151237 (owner: Ssmith) [17:54:41] (CR) Awight: [V: 2] Show selected submenus for filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151256 (owner: Ssmith) [17:56:20] (CR) Awight: [V: 2] Parameterize date-picker [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/154971 (owner: Ssmith) [17:56:37] (CR) Awight: [V: 2] Fix widget width [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155299 (owner: Ssmith) [17:57:34] (CR) Awight: [V: 2] Fix expressJS error with deprecated app configure [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155396 (owner: Ssmith) [18:01:37] (CR) Awight: [C: -1] ""defaults" quibble. Needs a rebase." (3 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156147 (owner: Ssmith) [18:01:41] (PS2) Awight: Add sequelize package and connect to db [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156147 (owner: Ssmith) [18:02:31] (CR) Awight: "Is this a parallel universe?" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/147212 (owner: Ssmith) [18:10:30] (PS6) Awight: Add a grunt linting checker for jshint, jscs, and banana and pass them [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616 (owner: Jforrester) [18:15:55] (PS7) Awight: Add a grunt linting checker for jshint, jscs, and banana and pass them [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616 (owner: Jforrester) [18:18:25] (PS8) Awight: Add a grunt linting checker for jshint, jscs, and banana and pass them [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616 (owner: Jforrester) [18:19:10] (PS1) Ejegg: Add bulk sent mailing import helpers for CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156157 [18:22:06] (PS1) Ejegg: Move CsvBatchFile into wmf_common [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156158 [18:32:56] (PS3) Ssmith: Add oauth/passportJS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155658 [18:33:15] (CR) jenkins-bot: [V: -1] Add oauth/passportJS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155658 (owner: Ssmith) [18:33:57] (CR) Awight: [C: -1] "Some small things mentioned inline..." (10 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156157 (owner: Ejegg) [18:36:23] (PS4) Ssmith: Add oauth/passportJS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155658 [20:07:01] (CR) Awight: [C: 2] "Thanks again!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616 (owner: Jforrester) [20:07:10] (Merged) jenkins-bot: Add a grunt linting checker for jshint, jscs, and banana and pass them [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616 (owner: Jforrester) [20:33:52] AndyRussG: Do you know... if the CN change comment schema change was applied? I thought it was... [20:33:59] I'll schedule a deployment, if u agree [20:36:13] (PS2) Awight: Move CsvBatchFile into wmf_common [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156158 (owner: Ejegg) [20:36:21] (CR) Awight: [C: 2] Move CsvBatchFile into wmf_common [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156158 (owner: Ejegg) [20:42:50] (PS3) Ssmith: Add sequelize package and connect to db [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156147 [20:48:04] AndyRussG: ok yeah: https://bugzilla.wikimedia.org/show_bug.cgi?id=69654 [20:48:12] So I'll go ahead and schedule a CN deployment [20:49:27] hi K4-713! I tried to figure out all the settings for WorldPay testing, but I'm still missing something. Do you think you could get me a copy of the relevant lines from your LocalSettings? [20:49:43] Buh, let me see what I have there. [20:49:50] It may or may not help you at all at this point. [20:49:57] <_< [20:49:58] >_> [20:50:23] i see you, awight [20:50:59] ty for the review on the bulk import stuff [20:51:11] yep, it's looking very solid! [20:51:24] ejegg: Moving this to a secure chat [20:51:44] k4, let me get on direct from my lappy rather than this vps [20:51:53] Sure. [20:52:14] AndyRussG: I'm gonna prepare a merge commit... [21:03:10] awight: just saw your pings... [21:03:40] Ah yeah done! thanks much [21:10:30] (PS1) Ssmith: Fix config file madness [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156187 [21:10:32] (CR) jenkins-bot: [V: -1] Fix config file madness [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156187 (owner: Ssmith) [21:12:31] (PS2) Ssmith: Fix config file madness [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156187 [21:15:00] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/156188 [21:16:21] AndyRussG: Can u review ^^ [21:16:35] AndyRussG: I've scheduled a deployment for 1600 PDT, today [21:17:07] awight: yes and cool thanks (respectively) [21:17:12] rad thx [21:19:06] (CR) Awight: [C: 2] Add oauth/passportJS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/155658 (owner: Ssmith) [21:19:40] (CR) Awight: [C: 2] Add sequelize package and connect to db (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156147 (owner: Ssmith) [21:20:11] (CR) Awight: [C: -1] "Hehe: commit -a, eh?" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/156187 (owner: Ssmith) [21:20:21] hi awight [21:21:13] eileen: How goes it! [21:21:32] ejegg: you've done DonationInterface deployments, right? U might want to do another soon... [21:21:35] not bad - got a baby lamb this morning [21:21:41] O_o [21:21:53] that sounds vaguely biblical or gastronomical [21:22:05] awesome! Enjoy until the slaughter! [21:22:19] well - this one is supposed to not be slaughtered [21:22:23] K4-713 got... guinea pigs over the weekend [21:22:31] oh hehe snack rescue [21:22:37] it gets a long life - unlike some of the others [21:22:47] will you bring it to the office? [21:22:56] the lamb? [21:23:28] yeah (just kidding of course) [21:23:47] awight: Just out of curiosity, what's the background on this patch? I'm looking at the history graph and I see Translaton updater bot doing stuff on several threads [21:24:02] AndyRussG: yeah the merge sucked. [21:24:05] well it's at my office but perhaos not yours [21:24:17] AndyRussG: what happened was, I cherry-picked for the last deploy, so things got confusing [21:24:26] awight: might not be ready for a deploy just yet - the encoding is still looking screwy in error XML coming back, though I haven't had anything go through and show up on the console yet [21:24:40] AndyRussG: For the latest patch, I did a merge, then fixed up by comparing with master [21:24:41] Heh, I'd like an office fit for a litle lamb [21:25:05] ejegg: aha ok then. Maybe we should add a config to turn that off, to prevent accidentally deploying broken [21:25:34] Ahh, we could even make it generic in that case [21:25:44] oooh, interesting [21:26:02] hopefully we will not need, but... payment processors. [21:27:13] AndyRussG - well the lamb is not inside - but just out the window [21:27:19] & office is at home [21:27:39] Ah so pastoral rather than gastronomical or biblical [21:27:42] awight - argh - I went to respond to one of your comments & it disappeared :-( [21:28:06] That sounds really fun tho. I had a small flock of ducks for a while, I would sit with them almost every day. [21:28:12] AndyRussG well we have some that are pastoral but will graduate to gastronomical. But this one gets to be a pet [21:28:39] yeah - enjoying our mini-farm [21:28:57] (lifestyle block they are called over here ) [21:29:23] hehe I keep mishearing "astronomical": http://farm8.static.flickr.com/7034/6453332355_a69b3d411a_m.jpg [21:30:42] :-) [21:30:52] eileen: I doubt my comment was that important. I had some notes in my last email about more stuff we could include in your survey, but that all depends on time [21:31:04] Surely we've burned through the initial contract? [21:31:20] yeah not too far off - I have maybe 3 hours left I think [21:31:47] ok perfect, no worries about expanding the scope, then [21:32:21] Did you have ideas for a conclusion? I was hoping to start converting into concrete task recommendations, but 3 hr would be very tight for that [21:32:42] awight: ejegg K4-713 woops gotta restart [21:33:02] standup? [21:33:04] Also, it's standuptime. [21:33:06] heh. [21:33:26] eileen: sorry, meeting-jacked. Should be back < 15 min [21:33:34] awight -ok [21:47:03] eileen: whew ok back again [21:49:26] awight cool [21:50:22] I guess in terms of concrete recommendations - if the Omnipay library is the way to go then there some steps to convert processors to integrate with that [21:51:04] eileen: mos def. And we'll have to design an extension to cover our additional API [21:51:11] we could get some fairly quick wins in the area of refunds & processing recurring contributions [21:51:20] Those would both be huge [21:51:40] fwiw, we've decided to consolidate all the python auditing code into PHP [21:51:42] & if we go with Omnipay I would probably prototype them in there & look at them WRT core concurrently [21:51:46] nice [21:52:07] verra nice. [21:52:46] Yeah we're still overdue for internal debrief about all this. Unfortunately (for us), the PM is debauching in Nevada for a month [21:52:57] oh right - until when [21:53:14] It's silly. Forever. I think we'll just meet without her. [21:53:23] I have some thoughts about the form - I think Tim's suggestion of doing some pseudocode on it is a good idea [21:53:23] Burning Man, then rehab I think [21:53:31] :-) [21:53:32] Yeah the form would be another huge win area [21:54:34] awight - totten has come too [21:56:41] I think large-granularity boolean toggles will be the cleanest way to control the "universal" donation form template, but... direct debit is a huge exception. [21:56:46] eileen awight: hey [21:56:47] totten - we were just thinking a bit about steps from here [21:57:14] awight - I'd been thinking more about the form returning an array of fields [21:57:32] yes that part makes sense to me [22:01:00] OK - Omnipay-man suggested a getSuggestedFields function on the processor (which I read as a very gentle getRequiredFields) [22:01:27] so it would be like $gateway->setCountry('US'); [22:01:41] $gateway->setCurrency('USD); [22:01:54] hrm. Yeah that approach is problematic though, cos it will be difficult to track changes between components, plus overriding will be nasty. [22:02:17] can you elaborate? [22:02:50] So, rather than components reporting that they support street address / state / country, they simply say "can use address information" or "require address info". [22:03:11] Then, if the site wants to customize by e.g. only asking for City / Country, there is no conflict with other components [22:03:43] yeah - so what I thought about was having a merge [22:06:12] so basically in CiviCRM you can define a billing profile (contact fields only) & that would be merged with the required fields for any processor [22:06:13] to get the fields displayed in the billing block [22:06:17] would you be able to mask fields out by merging? like, street_address=>null ? [22:06:21] OK I should clarify the context here... [22:06:23] So some payment methods (cc) require street and zip. [22:06:24] Some countries require additional contact info [22:06:28] Then, we have a base amount of contact info we're collecting at WMF [22:06:29] This set of fields changes on whim... [22:06:34] at times it's all available address fields for a country, at other times, it's just city and zip... [22:06:44] let me try to pseudocode what I'm thinking [22:06:47] k [22:07:41] Yeah, saying what I'm thinking aloud is proving my idea is full of holes. Country x Processor x Site want to manipulate individual fields, after all... [22:09:40] the trickiest part I think is changing the fields by Country within CiviCRM. You guys decide the country before you pass the person over to the form [22:10:20] eileen: we do. We'll eventually need a special form which allows the donor to change their country, but it would be fine to do a full reload on the page in that case. [22:12:21] ok [22:13:08] Currency is similar, but should if anything be slightly easier to change as the donor. However, it interacts with payment processor selection... [22:16:04] K4-713: can I borrows shank? [22:20:11] awight: As far as I can tell, your merge 156188 looks good [22:20:31] I smoke tested the filter and some of the log comments, working fine [22:21:08] I didn't try to recreate the original merge and actually I'm not extremely familiar with doing that on gerrit 8p [22:21:22] But the result looks fine [22:21:30] AndyRussG: ok, great! [22:21:42] Cool! +2'ing then :) [22:21:44] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/156188 (owner: Awight) [22:21:53] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/156188 (owner: Awight) [22:21:53] oh hehe for some reason I inferred you didn't have +2 [22:22:06] anyway, self-merge is sort of OK for a patch like this... [22:22:52] Oh you're right, heh, I don't even have +1! drat [22:23:41] Or maybe that's cos it merged [22:23:51] yeah I think that's why [22:24:21] I was like, whoa, what level of unpermissions is that that even +1 is vorbotten [22:25:07] Ah OK just checked, I do have +2 on CN [22:25:16] good! [22:25:23] awight: ...I missed something. Who are you stabbing? [22:25:35] (CR) AndyRussG: "Nice! Thanks :)" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/156188 (owner: Awight) [22:25:44] AndyRussG: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_Aug_25th [22:25:52] K4-713: oh just opening a window for better jumping... [22:26:13] pizzzacat1 is complaining she can't get a good running start [22:26:14] Now I just have to work hard to be awarded +3 [22:26:26] oh hehe: not a meritocracy [22:27:20] yeah the window doesn't open wide enough to comfortably jump out of it [22:28:33] Like in Inception? [22:29:28] You'd think once you made the decision to jump, comfort wouldn't really be an issue [22:29:47] awight: cool! is there anything I can or should do? I still haven't watched the deployment indoctrination^D^DI mean training video [22:30:24] that's why I think that's funny [22:30:26] awight totten - I think I was imagining something a bit like https://gist.github.com/eileenmcnaughton/bc40a6eabbb7e8304f09 [22:31:19] marktraceurWMF: au contraire! it's a key 20 seconds, better make it good [22:31:49] Suicide is funny [22:31:52] Quipping. :P [22:32:02] (but not actually) [22:33:36] & having js on the contribution page prevent the standard submit & call a few functions - firstly submitting all fields with a class like 'civicrm-submit' to civi to get the contact & contribution id created, then submitting all fields marked 'billing' to the billing url & replacing them with a token (if it gets a chance) before allowing actual submit to civi [22:35:06] dark humors [22:37:19] eileen: oooh, interesting [22:38:11] eileen: I think we worked around that problem by using an external "contribution tracking" sequence number so that the processor request has a unique ID we can correlate with the contribution later... [22:39:51] yeah - because you guys don't touch civi in real time [22:41:02] Contribution tracking does more than that. It's almost like it gets around this issue as a side-effect. [22:41:27] * K4-713 climbs back into the ground [22:41:32] yeah & I think the extra tracking you guys do would be very much wanted by a lot of people [22:41:54] totten - K4-713 explained that a bit to me last week [22:42:14] I should warn you, I can't really talk much today. [22:42:19] that's cool [22:42:37] But, yeah: That was a useful impromptu session. :) [22:43:00] Yeah - at the moment those notes are just pasted at the bottom of my document :-) [22:46:57] awight - I think if people are interested in going with Omnipay then I would suggest either the mini-roadmap I did for refunds or token processing as a starting point - it allows the chance to work with Omnipay on one processor & get comfortable with how well it will fit while also getting a win. Also it can go in the existing extension without creating a huge amount of extra work if it is to go into core later [22:47:29] and of course we would get a functionality win [23:01:44] eileen: good plan! I have to digest the gist you pasted earlier, I like that the form builder and html builder are decoupled... Not sure at all about profile.getfields a useful way to customize... [23:03:25] well - the profile.getfields function I used already exists which is why I used it [23:04:02] btw, https://gerrit.wikimedia.org/r/#/c/61929/15 is some bizarre stuff I was playing with a while ago. DonationForm/templates is a really basic set of templates, broken into small blocks... [23:04:11] ie. https://github.com/civicrm/civicrm-core/blob/master/api/v3/examples/Profile/GetFields.php [23:04:29] but that's a civi-centric gist - not a generic one [23:05:59] to make it generic the call to get configured fields would need to be hookable by whatever it is installed into [23:06:25] & the metadata structure would be 'owned' by the form builder [23:11:22] AndyRussG: fyi, MaxSem is deploying your CN changes now [23:11:56] awight: cool! (can I watch somewhere?) [23:12:11] #wikimedia-operations [23:13:01] AndyRussG: do you have the CN admin role? [23:13:27] rats, u do not. [23:14:44] AndyRussG: I can do whatever testing you need. I'll create a dummy campaign and banner, and try changing w/ and w/o a comment, to start with. [23:20:44] eileen: i get nervous about having API's which return html [23:21:02] but it may be a matter of terminology/framing [23:21:36] totten - yeah - I guess I'm more thinking in the framework of drupal saying ' html is just one of the ways you can get a form' [23:21:56] yeah [23:22:16] and civi needs a better, medium-independent way to represent a form [23:23:52] yeah [23:26:53] AndyRussG: small bug, comments do not stick when entered in the main campaign table view. [23:26:58] totten - the way that makes most sense to me to accomodate forms is to have them all use js to intercept the submit button so that a)credit cards can be replaced by tokens without them ever hitting civicrm & b) so that a second form can be rendered up on the same page if required (iFrame or transparent redirect) without too much being known upfront [23:27:18] 1) APIv3 -- uses more of a CRUD / SOA-ish architecture. the idea is that downstream devs write their own frontend [23:27:34] awight: whoa very strange [23:27:47] 2) Profiles/webforms -- the idea is that downstream admins can pick-and-choose what elements to include in the frontend [23:27:50] (blurg dicey wifi) [23:28:01] awight: are you sure? It depends on which log view you're looking at [23:28:10] 3) Widget - The idea is to define a set block of HTML/JS that can be reused in different contexts [23:29:08] AndyRussG: I opened the table view, checked "archive" for my dev_test_aw campaign, entered a change summary, then submitted... Looking at the "campaign settings" log view [23:29:36] totten I guess in Civi land api has come to stand for 'something that is tested & won't change between versions' [23:29:52] Just tested locally for enabling a campaign... lemme try archiving [23:30:06] Do other comments work? Can we check that the schema was applied? [23:30:43] Thank you much for testing BTW [23:31:17] eileen: my general preference is to push toward improving #2 (profile/webform/admin-config), but i can see how #3 might be a better match for aligning the code in WMF's frontend with Civi's frontend [23:32:23] eileen: yeah, we tend to get confused by API as "application programming interface [general term]" vs "Civi APIv3 [RESTy/CRUD system]" [23:32:54] totten_: the profile / webform is still going to need a processor dependent widget [23:33:00] awight: blurg, small bug... Yeah locally archiving doesn't generate a message either [23:33:14] awight: wait, I think there was some expected no-op now that I recall [23:33:59] Can you try some other operation on the main campaigns table? Like enabling or testing priority? They both work locally [23:34:19] ok sure [23:35:19] eileen: if we want to use a widget arch to handle the payment fields, then yes - we can put that widget in profiles/webforms/third-party code. that's a cool thing about the widget approach [23:36:03] eileen: but there are other ways to address the problem of dynamic fields (influenced by country vs processor vs site) in the profiles/webforms arch [23:36:26] awight: when you archived the campaign did it generate a log message with no summary? Or no log message? [23:36:34] totten -well the dynamic fields influenced by country + processor [23:36:56] AndyRussG: no log message. Ugh, I'm hitting all kinds of CN bugs. U can't unarchive, but the UI makes it seem possible... [23:36:58] ie. the processor will determine whether the country alters the fields in at least some cases [23:37:34] awight: Yeah I think that's prior to this change... [23:37:47] definitely [23:38:39] AndyRussG: great, yeah other types of edit are logged [23:38:51] Ah cool :) [23:38:58] Lemme check out no log on archiving [23:39:38] AndyRussG: I just made a Mingle card, fwiw [23:43:47] eileen: well, if one implements a widget and decides that the form is strictly a function($country,$processor) -- not function($country,$processor,$site) -- then you're constraining the widget's design so that sites can't influence it [23:43:57] eileen: that may be a good or bad thing -- depending on perspective [23:44:58] awight: I think those weigh in at about 25 cents each [23:45:31] (u said "fwiw") [23:46:08] AndyRussG: hehe I thought you meant, mingle cards. have you heard that we have Fundraising people who want a Mingle account and we can't create them cos of a seat limit? [23:46:20] totten_: yeah - I guess the reason the api takes $params is because then the signature doesn't change. Conversely CiviCRM widgets / js functions do change between versions [23:46:59] hadn't heard that! Maybe I can rent out my ID [23:47:10] lol good luck [23:47:19] there's too much work attached to it already [23:47:34] Heheh I'll just have to wait for a lull [23:47:46] or work towards one [23:47:53] BTW I can't find said card [23:48:03] (mingle latency?) [23:48:31] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/history [23:48:35] 1900 [23:49:15] AndyRussG: woohoo, the deployment scap completed and we have the "Summary" string now. U could announce if you wish... [23:51:18] Ah thanks, got it... [23:51:31] Announce... on the centralnotice admins list? [23:51:37] yah as you please [23:52:04] Did anything else get deployed? Just that + moar better translations by no longer striking volunteer translators? [23:52:24] hehehe that was a mini-scene [23:53:22] yeah still trying to wrap my head around some things [23:56:28] K I'll announce in a bit :) [23:57:44] * jeremyb waves CaitlinVirtue_ ccogdill [23:58:04] did you ever figure out how to login to RT? [23:59:52] Hi jeremyb.. I didn’t, although admittedly I didn’t try very much harder as it seemed it was a question for CaitlinVirtue_