[00:00:09] I think at least three times (probably 9+ months apart), I did something similar and spent minutes shouting at my monitor. [00:00:15] heh [00:00:43] Thank you sir can I have another! [00:00:49] Oh, you got the tests too, huh? Neat. [00:00:52] I'm just going to... [00:01:48] (CR) Katie Horn: [C: 2] "YEEEEEESS." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/156730 (owner: Ejegg) [00:02:06] (Merged) jenkins-bot: Rename GatewayForm to GatewayPage to distinguish from Gateway_Form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/156730 (owner: Ejegg) [00:02:09] woohoo! [00:34:58] (PS13) Awight: (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 [00:41:02] K4-713: ejegg: nudging to coordinate a payments deployment, if u haven't already discussed [00:41:13] ...now? [00:41:24] tomorrow? [00:41:44] Considering somebody has to stick around for at least an hour afterward, that seems preferable. [00:42:01] Any time in particular work for you? [00:42:13] Meh, whatever. Hopefully after 9am PST. [00:42:27] Who's taking this one? [00:42:37] I think I can do it [00:42:47] Have you done one before? [00:42:51] nope! [00:42:55] Ah, fun. [00:42:56] Okay. [00:43:03] But I have done one deploy from that cluster [00:43:07] Another exciting piece of news: check out the red/orange/green lights on the Civi PR wall: https://github.com/civicrm/civicrm-core/pulls Thanks totten! [00:43:27] Huh. [00:43:40] Oh, I get it. :) [00:43:41] oh, cool! Didn't realize github had that sort of build automation [00:44:06] Here come serious improvements in code quality! :p [00:44:19] nice [00:46:24] awight: How are you being notified about mingle changes / did you see my response? [00:46:58] sigh, I was getting emails for @me murmurs [00:47:06] ...? [00:47:09] That's it? [00:47:27] K4-713: ok I see [00:47:47] K4-713: yes I get it. And was kurious because we had talked. But the card doesn't say what we... [00:47:55] Yes it does. [00:47:56] ... [00:48:00] What do you think we decided? [00:48:16] I specifically asked you about the parsing. [00:48:21] Do you want to mention for example that this code is already written?? [00:48:36] In python. [00:48:42] If the point is to port from Python to PHP... that is something to be explicit about? [00:48:58] Why, btw would we want to do what you suggest? [00:48:59] Not sure how that helps for php, and it's sort of... already in the natural location to put the new thing. [00:49:30] ok either way. Apparently something I did not catch this morning [00:49:35] gah. Okay. Because the nightly audit workflow, that needs to share code with civi import / checking things, is in php. [00:50:12] This approach was exactly what I was... [00:50:14] OK So you want to add... log parsing. and port. and call wmf_civicrm directly rather than queueing [00:50:17] okok [00:50:26] No, not necessarily. [00:50:31] ...with the last part. [00:50:47] The point with this is to standardize on one codebase. [00:50:51] I guess we have to start somewhere. [00:51:08] Well, we need WP for france before October. So, it's here. [00:51:26] And, since I usually choose to work in a linear fashion, the first thing I have to do is parse the input. [00:51:52] Instead of "Add WorldPay nightly reconciliation file parsing ability to fr-tools repo" I would say "Port WP parsing from fr-tools to crm repo" [00:52:10] Okay, I'll change it. [00:52:15] Now that I've like triple-checked what is actually going on, I don't care what the card sez [00:52:24] I honestly wasn't thinking too hard about card names. [00:52:31] Hah you've seen the cruft I generate [00:52:34] ...because it's in conjunction with the next two. [00:52:37] Maybe I'm inspiring [00:52:58] I guess that's only obvious if you look from the spike that says "figure out WTF to do." [00:53:22] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1884 [00:53:30] I'll cross-link, I guess. [00:53:58] I was only thinking that if someone who was not part of our conversation sees the old card title, they will think we're snmoking it... [00:54:13] *which is not the case.* [00:54:16] :p [00:54:58] Sorry I'm all warped from dealing with Civi hooks. I just had to write two completely different types of hook implementation, cos one needed custom field values. /hara-kiri [00:55:44] You cannot get custom values from base object hooks. So I had to write a hook on the custom data (thx, eileen!) then retrieve the base object from within the hook. [00:56:23] WOOT there is really nothing at all left in queue2civicrm. [00:57:09] huh. Nothing at all? [00:57:16] Great. Now I will not know where anything is. [00:57:22] I mean, more than usual. [00:57:29] I have the way it was, like, a year ago in my head. [00:57:41] I pop open the base file and just blink at it for 7 minutes. [00:59:22] hehe. yeah it's a tiny bit of cruft we can discard, plus this line: [00:59:25] $contribution = wmf_civicrm_contribution_message_import($msg); [01:00:01] dang [01:00:03] Of course, I ended up making ^ that function way too complicated, but... temporary... I hope [01:00:16] Everything is temporary. [01:00:46] Yes but some things are built of really heavy and fragile imaginary bricks. [01:01:31] Yes. Yes they are. [01:01:34] ... [01:01:46] Wouldn't it be funny if everybody stopped using credit cards next year? [01:02:01] I mean, I'd laugh. [01:02:08] Just charge it straight to my life [01:03:58] I think the DonationInterface form situation and audit-sprawl are the last *really* bad legacy things to fix. [01:04:04] I must be dreaming. [01:04:10] Don't wake up. [01:04:14] DO NOT. [01:04:15] baahaha [01:04:16] :D [01:04:21] once I shuffle off this mortal coil [01:04:28] abre los ojos... [01:04:34] Man, it's getting weird in here. [01:04:51] * awight is sort of proud of single-handedly weirding it up [01:05:03] I'd like to think I helped a little. [01:05:17] yes as the sane foil [01:05:19] With the... you know, transience of existence type thoughts. [01:05:56] where's the 'fun' in existentialism... It's all Knight of resignation. [01:06:12] Maybe we can get the fun back in 'draising by all adopting FUNdaMENTALism [01:06:23] Or, the... mental? [01:06:27] It *must* be true. See, it's written here. [01:07:11] K4-713: Can I ask about the choice of repo? IMO we should push audit stuff into DonationInterface [01:07:28] ...really? [01:07:31] yah [01:07:35] Huh. [01:07:38] just to circle our ducks [01:07:50] I mean, that's where everything but Listeners live [01:07:51] * awight dies [01:08:01] oh oh reality is slowly coming back to me [01:08:02] So, in my head, donation interface is on a completely different planet. [01:08:02] it hurts. [01:08:11] At the very least, they are at opposite ends of the pipe. [01:08:24] But we make... API calls [01:08:30] also, DI is available to Civi [01:08:32] No we don't. [01:08:36] Not at that stage. [01:08:37] erhm [01:08:41] Nobody has one that would help us. [01:08:45] hehe yes in amazon and PP audit I believe [01:08:45] ...at that stage. [01:08:55] er... when? [01:09:00] * awight githubs [01:09:03] wat [01:09:10] Why with all the github? [01:09:13] :p [01:09:21] you want me to use that janky git.wmo site? [01:09:31] Yes? [01:09:33] :p [01:09:36] so... unnavigable [01:09:52] we have apparently not discovered... alphabetical order yet [01:10:08] and the number of repos displayed is randomly truncated at some smallish number. it's just awful [01:10:22] That's okay. I never want to see all of them anyway. [01:10:44] https://github.com/wikimedia/wikimedia-fundraising-tools/blob/master/AmazonAudit/amazon-audit.py#L49 [01:10:47] ...but that might just be the terrible ajax talking. [01:10:47] lol [01:11:12] One day they're gonna Clockwork Orange us and force us to watch films of all the bad things Fundraising has done [01:11:31] How is that not our lives already? [01:11:40] I thought that's called "bugfixes" [01:11:44] https://github.com/wikimedia/wikimedia-fundraising-tools/blob/master/audit/paypal/TrrFile.py#L158 [01:12:00] Okay, so... great. Do we know that these requests aren't costing us money? [01:12:07] blargh [01:12:12] Also, we can't be doing this now, because github. [01:12:18] * awight tries to reset so I can do evil coding again [01:12:23] eh? [01:12:37] If we can deploy from github, I missed a hell of a meeting. [01:12:41] oh [01:12:42] no [01:12:47] But this is the latest code [01:13:05] b... [01:13:15] For a lot of repos, you can even produce PRs in github and they are mirrored back into gerrit, afaik [01:13:25] s/a lot/indeterminate damage/ [01:13:43] I'm becoming extremely nervous. [01:13:52] you are right. [01:14:14] ...mostly because I haven't written a single line of code today, and this has a pretty hard deadline. [01:14:27] I love knowing where we're going. I really do. [01:14:30] * awight disappears into card 1847 [01:15:04] * awight kicks phantom of strategy meeting for special higher-ups, with no minutes published [01:15:09] <_< [01:15:10] >_> [01:15:15] ooooooooo. [01:15:26] I'm telling. [01:15:39] (I'm not. But I probably don't have to) [01:15:57] * awight considers nicks who might expect this of me [01:16:19] All I really care about though is: where was the leftovers of desert? [01:16:22] dessert. [01:16:26] FOR REAL THOUGH. [01:16:27] ah jesus [01:16:54] The homeless guy outside is asking. [01:17:05] OKOK buddy, enough beans. Where's the pie. [01:17:27] I was thinking cake soaked in alcohol. [01:18:13] * awight looks up coordinates to venue and grumbles some more [01:18:20] WHAT IS THAT CRAP [01:18:22] Also... who does fixed width reporting with PAIRS of lines? [01:18:32] OK /me dies further [01:18:33] I could just... [01:18:52] ...you know what? I'm not going to get anything else done from here today other than more grumbling. [01:18:58] Apparently not even dessert. [01:19:04] Rip. Off. [16:19:14] PPena: Hey, good morning! [16:20:03] * K4-713 waves at ejegg [16:20:10] hi K4! [16:20:43] I don't really have anything more interesting than "good morning". [16:21:14] me neither just yet [16:21:28] some time today we should deploy DonationInterface though [16:21:45] Or, as I like to say to Jeff: "Good aftermath". Takes care of timezone greeting discrepancies. :) [16:21:51] Yeah, deploying things. [16:21:52] Right. [16:21:54] I'll see if I can work out what changes to pull in [16:22:25] Okay, so... usually I just take whatever's in master, unless there's some shiny reason to pick around something. [16:22:34] I don't... *think* there is right now... [16:22:43] But always good to double-check. [16:23:01] oh, cool [16:23:13] In general, if it's not something tied to a mingle "ready to deploy" card, it's worth some follow-up questions. [16:24:44] ejegg: Have you had to deal with my irritating policy of not deploying any tests yet? [16:24:52] huh, cherry -v lists a whole lot, but it might be misleading [16:25:02] no, but that makes sense [16:25:15] reducing potential attack surface and all [16:25:58] Well, yeah, and it's less likely for us to do something abysmally stupid. [16:26:06] Mostly I'm worried about myself. :) [16:26:39] Do you want to take a look at the output of git cherry -v origin/deploy-payments_1.22 origin/master | grep + [16:26:47] and let me know what you think? [16:27:04] Some of those are pretty old and seem like they must be deployed [16:27:18] Sure, wait 1. [16:27:32] no rush [16:27:36] I've got to fetch the world and stuff. [16:28:12] ...oooh. I just remembered something. [16:28:13] righto [16:28:39] oh, i should just look at the file diff to get the real story [16:28:40] I've got some uncommitted garbage on my local because i18n changes cause translator work to happen IRL. [16:28:56] ...even if it's in an irrelevant branch. [16:29:13] oh, they don't just do master, huh? [16:29:55] So, my sanity check is usually to fetch and fast-forward everything locally, and then git diff --name-status master..deploy_payments [16:30:06] If anything but tests show up, something has been left out. [16:30:16] ah, thanks! was just trying to figure out that command line [16:30:37] 'course, the branches you reference should be the local and updated ones you use to track what's in gerrit. [16:30:48] Tabcomplete works for that, for some reason. [16:31:01] K4-713 hi! Sorry, just saw this now [16:31:17] K4-713 goooood morning :) [16:31:39] PPena: No worries! I just wanted to let you know, I sorted out the pressing Worldpay stuff with awight's help last night, so no need for a call in the near-term. [16:39:11] K4-713: so, merge in master, delete tests/, test hook & .jshint-type-stuff, revert .gitignore and .gitreview changes [16:39:18] missing any steps? [16:40:00] Huh. I don't think I had to mess with .jslint / .gitignore / .gitreview on merge before. [16:40:13] But my checkout is allegedly haunted. [16:40:13] yeah, those might be new [16:40:37] Usually I only have to kill off the tests. [16:40:42] there are a bunch of js style tweaks which I assume are related [16:40:55] Er... like what? [16:41:03] well, the jslint stuff [16:41:07] Oh, doy. [16:41:10] wait, let me see [16:41:21] It's been a while since the last payments deploy, hasn't it? [16:41:30] I think it was before I left for Ireland. [16:41:37] more than a month, yeah [16:42:09] the jschanges are mostly whitespace, some == / ===, etc [16:43:01] gitreview just points to a diff branch, and deploy gitignore ignores tests [16:43:09] aye [16:43:10] Okay. [16:43:24] Yeah, we want all the js if it's actually *in* DI. [16:43:33] cool [16:43:45] ...as opposed to, you know, git cruft. [16:43:54] right [16:55:53] K4-713 I got a call scheduled for today- do you want to be in? [16:56:09] K4-713 or do you need literally nothing from them?:) [16:56:17] I don't need anything at the moment. [16:56:38] Eventually, I will want to know if I can turn off that giant pile of reports that do not help us, *at all*. [16:56:48] ...unless I can think of some reason they would help. [16:56:54] So, I'm not even sure about that part. [16:57:06] I mean, presumably, if they're bothering to generate them, somebody finds them useful... [16:57:09] * K4-713 fidgets [17:01:28] ejegg: There's a good chance we'll need to do another payments deploy today. [17:01:35] ...once I write a patch. [17:01:43] oh, ok. [17:01:54] Should I hold off on this merge then? [17:01:55] But, don't let that stop you from getting this round out. [17:02:00] No, do it. [17:02:01] OK, cool [17:02:06] This isn't... actually that odd. [17:02:14] Well, maybe it is these days. [17:09:47] git's gotta be a little confused: "Your branch is ahead of 'origin/deploy-payments_1.22' by 1075 commits." [17:12:37] bah. git review is actually trying to push screenfuls of separate commits instead of just one merge [17:13:19] ! [17:13:30] 1075 commits, huh? [17:13:37] ...you guys were busy while I was on vacation. :p [17:14:29] hah! not that busy [17:14:59] I checked out deploy-payments_1.22 [17:15:13] did a merge -X theirs master [17:15:46] it complained of deleted/modified conflicts in tests/ but did the rest of the merge [17:16:51] I deleted tests, removed hook and reset branch in .gitreview, and committed with a plain old "git commit" [17:17:28] the comments bit of the message noted that i was likely committing a merge, and to delete MERGE_HEAD or somesuch if I didn't want to [17:17:37] but I thought that was how it was supposed to go [17:18:14] ohh man Chester McDefault [17:18:20] ejegg: I'm not sure I'm going to be tremendously helpful with the git merge advice. I have only merged master into deploy, like, once. The rest of the time I'm cherry-picking. [17:18:22] Hurm. [17:18:34] dang [17:18:39] I'm really beginning to hate Thursdays. [17:19:16] i'll see if the googles have any advice [17:19:44] ejegg this is how you feel when you cherry pick http://gph.is/1glgA2H [17:20:06] pizzzacat1: That's why I do it. [17:20:07] smoove [17:20:36] why would anyone choose any other way [17:20:48] also why does IRC always hate me [17:21:11] only 'cos after a merge git will stop being confused about which patches are still outstanding [17:22:29] ejegg: Was it seriously going to have 1000+ patch sets? [17:23:11] i ran out of scrollback [17:23:25] but yeah, looked like it [17:23:43] Any clues about what exactly it thought they all were? [17:23:55] like, everything ever [17:24:24] all the way back to "(documentation-2012-05-18-1800) Updated documentation" [17:24:24] * K4-713 squints [17:24:31] Ha, that never happened. [17:24:33] :D [17:24:47] hmph [17:28:11] (PS1) Katie Horn: Changing the default donor name to something less odd. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156819 [17:28:34] the-wub: ...you can +2 in the crm repo, yeah? [17:29:20] I think we're going to try to see if we can simultaneously break everything. [17:30:01] http://media.tumblr.com/55e743a6c14ecf989ac7a8f744e58582/tumblr_inline_n6wr5jzuqb1s9nclc.gif [17:31:17] K4-713: yeah, IIRC I can. for some reason :P [17:31:44] * K4-713 mumbles something about payments forms, looks uncertain [17:32:34] the-wub: This one should be totally simple anyway: https://gerrit.wikimedia.org/r/156819 [17:35:55] (CR) Pcoombe: [C: 2] Changing the default donor name to something less odd. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156819 (owner: Katie Horn) [17:36:33] K4-713: done :) [17:36:39] Okay, let me get this out. [17:36:58] ejegg: I need to deploy an emergency patch to the crm. [17:37:02] srry for the delay, my internet connection is incredibly shitty atm [17:37:13] ejegg: ...which has nothing to do with what you're doing on payments. [17:37:19] cool, that shouldn't be too crazy, right? [17:37:24] the-wub: No worries! [17:37:32] ejegg: I eat crazy for breakfast. [17:37:44] ...but I skipped it today. [17:37:48] :/ [17:38:09] speaking of insanity, i'm trying to redo the merge and see if I get different results [17:38:23] Yeah, that... helps sometimes for reasons that are maddening. [17:44:56] Okay: Here we go with a civi deploy. [17:45:00] Should be trivial... [17:46:38] Building qc to check. [17:46:54] ...no messages. [17:46:58] Somebody donate something. :p [17:47:22] Preferably with no name. [17:54:30] K4-713: Lila meeting upstairs? [17:54:42] Yeah... I'm in a good place here for the moment. [17:54:44] phooey and double phooey. I can get it down to a single patch to submit by zapping .git/MERGE_HEAD before I commit, but then the log is missing all the merged commits. Is there seriously no way to get the history synced without reviewing every single patch? [17:54:46] * pizzzacat hasn't read things blowing up [17:54:55] ok cool [17:55:08] ejegg: Oh, actually that's normal, and (for some) desired behavior. [17:55:15] As long as it's not 1000+ patches long. [17:55:25] That's an error/problem. [17:55:51] ...going to go to a thing now, though... hopefully brb unless the wireless has a seizure. [18:01:59] Woo, okay. [18:02:01] I'm here for the time being. [18:02:12] NOBODY PANIC I AM HERE. :p [18:05:32] ejegg: Yeah, so... there being a new patch for every commit in the deploy branch as well as in master, isn't actually wrong. [18:06:07] You just have to +2 the deploy stuff and say "deploy". Which is only ever okay when you're deploying. [18:06:53] OK, I was just hoping to get around having to do that 1000 times [18:07:23] 1000 is too many. [18:07:35] There should be, at most, one for each thing that wasn't already over htere. [18:08:01] OK, I think that's what I'll get if I cherry-pick in everything since the last deploy [18:08:17] let's try this a 3rd time! [18:08:31] (while I wait for the youtube stream) [18:08:48] You going to bail out on the merge? [18:08:55] ...incidentally, I'm totally fine with that. [18:10:05] awight can explain how we're both silly tomorrow. [18:16:53] ejegg: Are you totally absorbed in the meeting thingy, or are you still doing merge stuff? [18:19:12] half and half [18:20:01] Okay. I'll give you one eyeball. :) [18:38:48] ahh, we didn't merge in that maintenance mode switch simplification yet? [18:38:56] OK to do so for this deploy? [18:39:11] er... we should have. [18:39:14] Yep. [18:39:29] Just, you know: Make sure any globals you need are there. [18:39:34] ...in LocalSettings [18:39:38] or the secret one. [18:39:46] yeah, that changed re-used the same globals [18:39:56] Where is the mingle card for that one? Does it say deployed? [18:40:10] let me check. I think it wasn't even merged into master till lately [18:40:13] If so, somebody gets 10 minutes in the box. [18:40:15] Oh, ha. [18:40:23] Well, in that case, it makes sense. [18:40:41] yeah, still in the pending column [18:40:50] okay, cool. I mean: Kind of. [18:41:06] I think a lot happened, in a month. [18:41:19] Actually, the fact that it's been like a month since the last deploy, is... astonishing. [18:41:29] That never used to happen. [18:59:46] aaaargh - gerrit's complaining all the changes are closed. guess i need to regenerate change ids on each commit i cherry picked? [19:00:48] wat. OH, that. [19:01:10] er... how many of these changes have... removed tests? [19:01:26] most of the non-translation ones [19:01:37] Yeah, those you have to whack the change ID. [19:01:49] ok, here goes another round... [19:02:58] How close are you to pulling the trigger, do you think? [19:03:02] Do I have time to get food? [19:03:07] sure, go for it [19:03:16] I'd like to be around when you blast, at the very least. [19:03:29] So, you know: Wait for me to show up again. :) [19:03:33] for sure, i'll wait for your word [19:05:48] (PS1) Ejegg: Cleaning up the payments error logs [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156844 [19:05:50] (PS1) Ejegg: Fix @covers code coverage annotation [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156845 [19:05:52] (PS1) Ejegg: Move gateway form logic from execute to handleRequest [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156846 [19:05:54] (PS1) Ejegg: Simplify fundraising maintenance mode [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156847 [19:05:56] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156848 [19:05:58] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156849 [19:06:00] (PS1) Ejegg: Remove usage of deprecated Xml::escapeJsString [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156850 [19:06:02] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156851 [19:06:04] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156852 [19:06:06] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156853 [19:06:08] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156854 [19:06:10] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156855 [19:06:12] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156856 [19:06:14] (PS1) Ejegg: Add 'id' and 'for' attributes to WorldPay form labels [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156857 [19:06:16] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156858 [19:06:18] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156859 [19:06:20] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156860 [19:06:22] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156861 [19:06:24] (PS1) Ejegg: WorldPay: Put stripped email in MerchantReference2 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156862 [19:06:26] (PS1) Ejegg: Fix @returns >> @return phpdoc [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156863 [19:06:28] (PS1) Ejegg: Use public instead of var in classes [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156864 [19:06:30] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156865 [19:06:32] (PS1) Ejegg: Transliterate Worldpay post to ISO-8859-1 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156866 [19:06:34] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156867 [19:06:36] (PS1) Ejegg: Add a grunt linting checker for jshint, jscs, and banana and pass them [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156868 [19:06:38] (PS1) Ejegg: kill remaining calls to extract() [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156869 [19:06:40] (PS1) Ejegg: Follow-up Ib0d0f6c: Fix qqq typos [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156870 [19:06:42] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156871 [19:06:44] (PS1) Ejegg: one more extract to yank [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156872 [19:06:46] (PS1) Ejegg: Rename GatewayForm to GatewayPage to distinguish from Gateway_Form [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156873 [19:06:50] (CR) jenkins-bot: [V: -1] Cleaning up the payments error logs [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156844 (owner: Ejegg) [19:06:52] (CR) jenkins-bot: [V: -1] Fix @covers code coverage annotation [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156845 (owner: Ejegg) [19:06:54] (CR) jenkins-bot: [V: -1] Move gateway form logic from execute to handleRequest [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156846 (owner: Ejegg) [19:06:56] (CR) jenkins-bot: [V: -1] Simplify fundraising maintenance mode [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156847 (owner: Ejegg) [19:06:58] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156848 (owner: Ejegg) [19:07:00] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156849 (owner: Ejegg) [19:07:02] (CR) jenkins-bot: [V: -1] Remove usage of deprecated Xml::escapeJsString [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/156850 (owner: Ejegg) [19:07:04]