[01:36:29] seriously? lunch? [01:36:33] that must be wrong [01:36:36] :P [20:37:40] (PS1) Ejegg: Import sent mailings from Silverpop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/157968 [20:37:46] (CR) jenkins-bot: [V: -1] Import sent mailings from Silverpop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/157968 (owner: Ejegg) [20:39:18] (PS2) Ejegg: Import sent mailings from Silverpop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/157968 [22:02:45] ...helps if I don't get disconnected after asking a question. [22:03:17] what did you ask? [22:03:49] I was just asking caitlin if anything interesting happened this morning. [22:04:01] There was an email about... webmoney? [22:04:03] ah, word [22:04:16] oh, what is that? [22:04:22] Brokenness? [22:04:24] :p [22:04:51] This is something GlobalCollect does for us? [22:05:09] Yep. [22:05:31] huh, new to me! [22:06:00] There are *so many* weird payment methods they handle. [22:06:20] I'm not even sure when the last time was that we cared about that one... [22:06:21] how do we even test stuff like webmoney? Do you have an account? [22:06:27] :/ [22:07:32] I do not have a webmoney test account. And, there are a ton of small payment types for which we ask for test accounts and they either say "A what account?" or "a test what?" [22:07:41] oh man [22:07:58] Even better when we can't get a real account because it's in a locality where nobody has a bank account. [22:08:04] so basically we wait for people to try it in real life [22:08:17] That would be the only remaining option, yes. [22:09:07] Usually what that looks like is we take it as far as we can, and then start asking people in those areas to test for us with real accounts. [22:09:37] makes sense [22:14:11] ooh, I should check out that FR worldpay form failure. [22:14:18] Ah, good idea. [22:34:24] Do we need to gather and submit the country to WorldPay? [22:34:49] The personal-information block for non-US has no 'county' input, hidden or otherwise [22:35:04] and the input validation js is breaking because of that [22:35:18] not sure if i should update the js or the form [22:51:17] ejegg: Sorry, just saw this. [22:51:23] Country should always be present. [22:51:51] ...but that's not the only thing we assume is there on all forms, and this makes me worry about the other ones as well. [22:52:36] ok, let me see if I can figure out how it disappeared [22:52:45] Cool. [22:53:45] It's probably incredibly rare for it to be... not a hidden element. [22:54:07] I'm also poking around for a more comprehensive list. Starting in RapidHTML. [22:54:21] list of countries? [22:54:43] Nope. List of required fields that should be added as hidden elements if they're not in the visible form. [22:54:58] ah, right [22:55:53] aaaaaAAAHA. [22:56:02] found it? [22:56:15] I found the thing I remembered being useful. [22:56:28] Whether or not we actually *use* it... [22:56:55] found the commit that removed the address fields [22:56:58] (looks like no, but it's still a good guide, and the fact that I never nuked this function tells me that I had hope we'd use it someday...) [22:57:40] DonationInterface/gateway_forms/Form.php, line 472: setHiddenFields function. [22:57:59] Actually... at least one field in there is bogus. [22:58:01] :[ [22:58:32] d'oh! [22:58:44] aaaaaaand it's missing country. [22:58:54] yeppers [22:58:54] ...just kidding. [22:59:19] "Hey, look at this totally useless thing I found!" [22:59:49] So, add country back to the non-US form as a hidden element? Looks like it used to be a dropdown [23:00:04] It's... not always anything, but it is required. [23:00:10] I'd add as hidden. [23:00:18] OK, cool [23:00:41] It's possible it was a dropdown in WP because we were essentially in testing mode. [23:00:50] ahh [23:00:57] Does the commit that takes it out, say anything about it? [23:01:12] yeah, ' ~Address fields removed for FR [23:01:13] ' [23:01:28] change id Ie3d91a208454389212ec5958baa3dc648159927f [23:01:29] Sounds deliberate. [23:01:33] :) [23:02:10] should there be an FR-specific personal info block? This is in default.html [23:02:40] Usually all the hidden things are not inline with the rest of the form. [23:03:30] Let me find something relevant in GC. [23:04:30] seem to be inside display:none divs [23:04:37] Huh. Okay, I'm lying again. Or, more likely, describing 2011. [23:05:10] And, yeah: That seems to be everything I'm finding in GC. [23:05:28] Only, they're hidden TRs. [23:05:35] * K4-713 squints [23:06:58] ejegg: When you fix this, would you add a form test? [23:07:09] sure [23:07:40] Cool. [23:08:14] ah, looks like we have one for WP/FR - I'll just add country to the assert_nodes [23:08:29] Yay! [23:10:07] (PS1) Ejegg: Add country hidden field back to non-US WorldPay form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/158017 [23:42:04] how is RT 7599 different from fredge? [23:42:11] is it running still?