[16:02:59] <grrrit-wm>	 (PS2) Ejegg: Update package.json [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/158788 (owner: Ssmith)
[16:05:33] <grrrit-wm>	 (CR) Ejegg: [C: 2] Update package.json [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/158788 (owner: Ssmith)
[16:46:38] <atgo>	 hey jessicarobell!
[16:47:01] <jessicarobell>	 hey atgo! Welcome back!
[16:47:06] <atgo>	 thanks :)
[16:47:23] <atgo>	 do you know when that dutch donation with the wrong TY language happened?
[16:47:28] <atgo>	 i am trying to look through some logs
[16:48:45] <jessicarobell>	 Ok thanks. As far as I know, on September 3rd. Sometime in the afternoon/evening UTC time.
[16:48:59] <atgo>	 ok... i don't think i can get to it remotely
[16:49:05] <atgo>	 i didn't know this, but apparently the GC console IP blocks
[16:49:19] <jessicarobell>	 Do you want to wait and ask her to confirm the exact time before you start digging?
[16:49:38] <atgo>	 i don't think i can actually find it the way i was hoping i could, but ccogdill probably can through the console
[16:50:08] <ccogdill>	 I can look in a minute
[16:51:11] <jessicarobell>	 ah ok. It's not urgent as it seems that the Dutch letter is actually going out and we are not getting a bunch of complains. I am just worried this might be an iDEAL thing and we might start receiving more complains as iDEAL donations settle in which cause we'd want  to do something about this asap.
[16:51:19] <jessicarobell>	 thanks for checking ccogdill
[16:52:19] <jessicarobell>	 *complaints *case. sorry, writing too fast..
[16:53:42] <ccogdill>	 GC shows she came from an English page, jessicarobell
[16:53:59] <ccogdill>	 I know we have heard from Dutch iDEAL donors and they have gotten correct TY letters
[16:54:08] <ccogdill>	 this looks like an isolated incident to me
[16:54:19] <jessicarobell>	 hah. well, that's reassuring. thanks for checking ccogdill!
[16:54:38] <jessicarobell>	 thanks atgo
[16:54:55] <atgo>	 thanks guys :)
[16:55:01] <ccogdill>	 no worries
[17:00:46] <atgo>	 hey ejegg! where are you working from these days? :)
[17:01:07] <ejegg>	 right now, i'm at home, but I often work out of the library in Cambridge
[17:01:23] <ejegg>	 they just rebuilt the main branch a couple years ago, and it's gorgeous
[17:04:21] <atgo>	 cool ejegg - which one is that?
[17:05:06] <ejegg>	 it's near Harvard Square, on Broadway. http://www.cambridgema.gov/cpl/hoursandlocations/mainlibrary.aspx
[17:22:15] <atgo>	 shoot it's later than i thought! think you'll be over there tomorrow?
[17:29:52] <pizzzacat>	 that thing when you're wrestling a bug for 2 hours on friday and you leave frustrated and then you figure it out within 2 minutes on monday morning because it's obvious
[17:31:07] <awight>	 jealous.  I usually think a bug is trivial on Friday, then on Monday realize there are all manner of reasons I'll never be able to fix it.
[17:32:24] <pizzzacat>	 :(
[17:33:02] <pizzzacat>	 this happens to me a lot. usually at the end of the day I can't fix bugs. I wonder how to optimize this... because bugs don't care what time it is
[17:33:42] <awight>	 pizzzacat: try working on something != bugs in the afternoon?
[17:33:44] <awight>	 doodling...
[17:33:47] <awight>	 chatting
[17:33:50] <awight>	 aka "planning"
[17:36:22] <pizzzacat>	 ha yeah. probably good to just get to coding in the morning so planning what to do for the next day, late in the previous day, is probably wisest
[17:38:28] <awight>	 Sometimes I like to get unreasonably frustrated in the afternoon, though, spend a lot of time pounding my temples and the communal table, then eat a bunch of snacks and fart circles around people.
[17:41:50] <AndyRussG>	 Hi everyone :) happy Monday
[17:42:13] <AndyRussG>	 awight: yeah ventilation in my work space is important for me too :)
[17:42:27] <awight>	 Hopefuly no non-remote people take my advice...
[17:42:54] <AndyRussG>	 I'm a bit scared to ask other WMFers in Montreal about co-working...
[17:43:10] <AndyRussG>	 BTW I have a new algorithm for GlobalAlloc
[17:43:42] <AndyRussG>	 I'm 99% sure it'll work groovy. Do you want me to run it by you or shall I just code it up (should be quick)?
[17:43:56] <AndyRussG>	 awight: ^
[17:44:41] <awight>	 AndyRussG: oh, cool!
[17:44:48] <awight>	 Yeah I'd love to hear the plan
[17:45:01] <awight>	 a call at your leisure?
[17:45:02] <ejegg>	 atgo: I think I'll be there tomorrow.  I messed up my back Saturday, so I'm not sure if I'll be biking around again yet.
[17:45:10] <awight>	 aww
[17:45:21] <awight>	 slacklining kills...
[17:45:36] <ejegg>	 heh, i wish it was something fun.  just helping move furniture
[17:45:58] <awight>	 gettin soft at your desk job :p
[17:46:23] <ejegg>	 36th birthday present from life
[17:46:48] <awight>	 hah & u don't even qualify for reduced rates on the bus yet.
[17:47:09] <ejegg>	 been feeling like i should these last 2 days!
[17:48:14] <awight>	 ejegg: oh, I finally remembered the name of the stupid data transformation standard: http://www.omg.org/spec/QVT/1.1/PDF/
[17:48:23] <AndyRussG>	 awight: sure! when would be good for you?
[17:48:28] <awight>	 Pretty interesting read, IMO, with a small number of takeaways
[17:48:32] <awight>	 AndyRussG: any time
[17:48:34] <AndyRussG>	 ejegg: hope your back gets better
[17:48:39] <ejegg>	 ty
[17:48:46] <ejegg>	 awight: very meta
[17:49:19] <awight>	 hehe for some reason I'm reminded of the chiropracter's office down the road, with the "0 accidents at this intersection" sign I saw them taking down in a pool of broken safety glass one day...
[17:49:19] <AndyRussG>	 awight: K, how about in 20 minutes (i.e. after the more coffee's caffine kicks in) ?
[17:49:23] <awight>	 perfect!
[17:49:31] <ejegg>	 hah
[17:49:32] <AndyRussG>	 K sounds good
[17:54:08] <pizzzacat>	 ejegg I've confirmed that the Dash master is good to go
[17:54:45] <pizzzacat>	 we talked about figuring out what outstanding patches there are but it looks like everything is merged, if I'm understanding gerrit correctly
[17:54:45] <ejegg>	 pizzzacat: awesome!  I'll check it out.  What db name does it try to hit now?
[17:54:46] <pizzzacat>	 https://gerrit.wikimedia.org/r/#/q/project:wikimedia/fundraising/dash,p,002e788700023da6
[17:54:57] <pizzzacat>	 and it's not out of the question that I'm not
[17:55:09] <pizzzacat>	 db name?
[17:55:19] <pizzzacat>	 was there an issue with that?
[17:55:34] <ejegg>	 I can run it, but it's looking to hit a local db that I don't hae set up yet
[17:55:47] <ejegg>	 Can find in source
[17:55:48] <pizzzacat>	 oh, I see. I did a dump on fredge
[17:55:54] <ejegg>	 oh, ok.  thanks!
[17:55:55] <pizzzacat>	 on lutetium
[17:56:05] <pizzzacat>	 the rest of the infos are in the defaults.js file
[17:56:13] <pizzzacat>	 np!
[17:56:16] <ejegg>	 ahh, good to know.
[17:56:46] <pizzzacat>	 I should maybe add that info to the README
[17:56:48] <ejegg>	 I did have to do a rebase on the package.json patch set, so you may want to pull --rebase before you get into more development
[17:56:59] <pizzzacat>	 oh?
[17:57:15] <pizzzacat>	 so git pull --rebase on master?
[17:57:18] <ejegg>	 it was based on an older 'add fredge table models' patchset than the one that got merged
[17:57:24] <ejegg>	 I think so..
[17:57:36] <pizzzacat>	 I did submit a new patch for that file
[17:57:39] <pizzzacat>	 on Friday
[17:57:51] <pizzzacat>	 dunno if there's overlap?
[17:58:03] <ejegg>	 hmm, let me take a look in gerrit
[17:58:37] <pizzzacat>	 awight IRL 2 seconds?
[18:00:16] <ejegg>	 oh, looks like awight rebased the fredge tables commit before +2ing it
[18:00:37] <awight>	 haarr
[18:13:26] <AndyRussG>	 awight: https://meet.jit.si/242t97pqks05dn29
[18:13:34] <AndyRussG>	 (gotta use Chrome I think)
[18:14:10] <awight>	 AndyRussG: ok sorry, lemme get a room and ask for that URL again
[18:14:23] <AndyRussG>	 K no rush :)
[18:52:09] <atgo>	 oh no ejegg! sorry you hurt yourself... keep me posted about tomorrow :)
[18:52:22] <ejegg>	 ok, will do!
[18:52:40] <atgo>	 AndyRussG: i saw you made a card and chucked it straight to PCR... which is cool, but that means it doesn't capture a bunch of "hidden properties" that mingle tracks for us
[18:53:01] <AndyRussG>	 atgo:  one sec in  a call :)
[18:53:08] <atgo>	 sure, no worries
[19:02:09] <AndyRussG>	 atgo: Ah I see OK sorry about that
[19:02:24] <atgo>	 no worries! just letting you know.. that's my job :)
[19:02:28] <awight>	 AndyRussG: /me returns Grey Panther salute :)
[19:02:40] <awight>	 uh oh, atgo is notifying foo's
[19:03:17] * AndyRussG looks up Grey Panthers
[19:03:25] <AndyRussG>	 cool!
[19:03:31] <awight>	 They are rad
[19:03:56] <awight>	 It's like the Black Panther school breakfast program, all day, without the nationalism.
[19:05:03] <awight>	 pizzzacat: whenever you really get some momentum built up on that project, I'm ready for lunch fuds...
[19:05:48] <pizzzacat>	 awight ha ok, I brought my lunch, which you will no doubt make fun of, but I'll eat with you!
[19:07:08] <awight>	 aww.  I will do my best to find something funny about your fallen leaf salad and newt blood pudding :(
[19:07:24] <AndyRussG>	 right! https://en.wikipedia.org/wiki/Raging_Grannies
[19:07:53] <pizzzacat>	 awight it's even better - a "bagel dog"! - enjoy!
[19:08:38] <awight>	 *Nobody* sprays CS gas on the raging grannies... except the UC Regents' stormtroopers...
[19:09:23] <awight>	 hell yeah: Off Our Rockers and into Trouble
[19:14:43] <AndyRussG>	 When it's our turn we'll be "off our IRC clients and into trouble", which will be equivalent
[19:17:31] <awight>	 lol thx for the sobering reality
[19:19:41] <AndyRussG>	 oof kid pickup hour
[19:22:31] <pizzzacat>	 awight rly lunch?
[19:25:02] <atgo>	 hey awight when you're back i have a question
[19:25:21] <awight>	 atgo: yessir
[19:26:15] <atgo>	 working on some PCI stuff - GR would be out of scope, yes?
[19:26:24] <atgo>	 they work on civi, but not on payments
[19:26:42] <awight>	 atgo: Yeah hopefully this is true
[19:26:58] <atgo>	 awight:  thanks
[19:27:09] <awight>	 I guess the rule is, PII becomes cardholder data when it is combined with card data?
[19:27:57] <awight>	 glad to hear you're having a relaxing time filling in bubbles with a No. 2 pencil
[19:42:04] <pizzzacat>	 awight I'm gonna lunch w/o you
[20:40:03] <awight>	 ejegg: pinging about https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1855 review...  U said something about this last week, but I misgrokked.
[20:40:33] <ejegg>	 oh, just a couple of cosmetic things
[20:40:43] <ejegg>	 first issue has an actual comment about phpdoc
[20:41:07] <awight>	 ah right, I see it https://gerrit.wikimedia.org/r/#/c/156218/
[20:41:31] <ejegg>	 then if yr rebasing anyway
[20:41:51] <grrrit-wm>	 (PS2) Awight: Push template path strategy into a shared function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156218
[20:41:55] <ejegg>	 https://gerrit.wikimedia.org/r/#/c/156219/ had a couple ws bits highlighted in red
[20:42:31] <ejegg>	 and https://gerrit.wikimedia.org/r/#/c/153376/ had a 'TODO: template this' which I think you can now delete
[20:42:58] <ejegg>	 wmf_campaigns.module, line 241
[20:43:00] <awight>	 wait... the first patch.  What docstring needs updating?
[20:43:48] <awight>	 ejegg: whew ok I see comment oof
[20:44:28] <ejegg>	 oh right, no big deal anyway.  just 'for given language' or somethign
[20:44:29] <grrrit-wm>	 (PS3) Awight: Push template path strategy into a shared function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156218
[20:44:44] <grrrit-wm>	 (PS2) Awight: Make custom values on new contributions available to hooks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156219
[20:45:06] <grrrit-wm>	 (CR) Ejegg: [C: 2] Push template path strategy into a shared function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156218 (owner: Awight)
[20:45:34] <awight>	 meh, that ws is in the copied src
[20:45:46] <ejegg>	 oh, nvm then
[20:45:55] <grrrit-wm>	 (CR) Ejegg: [C: 2] Make custom values on new contributions available to hooks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/156219 (owner: Awight)
[20:47:26] <grrrit-wm>	 (PS1) Awight: clean up whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159168
[20:47:28] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] clean up whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159168 (owner: Awight)
[20:48:24] <ejegg>	 oops, i was too quick on the trigger
[20:49:24] <grrrit-wm>	 (PS2) Awight: clean up whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159168
[20:49:50] <grrrit-wm>	 (CR) Ejegg: [C: 2] clean up whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159168 (owner: Awight)
[20:49:53] <awight>	 if this were the wild west, I'd be one dead dude
[20:50:26] <grrrit-wm>	 (PS14) Awight: (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[21:00:50] <awight>	 ejegg: ok, PS14 seems to pass unit tests...
[21:01:35] <ejegg>	 woot!  Do you want to remove that '//TODO: template this POS. So inconvenient. ' comment now that you've added templating for the body at least?
[21:01:49] <ejegg>	  wmf_campaigns.module, line 241
[21:02:06] <awight>	 ah thx for the pointer
[21:02:45] <awight>	 erm wait, that comment still applies
[21:03:00] <awight>	 what IS going on
[21:03:03] <awight>	 one moment, please
[21:03:09] <ejegg>	 oh, bc the subject still needs templating?
[21:03:29] <awight>	 I was on the wrong commit
[21:03:44] <awight>	 OK (50 tests, 142 assertions)
[21:03:46] * awight blinks a bit
[21:03:49] <awight>	 well then.
[21:03:55] <ejegg>	 nice
[21:04:48] <grrrit-wm>	 (PS15) Awight: (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[21:05:26] <grrrit-wm>	 (CR) Ejegg: [C: 2] (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 (owner: Awight)
[21:07:02] <awight>	 ejegg: thanks for helping push that carcass across the finish line!
[21:08:53] <ejegg>	 my pleasure
[21:13:18] <grrrit-wm>	 (CR) Awight: [C: 2] "This is good, but not the complete fix--I think we should allow unarchiving from the Campaign page as well." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/158652 (owner: AndyRussG)
[21:13:33] <grrrit-wm>	 (Merged) jenkins-bot: Allow unarchiving of campaigns [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/158652 (owner: AndyRussG)
[21:15:36] <awight>	 ejegg: this might be crazy, but wrt https://gerrit.wikimedia.org/r/#/c/157267/...
[21:15:48] <ejegg>	 yeah?
[21:15:54] <ejegg>	 Oh, we talked this morning
[21:15:59] <awight>	 oh?
[21:16:07] <ejegg>	 they would like it up mid-November now
[21:16:22] <awight>	 I was gonna say, Maybe there's a way to add a configuration variable that programatically decides when to start disrespecting old cookies.
[21:16:53] <ejegg>	 Yeah, we could do that too, to avoid deploying in the midst of the storm
[21:17:21] <ejegg>	 will take a crack at that
[21:17:47] <awight>	 Sorry, I know that's incredibly annoying.
[21:17:59] <awight>	 But the rebase might introduce more surprises...
[21:17:59] <ejegg>	 no, shouldn't be too big a deal
[21:18:04] <ejegg>	 also true
[21:18:32] <ejegg>	 more annoying to have an unmerged patch flapping in the breeze for months
[21:18:51] <awight>	 yah i think so
[21:19:10] <ejegg>	 cool, will slide that card back to dev
[21:25:28] <awight>	 ejegg: also, I missed this line.  It's causing issues: include('Net/SFTP.php');
[21:25:45] <awight>	 All the require_once's above that line can disappear as well, fwiw
[21:26:13] <ejegg>	 ooh, ok
[21:26:37] <awight>	 erm maybe not the Silverpop stuff
[21:26:44] <awight>	 I commented in gerrit, but what is the deal?
[21:26:48] <awight>	 Those are upstream files?
[21:27:15] <ejegg>	 Net/SFTP is a from a PHP module, which I should really have mentioned in the commit message
[21:27:34] <ejegg>	 phpseclib
[21:28:06] <awight>	 That should be checked in as a contrib lib, IMO
[21:28:15] <ejegg>	 oh, OK
[21:28:22] <awight>	 If it helps, we have some composer stuff...
[21:28:52] <ejegg>	 Oh?  Got an example to
[21:28:53] <awight>	 Unfortunately, the security sitch is that we can use composer locally, but need to check 3rd-party libs into a vendor/ submodule, or as their own submodules...
[21:29:03] <awight>	 perhaps.  I think it's on a branch though
[21:29:21] <awight>	 https://gerrit.wikimedia.org/r/#/c/111329/
[21:29:23] <ejegg>	 OK
[21:29:33] <awight>	 totally illegal...
[21:30:01] <awight>	 that's such an antiexample...
[21:30:37] <ejegg>	 err, so add composer.json, but without a git url?
[21:31:23] <awight>	 too bad, we don't seem to have working example.
[21:31:27] <awight>	 I can help w/ that though
[21:33:11] <ejegg>	 repository of type 'artifact' looks like the way to go
[21:33:17] <ejegg>	 oop, standup time
[21:34:03] <awight>	 ejegg: ah, here's what I was hoping existed.  sites/all/modules/dedupe_review/composer.json on the dedupe branch
[21:34:07] <awight>	 standing...
[21:36:30] <ejegg>	 AndyRussG: standup?
[21:52:53] <atgo>	 hey ejegg! actually - maybe see you IRL tomorrow?
[21:55:40] <ejegg>	 that would be great!
[21:56:00] <ejegg>	 I just set up a chiropracter appt for 2pm, but before or after would work
[21:56:34] <ejegg>	 Davis Sq might be easier for me, if you can get there.  It's right on the red line
[21:56:51] <atgo>	 sweet! i'm so sad about your back
[21:57:23] <awight>	 trying to move furniture down the servants' stairs...
[21:57:59] <ejegg>	 heh... my friend had this huge credenza she inherited from her grandmother
[21:58:15] <awight>	 oh god, no Ikea quick-disconnects...
[21:58:45] <awight>	 atgo: I'm having the nagging memory that Civi is within PCI scope.
[21:58:47] <ejegg>	 we got it into her place in June, then a couple weeks later she learned the landlord was kicking them out in Sept.
[21:59:03] <atgo>	 awight: bah
[21:59:09] <atgo>	 ejegg: that's such a bummer
[21:59:13] <awight>	 omg, I sort of had that happen with an erstwhile roommate's giant kiln.
[21:59:22] <ejegg>	 oof, a kiln?
[21:59:32] <awight>	 huge honking thing.  and fragile.
[21:59:39] <ejegg>	 literally tons
[21:59:43] <atgo>	 so ejegg - let me shoot you an email with a plan for either morning or afternoon work session? i think morning might be better
[21:59:52] <ejegg>	 atgo: sure, sounds good!
[21:59:56] <atgo>	 yay! i'm excited :)
[22:00:06] <ejegg>	 me too
[22:00:30] <awight>	 She left the kiln in the driveway, after running the heat on full blast with my name on the bill for a month, and the landlord was itching for any scrap of paper to charge me deposit for...
[22:00:45] <ejegg>	 Diesel cafe is probably our best bet for Davis Sq.
[22:00:53] <ejegg>	 oh jeez, that's some roommate
[22:00:59] <awight>	 I hauled it by bike trailer to the squatters' house across the street.  Roommate got it back but we were both livid.
[22:01:11] <ejegg>	 wow
[22:01:34] <awight>	 Where is the debt collector for poor people...
[22:02:08] <awight>	 thx btw for phpseclib, we'll use that for audit downloads, too.
[22:02:59] <ejegg>	 ok, let me get that d/led and in there
[22:03:58] <awight>	 ejegg: you'll need to request a new repo, have u done that yet?
[22:04:04] <awight>	 http://www.mediawiki.org/wiki/Git/New_repositories/Requests
[22:04:20] <ejegg>	 oh really?
[22:04:29] <awight>	 well, to create a submodule for the lib
[22:04:50] <ejegg>	 oh shoot, OK
[22:05:08] <awight>	 I still don't grok the best practice around reusing composer libs, I guess the answer is: no
[22:05:25] <awight>	 so if we want to use phpseclib from another module, we duplicate the library over there :-/
[22:05:32] <ejegg>	 very odd
[22:05:43] <ejegg>	 So this is the way for anything not in core PHP?
[22:05:52] <awight>	 we could also use a top-level composer.json
[22:05:55] <ejegg>	 The module does have a .deb in the ubuntu repos
[22:06:04] <awight>	 ah we can do that, then
[22:06:23] <ejegg>	 work that out with Jeff_Green then?
[22:06:26] <awight>	 u might want to check version compatibilty stuff tho
[22:06:27] <awight>	 yeah
[22:06:54] <ejegg>	 ok, I'll check what's in the different releases
[22:07:15] <awight>	 I think our servers are on 12.04 LTS
[22:07:43] <Jeff_Green>	 yes they are
[22:07:48] <ejegg>	 Also, I'll get right of the require_once 'Silverpop/SilverpopImporter.php' that I added, but the rest of those above were already there.  Delete them?
[22:08:02] <awight>	 yeah I think we can delete them.
[22:08:14] <awight>	 As long as those files are listed in wmf_communication.info
[22:08:20] <ejegg>	 cool
[22:08:21] <awight>	 I patched the Drupal namespace fail...
[22:08:30] <awight>	 Don't look too closely :P
[22:08:36] <ejegg>	 hrm?
[22:08:42] <awight>	 (it's a hideous grep)
[22:08:58] <ejegg>	 ooh, drupal registry hackery.  sounds thrilling!
[22:09:10] * awight hides shame
[22:09:51] <ejegg>	 drat, I really need to research my dependencies better.  php-seclib is only in 13.10+
[22:09:51] <atgo>	 alrighty ejegg i'll ping you. everyone else, see you online :)
[22:10:22] <ejegg>	 I'll see about getting us a new repo to track it
[22:11:23] <awight>	 k
[22:11:28] <awight>	 it's a pretty fast process
[22:11:32] <awight>	 1-3 days, usually
[22:12:33] <awight>	 The thing I've been attempting is, write a composer.json and use that to do the d/l and install, but then check in vendor/ as a subrepo, and/or the individual projects depending on whether we want to fork them.
[22:13:15] <ejegg>	 ok, sounds good
[22:13:40] <awight>	 ejegg: oh, thing I was saying about the contentious include line: you can just write as require_once __DIR__ . '/Net/SFTP.php' and call it a day, for now.
[22:14:15] <awight>	 It would be best to include from the point of use, however, cos Drupal parses all .php files a f*king hundred times per pageview
[22:14:17] <ejegg>	 after copying phpseclib src to /Net, of course
[22:14:31] <awight>	 that part is discretionary :p
[22:15:04] <ejegg>	 oh, right, I keep forgetting about inline require.  Will move it down
[22:35:53] <grrrit-wm>	 (PS1) Ejegg: Add PHPseclib module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159210
[22:36:38] <awight>	 oof, ok then...  for now
[22:37:05] <ejegg>	 yeah, it's quite a chunk
[22:37:20] <awight>	 It's only 10% the size of CiviCRM :p
[22:39:16] <ejegg>	 when I redo it using composer, the vendor subdir should go under wmf_common, so we can use for audit and stuff, right?
[22:40:42] <awight>	 I don't have a well-formed opinion about that, yet.
[22:41:08] <awight>	 I'm still a bit butthurt that composer can't reuse identical libs required by subprojects
[22:41:28] <ejegg>	 ok, just trying to figure out what path repo to request. fundraising/crm/vendor ?
[22:41:37] <awight>	 it seems to work if the subproject is pulled in via composer, but not if it's just in the dir hierarchy
[22:41:40] <awight>	 yeah that sounds good
[22:41:46] <ejegg>	 cool
[22:41:52] <awight>	 that would correspond to a top-level composer.json, which is not a bad approach
[22:42:22] <awight>	 We can always include composer.json's in the modules, as a courtesy for 3rd-parties
[22:42:35] <ejegg>	 yeah, that sounds good
[22:43:08] <awight>	 If only... there were a way to get the top-level file to simply point to subproject composer.jsons, then build the dependencies in the top-level vendor/...
[22:43:22] <awight>	 IMO that would help with the gitbloat
[22:43:37] <ejegg>	 yeah, that sounds like the way to go
[22:45:30] <ejegg>	 requested repo
[22:48:21] <grrrit-wm>	 (PS1) Awight: WIP foreign checks nonsense [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159215
[22:48:25] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP foreign checks nonsense [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159215 (owner: Awight)
[22:48:49] <ejegg>	 oops, don't +2 that seclib yet
[22:48:57] <awight>	 no risk :)
[23:52:26] <grrrit-wm>	 (PS1) Awight: WIP multiple large donation thresholds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159225