[00:21:06] <pizzzacat>	 $('.haters').fadeOut();
[00:21:41] <pizzzacat>	 best code snippet in a page of documentation ever
[05:09:40] <jeremyb>	 hah, hangovers
[05:09:49] <jeremyb>	 also pizzacat's haters was good too
[05:38:51] <grrrit-wm>	 (CR) Ejegg: [C: 2] (FR #1995) Fix bad renormalization of recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162173 (owner: Awight)
[05:39:13] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] (FR #1995) Fix bad renormalization of recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162173 (owner: Awight)
[16:37:42] <ejegg>	 Good morning K4-713!
[16:37:50] <K4-713>	 hey ejegg
[16:37:58] <K4-713>	 Apparently WP is still busted.
[16:38:06] <ejegg>	 oh shoot
[16:38:07] <K4-713>	 But, it sounds like in a new way.
[16:38:23] <ejegg>	 ok, let me try with a charge that should work
[16:38:24] <K4-713>	 There are some fr-tech emails about that this morning.
[16:38:36] <K4-713>	 Ah, I'd take a look at the logs first.
[16:38:50] <atgo>	 aha! you beat me to it
[16:39:00] <atgo>	 i was just coming to IRC to chat about this
[16:39:04] <K4-713>	 We have totally different accounts for worldpay US and worldpay Everythingelse.
[16:39:21] <K4-713>	 It's possible it's something up with the everythingelse account.
[16:39:25] <K4-713>	 Or... fraud filters.
[16:39:40] <K4-713>	 In fact, my money is on fraud filters.
[16:39:44] <ejegg>	 ok, peeping logs
[16:40:36] <K4-713>	 atgo: Yeah, before we make any cards, we should probably make sure something is actually wrong. :)
[16:40:44] <atgo>	 word
[16:41:05] <atgo>	 that's what i was hoping i said but.. brain is fuzzy.
[16:41:14] <K4-713>	 Understandable.
[16:41:26] <K4-713>	 Your longitude is all weird.
[16:42:00] <K4-713>	 I basically have no excuse.
[16:42:32] <K4-713>	 And yet: Here we are.
[16:42:46] <ejegg>	 STOMP transac
[16:42:49] <ejegg>	 tion has no place to go for status failed :(
[16:43:02] <ejegg>	 let's see where that comes from
[16:43:03] <K4-713>	 That's fine, and we don't want it anyway.
[16:43:15] <K4-713>	 Not entirely sure why mwalker wanted that in the logs.
[16:43:17] <ejegg>	 OK, that was attached to Megan's info in the wp payments logs
[16:43:26] <K4-713>	 We should take it out, because it makes people think something unintended is happening.
[16:43:34] <K4-713>	 We don't want to save donor data for transactions that didn't happen.
[16:43:41] <ejegg>	 especially the frowny face
[16:43:42] <K4-713>	 Never have.
[16:43:54] <K4-713>	 Yeah. I guess he thought something was wrong, too.
[16:44:11] <ejegg>	 ok, i see it was rejected a couple lines up
[16:44:14] <K4-713>	 *coughNonExistantDocumentationcough*
[16:44:31] <ejegg>	 AuthorizePaymentForFraud failed
[16:44:36] <K4-713>	 AHA.
[16:45:23] <ejegg>	 Hmm, but XML says Transaction Approved
[16:45:41] <ejegg>	 taking a closer look at match codes
[16:45:51] <K4-713>	 AuthorizePaymentForFraud - is that one of ours?
[16:46:38] <ejegg>	 seems to be the initial .10 authorization worked, but one of the post-processing checks failed it
[16:46:48] <K4-713>	 In other words, are the minfraud and other antifraud filters hooked in with that... exactly.
[16:46:51] <K4-713>	 Exactly that.
[16:46:57] <K4-713>	 So... you see the contribution tracking id?
[16:47:07] <K4-713>	 Grep the payments-fraud log for that.
[16:47:37] <K4-713>	 Or, alternatively: query fredge.
[16:47:41] <K4-713>	 Same data.
[16:48:14] <ejegg>	 getAVSResult seems to be the culprit.
[16:48:26] <ejegg>	 Though CVVResult was clean.
[16:48:41] <ejegg>	 Might have something to do with the change I made a while ago
[16:48:47] <K4-713>	 Maybe not.
[16:49:04] <K4-713>	 So... depending on the form she used, it may not have even asked for her address.
[16:49:08] <K4-713>	 Which is normal.
[16:49:27] <K4-713>	 But, if you use a card that supports AVS, and a form that doesn't ask? You fail.
[16:49:31] <K4-713>	 atgo: ^^
[16:49:54] <K4-713>	 This is one reason credit card forms are localized.
[16:50:00] <ejegg>	 Aha, form doesn't have an address
[16:50:14] <ejegg>	 https://fr.wikipedia.org/?banner=B14_0718_enfrFR_frm_wp&force=1&country=FR
[16:50:19] <K4-713>	 ...I'm not even looking at code or logs or anything right now.
[16:50:34] <K4-713>	 And now I'm scared of myself and need to go to a meeting. :p
[16:50:39] <ejegg>	 heh
[16:50:39] * K4-713 waves
[16:50:43] <atgo>	 haha
[16:50:59] <atgo>	 so wait... does this mean that she'll never be able to donate on a french form?
[16:51:08] <atgo>	 with her US card?
[16:51:21] <ejegg>	 That's what it sounds like to me
[16:51:38] <atgo>	 hm. ok.
[16:51:48] <atgo>	 silly AVS
[16:51:56] <atgo>	 protecting us from fraud.
[17:10:00] <ejegg>	 atgo, pizzzacat, K4-713: anyone got anything to bring up at the scrum of scrums?  Need anything from other teams / need to warn other teams about anything?
[17:19:27] <atgo>	 ejegg: not off hand! thanks for checking in
[17:19:44] <atgo>	 also ejegg - megan was using a French card, which shoudln't require AVS...?
[17:33:22] <ejegg>	 atgo: oh, was she?
[17:33:25] <ejegg>	 very odd
[17:33:40] <ejegg>	 I need to know more about those rules, I guess
[18:40:35] <atgo>	 hey ejegg! could you make a card for the fraud issue?
[18:44:19] <ewulczyn>	 Does anyone know how to set up cyberduck or filezilla to connect to lutetium?
[18:47:21] <ejegg>	 ok, will do
[20:30:50] <AndyRussG>	 Hi atgo, ejegg, pizzzacat1, ewulczyn (no K4?)
[20:31:02] <AndyRussG>	 The CentralNotice backend RfC meeting starts in half an hour
[20:32:11] <AndyRussG>	 May overlap some with standup actually, looks like it's the second topic in the meeting
[20:34:38] <AndyRussG>	 ewulczyn: I mentioned some of the concerns you mentioned on the talk page, BTW: https://www.mediawiki.org/wiki/Talk:Requests_for_comment/CentralNotice_backend_improvements
[20:34:47] <AndyRussG>	 It'll be pretty technical.
[20:35:29] <AndyRussG>	 Meeting will be on #wikimedia-office IRC channel, at 9pm UTC
[20:36:02] <pizzzacat>	 it smells like pretzels in here
[20:36:06] <pizzzacat>	 warm delicious pretzels
[20:36:21] <ejegg>	 Hi AndyRussG
[20:36:25] <pizzzacat>	 am I going crazy? is this a form of stroke?
[20:36:57] <AndyRussG>	 :)
[20:37:16] <pizzzacat>	 like a more specialized type of stroke, better than regular toast smells
[20:38:07] <AndyRussG>	 Hmm over here most of the smells are drowned out by the noise
[20:39:33] <atgo>	 haha pizzzacat1 :)
[20:39:38] <AndyRussG>	 That's why I'm listening to music on headphones--to be able to smell better
[20:40:14] <atgo>	 AndyRussG would oyu be able to write up some minutes/conclusions from the RFC for us to discuss another time?
[20:40:31] <AndyRussG>	 atgo: most certainly yes
[20:40:41] <atgo>	 great :)
[20:40:55] <atgo>	 i've been in transit for like a day and a half and must close eyes
[20:41:41] <AndyRussG>	 atgo: enjoy! Yeah I expect it'll be pretty generalish
[20:50:50] <K4-713>	 ejegg: Gah. So, where were we at 9:30?
[20:53:03] <ejegg>	 at 9:30?
[20:55:37] <ejegg>	 K4-713: what happened at 9:30?
[20:56:29] <K4-713>	 Somebody momentarily thought Worldpay was broken.
[20:57:06] <ejegg>	 Well, we probably need to change something
[20:57:22] <K4-713>	 ejegg: Then we discovered it was more nuanced than that: The antifraud filters were making WP in eurpoe unusable. :)
[20:57:27] <ejegg>	 If FR-issued cards are coming back with AVS 'not performed' instead of 'not supported'
[20:57:45] <K4-713>	 Well, then all we need to do is change the score percentage for that code.
[20:57:58] <K4-713>	 Make sense?
[20:58:10] <K4-713>	 Also, I nominate you to do that. :)
[20:58:14] <ejegg>	 sure, if that's cool for the general case
[20:58:26] <K4-713>	 I mean, I wouldn't take it all the way down to zero.
[20:58:44] <ejegg>	 Same as 'not supported', or something midway between?
[20:58:58] <K4-713>	 Matching for not supported seems most sane.
[20:59:02] <K4-713>	 Can you write a test for it?
[20:59:05] <ejegg>	 OK, will do
[20:59:24] <K4-713>	 And, ah... probably change it in DonationInterface.php instead of out in localsettings.
[21:00:31] <ejegg>	 yeah, I actually didn't see it in localsettings, only DI.php
[21:00:49] <K4-713>	 It's only in localsettings if you've put it there as an override. :)
[21:00:57] <K4-713>	 (on payments? Definitely.)
[21:01:13] <K4-713>	 (But it's probably not being overridden)
[21:01:17] <K4-713>	 (...probably)
[21:01:27] <ejegg>	 ok, cool.
[21:02:26] <K4-713>	 ejegg: This is the sort of task that should have deploy notes saying "Make sure the thing I'm doing now isn't being overridden in localsettings".
[21:03:40] <ejegg>	 Ah, noted!  I'll add that to the card before I forget
[21:34:08] <AndyRussG>	 ejegg: K4-7131: pizzzacat: the meeting is about to start discussing the CentralNotice RfC so I'm gonna skip standup, hope that's OK ;p
[21:46:21] <grrrit-wm>	 (PS1) Ejegg: Fix WorldPay AVS settings to work with non-(US|UK|CA) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162766
[21:46:43] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Fix WorldPay AVS settings to work with non-(US|UK|CA) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162766 (owner: Ejegg)
[22:05:55] <K4-713>	 the-wub: are you online?
[22:07:00] <the-wub>	 K4-713: yeah I'm just staying quiet :)
[22:07:08] <the-wub>	 trying to get my head round what's being proposed a bit better. but nothing problematic jumps out at me so far
[22:07:14] <K4-713>	 Just wanted to make sure you had eyes on the current thing.
[22:07:45] * K4-713 high-fives the-wub, goes back to half-lurk mode
[22:23:56] <grrrit-wm>	 (PS1) Ejegg: Fix form HTML generation test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162776
[22:27:22] <ejegg>	 K4-713: You mind reviewing that test case update?  The old test case started breaking for some dumb reason (preventing anything from getting V+2), and it was too inflexible anyway
[22:34:11] <grrrit-wm>	 (PS2) Ejegg: Fix WorldPay AVS settings to work with non-(US|UK|CA) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162766
[22:43:12] <ejegg>	 K4-713: Got that settings change and test ready for review, plus a fix for a test that was blocking V+2 for everything DI
[22:43:39] <K4-713>	 Yay!
[22:43:50] <K4-713>	 I'll have a look, and then we can deploy maybe tomorrow.
[22:43:53] <ejegg>	 rockin
[22:48:04] <grrrit-wm>	 (CR) Katie Horn: [C: 2] Fix form HTML generation test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162776 (owner: Ejegg)
[22:48:24] <grrrit-wm>	 (Merged) jenkins-bot: Fix form HTML generation test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162776 (owner: Ejegg)
[22:50:27] <grrrit-wm>	 (CR) Katie Horn: [C: 2] Fix WorldPay AVS settings to work with non-(US|UK|CA) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162766 (owner: Ejegg)
[22:50:49] <grrrit-wm>	 (Merged) jenkins-bot: Fix WorldPay AVS settings to work with non-(US|UK|CA) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162766 (owner: Ejegg)
[22:51:06] <K4-713>	 ejegg: Hum... how long are you going to be here today?
[22:53:38] <ejegg>	 another couple hours, probably.  want to deploy?
[22:57:36] <ejegg>	 K4-713: Did you want to deploy that stuff now?
[22:57:51] <K4-713>	 ejegg: I think if you have time (and this should be really simple) it would make some people very happy.
[22:58:10] <ejegg>	 Cool, will get started!
[22:58:21] <K4-713>	 Rad. Let me know if you need anything.
[22:58:38] <ejegg>	 I'll let you know when I'm about to pull the trigger
[22:58:46] <K4-713>	 Perfect.
[23:06:21] <grrrit-wm>	 (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/162785
[23:06:23] <grrrit-wm>	 (PS1) Ejegg: Fix WorldPay AVS settings to work with non-(US|UK|CA) [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/162786
[23:07:22] <grrrit-wm>	 (PS1) Ejegg: Delete tests [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/162787
[23:07:43] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/162785 (owner: Ejegg)
[23:08:00] <grrrit-wm>	 (CR) Ejegg: [C: 2] Fix WorldPay AVS settings to work with non-(US|UK|CA) [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/162786 (owner: Ejegg)
[23:08:14] <grrrit-wm>	 (CR) Ejegg: [C: 2] Delete tests [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/162787 (owner: Ejegg)
[23:08:29] <grrrit-wm>	 (CR) Ejegg: [V: 2] Delete tests [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/162787 (owner: Ejegg)
[23:09:37] <grrrit-wm>	 (CR) Katie Horn: [C: 2] WorldPay auditing ported to SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/157303 (owner: Awight)
[23:10:37] <grrrit-wm>	 (Abandoned) Katie Horn: Bug fixes for the initial commit of the WP recon parser [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/159631 (owner: Katie Horn)
[23:18:40] <ejegg>	 K4-713: ok, about to rsync blast
[23:18:44] <grrrit-wm>	 (CR) Katie Horn: "Side note: This also has I5ddde4025c60a79c45c681b7b81d7624ae00b8ff." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/157303 (owner: Awight)
[23:18:50] <K4-713>	 ejegg: Go for it. :)
[23:19:11] <ejegg>	 done
[23:20:07] <K4-713>	 ejegg: ...do you log updates in here?
[23:20:23] <ejegg>	 oh, what's the syntax for that?
[23:20:31] <grrrit-wm>	 (Abandoned) Katie Horn: Fixes the date formatting / normalizing. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/159638 (owner: Katie Horn)
[23:20:34] <ejegg>	 morebots: help
[23:20:34] <morebots>	 I am a logbot running on tools-exec-11.
[23:20:34] <morebots>	 Messages are logged to wikitech.wikimedia.org/wiki/Server_Admin_Log.
[23:20:34] <morebots>	 To log a message, type !log <msg>.
[23:21:06] <ejegg>	 !log Updated paymentswiki from 3ac5dd1c3fade37b6f3a4879aef8ea71b3bbbf08 to 83464deed3b66da655ca5d1086852237c4793b71
[23:21:12] <morebots>	 Logged the message, Master
[23:29:17] <K4-713>	 ejegg: ...I really hate that amazon form BS error.
[23:29:32] <ejegg>	 I tried replicating locally this morning
[23:29:44] <ejegg>	 but it's never getting the blank ffname
[23:29:46] <K4-713>	 Some day, I'm going to go crazy and fix it while I'm supposed to do something else.
[23:29:55] <K4-713>	 ejegg: I'm pretty sure it's the return user.
[23:30:08] <ejegg>	 ohhh, after they come back from donating!
[23:30:10] <K4-713>	 So... coming back from the amazon workflow, in order to get bounced to our TY page.
[23:30:12] <K4-713>	 yep
[23:30:27] <ejegg>	 i just never followed through...
[23:30:30] <K4-713>	 :D
[23:30:55] <K4-713>	 I went cross-eyed for a while before that one occurred to me. Sad.
[23:31:35] <ejegg>	 mental grep in process...
[23:33:53] <K4-713>	 I have this really stupid problem in WP that I just noticed.
[23:34:08] <ejegg>	 oh?
[23:34:28] <K4-713>	 I'm not sure how I can tell, from the perspective of the thing that parses the nightly recon file, what account we're looking at.
[23:35:07] <K4-713>	 You'd think that would be in the filename...
[23:35:34] <ejegg>	 ooh, that could be an issue!
[23:35:54] <K4-713>	 yep
[23:35:58] <K4-713>	 There's got to be something here.
[23:36:07] <ejegg>	 srsly
[23:36:12] <K4-713>	 Not immediately obvious, because: fixed-width spew.
[23:38:35] <K4-713>	 Yep: It's not in there.
[23:38:44] <K4-713>	 Maybe they're going by StoreIDs.
[23:39:28] <ejegg>	 it's realy not the first part of the filename, huh?
[23:39:37] <K4-713>	 They *are* going by storeIDs.
[23:39:48] <K4-713>	 The first part of the filename is all AN.
[23:39:54] <K4-713>	 er. Alphanumeric.
[23:40:08] <K4-713>	 Well, that sucks.
[23:40:10] <K4-713>	 Okay.
[23:40:31] <ejegg>	 at least that's something
[23:40:39] <K4-713>	 There's one storeID per currency we accept.
[23:40:47] <K4-713>	 ...for one-time.
[23:40:56] <K4-713>	 And more for amex.
[23:41:01] <ejegg>	 bah
[23:41:09] <K4-713>	 All those multiply by 2 when we support recurring through them.
[23:41:25] <K4-713>	 All of those lines, map to three accounts.
[23:41:37] <ejegg>	 so that's a lot of mapping to duplicate between DI and the processor
[23:41:38] <K4-713>	 fffffffffffffffffffffffokay.
[23:41:51] <ejegg>	 yep, sounds fun
[23:42:05] <K4-713>	 The really suck thing, is that this is probably not something we want in the actual repo.
[23:42:14] <ejegg>	 right
[23:42:23] <K4-713>	 config file for the file parser.
[23:43:37] <K4-713>	 If we rolled the good bits of DI into smashpig, this wouldn't be a problem.
[23:43:53] <ejegg>	 shouldn't be too hard to make a little php script to dump stuff from the form settings into yaml, i guess
[23:43:59] <K4-713>	 ugh
[23:44:03] <ejegg>	 yeah
[23:44:09] <K4-713>	 ...I'll just... not do that.
[23:45:40] <K4-713>	 Oh, and apparently it's not even 1:1 with currency.
[23:46:24] <ejegg>	 as in, /some/ storeIDs have multiple currencies?
[23:46:38] <ejegg>	 or some currencies have different IDs in diff countries?
[23:46:38] <K4-713>	 Some of them settle into different currencies or something.
[23:46:43] <ejegg>	 man
[23:47:10] <K4-713>	 I have no idea how they got to here.
[23:47:18] <K4-713>	 What problem... does this solve?
[23:47:51] <ejegg>	 underemployment?
[23:48:09] <K4-713>	 At some level: Empty filing cabinets that are too easy to move.
[23:48:21] <ejegg>	 heh
[23:49:40] <K4-713>	 Well... we will need to deal with this before we do the US implementation.
[23:50:11] <K4-713>	 Now, though, we can... write a card and develop a raging case of amnesia for the time being.
[23:50:31] <ejegg>	 oh, now that you're doing the parsing in php, i guess you can just include the same file for settings?
[23:50:43] <ejegg>	 and just ignore most of them
[23:51:42] <K4-713>	 I'm not even sure where that config should go, though.
[23:51:56] <K4-713>	 ...probably will just let awight out it wherever makes him happy.
[23:52:06] <ejegg>	 oh right, parser and DI are on different boxen
[23:52:17] <K4-713>	 very.