[00:06:21] When we fix the amazon logspam, i'm going to miss the 'random article' aspect of tailing the error logs [00:07:16] heh [00:09:53] Can we just fix that by adding ?ffname=amazon to the return URL in our account settings? [00:10:42] I verified locally that you were right about the spam happening on return, and that adding the param gives no logspam [00:11:09] gonna make a mingle card [00:11:13] YAY [00:11:34] Please add it to the cleanup before Big EN supertask. :) [00:12:12] will do [00:16:51] well, i'm pretty sure that last deploy didn't break anything new [00:17:06] gonna sign off for the night [00:50:39] (PS1) Katie Horn: I kind of need the message. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/162798 [02:29:36] (PS5) Katie Horn: WIP: DO NOT MERGE - Generic audit logic and worldpay audit job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159761 [16:54:18] K4-713: can i bounce an idea off you for semi-generically preventing multiple form submission? [16:54:38] Hm. Sure, but we already do that some places. [16:55:13] yeah, there are so many places to look for this stuff... [16:55:25] Pretty sure we have some javascript kicking around in there that does it. [16:55:55] At least a few places, we're just adding the 'disabled' class to the button, but not doing anything about it [16:56:04] hm. [16:56:18] I thought we did something somewhere that actually removed the form action. :D [16:56:29] oh, that would do the trick! [16:56:35] Grey out button, make everything impossible. [16:57:18] oh, nvm about my other idea, just realized it wouldn't be practical [16:57:58] Having said that, I wouldn't be surprised at all if you said you couldn't find evidence of that having ever existed. [16:58:55] would have involved another listener to the submit event to check for the disabled class and prevent default, but interaction with validation would be problematic [16:59:39] validation needs to fire on submit too, and we don't want to disable the form if they just need to correct something clientside [17:01:51] guess we just need to add multisubmit prevention to all the existing submit listeners [17:13:58] Wellp, apparently my computer is haunted today. [17:14:07] Totally helpful. [17:14:48] i hope it's by pacman ghosts. they're kinda cute. [17:14:48] It crashed once already, and then netbeans decided to apply different project format settings randomly for no reason. [17:14:55] I WILL EAT THEM. [17:15:15] Particularly Clyde. [17:15:21] I've been training for this my whole life. [17:17:19] whoa, i've been calling Clyde 'Sue' all this time. Guess I played more Ms. Pac-Man than the original. [17:18:05] heh [17:50:44] Aw, man. Our standups are at 11am in 36? [17:51:14] where is that? [17:51:20] Just another room. [17:51:23] With no video setup. [17:51:30] oh, boo [17:51:45] And I *definitely* didn't have video conferencing as a priority for this computer of mine. [17:51:47] that spot in the hallway's taken? [17:51:52] Guess so. [17:52:08] I mean, I think a lot of teams use it. [17:53:21] pizzzacat: Can we use your computer for standup in... 7 minutes? [17:53:36] sure [17:53:58] Cool, thanks. [17:54:17] As previously stated: Mine is particularly haunted today, and hangouts make it cranky anyway. [17:54:43] * K4-713 wonders if I should get USB devices to help or if that would just make it worse [17:55:34] Everybody on the other end says things like "Why are you sitting in total darkness?" and "Are you at the bottom of a well?" [17:56:44] "I can't hear you... is the tide coming in or something?" [17:59:07] I'm sure you'll know what I'm talking about next week. [18:19:57] buh. internet. [18:20:00] hey k4-713, awight, pizzzacat, ejegg - for the WP form, is this something peter can tinker with or is it fr-tech only? [18:21:01] atgo which thing? [18:21:20] you mean what we were talking about, re:getting Peter into forms maybe? [18:21:32] yes [18:21:40] styles, buttons [18:22:10] I talked to K4 and now Adam [18:22:22] seems to sound like a good idea [18:22:43] and I can set him up when I'm in Paris if this is a good idea for everyone [18:24:51] atgo: Strictly speaking, not a lot is fr-tech only.... [18:25:05] ...though, we do seem to be the only ones who can actually... test things. [18:25:06] cool [18:25:13] that sounds like a great plan [18:25:17] Accounts, and not having them, are a problem. [18:25:27] right [18:25:33] Setting them up are also a problem. [18:26:08] It would be Neat, if we did something like add a way to use dummy accounts that didn't actually talk to anything, so people can... you know. Do stuff. [18:26:37] yup! [18:27:11] ok [18:27:16] so... this seems to be a longer conversation [18:27:25] Sort of. [18:27:29] The answer is "Partially!" [18:27:32] in the short term, would pizzzacat be able to get him set up for the forms at least? [18:27:40] Should be, yes. [18:27:51] He's done stuff like this before, too. [18:28:39] So, it's not totally unfamiliar territory. [18:28:49] K4-713: this could be a part of our discussion about setup for while I'm in France…which I need to set a meeting for, for today or tomorrow [18:29:05] Okay [18:29:08] Makes sense. [18:29:08] probably tomorrow [18:29:12] :) [18:29:15] this will be cool [18:29:18] yay! [18:29:52] also pizzzacat i just sent you some rather raw notes about the sahar report [18:30:00] we can talk through some other time or i can answer questions [18:30:18] * K4-713 wonders what the heck I was doing before standup [18:31:10] ok thanks atgo [18:33:46] awight i have some questions for you [18:36:06] K4-713: have a second? [18:36:15] We're looking for docs about utm_* [18:36:23] Good luck. [18:36:39] ewulczyn: https://wikitech.wikimedia.org/wiki/Fundraising#Contribution_tracking [18:36:41] Hang on, I'll see if I can remember where the last potentially useful thing was. [18:36:48] This might take some time. [18:37:20] I'm going to start hashtagging about f'd up documentation and not being ready for people. [18:37:24] atgo: now = good time! [18:37:30] Then we can count how many times a day this comes up. [18:37:36] hehe smeariously [18:37:50] I might have to produce a graph to prove I'm not kidding. [18:38:16] awight... so how close are we on the CI project? [18:38:19] 5 minutes of stuttering over an attempted explanation of things I still don't know after two years, was a bad feeling [18:38:37] awight: ...who said medium wasn't useful? [18:38:40] atgo: probably 80% of the way or something [18:38:47] Medium is amazing. [18:38:53] ok, cool. that's the same as what mingle says [18:38:56] K4-713: lol that's what we just determined independently [18:38:59] atgo: baahahaha [18:39:04] suddenly... [18:39:09] I was listening to loud angry rock. [18:39:22] :P [18:39:23] * K4-713 pictures an actual rock with googly eyes [18:39:36] and frowny brows [18:39:41] awight also - did you see the question about testing for reporting phase 1? [18:40:03] atgo: yes, but it shot out the other ear. one moment, please [18:40:31] atgo: privchan... [18:40:36] yup [18:56:36] Ayola? [18:56:51] (sp) [19:46:07] (PS1) Ejegg: Prevent double-submit of Worldpay form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162962 [19:47:51] awight|launch: i emailed you a TY summary, just to make sure everything is covered. if it all goes out at once, could you just throw the others into the current sprint as well? thanks! [19:53:44] also ejegg awight|launch - this is a blocking issue for WP. could one of you look into it in the near-er term? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1687 [19:54:24] ooh, that looks fun! [20:08:59] hehe ejegg :) [20:09:43] aw damn. [20:09:48] awight: Look up. [20:10:05] That was the card I was just talking about. [20:10:18] K4-713: yeah I think ejegg was starting to lick that cookie on Monday [20:10:23] mebbe not [20:10:24] order id fix? [20:10:27] yep [20:10:37] looking at it now [20:10:45] It's a total whack-a-mole situation. [20:10:51] ejegg: not sure we clued you into the cookie-licking metaphor. Should be self-explanatory :) [20:10:52] So... lots of tests. :) [20:11:13] oh good it's a well-known idiom [20:11:38] awight: I don't know. I have had a lot of people look at me like I was *completely* insane, or making inappropriate suggestions. [20:11:48] When I mentioned cookie licking. [20:12:01] So, somewhere in gateway constructor we call a fn that tests whether session data has a gateway w/different identifier, and regenerate order ID if true? [20:12:01] ...needs explaining. [20:12:10] that's -ahem- "white cookie" licking that they were thinking of [20:12:28] * K4-713 squints [20:12:31] ejegg: yeah I think that's what we need [20:12:32] Aaaaanyway. [20:12:57] ejegg: This is really, really easy to screw up, and badly. [20:13:44] There is a thing, in DonationInterface, that is called very carefully in workflows when the current attempt has reached an end. [20:13:45] so actually call regenerateOrderID, or just remove the order ID entirely? [20:13:50] ! [20:13:58] oh is there? [20:14:10] I have not yet encountered this thing [20:14:58] atgo: assuming you have information about card 1920, can you reply to pcoombe's comment? [20:15:31] ejegg: You should know that most of the times we have ever had to touch this, something major explodes. [20:16:03] aw geez, it seemed so simple! [20:16:30] It's a big hairy angry mess. [20:16:57] And the reason it's doing what it's doing right now, is probably because you're actually looking at a bandaid ball. [20:17:35] Is checking that the $_SESSION['Donor']['gateway'] exists and does not match $this::IDENTIFIER potentially wrong? [20:17:46] buh [20:17:48] Where? [20:18:11] I guess I'd do it in the adapter constructor, or a fn called from there [20:18:21] Well... wait. [20:18:38] (PS2) Awight: (FR #1995) Fix bad renormalization of recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162173 [20:18:49] ejegg: So, it sounds to me like the thing that regenerates the order ID when we need to, isn't getting the right format. [20:19:27] Oh, I thought it just didn't know the order ID needed regenerating when we switched gateways [20:19:59] and that the solution was to get rid of the old order ID on switch [20:20:24] to force eventual regeneration [20:20:56] So I'd detect the switch by comparing the session gw with the current gw id [20:20:58] ejegg: Okay... so, instead of just resetting the order id in that case, you should probably nuke everything in the session and start over. [20:21:05] There's a clean function for that too. [20:21:28] Otherwise, you will have weird other things hanging out in there as well. [20:21:53] If it's the same person just changing method, we might save some data and not force them to re-fill some fields [20:22:13] not worth it? [20:22:24] Well, unless they submitted on the other form, there won't be. [20:22:55] ahh, makes sense [20:23:15] OK, so clean out the whole thing on swap. Sounds not too hard [20:23:52] Funny story: I think there's another card in there for this, too. [20:24:16] atgo consolidated two - is there a third? [20:24:28] Oh, did she? [20:24:30] Okay then. [20:24:50] cookies? [20:25:07] er. [20:25:09] What? [20:25:15] Oh, cookie licking? [20:25:35] ejegg K4-713 i'm trying to catch up [20:25:37] what? is this? [20:25:44] atgo: You should like this a lot. [20:26:01] You know, with volunteers, when somebody says "Oh, I'll do that!" and then they don't? [20:26:11] K4-713 mind pointing me in the direction of that 'clean out the session' function? [20:26:12] We would say that they licked that cookie, and then put it back. [20:26:22] (Abandoned) Awight: Sync thank-you translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/161422 (owner: Awight) [20:26:33] ejegg: I'm looking. :/ [20:26:59] ... cute [20:27:03] This context switching into DI is... not unlike a carnival ride that goes slightly too long. [20:27:10] Guess I could just set $_SESSION['Donor'] = null [20:27:12] And then I get to go back. [20:27:16] ejegg: noooooo [20:27:16] awight commented on 1920 [20:27:32] Must... use... standard things! [20:27:34] oh, that would be a bad thing? [20:27:36] OK [20:28:52] There are a lot of (totally documented, of course) codepath switches that look at the session data in particular ways. [20:29:18] yeah, i'm just grepping DI for $_SESSION now and learning things [20:30:06] aha, session_unsetDonorData! [20:30:26] You beat me. [20:30:43] Which is not surprising. I feel like I've been... poisoned. [20:30:50] Can't even read. [20:30:54] sorry to bother you with stuff I could answer myself... [20:31:05] ejegg: What uses that? [20:31:12] oh, let's see [20:31:39] Here's the thing I think I meant to say: session_resetForNewAttempt. [20:31:57] Do that with a force, I think. [20:31:59] ohh, that does a few cool things [20:32:10] ejegg: sorry to interrupt, but can you zap this one for me? https://gerrit.wikimedia.org/r/161423 [20:32:39] At least I do helpful comments sometimes. [20:32:57] "For those times you want to have the user functionally start over without, you know, cutting your entire head off like you do with session_unsetAllData()." [20:33:02] awight: rebase? [20:33:05] (PS2) Awight: Clean up template annotation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/161423 [20:33:10] heh, i love it [20:36:26] (CR) Ejegg: [C: -1] "JSON_UNESCAPED_SLASHES isn't available in PHP 5.3" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/161423 (owner: Awight) [20:36:37] * awight dies temporarily [20:36:51] sorry man [20:40:56] (PS1) Awight: sync thank-you translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/162972 [20:43:57] awight ejegg K4-713 pizzzacat i'm not much longer for awake time... anything else i can help with? [20:44:06] awight did you see the summary of TY stuff? [20:44:26] I'm good :) nitey nite [20:44:33] atgo: erhm... nothing I can't start queuing for tomorrow. [20:44:40] the-wub: (atgo) I'm gonna let you take care of this, there is some coordinating of text that should happen: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1838 [20:44:44] he ok [20:44:58] coordinating of text? [20:45:14] atgo: yeah thanks for the list [20:45:21] atgo: I explain in the comment [20:45:32] We'll want copy changes if the box is removed [20:45:40] aaah okaaay i see [20:45:48] plus... that letter is production-owned anyway [20:46:48] ok sounds good [20:47:08] awight, atgo : I'll look into it, but it seems pretty low priority [20:47:33] yeah.. i think megan would like it before december, but i could be wrong about that [20:47:41] the-wub: I don't know where that request came from--ah from megan, then [20:48:50] the-wub: also, did you see my question on the "sync translations" code review? I'm wondering how the English paragraphs decide when to appear. [20:49:16] It seems like a bad thing, that we publish a translation, but apparently it can be destroyed by changes to the master en letter? [20:49:45] awight: missed that. link? [20:50:26] (CR) Awight: Sync thank-you translations (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/161422 (owner: Awight) [20:50:38] the-wub: heh, sorry, I hadn't published the comments yet. ^^ [20:55:49] awight: I think that may have been my mistake actually, misclicked/pasted the wrong thing in the Translate extension https://meta.wikimedia.org/w/index.php?diff=9058842&oldid=8848096 [20:56:16] although I have no idea what I was supposed to be doing, thanks to the lack of edit summaries in Translate :( [20:57:04] it wasn't caused by changes to the en master page [20:57:07] the-wub: thanks, that's a huge relief to know there is an explanation [21:19:14] (CR) Awight: [C: 2] Prevent double-submit of Worldpay form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162962 (owner: Ejegg) [21:19:42] (Merged) jenkins-bot: Prevent double-submit of Worldpay form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162962 (owner: Ejegg) [21:46:10] (PS1) Ejegg: Clear out session data when changing adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163034 [21:55:03] (CR) Ejegg: "" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162173 (owner: Awight) [21:55:19] (CR) Ejegg: (FR #1995) Fix bad renormalization of recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162173 (owner: Awight) [21:55:28] (CR) Ejegg: [C: 2] (FR #1995) Fix bad renormalization of recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162173 (owner: Awight) [21:55:49] (Merged) jenkins-bot: (FR #1995) Fix bad renormalization of recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/162173 (owner: Awight) [21:56:37] ejegg: yeah ^, I think a test failed spuriously, in the last patchset. [21:56:59] lameness [21:57:07] but merged now! [21:57:11] thanks! [21:57:56] The comparison that failed is still baffling me... [21:57:57] [-value="NIO"><donate_interface-NIO><donate_interface-NIO> oh. /me squints at > [21:58:14] I wonder what that's about... [21:58:30] just escaping [21:58:43] yeah, i wasn't sure either [21:58:50] the test seemed overstrict though [21:58:59] would have broken on any kind of spacing change [21:59:32] so i swapped out the string compare for some node inspection [21:59:46] nice! [22:03:34] (PS1) Ejegg: Prevent double submission of GC bank transfer form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163040 [22:04:30] (CR) jenkins-bot: [V: -1] Prevent double submission of GC bank transfer form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163040 (owner: Ejegg) [22:05:40] ejegg: are we really using that form? ^^ [22:05:59] yeah, for iDEAL [22:06:10] wat. [22:06:22] somebody managed to submit 30 times on tuesday [22:06:22] which RL module? [22:06:24] gc.form.rapidhtml.webitects.2nd? [22:06:30] awesome [22:06:32] itchy finger [22:06:32] let me check [22:07:42] oh yep, that's the one [22:08:33] (PS2) Ejegg: Prevent double submission of GC bank transfer form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163040 [22:08:36] I really don't understand. [22:09:06] the only references I can find in DonationInterfaceFormSettings, under "Credit Card - Two Step", don't have payment methods specified. [22:09:21] hmm, let me see [22:09:34] Is this something people can actually get to, or maybe this haxor had a wild orphan URL? [22:09:59] I mean. It's whitelisted, which is a sign it does get used. [22:10:09] I think you can get to it from the NL landing page [22:10:55] index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=rtbt-ideal&recurring=&payment_method=rtbt.rtbt_ideal&utm_source=Waystogive.default~default~default~default~control.rtbt.rtbt_ideal&utm_medium=sitenotice&utm_campaign=C11_Waystogive&utm_key=&referrer=https%3A%2F%2Fwikimediafoundation.org%2Fwiki%2FWays_to_Give&language=en&country=NL&returnto=Thank_You%2Fen&amountGiven=¤cy_code=EUR&frequency=onetime&amount=3&uselang=en [22:12:48] awight: rtbt-ideal [22:14:42] Nice--I think this has been mentioned before, but... ways to give vs other ways to give... [22:17:38] yeah, maybe low priority, just happened to be the one in the logs during a deployment [22:17:55] ejegg: k, sorry to waste your time. I can confirm that webitects2nd.js is being used there... [22:19:02] that is some horrifically single-use code... replicates most of gc.cc.js, but with a bunch more stuff that we probably aren't using any more. [22:19:16] I'll add a card to clean up... [22:20:13] oh wow, that doesn't work at all. [22:20:38] grr, nvm I got redirected to my sandbox [22:26:13] nice. description: 19334833.83662 [22:26:18] take that to the bank... [22:33:06] awight: for the eventual changeup of how we do forms, were you thinking twig, or getting away from templates entirely and generating all the fields dynamically? [22:33:27] I guess we need the templates for stuff like logos [22:40:22] ejegg: twig was definitely on my mind. [22:44:25] ejegg: actually, I don't understand what you mean by "dynamically"--on the client? [22:45:07] no, on the server [22:45:45] instead of the input HTML in the template, a placeholder for the whole input [22:45:58] you're blowing my mind [22:46:14] where would the form come from, in that case? [22:46:16] strcat? [22:46:47] I mean a token for each input element, not the whole form [22:47:27] ah, I think I see what u mean. I've been laboring over this exact question... [22:47:29] since the server knows what kind of data goes in each, what the placeholder should be, and what name / id makes sense for it [22:47:59] Probably we'll end up doing nested templates [22:48:00] validation type would go in a data-validation attr [22:49:13] I don't imagine there will be anything with truly dynamic fields. [22:50:30] no, but there is a lot of repeated stuff in the forms now [22:50:43] Won't nested templates cover that? [22:51:02] hmm, i guess [22:54:49] hehe, now we just have to implement the universal form before the code slush [22:55:12] errr, right [23:12:41] Eileen just forwarded this interesting thread, http://forum.civicrm.org/index.php/topic,34170.0.html [23:13:54] (CR) Awight: [C: 2] Prevent double submission of GC bank transfer form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163040 (owner: Ejegg) [23:13:55] Hmm, I should look at the existing Civi payments code [23:14:18] ejegg: bring some bleach-based contact solution [23:14:20] (Merged) jenkins-bot: Prevent double submission of GC bank transfer form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163040 (owner: Ejegg) [23:14:33] that good, huh? [23:16:06] everyone's favorite is that there is an extra "confirm" page in the workflow, and you can't skip it because the submit function does half the work of the next page's submit handler... [23:16:28] eww, weird [23:17:00] yeah eventually they introduced an option to skip that page, but it does so by submitting the form internally... [23:17:18] aww, man! [23:17:22] it's like when you see barnacles growing on other barnacles... [23:21:30] (PS3) Awight: Clean up template annotation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/161423 [23:22:05] awight: Those are load-bearing barnacles. [23:22:36] barnacular spectacular [23:22:40] :D [23:22:57] (CR) Ejegg: [C: 2] Clean up template annotation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/161423 (owner: Awight) [23:23:02] ...in fundraising vernacular. [23:23:26] guys, don't laugh this is serious bizness: http://link.springer.com/article/10.1023%2FA%3A1017088317920 [23:24:48] brb, off to warn the sea captains that barnacles cause drag [23:24:59] lol [23:25:16] you can show them the bilinear regressions [23:25:33] K4-713: I forgot to mention a major thing about the payments upgrade: in theory, it needs some CR [23:26:16] Probably fair to just say: it matches upstream MW exactly, and we've reviewed the one PHP file we're adding... [23:28:26] awight: Ah. [23:28:39] * K4-713 looks around for people to nominate [23:29:22] For the purposes of PCI, does it *have* to be one of our tiny team? [23:29:27] no [23:29:32] YAY [23:29:36] afaik, just "someone reviewed it" [23:29:43] it's really nbd though [23:29:47] I need a lawyer. [23:29:51] Like, all the time. [23:29:54] just... git diff origin/REL1_23 [23:30:17] I usually get cuffed when I'm in that kind of a mood. [23:30:18] are we taking this opportunity to use DI master rather than the accumulation of cherrypicks? [23:30:35] ejegg: nah, that's independent [23:30:50] But we are, right? [23:30:52] heh [23:31:08] from the payments-1.23 perspective, that's just a submodule pointer thing [23:31:12] not related... [23:31:24] Yeah... I mean, obviously people already reviewed or it wouldn't be in core. Right? [23:31:26] ah, ok [23:31:42] but... let me do that now. It's "just" merging master into deployment and looking at what happens :) [23:31:48] (scare-quotes) [23:32:03] awight: Unless you want somebody to page through the commits and verify that nobody self +2'd. [23:32:13] OOF [23:32:15] rats [23:32:21] yeah cos that totally did happen... [23:32:22] Wait. I guess it would be or my imaginary lawyer wanting that. [23:32:26] URrgh [23:32:37] My imaginary lawyer is kind of a knob. [23:32:40] Sorry. [23:32:42] I knoticed [23:35:32] I just did something that should have been complicated, in 14 lines. [23:35:34] >_> [23:35:35] <_< [23:35:45] That can't be real. [23:35:48] I can still read it. [23:35:49] pray tell [23:35:52] (PS2) Awight: sync thank-you translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/162972 [23:36:13] Queueflooding the "negative" transactions from a nightly recon file. [23:36:17] K4-713: u started coding in python, then? [23:36:22] HARGH [23:36:41] ...I said I could read it. [23:36:42] :p [23:37:11] it's a great language, it's like Perl but with the read bit turned on. [23:37:53] (PS3) Awight: sync thank-you translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/162972 [23:42:16] Ugh, this isn't right. [23:42:20] But... I don't know why. [23:45:18] * K4-713 grumbles about April... [23:45:37] Anybody know off the top of your head, when we ran the WP campaign in BE? [23:46:07] (CR) Awight: [C: 2] "Nice one! I even ran your test w/o the code change and it correct failed..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163034 (owner: Ejegg) [23:46:45] ejegg: btw, you probably want to add reviewers to your patches... "fr-tech" is a good choice [23:47:05] Oh, thanks for finding that one anyway! [23:47:11] (Merged) jenkins-bot: Clear out session data when changing adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163034 (owner: Ejegg) [23:47:22] I added myself to the git/reviewers bot config :) [23:47:48] Ahh, I was wondering where the automatically added reviewers came from! [23:47:49] K4-713: wants spam? https://www.mediawiki.org/wiki/Git/Reviewers [23:48:08] om nom nom nom [23:48:17] more filter fodder [23:48:36] I mean, I already get a lot. [23:48:57] this will dwarf the wmflists! [23:49:19] ...okay, that's confusing. I thought I got all the DI spam anyway already. [23:49:25] How... [23:49:44] K4-713: WP BE was 5/29-6/30, says some old mail [23:49:44] K4-713: ah you must be subscribed through gerrit [23:49:52] "Prank" videos on youtube [23:50:03]