[00:03:02] (PS1) Awight: Merge master into deploy-payments_1.22 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/163067 [00:03:45] K4-713: ejegg: ^^ there's the cherry-pitter [00:03:53] woohoo! [00:05:11] I'm sure I'll ruin it again soon enough. [00:05:15] muaha [00:05:17] :p [00:05:31] nah, all it takes is occasionally merging rather than cherry-picking [00:06:24] it looks like we've never had a reason to skip over a patch entirely, on the deploy branch. [00:06:35] I'm suprised there weren't differences lurking [00:06:44] me too! [00:06:53] in fact, downright suspicious. [00:09:06] double-checked, it looks ok. git diff --stat 6f558d1 [00:11:13] awight: I'm not completely surprised at that. [00:11:42] Then again, I usually git diff master..deploy_payments locally before I do a deploy. [00:12:18] yeah, looks fine to me too! [00:12:51] (CR) Ejegg: [C: 2] Merge master into deploy-payments_1.22 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/163067 (owner: Awight) [00:13:08] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163069 [00:14:05] !log turning off Civi jobs before deployment [00:14:10] Logged the message, Master [00:15:02] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163069 (owner: Awight) [00:30:16] Hey um. Can anyone else ssh through the frack bastion? [00:30:50] I think Ellery set off an ip velocity filter in the firewall or something. [00:30:55] oops [00:31:22] K4-713: ejegg: in case we don't speak again, please beware that the crm deploy branch has undeployed changes. [00:31:36] ! [00:31:44] orly [00:31:46] Like what? [00:32:23] erm, these things, https://gerrit.wikimedia.org/r/#/c/163069/ [00:32:42] I really like that the commits are linked this time... [00:33:41] eep [00:34:04] Hey, I see some Oanda in there. [00:34:19] Oanda Jackson? [00:34:29] or Oanda Sykes [00:34:33] I hope its the latter [00:34:40] Oanda go to the bar later. :p [00:34:40] I'm sure they're both lovely [00:34:55] we are so hilarious omg [00:35:00] I know. [00:35:13] who needs the internet when there's us [00:35:32] But we're *on* that! [00:35:35] The internet. [00:35:59] some people just don't get it [00:36:06] I bet Harry Potter has an Oanda summon things. [00:36:16] * K4-713 takes a walk [01:52:48] (PS2) Awight: WIP (FR #1497) More import columns for communication prefs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/162187 [01:52:50] (PS1) Awight: Import notes into Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163082 [02:02:50] (PS2) Awight: Import notes into Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163082 [02:02:52] (PS3) Awight: (FR #1497) More import columns for communication prefs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/162187 [02:55:42] (PS6) Katie Horn: WIP: DO NOT MERGE - Generic audit logic and worldpay audit job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/159761 [08:19:04] !log disabling CRM jobs during deployment [08:19:11] Logged the message, Master [08:24:39] !log fundraising_code_update: revision for civicrm changed from 06c9546f9b68f6ecbaaf510944418aa52f9ed0fb to 5aca00fd4573f0fe8f385baa7238172f6ae54438 [08:24:45] Logged the message, Master [08:28:22] !log skip over wmf_civicrm schema migration 7022 -- *why* did I make that unsafe [08:28:28] Logged the message, Master [08:29:47] !log large_donation schema migration 7000 [08:29:53] Logged the message, Master [08:44:39] !log rollback: revision for civicrm locked to 06c9546f9b68f6ecbaaf510944418aa52f9ed0fb [08:44:45] Logged the message, Master [09:10:01] (PS1) Awight: remove test manifest in deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163130 [09:33:47] (PS1) Awight: Override Twig security to not whitelist property access [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163132 [09:35:10] (PS1) Awight: WIP noticed some things in large_donation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163133 [09:36:13] (PS1) Awight: load vendor classes for all tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163134 [10:46:32] (CR) Pcoombe: [C: 2] sync thank-you translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/162972 (owner: Awight) [16:37:15] hey awight you there? [16:38:10] atgo: yessir! [16:38:15] hii! [16:38:35] do you know anything about the banners not closing bug from last week? [16:39:00] ejegg: I have a little deploy snafu, if you have time to review: https://gerrit.wikimedia.org/r/163132 [16:39:05] atgo: this is the first I've heard of it. [16:39:09] * awight looks for card [16:39:14] ejegg fixed it, didn't he? [16:39:50] no card [16:39:59] ? [16:40:17] blurp. anyway, atgo is something still on fire? [16:40:32] no, just wanted to check in [16:40:38] is there a card? i don't remember seeing it [16:40:41] i'm getting some questions :) [16:41:05] hello [16:41:34] hi! [16:43:28] atgo: there was one problem with a banner's hand-coded close button not having the right image, and another where the js deployment happened at just the wrong time and a pair of mismatched files entered the cache [16:43:50] ok sweet. is there a card for this? [16:44:03] for the deployment fix, we moved the json dependency card back into dev till we got the cache cleared [16:44:31] the other was fixed by the monuments banner maintainer [16:44:42] monuments banner maintainer? [16:44:54] Glaisher, I think? [16:45:02] ? [16:45:28] harej is one the who created the SoM banner [16:45:38] I only fixed some stuff in it [16:45:39] Oh hi! Just saying you were able to make the close button show up without us having to do a code change [16:46:27] awight: taking a look at that twig patch [16:52:08] ok thanks [16:52:25] (CR) Ejegg: [C: 2] Override Twig security to not whitelist property access [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163132 (owner: Awight) [16:53:17] wurd, thank you. [16:55:40] yeah, seems like sandbox should allow an 'all' switch on each of those [16:56:23] ejegg: yeah, there are no docs & when I looked at the source, it seems only two of the check functions are broken out for overriding. We may be the only ones using it. [16:56:54] on the cutting edge of conservatism, huh? [16:57:14] :) just how I like it [17:00:03] the bleeding pudding edge [17:00:16] ok wish me luck, redeploying... [17:00:30] gl [17:02:04] !log disabling CRM jobs for deployment... [17:02:10] Logged the message, Master [17:02:22] awight: Disabling jobs? Looks serious. [17:02:39] ...good luck with that. :p [17:03:18] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163193 [17:03:44] K4-713: yeah, we're using Twig from a composer vendor/ directory now, so the TY job would melt down w/ autoloader errors [17:03:49] oh, wow that reminds me [17:03:54] oooooooh. okay. [17:03:56] Jeff_Green: can I borrow u for a minute? [17:04:26] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163193 (owner: Awight) [17:04:46] Jeff_Green: I need a drupal settings change... [17:06:25] ya [17:06:35] i'm just looking at your ssh email too [17:06:45] Jeff_Green: actually, I found the g+w config file so I'm faking it using that for now [17:06:59] oh good [17:07:01] Jeff_Green: some time soon though, I'd like to finish moving all that cruft to /etc [17:07:24] ok, let me know when you have a block of time to work on it and we can make it so [17:07:35] Jeff_Green: today is fine, up to you [17:07:51] I can prepare the file in ~... [17:08:03] let's do next week, friday seems like we're asking for trouble [17:08:22] aww, there goes the flame-stoking fun [17:08:30] ha [17:08:51] !log updated crm from 06c9546f9b68f6ecbaaf510944418aa52f9ed0fb to 25159fcfc29921b08de86f12121fb292139be09d [17:08:58] Logged the message, Master [17:10:43] awight: once again I forget to write release notes. Our OANDA account holder should get our API key from their site and add it to Civi [17:10:47] awight i'm puzzled by your ssh eerror from yesterday [17:11:07] ejegg: ah, is it a rollback thing? [17:11:12] Jeff_Green: tell me about it... [17:11:45] awight: not if we can get the key soon [17:11:58] conversions will work, just the update needs the key [17:12:06] ejegg: hehe okay I'll let u sweat it out, then. sorry! [17:12:18] ejegg: it's fine to rollback, if you decide to later [17:12:28] I already did last night :) [17:12:32] K4-713, atgo: does one of you have the OANDA login? [17:12:38] awight: sorry! [17:12:47] ejegg: I don't think I do. [17:12:54] I'll look, though. [17:13:31] Oooh, I'm a big fat liar. I have something. [17:13:35] ejegg i'll look [17:13:36] woohoo [17:13:43] oh.. k4-713 you've got it? [17:13:43] oh.. k4-713 you've got it? [17:13:45] ...but there's no PW. [17:13:49] Double liar. [17:13:52] pls add yourself to https://collab.wikimedia.org/wiki/Fundraising/Engineering/3rd_Party_Account_Location [17:13:55] oh nvm :p [17:14:09] I just have the username. [17:14:10] "non-password holders" :) [17:14:16] Maybe I can use it to do a reset? [17:14:20] lol [17:14:25] hang on... i.. let me look [17:14:33] No, really. I don't know what email address it's tied to. [17:14:36] Could be fr-tech. [17:14:55] i have it [17:15:03] both the pass and acct [17:15:05] ejegg: looks like we have a chronic case of "Could not find template info comment in thank you email" [17:15:19] nbd [17:15:26] k4-713 is it cool if i email these to ejegg? [17:15:30] ooh, that's no fun. Did the updated templates get deployed? [17:15:38] atgo: want to set up OTR? [17:15:47] atgo: Do you have encrypted... yeah, that. [17:15:52] mm. yes [17:15:54] suppose i should [17:15:56] do that [17:15:58] Definitely. [17:16:08] ok, switching to local irc client [17:16:12] And while you're at it, I want the PW too. [17:16:18] pizzzacat1: on that note, u might want to install OTR before your trip [17:16:23] :p [17:16:31] K4-713: it's in the doc that pats keeps for such things [17:16:38] you're on it [17:16:40] oh hah, well then email away [17:16:52] ? [17:16:56] * awight facemonitors [17:17:08] atgo: cos that means we already have no security [17:17:08] Ugh... [17:17:17] Well, docs are still better than email. [17:17:22] But not by much. [17:17:26] doubtful [17:18:04] But I guess g00gle isn't advertising keys and wands to us, yet... [17:18:08] well.. you guys just tell me what to do [17:18:24] K4-713: you can look at this and then OTR it to ejegg if you want [17:18:24] atgo: it's worth the 30 min to set up OTR, either way. [17:18:37] yeah [17:18:41] erm.. how? [17:18:48] irc client is? [17:19:12] * K4-713 stares angrily at mountain of google docs [17:19:20] yeah we need folders [17:19:29] lingo [17:19:59] like a chincilla needs narrow spaces between furniture [17:20:37] awight what's OTR? [17:21:18] off the record IRC encryption [17:21:51] K4-713: hey, didyu get a large donation email just now? [17:23:48] eeeyes? [17:24:10] pizzzacat: yah, when you're remote, you should have that for IRCing passwords or bad jokes. [17:24:23] K4-713: err, is it formatted like a sane machine wrote it? [17:24:59] hah [17:25:41] awight: More or less? [17:25:51] Looks pretty much the same as it did 8 hours ago. [17:26:09] woot. k thx [17:27:16] awight: Actually, wait. This is weird. [17:27:47] Maybe you have more insight, but it looks like it's *exactly* the same as one from 8 hours ago, except for the contribution_id. [17:27:52] Is that a test email or something? [17:28:13] !log CRM jobs reenabled [17:28:19] Logged the message, Master [17:28:19] K4-713: yeah [17:28:25] Oh, phew. [17:28:28] K4-713: oh, the one 8 hours ago doesn't count :) [17:28:31] Identical contact ID freaked me out. [17:28:34] needs to be from earlier [17:29:03] ejegg: What was I supposed to be getting from Oanda? [17:29:09] I'm in now. [17:29:32] * K4-713 changes terrible password [17:32:55] K4- the API key [17:33:04] should be on the account settings page [17:34:42] K4-713: ^ [17:35:00] * K4-713 goes blind [17:35:12] Okay, got it. [17:41:02] atgo: Check out the new password. [17:41:15] noice [17:41:59] PPena: FYI K4-713 changed the OANDA password. It's reflected in your accounts doc [17:42:25] atgo cool-thank you [17:44:04] Okay, where was... oh. Standup in 15 minutes. [17:44:25] In order to avoid driving myself insane, I will not try to get my head back in that game until after. [17:47:29] awight: Those jobs still off? [17:47:47] K4-713: have been reenabled! [17:47:56] agh. [17:48:08] K4-713: hey tangentially, #1904 is not actually PCR, is it? [17:48:13] We should probably turn off qc and wait for ejegg to give the all-clear for Oanda. [17:48:19] awight there's a MG checkin at 11 as well [17:48:37] alas, awight and i will miss the standup :( [17:48:39] ejegg: ^^ (although they will be crazy with event) [17:48:53] K4-713: I think that's safe to do live [17:49:06] we're just not getting real-time conversion rate updates [17:49:24] Apparently the job looks at an alternate source if oanda isn't working. [17:49:30] um [17:49:31] oh [17:49:34] Right, it got the rates from ECB [17:49:46] what runs that? Is that seriously a civi cron? [17:49:49] oh yeah! ejegg! you're joining [17:49:51] exciting times [17:49:58] Yay [17:50:02] ...qc still on? [17:50:07] so... looks like K4-713 and pizzzacat for standup. if you guys want we can do it at noon your time or email [17:50:13] gah [17:50:24] !log CRM queue consumer disabled [17:50:28] sorry... my timing sucks [17:50:30] Logged the message, Master [17:50:37] atgo: My vote is for 10 minutes from now, or never. [17:50:47] never! but email perhaps? [17:51:04] awight: Thanks. I don't know how flaky those rates are, but presumably if they were good, we wouldn't be paying for Oanda. [17:51:23] maybe we should kill the fallback. [17:51:41] I didn't even remember that was in there. [17:51:52] Probably need a spike. [17:51:55] ECB just doesn't have all the currencies [17:52:03] ooooo [17:52:11] I'm good for email [17:52:18] What happens to the ones it doesn't have? [17:52:41] Standup: I did almost none of what I said I would yesterday, fooled around with thank-yous instead. I just deployed the multiple large donation notification levels, which was the last Coinbase task AFAIR. Today, I'm sweeping in the corners, and will try to push DI unfork along. [17:52:42] I'll send you an email update atgo :) [17:52:47] thanks pizzzacat :) [17:52:51] K4-713: I think they stagnate, which is probably fine. [17:52:53] mew mew [17:53:14] btw there are many cats in ibiza [17:53:28] ibiza cat [17:53:32] :D [17:53:44] whoa, it's like you've been waiting for that moment your whole adult life [17:53:49] well-played [17:54:27] I think I have my next destination figured out, then, atgo [17:54:35] well, clearly [17:54:42] it's pretty nice here, not going to lie [17:54:45] the only problem is all the raves [17:54:46] u can spend one whole life there [17:54:50] OH NO [17:54:50] so much raving [17:54:52] i haven't seen a single rave yet [17:54:59] * awight finds a place to sleep during the day [17:55:06] I heard people literally wear suits made out of glow sticks [17:55:13] ooh that explains that... [17:55:39] yeah and instead of putting bread on your table at the restaurants they put bowls of drugs [17:56:00] lol [17:56:03] just bowls and bowls [17:57:19] Don't fill up on drugs! You'll ruin your appetite! [18:01:08] ejegg: uhh... question. What table is the currency converter using? [18:01:25] exchange_rates in the drupal db [18:01:39] So... funny thing. [18:01:46] ut-oh [18:01:53] select * from exchange_rates ORDER BY local_update DESC LIMIT 1; [18:02:04] ...and check out the date on that timestamp. [18:02:12] Either one, really. [18:04:27] So, June??? [18:04:29] eek [18:04:51] Crap. I was hoping you were going to say: "No, that's okay because [things]." [18:05:40] I'll, ah... make a card. [18:05:57] yeah, that should raise some kind of alarm [18:05:58] In the meantime, it's probably safe to re-enable qc. [18:06:03] guess so [18:06:24] * K4-713 makes a face with no equivalent emoji [18:06:34] atgo: Guess what? [18:06:42] sup? [18:06:55] Looks like the last time we got currency updates, was June. [18:07:29] I'm... going to make some cards and go hang out in a stairwell. [18:07:35] it may be a firewall thing [18:07:50] ejegg: Probably [18:08:01] Would explain the long wait before fallback [18:08:02] I think that was right around the time we moved boxes. [18:08:22] At any rate, one of those cards is going to be "put an alarm on that bizness." [18:08:37] yeah [18:09:55] !log re-enabled donations queue consumer [18:10:02] Logged the message, Master [18:11:03] ejegg: Well, I had been about to suggest that we roll back the new stuff, but that seems deeply unnecessary at this point. [18:11:33] heh, no more broken than before [18:11:39] ...exactly. [18:11:55] Three months of conversion cleanup? [18:12:12] Not significantly different from three months and two days. [18:12:17] oh boy [18:13:28] I seem to remember having to do something not entirely unlike this before. [18:13:56] ejegg: Is there some simple way in Oanda to get exchange rates for the past? [18:14:02] And if so, how far into the past? [18:14:15] it's definitely in the api [18:14:19] Cool. [18:14:31] i'm pretty sure for at least 3 months [18:14:45] We really like cutting it close, don't we? [18:14:49] :) [18:15:02] i mean i think it's way longer [18:15:32] You know, I was about to make cards for this, but... you probably know more about it at this point, than I do. [18:15:51] ejegg: Can you make some mingle cards describing what we need to do, to get this all working again? [18:16:15] ...and a couple describing what we should do about the cleanup. [18:16:57] And one for a "really old rates" alarm! [18:17:31] If you could, in this process, assume that this kind of thing is probably going to happen again, and that we should be able to reuse the solution in the future, that would be even better. [18:31:10] hey pizzzacat1... FYI we need to fix the australia form so it's only state [18:31:13] not all the address [18:32:13] atgo got it :) [18:36:52] aand now i see your standup :) [18:37:34] Oh, good grief. Now it's lunchtime. [18:37:52] I just can't get my timing right today. [18:38:26] ccogdill: #1924 is all good? [18:38:33] K4- Jeff got the routes open, but I'm still getting a 400 status. Will try to diagnose that one and will make some cards for the other stuff [18:38:35] because you're rocking it at SQL [18:38:52] ejegg: Great! [18:38:56] I think so atgo! [18:39:01] ok! i'll delete :) [18:39:02] yay [18:39:10] by the way, did you see the attachment Peter sent with his query [18:39:14] super helpful! [18:39:17] and thanks :) [18:39:54] ejegg: Let me know if there is anything I can do to help with that. I think no matter where you end up leaving it, though, we can float like this for a while longer. [18:39:57] i did not [18:40:08] ccogdill: would you forward? or am i on that email and just missed it? [18:40:20] Hmm you may have been dropped at that point [18:40:22] I’ll send [18:40:28] ejegg: So, you know... not so much of an emergency. Don't sweat it over the weekend or anything. [18:40:31] K4-713 OK, cool. I think I got it [18:40:56] ccogdill: How are you doing with the SQL? :) [18:41:08] well, with Peter’s help I managed to join 4 tables :D [18:41:15] Aw yeah. [18:41:22] I didn’t have it quite right but I was definitely on the right track [18:41:34] that training session was so helpful K4-713, thank you thank you! [18:42:04] ccogdill: My pleasure. :) So, on the scale of "fun" to "torture"... how are you liking going in there yourself? [18:42:17] ccogdill you're way ahead of me. sigh [18:42:32] I’m really liking it! But I’ll like it more when I understand it better :) [18:42:35] getting easier all the time [18:42:52] Yaaaay. [18:43:30] That's so cool! When's our next one scheduled? [18:46:42] next next week [18:46:51] hopefully i'll have time to dig around too! [18:47:06] Great! [18:47:24] yes I can’t wait [18:47:26] If you want, I can show you how to get the antifraud data out of fredge next time. [18:47:33] ok.. i feel like i may be beating a dead horse. but the banner closing fix. awight|geekmeet ejegg [18:47:37] is that for sure OK now? [18:47:50] That would be a huge flaming big deal if it wasn't. [18:48:11] You'd know, because we'd be all "Help! People are lighting the tree I climbed to get away from the pitchforks!" [18:48:15] Yeah, it's working [18:48:50] K4-713 we gotta do one last Lee's run before I skip town, don't you think? In like 10 mins [18:48:55] YES. [18:49:04] ok, thanks :) [18:49:25] word [19:55:32] (PS1) Awight: add WMF logo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163242 [19:56:42] (CR) Awight: [C: 2] "self-reviewing non-code file" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163242 (owner: Awight) [19:57:27] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163243 [19:57:34] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163243 (owner: Awight) [19:58:15] !log update CRM from 25159fcfc29921b08de86f12121fb292139be09d to 3e42bac8cb7f58f5e504946f4944c69ca5553e60 [19:58:20] Logged the message, Master [20:01:41] (PS1) Awight: favicon [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163244 [20:01:51] (CR) Awight: [C: 2] "self-reviewing non-code" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163244 (owner: Awight) [20:01:58] (CR) Awight: [V: 2] "self-reviewing non-code" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163244 (owner: Awight) [20:02:24] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163245 [20:02:35] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163245 (owner: Awight) [20:06:45] K4|gone: <_< have I gone too far... (RL) [20:06:59] uhh... [20:11:02] ooh, civi is pretty, what happened??? [20:11:05] wow.... the CIVI looks awesome [20:11:08] wowowhoo [20:11:29] purpully.... [20:15:18] * awight blushes sickly kool-aid [20:15:34] mweeehehehe [20:17:41] awight: I guess we're keeping it, then. :D [20:17:45] this is the first time the WMF logo is showing up for me too [20:18:07] woot! that was surprisingly tricky, but I think it's here to stay [20:21:51] there's even a logo on the tab in chrome [20:21:59] oh, good! [20:22:09] CaitlinVirtue: btw, nice to see you in IRC :p [20:22:59] haha, thanks. It's a bit scary here, but I'm trying to be brave and use the lingua franca, as it were [20:23:05] There are roughly 5 successful jokes per day, but sometimes we have solar flare activity of fun, to make yr reading worthwhile. [20:23:23] :p the imperial language [20:23:31] <_< [20:23:32] >_> [20:23:41]