[15:36:50] (PS1) Ssmith: Merge "Clear out session data when changing adapters" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164087 [17:11:14] pizzzacat: anything you want me to bring up at the scrum of scrums? [17:14:26] umm [17:14:36] I don't believe so ejegg! [17:15:01] ok, cool [17:38:10] is Adam W is the house? [17:51:25] SVentura: No dice, sorry [17:55:50] ejegg: I'm trying to rereview #1880, but not sure how we're doing this... I left some comments already, u want me to "-1" :p? [17:56:17] meh looks like it's all superficial, nvm [17:56:46] this is the only really offensive one: function validateValue( value, column, undefined ) { I know u already explained this microoptimization to me tho [17:57:11] * awight looks for calorie source before continuing to harp on small things [17:57:24] awight: Damn, timing, SVentura was loking for you [17:57:26] looking. [17:57:46] :p [17:58:39] ejegg: also, are we amending or slapping fixit patches on the end of the branch? [18:00:42] ejegg: I assume pizzzacat wants to avoid amending like the plague--the option is to work on a feature branch though, and all these patches are in -master... [18:01:29] hi awight! [18:01:49] sorry, let me take a look [18:02:07] Oh right, I guess we're adding fixit patches [18:03:34] what is the topic? and are we doing standup? [18:03:52] or email standup because Anne [18:04:44] ejegg awight ^ [18:05:24] oh just saw k4's email [18:06:06] ejegg: awight pizzzacat Isn't today shrimp prawning so no standup? [18:06:24] oh rite [18:06:32] not reflected on the calendar but yeah [18:06:37] * AndyRussG wipes his brow [18:06:38] phew [18:07:23] however, I won't be at shrimp prawning. I don't even know if Anne will be…she's all email this week I guess [18:07:47] does anyone know what's going on with that? I tried emailing Anne about shrimp prawning but haven't heard back yet. [18:08:58] seems like everyone's left [18:10:30] we're standing up [18:10:33] pizzzacat: ^^ [18:10:55] ah ok [18:11:18] calling in [18:12:24] Ooops [18:32:42] git rebase --onto origin/master HEAD^ HEAD [18:33:07] (PS1) Ssmith: Fix AU GlobalCollect form to only show state [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164133 [18:40:16] ejegg: fyi, we're having EFF over to the office, 4-6pm. Want to be an eerily projected giant fly on the wall? [18:40:52] Sure, for the first hour anyway! [18:41:42] hehe cool, this will be weird :) [18:41:58] SecondLife style [18:42:22] remember VRML? [18:42:30] no [18:42:58] cool, I do vaguely remember reading about it, I think in a historical context though [18:43:07] w3c standard for 3d worlds, back before anyone had the hardware to make it look good [18:43:23] hehe. "you find a silver key." [18:43:44] go nOrth, South, or Into the cave [18:44:08] imagination rendering engine is hard to benchmark [18:50:36] ccogdill: Where are we meeting, and should we already have food? [18:51:22] yes to already having food [18:51:35] I think we’re just hanging out at the big table on 3rd [18:51:43] does that sound good to you, K4-713? [18:51:46] Okay then. See you all soon. :) [18:51:49] cool! [18:54:56] (PS1) Awight: WIP workaround for mixing test instrumentation into adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164140 [18:55:12] (CR) jenkins-bot: [V: -1] WIP workaround for mixing test instrumentation into adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164140 (owner: Awight) [20:21:15] K4-713: Do we hope to start recording settlement date as distinct from received date? Or was that just a thing we pondered and abandoned? [20:22:23] ejegg: we're trying to leave that open for the future [20:22:36] guh [20:22:37] OK, cool [20:22:51] Yeah, it's one of those things that we always just thought of as "nice to have". [20:23:05] I'm not sure what would cause that to be more relevant than... you know: Now. [20:23:07] the real settlement happens into various currencies, per account... we considered keeping track of all that. [20:23:23] Well, we may eventually have to. [20:23:26] But that's going to be huge. [20:23:59] ...and recording settlement currency is definitely a bigger deal (both in importance and in... scale) than recording the settlement date. [20:24:33] Oh, that might have a bearing on the fee thing, too. i'm reconverting fee_amount based on the ratio between the original_amount and the old total_amount. [20:24:46] since we don't have an original_fee recorded any place [20:24:48] hmm. [20:25:02] I don't even know that we have that for most payments, in a real way. [20:26:15] ejegg: Hang on a second, though. [20:26:27] ejegg: What other than paypal even has fees recorded? [20:26:31] Okay, maybe also amazon. [20:26:36] oh, let me check. [20:26:51] Those might not be so much calculated, as recorded straight from IPN messages. [20:27:01] So, recalculating that would be not so great. [20:27:03] hrmph yeah we do conversion on fee_amount. [20:27:24] awight: They don't... bill us in our own currency? [20:27:27] oh wait, the place I'm seeing us convert is a settle() function that's not actually used yet [20:27:51] yup. [20:28:22] err, wait, we /are/ converting fees in wmf_civicrm_normalize_contribution_amounts [20:28:46] * K4-713 looks worried [20:28:57] Uhm. [20:29:02] yeah that happens :-/ [20:29:14] I think we should probably double-check that we aren't doing something weird, on a per-gateway basis. [20:29:25] ...which will clearly take the rest of the calendar year. [20:29:34] We do a lot of things. [20:29:44] -_- [20:30:48] so, the only place I see us setting fee on the intake is in the paypal listener. Let's see what currency that's supposed to be in [20:32:03] ./AmazonAudit/amazon-audit.py: "fee": abs(float(txn['FPSFees']['Value'])), [20:32:19] paypal auditing has fees, too: ./audit/paypal/TrrFile.py: out['fee'] = float(row['Fee Amount']) / 100.0 [20:32:42] guess i'm not looking in enough places [20:34:30] that's wikimedia/fundraising/tools [20:35:05] ok, for paypal, mc_fee is in the original currency, so conversion is right and proper [20:36:01] sounds right [20:40:18] ewulczyn: shoot! [20:41:16] or, at least it looked like a question was brewing :) [21:24:08] argh shrimp prawning. [21:24:59] awight, ejegg, AndyRussG... get ready to prawn our next shrimp in about 5 minutes. [21:25:01] (PS2) Awight: WIP workaround for mixing test instrumentation into adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164140 [21:25:23] (Abandoned) Awight: WIP workaround for mixing test instrumentation into adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164140 (owner: Awight) [21:34:12] awight: ejegg I don't see a video call link on the 5:30 shrimp event [21:34:32] I was just trying to find one myself! [21:34:45] They don't seem to be in the usual sprint-planning hangout [21:35:06] Didn't know there was one 8p [21:35:43] There's a link on the 6:00 event tho [21:37:32] ejegg: can you let me know here if you find the call please? I think I finally got my Webcam back working but it borks and needs commands run again every time I turn it off [21:37:51] K4-713: where are uuuuuu? [21:38:02] Refresh the invite. There should be a video call in there now. [21:38:12] ...just for the alt one for today. [21:38:47] I don't see it :( [21:39:15] try now? [21:40:13] GOt it :) thx [21:40:30] I just super-invited both of you. [22:40:02] (PS2) Awight: Use autoloading for test classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163787 [23:03:13] (PS1) Ejegg: Drush command to recovert old non-USD contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164256 [23:05:54] K4-713: https://gerrit.wikimedia.org/r/163787 [23:06:06] hmm? [23:06:20] u will like. [23:06:45] Huh. [23:08:22] (PS3) Awight: Use autoloading for test classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163787 [23:10:03] "Set up globaltown" [23:10:04] heh [23:12:12] awight: You going to patchset on me again, or can I... [23:12:15] ... [23:12:17] ... [23:13:31] ...whatever, I'm doing it. [23:13:39] (CR) Katie Horn: [C: 2] Use autoloading for test classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163787 (owner: Awight) [23:14:41] (CR) Awight: [C: 2] Drush command to recovert old non-USD contributions (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164256 (owner: Ejegg) [23:15:10] K4-713: hehe, thanks! [23:16:28] (Merged) jenkins-bot: Use autoloading for test classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163787 (owner: Awight) [23:17:44] K4-713: corner store? [23:17:54] Oh yeah, totally. [23:17:57] or u are fitting in 15 min of real work today? :p [23:17:58] ok [23:43:16] (PS1) Ejegg: Wire backfill & recalc together, fix help [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164269 [23:50:14] exit