[00:05:19] (PS23) Awight: Merge standalone framework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139452 [00:05:22] (CR) jenkins-bot: [V: -1] Merge standalone framework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139452 (owner: Awight) [00:05:30] \./ [00:06:25] (CR) Awight: Merge standalone framework (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139452 (owner: Awight) [00:07:27] (PS24) Awight: Merge standalone framework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139452 [00:07:45] (CR) Awight: "PS 24: rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139452 (owner: Awight) [00:09:56] (PS2) Awight: Fix AU GlobalCollect form to only show state [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164133 (owner: Ssmith) [00:10:02] (CR) Awight: [C: 2] Fix AU GlobalCollect form to only show state [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164133 (owner: Ssmith) [00:10:42] (Merged) jenkins-bot: Fix AU GlobalCollect form to only show state [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164133 (owner: Ssmith) [00:21:04] (PS1) Awight: Fail the message if a currency or amount are given alone, rather than as a pair. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164499 [00:25:00] (CR) Ejegg: "wait, do you want to process messages where all of those fields are blank?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164499 (owner: Awight) [00:26:07] ejegg: yeah, I had to look myself... which means it's not clear, but... the required fields are tested in wmf_civicrm_verify_message_and_stage [00:27:05] oops, mixed media. [00:27:24] (CR) Awight: "yeah, I had to look myself... which means it's not clear, but... the required fields are tested in wmf_civicrm_verify_message_and_stage" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164499 (owner: Awight) [00:28:09] Mingle just got sliding window animations for the useless popup [00:28:18] Can't wait to hear what Anne thinks :) [01:25:28] atgo: mingle now featuring slower popups! [02:11:35] exit [02:12:32] d'oh, that's two nights in a row i forgot how to /quit [15:47:10] would anyone happen to know anything about this? https://meta.wikimedia.org/wiki/Wikimedia_Forum#Weird_NL_response_to_donations [16:21:38] ejegg: Good morning! [16:21:59] Or, you know... afternoon, I guess. [16:22:04] Hello! [16:22:08] How's it going? [16:22:29] I really do want to start using Good Aftermath on everybody... just as long as we all understand it is actually a cheery greeting. :) [16:22:38] Ah, it's going okay. [16:22:43] I'm on board with the aftermath! [16:22:46] Woot. [16:23:07] Timezones are inconsistent. Aftermath is constant. [16:24:02] ejegg: Aaaaanyway, I wanted to know if you would be okay doing a civi deploy today... but I think awight had to roll some things back, so we shouldn't roll back his rollback. [16:24:22] Hah, I was just about to suggest that myself [16:24:31] Let me see what this rollback is [16:24:35] Well, perfect then. [16:24:57] I've got a check-in about Worldpay that has a chance of going over the new standup time. If that happens, just go without me. [16:25:05] ok [16:25:13] Actually... we should do a round of fr-tech norms and values. [16:25:18] Soonish. [16:25:36] Not quite sure what that entails, but ok [16:25:36] One of them is usually "Don't wait for everybody to show up for regular meetings." [16:25:41] ahh [16:25:48] Couple reasons. [16:25:52] awight, hello! [16:26:06] One of them is that they may have been captured and detained by people who won't let them go until nobody has a chance of checking in. [16:26:10] bonjour! [16:26:15] awight: Yo. [16:26:18] You wfh today? [16:26:22] um context = meeting? [16:26:28] yeah, things got snaggly [16:26:28] yep [16:26:38] wt... /me looks around for the meeting [16:26:41] awight: Well, good luck with the snaggling. [16:26:42] awight: I was gonna deploy crm to run that exchange rate backfill [16:26:45] RRgh [16:26:50] awight: I was just talking about standup. [16:26:55] If I'm not there, just go without me. [16:26:56] but K4-713 mentioned you might have had to roll some stuff back [16:27:20] so, we moved standup to 9:30 or something? [16:27:27] are there things I should know about crm deploy? [16:27:40] ejegg: no, it should be kosher, lemme look. [16:27:44] rockin [16:27:49] awight: haha, no... it's still at 11. 9:30 would mean I'd be gone for all of them getting less blood in my caffeine stream. [16:27:59] yeah I cannot make 11:00 either, I'm meeting with major gifts [16:28:12] oh right, and I hang out at those too now [16:28:13] * K4-713 sighs [16:28:25] so, 11:30? [16:28:26] lol ok IRC / email standup it is [16:28:30] I'm beginning to think 11 is just a bad time. [16:28:31] or that, sure [16:28:32] or that [16:28:38] 1..10 [16:28:42] heh [16:28:42] jixies [16:28:51] erm ok looking at crm deployment [16:29:26] I'm definitely not going to cry if we don't have video chat standup today. [16:29:45] I'll probably be having a conniption fit about Worldpay accounts by that point in time, anyway. [16:30:18] * K4-713 joins g+ meeting just in time for my head to spin all the way around [16:30:45] ejegg: yeah the CRM deploy looks healthy [16:31:29] I can't remember what the hangup was earlier in the week... seems to have passed :) [16:31:29] good stuff [16:31:45] K4-713: the power of KRIST compels u [16:32:09] But I don't even believe in Jeebus. [16:33:06] * awight arranges for a very convincing TV-based miracle [16:37:43] :D [16:42:27] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/164574 [16:46:43] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/164574 (owner: Ejegg) [16:49:18] rsync_blasting imminent in crm land, please refrain from using your CB radio [16:49:31] woohoo! [16:50:04] !log updated crm from 6f66294607d132230ef82fb4867c37a8700bfd4e to ef68d9fe98a64e819ebbdddbe5e13f83037607ce [16:50:14] Logged the message, Master [16:52:51] ok, I'm going to try a couple days of backfill - just rate updates first, not the recalculation yet [16:59:30] Elliott, when are you writing these patches?? I keep running into newly minted features every time I turn around. [17:00:00] which one do you mean? [17:00:15] You review most of them! [17:01:47] OK, got all of our rates updated locally. gonna double check some totals before I recalculate anything. [17:02:48] the Card Juggler... [17:03:34] heh, i should learn to stay quiet while my hype man is burnishing my image [17:04:02] lol I'm simply noting the facts [17:04:30] plus: have you talked to the union about this overtime? [17:09:39] OK, total non-USD from 6/19-9/30 while we had out of date rates was recorded as $4.564 million [17:09:49] O_o [17:09:55] \o/ [17:10:13] * awight starts madly rolling pennies [17:10:50] The rates from 6/19-7/1 would have been pretty close, so I wonder if I should just recalculate this fiscal year. Who would make that call? [17:11:45] ejegg: tle@wmo [17:11:52] ty [17:12:00] you could also rattle PPena's cage [17:12:06] ok, will cc her [17:12:27] Why can you say the rates would be pretty close, though? [17:12:46] we had the rates from 6/19 [17:12:56] So volatile, though... [17:13:01] true [17:13:32] Thanks to Soros and... drone bombings. [17:13:36] awight sup? [17:13:55] PPena: hey, ejegg is about to fix the currency conversion glitch and has Q's 4 u [17:13:59] we have the rates now though - let me see if I can get a rough estimate of volatility over that time period [17:14:29] right. cos the rates became constant on 6/19, right? [17:14:32] (most rates) [17:14:50] PPena: just wondering if it's going to be a pain to recalculate things from last fiscal year [17:15:19] maybe this accounts for out <1% reconciliation error :) [17:15:26] s/out/our/ [17:16:15] from 6/19-9/29 we were using the 6/19 rates, but for the last 10 days of FY2014 those rates wouldn't have been /too/ stale [17:44:37] ejegg hmmm how many months are we off? I thought it started in July? [17:44:59] 6/19 was the last update we got till 9/29 [17:45:00] ejegg gotcha [17:45:15] Just about to send an email out with some details [17:45:25] meganhernandez seemed to want it all recalculated... [17:45:27] ejegg go ahead… just a month of difference [17:45:36] can we tell right off the bat how different will it be? [17:45:55] ejegg yeah stuff should be correct… so, lets do what we need to do :) [17:46:00] And, I mean, why wouldn't we? [17:46:03] I was looking at the last days of FY14, and the rates for the top currencies then were pretty similar [17:46:17] Oh, last fiscal. [17:46:25] I just didn't want to cause any paperwork headaches if the FY thing would need to be reopened [17:46:28] ejegg: are those currencies where we were using ECB, though? [17:46:43] nope, we weren't getting updates from anywhere. firewall [17:46:46] OH [17:46:50] lolcat [17:47:09] It would be a good idea to let finance know, but I think last year is a done deal at this point. [17:47:12] yeah, the card for 'make an alarm' is still a todo [17:47:30] OK, so we can correct it in Civi without putting a bee in anybody's bonnet [17:47:42] Hummm... [17:47:47] hehe. and then we got into currency speculation [17:47:59] Maybe let 'em know what we want to do and wait a bit before actually... [17:48:02] Just in case. [17:48:11] I like to think lots of people know things I don't. [17:48:21] I mean, I really hope that's the case. [17:48:25] ok, i've got an email ready to send to tle + pats + cc fr-tech [17:48:27] Scary. [17:48:54] Point being, they might know of a reason to leave it alone. [17:49:12] cool [18:05:57] bahaha, awight|meating. [18:06:07] Ew. [18:06:37] ejegg|brb: ...aw. [18:07:06] Actually, never mind. The logs answered my question. [18:29:01] AndyRussG: Is there a CN deploy on the schedule any time soon? [18:32:03] This is exciting: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2018?referrer[q]=2018&referrer[q_type]=&referrer[query_id]=q_13f953501&referrer[rank]=1&referrer[size]=1&referrer[ts]=10%2F03%2F14+18%3A31%3A48 [18:32:07] grr. [18:32:32] it's like a conga line of referrers [18:32:46] or just an array [18:32:57] ccogdill: oh, I think the query is off. [18:33:00] heh [18:33:05] not surprisign [18:33:13] "installments" is Civi code for: how many will there be total [18:33:17] "0" = forever [18:33:20] okay [18:33:30] but I do have 3 examples of contacts that didn’t recur [18:33:31] lemme make u a query that does what you wanted... [18:33:33] ooof [18:33:35] ok [18:33:37] cool thank you! [18:33:37] I can believe that [18:33:48] is there a field that is what I thought installments is? [18:34:36] no [18:34:45] u have to join and count [18:35:14] okay [18:35:27] erm, actually I lied, there is a number which roughly equals how many times we charged in GC, sorry. it's sort of an accident that it's there. [18:35:33] haha [18:35:36] can we keep it? [18:37:00] ccogdill: SELECT * from civicrm_contribution_recur WHERE create_date >= '2014-08-01' AND create_date < '2014-08-30' AND processor_id > 1 ORDER BY id DESC LIMIT 50; [18:37:13] ccogdill: well, it's twitchy cos it will not work for PayPal, for example [18:37:58] hmm okay [18:38:07] ccogdill: confirmed, it seems like 8-27 was the last time we recurred :'-( [18:38:20] that sounds about right [18:38:26] ... [18:38:51] What... happened... to the alarm? [18:39:05] thanks for the query help, btw! I’ll keep the processor_ID in my and paypal caveat as well [18:40:04] *in my notes [18:40:17] K4-713: those alarms fade in and out like a cellphone. [18:42:55] ccogdill: SELECT count(*) as num_payments,r.* from civicrm_contribution_recur r [18:42:58] join civicrm_contribution c on c.contribution_recur_id = r.id [18:43:00] WHERE create_date >= '2014-07-01' [18:43:03] GROUP BY r.id DESC [18:43:05] HAVING count(*) > 1 [18:43:52] okay thanks! I may want to talk about that one a little if we have another mysql powwow [18:43:58] but putting this in my notes for now [18:44:38] ccogdill: here's one that shows when GC recurring stopped: [18:44:39] ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'join civicrm_contribution c on c.contribution_recur_id = r.id\x0AORDER BYSELECT count(*) as num_payments,r.* from civicrm_contribution_recur r [18:44:44] join civicrm_contribution c on c.contribution_recur_id = r.id [18:44:47] join wmf_contribution_extra e on c.id = e.entity_id [18:44:49] WHERE create_date >= '2014-07-01' and gateway='globalcollect' [18:44:52] GROUP BY r.id DESC [18:44:54] one more try [18:44:56] HAVING count(*) > 1 [18:44:59] hehe [18:45:01] SELECT count(*) as num_payments,r.* from civicrm_contribution_recur r [18:45:04] join civicrm_contribution c on c.contribution_recur_id = r.id [18:45:07] join wmf_contribution_extra e on c.id = e.entity_id [18:45:09] WHERE create_date >= '2014-07-01' and gateway='globalcollect' [18:45:12] GROUP BY r.id DESC [18:45:14] HAVING count(*) > 1 [18:45:32] whew that one’s fancy [18:46:43] howdy! [18:46:51] atgo not sure if you saw this https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2018 but I just bugged Adam with it [18:46:54] hello! [18:47:03] :) [18:47:08] nope.. haven't seen it. my internet is terrrrrible [18:47:11] eek [18:47:16] old buildings [18:47:30] look at you query-ing [18:47:35] yeah islands are never great at internet [18:47:54] hahah, kind of querying incorrectly, but getting closer! and yeah I guess that’s to be expected [18:48:35] fwiw, I can confirm that subscriptions *created* before 8-27 are still recurring w/o glitch ( K4-713 ejegg ) [18:49:01] mmm… [18:49:02] https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=105244 [18:49:08] ... this is gonna be something really embarrassing that blames right back to me :) [18:49:09] was created 8/21 and did not recur [18:49:44] it sounds like you guys are on it (and i'm technically on vacation :)... let me know if i can help at all on Monday when i have better internet [18:49:44] https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=6660181 [18:49:59] haha k atgo! enjoy the sunshine! [18:50:00] also just checking up on WP - K4-713... is this one basically redundant to all the other auditing ones? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [18:50:26] ccogdill: that's a really weird one--we have a one-time contribution from 2008 for that guyu [18:50:28] thanks ccogdill :) [18:50:30] guy. as if it was deduped. [18:50:44] interesting awight. do you think the cutoff date was between 8/3 and 8/27? [18:50:51] and I know sometimes contacts are deduped [18:50:53] or used to be [18:51:06] I get kinda confused when you say we never do it :p [18:53:08] hehe. Just that the default is to not dedupe. I should find a better way to say that :) [18:53:40] haha okay that makes a little more sense [19:04:36] K4-713, ejegg: I'm licking the recurring card for a few minutes cos I think I did the damage (to subscription ID, preliminary to my hook refactor), but any minute now, I will be whisked away for the weekend. If I can't fix, then please accept this card as a simple gift :p [19:05:04] aww, you're too kind! [19:05:06] heh [19:05:19] enjoy the festival! [19:09:04] select (count(*) = 1) as broken, r.* from civicrm_contribution_recur r join civicrm_contribution c on c.contribution_recur_id = r.id join wmf_contribution_extra e on c.id = e.entity_id WHERE create_date >= '2014-07-01' and create_date < '2014-09-01' and gateway='globalcollect' GROUP BY r.id DESC; [19:29:36] haha [19:30:09] Oops... I ran off to lunch (because curry) and didn't say anything. [19:30:13] awight: You still here? [19:30:19] What's up with recurring? [19:30:35] K4-713: good choice [19:30:48] So the time came. I found the bug but cannot fix immediately. [19:30:53] AND civicrm_contribution_recur.trxn_id LIKE 'RECURRING GLOBALCOLLECT%' [19:31:06] wmf_civicrm/recurring.inc line 219 [19:31:16] What about that line? [19:31:40] however, I changed what we are storing in that column on 8-23 or so [19:31:41] We... whacked the old recurring transaction id format, didn't we. [19:31:45] yup. [19:31:54] I so regret everything I've done. [19:32:03] I remember thinking "This seems dangerous" and letting it go anyway. [19:32:03] I'm trying to write the JOIN so this works again. [19:32:08] So... I helped. [19:32:18] Moments like this I know I have not found my calling! [19:32:20] Team effort. [19:32:28] AAAAAAAADAM. [19:32:32] ...that was me calling. [19:32:55] I... may have a case of the "Incredibly punchy"-s today. [19:33:43] I found my special purpose!! [19:33:52] aaaaaahaha [19:34:13] If I had a dog, I'd seriously consider calling it sh*thead. [19:34:50] * awight dies. I had forgotten... [19:35:48] Oh hey... how can I tell what worldpay transactions are anonymous? [19:35:54] Everything is working now. [19:36:09] * K4-713 gets an evil "delete everyhing" glint in one eye [19:37:58] Oh, also: Do we know why paging through contribution search results is a complete lie? [19:39:02] GRR [19:39:24] so, there is no way to fix the failure retry unless I rollback the trxn_id change [19:39:32] cos there are no contributions to join on [19:40:12] yipes [19:46:31] (PS1) Awight: Fix new RGC subscription IDs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164634 [19:48:26] K4-713: ejegg|food: ^^ I think it's just that, plus backfill (which can wait for the weekend). [19:53:17] K4-713: your path has /usr/local on it? /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games [19:53:52] Jeff_Green: wasn't there a safety thing to prevent non-sudo drusshing? [19:54:18] Hur? No, it's out in... [19:54:28] /var/spool/audit/worldpay/ [19:54:45] And, I can totally non-sudo drush. All the time. [19:59:13] boo. [19:59:20] K4-713: ok but echo $PATH [19:59:28] Oh, that. [19:59:29] i can only sudo stuff in /usr/games for some reason [19:59:32] /usr/local/bin/drush is the thing u want [19:59:36] ejegg: bahaha [20:00:04] sudo nethack starts you in the gnomish mines [20:00:12] /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games [20:01:36] PPena: When does Dante work, usually? [20:02:29] I was trying to schedule a call so we wouldn't just play phone tag all day. [20:03:54] ...oh good. Mingle changed their card entry UI. Again. [20:04:24] This one is slower ! [20:05:11] now... with added grievances :p [20:06:13] Also, all the default fields are no longer visible. [20:06:19] On the "light" version of the card. [20:08:07] Well, cool. I totally forgot what I was going to add. [20:09:46] * awight|doorfloat coughs [20:22:23] K4-713: any preference what I work on next? [20:22:54] * K4-713 looks at current sprint [20:22:57] I'm ready to +2 that 'unfork' card, unless you want to have a look first [20:23:55] If it wasn't Friday, I'd say "payments wiki deploy plz". [20:24:27] oh, what's new since yesterday? [20:25:19] ah, state field in AU [20:25:52] Well, and the normalization of the recurring flag. [20:25:58] ohhh, yeah! [20:26:03] That seems like it would be, you know... good to have. [20:26:29] well, two little things like that seem relatively risk-free, even though Friday [20:26:32] ejegg: Did you get anywhere with the amazon logspam problem? [20:26:48] We could fix it in our Amazon account, i think [20:26:53] Oh, right. [20:26:59] just add &ffname=amazon to redirect URL [20:27:04] awight|doorfloat: Do you have the amazon creds? Or is that just me? [20:32:54] oh K4-713 , looks like the recurring fix is crm, not payments-wiki [20:33:17] Well... which recurring fix. [20:33:45] oh, is there another patch to write? [20:33:46] ejegg: I was talking 1995, ready to deploy. [20:34:07] ah, somehow I missed that [20:34:17] I think that is deployed [20:34:25] will verify & move [20:37:25] K4-713 just give him a call on the # I sent you- if hes not available will go to vm. [20:37:27] yep, that went out yesterday. Sorry I missed the card then [20:55:16] awight|doorfloat: You just missed it. [20:56:02] A truck *completely* took out the fire hydrant on the corner. [20:56:17] Geyser up to the 4th floor. [20:56:20] awesome cartoon geyser? [20:56:36] Four complete stories of water column. [20:57:25] I'll, ah... [20:57:28] email. :) [21:05:35] PPena: I called, and it went to a totally nondescript voicemail box. [21:05:37] Ah well. [21:15:10] we truly do work in Awesometown [21:15:27] ok have fun in the sprinklers for me [21:16:00] I relinquish claim to #2018 if anyone wants to ruin their weekend. There's an untested patch linked to in the description. [21:16:04] chow! [21:37:21] (PS1) Ejegg: Upgrade CiviCRM to 4.2.19 upstream [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/164675 [21:40:43] ejegg: This is frustrating. I have the creds for our amazon stuff, but they have apparently changed their entire portal layout without changing their documentation. [21:43:04] aww, phooey [21:44:00] at least we're not running on their cloud servers and getting rebooted at random times for a mystery patch [21:48:51] ejegg: Okay, after wrestling this thing for way too long... we don't have a configured return URL. [21:48:54] * K4-713 frowns [21:49:13] How in the H-... [21:52:48] Huh?? Okayyyyy [21:53:20] I found it. [21:53:28] code, or account setting? [21:53:33] amazon.adapter.php... line 220. [21:54:00] arrrr [21:54:33] i could swear I never saw it going over the wire in my testing [21:54:45] whee, i have code to work on! [21:55:04] Yaaay. [21:55:28] Maybe I should just... log into everything else we have with 3rd parties for the rest of the day. :p [21:55:54] It's totally silly accounts day. [21:55:55] if your eyes are up for more screen time, there's that civicrm patch to review ^^ [21:56:03] YAY. [21:56:17] but I guess I won't deploy that this evening [21:56:27] It's kind of telling that I would rather do code review than more screwing around with accounts, isn't it? [21:56:34] hah [21:56:43] in gerrit, no less [21:56:54] I... don't mind gerrit. [21:57:14] yeah, i guess i'm used to its quirks by now [21:57:22] Are we talking about the civi upgrade patch? [21:57:26] yeah [21:57:33] Ouch. [21:57:40] ...but okay. [21:58:08] we missed out on 4.2.18, so it's a couple of releases mushed together [21:58:22] ah, okay. [22:04:39] ejegg: What the heck is the point of this? https://gerrit.wikimedia.org/r/#/c/164675/1/CRM/Upgrade/Incremental/sql/4.2.19.mysql.tpl [22:04:41] haha [22:05:15] ...special thing that tells us we don't have a special thing this time? [22:05:34] autogenereated, I guess? [22:05:41] One would hope. [22:07:31] no db changes since 4.2.17, so that's one less thing to worry about during the upgrade [22:07:42] Yeah, I was thinking that too. [22:07:49] Wooo. [22:14:32] (CR) Katie Horn: [C: 2] Upgrade CiviCRM to 4.2.19 upstream [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/164675 (owner: Ejegg) [22:14:53] thanks! [22:16:19] oh phooey, I think I git reviewed that against the wrong branch :( [22:17:32] ...master? [22:17:41] should have been contrib [22:17:58] The topic is contrib. [22:18:25] yeah. master has all our changes, so that's another merge which gerrit just did for us... [22:18:41] Anyway, I should make sure the contrib branch actually gets 4.2.19 [22:19:02] Nuts. [22:19:46] well, jenkins would have squawked if their updates stepped on any of our local customizations [22:20:25] Yeah, it did not look like it was in any way related to any of our hacks. [22:20:39] The ones I know about, anyway. [22:31:34] OK, got contrib branch all set, and made sure the master merge was exactly the same changes. I think we're in good shape [22:31:52] still probably not gonna deploy till monday [22:32:15] ejegg: Yeah, I really wouldn't. :) [22:32:34] Deploy Fridays have this way of leading to Skeptical Saturdays. [22:32:43] nobody wants that [22:32:47] Noooope. [22:33:14] I mean, unless you were going to have one anyway. [22:34:48] Splendid Saturdays are more my thing. When I've got my bowler hat on, anyway. [22:34:54] * ejegg wishes he had a bowler hat [22:35:07] That can be arranged, you know. [22:35:34] brb, haberdasher [22:36:56] Hey: Why isn't the "kwisatz haberdashery" a thing? [22:37:01] hah! [22:37:11] a tight hat is the mindkiller [22:37:12] I have actually been wondering this for years. [22:38:10] i need to see that doc about how Jodorowsky was gonna make Dune [22:40:54] ejegg: I almost watched that on a flight this summer. [22:41:10] But, the stranger next to me was already watching it. [22:41:32] Then, I would have had to do intentionally creepy things for the entire remainder of the flight. [22:48:03] heh [23:01:08] (PS1) Ejegg: Parse ReturnURL to append order id correctly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164700 [23:01:28] (CR) jenkins-bot: [V: -1] Parse ReturnURL to append order id correctly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164700 (owner: Ejegg) [23:14:12] (PS2) Ejegg: Parse ReturnURL to append order id correctly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164700 [23:19:17] (PS3) Ejegg: Parse ReturnURL to append order id correctly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164700 [23:20:05] K4-713: looks like $wgAmazonGatewayReturnURL is blank in DonationInterface.php and not in DIFormSettings.php, so I just put a note in the commit message to fix it up on payments when we deploy [23:20:30] ejegg: What about $wgDonationInterfaceReturnURL? [23:20:39] Oh, wait. [23:20:47] No, that's going to be in LocalSettings. [23:21:01] ohhh [23:21:05] So, you'd have to log in to the deploy server and look. [23:21:45] ok [23:25:28] K4-713: I finally got the drupal / dash auth thing working! [23:25:42] YAAAAAYAYAYAYAY. [23:25:56] How soon can you deploy that? [23:26:02] :) [23:26:14] we need to add a bunch of modules to drupal [23:26:25] oh, I should check those in [23:26:39] after I delete all the ones i didn't end up using [23:27:37] I'll talk to Jeff monday about getting the stuff added + configured