[08:02:28] good morning atgomez! [08:02:32] howdddyy [08:02:42] I've been having issues with my google hangouts so I hope it werks [08:02:44] yeah me too [08:02:48] we could try something else? [08:02:51] :( [08:02:59] oh? [08:03:14] you have skype? [08:03:23] hmm I do but I haven't been able to log in [08:03:27] let me try [08:03:43] or we can do facetime since we both have mac [08:03:52] ... and then gotomeeting for screenshare or something [08:03:59] sigh. why is this still a thing? [08:04:31] I knowww right [08:05:12] yeah I can't log in to skype [08:05:29] I'm happy with facetime [08:05:37] but yeah need to screenshare [08:05:53] ok... check out gotomeeting [08:05:58] actually that might just work entirely [08:06:37] making a gotomeeting acct [08:06:50] ugh wants my cc info [08:07:03] no thanks [08:07:27] blargh [08:07:31] oh wait [08:07:43] I requested my skype password and thought I didnt' get it [08:07:46] but it was in another box [08:07:55] oh! [08:07:59] too many boxen [08:08:34] need a sec to get another email [08:09:30] k. when you get there, i'm annetgomez [08:10:22] I'm typing the password I just reset. it thinks it's wrong. I'm logged in on the web. [08:10:29] maybe caching fail [08:10:50] can you do it from the web somehow? [08:10:54] (not in app)? [08:11:35] i have no idea [08:11:51] doesn't seem so. [08:11:53] jeeze [08:12:32] hmm.. [08:12:45] want to see if google hangouts will work? [08:12:47] I dunno [08:12:48] this is... frustrating [08:12:50] yeah [08:12:52] yep [08:12:57] i'll clear my history reals quick first [08:13:05] sometimes that helps? [08:13:14] orly [08:13:15] ok [08:13:36] restarting browser too [08:13:47] ok i'm in it... we'll see [08:13:51] ASFN:AKJSHF:SKDFN [08:13:54] microphone. not working. [08:15:18] If you go to the settings gear thingie [08:15:24] and click a different mic [08:15:29] it usually helps for me [14:18:46] hi evryone [14:19:25] I have a question a bout an email that has been received by a lot of Dutch Wikimedians/Wikipedians about their donation not going through [14:20:27] this email is full of spelling mistakes and therefor a lot of people are wondering if this is an official notice or a phishing message [14:20:45] does anyone know who I could contact about this? [14:21:03] jessicarobell? [14:30:19] ter_burg: it's already answered on wikimedia forum [14:30:37] Nemo_bis: do you have a link? [14:30:43] ter_burg: https://meta.wikimedia.org/wiki/Wikimedia_Forum#Weird_NL_response_to_donations [14:32:02] Nemo_bis: thank you very much [14:34:04] I also wonder if the polish anti-malware website still has a notice about Wikipedia banners :) [16:15:27] (CR) Awight: [C: 2] Parse ReturnURL to append order id correctly (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164700 (owner: Ejegg) [16:16:43] (Merged) jenkins-bot: Parse ReturnURL to append order id correctly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164700 (owner: Ejegg) [16:18:32] ejegg: the standalone unfork is ready for more CR when you have the time... [16:19:33] (CR) Ejegg: Parse ReturnURL to append order id correctly (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164700 (owner: Ejegg) [16:20:04] Cool, I'll take a look! [16:30:24] (PS1) Ejegg: Add ffname=amazon in code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165006 [16:36:49] (CR) Awight: [C: 2] Add ffname=amazon in code (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165006 (owner: Ejegg) [16:37:08] (Merged) jenkins-bot: Add ffname=amazon in code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165006 (owner: Ejegg) [16:37:49] ejegg: fwiw, I've tried two different dead-end approaches for improving the repeated code in DI testing adapters... [16:38:09] Traits work fine, but are not available until php 5.4 :( [16:39:00] Sounds cool. I'll check 'em out! [16:39:17] Now I'm considering tackling the problem a bit more dramatically, changing production code to componentize and use dependency injection or something. [16:39:24] nothing to check out yet, unless you're curious. [16:39:47] hey awight are you working tuesday? [16:39:56] I meant traits - haven't played with 'em in PHP yet [16:39:57] meganhernandez: no [16:40:15] i’m talking with the-wub now & trying to find a time where we could ask some questions about buckets & cookeis [16:40:20] ejegg: here's the traits approach: https://gerrit.wikimedia.org/r/#/c/133508/ https://gerrit.wikimedia.org/r/#/c/133509/ [16:40:41] meganhernandez: ah ok. It might be best to do that over email, anyway, cos I was only tangentially involved in that development. [16:40:41] ah, cool [16:40:53] meganhernandez: that would give me time to ferret out meaningful answers :) [16:41:30] ejegg: here's a horrible approach that doesn't work for the same reason the FundraisingTranslationWorkflow is so hideous: https://gerrit.wikimedia.org/r/#/c/164140/ [16:41:52] (cos only proxy classes cannot change internal behaviors) [16:42:35] right, gotcha [16:49:37] hey Jeff_Green! [16:50:03] would you have a minute today to help me get the certificate from lutetium? i'm a little behind on following up with that [16:50:04] hey [16:50:07] sure [16:50:50] atgomez: you've got your ssh access working, right? [16:51:01] yes... i'm offsite right now though, does that effect it? [16:51:05] forgive my ignorance :) [16:51:11] nope [16:51:24] you're on mac? [16:51:34] yes [16:52:32] ok. fire up a terminal [16:52:41] and enter at the prompt... [16:52:47] cd ~/Desktop [16:52:54] awight: I'm going to check in some drupal modules for the auth bits. What do you think of putting them in vendor/drupal_modules and symlinking to there? [16:53:35] k Jeff_Green [16:53:48] now type: pwd [16:54:12] it should say something like /blah/blah/atgomez/Desktop [16:54:20] ya? [16:54:23] mmhmm [16:54:26] ok [16:54:38] now enter: scp lutetium:client_cert* . [16:54:46] note the dot at the end [16:55:03] that should copy two files from your homedir on lutetium, to the desktop on your mac [16:56:06] it gave me back a usage: line, but nothing on desktop [16:56:24] did you miss the dot? [16:56:29] nay [16:56:49] ejegg: interesting, I think it's really far outside of normal Drupal conventions. Not necessarily a bad thing, but what is your reason for putting under vendor/ ? Just to separate contrib and WMF code? [16:56:53] aha! [16:56:58] the space? [16:57:07] yes [16:57:08] the space. [16:57:09] I'm so annoyed... some twerp deleted my staff photo because... I was in the photo. [16:57:25] ok so Jeff_Green now i just follow the instructions you sent before [16:57:26] ? [16:57:29] awight that makes perfect sense! [16:57:34] atgomez: yep [16:57:35] awight: lame! [16:57:43] atgomez: lemme know if it goes awry [16:57:44] Jeff_Green: yeah, apparently I couldn't possibly have taken a photo with a timer. [16:58:01] I have to provide full metadata to the military history tribunal [16:58:02] thanks Jeff_Green... i've got to step into some meetings but i'll ping you later [16:58:07] awight: they haven't invented those yet [16:58:14] awight: Yeah, wanted to keep them apart from our code [16:58:52] ejegg: hrm. [16:58:58] Go for it, I guess [16:59:31] cool [17:00:49] ejegg: hrm on second though [17:01:08] vendor/ is not the right place, that should really be managed by composer, don't you think? [17:01:20] want to create modules/contrib? it can be a subrepo, whatev. [17:03:18] hmm. I guess composer should have its own space [17:06:02] Oh, and we don't even need symlinks for a /modules subdir. Yeah, sounds like the thing to do [17:06:56] Sorry for curtness. I'm bloody annoyed at Commons admins, but glad to have first-hand experience in why editors are running away... [17:08:03] oh, no worries. Sucks that they just zapped it without asking [17:08:27] Well, there was a blitz discussion in June, but then the deletion happened a few hours later without any notification being sent to me. [17:20:31] (PS1) Ejegg: Add modules for OAuth [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165017 [17:21:29] ejegg: is ctools an optional or required dependency? [17:22:02] oof, looks required. [17:22:04] (CR) Ejegg: [C: 2] "Looks good. Awesome to end the bifurcation and start decoupling payment stuff from mediawiki!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139452 (owner: Awight) [17:22:27] Couldn't find any more nits to pick! [17:22:46] lol I bet it will crash the server [17:22:58] hhe [17:22:59] heh [17:23:00] (Merged) jenkins-bot: Merge standalone framework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139452 (owner: Awight) [17:23:59] ejegg: just one more patch... https://gerrit.wikimedia.org/r/#/c/139476/ [17:24:04] yeah, i think ctools may only be used in the config screens though. Would be cool if we could somehow turn it off after we're done that [17:24:17] yeah it's so much code to not review... [17:24:55] cos of PCI... [17:25:38] boy, ctools really is chunky [17:25:55] erm we should really look at the rules again. Hopefully our PCI people can tell us exactly what needs CR. [17:26:04] It's possible that the CRM is exempt. [17:26:07] guess i could excise the plugins that aren't required [17:27:00] gonna see how much I can delete locally before oauth breaks [17:27:25] ejegg: well, maybe I'm full of it. [17:27:59] The CR thing is probably elective for CRM modules [17:28:04] also, this is interesting: https://www.drupal.org/node/1136032 [17:28:20] = what u just said [17:28:37] ah, nice! [17:28:56] blarrrhaha: 1 - You can write it yourself its very straightforward and its 2 lines of code [17:29:08] 2 - This is called only in services_menu() which caching is already supported by drupal [17:29:14] hah! [17:31:33] booo. » Closed (won't fix) [17:31:46] yeah, lame! [17:32:22] ok, ctools it is. Lemme just check in with K4-713 about the CR. [17:33:47] thanks! [17:52:04] pizzzacat: Do you want to try to have check-ins while you're remote? [17:54:14] hmm maybe like ad hoc? [17:54:35] K4-713: ejegg: high-prio CR: https://gerrit.wikimedia.org/r/#/c/164634/1 [17:59:56] K4-713 awight pizzzacat ejegg AndyRussG standup? yay i have working internet! [18:02:26] atgomez: we have no hardware... few minutes please? [18:02:32] sure [18:07:49] awight: any luck? [18:23:33] that was a drink with DATE JUICE [18:23:54] not to be confused with wine [18:27:38] pizzzacat: of course wine is only allowed during standup if you use a coffee mug [18:30:20] duly noted [18:32:18] Or if it's in sangria. Preventing scurvy is everyone's responsibility. [18:47:11] please excuse my ignorance, but how does one insert their signature on a wiki page? [18:47:32] pizzzacat: ~~~~ [18:47:45] Four is signature and timestamp, three is just signature. [18:47:53] wow really? hah [18:47:57] ok thanks! [19:33:27] useful. [20:11:51] (CR) Ejegg: "Looks good, but doesn't auto-rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139476 (owner: Awight) [20:12:17] (CR) Ejegg: [C: 2] Fix new RGC subscription IDs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164634 (owner: Awight) [20:12:22] (Merged) jenkins-bot: Fix new RGC subscription IDs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164634 (owner: Awight) [20:13:00] (PS8) Awight: new recurring charge API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139476 [20:13:07] (CR) Awight: "PS8: rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139476 (owner: Awight) [20:14:10] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/165086 [20:14:24] (CR) Awight: [C: 2 V: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/165086 (owner: Awight) [20:21:50] !log backfilled recurring GC glitch from FR #2018, 3342 records affected. [20:21:55] Logged the message, Master [20:25:46] (CR) Ejegg: [C: 2] new recurring charge API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139476 (owner: Awight) [20:26:05] (Merged) jenkins-bot: new recurring charge API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/139476 (owner: Awight) [20:27:52] meganhernandez: I don't see any more tests this afternoon, is it a good time for us to deploy a potentially mischievious change to payments? [20:30:52] K4-713: omg, classic: I see now that the alarm was testing for RECURRING GLOBALCOLLECT [20:34:18] awight: Hargh. [20:34:49] whooohahaha [20:35:05] This sort of excitement keeps me from staying young [20:35:05] ...? [20:35:20] I went all the way around. I'm twelve again. [20:35:34] ah, to be foolish and... taller than I should be [20:35:44] Good thing spacetime is curved. [20:35:47] *whew* [20:36:07] oh I see about Hargh. I thought you were replying to my threat one line up ^^^ [20:36:23] I'd like to deploy the DI unfork to payments and... see what heats up. [20:36:29] baha, no. Just do it. [20:36:34] <_< [20:36:36] >_+> [20:36:38] ow. [20:36:50] * K4-713 stuffs awight's eyeball back in [20:36:59] ascii slapstick :( we need aalib support in this channel. [20:37:24] * K4-713 sighs [20:37:31] I have no idea how this thing works anymore. [20:37:37] Awesome. [20:37:48] * awight looks for what u talking about. WorldPay DI? [20:37:59] Nope. [20:38:03] The IP velocity thing. [20:38:11] When I git blame that file, it's *only* my name. [20:38:40] that makes for a tough shell game. [20:38:48] HEY**look under this cup [20:39:20] Jeff_Green: fyi that check_fundraising_jobs alert is *not* going to get better :) for a month. [20:40:30] (PS1) Awight: One TY translation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165094 [20:40:44] awight: got a recommendation on an appropriate new threshold? [20:41:05] erm. 3350 for now would be great [20:41:27] :'-) [20:42:46] ...we missed 3300, didn't we? [20:43:09] warning 3350? [20:43:15] how about critical? [20:43:35] 5.0E25? [20:44:54] :) [20:45:21] maxint. [21:14:40] K4-713: how hard are we blocking on CR for MediaWiki core? [21:15:07] I guess that's in the category of more serious PCI stuff. [21:18:02] awight: hey, your deploy today wouldn't have had any effect on cluster-wide page load times, right? [21:18:11] it just correlates (timing wise) with: http://tinyurl.com/kznjpe3 [21:18:30] also, sorry I didn't see you later saturday evening :) [21:18:45] greg-g: OOF! [21:18:59] greg-g: I haven't deployed anything to the cluster today... [21:19:03] probably not you, probably parsoid [21:19:34] greg-g: and, sorry to scare the family away stupidly catching up on the basics! [21:19:57] haha [21:19:59] not at all [21:28:30] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/165102 [21:28:46] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/165102 (owner: Awight) [21:29:03] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/165102 (owner: Awight) [21:37:52] Jeff_Green: minor thing--I noticed that the diff is backwards for fundraising_code_update. eg, I just added these two files: [21:37:55] D gateway_common/WmfFramework.drupal.php [21:37:58] D gateway_common/WmfFramework.mediawiki.php [21:38:32] i feel like we've switched the diff around like 10x [21:39:12] I think there are two [21:39:17] the other one is working correctly now [21:39:42] sorry for perceived inefficiency :p [21:40:05] Hey, I'm just happy to not be sprinkling salt everywhere [21:40:14] there are four [21:40:18] or doing some insane git rebase merge from prod boxes [21:40:21] which one do you think is backward [21:40:23] Jeff_Green: oh heh [21:40:30] awight: To answer your question from earlier... [21:40:37] can you run it in verbose/debug mode and see which is wrong? [21:40:40] * K4-713 makes deeply stupid face [21:40:48] Jeff_Green: oh cool. [21:41:00] K4-713: hehe can you put that in writing [21:41:08] My stupid face? Yes. [21:41:23] I JUST DID. [21:41:26] OK I'm about to break payments [21:41:34] I'll need to borrow that face in a minute [21:41:36] awight: rad. [21:41:59] * K4-713 starts tailing logs for fun [21:44:52] * awight twitches nose at suspicious lack of smoke [21:46:03] ejegg: the ffname=amazon fix worked! [21:46:24] the silence of the logs [21:46:54] it's deafening! [21:47:27] All I hear is tinnitus [21:51:59] ejegg: back to this morning... I'm happy with the modules/contrib thing, but I realized there's one more alternative if you'd like--composer is able to download from external repos into the vendor dir, so we could use the hierarchy you originally wanted, but via composer. [21:52:36] I think a subdir is just fine [21:53:11] I was originally worried that some lint would complain, but it's non-voting for crm [21:53:39] aha. fwiw, most lint jobs have config files to allow ignoring directories. [21:53:46] oh, that too [21:56:27] ...did you guys get the amazon return URL thing out? [21:56:41] yep, awight just deployed it [22:03:51] yaaaaaaaaaaaaaaaay. [22:06:37] (PS2) Awight: DO NOT DEPLOY - Use the merged DonationInterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163764 [22:36:11] * awight kills self for cheating WmfFramework.* dependency injection [22:51:44] (PS3) Awight: WIP Use the merged DonationInterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163764 [22:52:18] (PS1) Awight: Start a new branch for Drupal and embeddeding [extensions/DonationInterface] (drupal) - https://gerrit.wikimedia.org/r/165126 [22:52:33] (CR) jenkins-bot: [V: -1] Start a new branch for Drupal and embeddeding [extensions/DonationInterface] (drupal) - https://gerrit.wikimedia.org/r/165126 (owner: Awight) [22:53:36] (PS2) Awight: Start a new branch for Drupal and embedding [extensions/DonationInterface] (drupal) - https://gerrit.wikimedia.org/r/165126 [22:53:52] (CR) jenkins-bot: [V: -1] Start a new branch for Drupal and embedding [extensions/DonationInterface] (drupal) - https://gerrit.wikimedia.org/r/165126 (owner: Awight) [22:56:02] (PS3) Awight: Start a new branch for Drupal and embedding [extensions/DonationInterface] (drupal) - https://gerrit.wikimedia.org/r/165126 [22:56:18] ejegg: ^^ if you're bored [22:56:37] awight: thanks! Gotta run now, but will investigate later. [22:56:42] k [22:58:57] (PS1) Awight: Manage DonationInterface through Composer [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/165127 [23:00:05] (PS4) Awight: WIP Use the merged DonationInterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163764 [23:58:36] (PS4) Awight: Start a new branch for Drupal and embedding [extensions/DonationInterface] (drupal) - https://gerrit.wikimedia.org/r/165126