[00:01:27] (PS1) Awight: Composer packaging to make us available as a library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165137 [00:01:29] (PS1) Awight: fixups for unfork [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165138 [00:02:01] (PS5) Awight: Start a new branch for Drupal and embedding [extensions/DonationInterface] (drupal) - https://gerrit.wikimedia.org/r/165126 [00:33:54] ewulczyn____: https://wikitech.wikimedia.org/wiki/Special:UserLogin/signup [00:36:42] ewulczyn____: https://gerrit.wikimedia.org/r/#/c/53279/8 [00:40:03] awight: ejegg|away Hi... for deploying CN patches, looking at slots here... https://wikitech.wikimedia.org/wiki/Deployments#Week_of_October_6th [00:40:30] And gonna watch this... http://www.youtube.com/watch?v=Qfm5ZlZFkUs&feature=youtu.be [00:44:44] AndyRussG: aww, I thought it was going to be something funny :) [00:44:54] thanks for the link, tho, I could use that! [00:45:18] heh might yet be funny, I'll be able to tell you after I watch it [00:46:03] I'd be surprised if it's completely devoid of jokes [00:47:10] have fun! [00:47:19] :p [00:47:20] Thanks! :) [02:37:33] (PS4) AndyRussG: WIP Schema for persistent global allocation tracking [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/159403 [04:10:20] (CR) Springle: [C: -1] WIP Schema for persistent global allocation tracking (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/159403 (owner: AndyRussG) [08:46:47] (PS1) Siebrand: Update translation of Dutch thank you. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165179 [10:14:02] Hi the-wub! How are you today? [10:14:56] hi jessicarobell. i'm good thx, how are you? got rid of that cold? [10:15:20] good to hear. I am better thanks! Getting there.. [10:15:49] It just got so cold all of a sudden. But I guess it's fall for real now! :) [10:17:01] Could I ask you to please send me the link to the thank you landing page when you have a minute? Can't find the link.. [10:34:06] jessicarobell: you mean https://wikimediafoundation.org/wiki/Thank_You/en or something else? [10:34:33] That's what I mean. Thanks the-wub! [10:37:26] the-wub: I realized that there are no social sharing buttons on the italian page https://wikimediafoundation.org/wiki/Thank_You/it. Would that take a lot of work to add? [10:41:43] I don't think we have translations for the messages to be shared [10:42:04] "I just donated to Wikipedia!" and "I just donated to #Wikipedia. Help keep it free! #keepitfree" [10:42:49] fixing TY pages is a project that keeps getting pushed down the road... :( [10:45:24] Ok. I can get those messages translated, no problem. But shouldn't we use what's on the English page at the moment: "Tell the world that you support Wikimedia: tweet it with hashtag #keepitfree!" ? [10:46:20] I know the feeling! I want to clone myself at the moment… [10:47:31] oh yeah, there's that message too. but I don't think it's so important [10:47:52] the ones I gave are the messages actually shared when you click the buttons [10:50:19] ah right! Ok. I will work on getting these translated. thanks the-wub. [13:00:41] (CR) Ejegg: [C: 2] fixups for unfork [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165138 (owner: Awight) [14:05:50] (CR) Pcoombe: [C: 2] One TY translation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165094 (owner: Awight) [15:17:39] (PS1) Ejegg: Fix Silverpop import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165217 [15:20:41] (CR) Ejegg: [C: 2] Composer packaging to make us available as a library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165137 (owner: Awight) [15:21:03] (Merged) jenkins-bot: Composer packaging to make us available as a library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165137 (owner: Awight) [15:21:14] (Merged) jenkins-bot: fixups for unfork [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/165138 (owner: Awight) [15:29:06] (Abandoned) Ejegg: Fix Silverpop import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165217 (owner: Ejegg) [15:29:20] (PS1) Ejegg: Fix Silverpop import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165224 [17:21:10] greg-g: Hi! I'm pinging 4 a CentralNotice deploy :) [17:21:42] AndyRussG: what's up? [17:22:35] Not to much... Just have a few CentralNotice patches that need to be deployed. I don't think I have deployment rights, was just watching the deployment training video to get a better idea of how it works, tho [17:23:29] https://gerrit.wikimedia.org/r/#/c/156140/ [17:23:55] https://gerrit.wikimedia.org/r/#/c/157502/ [17:24:26] https://gerrit.wikimedia.org/r/#/c/158652/ [17:25:42] greg-g: I think I'm supposed to ping you [17:25:46] to reserve a spot [17:25:51] https://wikitech.wikimedia.org/wiki/Deployments#Week_of_October_6th [17:26:09] (I might have misunderstoood tho) [17:27:44] ejegg: Hellooooo... [17:27:48] Can I have you read something? [17:27:52] Jeff_Green: You too. [17:27:59] Hi K4-713! [17:28:11] Sure, what's the reading material? [17:28:18] Will be an email soon. [17:28:21] cool [17:28:23] About all the self-reviews. [17:28:45] oh, I just got some more technical advice on that [17:29:27] git log --show-notes=review tells you a bunch of stuff that you'd otherwise get from the gerrit query [17:29:52] but it's a lot easier to limit to a specific branch [17:32:45] ejegg: Email sent. [17:32:45] If you have new/update information I should include, that would be cool too. [17:33:15] right-o... [17:33:18] * ejegg looks at email [17:34:18] K4-713: will read [17:34:27] ty [17:41:29] blargh... I think I'm about to come down with a case of exploding headache. [17:41:33] Sad. [17:44:02] K4-713: the log / awk script I'm trying out now seems to filter out most of the self-reviews, but I may just be doing the log wrong. I'll send it around. [17:44:33] ejegg: I'd love to hear that the problem is not as big as we think. [17:44:34] gets it down to 35! [17:44:59] Oh... well that's not so bad. [17:45:02] But I'll check against the bigger list to make sure I'm not ignoring stuff that should be in there [17:45:24] I still want to... not have to go all code janitor on this. [17:45:41] Awesome. [17:57:40] Hmmm on tool labs, metawiki database, I get permission denied to view the central notice tables :( [17:57:44] K4-713: looks good to me [17:57:55] Jeff_Green: Thanks. :) [18:01:36] ejegg|brb: standup. [18:01:39] But you're brb [20:56:44] !log altered worldpay account settings for France on payments [20:56:51] Logged the message, Master [21:00:41] ejegg: Anything happen with that +2 bizness? [21:06:01] which +2 bizness? the self-merges? [21:09:05] K4-713: i sent an email with the log cmd, awk script, and results [21:10:25] ejegg: Sorry. I apparently did finally go blind today. [21:10:33] Also I never learned to read. [21:10:40] ...I have dragon. [21:10:41] :p [21:10:42] heh [21:11:27] after the first set of results, im suspicious of the low number [21:11:48] Were you able to spot-check any of the things that got left behind? [21:12:19] but i think that first set included lots of commits that werent between 1.22 and 1.23 [21:12:26] Aaaha. [21:12:40] as well as some cherrypicks that had actually been reviewed [21:12:47] Okay, well... maybe I'll refrain from running this one up the flagpole for now. [21:13:20] If we really do only have 35 to eyeball... we can do that. [21:13:28] And then we can slap people. [21:13:51] yeah, i guess the bad habits arent as rampant as i was afraid they wre! [21:14:16] I was... too overwhelmed to even be annoyed. [21:14:23] When we thought it was 350. [21:16:09] also, i need to use awk more often. it's awesome for this kind of thing [21:19:29] * K4-713 shakes self [21:19:36] What was I doing. [21:19:57] Oh, right. [21:20:32] Discovering that there is a hilariously missing piece of wiring-up in our implementation of WorldPay. [21:21:56] ejegg: Check this out. [21:21:58] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDonationInterface/b6de0125f76c6fd4ab4bf5c28a40bf12ccbfb6f8/worldpay_gateway%2Fworldpay.adapter.php#L762 [21:22:37] Spent an hour trying to figure out why the response errors were always empty. [21:22:44] * K4-713 facepalms [21:23:11] I'm not a doctor, but I think there should be more there. [21:24:51] hah! [21:25:08] aww, man [21:25:39] Ah well. I've got it now. [21:26:34] $response isn't even a DOMDocument! [21:27:21] ooh, just an array! [21:27:26] yep [21:27:33] The hard part... has been done. [21:27:53] All we have to do here is be able to tell the difference between [problem] and [!problem]. [21:28:03] wait, globalcollect says its an array in @param, but then does a ->getElementsByTagName on it! [21:28:16] maybe it is a doc? [21:28:17] * K4-713 squints [21:29:07] That's it. [21:29:12] I'm... clearly done for. [21:29:20] it's whatever comes out of getFormattedResponse... [21:29:24] Can't read, went blind, broken type checking. [21:29:37] ...which could be either [21:29:45] depending on getCommunicationType [21:29:56] Yeah, it's never namevalue. [21:30:01] ok [21:30:47] The cool thing is that we already have this mechanism that takes a numeric code and tells you if it's a problem or not. [21:30:50] For that request type. [21:30:56] I just have to... you know, find that part. [21:31:27] is this the ranges -> status mapping, or the processResponse potential retry logic? [21:31:59] processResponse is after this in do_transaction. [21:32:08] Because if it's an error, you can probably give up earlier. [21:32:15] ah, so it is [21:32:19] It's the error_map. [21:33:09] Actually, I lied again. [21:33:15] It's the return_value_map. [21:33:19] ...may not be an error. [21:33:52] I have this sinking suspicion that they used to be the same thing, though. [21:34:07] baaaaaah. [21:34:35] AHA [21:34:36] findCodeAction [21:35:35] ok, which is populated by those addCodeRange calls [21:35:40] yep [21:36:11] but even 'failed' means 'try again till the retry limit' [21:36:23] You should just be able to pass in the transaction name you just ran, the relevant node name, and a number... and find out if you're failing or not. [21:36:29] ejegg: Ha, not always. [21:36:39] There are a limited number of retries, and not everything retries. [21:37:05] That was more obvious until they split do_transaction into multiple functions. [21:56:39] * K4-713 headscratches at latest WP email [21:59:03] WP email w/ lice? [21:59:16] They want me to change the card type I'm sending to them. Only I can't see any place I'm sending that. [21:59:19] They are sending it to me. [21:59:26] ...wat. [22:00:05] Hmm sounds like they're the ones that need a good headscratch [22:01:12] Maybe they have us convert that data to a random number and send that. [22:01:29] ...sounds like something they would do. [22:03:21] * K4-713 chokes [22:03:53] I found an array in which we turn codes into card types, but... yeah, they totally send those back to us. Not the other way. [22:04:07] * K4-713 burbles [22:04:25] Also, they want me to send something we don't have in there. [22:04:35] weird... [22:04:43] I don't even... [22:04:51] hm. [22:05:22] Maybe there's a pdf that would barely fit in a 3-ring binder if printed, that has the code in it somewhere. [22:11:46] * AndyRussG hopes K4-713 is OK... [22:12:08] I'm always alright. [22:12:54] :) [22:15:04] K that's good :)