[00:42:45] <AndyRussG>	 ejegg|away: the explanation is that the tip of wmf_deploy has a cherry-picked jQuery.JSON fix. That's why Special:Version is wrong
[03:56:17] <grrrit-wm1>	 (PS2) Awight: Update legal text on landing page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166567 (owner: Ssmith)
[03:56:35] <grrrit-wm1>	 (CR) jenkins-bot: [V: -1] Update legal text on landing page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166567 (owner: Ssmith)
[04:41:18] <grrrit-wm1>	 (PS3) Awight: Update legal text on landing page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166567 (owner: Ssmith)
[04:41:35] <grrrit-wm1>	 (CR) jenkins-bot: [V: -1] Update legal text on landing page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166567 (owner: Ssmith)
[04:42:32] <grrrit-wm1>	 (CR) Awight: "PS 3: escape ampersands in the tax deduction URL." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166567 (owner: Ssmith)
[04:57:37] <grrrit-wm1>	 (PS4) Awight: Update legal text on landing page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166567 (owner: Ssmith)
[05:16:19] <grrrit-wm1>	 (CR) Katie Horn: [C: 2] Update legal text on landing page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166567 (owner: Ssmith)
[05:17:16] <grrrit-wm1>	 (Merged) jenkins-bot: Update legal text on landing page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166567 (owner: Ssmith)
[05:39:47] <grrrit-wm1>	 (PS1) Katie Horn: Merge branch 'master' into deploy-payments_1.22 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/166715
[05:41:36] <grrrit-wm1>	 (CR) Katie Horn: [C: 2] "Merge for deploy" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/166715 (owner: Katie Horn)
[05:41:53] <grrrit-wm1>	 (Merged) jenkins-bot: Merge branch 'master' into deploy-payments_1.22 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/166715 (owner: Katie Horn)
[05:54:38] <K4-713>	 !log updated payments to 944596744e0de23fee098
[05:54:45] <morebots>	 Logged the message, Master
[05:55:08] <K4-713>	 ...and now, we eat cookies for an hour.
[16:12:52] <K4-713>	 pizzzacat: Heya.
[16:12:55] <K4-713>	 I just got in.
[16:16:31] <pizzzacat>	 hey
[16:16:42] <pizzzacat>	 I should probably go out of doors for this call..
[16:16:51] <pizzzacat>	 stuffy
[16:16:54] <pizzzacat>	 need a walk!
[16:16:55] <K4-713>	 I don't have a room or anything right now.
[16:17:06] <K4-713>	 Also, atgo is still not in yet.
[16:17:08] <pizzzacat>	 ah ok.
[16:17:29] <K4-713>	 How about we give it another... 10-ish minutes and then go anyway.
[16:17:38] <pizzzacat>	 ok!
[16:23:39] <K4-713>	 pizzzacat: Sent you a meeting invite. Going to get set up now.
[16:23:50] <pizzzacat>	 ok, cool
[16:43:13] <ejegg>	 K4-713: anything I should transmit to the Scrum of Scrums?  Gonna send an email today since we're getting Civi training
[16:56:29] <ejegg>	 atgo__: anything you want me to add to scrum of scrums?  Just sending them notes today since we have Civi training
[17:07:12] <ejegg>	 nick ejegg/civitrain
[17:07:15] <ejegg>	 derp
[17:35:29] <grrrit-wm1>	 (PS3) Ejegg: Don't retry on certain errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166573
[17:35:31] <grrrit-wm1>	 (PS2) Ejegg: Penalize toxic card IPs in velocity filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166678
[17:35:33] <grrrit-wm1>	 (PS5) Ejegg: Another safeguard around MC-forbidden retries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166607
[17:42:00] <AndyRussG>	 Is there standup before the afternoon sit-down?
[18:24:04] * awight wipes brow
[18:28:14] <grrrit-wm1>	 (CR) AndyRussG: WIP Schema for persistent global allocation tracking (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/159403 (owner: AndyRussG)
[18:28:36] <AndyRussG>	 Hi awight :)
[18:29:28] * AndyRussG offers cloth for brow-wiping
[18:31:19] <awight>	 eew, this rag is already sweaty :p
[18:33:26] * AndyRussG blinks and thinks about buying laundry soap
[18:36:47] <AndyRussG>	 NETime you'd like to check a few more bucket details, that'd be fantastic, don't mean to weigh you down with more stuff, there's not a rush I don't think :)
[18:40:13] <awight>	 AndyRussG: happy to do that now, or any time today
[18:40:29] <AndyRussG>	 awight: cool thanks!
[18:40:44] <AndyRussG>	 Back 2 the etherpad? http://etherpad.wikimedia.org/p/bucketbingo
[18:41:02] <awight>	 sure, ooh more notes
[18:41:28] <AndyRussG>	 mmm U can disregard those, basically used them for the doc I put up
[18:41:37] <awight>	 btw, I did not write this ;) so I'm spelunking as well
[18:42:37] <AndyRussG>	 right! yeah I'm just not fully sure I'm right about a few details
[18:43:01] <AndyRussG>	 Looking specifically at the points where there are three or more *'s in a row...
[18:43:07] <awight>	 hehe ok
[18:44:45] <awight>	 AndyRussG: I'm pretty sure the assertion about refreshing the cookie expiration is true
[18:44:57] <AndyRussG>	 K that's the main key point
[18:45:00] <awight>	 The bannerController reads the old cookie in, parses the value, then sets the cookie again
[18:45:13] <awight>	 that will re-up the expiration time, AFAIK
[18:45:22] <AndyRussG>	 Looks to me like it only sets it again if it can't get a value
[18:46:31] <awight>	 AndyRussG: I think you're right
[18:46:42] <AndyRussG>	 bbff OK thanks
[18:46:54] <AndyRussG>	 I did actually try it out and apparently got that behaviour
[18:46:56] <awight>	 yep, thanks for the double-check
[18:47:47] <AndyRussG>	 np, thanks much also for helping out
[18:47:58] <AndyRussG>	 So this concern is warranted? https://www.mediawiki.org/wiki/Extension:CentralNotice/Buckets#Cycling_bucket_cookie_expiries.3F
[18:48:13] <grrrit-wm1>	 (PS5) Awight: WIP Use the merged DonationInterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163764
[18:48:34] <awight>	 AndyRussG: oof, yeah good catch
[18:48:45] <awight>	 We definitely want to make bucketing work per-test
[18:49:16] <AndyRussG>	 OK
[18:51:33] <AndyRussG>	 Yeah that's what I was imagining
[18:51:33] <awight>	 On that note, we need to find a way to introduce the concept of a "test", but without affecting... anything else :)
[18:52:53] <AndyRussG>	 I think for now some simple code to make all the buckets reset at once and/or make them per-campaign would be sufficent, maybe?
[19:07:20] <K4-713>	 ejegg: Cool! I will look at those as soon as I get back to my desk.
[19:07:25] <grrrit-wm1>	 (PS5) AndyRussG: WIP Schema for persistent global allocation tracking [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/159403
[19:08:40] <ejegg>	 Rockin, thanks!
[19:13:19] <ejegg>	 Oops, one more set of revisions coming up
[19:17:14] <grrrit-wm1>	 (PS3) Ejegg: Penalize toxic card IPs in velocity filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166678
[19:17:16] <grrrit-wm1>	 (PS6) Ejegg: Another safeguard around MC-forbidden retries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166607
[19:38:32] <grrrit-wm1>	 (PS1) Ejegg: Orphan adapter tests for MC retry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166803
[20:05:38] <grrrit-wm1>	 (PS1) Awight: Upgrade to Drupal 7.32 upstream [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/166821
[20:05:40] <grrrit-wm1>	 (PS1) Awight: Merge contrib [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/166822
[20:06:24] <grrrit-wm1>	 (PS1) Awight: Update drupal submodule to 7.32 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/166828
[20:07:13] <grrrit-wm1>	 (PS1) Awight: Merge master into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/166836
[20:08:42] <ejegg>	 awight: There may be a Civi update ready to go too.  Let me see if the submodule bump ever made it into deployment
[20:11:44] <grrrit-wm1>	 (PS1) Ejegg: Update CiviCRM submodule to 4.2.19 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/166862
[20:13:11] <grrrit-wm1>	 (CR) Ejegg: [C: 2] Update CiviCRM submodule to 4.2.19 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/166862 (owner: Ejegg)
[20:13:13] <grrrit-wm1>	 (Merged) jenkins-bot: Update CiviCRM submodule to 4.2.19 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/166862 (owner: Ejegg)
[20:17:07] <awight>	 ejegg: any special instructions?  I assume we need drush civicrm-upgrade-db?
[20:17:26] <ejegg>	 nope, no db schema changes since 4.2.17
[20:18:37] <awight>	 ejegg: confirmed.
[20:18:44] <awight>	 wanna deploy that?
[20:19:19] <ejegg>	 sure!
[20:20:28] <awight>	 ejegg: is there a card for bounce processing ops work?
[20:20:32] <awight>	 or RT ticket?
[20:20:38] <ejegg>	 let me see
[20:20:52] <awight>	 It fell off of Mingle...
[20:21:03] <awight>	 off the right end, happily
[20:21:49] <ejegg>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1862
[20:22:15] <awight>	 thx, I'm kicking that back into the sprint...
[20:22:56] <ejegg>	 Though I guess we won't be following those instructions exactly.  Jenkins job instead of cron, and Jeff_Green may have some requirements for the address
[20:23:18] <awight>	 atgo____: I see you pulled this out of the queue a month ago... wondering why? ^^
[20:24:02] <atgo____>	 during sprint planning, i'd guess
[20:24:06] <awight>	 IMO it's a priority cos we don't want to jiggle it when the volume increases.
[20:24:06] <atgo____>	 it was exactly 4 weeks ago
[20:24:11] <awight>	 I'm happy to be wrong though
[20:24:12] <grrrit-wm1>	 (CR) Ejegg: [C: 2] "What's this shiny needle doing in this haystack?" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/166821 (owner: Awight)
[20:24:30] <atgo____>	 everythign can't be a priority... i'm not saying we shouldn't do it, but that the sprint should reflect what is actually going to happen in the upcoming 2 weeks
[20:24:57] <awight>	 ejegg: yeah man, subtle.  + foreach (array_values($data) as $i => $value) {
[20:25:07] <atgo____>	 put it back in
[20:25:21] <atgo____>	 if you'd like
[20:25:49] <atgo____>	 we also agreed that the supertasks that we're focusing on completing are prepping for big english, updating GC audit, and dash
[20:25:55] <atgo____>	 and Civi CI
[20:26:09] <awight>	 atgo____: it's mostly Jeff_Green work, any opportunity to make his life more difficult :D
[20:26:55] <grrrit-wm1>	 (CR) Ejegg: [C: 2] Merge contrib [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/166822 (owner: Awight)
[20:27:12] <Jeff_Green>	 whut
[20:27:15] <awight>	 atgo____: do we have a tag for things like this bounce processing, which are not directly aligned with online fundraising, but cannot be jiggled until 2015?
[20:27:34] <Jeff_Green>	 oh that
[20:27:47] * awight gives Jeff_Green a hatchet to gather wood until the child protective people leave
[20:27:51] <awight>	 :p
[20:27:52] <grrrit-wm1>	 (CR) Ejegg: [C: 2] Merge master into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/166836 (owner: Awight)
[20:27:59] <atgo____>	 we have the supertask about bounce processing
[20:28:03] <atgo____>	 why does this need to happen before 2015?
[20:28:16] <Jeff_Green>	 iirc we already route those sanely, and they sit in an IMAP account on barium awaiting processing
[20:29:22] <awight>	 atgo: I'm not sure it does.  yeah and synchronizing the Silverpop opt-outs is probably even more important at this point
[20:29:29] <Jeff_Green>	 /@donate\.wikimedia\.org$/ civimail
[20:29:30] <awight>	 erp.  ok good thing you're aroung.
[20:29:34] <awight>	 d
[20:29:44] <Jeff_Green>	 we route everything to donate.wm.o to a local account 'civimail' on barium
[20:29:45] <atgo>	 oooh you're saying that shouldn't be messed with before 2015? like frozen? awight
[20:30:46] <Jeff_Green>	 and there are 12K messages in that user's inbox
[20:30:54] <awight>	 atgo: well... silverpop we can jiggle.  but we probably want to freeze the code and infrastructure around thank-you and CiviMail
[20:31:04] <atgo>	 got it
[20:31:21] <awight>	 Yeah, just to not risk a million spams
[20:31:39] <atgo>	 no tag as of now. let's chat a minute about this during the shrimp prawning. i'm not sure how worthwile it's going to be to add tags to a zillion cards in the backlog
[20:31:47] * awight gets out of this business :)
[20:31:47] <atgo>	 so much as maybe make a list of areas to be avoided somewhere
[20:32:05] <atgo>	 :P
[20:33:37] <grrrit-wm1>	 (CR) Ejegg: [C: 2] "Whoops, I should have +2ed this before the merge into deploy!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/166828 (owner: Awight)
[20:33:41] <grrrit-wm1>	 (Merged) jenkins-bot: Merge master into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/166836 (owner: Awight)
[20:34:00] <awight>	 ejegg: can u remind me how CiviMail and thank-you bounce processing are/if are related?
[20:34:28] <ejegg>	 Bounce processing needs a CiviMail mailing record to get the VERP header
[20:34:34] <awight>	 I guess the priority thing is TY bounce processing...
[20:34:36] <awight>	 aha ok
[20:34:52] <awight>	 right, so your patches create those activity records
[20:34:56] <awight>	 which is rad
[20:35:05] <ejegg>	 TY sender adds the record and the VERP header
[20:35:16] <awight>	 are we still blocked on deciding whether to store rendered TYs?
[20:35:16] <ejegg>	 then normal bounce processing catches and marks the address
[20:35:19] <awight>	 cool
[20:35:37] <Jeff_Green>	 is there any cross-check in civi on the VERP?
[20:35:52] <ejegg>	 We're cool to store them, but K4 would like to decide on a retention period
[20:36:00] <awight>	 Jeff_Green: like, a signature to prove it's not spoofed?
[20:36:13] <Jeff_Green>	 i.e. is there anything to stop me from sending messages to bounce-jgreen=wikimedia.org@donate.wikimedia.org and getting that address on the do-not-mail list?
[20:36:15] <ejegg>	 Jeff_Green: yeah, there's some kind of hash.  Let me see how they make it
[20:36:28] <ejegg>	 It's definitely cryptic
[20:36:32] <Jeff_Green>	 ha
[20:36:43] <ejegg>	 though maybe not cryptological
[20:36:49] * awight +1's the pundraising
[20:38:13] <grrrit-wm1>	 (PS6) Awight: WIP Use the merged DonationInterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163764
[20:40:17] <ejegg>	 sha1 of jobId, emailId, and contactId, salted with time().  That's just stored in the mailing queue event table and matched on incoming bounce
[20:40:24] <ejegg>	 So pretty tough to spoof
[20:42:30] <Jeff_Green>	 great
[20:49:06] <awight>	 ejegg: https://gerrit.wikimedia.org/r/#/c/165127 if u can
[20:49:35] <awight>	 Thanks again for throwing open that composer door, btw.  We've been managing dependencies sooo ad-hockedly
[20:50:26] <ejegg>	 oh, thank you for suggesting it!
[20:51:28] <awight>	 It's working out very nicely, especially the autoload stuff.
[20:52:00] <ejegg>	 aargh, permissions issues updating staging civi via git again
[20:54:29] <ejegg>	 Jeff_Green, awight: is there a reason we don't deploy staging civi like we do everything else?
[20:55:26] <grrrit-wm1>	 (CR) Ejegg: [C: 2] Manage DonationInterface through Composer [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/165127 (owner: Awight)
[20:55:53] <grrrit-wm1>	 (CR) Ejegg: [V: 2] Manage DonationInterface through Composer [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/165127 (owner: Awight)
[20:58:57] <awight>	 ejegg: AFAIK, we don't have a rigorous staging deployment process, anywhere.
[20:59:17] <awight>	 I still don't understand when we deploy to payments staging; plus, there is a production job running there.
[20:59:20] <ejegg>	 except the payments wiki, right?
[20:59:30] <ejegg>	 oh, weird
[20:59:55] <awight>	 Civi staging isn't used like a normal staging deployment...  more like a robust development deployment.
[20:59:56] <ejegg>	 ok, onward to production!
[20:59:58] <awight>	 hehe
[21:00:12] <awight>	 If you have thoughts about the staging protocol, please write!
[21:00:33] <awight>	 It's pretty messy at WMF in general... test vs test2 vs beta...
[21:02:58] <grrrit-wm1>	 (PS1) Ejegg: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/166878
[21:03:42] <grrrit-wm1>	 (CR) Ejegg: [C: 2] Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/166878 (owner: Ejegg)
[21:04:44] <ejegg>	 Yeah, I really like the scripts on frack, with their change previews and random codes to prevent typing yes by instinct
[21:04:58] <awight>	 yes!
[21:06:45] <ejegg>	 !log updated crm from 05e5388df34059c651223d53fb2986ac1c39a2d9 to d6a75b6df4482de61da372fa653902db7ca12766
[21:06:50] <morebots>	 Logged the message, Master
[21:08:45] <grrrit-wm1>	 (PS1) Awight: Move MWException stub into its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166880
[21:08:58] <grrrit-wm1>	 (PS2) Awight: Move MWException stub into its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166880
[21:09:10] <grrrit-wm1>	 (Abandoned) Awight: Move MWException stub into its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166880 (owner: Awight)
[21:21:20] <AndyRussG>	 hashblob
[21:22:18] <Jeff_Green>	 ejegg: we can easily do that if desired, but it seemed to fly in the face of live hack testing
[21:22:44] <Jeff_Green>	 i think i first did it that way then people wanted to be able to hack locally
[21:23:17] <AndyRussG>	 It's a word
[21:23:45] <AndyRussG>	 Is it a hash? is it a blob?
[21:24:09] <Jeff_Green>	 habob
[21:27:44] <grrrit-wm1>	 (PS6) AndyRussG: WIP Schema for persistent global allocation tracking [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/159403
[21:27:57] <AndyRussG>	 Jeff_Green: too late
[21:29:34] <ejegg>	 Jeff_Green: ahh, I see
[21:36:40] <grrrit-wm1>	 (PS1) Ejegg: Add IP spanking for shady cards to Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166889
[21:36:42] <grrrit-wm1>	 (CR) jenkins-bot: [V: -1] Add IP spanking for shady cards to Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166889 (owner: Ejegg)
[21:38:22] <ejegg>	 what, too far down the unmerged chain?
[21:40:39] <awight>	 O_o
[21:44:00] <AndyRussG>	 I can't begin to imagine how I'd review a patch with such a commit message
[21:45:44] <ejegg>	 heh.  It's just adding an extra-long time penalty in the IP velocity filter for trying a stolen card
[21:50:03] <AndyRussG>	 doesn't make it any better 8p
[21:50:22] <AndyRussG>	 I'll stick with my hashblobs for now, thanks tho ;)
[21:50:48] <AndyRussG>	 (jk)
[21:51:00] <AndyRussG>	 (in fact it's a fantastic commit message)
[21:51:13] <awight>	 K4-713: hey.  Can we do better than "deploy-payments_1.23"?
[21:51:15] <ejegg>	 hmm, maybe that's why Jenkins wouldn't merge it.  He seems conservative
[21:51:28] <awight>	 I'd love to never have to remember that arcane series of punctuations again.
[21:51:33] <awight>	 we could call it... "deployment"
[21:51:34] <K4-713>	 awight: Ah... what would you rather?
[21:52:11] <awight>	 Since we don't have a release schedule, have no use for semantic versioning, and are never tracking more than one MW-core branch
[21:52:19] <K4-713>	 Hm. Well, if you cut "payments" out of it, that implies that we are good enough to deploy from the same deploy branch to everything... not just the payments cluster.
[21:52:27] <awight>	 yes
[21:52:31] <K4-713>	 Okay then.
[21:52:40] <awight>	 I think that's the arrangement in the mediawiki-config files, actually
[21:52:47] <K4-713>	 There's that other DI project on... some other machine.
[21:52:50] <K4-713>	 I think.
[21:52:51] <awight>	 we specify a magic branch, and that's the one that will be
[21:52:53] <awight>	 eh?
[21:53:10] <awight>	 wait: eh?
[21:53:51] <K4-713>	 There's the DonationInterface project we can code_update.
[21:53:55] <K4-713>	 That goes somewhere.
[21:54:09] <awight>	 oh.  yeah that's for Civi
[21:54:10] <K4-713>	 I think civi uses it to recur things.
[21:54:32] <awight>	 I'm replacing that with Composer... and using a new branch "drupal" where we maintain a few embedding tweaks
[21:54:39] <K4-713>	 hm
[21:54:40] <atgo>	 i'm heading for prawning with a kitchen stop
[21:54:42] <atgo>	 see you cats :)
[21:54:48] <K4-713>	 Oh wait, me too.
[21:54:53] <awight>	 we need ice cream floats?
[21:56:17] <ejegg>	 awight: you might want to spell your away nick differently
[22:07:31] <awight|pron>	 lolthx
[22:33:36] <grrrit-wm1>	 (PS2) Ejegg: Add IP spanking for shady cards to Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166889
[22:33:40] <grrrit-wm1>	 (CR) jenkins-bot: [V: -1] Add IP spanking for shady cards to Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166889 (owner: Ejegg)
[22:37:46] <awight>	 K4-713: https://wikitech.wikimedia.org/wiki/Deployments
[22:38:36] <K4-713>	 Huh.
[23:01:30] <AndyRussG>	 ejegg: just added the other two changes, 158652 and 166138
[23:07:35] <ejegg>	 AndyRussG|hmwork: thanks!
[23:12:36] <awight>	 K4-713: what were we saying a minute ago... branch name "deployment", that works?
[23:12:44] <K4-713>	 Sure.
[23:12:58] <awight>	 okdoke
[23:13:16] <K4-713>	 I guess if we run into an issue in which we have to get specific, that's easy to do at that time, too.
[23:14:05] <awight>	 yep!
[23:15:10] <grrrit-wm1>	 (CR) Katie Horn: [C: 2] Don't retry on certain errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166573 (owner: Ejegg)
[23:15:30] <grrrit-wm1>	 (Merged) jenkins-bot: Don't retry on certain errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166573 (owner: Ejegg)
[23:17:37] <grrrit-wm1>	 (CR) Katie Horn: [C: 2] Another safeguard around MC-forbidden retries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166607 (owner: Ejegg)
[23:21:17] <grrrit-wm1>	 (CR) Katie Horn: [C: 2] Penalize toxic card IPs in velocity filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166678 (owner: Ejegg)
[23:23:22] <awight>	 Hrm, I just noticed that DonationInterface is listed among the automatically branched extensions.  That is bogus, I'm removing us from the list.
[23:23:47] <K4-713>	 awight: ...there was a thing, for a while...
[23:23:59] <K4-713>	 ...what if I said "Translation Only"?
[23:26:57] <awight>	 O_o
[23:27:02] <awight>	 interesting
[23:27:17] <awight>	 but the messages are not used from outside the extension (grmble Civi)
[23:27:33] <K4-713>	 Not even from... something on-wiki?
[23:27:44] <awight>	 not that I know of
[23:27:58] <K4-713>	 I'm not being silly, this is actually something that I can't quite... remember...
[23:28:12] <K4-713>	 I think it's something installed on donate wiki.
[23:28:19] <K4-713>	 ...maybe flp.
[23:28:24] <awight>	 you're totally right.
[23:28:28] <K4-713>	 Oh?
[23:28:31] <K4-713>	 Neat.
[23:28:33] <K4-713>	 Which one?
[23:28:51] <awight>	 On this note, let me reiterate a wish that mediawiki declared dependencies explicitly
[23:29:05] <awight>	 FLP yeah it has some horrible abuse of the int: strings
[23:29:10] <K4-713>	 aye
[23:29:18] <K4-713>	 We really should decide to own that thing someday.
[23:29:29] <K4-713>	 >_>
[23:29:30] <K4-713>	 <_<
[23:29:32] <awight>	 It's very much on my radar to destroy
[23:29:40] <K4-713>	 How?
[23:29:48] <K4-713>	 I mean, we need donate to do its magic.
[23:29:49] <awight>	 I want to roll that under the DonationForm renderer
[23:29:54] <K4-713>	 oho
[23:29:59] <K4-713>	 Distributed magic.
[23:30:10] <K4-713>	 I can dig it.
[23:30:26] <awight>	 meanwhile, i do not know how those i18n strings get to FLP
[23:30:28] <K4-713>	 That... is going to be a difficult cutover.
[23:30:32] <awight>	 yah!
[23:30:41] <awight>	 it's either the localization cache, or...
[23:30:46] * awight scrounges among config files
[23:30:56] <K4-713>	 Please document this mystery somewhere.
[23:31:11] <K4-713>	 In case I manage to hit myself in the head with a hammer somehow.
[23:31:31] <K4-713>	 (rebound, probably)
[23:31:42] <awight>	 we could make a small book, ruining all the surprising magic, hidden dependencies
[23:31:51] <awight>	 too many secrets
[23:31:59] <K4-713>	 setec astronomy.
[23:31:59] <marktraceur>	 And ruin the wonder? The amazement?
[23:32:06] <K4-713>	 HI marktraceur.
[23:32:10] <marktraceur>	 The sense of accomplishment?
[23:32:16] <marktraceur>	 Ohai K4-713
[23:32:17] <awight>	 marktraceur: who else knows >-/
[23:32:44] <marktraceur>	 Is that...an angry, skeptical cyclops?
[23:33:01] <awight>	 what the crap is this?
[23:33:02] <awight>	     // Allow only these domains to access CentralNotice data through the reporter
[23:33:05] <awight>	     $wgNoticeReporterDomains = 'https://donate.wikimedia.org';
[23:33:11] <K4-713>	 ...
[23:33:25] <K4-713>	 reporter.
[23:33:30] <awight>	 the sins of our fathers...
[23:33:31] <K4-713>	 Right, the... what?
[23:35:46] <K4-713>	 Oho! I think we get to test WP again tomorrow.
[23:35:57] <awight>	 K4-713: whoa.  did you know that DonationInterface is enabled on foundationwiki??
[23:36:14] * K4-713 squiiiiints
[23:36:15] <K4-713>	 No.
[23:36:18] <K4-713>	 No, I did not.
[23:36:29] <awight>	 urgh, ContributionTracking as well.
[23:36:31] <K4-713>	 Is it, perhaps, language only?
[23:36:41] <awight>	 oof
[23:37:43] <awight>	 so... I think I can explain the magic i18n strings, DI is configured to deploy to donatewiki as an extension
[23:38:04] <K4-713>	 k
[23:38:31] <awight>	 I guess it's updated with the train.
[23:39:35] <K4-713>	 (Jeeze, jenkins. Merge. )
[23:40:21] <awight>	 K4-713: I just learned about https://integration.wikimedia.org/zuul recently.
[23:40:27] <awight>	 CI TV
[23:40:35] <K4-713>	 Heh. I was just there.
[23:41:00] <K4-713>	 "queued 23 min ago"
[23:41:13] <marktraceur>	 Jenkins is being slower and slower as we go on
[23:41:21] <awight>	 I wish they had that when I was a kid, just waiting for builds to merge with no feedback
[23:41:28] <K4-713>	 haha
[23:41:56] <awight>	 marktraceur: we amped up our game recently, by regressing to the several-year-old Jenkins build that comes with Ubuntu :)
[23:42:04] <awight>	 for secret FR stuff.
[23:42:09] <K4-713>	 SHH.
[23:42:11] <awight>	 to keep it moar secret.
[23:42:17] <K4-713>	 He'll see the big board!
[23:42:19] <marktraceur>	 Well not secret anymore, christ awight
[23:42:29] <awight>	 hold on, I'm going to explain the entire plot to him before unleashing the alligators.
[23:42:52] <marktraceur>	 YOU'LL NEVER GET AWAY WITH IT
[23:42:55] <K4-713>	 "No, Mr. Bond: I expect you to donate!"
[23:43:11] <awight>	 kaaapow!  bing!
[23:43:14] <marktraceur>	 K4-713: No no. "No, Mr. Bond: I expect you to DI."
[23:43:38] <K4-713>	 Wooooo.
[23:44:37] <awight>	 gnu's not a color.
[23:44:47] <AndyRussG|hmwork>	 it's a state of mind
[23:45:03] <awight>	 hehe: trolled!
[23:45:04] <marktraceur>	 I installed the Hurd on your beard, awight
[23:45:10] <awight>	 baahaha
[23:45:21] <awight>	 better than the squirrelmail infestation
[23:45:29] <K4-713>	 O_O
[23:46:30] <awight>	 oh hrmph,I was thinking of horde
[23:46:37] <marktraceur>	 Heh
[23:47:30] <grrrit-wm1>	 (CR) Katie Horn: [C: 2] Orphan adapter tests for MC retry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166803 (owner: Ejegg)
[23:48:30] <grrrit-wm1>	 (CR) Katie Horn: [C: 2] Add IP spanking for shady cards to Worldpay (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166889 (owner: Ejegg)
[23:50:30] <grrrit-wm1>	 (Merged) jenkins-bot: Another safeguard around MC-forbidden retries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166607 (owner: Ejegg)
[23:50:32] <grrrit-wm1>	 (PS1) Awight: Don't do contribution tracking in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166917
[23:50:58] <K4-713>	 Geeze, jenkins. Done with your smoke break?
[23:51:18] <K4-713>	 I don't remember it being this slow unless it was broken.