[16:26:39] ... [16:26:51] Where the hey is my team? [16:27:13] I guess maybe I'm just running early today. [16:33:28] (CR) Siebrand: "How does this work?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165179 (owner: Siebrand) [16:34:48] Hey ejegg! [16:35:14] ...doesn't writing a WorldPay patch super-fast sound like a fun way to start the week? [16:35:30] * K4-713 grins creepily [16:36:57] Ooh, what's the issue that needs patching? [16:37:08] I've sent an email and made a card. [16:37:11] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2068 [16:37:19] PRobably just look at the card at this point. [16:37:36] I'm going to grab some sample XML to make it easier. [16:37:39] Oh boy, we're making a special exception for them, huh? [16:37:51] Basically, I'd do it, but I'm going to be stuck in meetings pretty much all day. [16:38:06] OK, let me track down the XML and take a look [16:38:16] ejegg: I'm getting that now. [16:38:22] I'll just add it to the card. [16:38:28] oh, thanks! [16:45:02] ejegg: Added. [16:46:03] ejegg: And while we're both here, let me explain why we can get away with this. [16:46:12] yeah? [16:46:44] The special pipe we're using for France, will deny cards from elsewhere. [16:46:59] That is the *only* reason this is okay. [16:47:40] I tried my own (US) card through that pipe and pretended I was from France, and it told me the transaction was invalid. [16:47:53] Didn't even think I was trying to do something that made sense. [16:47:55] OK, so we only want to allow the missing AVS nodes if the specially formatted CVV results are present, probably [16:48:03] hmmmm... [16:48:22] Based on some conversations I had last week, I don't think those two things are connected. [16:48:31] Which I thought was odd. [16:48:32] Or just check for county = FR [16:48:37] Ehh... [16:48:39] *country [16:49:05] I'd rather have an array of special snowflake countries in LocalSettings, and check that. [16:49:11] So, no hard-coding France anywhere. [16:49:16] ah, right [16:50:05] Actually, it might be better to have an array of special snowflake accounts that are currently enabled... [16:50:40] wgDonationInterfaceSpecialSnowlakeAccounts, got it. [16:50:45] heh [16:50:45] bahaha [16:51:00] ...but that's actually totally reasonable. :p [16:51:07] (for now) [16:51:24] OK, this shouldn't be too crazy [16:51:26] You know where all these settings live on prod, right? [16:51:48] umm, not precisely, but I bet I can ask awight or Jeff_Green, right? [16:52:04] whut [16:52:05] Yep! I'd suggest looking at how we're switching out for France right now, and either use that or check it. [16:52:15] ...channel change. :) [16:57:52] AndyRussG: hey! I have 11:30 free if u wanna talk this out... [16:57:57] or another time? [16:59:20] Also, considering the brainstorminess, maybe ejegg wants to be involved? ejegg: re: rethinking CentralNotice buckets, especially the C/D hack [16:59:44] moar heads = butter [17:00:43] awight: sounds good, NEtime is great :) [17:04:50] awight: ejegg: I'm good baiscally any time that's free on my calendar :) [17:05:45] Now I have to make some spicy green sauce! [17:05:58] (in a bucket) [17:13:32] AndyRussG: woohoo! OK thanks, I'll encalendar then [17:15:07] :) [17:15:45] ejegg: pizzzacat: have chatty here? [17:16:58] OK, chat here is fine [17:19:19] ejegg: https://etherpad.wikimedia.org/p/dash_deploy_tasks [17:31:41] Jeff_Green: fyi, we're talking about you. Way to deploy application settings [17:31:44] rrrgh [17:31:46] Jeff_Green: https://etherpad.wikimedia.org/p/dash_deploy_tasks [17:32:09] ohi [17:32:26] oh that [17:32:40] afail that is what became /etc/fundraising/dash.js [17:32:55] ooh, afail. that's my new favorite typo [17:33:32] TIL I need a favorite typo [17:38:34] Jeff_Green: if you have bandwidth, https://plus.google.com/hangouts/_/wikimedia.org/dash-review?authuser=0 [17:38:53] K4-713: The CVN oddity with FR is that CVNMatch is gone, so we'llhave to rely on CVNMessageCode, right? [17:39:22] ejegg: No. [17:39:25] CVN is still there. [17:39:28] AVS is missing. [17:39:54] Oh, that example XML you posted has no CVNMatch node either [17:40:03] just CVNMessageCode and CVNMessage [17:40:18] in addition to the missing AVS stuff [17:40:22] But, CVN will basically always come back with what should be a fail everywhere else, so we need... Wait, no way. That should totally be in there. [17:40:26] Code 2. [17:40:35] wtf, K4. [17:41:08] Yeah, yours has 2 No Data Matched [17:41:28] but the other testresponse also has 1 [17:41:36] and processResponse expects the CVNMatch node [17:42:30] ...wait, what did you say was missing from my XML, then? [17:42:40] CVNMatch [17:42:51] ...but you just said it was there. [17:42:55] So confused. [17:43:04] no, the other testresponse files for other tests [17:43:22] other ones have 3 CVV related nodes, yours has 2 [17:43:45] orly. [17:43:50] yah [17:43:54] Okay. [17:44:10] So, this is exactly what the special france pipe is returning. [17:44:12] but if it's giving us fail anyway, we just don't care [17:45:30] Is CVNMatch being expected by ProcessResponse? [17:45:57] That... might need to come off the list if it's in there. [17:46:00] yeah, but I guess I'm exempting that along with the avs stuff for snowflakes. [17:46:02] For everything. [17:46:08] Oh? [17:46:11] Otherwise, our antifraud data in fredge will be off. [17:46:24] Note that if the required nodes are not there, we don't even run the filters. [17:46:29] So, no fredge message with the fail. [17:46:38] Ah, that's interesting. [17:47:35] Wait, is the node missing at random for other store IDs? [17:47:52] I figured the value would just reflect whther or not the match was successful [17:47:53] It might only be set if there is a full match. [17:48:00] oh jeez [17:49:14] OK, will take it off the list for errbody [17:49:46] You may have to check to see that nothing is being handled like false. [17:49:58] OK [17:50:27] Oh... also, I just realized why maybe some of the confusion. [17:51:01] (PS3) AndyRussG: WIP Persistent global alloc tracking (excludes schema) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/167243 [17:51:09] You know you don't actually have to supply a valid error code in the tests to select the right XML to fly in, right? [17:51:24] It's basically just a freeform string. [17:51:46] I just wanted it mostly to be response code. [17:52:08] yeah, i'm using 'snowflake' for the suffix on yours :) [17:52:18] PErfect. [17:54:09] Do Apache Hive and Cassandra have any overlap in uses and usefulness? [17:57:39] pizzzacat: u might want to copy that etherpad somewhere more permanent, like the mingle card.. [17:59:51] ok will do awight [17:59:53] ^^ hehe, once Jeff_Green is done [18:00:13] ok i can be done [18:00:20] no worries Jeff_Green [18:00:23] just trying to make it more list-ish [18:00:32] much appreciated [18:00:33] Is no rush! [18:00:34] in case the censors are offended by conversational content [18:00:40] yeah I will do it later on [18:02:01] gahh, too many hangouts links... [18:03:46] Buh, are you guys doing standup? [18:03:49] Where is atgo? [18:03:54] just wondering that. [18:03:56] yeah in standup [18:04:00] we started on time :p [18:04:03] brt [18:05:18] awight: GOOD. [18:05:27] Mondays are probably going to be like that forever now. [18:05:32] ...with me partially missing. [18:13:38] gee I wish I could do that! [18:22:46] AndyRussG: c'mon, I'm not a robot... I was obliquely attempting nonsequitor to bad lip reading, https://www.youtube.com/watch?v=QlwilbVYvUg [18:23:21] to click or not to click? [18:23:30] what would a robot do? [18:24:07] It is three.5 minutes you will not get back, nor regret [18:24:34] K to click then [18:24:47] BTW ellery is working like a madman on his google doc [18:26:25] AndyRussG: grrp, can you resend me the doc link? [18:26:39] AndyRussG: oh nvm, it just appeared [18:26:39] https://docs.google.com/a/wikimedia.org/document/d/150lrUt8b4aiPK19XCcoE6Yy3TwN_wo529UGQjk0eTbo/edit [18:26:41] thx! [18:26:45] :) [18:27:31] AndyRussG: looks like you lit a productive fire! [18:27:50] shh I watching the link you sent [18:28:57] awight: very worth it, thank you [18:29:54] awight: ejegg: wanna wait a couple more minutes to finish digging into the doc? [18:30:30] shoot, I think I really should finish this worldpay thing first [18:30:45] I might have to sit this one out [18:30:56] ejegg: yep, no worries. This is just brainstorming, we'll write up any results. [18:31:03] thanks! [18:31:51] AndyRussG: if u want, https://plus.google.com/hangouts/_/wikimedia.org/cn-bucket-chat?authuser=0 [18:31:59] otherwise, etherpad?... [18:32:31] https://etherpad.wikimedia.org/p/CN_bucketing_overhaul [18:32:52] hehe, another fine mind ruined by easily available BLR [18:33:26] AndyRussG: I saw you for a second [18:33:44] awight: hmm, it had some connection issue, then said no one was there [18:33:52] AndyRussG: jitsi? [18:34:08] also cool, see if it works now... [18:37:32] ? [18:38:28] awight: https://meet.jit.si/SurlyElephantsExpireArticulately [18:38:37] sekret! [18:38:46] * awight enfires anagram machine [18:39:50] AndyRussG: u can hear me? grr, I think we had this happen last time [18:40:02] Yeah I guess jitsi is pooh [18:41:17] awight: back to hangouts? [18:41:46] AndyRussG: sure. [18:42:36] :) [18:43:36] argh, I'm downloading the SIP app [18:43:48] Ah OK [18:43:50] seems to be killing hangouts for the moment. [18:44:00] They don't like each other [18:44:01] sorry, eta < 1 min [18:44:04] I'm sure [18:44:06] np :) [18:46:42] I'm a bit underwhelmed that it's asking for my google password rather than using openid [18:47:37] blrg [18:50:01] AndyRussG: well, auth failed from the jitsi app [18:50:10] ooof [18:50:14] it's a ruse [18:50:17] a robote ruse [18:50:36] borken robot [18:51:05] borken (German for "borked") 'n' broken [18:51:12] Ich bin geborken [18:52:21] AndyRussG: I think it was having jitsi open, one sec [18:54:58] AndyRussG: resources/src/mediawiki/mediawiki.user.js [19:00:57] AndyRussG: V [19:00:58] https://etherpad.wikimedia.org/p/CN_bucketing_overhaul [19:24:23] (PS1) Ejegg: Allow special treatment for certain store IDs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/167642 [19:26:35] hey Jeff_Green! we've got an outstanding question here... do you know any status update? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1631 [19:28:15] looking [19:29:19] oh that was a fun one [19:31:03] i vaguely rememember making adjustments to watchmouse monitoring out of that event [20:03:10] K4-713: atgo: fwiw, I'm in wikimedia-staff asking for a vid chat [20:03:30] we will send a link [20:03:53] atgo: re. that mingle card, I think I made some improvements to watchmouse monitoring after that event but there's still not a great way to detect all imagineable glitches [20:04:00] hmm [20:04:01] ok [20:04:26] I'm adding a nagios/icinga collector that will check the systemstatus URL on each server, which should have caught that particular fail case [20:04:57] so that's liken 82% fix :-) [20:22:56] About to push merged dash code to gerrit for review [20:23:12] prepare for a wee flood [20:23:43] also, WP thing to review: https://gerrit.wikimedia.org/r/167642 [20:23:51] K4-713: awight ^^ [20:51:51] i'm not sure what I'm supposed to do re. mingle. I don't see any way to update that #1630 [20:55:42] hey awight - does this mean that you think this should be in before Dec? [20:55:47] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1832 [20:55:55] your comment isn't totally clear; ) [20:56:43] and you did put it in the bucket :) [20:56:57] awight: Would you do the CR for ejegg there? I am still indisposed for another half an hour. [20:57:09] And we are still trying to get this out today, I think. [21:00:04] aaaugh. Gerrit is really getting to me. [remote rejected] (invalid committer) when I try to push stuff including ssmith's commits from github [21:00:28] tempted to just squash it all [21:00:38] pizzzacat hates gerrit too :) [21:00:42] and HI pizzzacat!! [21:01:05] hiii [21:02:06] dare I bring up…….Phabricator? [21:02:12] *lightning* [21:02:15] *thunder* [21:02:43] ejegg: pizzzacat has to add that email address through the gerrit UI [21:03:34] awight: really? it's saying 'committer email address does not match your user account' [21:03:48] https://gerrit.wikimedia.org/r/#/settings/web-identities [21:03:50] looks like i'd have to claim her address to appease gerrit [21:04:08] Donno about that, but I'm sure it has no chance of working w/o the ^^ [21:04:19] pizzzacat: do you have your work email attached to your gerrit account? [21:04:38] omg it's complaining about the @wikimedia.org acct? bah [21:04:50] yea [21:05:02] oh right, it's totally the smae one as her account [21:05:15] yes should be my work one [21:05:20] *is my work one [21:05:33] http://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Email_doesn.27t_match [21:05:47] pizzzacat i just got a phabricator account! i'm looking into it for mingle replacement... though it'll be a while either way [21:05:56] I've come up against this problem before ejegg awight [21:06:00] Such a sad situation [21:06:15] I almost jumped out the window [21:06:22] good thing Matt was there [21:06:30] to tell me happy birthday for the 24th time [21:06:35] and bring me back to reality [21:06:35] awight: srsly amend em all to claim them as my own? blecch [21:06:40] I would paste this issue into -operations and then take a poop in the corner [21:06:50] that's just my style, though. [21:07:02] blaahh! [21:07:18] ...I'm just going to... [21:07:24] atgo that's cool! I want to check it out and see if it's better than gerrit [21:07:32] hahahaha hahaha K4 [21:08:01] don't forget to bleach your computer before attempting real work again. if ever. [21:08:16] OK, I need to eat before I fight another round with gerrit [21:09:07] ejegg|food: pizzzacat: "Grant "Forge Committer Identity" and "Forge Author Identity" access [21:09:10] priviliges " [21:09:12] [sic] [21:09:17] haha [21:09:23] ejegg I know that feel [21:09:35] I love when people use [sic] awight [21:10:11] me too, but it has to be really bad to justify the usage [21:10:20] not just like "me to [sic]" [21:11:23] ejegg|food: https://gerrit.wikimedia.org/r/#/admin/projects/wikimedia/fundraising/dash,access [21:11:32] ok on that note, I'm foodwards two. [21:11:35] also [21:15:39] pizzzacat: ejegg|food: I just enabled the force author and commiter privs on the main repo... hopefully that helps. [21:16:03] you should both be able to mess with those permissions yerselves, too. [21:17:27] oh thanks!! [21:21:22] :p not much of a favor, it was kind of like "oh look, here's the level boss! would you like to fight her?" [21:39:26] awight|p-o: Thank you! now just got to work out the duped commits... [21:45:50] baahaha good luck. ejegg, are you waiting for code review from me? arrgh I think so [21:46:13] oh yeah, that WP hack for france [21:46:31] https://gerrit.wikimedia.org/r/#/c/167642/ [21:46:31] ? [21:46:52] yes [21:47:00] looks like a hack :) [21:47:20] heh. yep. [21:50:17] almost midnight here, gonna head offline, talk to you in the morn! [21:50:29] ok, have a good night [22:01:20] ejegg: Are you still waiting for CR? [22:01:36] awight's on it now, I believe [22:01:43] Huh. [22:01:53] * K4-713 blinks [22:02:20] Well, good, because I only have 27 minutes before I have to bail out again. [22:03:42] ejegg: I did look at it a bit, and I had one comment that I wanted to leave, but then another thing started. [22:03:53] what was your comment? [22:04:12] Ideally, we wouldn't stop the CVV check. We'd just give that whole test a different number of points for failure. [22:04:36] oh, I thought you said it always reported failure [22:04:53] If I did, I was lying. they never said it would always do that. [22:05:19] Ok, so just allowing 'No data matched'? [22:05:23] So, in theory, it will occasionally perform the check. [22:05:30] Nah, not even that. [22:05:45] You know how every antifraud test has a related score we can dial around? [22:05:49] I wanted a special one of those. [22:06:11] so a specialSnowflakeCVVMap? [22:06:12] So, the CVV check failing would be worth slightly fewer points through the snowflake pipe. [22:06:22] I don't even think we want a special map. [22:06:23] Oh, the whole cvv weight [22:06:29] Yep. [22:06:39] OK, gotcha [22:07:12] But, that's such a nitpick at this point, I don't even know how much I care. [22:09:35] (CR) Awight: [C: 2] Allow special treatment for certain store IDs (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/167642 (owner: Ejegg) [22:09:59] (Merged) jenkins-bot: Allow special treatment for certain store IDs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/167642 (owner: Ejegg) [22:10:43] aaahblurp, just getting to the backscroll party a bit late. [22:10:51] That does sound like an enhancement, though. [22:11:03] ejegg: anything else before I head to the ghost office? [22:11:09] "a parenthetical crime of ternary passion." <--wow [22:11:22] thanks awight, i'm all set! [22:11:41] awight|p-o: Keep that up and I'll have you do all the code review. [22:12:28] (CR) Awight: [C: 2] "Ghost-busting!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166594 (owner: Ejegg) [22:12:44] (Merged) jenkins-bot: Comment clarifications and formatting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/166594 (owner: Ejegg) [22:12:45] K4-713: :p I'll tone it down, then [22:12:58] No! Wait. [22:13:00] Er. [22:13:10] /nick awight|really ghost [22:13:22] I'm... trying to figure out how I incentivize this properly. [22:13:23] hehe. K4-713 u need a thing in the next hour? [22:14:08] Nope. Well, unless ejegg's patch gets merged. [22:14:18] whaa [22:14:20] yes it did [22:14:37] Did it? [22:14:39] unless !merged? [22:14:48] 15:09 < grrrit-wm1> (Merged) jenkins-bot: Allow special treatment for certain store IDs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/167642 (owner: Ejegg) [22:15:14] * K4-713 rediscovers F5, looks foolish [22:15:32] I think I misparsed. Will not help with more things in that case :0 [22:15:55] This should get deployed and stuff. [22:15:58] <_< [22:15:59] >_> [22:16:06] * awight|p-o changes color slightly [22:16:15] ok that is somewthing I can do [22:16:24] * K4-713 wonders what color [22:17:02] I'm in another thing in 15 minutes, probably not able to add input. [22:17:08] ejegg: feel like watching logs for an hour? [22:17:23] I hear it's helpful that I deploy yr payments code? [22:17:44] I can do some things after... 5:30pm. [22:17:53] awight|purgreen: certainly will do! [22:18:05] It would be swell if "some things" means retrying the snowflake pipe. [22:18:10] In prod. [22:18:38] I also wonder how long it's going to be, before we basically don't seem to be speaking English anymore. [22:18:45] (don't look now) [22:20:15] btw, there is a lot of "Blocking validation problems with this payment. Investigation required" [22:21:00] the orphan slayer choking on perhaps, ffname=null [22:21:33] hum [22:21:45] No, I think it's the null... currency or amount. [22:21:47] Can't remember. [22:21:50] It's one of those, though, I think. [22:21:55] currency [22:22:03] If you look at the associated json... [22:22:08] oh. thassit, thxu [22:22:12] yep [22:22:16] okay, I'm gone again. [22:23:28] bah, my intricate git rebase swapping out all the dupe commits failed. [22:23:45] aargh. [22:23:59] squashing? [22:24:12] guess I'll have to [22:24:23] i mean, squashing just the dupe commits? [22:24:33] yeah, going to try that first [22:24:40] k g'luck [22:24:52] I'll holler once done deploying [22:25:03] thanks! [22:25:32] Want to add the fr store ID to that new snowflake account_config key in the hidden settings file? [22:25:58] ok, thanks for the reminder! [22:27:43] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/167718 [22:28:32] (PS2) Awight: Merge branch 'master' into deploy-payments_1.22 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/167718 [22:29:02] (CR) Awight: [C: 2] Merge branch 'master' into deploy-payments_1.22 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/167718 (owner: Awight) [22:36:33] fwiw. 15:36 < grrrit-wm1> (CR) Awight: "recheck" [core] (fundraising/REL1_22) - https://gerrit.wikimedia.org/r/167720 [22:36:55] an unrelated parser test is failing :-/ [22:37:03] dang it! [22:38:05] !log updating payments config with French Snowflake hack [22:38:09] Logged the message, Master [22:38:51] ok, clear for defribbilation [22:39:01] awesome, thanks! [22:39:07] I'll keep an eye out for an hr [22:39:26] got to head to class then, but will be back out at 9:30 my time / 6:30 yrs [22:39:43] sounds fun! [22:39:51] * awight|purgreen taps foot... [22:47:40] ejegg: it's not looking awesome for deployment in the next few minutes... sudo to the local/bin scripts is broken. [22:47:57] dang [22:48:01] how about I do the deploy and take care of log babysitting, when I get back from P.O,... [22:48:16] Is there anything you wanted to do, such as test w/ FR card? [22:48:18] OK, I'll get back online after class [22:48:33] Yeah, K4 has an FR card to test with [22:48:36] u sure? if you have a cc# to forward me, I'm not complaining :p [22:48:37] ok then [22:49:09] I'll email all re: successful deployment. [22:49:20] thanks! [23:56:42] !log updated payments to 4cf8eb06a4746478c6424648c94688bf460cf63d [23:56:48] Logged the message, Master [23:57:02] ejegg|away: K4-713 ^^ done. Config should cause FR to exhibit snowflakiness. [23:57:38] ie: config is deployed also.