[13:58:58] Morning Jeff_Green :) [14:14:37] morning [14:20:02] How's it going? I suppose we should wait for ejegg|away before doing the change to the udp-filter... He showed you the patch? https://gerrit.wikimedia.org/r/#/c/168186/ [14:30:24] yeah [14:57:32] K... In case you're curious as to the status of the issue as a whole, there are updates here: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2066 [14:58:29] Hi Jeff_Green and AndyRussG [14:58:37] Morning ejegg :) [14:59:04] hey [15:00:02] So, we can also turn off the HideBanners filter: https://gerrit.wikimedia.org/r/168298 [15:00:22] orlly [15:00:25] ok [15:00:29] We only needed that to determine when folks stopped hitting it with the old cookie JS [15:00:34] great [15:00:42] what was the other commit again? [15:00:43] Should save a little space, I hope [15:00:59] the first one was just taking the querystring off the RecordImpressions filter [15:01:12] We want to be pulling in all of those hits anyway [15:01:34] but the filter was only including those where the first qs param was 'banner' or 'reason' [15:01:35] now that we're talking about it, lemme see what our current storage situation is [15:02:10] As far as I'm concerned, we can even delete all the old HideBanner sampled logs [15:02:38] ejegg: BTW I finished checking the DjangoBannerStats and came to the same conclusion that you had reached much more quickly, that there won't be an issue [15:03:26] Yeah, I had done some looking at that before, seeing if it made sense to add more time scales than 'forever' or 'last 2 hours' [15:05:36] 221G 2014 [15:05:53] quite a bit more than last year, but much better than 2011 which was 1.3T :-) [15:06:14] Jeff_Green: sorry, you were asking for a link to the other commit, not a description: https://gerrit.wikimedia.org/r/168298 [15:06:32] derp, that's the same one [15:06:32] ya, we're ready to merge? [15:06:53] https://gerrit.wikimedia.org/r/#/c/168186 [15:06:58] ready when you are! [15:07:33] Ooooh here come the elves, right? [15:10:31] we need to rebase https://gerrit.wikimedia.org/r/#/c/168186 [15:11:03] I don't have the option to review it [15:11:20] ok, will do [15:12:10] rebased [15:13:06] od [15:13:09] odd i mean [15:13:24] turns out I somehow got logged out of gerrit even though I hadn't closed my browser [15:13:28] rebased the 2nd too, since it depended on the 1st [15:13:50] ahh, weird [15:18:05] deployed [15:19:21] Jeff_Green: ejegg: :) thanks [15:20:22] rockin! [15:20:26] thanks [15:21:05] np [15:22:33] Jeff_Green: I may have found our issue with dash's OAuth requests, too. The Drupal lib is probably reconstructing an http url since nginx is doing the ssl. [15:22:59] I'm going to tweak the lib a tiny bit to respect x-forwarded-proto headers, then we can add that to nginx [15:23:36] ah, that makes sense [15:23:49] drupal seems pretty broken re functioning behind a proxy [15:32:43] (PS1) Ejegg: Tweak OAuth lib to respect x-forwarded-proto [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168303 [15:33:00] ejegg: when you re-start the jenkins job can I bother you to loop me in (i.e. send a link or whatever) so I can learn about that too? thx! [15:39:32] AndyRussG: I think we don't want to restart the job till we're accounting for the new reasons [15:40:49] If we restart it now, it would throw all the 'donate' and 'close' cookies in the 'other' bucket [15:43:44] ejegg: Ah hmmm! OK, I wasn't clear that we were going to do that [15:43:45] (CR) Ejegg: [C: 2] less panic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165874 (owner: Awight) [15:44:24] My understanding was that this will now just be a backup mechanism and the real data will be pulled out of Hive [15:44:33] I think it's a simple change tho... [15:44:57] Oh, I thought we were going to make that small change at least [15:45:23] Since now it really would be misleading to leave it alone [15:47:03] OK... Lemme try that I guess... [15:48:13] Jeff_Green: File size looks approximately the same as with the querystring on the filter - almost 5MB for 15 min [15:48:33] I mean same as it was before we deployed the CN change [15:54:53] ejegg: great [16:00:09] on https://wikimediafoundation.org/wiki/FAQ/nl are a lot of red links which I think should not be there [16:00:37] "Doneer nu" is multiple times in red (=Donate now link) [16:02:05] Ooh, that's odd. None of those links in the english version [16:02:38] yes [16:03:05] if users have questions and ask them on the Dutch Wikipedia, they are pointed there [16:07:54] Hi Romaine... I imagine there's another IRC channel where you could get better help on that... This is where we talk mainly about fundraising campaigns, and especially the technology involved [16:08:57] tell me which one, and I will go there [16:09:04] I only know of this one [16:10:27] Romaine: looks like someone added those (in English!) way back in 2010, and they were just now translated [16:10:35] ...but still lead nowhere [16:10:59] only WMF staff seem to have access to that wiki, so you can remove it [16:11:22] oh, right [16:11:27] Romaine: one sec [16:11:52] otherwise I would have helped already :-) [16:12:20] Romaine: really appreciate your pointing this out, BTW... Here is the list of channels: http://meta.wikimedia.org/wiki/IRC/Channels [16:12:28] (probably mostly complete) [16:12:43] There is for examle wikimedia-nl [16:13:32] only one channel for fundraising on that page, this channel here: Discussion of Wikimedia fundraising. [16:13:36] If you don't get an answer there, I guess the next place I'd try is wikipedia-nl [16:13:40] * Romaine is OP in Wikimedia-nl [16:13:58] * Romaine is OP in Wikipedia-nl too [16:14:21] and the other users do not know the answer to solve this [16:14:40] Ah OK right sorry... it just looked like this issue wasn't that fundraising-specific [16:15:19] no problem [16:15:32] so I suspect you know the right people in WMF to ask to change this, I hope you can ask such [16:19:20] Romaine: K, I don't know a lot of details of people's roles outside tech, but I'll ask in a bit then :) when more folks in SF are around [16:21:53] thanks alot :-) [16:22:28] I'm around. Does that help at all? [16:23:40] Morning K4-713! Romaine is wondering whom to ask for fixing the redlinks that say "Donate now" ("Doneer nu") on this WMF page: https://wikimediafoundation.org/wiki/FAQ/nl [16:24:24] Wow... this looks very old. [16:24:32] Or rather, the links do. [16:25:23] They're all rusty red [16:26:01] Well, that, and they're pointing to foundation wiki. [16:26:31] We haven't had donation forms on foundation wiki since before my time here. [16:26:46] 2010 or something. [16:27:41] Usually, we just link to donate.wikimedia.org these days, with some parameters so we can tell where the donors came from in a general sense. [16:27:49] yep, that's when those links were added! [16:28:05] https://wikimediafoundation.org/w/index.php?title=FAQ%2Fnl&diff=51116&oldid=43640 [16:28:12] Wow. I just threw a dart for that year. [16:28:17] Neat. [16:29:03] Ah, in general, stuff like this usually goes to the-wub, but I don't see him online right now. [16:29:47] Also, this kind of makes me wonder if there are other language FAQs with this exact problem. [16:30:02] Ah cool... Romaine, there's your answer ^ [16:31:36] Hmm. The sidebar link on foundation wiki is a little off, too. [16:32:02] utm_source and campaign should specify "sidebar". [16:32:40] They appear to be missing. [16:33:04] K4-713: the change to the udp-filter is deployed... a small change to DjangoBannerStats to count the new hide reasons is in the works... [16:33:18] AndyRussG: Fantastic. [16:33:28] I did see one thing go by that I wanted to ask you guys about. [16:33:43] Looks like there was one commit that is going to stop counting hide impressions? [16:34:38] (most of the credit to ejegg BTW) [16:34:51] Mmm what commit is that? [16:35:08] K4-713: we only added that one to find out when we could deploy part 2 of the cookie change [16:35:20] Uhh... what? [16:35:26] heh [16:35:44] We were looking at HideBanners to see when they stopped using the requests from the old js [16:36:13] Since we've got that all deployed, I didn't think we needed it any more [16:36:23] did we start using it for something else in the meantime? [16:36:38] I hope I'm conflating two things, then. [16:37:08] Oh, sorry, did you mean the puppet change to remove the udplogs filter for Special:HideBanners? [16:37:09] Megan absolutely looks at hide impressions. I just want to make sure this isn't that. [16:37:13] Or something else? [16:37:24] It wasn't clear. I think all I got was the puppet commit message. [16:37:32] And it looked funny. [16:38:15] Yeah, that should be fine. We're still sending 'hide' results to Special:RecordImpression and counting them as usual [16:38:31] Okay, great. Just making totally sure. [16:49:03] K4-713: thanks for picking this up :) [16:53:25] (PS1) Ssmith: Add big english component [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168323 [16:53:28] (PS1) Ssmith: Fix css issue with subfilters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168324 [16:53:30] (PS1) Ssmith: Add 'or' logic to query string generator [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168325 [17:00:23] (PS2) Ssmith: Fix css issue with subfilters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168324 [17:00:25] (PS2) Ssmith: Add 'or' logic to query string generator [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168325 [17:01:14] (CR) Ejegg: [C: 2] Fix css issue with subfilters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168324 (owner: Ssmith) [17:02:28] AndyRussG: (ejegg if free) u wanna chat for a few minutes about the mixin fix for banner "treatment phases", or shall I go ahead with a write-up? [17:02:51] atgo: you want to add reality? :p [17:03:01] Yeah NEtime [17:03:17] sorry to distract from the impressions fubar [17:03:23] atgo brought a little reality all the way from Burning Man [17:03:31] baahaha O_o [17:03:47] in a ziplock baggie [17:03:51] <_< [17:03:51] >_> [17:03:56] hey, now [17:04:50] awight: gimme 5 min for a brief kitchen run? [17:05:24] of curse! [17:06:58] awight: unrelated question - do you know if drupal can tell it's being served over https? It seems to get base urls right... [17:07:11] AndyRussG: ejegg: atgo: I'm gonna be sitting in a video room, whoever wants to talk about this. https://plus.google.com/hangouts/_/wikimedia.org/awight?authuser=0&hceid=YXdpZ2h0QHdpa2ltZWRpYS5vcmc.ftfu7fmrpdim9gtt5dpiecnudk [17:07:31] ejegg: I don't know. it only knows base_url if you set it explicitly [17:08:19] Aah, and that could include the protocol. The oauth lib is looking at the HTTPS server var. I think we need to finagle that [17:09:14] apache's SetEnvIf seems promising [17:11:58] awight huh? i'm on calls [17:12:00] :/ [17:12:32] awight: I'm all kitchened up and in the call [17:25:43] * K4-713 blinks at calendar [17:26:31] I think the sky just opened up and sucked all the meetings back into space for the next two days. [17:27:48] atgo / atgo_: Whichever one you are: WX? Is that the next thing? [17:28:00] hi! [17:28:04] yo [17:28:13] i.. have multiple personalities right now [17:28:35] in ze dev ready, we have the email thing (rosie's) from yesterday [17:28:39] and then wx :) [17:28:48] Did we not temporarily fix that? [17:29:04] I mean, enough to cause it to stop being an emergency. [17:32:39] atgo_ ^^? [17:33:11] AndyRussG: ejegg: sorry for the brevity, and thanks for the brainflurry. [17:33:22] Good to know we haven't come up with a solution, at least :) [17:33:32] I'll sit on it for another hour and see what hatches... [17:33:49] K4-713 that's probably an awight question [17:33:55] <_< [17:34:00] Er, really? [17:34:00] since rosie also wants to get the event emails [17:34:12] right awight ? [17:34:18] Which event emails? Are those something distinct from the threshhold ones? [17:34:23] ah no rosie's problem is not OK [17:34:31] K4-713: yeah--these are the campaign emails [17:34:38] awight: Were you looking for something to do? [17:34:39] :D [17:34:42] K4-713: um. [17:34:54] * awight slamshifts into 1st again [17:35:05] awight: np, thanks also [17:35:54] So, 2077 is only talking about the amount thing. [17:36:25] And, it seems totally inconsistent with what we discovered and tested yesterday. [17:37:21] awight or atgo_: Can one of you inject some reality into that card? [17:37:38] i'm on a call [17:37:45] can look later [17:38:02] (PS1) Awight: large donation: inclusive threshold check [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168338 [17:38:06] Also, is there a card for event emails? [17:38:18] I think that's a completely new feature. [17:38:21] * awight fumbles for reality [17:38:36] K4-713: nah it's a bug in the rewritten wmf_campaigns hook [17:38:47] We used to email for events? [17:38:52] I don't remember that at all. [17:39:03] ...which is clearly inconclusive. [17:39:14] I wrote it a few months ago [17:39:23] Ah, that explains it. :) [17:40:02] when utm_campaign matches a key from the Direct Mail Appeal [sic] table... zap! [17:40:14] * K4-713 ducks [17:40:34] Anyway, I'm jumping on the WX thing, as I seem to have two reasonable days in a row. [17:41:22] woot! [17:41:30] pizzzacat: you missed a valid use of sick [sic] [17:42:47] (CR) Katie Horn: [C: 2] large donation: inclusive threshold check [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168338 (owner: Awight) [17:42:51] thx! [17:43:00] yep [17:43:17] * awight dabs perspiration [17:43:38] atgo: u making the campaign notification card, or shall I? [17:44:04] Oh hey, if you do a civi deploy today, there's another trivial change that should go out. [17:44:09] Fixes fredge time issues. [17:44:14] k. merged already? [17:44:18] yep [17:44:20] great [17:44:38] * awight shakes mane at PHP time handling [17:46:36] atgo: ok I'm making the campaign card [17:47:54] (PS1) Ejegg: Use setenvif to set HTTPS on if X-Forwarded-Proto says so [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/168340 [17:48:22] ejegg: lemme know when I should jump on the CR [17:50:05] awight: got two alternatives for the oauth sig fix [17:50:17] are they compatible? [17:50:20] one in apache config (using the .htaccess in drupal) [17:50:38] and the other tweaking the OAuth lib to look for x-forwarded-proto [17:50:49] leaning towards the .htaccess one for now [17:51:04] they won't break each other, but we only need one [17:51:10] ah ok [17:51:20] well, tell me where to start if you need CR [17:51:28] oh u just did :) [17:51:32] .htaccess: https://gerrit.wikimedia.org/r/168340 [17:51:34] ok I'll look at the .htaccess [17:52:04] ejegg: what's the RewriteBase thing about? [17:52:11] lib tweak: https://gerrit.wikimedia.org/r/168303 [17:52:34] rewritebase? Oops, that shouldn't be there [17:53:04] Sorry, that was a local setting [17:53:06] k [17:55:50] (PS2) Ejegg: Use setenvif to set HTTPS on if X-Forwarded-Proto says so [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/168340 [17:56:21] (PS1) AndyRussG: WIP Count more hide reasons [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/168343 [17:56:51] thanks awight :) [17:56:54] (PS3) Awight: Use setenvif to set HTTPS on if X-Forwarded-Proto says so [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/168340 (owner: Ejegg) [17:57:21] (CR) AndyRussG: "Tagged as "WIP" because it's untested... :/" [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/168343 (owner: AndyRussG) [17:57:23] (CR) Awight: [C: 2] "Cool. And the OAuth lib is tooled to look for the HTTPS server variable or something?" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/168340 (owner: Ejegg) [17:58:02] awight: ejegg: anyone able to test easily? If not I can get set up to do so [17:58:26] (Merged) jenkins-bot: Use setenvif to set HTTPS on if X-Forwarded-Proto says so [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/168340 (owner: Ejegg) [17:59:06] staaand up? [17:59:13] (CR) Ejegg: "Yep, oauth/lib/OAuth.php line 268 uses that to get the scheme for the reconstructed URL" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/168340 (owner: Ejegg) [18:00:14] AndyRussG: the django fix? I think you might be the one :,-( [18:00:29] and crhome just crashed [18:00:32] K on it :) [18:00:48] awight AndyRussG ejegg K4-713 stand up ? [18:02:09] atgo_: Yeah, totally. Sorry. [18:02:12] Lateness. [18:02:45] atgo_: yeah I used a chrome box a minute ago. Most worthless experience of my videochatting career. [18:04:17] (PS1) Ejegg: Update drupal submodule for https forwarding fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168347 [18:06:49] (CR) Ejegg: [C: 2] Update drupal submodule for https forwarding fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168347 (owner: Ejegg) [18:08:09] (Abandoned) Ejegg: Tweak OAuth lib to respect x-forwarded-proto [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168303 (owner: Ejegg) [18:20:18] Jeff_Green: sorry, but--can you make time to work on the payments -> mw 1.23 deployment? [18:20:22] today...? [18:20:38] sure [18:20:46] * awight plays "taps" [18:20:49] i've got about 2.5H [18:20:49] ha [18:21:02] now is good if you want to start [18:21:03] ok cool. We have some branches. Where should we start? [18:21:07] that works. [18:21:08] I'm between tasks [18:21:13] ok so [18:21:20] lemme look at deploy config [18:21:34] ok, and I'll merge recent 1.22 changes into the new branch [18:21:59] right now we have two projects [18:22:09] payments is tied to REL1_22 [18:22:24] and payments-wiki-staging is tied to REL1_23 [18:22:38] payments-wiki-staging only deploys to payments1004 [18:23:31] oh then there was that whole db schema question right? [18:24:09] eersh. yes [18:25:58] Jeff_Green: if we have been running maintenance update, that's fine to continue doing so, IMO [18:26:27] I'm not clear on why that is verboten on the main cluster. I think there's some custom hackery, text tables are stored in weird places, something... [18:27:14] ejegg: I'm in the hangout for the check-in, if you're ready. [18:27:27] be right there [18:28:44] awight: I've never done an upgrade [18:29:04] oof. [18:29:06] we can copy the db to lutetium and try the script there? [18:29:15] sure. we'd need a copy of the source, too. [18:29:51] makes sense that we haven't needed to, if we've never upgraded MW and none of our extensions have db migrations. [18:30:10] actually, the ContributionTracking migrations are really effed.... fortunately we don't need to run them, ever. [18:30:10] yeah [18:31:04] i can make another frdeploy project for lutetium [18:31:09] ejegg: fyi I'm deploying CRM, and it includes your htaccess fix [18:31:11] with its own config file [18:31:24] Jeff_Green: whatever you think is best [18:31:53] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/168360 [18:32:02] do you envision a test instance you can live-hack? [18:32:05] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/168360 (owner: Awight) [18:32:10] otherwise, syncblast is grand [18:32:12] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/168360 (owner: Awight) [18:32:18] Jeff_Green: no livehack needed today [18:32:22] k [18:32:29] gimme about 15 min [18:32:33] we'll need to tweak db stuff in LocalSettings, but that's all [18:32:36] great! [18:32:39] k [18:33:22] REL1_23 right? [18:33:25] eew... fu6y [18:33:34] Jeff_Green: no, fundraising/REL1_23 [18:33:52] k, that's what I meant [18:34:22] !log updated crm from d6a75b6df4482de61da372fa653902db7ca12766 to 0a3ab0f18ce726898d14adcbe6ab08411c9e3e82 [18:34:29] Logged the message, Master [18:34:53] ejegg: ^^ [18:41:20] hey awight, you got a sec for a question on submodules? [18:42:05] pizzzacat: yessir! [18:42:21] sweet! [18:42:31] awight: awesome, thanks! let's give it another shot [18:43:22] so if I want to allow for the development of submodules in the Dash, do I create repos for them the same way I did for node_modules and bower_modules? will it always have to know the path, in other words? [18:43:54] pizzzacat: interesting. what's the alternative? you want to randomly discover stuff? [18:44:05] Cos that would be fine... [18:44:32] arrrrgghh. Still getting 401s. [18:44:53] ejegg: can u instrument the signature functions? [18:45:09] both sides? [18:45:40] a packet log would be really useful [18:45:41] I don't know if there's an alternative, like maybe just making a new repo each time you want a new widget, and then symlinking to it in the project [18:46:02] just looking for best-practice type of advice I suppose [18:46:09] new repo for each widget seems like overkill [18:46:20] pizzzacat: sorry, I need to fud and then can continue [18:46:23] oh ok [18:46:33] maybe ejegg knows [18:46:40] yeah it could be overkill [18:46:43] pizzzacat: it sounds like you're on a productive path, please assume you can do exactly that [18:46:54] u might want to keep things in the same directory structure, though. [18:47:04] ok, cool [18:47:09] e.g. wikimedia/fundraising/dash/widegts/foo [18:47:11] ok [18:47:31] then request a new repo for each widget so they can be committed individually? [18:47:37] pizzzacat: partly 'cause you need to have one file in /widgets, and a couple others in /src/components/widgets [18:48:06] ejegg: got the logs, thanks much! :) [18:48:08] hmm true [18:48:59] blast [18:49:03] I guess it could be a gulp task to copy stuff into the right place [18:49:25] oh that's an idea… [18:49:35] which stuff were you thinking? [18:49:40] probably the js & html since you're already doing that into dist [18:49:43] I mean what approach [18:49:47] i mean client-side [18:50:00] true [18:50:14] so those would actually never be put into a components folder [18:50:28] er directory [18:50:33] dev might be annoying though [18:50:41] yep [18:51:02] what do we gain from submodulizing each widget? [18:51:25] the ability to work on the widgets independently of the framework changing [18:51:53] so like, right now for example you're troubleshooting some stuff. but also later, someone like Ellery might want to develop a widget [18:52:06] and not want to deal with the framework [18:52:12] huh, ok [18:52:39] but this may not be a huge deal [18:53:09] I mean, I don't know. I see already issues for myself, trying to work on something independently of the framework and going through rebase/etc issues [18:53:25] but later it could be easier when the framework is more stable [18:53:36] Yeah, I think it will get easier [18:53:57] awight|lunch: I wrote out on the etherpad the idea for buckets, amazingly I think it may work, or that's how it seems from my twisted perspective: https://etherpad.wikimedia.org/p/CN_bucketing_overhaul [18:54:03] ejegg: ^ [18:55:59] ejegg should I just go the branch route then, and forget about submodules? and if we want to do it that way someday we can just break it out? [18:56:28] pizzzacat: yeah, let's leave submodules till later if you don't mind [18:57:06] AndyRussG: that seems pretty straightforward [18:57:24] ejegg ok, sounds good. [18:58:36] ejegg: thx, heh really just the first step in the global introduction of solient green [18:59:16] hehe [20:16:47] (PS1) Ejegg: Logging to debug OAuth signature validation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168412 [20:23:30] (PS1) Ejegg: Logging to debug OAuth request signing [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/168416 [20:25:56] (PS1) Ejegg: Logging to debug OAuth request signing [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/168417 [20:26:20] (Abandoned) Ejegg: Logging to debug OAuth request signing [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/168416 (owner: Ejegg) [20:26:44] awight: ^^ [20:26:58] will remove 'em once we've got this sorted [20:53:16] (CR) Awight: [C: 2] Logging to debug OAuth request signing [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/168417 (owner: Ejegg) [20:54:40] (CR) Awight: [C: 2] Logging to debug OAuth signature validation (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168412 (owner: Ejegg) [20:54:43] (Merged) jenkins-bot: Logging to debug OAuth signature validation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168412 (owner: Ejegg) [20:54:56] (CR) Awight: [V: 2] Logging to debug OAuth request signing [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/168417 (owner: Ejegg) [20:55:08] thanks! [20:55:34] good luck! [20:56:29] (PS1) Ejegg: Update node_modules for OAuth debug [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/168425 [20:56:43] (CR) Ejegg: [C: 2] Update node_modules for OAuth debug [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/168425 (owner: Ejegg) [20:57:30] AndyRussG: fyi, atgo is talking me down about actually implementing any of these bucket things until we talk to Megan... and schedule it sanely. [21:00:56] awight: Oh man, there was something I wanted to ask you about prod civi. [21:01:08] I just remembered, because it's related to the audit modules I'm writing now. [21:01:17] K4-713: yes [21:01:26] So, the configuration menu in the UI. [21:01:34] hehe [21:01:38] I install the module on my local, and it's... what? [21:01:43] whoa [21:01:47] Do you already know the punchline? [21:01:51] no [21:02:01] It's just that it seemed like you'd heard this one before. [21:02:06] Which would be great. [21:02:09] * awight frowns [21:02:39] On my local, I enable the module, and the config menu is right where I expect it to be. [21:02:45] oh, good... [21:02:50] On prod, I enable the module and it's freaking nowhere. [21:02:54] (PS1) Ejegg: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/168427 [21:02:55] "drush cc all" [21:03:01] First thing I tried. [21:03:19] (CR) Ejegg: [C: 2] "+2 for deploy" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/168427 (owner: Ejegg) [21:04:35] !log updated civicrm from 0a3ab0f18ce726898d14adcbe6ab08411c9e3e82 to 03b15f7dad58ce61894d632e8fbebd2ae76ae4d0 [21:04:44] Logged the message, Master [21:09:39] (PS1) Awight: add permissions hook for wmf_audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168435 [21:09:40] K4-713: ^^ [21:09:49] oho [21:09:58] When did this become a requirement? [21:10:19] I kind of wonder if the old modules didn't need it because it was already in there before an upgrade or something? [21:11:55] awight: Should that be wmf_audit_permission()? [21:12:13] oh goderp [21:12:30] (PS2) Awight: add permissions hook for wmf_audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168435 [21:12:53] we need those CI tests checking for foolishness [21:13:04] (CR) Katie Horn: [C: 2] add permissions hook for wmf_audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/168435 (owner: Awight) [21:13:28] K4-713: u want me to deploy? [21:13:34] Oh, sure. [21:13:41] No rush, though. [21:14:11] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/168436 [21:14:23]