[00:07:48] and freaking every form of \t and punctuation you might desire. [00:07:56] this tsv format is inadequate, sigh [00:08:16] luckily, I hear from OKeyes that tab literal is rare [00:08:55] and if the following fields have no tabs, and we anchor it to the end, we're still cool [00:09:59] yah I think so. [00:10:24] maybe we can make more specific patterns for some of the other terms... [00:10:34] but that is all on the slash-n-burn schedule. [00:10:38] right [00:16:14] wow, are those hard-coded IPs even valid any more? [00:16:29] eh? In the code somewhere? [00:16:42] Oh, one of them is for aluminium, so definitely not that one! [00:16:48] yeah, just noticed them [00:17:16] it's really bad in there. [00:17:34] I get all worked up about fixing bugs when I peek. [00:17:39] heh [00:21:48] I suppose I should deploy this impressions thing! [00:22:36] AndyRussG|souper: heads-up, I'm gonna try to deploy your fix [00:24:11] do we move all the old logs out of the way temporarily to process stuff since yesterday morning? [00:24:11] (CR) Awight: [V: 2] Count more hide reasons and update log parsing [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/168343 (owner: AndyRussG) [00:25:37] ejegg: no, there's some way to reprocess glob-matching files from the cmdline [00:26:14] ah, nice [00:27:47] !log updated DjangoBannerStats from cf5a875d49f4c4cf229d7f864a73d4c2f588ebf9 to a3038f133d64c737d3987bd1c37a987fd3003dd6 [00:27:56] Logged the message, Master [00:29:13] AndyRussG|souper: woohoo! 00:28:52 SQUID: 47998 OKAY / 0 FAILED with 14276 IGNORED and ... [00:32:34] awight: fantastic!! :) [00:32:59] I can try the \t version and send another patch... [00:34:19] Donno, the last few terms aren't used, so it's not a big deal. [00:34:55] Capturing reason= might be useful if you feel like kicking more ass, but it's not an emergency. [00:35:19] I wouldn't be too sure about any parsing in UA strings with spaces...... [00:36:56] thx relieved it works.... :) [00:40:15] ok cya Monday! [01:04:46] (PS1) Ejegg: Move fonts into /dist, update /dist files [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168734 [01:08:58] (CR) Ejegg: [C: 2] "self-merging non-code change for deploy" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168734 (owner: Ejegg) [01:10:21] (PS1) Ejegg: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/168735 [01:10:38] (CR) Ejegg: [C: 2] "+2 for deploy" [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/168735 (owner: Ejegg) [20:03:29] (PS1) Hoo man: Make sure we declare globals before using them [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/168774 [20:07:00] (PS1) Hoo man: Make sure we declare globals before using them [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/168777 [20:07:13] (CR) Hoo man: "This should be deployed on Monday." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/168777 (owner: Hoo man) [20:09:26] (CR) Ori.livneh: [C: 2] Make sure we declare globals before using them [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/168777 (owner: Hoo man) [20:09:37] (Merged) jenkins-bot: Make sure we declare globals before using them [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/168777 (owner: Hoo man) [20:10:23] (CR) Nemo bis: [C: 1] Make sure we declare globals before using them [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/168774 (owner: Hoo man) [20:10:55] (CR) Ori.livneh: [C: 2] Make sure we declare globals before using them [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/168774 (owner: Hoo man) [20:11:05] (Merged) jenkins-bot: Make sure we declare globals before using them [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/168774 (owner: Hoo man) [20:15:50] (CR) Hoo man: "Apparently Ori is more bold than me and will deploy this today." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/168777 (owner: Hoo man)