[00:00:04] that would be an adventure [00:00:15] I tried a few months ago, it was a bloodbath. [00:00:22] contribution_type vs financial_type..... [00:00:37] totally arbitrary which one to use in 4.4 [00:00:40] oh man, core stuff not upgrading well? [00:00:54] (PS2) Ejegg: Mark old email address as 'On hold' after edit or delete [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170253 [00:01:22] well, the CiviAccounts work caused those two terms to sort of alias to one another, but only about half of the usages are actually back-compatible. [00:01:45] ejegg: wow, nice hook! CR now [00:02:27] one more patchset, just fixing param type [00:02:55] (PS3) Ejegg: Mark old email address as 'On hold' after edit or delete [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170253 [00:10:47] (CR) Awight: [C: 2] "wow." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170253 (owner: Ejegg) [00:11:01] ya blew up my brain [00:13:40] ejegg: ^^ yeah you [00:13:51] that hook was great :D [00:13:52] heh, thanks, i think! [00:14:13] it was all street-fighty yet elegant [00:14:16] I figure if they delete it, see it come back in red, and delete it again, they really want it gone! [00:14:23] yep! that's fair [00:14:51] might have gone to great lengths to avoid nested ifs, but you can tell I hate them more than multiple returns [00:15:40] ah, guess I didn't need to assign the result of that last call, either. Just did that for the debugger [00:15:44] hehe. multiple returns are fine. I twitched a bit at the unrelated clauses in that first conditional, but :p such a ridiculous thing to even mention [00:16:02] ohh, that was what you meant by that comment [00:16:05] whew. typing into the wrong window, new Mingle card: "Document hehe" [00:16:13] heh [00:16:36] I only twitch cos in a year someone will scratch their armpit a bit when they get to that line :p [00:17:59] Took me a while to figure out why || $email->on_hold was evaluating to true when the debugger said it was null. Then I realized it was "null". Seems to happen to me a lot these days! [00:18:11] grr [00:18:14] that is ass. [00:18:36] how to make tri-state crap worse to deal with... quad-state! [00:18:42] thanks for the CR. Gonna head out for the evening! [00:18:51] kbye! [00:40:54] (PS1) Awight: WIP Customized LYBUNT report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170268 [17:06:23] Jeff_Green: Hey, I think we have a ton of time with the AMQ store now... [17:07:16] Do we have any hangovers from yesterday's convergence of totally unrelated random things, that we still need to address? [17:19:43] K4-713: i saw that [17:20:02] we're down to ~37GB, which is great [17:20:19] That still seems like a lot, for only a few thousand messages. :/ [17:20:34] it's because of the stupidity of kahadb [17:20:38] I know... [17:20:47] Harumph. [17:21:14] Maybe I'll have another look for random old messages. [17:21:43] i tweaked nagios so it should start complaining a lot as we approach 80GB [17:21:53] i think the configured cap is 100GB [17:22:10] Sounds right. [17:22:11] and we have a lot of space on the partition, so we can raise the cap in a dire emergency [17:27:39] hey K4-713... megan is thinking about putting up a GC vs WP test in the US [17:27:48] do you have any objections/availability to keep an eye on things? [17:27:57] Sounds like a good idea to me. [17:28:01] word. [17:28:05] she's thinking maybe 11am [17:28:32] Can we do 11:15 so it's not conflicting with standup? [17:28:55] sounds gouda [17:29:10] Mmm. Gouda. [17:31:04] Oh, atgo: There's a thing I wanted to talk to you about... [17:31:10] cheese? [17:31:16] Well, yes. [17:31:32] But also, the way we track donations in the system after they're made. [17:31:45] Specifically, when we have one of these new... feeder integrations... [17:32:04] I think awight and ejegg should team up on that one. [17:32:29] like instantbuy you mean? [17:32:50] That, and/or others like it in the future, yes. [17:33:00] I'm thinking we should be responsible for the accounting bits there. [17:33:25] It's... possibly the only thing I can think of to parallelize some of this work. [17:33:33] yeah, i get that [17:33:46] the only thing is that we have other higher priority things that need to happen before December [17:33:56] so i'm a bit wary to pull them off of that for this [17:34:13] Yeah, but we're probably more invested in getting this long-term correct... and this might require a civi wizard. [17:34:49] totally understand. however, we have these must-haves as well [17:34:49] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards?favorite_id=12140&view=Big+En+2014+planning [17:35:14] So, the other thing I'm thinking, is that in the best case scenario, we have the new toy. [17:35:21] ps - mingle is orange again. [17:35:34] At that point, if the tracking isn't right... we're going to get pulled off other things to fix it anyway. [17:35:47] Best case means more work. :/ [17:35:52] yeah [17:35:56] feeder integration? [17:36:06] You know... [17:36:13] i am not clear on whether or not zac is willing to take part of this on [17:36:28] He had a point about this on his milestone doc which I have now. [17:36:33] It was dead last. [17:36:45] Feeder integrations: one-time virtual cards through existing gateways. [17:36:56] ah, gotcha [17:45:57] i'm willing to do whatever you need [17:45:58] :) [17:48:16] thanks zacs! [17:48:32] let's chat about this when we manage to connect next week [17:48:39] sounds good [17:51:19] Jeff_Green: Thanks for the new dev_ snapshots! [17:56:28] hey Jeff_Green! did you get a chance to set up PPena for lutetium access? [17:56:38] just checking in. i believe k4 contacted you earlier [17:57:47] ejegg: yw [17:58:21] atgo: she did, and I have an outstanding RT ticket for her an one or two others. sorry, I haven't gotten to it yet but I haven't forgotten [17:58:37] no worries :) [17:58:46] omg this ibooks thing is going to kill me with login-notification spam [17:58:51] ejegg - just chatted with major gifts and we're going to cancel the checkin today [17:58:55] there may or may not be one next week [17:59:02] ipython i mean [18:01:04] also standup? [18:17:59] ccogdill not sure if you saw in gchat, but just a heads up that this is in progress: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1992 [18:18:13] I did! thank you [18:18:19] such a huge help [18:18:46] I ran some Italian numbers, of the 2296 tickets we received, 8% (198) were email updates [18:30:11] ejegg: Do you know where the wr1 files live? [18:30:26] nope! [18:30:36] Looking at those might help you understand... whatever. [18:30:41] They're incredibly sparse. [18:30:51] yeah, that would be helpful, thanks! [18:30:58] paste path elsewhere? [18:31:03] aye [18:36:08] !log disabled recurring globalcollect [18:36:14] Logged the message, Master [18:37:03] meganhernandez: Are we still doing a WPUS test? [18:37:25] Still standing by. [18:39:03] just wrapping up with ellery [18:39:08] want to in 10 mins? [18:39:27] Sure! [18:39:31] * K4-713 grabs more coffee [18:56:51] hey K4-713 i was just checking the banners peter made and we need a tweak [18:57:03] Oh good. Because it's totally lunch time. [18:57:10] meganhernandez: Can we try again in an hour? [18:57:16] they don’t have the close code in there. and i don’t see him online anymore [18:57:25] d'oh. [18:57:34] Yeah, that seems important. [18:57:39] i’ll send them over to him so he can tweak them, it’s easy. but yeah [18:57:43] okay. [18:57:54] i’ll reply to the thread if i get them back today [18:58:00] Great. [18:58:07] Going for food now. :) [18:58:17] if not, monday or tues? we can just set up the campaign ahead of time & you can enable it whenver [18:58:18] ok [18:58:20] have a good one [18:58:23] You too! [19:14:28] (PS1) Ejegg: Use real contribution tracking id for recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170378 [19:42:48] (PS2) Ejegg: Use real contribution tracking id for recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170378 [19:53:34] (PS1) Ejegg: Fix hook fail on api email creation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170388 [20:22:46] hey atgo K4-713 meganhernandez - anyone have an enBE Worldpay link? [20:23:02] I have a banner in French but not English, and don’t know how to force WP for belgium [20:23:18] let me see your link [20:24:14] https://fr.wikipedia.org/?banner=B14_1031_frBE_gtw_wp_2&force=1&country=BE [20:24:29] I tried switching the fr’s with en’s to no avail, and couldn’t find anything on central notice [20:25:02] you need a blank one with no amount? [20:25:31] https://payments.wikimedia.org/index.php?title=Special:WorldPayGateway&appeal=JimmyQuote&ffname=worldpay&recurring=&utm_medium=sitenotice&utm_campaign=none&utm_source=B14_1031_frBE_gtw_wp_2.no-LP.cc&language=fr&country=BE¤cy_code=EUR&payment_method=cc&referrer=&returnto=&frequency=onetime&amountGiven=&utm_key=1&uselang=en&gateway=worldpay [20:25:45] but that has a 2 euro amount [20:26:24] yeah :/ trying to avoid having to ask donors to give us the amount so we can send a custom link, but we can do that if it’s our best option [20:26:39] yeah we should have one... let me ask k4 irl [20:26:47] thanks! [20:27:47] so... this'll work for GC [20:27:47] https://donate.wikimedia.org/w/index.php?title=Special:FundraiserLandingPage&country=BE&uselang=en&utm_medium=spontaneous&utm_source=fr-redir&utm_campaign=spontaneous [20:27:51] but you need a WP one? [20:28:27] ccogdill ^ [20:28:31] for belgium? [20:28:55] there’s an error where people in France are trying to donate with a non-french card and they fail automatically [20:29:10] ahh.. yeah... that's a known thing. you can send them the GC form [20:29:11] so Pats said WP said the solution was to send the BE WP form [20:29:15] which processes through streamline [20:29:21] okay PPena does that sound okay to you? [20:30:34] ccogdill I think this is the best idea so far, but we are still confirming with them to make sure its a feasible workaround (that cards wont get the same error via Streamline in BE) [20:30:51] so PPena what i'm saying is that we should just send them the GC form [20:30:52] PPena see atgo’s response above mine [20:30:57] she just wants to use the GC form [20:31:01] which is fine with me [20:31:20] it's not impossible to get to a WP form, but would take (a little bit of) tech work, and i'm not seeing a hard reason for it [20:31:48] atgo my fear is that GC will reject those too, but we can try [20:31:54] why would they? [20:31:57] ccogdill can you try that one first and follow up with the donors [20:32:13] please :) [20:32:16] yep [20:32:19] I think it’ll work [20:32:28] cool, thanks all [20:34:23] K4-713: https://gerrit.wikimedia.org/r/170378 should fix the recurring 123456 [20:34:38] and I'm pretty sure it is just recurring [20:39:24] the currencies and amounts match up between the wr file and the wmf_contribution_extra table for the records after the deployment [20:40:53] K4-713: and this one's a fix for my email edit/suppression patch breaking api email creation: https://gerrit.wikimedia.org/r/170388 [20:45:17] ejegg: Looking now. [20:45:49] K4-713: those wr files are only for non-USD? [20:45:58] No, those are everything. [20:46:29] oh, duh, now I see the USD ones [20:47:22] and no time data beyond the date, it seems [20:53:21] ejegg: wr1 files are unbelievably sparse. [20:55:04] ejegg: Hang on, this looks a little odd. [20:55:49] Is there a reason we're not just sending the original order ID in both fields? [20:56:55] both? [20:58:46] * K4-713 burbles [20:58:47] merchantreference and ? [20:58:52] Sorry, I'm terribly confused right now. [20:59:17] It's difficult to see how we got where we are, and I think I did half of it. [20:59:41] again I'm glad I'm not the only one confused by all of this! [20:59:56] * K4-713 looks sad [21:00:31] I hate it when I go spelunking in DI, find a particularly infuriating line, git blame, and it's me. [21:01:07] Commit message starts with : "CAREFUL: This commit has potential to be very disruptive." [21:01:11] THANK YOU, OLD ME. [21:01:15] VERY HELPFUL. [21:01:29] hehe [21:02:11] "Amazon is a mutant. However, it seems to work... so we should un-mutant it in a different monster patch." [21:02:17] * K4-713 sighs [21:02:56] "Need to come up with a new way to structure our tests. Preferably something that doesn't make poking both of my own eyes out sound like more fun than writing new tests." [21:03:07] lovely [21:04:24] Okay, so what I'm looking at, is the bit where we started sending ctid in merchant reference, instead of just oid in two places. [21:04:43] seems to make sense [21:04:52] But, it's ctid + 5 random digits, because GC objected to getting the same merchant reference twice for the same OID. [21:05:02] ...makes a certain amount of sense so far. [21:05:42] The problem, though, is that I don't think the audit script will, ah... handle these gracefully. [21:06:23] If they're coming in from recurring. [21:06:32] It might. [21:06:34] oh? Why specifically recurring? [21:07:19] So, it will have to be smart enough to know that what it's looking at in the merchantreference field is a ctid & '.' & $whocares, and look for it in the civi database that way. [21:07:45] ...because there is no chance it will be able to rebuild from payments log files. [21:07:51] right [21:08:00] phew. [21:08:02] Okay. [21:08:18] I'll... look at that now. [21:08:20] oh, it's looking in the logs from payments cluster! [21:08:24] Yes! [21:08:28] :) [21:08:34] And, you know, *just* those. [21:08:37] i should read the audit code... [21:08:47] Eh, I wouldn't recommend it. [21:08:57] If nothing was exploding right now, I'd be eyeball deep in the rewrite. [21:09:23] ...in which all the data is in the same place to begin with and we don't have to doof around with payments logs at all anymore. [21:10:24] It's a beautiful dream. [21:10:49] Also, the audit code as it stands today, is... [21:11:14] ...well, it's like a monument to what happens to my brain when I'm sleep deprived, under the gun, and trying to do five things at once. [21:11:18] It's like an insanity map. [21:11:25] aww [21:11:40] No, really. Most of that was authored out of one bloodshot eye. [21:11:51] terrifying! [21:12:07] Having said that, a surprisingly small amount of it has changed since January 2012. [21:13:06] But the new one is so much better. [21:14:48] Oh. [21:14:53] Wait, I did think of this. [21:16:13] Yeah, it's totally been handled. Neat. [21:17:09] yay! [21:19:17] ejegg: Okay, one last question. [21:19:30] Why did you nuke the 'standalone_globalcollect_adapter_path' stuff? [21:20:08] Seems totally unrelated. [21:20:47] oh yeah, sorry, can split that out [21:25:01] (PS3) Ejegg: Use real contribution tracking id for recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170378 [21:26:18] (PS1) Ejegg: Nuke standalone_globalcollect_adapter_path use in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170442 [21:46:13] blarg, some jpmorgan imports are coming in with nonsense original_amounts [21:46:40] got one with original_amount = 7.00, original_currency = EUR, and total_amount (USD) = 10,000 [21:47:05] the 'source' looks good, at EUR 7,265.01 [21:47:19] oh, that comma must have screwed up the parsing [21:48:18] Stupid commas. [21:48:18] so, I don't want to run recalculation just yet [21:48:37] as it would knock that down to ten bucks [21:48:40] ejegg: Are you done with https://gerrit.wikimedia.org/r/#/c/170378/ now? [21:48:44] yeah [21:49:23] You know... in the future, when we assign dummy numbers, we should have different ones for every codebase. [21:49:46] If, for instance, the unfork had "654321" instead of "123456"... [21:49:52] heh, or use the revision number [21:49:59] Also, I just typed "undork". [21:50:05] That's different. [21:50:08] no hope of that here! [21:50:13] Also, I don't think I can be a part of that. :) [21:50:26] High five. [21:50:35] * ejegg misses [21:50:51] sorry, too dorky to high five right [21:52:21] I'm glad we're all on the same page today. [21:53:01] (CR) Katie Horn: [C: 2] Use real contribution tracking id for recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170378 (owner: Ejegg) [21:54:11] Thanks! Want me to cherry-pick that in for deploy? If I deploy the email patch as well, we'll need this fix too: https://gerrit.wikimedia.org/r/170388 [21:55:00] Hmm. I'm reluctant to do a friday deploy on a holiday weekend... [21:55:22] ok, I can live with putting it off till monday [21:55:31] Then again, I haven't gotten any feedback about holding off yet. [21:55:39] recurring has how long a lag catchup time? [21:56:02] Whatever it is, it's configurable in the UI. [21:56:08] ah, cool [21:56:45] (CR) Katie Horn: [C: 2] "Argh." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170388 (owner: Ejegg) [21:56:53] Well, that's ready now, at any rate. [21:56:58] thanks again! [21:57:04] Yep! [21:57:47] OK, I'll look at fixing the comma-afflicted rows for just the recalc period, and file a card for fixing the import [21:58:28] Sounds good to me. [21:59:05] I think I'll probably poke at WP stats for a few minutes, and then try to remember where I got stuck on the WX implementation. [21:59:17] enjoy! [22:00:44] Let me know if you find any more ghosts in the machines. :) [22:00:51] will do! [22:37:41] Hey fundraising people [22:38:00] Hi guillom [22:38:20] Do you know where I can find the translations of the post-donation survey? I've received feedback from a French user and I'd like to make a few tweaks to the text :) [22:38:28] Hi AndyRussG! [22:39:01] Hmm no idea sorry 8p, K4-713 might know :) [22:39:10] gotta run, cya, everyone! [22:39:18] bahaha... dang. [22:39:21] What happened? [22:39:33] I'm guessing it's somewhere on translatewiki.net but it's soooo bg [22:39:42] big, too [22:39:51] It might be on meta. [22:39:55] Hah! [22:40:06] I'm not entirely sure how they do these things, really. [22:40:10] I looked at https://meta.wikimedia.org/wiki/Fundraising/Translation [22:40:15] I might just wait for Jessica [22:40:28] Yeah, she would definitely know. [22:40:32] But I thought I'd ask here just in case :) [22:41:03] In fact, everybody who would definitely know, is in Europe. [22:41:08] heh [22:41:10] So, hopefully asleep. [22:41:31] Why did I move here. Tell me, WHY? I'm in the Wrong timezone now! [22:41:49] That has to be disorienting. [22:56:56] K4-713 can you sanity check me on this - I'm supposed to see all the changes from my patch https://gerrit.wikimedia.org/r/#/c/169341/ [22:57:40] but some of them are missing. and I checked out the HEAD~1 but it's the same story. [22:57:53] Where are you not seeing the changes? [22:58:11] In your browser? [22:58:20] no, just some of the files are missing [22:58:24] in the directory. [22:58:36] so like, you're supposed to see a worldpay-test.html [22:58:36] Weird. Hang on, I'll... turn several degrees... [22:58:42] haa [23:04:13] pizzzacat k4-713 ewulczyn - party is starting up here! I’m still working haha but hoping you all can make it up [23:04:23] Caitlin_Virtue is asking for you :) [23:04:27] for party purposes [23:12:14] * marktraceur dances [23:12:21] Is K4-713 running the karaoke? :) [23:15:58] There's karaoke? [23:16:34] I guess that's a no