[00:17:03] hehe, I guess I burned out my DSL modem with all the 'torrenting. [00:17:16] It will only flicker on for an instant... [00:17:53] awight: boo! [00:18:00] AndyRussG|hmwork: lemme know if you want to charge into the skin change thing! [00:18:08] * awight jumps in fright [00:18:26] I'm still thinking about it... <_< [00:18:33] yep, no worries [00:18:46] What about sending the stuff in in resourceloader config variables? [00:18:57] How do those get in there? [00:19:07] Excellent question, I'm not sure. [00:19:18] But i assume they must be loaded by something in the skin [00:19:36] * awight looks [00:19:39] Maybe they're not as strictly cached and we part of a request that's already happening, that we could piggyback on? [00:20:03] I doubt, but that's an interesting angle [00:21:24] For example, in bannerController we get mw.config.get( 'wgUserLanguage' ) [00:21:49] Really that's all we need to requests to bifurcate on [00:22:04] Or almost, the other being logged in vs anon [00:22:17] Project just means whatever wiki we're already on [00:22:35] AndyRussG: search a wiki web response for mw.config.set [00:23:20] it's being set in http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=startup&only=scripts&skin=vector&* [00:23:32] which might be something we can purge often! [00:25:37] well there is certainly a buttload or 2 of data in there [00:27:28] including Cn stuff, for example wgNoticeOldCookieApocalypse [00:28:09] What if we just set a configuration variable with a good old fashion data structure? [00:28:09] yes! Those settings come from both the mw-config repo, and from mediawiki core and extension code... [00:28:16] I'm digging it so far. [00:28:26] Wanna ask on wikimedia-dev if this is possible? [00:28:34] yeah let's :) [00:28:51] * awight puts on pants with fewer holes [00:54:04] Well, that was baller. [00:54:19] Sometimes I think MediaWiki is not so bad, after all :) [01:12:58] so, exploiting ResourceLoader for CN campaigns is a go, huh? [01:13:00] nice! [01:13:17] yeah [01:13:24] very exciting! [01:13:42] This will also tighten up our stupid 15-minute cache expiry on BannerRandom [01:14:02] * AndyRussG enjoys the fuzzy feeling of having slightly contributed to awight's faith in humanity... [01:14:04] could go down to 5 minutes, or even less if we want to be pushy [01:14:07] lol [01:14:23] AndyRussG: not sure you should feel too good about adding to my faith in *PHP* [01:14:49] Heh you even called it pretty 8p [01:15:11] ResourceLoaderLanguageDataModule::getData... it is pretty [01:15:30] Sometimes beauty is objective :D [01:15:49] awight: ejegg: I think it's also a go then to be able to send in a few bits of pre-fecth per-campaign JS in that blob, no? [01:16:03] for sure. [01:16:58] wooo \o/ K we're in the money... ah no I mean, we're in the... collective consensus-based free knowledge goodness... [01:16:59] ejegg: yeah and not sure u saw it mentioned, but this also cuts down our cache fragmentation torture by some huge number of dimensions [01:17:29] yeah, was lurking along. Sounds great! [01:18:30] heh I'm glad I didn't follow my gut and do the BeforePageDisplay hook, thanks for poking me on this awight [01:20:05] err all credit and blame is yours, we had a deal! [01:20:17] I was encouraging u to go for the skin change... [01:20:45] though you problematized it in a way I totally had no idea about [01:20:57] * AndyRussG wonders whether we'll still bring down the site [01:22:51] Feel free to share your champagne with Krinkle :) ... if they don't lock us up for this [01:23:53] huh I thought this _was_ the loonie bin [01:24:12] you mean we're not locked up yet? [01:24:16] brewery, *then* the loonie bin aye? [01:24:36] K yes I think that's the correct load order [01:27:00] I'm just elated that we might be able to ditch this phony "slots" thing... it's been such a deadweight. [01:27:50] a pretty clever tho [01:28:01] clever one [01:28:06] tho [01:28:16] grr. I would go back and break up my parents over that one... [01:28:19] but yeah nice to no longer need it [01:28:52] family! [01:29:11] heh yeah multiastasking here too 8p I must confess... [01:29:17] enjoy! [17:17:14] (PS1) Ejegg: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/170953 [17:17:36] (CR) Ejegg: [C: 2] "+2 for deploy" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/170953 (owner: Ejegg) [17:21:02] !log updated crm from b8a1fa98b5d9252d708090c99b61fd22ebe8d2be to e9e81a828d50e8bddf98eae699c925e09b25927b [17:21:09] Logged the message, Master [19:00:49] ejegg: awight|nowork: Hi...! So the plan is still standups at 2:33 PMPacific? [19:12:50] (PS5) Ssmith: Add form partials for WP button copy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/169341 [19:14:40] hi AndyRussG : I think so [19:14:53] ejegg: :) cool thanks! [19:55:56] (PS1) Ssmith: Add dropdown test for WorldPay credit card entry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171022 [19:56:19] (CR) jenkins-bot: [V: -1] Add dropdown test for WorldPay credit card entry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171022 (owner: Ssmith) [20:16:36] (CR) Ejegg: [C: 2] "Looking good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/169341 (owner: Ssmith) [20:19:42] (PS2) Ssmith: Add dropdown test for WorldPay credit card entry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171022 [20:22:23] (Merged) jenkins-bot: Add form partials for WP button copy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/169341 (owner: Ssmith) [20:58:07] (PS2) AndyRussG: WIP API for campaign allocation choices [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 [21:02:29] (CR) AndyRussG: "WIP until patches that use this API are solidified. Also leaving off API help stuff for now..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [21:47:30] (PS3) Ssmith: Add dropdown test for WorldPay credit card entry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171022 [22:10:43] (CR) Ejegg: [C: 2] "Good stuff" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171022 (owner: Ssmith) [22:11:25] (Merged) jenkins-bot: Add dropdown test for WorldPay credit card entry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171022 (owner: Ssmith) [22:26:20] (PS2) Ssmith: Add log out button [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/169236 (owner: Ejegg) [22:27:50] (CR) Ssmith: [C: 2] Add log out button [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/169236 (owner: Ejegg) [22:30:30] pizzzacat: ejegg: AndyRussG|brb: care 4 a standup? [22:30:48] awight: I'm already there :) https://plus.google.com/hangouts/_/wikimedia.org/fr-tech-daily?authuser=0 [22:30:50] sure! [22:47:45] awight: ejegg: happy to hear any comments on the step 1 bucket patch, it's pretty straightforward tho I'm slightly concerned there might be broken DB-query-related edge cases lurking in there... thanks in advance... [23:05:01] just reading up on mediawiki's db api [23:06:07] ooh that's a fun one [23:06:25] * AndyRussG makes dinosaur noises [23:10:45] (PS4) Ejegg: Add BigEnglish widget, first chart as POC [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168603 (owner: Ssmith) [23:11:04] (CR) Ejegg: [C: 2] Add BigEnglish widget, first chart as POC [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168603 (owner: Ssmith) [23:11:12] (Merged) jenkins-bot: Add BigEnglish widget, first chart as POC [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/168603 (owner: Ssmith) [23:24:33] AndyRussG: Would it be better to put the join conditions in a separate array and use that parameter? [23:25:06] ejegg: mmm as a parameter in what sense? [23:25:16] to the select method? [23:26:37] stil not sure what you mean... the select method takes an array for conditions in general, which is $conds (AllocationChoiceProvider L44) [23:27:16] yep, looks like it takes a couple of optional params after that for options and join_conditions [23:28:03] ejegg: hmm I've only seen that used for additional options like "LEFT JOIN" etc [23:28:04] so if you want to make the sql come out with the explicit joins, you can use that last param [23:28:31] Ah hmmm right I see [23:28:34] huh, guess so [23:28:52] db engines are pretty good at optimizing the implicit joins, huh? [23:29:00] K, I think you're right ou can do that, I never looked closely at that bit [23:29:34] Truthfully I have no idea, I'm just following existing patterns that I've seen, that are quite possibly suboptimal.. [23:30:33] hmm, can't see that param used anyplace yet. [23:30:47] Here is an example... https://www.mediawiki.org/wiki/Manual:Database_access#Wrapper_function:_select.28.29 (scroll down a bit...) [23:32:06] It's used... from core try grep -r JOIN includes/ [23:32:44] ejegg: OK, I'll try that! :) I'm all for explicitness here [23:33:05] ahh cool [23:33:13] Even if the DB can optimize implicit joins, it seems likely it'll do a better job on explicit ones... [23:33:21] or at least won't do a worse job [23:33:31] Yeah, I would hope so! Back in a bit... [23:33:38] K thanks much :) [23:58:09] AndyRussG|hmwork: ejegg|away: more DB fun, https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2138