[00:03:09] awight: ejegg: two changes that I was going to mention to existing CN patches... the first one adds the choices provider and the API, so I was thinking instead of separating them out into separate changes [00:03:23] And the other thing is that I'm not sure about the terminology being the clearest possible [00:03:39] wrt "choices"? [00:03:55] and allocation [00:04:04] maybe BannerOptions? [00:04:12] BannerOptionChoices? [00:04:36] I don't like "option" or "choices", personally [00:04:44] Hmmmm [00:04:48] banner groups? [00:04:59] OK at least we're agreed on changing it somehow :) [00:05:03] how about "Maoist hegemony" [00:05:10] err [00:05:24] How about excellence in elementary school math educatino? [00:05:35] allocations is the user-facing tem [00:05:36] term [00:05:53] we can do whatever in code, but probably not a good time to redefine user-facing things, fwiw [00:06:33] Yeah no UI changes happening [00:06:41] in these steps really I don't think [00:07:02] allocation kinda includes the idea of deciding, as in, I'm gonna decide what goes where, so I'm allocating [00:07:16] that does seem to be the concept [00:07:36] just cos we're offering a larger subset of the allocations doesn't mean we're really leaving anything new up to the client... [00:08:21] Well in this case the banners and campaigns are allocated, it's just figuring out what was allocated based on the info here or there (server or client) [00:10:19] BannerChooser is the original so there's choice in there... [00:11:13] good point--but that took the "slot" param... [00:11:16] BannerNarrowerDowner doesn't quite have that ring... [00:12:04] atgo: Does this make sense, or did I just make a mess? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2157 [00:13:07] K4-713 looks great, the only thing is maybe to point at where we could borrow/copy some code from pp/amazon? [00:13:20] Oh. you want file names? [00:13:22] I can do that. [00:13:39] They both only have the one form, I think. [00:15:02] I guess I could figure out how to set local instances to actually, you know... display the things. [00:15:05] (PS5) Ssmith: make gauge range selection more clear [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/171982 [00:15:12] Instead of just forwarding on unless there's a problem. [00:15:24] awight: BannerChoicesProvider doesn't cut it then? [00:15:52] Must be some nicer term for narrowing down choices [00:16:07] BannerResolver? [00:16:24] K4-713: nice! [00:16:29] Though, I like "BannerDowner" too. [00:16:30] for the final method... [00:16:36] * awight puts on sunglasses at night [00:17:07] You're lucky I didn't say something like "Eunice". [00:17:13] BannerSubset? [00:17:21] EuniceBannerSubsets? [00:17:32] Nah, just Eunice. [00:17:40] me nice -19 [00:17:58] I get it. [00:18:05] * K4-713 looks pleased with self [00:18:18] * awight further encrypts obscure references [00:21:40] how many bits? [00:22:18] 2-bit encryption [00:22:44] hey pizzzacat3 [00:22:51] Lousy 2-bit encryption grumble grumble [00:22:54] how many pizzzacats?! [00:23:49] anyway, i think we agreed to push the old version down and just include a new one on the bmml files... is that correct? [00:24:18] atgo yes [00:24:28] hokay [00:24:37] that should be ok for now [00:24:46] if it gets crazy we can try a new system of folders [00:24:51] cool sounds good [00:33:25] atgo: Good news! A lot of things aren't the way I remember them being. [00:33:32] ...er. [00:33:36] haha is that a good thing...? [00:33:47] i'm so glad i'm not crazy i'm so glad i'm not crazy [00:33:51] It's kind of hard to tell right now! [00:33:59] gotchya :P [00:34:08] I hope I do that on Wednesday. [01:08:08] BannerSelecitonDataProvider? [01:11:34] Just BannerAllocationProvider? Makes even more sense now that we'll be using it for SpecialBannerAllocation [01:26:14] pizzzacat1: do you know, is it possible to talk to people on github? [01:27:13] awight, in what sense? [01:27:29] pizzzacat: email them, leave a message, etc? [01:27:32] like to comment on their code, or a private message? [01:27:33] oh [01:27:40] I think so. lemme check. [01:28:10] hehehe, http://www.sourcecon.com/news/2014/02/06/how-to-find-almost-any-github-users-email-address/ [01:29:27] yeah it doesn't appear they have direct messaging [01:29:30] pizzzacat: creepy, that works ^^ [01:29:43] I guess the only way I've done it is by commenting on things we were working on [01:29:44] I guess "git log" would have worked as well. [01:30:10] how so? [01:31:09] cos I think all I did was find the committer email in a roundabout fashion [01:32:10] ohh I see [01:44:21] (PS1) Awight: Skeletal browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172472 [02:03:33] (PS2) Awight: WIP Skeletal browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172472 [02:29:20] PHP provider class: BannerChoiceDataProvider [02:29:20] awight ejegg|away: tentatively... [02:29:20] PHP API class: ApiCentralNoticeBannerChoiceData [02:29:20] PHP ResourceLoader class: CNBannerChoiceResourceLoaderModule [02:29:20] JS bannerController lib method: setBannerChoiceData [02:29:20] JS bannerController lib prop: bannerChoiceData [02:29:22] JS bannerController lib method: chooseBanner [02:30:04] Or replace "BannerChoice" with a phrase more to your liking... [02:32:10] AndyRussG: Sounds fine, except it would be nice if the RL module that supplies data has Data in the name and in the module name [02:32:26] gotta run for now! [02:32:26] awight: ah woops OK [02:32:29] (PS3) Awight: WIP Skeletal browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172472 [02:32:30] bye! [04:00:33] (CR) AndyRussG: "Fixed issues marked "Done" in next PS." (6 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [04:01:21] (PS5) AndyRussG: WIP Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 [04:05:35] (CR) AndyRussG: "This patchset:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [09:23:30] (PS4) Awight: WIP Skeletal browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172472 [09:24:50] (PS1) Awight: Alias table names to support prefixed schemas [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172509 [09:30:47] (PS2) Awight: Alias table names to support prefixed schemas [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172509 [11:23:55] (PS5) Awight: Skeletal browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172472 [18:39:32] (PS6) AndyRussG: WIP Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 [19:14:18] (PS7) AndyRussG: WIP Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 [21:02:38] (PS8) AndyRussG: WIP Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 [21:09:02] (PS9) AndyRussG: WIP Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 [22:01:26] Hey [22:01:31] Are you guys using the FundraisingEmailUnsubscribe extension? [22:01:35] It looks effectively abandoned [22:36:24] Hi Reedy [22:36:47] Hmm I'm afraid I have no idea... :( [22:37:40] I don't see it installed... [22:41:11] (PS1) AndyRussG: WIP Add the centralnoticebannerchoicedata API module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172656 [22:41:22] (CR) jenkins-bot: [V: -1] WIP Add the centralnoticebannerchoicedata API module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172656 (owner: AndyRussG) [22:42:47] (PS2) AndyRussG: WIP Add the centralnoticebannerchoicedata API module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172656 [22:42:57] AndyRussG: Ditto :) [22:43:22] I'm guessing the fact it's not currently translated is a big hint about this too [22:43:38] Presumably it should be, but never was for whatever reason [22:44:30] *should be deployed [22:45:27] Reedy: last actual change was like a year ago [22:45:43] Don't see a mediawiki.org page... [22:45:53] So looks doubtful [22:46:41] Mind you there are lots of bits of the FR architecture I don't know a lot about but since things seem to move pretty fast, I'd be surprised if something so abandonded were in use... [22:47:23] lol [22:47:38] Where's the best place to file a bug/whatever so it gets to the eyes of the relevant people? [22:47:43] https://gerrit.wikimedia.org/r/172651 [22:48:06] There's a change to have it enabled on translatewiki, but it's just a waste of translators time if they're doing something that isn't used [22:48:50] (CR) AndyRussG: WIP Add BannerChoiceDataProvider (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [22:49:08] I CC'd matt walker on the changeset [22:50:09] Reedy: Hmmm, that's OK though he has moved on to work on flying things, no longer at the WMF [22:50:45] I would file a bugzilla report and ping or e-mail Anne Gomez (atgo) or Katie, I'm sure they'll both be back tomorrow [22:56:56] (CR) AndyRussG: "- Informs whether a campaign is geolocated." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [23:23:03] (PS4) AndyRussG: WIP Get banner choices via server, choose on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 [23:24:35] (CR) AndyRussG: "Just rebased..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 (owner: AndyRussG) [23:29:46] Just filed https://bugzilla.wikimedia.org/73286 [23:30:04] Reedy: cool thanks! :)