[00:50:54] awight: boo! [00:51:38] AndyRussG: hey, I was about to mess with a few QUnit tests [00:51:41] How's it going? [00:51:54] U can't fool me btw about this not being a Canadian holiday :p [00:52:08] * awight looks up role of Canada in WWII [00:52:12] Not too bad :) going carefully... [00:52:18] It is but the kids had school like usual [00:52:23] ahhh [00:52:24] ok then [00:52:30] carry on 8p [00:52:33] They did have to sing a song or two tho [00:52:37] woohoo! [00:52:40] But other than that it's normal [00:52:53] I was just reminiscing about the union song u lullabye'd my baby with [00:53:00] that was radical [00:53:10] which one was that? [00:53:15] * AndyRussG joggles memory [00:53:24] I didn't know the song [00:53:57] * awight marches around with the tenth of the Internationale I might be able to muster [00:54:11] AndyRussG: u want any CR? [00:54:17] Ah yeah I think I know which one [00:54:21] wow! [00:54:34] wow? [00:54:35] in the car, headed down the Peninsula for bowling... [00:54:58] When is the SF trip, btw? [00:55:30] I thought at the beginning of December but I haven't heard anything for a little while [00:55:49] And also at the end of January I think [00:56:46] trying now to remember the tune... [00:57:58] Yeah these two patches are at least ready for another go: [00:57:58] https://gerrit.wikimedia.org/r/#/c/170843/ [00:58:06] https://gerrit.wikimedia.org/r/#/c/172656/ [00:59:12] oh sure! [01:00:03] AndyRussG: btw, merging this would be a favor, my dev instance is a bit janky otherwise, https://gerrit.wikimedia.org/r/#/c/172509/ [01:00:25] AndyRussG: ah, you weren't on the reviewer list [01:00:54] semimental note, you or I should create a CN devs group in Gerrit [01:01:06] ah OK [01:01:15] Back, sorry had some fish in my wifi [01:01:24] making it fishy [01:01:32] nice neoidiom! [01:02:31] :) [01:03:03] awight: should we always be using table aliases? I though it was kinda borking something in the joins of the first patch I sent u, in fact, that's why I left 'em off [01:03:52] Ah on the topic of tables... is it my imagination, or does cn_assignments really not have any indexes besides primary key? [01:06:21] * AndyRussG continues to hunt for that tune... [01:07:13] awight: BTW the above patches aren't ready to *merge* yet, just ready for another look... [01:07:42] (CR) Awight: [C: 2] WIP Add the centralnoticebannerchoicedata API module (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172656 (owner: AndyRussG) [01:08:35] awight: don't do it!! not yet!! it even still says "WIP" [01:08:46] we'll get a "WIP"-y history [01:10:41] (CR) AndyRussG: [C: -2] "(Note: not yet ready for merge pls...)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [01:13:07] (PS3) AndyRussG: WIP Add the centralnoticebannerchoicedata API module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172656 [01:21:16] (CR) AndyRussG: [C: 2] "Wooo!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172509 (owner: Awight) [01:21:27] (Merged) jenkins-bot: Alias table names to support prefixed schemas [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172509 (owner: Awight) [01:24:54] (CR) Awight: [C: 2] WIP Add BannerChoiceDataProvider (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [01:25:18] (CR) Awight: WIP Add BannerChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [01:25:52] AndyRussG: hah, thanks for the -2 to slow me down, there [01:26:14] AndyRussG: yeah, I think we need table aliases whenever you want to reference the table by name [01:26:28] * awight looks at cn_assignments [01:26:35] ah OK re: aliases lemme check that out [01:27:02] Yeah np, we don't want to have to send K4 on a space voyage to make time appear to slow down for her agin [01:27:09] you can leave them out if none of the column names overlap, and you don't want to reference as table.column [01:27:17] hehehe [01:27:18] thanks much BTW!! also let me know if you need anything for QUnit tests... I did just a bit of those for Campaigns [01:27:37] awight: re: table names, OK, I'll check it out [01:27:38] She's really been on a roller coaster, my heart goes out to her [01:27:52] AndyRussG: oh great, yeah I'll copy your work, then [01:28:08] one sec lemme pull up the patch... [01:28:25] qunit: https://gerrit.wikimedia.org/r/#/c/151594/ [01:28:57] AndyRussG: cn_assignments: yep, we're fumbling in the dark with no keys [01:28:58] My main takeaways after this first QUnit go were: you test the inputs and outputs of functions [01:29:02] awesome [01:29:19] AndyRussG: ping if I can help you get the browser tests running [01:29:41] and the code that u test should not have any effects other than defining objects that u want to test [01:29:58] that's why I made bannerController.lib, which can be loaded for the tests but doesn't do anything on load [01:30:16] I'm sure I saw JS mocking capabilities somewhere in MW tho I didn't use 'em [01:30:19] that's perfect [01:30:25] no I want to stay away from mocking [01:30:38] it doesn't seem to be... well grasped [01:30:47] Ah OK [01:30:50] meanwhile, I've been having a blast with mocking in Python [01:30:55] re: browser tests, K thanks! I'm still working on the features... [01:31:06] u can override system libraries, etc. [01:31:33] interesting! yeah Python's from another planet sometimes [01:31:46] of course. sure, maybe the tests only useful as a simple cross-OS regression suite. [01:32:01] a dirty planet full of quicksand [01:32:13] but where you can build a palace in hours [01:32:33] the other day I came across a gotcha where you could legally indent something in different ways and it had a totally different meaning [01:32:48] but it was anything but visually obvious [01:33:41] oh the whitespace thing is horrible [01:38:51] AndyRussG: oh! the Campaigns code has not gotten reviewed. [01:39:30] No it's still dependent on a WIP patch that I promised to ask for some design help on, and also there was the whole thing as to whether the feature will ever be merged anyway [01:39:39] kinda left it on the back burner for now [01:43:55] aha ok I'll stop adding reviewers, then [01:44:41] AndyRussG: so, quick checkin--is your near-term plan to solidify the existing commits, or is there still functionality you're coding? [01:44:47] * awight reads code again. [01:44:57] Right, there's the JS side of things [01:45:16] Yeah actually still quite a lot of functionality to go [01:45:38] AndyRussG: you want https://gerrit.wikimedia.org/r/#/c/172299/ re-reviewed? [01:46:03] Lemme... [01:46:05] just ignore me [01:47:05] I'm going to have a quiet QUnit party on my own, now :) [01:51:29] awight: that patch, not yet, but soooooooon [01:54:05] sorry--meaning, I'm gonna whip up some basic qunit tests for CN [01:54:55] K! I should have some more testable JS in a few hours... [01:55:20] Also if you find yourself looking for stuff to do, there's also PHPUnit testing of the PHP side [01:56:11] Including devising test DB data cases with complicated overlapping campaign and banner data :) [01:56:29] cool. wrt js tests, I'll try to stay away from stuff w/o a defined API yet, I'll just pluck low-hanging, existing fruit [01:56:34] hehe cool [01:56:51] yes that's equally important [01:57:27] in PHP, I'll start by trying to apply the existing allocation tests to the new framework [01:58:26] Ah OK! Mmm I didn't notice there were already allocation tests, /me facepalms... [01:59:08] I think they even cover regressions to bugs we've found! [01:59:19] Yeah we could already start testing the output of BannerChoiceDataProvider [01:59:35] rad. k [02:05:31] thanks!! :D [03:17:36] (PS1) Awight: WIP Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 [03:17:47] (CR) jenkins-bot: [V: -1] WIP Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 (owner: Awight) [03:19:02] (PS2) Awight: WIP Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 [04:26:33] AndyRussG: u might want to add yourself to CN, here: http://www.mediawiki.org/wiki/Git/Reviewers [04:27:21] (PS3) Awight: Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 [04:27:22] awight: ah yes, thanks, one of those things that has been floating midway down my to-do list for a while.. [04:27:32] AndyRussG: some basic QUnit stuff is available now... Do you agree that I should turn to PHP tests? [04:27:41] Yeah that'd be fantastic :) [04:27:48] I have been sleuthing the lang dilemma [04:28:00] lang? content vs interface language? [04:28:07] tl:dr; it's not $wgContLang, but rather $context->getLanguage() [04:28:11] oooh [04:28:22] i.e. interface language, as set by user pref or uselang [04:28:46] well, IMO the goal is to leave all behavior unchanged [04:28:51] exactly [04:29:01] so, wgContLang [04:29:07] no [04:29:11] I did check on RequestContext::getLanguage [04:29:21] pretty sure it's returning content language [04:29:27] nope [04:29:30] oh? [04:29:35] * awight watches pretty waterfall [04:30:02] * AndyRussG tries to hide crazed expression on face [04:30:20] Here is my draft Gerrit comment w/ all the sleuthing: [04:30:24] I thought I'd tracked this down fully but apparently not! I think I've got it now, tho. tl;dr: it's not $wgContLang, but rather $context->getLanguage(). Here are the sordid details: [04:30:25] The response to the initial request fires up and a script tag with a link for the first ResourceLoader script is inserted into the document head. [04:30:25] The link contains a lang parameter that is obtained via RequestContext::getLanguage() (see https://git.wikimedia.org/blob/mediawiki%2Fcore.git/37a6d0e60d7d86f5f078d352f0a2d01e12fedbec/includes%2FOutputPage.php#L2756). [04:30:25] RequestContext::getLanguage() will use first the uselang param from the original request, or the language in the user's preferences. Only the default/value for anons is $wgContLang (see https://git.wikimedia.org/blob/mediawiki%2Fcore.git/37a6d0e60d7d86f5f078d352f0a2d01e12fedbec/includes%2Fcontext%2FRequestContext.php#L322). [04:30:25] ResourceLoader makes this value available to JS modules via mw.config.get( 'wgUserLanguage' ). [04:30:26] bannerController.js uses this value for the uselang parameter in the call to Special:BannerRandom (see https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice.git/2d659220a1e29a457e24099c16ee8329fe07b627/modules%2Fext.centralNotice.bannerController%2FbannerController.js#L131). [04:30:28] SpecialBannerLoader creates an allocation context again using RequestContext::getLanguage(), which in this case has been forced via the uselang parameter (see https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice.git/2d659220a1e29a457e24099c16ee8329fe07b627/special%2FSpecialBannerLoader.php#L37). [04:30:30] SpecialBannerRandom uses that value in the call to BannerChooser. [04:30:33] You can see that this happens by setting your user preferences or adding a uselang param to your request; that will control which banner you get. [04:30:35] The code here hooks into the same pipeline via ResourceLoaderContext::getLanguage(). So we'll be getting the same values that we're getting now. :) [04:30:58] O_o [04:31:00] ...mmm now please show me to the loony bin [04:31:30] * AndyRussG tends to self-shot foot [04:31:42] craaap [04:31:53] so we've been serving wrongness all along [04:31:56] not surprising [04:32:39] yep. uselang [04:32:44] Mariana has been using this funny expression since shortly after our arrival here [04:33:40] (PS4) Awight: Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 [04:33:45] Since the cat we brought from Mex was killed, a week after we arrived. According to the person from the city who came to pick up the departed, it was probably racoons (though in fact it may have been a car). [04:33:55] awww [04:34:02] So whenever something bad happens, she says, "Oh no! Raccoons!" [04:34:07] it probably smelled delicious [04:34:09] lol [04:34:16] yeah they are bad news rodents [04:34:28] so maybe this is an "Oh no! Raccoons!" moment... [04:35:12] jk [04:35:22] well, thanks for unraveling one of the many labyrinths we've prepared for CN meddlers :p [04:35:27] I mean, really it's not that bad... [04:35:39] it's reasonable, for sure [04:35:46] it's just... not correct ;) [04:36:03] * AndyRussG looks for his prize... some JS coding time! [04:36:18] and np [04:36:52] that "feature" is definitely worth documenting at mediawiki/Extension:Cn once the smoke from this week clears [04:36:54] yeah, really only unusual corner cases are affected.. [04:37:10] I don't know... that might be a really common thing for power users [04:37:29] or pretty much anyone who logs in and speaks >1 language [04:37:55] Hmmm [04:38:06] User preferences aren't global yet, are they? [04:38:16] We could find out how many users have that pref set [04:38:18] donno [04:39:10] It's just dawning on me that this explains WMIL's habit of matching on *all* languages, cos they must have noticed that uselang was causing banners to be filtered on ilwiki [04:39:14] oooh [04:39:32] That's been under my fingernails for a whiles [04:39:44] WMIL? [04:39:58] WM Illinois? [04:39:59] Israel [04:40:00] hehe [04:40:02] Ah right [04:40:36] True there could be regions that are more affected than others [04:42:44] What did you mean by "trigger the ternary" in ur comment here, L 62 https://gerrit.wikimedia.org/r/#/c/172299/3/includes/CNBannerChoicesResourceLoaderModule.php [04:44:06] Also, do you know how to configure my local setup for the interwiki DB calls? [04:44:31] AndyRussG: that the response from json_encode will be { "status": "fatal" }..., true-ish [04:44:48] AndyRussG: hrm interwiki, that is trickier. no [04:45:14] Ah K I see [04:45:29] Hmm [04:45:34] not sure if this is related, http://www.mediawiki.org/wiki/Manual:Shared_database [04:46:43] http://www.mediawiki.org/wiki/Manual:Wiki_family#Wikimedia_Method [04:46:44] maybe like first cousin [04:47:58] that looks more part of the nuclear [04:51:26] (CR) Awight: "Please see https://gerrit.wikimedia.org/r/#/c/172666/ for the CI config change to enable these tests." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 (owner: Awight) [04:52:53] (Abandoned) Awight: WIP: objects to manage allocations data [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/59366 (owner: Awight) [04:59:15] awight: hey, I'm gonna head to sleep... I could keep on going but I think it's wiser to have my brain in working order during the day tomorrow, and if necessary, lose some zzz's tomorrow instead [05:00:00] (PS1) Awight: rename BannerChooser test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172667 [05:00:08] AndyRussG: good choice! [05:00:14] :) [05:00:23] Sorry I didn't get the new JS version for this evening as promised :( but hopefully I can get it done early tomorrow [05:00:25] I'll be on autopilot porting unit tests, then similar fate [05:00:28] wat. [05:00:49] there's all the way until Thursday eve, no rush :p [05:00:53] Mmm I think I'd predicted I'd have some more of the JS functionality for like, now... [05:01:00] Ah heh yeah [05:01:01] bye! [05:01:11] bye! Thanks much :) [08:05:49] (CR) Awight: [C: -1] "I threw a small tantrum about: where are all the keys?" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [08:16:29] (CR) Awight: "SORRY, my last comments were based on complete fiction, I was looking at my own test data, which had been stripped of keys by the PHPUnit " (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [09:04:17] (PS1) Awight: Unit tests for BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172673 [09:04:30] (CR) jenkins-bot: [V: -1] Unit tests for BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172673 (owner: Awight) [09:05:24] (PS1) Awight: More table alias fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172674 [09:05:31] (CR) Awight: "Depends on https://gerrit.wikimedia.org/r/172674" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172673 (owner: Awight) [09:06:41] (PS2) Awight: More table alias fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172674 [16:50:15] (Restored) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/46700 (owner: Hashar) [16:50:19] (PS3) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/46700 [16:55:24] (PS5) Awight: Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 [16:55:55] (CR) jenkins-bot: [V: -1] Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 (owner: Awight) [16:56:23] Jeff_Green: donno what all is in the air today, but the contribution_tracking trigger is probably the highest priority from my perspective. [16:56:47] No rush cos I have lots of other things to do, but it would be great to give that a stab some time today. [16:57:31] ok looking [16:57:37] what's the card again? [16:58:10] Jeff_Green: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2138 [16:58:13] thx! [17:10:42] hi, guys! does anybody know why donations from Russia were stopped? [17:10:57] we get the following message when opening the donation page - http://habrastorage.org/files/31b/b1f/ec9/31bb1fec9b9e45abb6ac4babcc237184.png [17:12:07] rubin16: no idea, I wonder who you should ask... [17:12:42] meganhernandez: ^^ have you heard anything about this? [17:14:53] I can confirm the behavior, https://donate.wikimedia.org/w/index.php?title=Special:FundraiserLandingPage&country=RU [17:14:57] yes, we are not running in Russia right now [17:15:08] meganhernandez: but why? [17:15:53] meganhernandez: It seems to be worse than that--Russia is being blacklisted. [17:16:16] afaict, these should be the only blacklisted countried: 'DE', 'CH', 'BY', 'CD', 'CI', 'CU', 'IQ', 'IR', 'KP', 'LB', 'LY', 'MM', 'SD', 'SO', 'SY', 'YE', 'ZW' [17:16:44] de - Germany, too? [17:17:39] rubin16: err, CH and DE are countries where the chapter does their own fundraising [17:18:05] ok, that's clear for them. But why is Russia blacklisted? [17:18:46] we at Wikimedia RU already received some negative publicity in the Net because of this as users consider this as some political action of WMF regarding Russia [17:18:49] it's not... which makes this a disturbing bug report [17:21:03] meganhernandez: so, is it a bug or a specific decision? [17:24:48] hi rubin16, we are not currently fundraising in russia. if you could point me to the the comments you’ve seen online, that would be great. thanks! [17:25:19] rubin16: err, furthermore, "we are unable to accept donations from your country" turns out to be correct, at this time [17:25:50] meganhernandez: they are in Russian, but you can see here - http://habrahabr.ru/post/242987/ [17:26:20] habrahabr is one of the top sites in Runet with more than 1mln daily audience [17:27:38] meganhernandez: so, is it somehow possible to learn the reason of such decision and some more information? [17:33:27] AndyRussG: ping me when you have testable WIP for JS banner choice! [17:33:37] awight: K will do [17:33:59] AndyRussG: unfortunately, I'm trying to resolve a difference between QUnit runs locally, vs in under CI Jenkins [17:34:03] Just about to upload a new patch with fixes following CR on the ResourceLoader patch [17:34:07] great! [17:34:42] Hummm OK also lemme know if I can help with that, thanks! :) [17:39:22] so sad to be blocked in the same line as Libya, Iran, Congo, etc.. I will post to fundraising-l in such case [17:40:14] (CR) Hashar: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172674 (owner: Awight) [17:40:47] AndyRussG: btw, ^^ that patch will help me with writing unit tests [17:41:03] rubin16: thank you for pursuing this! [17:41:05] K should I look? [17:41:41] AndyRussG: please do! U don't have to merge as-is, but if you could squash into your WIP or something... [17:41:42] rubin16: ^ what awight said, that does sound sad and important to figure out [17:42:05] awight: OK, or maybe depend on... [17:42:13] thanks for comments ;) [17:43:12] AndyRussG: yes, that works too, if subsequent patches depend on the table aliases. whatever's the least disruptive, I hate editing code you're actively working on. [17:44:54] (Abandoned) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/46700 (owner: Hashar) [17:44:55] awight: ah np, thanks for heads-up :) I feel like I'm a bit in slow-mo or not-fast-enough-mo, getting moar coffee now 8p [17:46:16] (CR) Hashar: "Seems the qunit jobs do not pass. Could the extension require an other extension as a dependency?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 (owner: Awight) [17:59:53] (PS5) AndyRussG: WIP Send banner choice data via to the client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 [18:10:17] (CR) AndyRussG: WIP Send banner choice data via to the client (9 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 (owner: AndyRussG) [18:16:12] (CR) Awight: WIP Send banner choice data via to the client (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 (owner: AndyRussG) [18:19:57] (CR) Awight: [C: 1] "LGTM!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 (owner: AndyRussG) [18:23:30] Scrum of scrums is coming up. awight, AndyRussG, pizzzacat: anything you want me to mention? Going to summarize the CN stuff in progress. Can other teams help with anything, like browser test advice? [18:25:07] ejegg thanks for checking. I can't think of anything at the moment. [18:25:10] ejegg: we're getting some good support from cmcmahon and marxarelli already [18:25:22] ejegg: btw, we also have QUnit tests now :) [18:25:24] ok, great! [18:25:28] but there are problem with everything [18:25:32] problemz [18:26:38] yeah, i'd love to try running those locally. just as soon as I get the throttle / percentage calculations straight for allocation! [18:28:02] oof [18:28:08] oooof [18:28:50] BTW for anyone that needs it, I found how to run the qunit tests headless, go to your integration-jenkins repo, and run: ./bin/wmfgrunt qunit --verbose '--qunit-url=http://YOURWIKI/index.php/Special:JavaScriptTest/qunit' [18:30:23] ooh, valuable snippet [18:30:46] (CR) Awight: "for the record, I'm successfully running QUnit headless now, using the CI scripts:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 (owner: Awight) [18:33:42] awight are we ok with locking up the drupal db for a bit to do this trigger-related table update? [18:34:26] Jeff_Green: yeah, but I think we need to put payments into maintenance mode [18:34:38] are we running any tests atm? [18:35:37] we should also dump the db first in case of surprises [18:35:46] Jeff_Green: No "tests" on the calendar, but we definitely have baners up [18:36:06] oic [18:36:08] meganhernandez: any sensitive tests running? We're talking about putting payments into maintenance mode for an hour or so [18:36:52] we have banners up now [18:37:08] tests are running but we could pause them if we need to [18:37:22] meganhernandez: is there any time today that is better? [18:37:46] (PS6) Dduvall: Skeletal browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172472 (owner: Awight) [18:39:41] (CR) Awight: [C: 1] "marxarelli: changes look good, thanks much!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172472 (owner: Awight) [18:40:58] not really, awight im on calls the next couple hours. can’t test or monitor right now, but go ahead & disable if i’m not needed [18:41:43] meganhernandez: k thanks, and sorry for the inconvenience. On the bright side, the change we're trying to make will speed up ewulczyn's scripts by some huge factor. [18:42:15] Jeff_Green: ping me when you're ready to do this, and I'll disable the campaigns... [18:42:32] ok. gimme a few minutes [18:42:36] doing a few things at once [18:42:57] yup [18:45:20] atgo: we having the 11:00 meeting? [18:45:30] atgo: and, are you here? [18:45:35] yes i'm in a meeting [18:45:48] whew. the bullpen is very quiet today [18:49:07] (CR) Dduvall: [C: 2] Skeletal browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172472 (owner: Awight) [18:51:06] * awight highlights awesome support from the QA team ^^ [18:55:03] AndyRussG: fyi, marxarelli and chrismcmahon just hooked us up with live browser tests: https://integration.wikimedia.org/ci/job/browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/ [18:55:22] The lights should go green whenever the ?random= override is implemented and merged to CN master [18:55:24] awight: nice! [18:56:08] right now I'm debooging [18:56:25] also check-in in like 2 minutes.. [18:56:36] AndyRussG: k, just holler if I can help with anything. Otherwise, I'll be tweaking the PHPUnit and QUnit tests [18:56:39] awight: I'm eyeball deep in a pxeboot system bug hunt, can we schedule the db stuff for tomorrow? [18:56:54] nice! thx :) [18:56:55] Jeff_Green: I'm out tomorrow, for parenting... [18:57:11] ok. i guess friday then [18:57:17] err, let's not [18:57:25] monday! [18:57:45] Jeff_Green: ok, we'll see! [19:50:59] AndyRussG: I'm running into patch serialization issues... do you want to merge any of the WIPs? Or maybe we can switch to a feature branch? [19:51:27] Finding I have to git log -p -1 | patch a bunch of dependencies to be able to write tests [19:52:12] anyway, this is my problem. I guess a feature branch will make it difficult to rework WIPs up the chain. [19:52:15] nvm [19:52:43] awight: I can send some final wee changes (at least the commit messages) and we can merge stuff I think [19:52:57] that would be great [19:52:57] how does that sound? [19:53:01] :) [19:53:41] We can rewrite history after the revolution [19:54:38] That assumes we win :-/ [20:17:56] AndyRussG: Can we get the campaign keys back in the choice data provider? It would be really useful in making the campaign links for the allocation page. If we're concerned with overhead, maybe add a parameter to getChoices? [20:18:24] ejegg: Hi! [20:18:36] Hi AndyRussG [20:19:36] Hmm OK, wasn't concerned about overhead really [20:20:08] You're talking about the outermost level of the data structure? [20:20:37] yep! [20:20:52] As in, 'campaignname' => array ( 'campaignProp1' => val1, 'campaignProp2' => val2, etc. ) ? [20:21:12] It would add a bit of unnecessary bandwidth to send to the client, so maybe add a param [20:21:18] to skip the array_values call? [20:21:32] Yeah, exactly [20:21:59] Well not much bandwidth 'cause we could then remove the name property from the inner array [20:22:15] actually it'd save bandwidth on the "name" property label [20:22:24] * AndyRussG curses gzip [20:22:39] Maybe campaign names should be sha1's [20:22:39] Oh, it would be nice to have both for the internal call on the allocations page [20:22:48] the id for the link, and the name for display [20:23:45] ejegg: just the campaign name as the key wouldn't be good enuf? can't you pass that in somewhere? [20:23:57] and by 'nice' i mean i'm not sure how to make the link at all without the id. given the id alone i could look up the name. [20:24:09] also BTW if you have a WIP feel free to send it u, even if it's all full of unfinishedness [20:24:12] up [20:25:38] very little actual code done sadly. spent a long time playing with campaigns to determine interaction btwn priority / throttle / bucket / percentage [20:26:03] Ah mwwahaha that is the best part of CN [20:27:04] So you want database ids as the keys or names? [20:28:30] What is the route you're looking at for creating the links? [20:28:31] oh shoot, sorry to waste your time. Guess the names are all I need. No need to change a thing! [20:29:01] ah no, I mean np it's totally not a waste and certain this'll need tweaking [20:29:39] awight|fud suggested that we merge those early patches (proveder + api) which would make it easier to build on those changes, git/gerrit-wise [20:29:51] I was just not reading things correctly - the links do use the name after all. [20:29:57] we can always go back and tweak them some more [20:29:59] Ah OK [20:30:40] Yeah, I'm down with merging those, especially since they don't change the way things act yet. [20:30:48] cool! :) [20:31:17] If u have any questions or want to discuss how to organize that part of the code, pls let me know anytime... it'd be nice to have similar enough logic/function/method names in JS and PHP so we could see the similarity in algorithms [20:31:32] (PS10) AndyRussG: Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 [20:31:42] it looks very good from what I've seen so far [20:33:10] :) very glad to hear such positive feedback on this, thanks [20:33:28] gnarliness can be beautiful too ;p [20:34:22] PPena: what happened to you? [20:37:08] (CR) AndyRussG: Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [20:39:32] (PS4) AndyRussG: Add the centralnoticebannerchoicedata API module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172656 [20:47:07] (CR) Awight: [C: 2] Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [20:47:14] (CR) Hashar: "I reproduced it locally when I noticed the URL in the Jenkins console log have 'skin=fallback'." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 (owner: Awight) [20:47:49] heheheh la lucha sigue [20:48:28] (Merged) jenkins-bot: Add BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/170843 (owner: AndyRussG) [20:49:24] (CR) Awight: [C: 2] Add the centralnoticebannerchoicedata API module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172656 (owner: AndyRussG) [20:49:57] (Merged) jenkins-bot: Add the centralnoticebannerchoicedata API module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172656 (owner: AndyRussG) [20:50:01] atgo: awight: ejegg: instead of standup today, maybe we should do double standup tomorrow? [20:50:07] yes [20:50:13] we should skiip them on shrimp prawning days [20:50:30] ah K :) [20:51:27] (CR) Awight: "Awesome sleuthing. Let me look into fixing the "fallback" skin." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 (owner: Awight) [20:52:23] hey awight [20:52:30] when do you want to do the TY thing? [20:53:55] (PS6) AndyRussG: WIP bannerChoiceData and bannerController.lib modules [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 [20:54:51] ccogdill: is now a good time? [20:55:00] don’t see why not [20:55:09] (CR) AndyRussG: WIP bannerChoiceData and bannerController.lib modules (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 (owner: AndyRussG) [20:55:55] (CR) AndyRussG: [C: -1] "Still WIP... Just rebased and updated commit messsage. :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172299 (owner: AndyRussG) [20:56:12] ccogdill: ok, one moment please [21:03:53] ccogdill: believe it or not, the emails already went out normally [21:03:56] sorry for the false alarm! [21:04:08] haha [21:04:15] they did last week? [21:04:19] yep [21:04:22] well that”s good! [21:04:25] thanks [21:04:36] I can't quite explain, but yes I'm happy too! [21:04:45] ... huh? :P [21:05:06] <_< [21:05:07] >_> [21:05:52] (PS3) Awight: More table alias fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172674 [21:06:03] AndyRussG: mind kicking that for me? ^^ [21:06:48] awight: K one sec [21:07:31] (PS1) Awight: ApiCentralNoticeBannerChoiceData tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172881 [21:07:34] (CR) jenkins-bot: [V: -1] ApiCentralNoticeBannerChoiceData tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172881 (owner: Awight) [21:07:53] (PS2) Awight: Unit tests for BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172673 [21:08:25] (CR) jenkins-bot: [V: -1] Unit tests for BannerChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172673 (owner: Awight) [21:10:06] (PS1) Awight: WIP BannerChoiceData RL module test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172882 [21:10:08] (CR) jenkins-bot: [V: -1] WIP BannerChoiceData RL module test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172882 (owner: Awight) [21:11:22] (CR) AndyRussG: [C: 2] "happy happy" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172674 (owner: Awight) [21:11:41] * AndyRussG patiently waits forh the loony bin to send limousine [21:11:57] (Merged) jenkins-bot: More table alias fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172674 (owner: Awight) [21:16:00]