[00:02:03] (PS2) Ejegg: rename BannerChooser test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172667 (owner: Awight) [00:02:24] (CR) Ejegg: [C: 2] "Rebased" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172667 (owner: Awight) [00:02:58] (Merged) jenkins-bot: rename BannerChooser test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172667 (owner: Awight) [00:04:15] AndyRussG: got a cheat sheet on running the 'feature' / rubocop tests? [00:04:41] ejegg: ummm maybe one sec :) [00:05:37] ejegg: maybe this http://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Very_Basic_Howto [00:05:44] and this? https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing [00:06:39] innnteresting. thanks! [00:06:45] np :) [00:38:29] (PS5) Ejegg: ApiCentralNoticeBannerChoiceData tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172881 (owner: Awight) [00:43:18] (PS4) AndyRussG: WIP Choose banner on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 [00:43:44] blrrgg ^ at least one function there that now (appears to) work... [00:43:56] rockin [00:44:30] heh small victories... [00:45:08] if u have a sec to take a peek before you call it a day, to see if you have any objections, that'd be totally fab [00:45:19] looking now! [00:46:14] thx! [00:51:03] should setChoiceData just filter the stuff on the way in? [00:51:27] ejegg: I dunno... I haven't done the actual execution logic yet [00:51:44] oh, probably not [00:51:47] My instinct sez no, let's keep things pretty atomic and have a controller-sh function separate [00:51:58] since we need to do the geoip lookup and stuff to get info for filtering [00:52:07] and setChoiceData happens immediately now [00:52:08] Right also [00:52:11] cool [00:52:52] To test it I've just been saying mw.cnBannerControllerLib.choiceData, then mw.cnBannerControllerLib.filterChoiceData(), then mw.cnBannerControllerLib.choiceData again on the browser console [00:53:26] (Abandoned) Awight: (bug 73389) mark new banner controller dependencies as mobile-ready [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173107 (owner: Awight) [00:54:07] (PS8) Awight: WIP BannerChoicesResourceLoaderModule test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172882 [00:54:37] AndyRussG: using != instead of !== for bucket comparison because one might be a string? [00:54:40] (CR) jenkins-bot: [V: -1] WIP BannerChoicesResourceLoaderModule test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172882 (owner: Awight) [00:56:29] ejegg: hmmm [00:56:44] AndyRussG: generally looking really good [00:57:27] (PS9) Awight: Test CNBannerChoicesResourceLoaderModule [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172882 [00:57:29] thanks! a small step, I feel like I keep bumping into walls today [00:57:39] like Mr. Bean [00:58:03] yeah! good catch with regard to the !=, I hadn't thought about that issue actually [00:58:19] (PS17) Ejegg: Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 (owner: Awight) [00:58:45] I should make sure about both inputs [00:58:57] * ejegg thinks he hears yackity sax... [00:59:51] Humm gonna have to look into that! [01:00:37] oops, that's benny hill, not mr bean [01:00:57] Ahhh interesting still [01:01:00] * AndyRussG shows his age [01:10:42] (CR) Awight: [C: 1] "Cool!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/173425 (owner: Ejegg) [01:12:46] Hmmm might as well make a flat banner array and copy in the campaign data in filterChoiceData, like u did... [01:12:49] (Abandoned) Awight: minor fixups to WIP [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172957 (owner: Awight) [01:27:41] (CR) Ejegg: [C: 2] "Looking good! Rebased and trivially updated for json fixtures." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172881 (owner: Awight) [01:29:48] AndyRussG: those don't necessarily need to be the same fn. I'd be curious what the algorithm looks like with the non-flattened data structure [01:31:17] ejegg: hmmmm [01:31:36] You're OK w/ improving it a bit to make it more readable? [01:32:10] ehh, probably best to do a direct port for starters, with a flatten function [01:32:54] Yeah that's what awight suggested... [01:34:17] There are lots of other improvements possible I think [01:35:07] grrrr, mouse buttons suddenly not doing anything, even after rmmod psmouse && modprobe psmouse [01:35:56] maybe this weekend is the time to migrate off the bleeding ubuntu edge to plain old debian [01:37:13] hmmmm or bleeding edge debian :) [01:37:36] even unstable would probably give me fewer problems [01:38:50] well, guess I'm gonna call it a night. I'll probably do some more CR over the next couple of days. [01:38:58] have a good night! [12:23:07] (CR) Amire80: [C: -1] "The selector should be more specific and include only s in the donation form." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/173435 (owner: Ejegg) [18:09:10] (PS18) Awight: Basic QUnit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/172665 [18:09:22] (Abandoned) Awight: DO NOT MERGE octopus branches together for development [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173243 (owner: Awight) [18:33:02] (PS6) Awight: WIP QUnit tests for client banner allocations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173249 [18:33:05] (PS1) Awight: WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 [18:34:18] (CR) jenkins-bot: [V: -1] WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 (owner: Awight) [18:34:29] (PS2) Awight: WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 [18:34:31] (PS7) Awight: WIP QUnit tests for client banner allocations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173249 [18:35:39] (CR) jenkins-bot: [V: -1] WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 (owner: Awight) [23:28:39] (PS2) Ssmith: Make navbar px-perfect [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/173224 [23:28:41] (PS3) Ssmith: Fix range values [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/173064 [23:28:43] (PS2) Ssmith: Reset form when modal is reopened [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/172938 [23:28:45] (PS5) Ssmith: Extend ChartJS and make selection chart dynamic [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/173190 [23:28:47] (PS1) Ssmith: Show actual SQL instead of query string in db modal [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/173632 [23:57:27] (PS2) Ssmith: Show actual SQL instead of query string in db modal [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/173632