[16:04:11] (PS5) AndyRussG: WIP Choose banner on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 [16:04:48] (CR) jenkins-bot: [V: -1] WIP Choose banner on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 (owner: AndyRussG) [16:32:26] (PS1) Awight: Confirmed no more usage of toggleBanner [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173661 [16:33:36] (CR) jenkins-bot: [V: -1] Confirmed no more usage of toggleBanner [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173661 (owner: Awight) [17:09:24] (PS3) Awight: WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 [17:10:35] (CR) jenkins-bot: [V: -1] WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 (owner: Awight) [17:33:12] (PS1) Awight: Implement banner= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173662 [17:33:14] (PS1) Awight: Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 [17:33:45] (CR) jenkins-bot: [V: -1] Implement banner= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173662 (owner: Awight) [17:33:52] (CR) jenkins-bot: [V: -1] Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (owner: Awight) [17:36:57] (PS4) Awight: WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 [17:36:59] (PS8) Awight: WIP QUnit tests for client banner allocations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173249 [17:38:09] (CR) jenkins-bot: [V: -1] WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 (owner: Awight) [17:38:11] (CR) jenkins-bot: [V: -1] WIP QUnit tests for client banner allocations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173249 (owner: Awight) [19:02:28] (PS6) AndyRussG: WIP Choose banner on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 [19:03:01] (CR) jenkins-bot: [V: -1] WIP Choose banner on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 (owner: AndyRussG) [19:35:18] (CR) Awight: [C: 1] "Looks perfect, minus the typo picked up by jslint at like 147." (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 (owner: AndyRussG) [20:12:05] (PS7) AndyRussG: WIP Choose banner on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 [21:30:24] (PS8) AndyRussG: WIP Choose banner on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 [21:39:02] (CR) AndyRussG: "The allocations method appears to work. I guess we'll see how it plays out when all combinations of criteria are thoroughly tested..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173220 (owner: AndyRussG) [21:43:49] awight: boo! looks like this is working (from calling methods on the browser console) ^ p.s. pls ignore this ping if you're having a weekend or something :) [21:44:09] Gonna wire it up now! :) [21:48:16] AndyRussG: hey! [21:49:12] I'm having a stormy weekend, back n forth between work and family time :) [21:49:20] I try not to do that, normally... [21:50:05] AndyRussG: There's a good chance those qunit tests will actually succeed. Like I said, I still need to figure out a good test of chooseBanner(). [21:50:30] Holler if you think any of the tests I've written so far should be more granular, or less invasive of protected properties, etc. [21:51:28] AndyRussG: would it be useful to prepare a merged version of all the QUnit patches, so you can apply to your development branch? [21:53:27] If you get into the mood for CR, this should be ready, also: https://gerrit.wikimedia.org/r/#/c/172882/ [21:54:02] I guess the way I feel about the QUnit patches, is that they should be merged as they pass. [21:54:08] awight: K... many thanks... re: QUnit patches, I see three now, is that correct? https://gerrit.wikimedia.org/r/173249 https://gerrit.wikimedia.org/r/172665 https://gerrit.wikimedia.org/r/173533 [21:54:49] ignore https://gerrit.wikimedia.org/r/173533 for now... [21:54:55] ah OK [21:55:11] But this one probably is useful already: https://gerrit.wikimedia.org/r/173663 [21:55:13] that makes sense... maybe rebase 'em on the feature (WIP choose banner on client), or do so when it's functional, whatever is easiest [21:56:05] unfortunately, Gerrit can't rebase octopus merges... hrm. I'm not even sure the merge is helpful for you [21:56:11] Yeah I saw the RL module test is ready coming along! [21:56:30] What I was imagining, was that I could prepare a patch that you can apply and not commit, which has all the future qunit tests [21:56:40] this would all be simpler if they were just merged to master, however :) [21:57:20] AndyRussG: maybe we should just merge all this stuff, but into a new branch, then cherry-pick back to master as things are ready? I really donno. [21:59:23] Hmmm not sure either really [21:59:31] * awight looks for other devs with time for CR... hehe nope [22:00:00] I suppose there _might_ be a few other crazies out there [22:00:58] OK, I think the sanest thing to do... is if I make all the QUnit patches into a linear branch, then you can rebase your js patch on top of that for dev testing, then back to trunk for commit? [22:02:36] (PS9) Awight: WIP QUnit tests for client banner allocations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173249 [22:02:41] Sure! that sounds great [22:02:50] AndyRussG: okay, there's the commit to use ^^ [22:02:58] K :) [22:03:46] (CR) jenkins-bot: [V: -1] WIP QUnit tests for client banner allocations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173249 (owner: Awight) [22:04:26] Have you noticed that WMF Jenkins speaks random languages? So far, I've gotten en, es, and zh [22:04:32] I don't think it's my browser... [22:04:45] I'm not impressed. well, sort of. :p [22:05:00] I did get es for those browser tests! I thought, maybe my browser, but that shouldn't be the case... [22:05:08] Since my browser is configured for en [22:05:33] hehe. double-freed esperanto [22:05:48] high-impedance floating input. [22:06:11] must be a bug in Jenkins' language allocation code [22:06:26] or maybe an artifact of language allocation quantizing [22:07:41] :) [22:10:07] aww, those rebased tests are a mess, now [22:10:17] I'll be online in a few hours :-/ [22:13:20] K thanks! [23:41:58] (PS2) AndyRussG: Reuse $wgCentralDBname for the Choice infrastructure [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173218 (owner: Awight) [23:44:24] (CR) AndyRussG: [C: 2] "Rebased... LGTM!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173218 (owner: Awight) [23:48:50] (Merged) jenkins-bot: Reuse $wgCentralDBname for the Choice infrastructure [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173218 (owner: Awight)