[00:10:00] <grrrit-wm>	 (PS4) Ejegg: WIP: add is_YYYY_donor and latest don data to wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/175794
[00:18:06] <K4-713>	 bahaha, just got back "Greetings Katie, Do not be alarmed."
[00:18:12] <K4-713>	 Every email to me should start like that.
[00:18:25] <ejegg>	 so soothing
[00:18:32] <K4-713>	 Right?
[00:18:38] <ejegg>	 and like an extraterrestrial
[00:18:57] <K4-713>	 I was a little surprised there wasn't a "We come in peace!" somewhere in there.
[00:19:17] <K4-713>	 I mean, it worked. I'm too amused to be alarmed. :)
[00:20:34] <ejegg>	 K4-713: any idea why my initial db population in wmf_civicrm.install is doing zilch (not even throwing an exception), while printing out the sql and executing it via mysql cmd line populates wmf_donor just fine?
[00:20:39] <ejegg>	 https://gerrit.wikimedia.org/r/175794
[00:20:54] <K4-713>	 ejegg: Hurmfpppf.
[00:21:10] <ejegg>	 I mean, I could just run those scripts independently
[00:21:16] <K4-713>	 Are you, by any chance, installing several times on your local?
[00:21:34] <K4-713>	 If you disable the module, you have to uninstall it all the way before it will fire again.
[00:21:36] <ejegg>	 yeah, but I reset the schema_version
[00:21:39] <ejegg>	 drop the tables
[00:21:46] <ejegg>	 and delete from civicrm_custom_*
[00:21:52] <K4-713>	 I think some other table helpfully remembers for you.
[00:21:55] <ejegg>	 it's recreating the tables fine
[00:22:36] <ejegg>	 but i'm doing some fancy selects into a temp table, then into wmf_donor to get the initial state of the table right
[00:22:55] <ejegg>	 Heck, I can even see drush running the queries in the mysql query log
[00:23:15] <ejegg>	 but it's like they all get rolled back or something
[00:23:26] <ejegg>	 ...not that I see a rollback
[00:23:32] <ejegg>	 but wmf_donor ends up empty
[00:24:44] <meganhernandez>	 hey there K4-713  i think you put this irc but i missed it.  i’m good to put AU up in the banners?
[00:26:07] <K4-713>	 meganhernandez: Yes! With bpay enabled and everything.
[00:26:41] <K4-713>	 The nightly is still in a state where I have to poke it along every day, but that's a once a day thing and totally on our end.
[00:33:00] <ejegg>	 bah, data truncation due to garbage in original_currency
[00:33:10] <ejegg>	 plus stricter connection settings via drush
[00:33:40] <K4-713>	 I don't like that "garbage in original_currency" thing you just said.
[00:33:48] <ejegg>	 There's a card for it
[00:33:54] <K4-713>	 ejegg: Can you tell how old the garbage is?
[00:34:10] <ejegg>	 this is on my local, but there's definitely some in prod too
[00:34:18] <K4-713>	 Ah. What made it?
[00:34:19] <ejegg>	 and not too old in prod either
[00:34:27] <ejegg>	 I'm not sure, maybe imports?
[00:34:29] <K4-713>	 fooey.
[00:34:45] <ejegg>	 figuring that our is the first part of the card
[00:34:48] <ejegg>	 *out
[00:34:52] <K4-713>	 I think we knew that manual entry was making some oddness, too.
[00:35:03] <ejegg>	 Ooh, probably that too!
[00:35:19] <K4-713>	 This is one of our most favorite panic buttons, actually.
[00:35:26] <ejegg>	 Especially since original_* are parsed out of the 'source'
[00:35:52] <K4-713>	 "OMG, SOME PROCESS IS ENTERING BAD DAToh, it's one of the people that actually logged in. nvm"
[00:36:06] <ejegg>	 heh
[00:36:11] <K4-713>	 That happens at least once every six months.
[00:36:24] <ejegg>	 I mean, we could do some validation
[00:36:36] <K4-713>	 Particularly if we're worried about extra fields that real people can't edit...
[00:37:14] <K4-713>	 Yeah, we could always do extra validation, but I want to do it in such a way that we're not hacking civi core for our own mysterious purposes.
[00:37:34] <K4-713>	 Those do not to well through upgrades.
[00:37:37] <K4-713>	 *do
[00:37:54] <ejegg>	 true.  Something in a civicrm_pre hook, perhaps?
[00:38:04] <meganhernandez>	 AU is up
[00:38:09] <meganhernandez>	 will send to mailing list
[00:38:12] <ejegg>	 I forget if those can cancel the insert tho
[00:38:31] <K4-713>	 meganhernandez: Yay!
[00:38:40] <K4-713>	 meganhernandez: How long?
[00:38:48] <meganhernandez>	 just went up a couple mins ago
[00:38:51] <meganhernandez>	 but it’s low level
[00:38:57] <meganhernandez>	 want me to turn up to 100%
[00:39:01] <meganhernandez>	 blast off?
[00:39:33] <K4-713>	 meganhernandez: I mean, the logs look good.
[00:39:53] <K4-713>	 0:)
[00:40:30] <K4-713>	 ejegg: Yeah, I think that question is why this discussion usually trails off into oblivion as soon as somebody says "Deadline over here!" or somesuch.
[00:40:42] <K4-713>	 "Nice to Have" and all that.
[00:40:46] <ejegg>	 heh
[00:41:10] <K4-713>	 meganhernandez: I've been seeing kind of a lot of traffic all day.
[00:41:20] <meganhernandez>	 that’s email
[00:41:33] <meganhernandez>	 well the early morning was 100% full screen banner test (6am)
[00:41:38] <meganhernandez>	 and then 300,000 emails
[00:41:40] <meganhernandez>	 today is a big day
[00:41:43] <K4-713>	 Aha.
[00:41:45] <K4-713>	 Yes it is.
[00:41:59] <K4-713>	 I'm getting a lot of mobile right now, looks like.
[00:42:07] <meganhernandez>	 not as many emails tomorrow.  but then 300,000 blast off again on monday
[00:42:08] <K4-713>	 US and CA.
[00:42:20] <meganhernandez>	 that’s interesting…we’re not running mobile in canada right now
[00:42:37] <K4-713>	 Oh wait: Just kidding. Canada is email.
[00:42:49] <K4-713>	 mobile is... all US.
[00:42:50] <meganhernandez>	 yeah, that’s right
[00:42:59] <meganhernandez>	 yeah mobile is only up in the US today
[00:45:12] <K4-713>	 Yeah, it's cruising along...
[00:45:21] <K4-713>	 CN seems happy, too.
[00:49:46] <AndyRussG>	 K4-713: Just checking w/ that low-level campaign in fact
[00:50:53] <K4-713>	 AndyRussG: Everything looks great from payments.
[00:51:02] <AndyRussG>	 K4-713: fantastic
[00:52:13] <grrrit-wm>	 (PS1) Ssmith: Add amount per second chart views [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175903
[00:54:12] <AndyRussG>	 K4-713: yea I am getting banners served for the campaign "C14_enWW_dsk_lw_FR", running at 40%. But they're all getting hidden with reason:waitimps, even when I delete all cookies. I guess I should assume that's intentional, I don't see anything amiss with CN itself...
[00:54:46] <K4-713>	 That might be one that waits initially, until you hit a threshold.
[00:55:01] <K4-713>	 meganhernandez: Does what I just said make sense?
[00:55:45] <meganhernandez>	 yes, that’s the low level campaign running
[00:55:52] <K4-713>	 AndyRussG: The idea there is that we don't want to kill people who obsessively delete their cookies, or have all of them set to delete on browser close.
[00:56:41] <meganhernandez>	 so the banners are set to hide from each reader for 5 page views, and then show just 1 impression.  30 days later, a reader can get another banner, if they’ve seen 5 pages.
[00:56:49] <meganhernandez>	 so that scenario is running at 40%
[00:57:27] <K4-713>	 I like it when I remember things about stuff. :)
[00:57:49] <K4-713>	 Anyway, that behavior is in fact expected.
[00:59:32] <grrrit-wm>	 (PS5) Ejegg: Add is_YYYY_donor and latest donation to wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/175794
[01:02:52] <meganhernandez>	 stufffff!
[01:03:25] <ejegg>	 K4|brb: might be ready for some review: https://gerrit.wikimedia.org/r/175794
[01:03:34] <meganhernandez>	 hey AndyRussG do you want to do a 100% test with bucket A, B, C & D in the US tomorrow morning?
[01:10:11] <grrrit-wm>	 (PS1) Krinkle: Use gmmktime instead of strtotime [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175907
[01:11:13] <grrrit-wm>	 (CR) Ejegg: [C: -1] "Code looks good, but needs bower_modules submodule update" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175161 (owner: Ssmith)
[01:12:48] <K4-713>	 ejegg: Might be?
[01:15:25] <AndyRussG>	 meganhernandez: K4-713: thanks for the explanations!
[01:16:04] <AndyRussG>	 meganhernandez: sure! I can be around as early as 13:25 UTC
[01:16:56] <ejegg>	 K4-713:is ready for review!
[01:17:11] <K4-713>	 ejegg: Looking. :)
[01:17:38] <ejegg>	 Will put in another patch to point the new report to that table
[01:18:37] <grrrit-wm>	 (PS2) Krinkle: Use date_create instead of strtotime [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175907
[01:18:48] <K4-713>	 ejegg: Hummm.
[01:19:33] <K4-713>	 ejegg: I'm a little worried about having the db update come through the install, actually.
[01:19:45] <ejegg>	 Ah, ok.
[01:20:10] <K4-713>	 I think it's just that we have so very much data.
[01:21:03] <ejegg>	 Hmm.  Well, as long as we run it while thw QC is paused, we should be good
[01:21:05] <K4-713>	 I may be... in skeptical of everything mode.
[01:21:31] <K4-713>	 At the very least, though, this would be one of those things I'd want to test in a secure sandbox before we try it in prod.
[01:21:33] <ejegg>	 We could even run it just for the 1k+ smart group donors
[01:21:53] <ejegg>	 just for LYBUNT
[01:21:57] <K4-713>	 And, if it's part of the module install, that makes the deploy totally fiddly.
[01:22:14] <ejegg>	 OK, I'll break it off into another script
[01:22:49] <K4-713>	 Thanks. Hopefully it's not too painful.
[01:23:17] <ejegg>	 Nope, should be fine.  I'll take the generated version to avoid some copypasting
[01:23:27] <K4-713>	 I'll comment in gerrit just so it's on record.
[01:23:30] <ejegg>	 ty
[01:27:07] <K4-713>	 ejegg: Funny thing is, any other week of the year and I probably wouldn't worry about it.
[01:27:32] <ejegg>	 Y'know, I like the idea of splitting it off too.
[01:28:03] <ejegg>	 If only so we can decide just how much of the table we need to update for now
[01:28:41] <grrrit-wm>	 (CR) Katie Horn: [C: -1] "One inline comment about the install script" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/175794 (owner: Ejegg)
[01:29:10] <K4-713>	 ejegg: Yeah, that too.
[01:29:22] <K4-713>	 If we try it in the sandbox and it takes forever, for instance.
[01:29:53] <grrrit-wm>	 (PS3) Krinkle: Don't use UNIX timestamp for wgNoticeOldCookieApocalypse config [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175907
[01:30:02] <ejegg>	 All MG needs LYBUNT for is for 1k+ donors
[01:30:17] <K4-713>	 ejegg: Yeah, but once they have that...
[01:30:21] <ejegg>	 I'd eventually like to use this rollup for the Silverpop export too
[01:30:22] <K4-713>	 ...everybody'll want one.
[01:30:26] <ejegg>	 heh, yep!
[01:31:04] <grrrit-wm>	 (CR) Krinkle: "Verified that the produced number is the same, and that the setting is not used anywhere in any wikimedia/* git repository (especially not" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175907 (owner: Krinkle)
[01:32:56] <Krinkle>	 AndyRussG: ^ for later :)
[01:33:53] <K4-713>	 Krinkle: Thanks for all the last-minute help.
[01:34:08] <grrrit-wm>	 (PS4) Krinkle: Don't use UNIX timestamp for wgNoticeOldCookieApocalypse config [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175907
[01:35:06] <Krinkle>	 K4-713: Anytime :) Fundraising deserves the attention. I'll try to keep an eye out more often.
[01:35:29] <Krinkle>	 Interesting stuff and interesting set of problems.
[01:35:58] <K4-713>	 Krinkle: It is very much appreciated! We have more problems if you're looking for some...
[01:37:11] <grrrit-wm>	 (PS6) Ejegg: Add is_YYYY_donor and latest donation to wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/175794
[01:37:11] <Krinkle>	 Can't make any promises. But I'm always looking for peacemeal things in random places I don't belong to learn more in general about different things, to spread knowledge, and to do while crunching stuff in the back of my mind.
[01:37:41] <K4-713>	 Good to know! I'll put you on the list. After I make a list somewhere.
[01:38:23] <Krinkle>	 If you're getting stuck somewhere or need something to happen elsewhere, I'll see what I can do.
[01:43:38] <AndyRussG>	 Krinkle: thanks! (I'm only semi-here right now but will be fully here again in 15 min or so)
[01:49:08] <ejegg>	 K4-713: think I'm gonna call it a night
[01:49:17] <K4-713>	 I'm about to go Science anyway.
[01:49:25] <K4-713>	 So, good timing.
[01:49:29] <ejegg>	 enjoy your science!
[01:49:31] <ejegg>	 ??
[01:49:42] <K4-713>	 I just sent an email to Jeff (and the rest of you) about the test sandbox.
[01:49:48] <ejegg>	 oh
[01:49:55] <K4-713>	 Hopefully he doesn't read it and go "what?"
[01:50:11] <K4-713>	 I swear we do this at least three times a year, though.
[01:50:24] <K4-713>	 It shouldn't be a problem.
[01:52:07] <K4-713>	 >_>
[01:52:08] <K4-713>	 <_<
[01:52:08] <ejegg>	 OK, well, enjoy, and have a good night.
[01:52:12] <K4-713>	 Ha, you too.
[13:54:32] <meganhernandez>	 hey AndyRussG all good for banneres to go up in a couple mins?
[13:57:56] <AndyRussG>	 Hi meganhernandez...! No problems reported, so yes I think so :)
[13:58:30] <meganhernandez>	 great, this campaign is set to start in 2 mins
[13:58:32] <meganhernandez>	 https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&method=listNoticeDetail&notice=C14_enUS_dsk_FR
[13:59:43] <AndyRussG>	 meganhernandez: OK, looks good!
[14:16:44] <AndyRussG>	 meganhernandez: I got the full-screen banner, but I don't get the top banner afterwards. I found the problem, also realized it's something I should have forseen: the Javascript code that moves people to the buckets C and D has to be updated. Sorry about that :(
[14:17:40] <AndyRussG>	 Some minor changes to this javascript are needed: https://meta.wikimedia.org/wiki/MediaWiki:FR2014/Resources/Oct2014FullScreen.js
[14:17:50] <meganhernandez>	 ah ok, yeah the banners in c & D have about 15 donations each
[14:19:40] <meganhernandez>	 want me to take the test down & then we can try again after it’s updated?
[14:20:25] <AndyRussG>	 that's you're decision of course... I think it'll be a quick fix...
[14:22:14] <meganhernandez>	 ok im done with the test that’s running in a & b
[14:22:18] <meganhernandez>	 i’ll take it down
[14:22:48] <meganhernandez>	 it’s down. i
[14:23:08] <meganhernandez>	 i’ll make a new test for buckets A &B.  let me know when you’re ready for banners to go back up
[14:24:30] <AndyRussG>	 meganhernandez: OK... This is something to work on with Peter...
[14:24:54] <meganhernandez>	 ah ok, i didn’t get that
[14:25:12] <meganhernandez>	 will you send him an email to let him know what we need?
[14:26:37] <AndyRussG>	 meganhernandez: OK, will do that right away...
[14:56:25] <AndyRussG>	 Hi the-wub :)
[14:57:00] <the-wub>	 hey Andy :)
[14:59:09] <AndyRussG>	 How's it going? I just sent an e-mail about changes to the JS to move people to a new bucket, really sorry I didn't think of that before!
[14:59:29] <the-wub>	 ah yeah, just saw that. will get right on changing it
[14:59:51] <AndyRussG>	 Ah cool! I think it should work, but I haven't tested it--are you able to test easily?
[15:02:02] <the-wub>	 I'll make a new banner to test on. Are we using the client-side banner choice everywhere now?
[15:08:28] <AndyRussG>	 the-wub: yep! it's activated everywhere now :)
[15:09:28] <AndyRussG>	 So the per-campaign buckets lasting the duration of the campaign + 30 days are also enabled everywhere
[15:10:20] <AndyRussG>	 the-wub: You can use the same method as in the e-mail to change the buckets for a campaign anytime, in fact
[15:13:02] <AndyRussG>	 Morning atgo :)
[15:20:25] <the-wub>	 hmm... it breaks when testing a banner (putting banner= in the url) since bucketsByCampaign is null then. but I think we can just skip over changing buckets in that case
[15:24:32] <AndyRussG>	 the-wub: hmmm... yeah didn't think of a test harness for this kind of code. The only thing that comes to mind is maybe pausing in the debugger, setting a value for mw.cnBannerControllerLib.bucketsByCampaign manually, then continuing the debugger
[15:26:33] <AndyRussG>	 you could say mw.cnBannerControllerLib.bucketsByCampaign = { name_of_campaign: { start: '1417010400', end: '1419606000', val: 0 } };
[15:26:59] <AndyRussG>	 I don't know what you get as the name of the campaign when you test like that...
[15:28:00] <AndyRussG>	 the-wub: or if you want to activate it on aa.wikibooks or something... let me know if you'd like me to test it...
[16:20:59] <AndyRussG>	 morning ejegg :) how's it going?
[16:28:28] <ejegg>	 Hi AndyRussG
[16:28:30] <grrrit-wm>	 (PS1) Ejegg: Allow falsy values as custom field db defaults [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/176003
[16:28:52] <ejegg>	 Just messing about with lybunt stuff.  How's things with you?
[16:29:30] <grrrit-wm>	 (PS7) Ejegg: Add is_YYYY_donor and latest donation to wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/175794
[16:32:00] <AndyRussG>	 ejegg: cool... yea not bad... I was wondering if you have a sec to activate a campaign on aa.wikibooks with this banner: https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/Edit/B14_newBucketTest ? my centralnotice-admin rights are still in the post, I think
[16:32:09] <AndyRussG>	 thanks in advance :)
[16:32:29] <ejegg>	 AndyRussG: sure, one sec
[16:32:43] <AndyRussG>	 thanks!
[16:35:03] <ejegg>	 geotargeting matter?
[16:35:21] <ejegg>	 also, user bucketing = ?
[16:35:22] <AndyRussG>	 nope!
[16:35:36] <ejegg>	 2?
[16:35:39] <AndyRussG>	 Mmm maybe set it to 4?
[16:35:45] <ejegg>	 ok
[16:35:48] <AndyRussG>	 Shouldn't really matter tho
[16:35:51] <AndyRussG>	 Thanks!
[16:37:56] <atgo>	 i was just going to offer to do that :P
[16:38:00] <atgo>	 and here you guys go
[16:38:10] <AndyRussG>	 Ah thanks atgo :)
[16:38:46] <ejegg>	 hmm, thought I just enabled it, but not seeing the banner yet
[16:38:55] <AndyRussG>	 cache time?
[16:38:58] <ejegg>	 let me try private browsing
[16:39:00] <ejegg>	 oh, or that
[16:39:14] <ejegg>	 Ah, there it is!
[16:39:32] <ejegg>	 Am I supposed to be rebucketed now?
[16:39:43] <AndyRussG>	 methinks so
[16:39:47] <meganhernandez>	 hey AndyRussG i’m around if you need any help with that test petersent
[16:40:08] <AndyRussG>	 meganhernandez: thanks, we're just checking it out now on aa.wikibooks
[16:42:28] <ejegg>	 Hey AndyRussG : idea for after the new year.  If we're sending the category along with the banner choice data, we can check the hide cookie before we even request BannerLoader
[16:42:58] <atgo>	 hey guys - logging off IRC. Will be on email though
[16:43:04] <atgo>	 and gchat
[16:43:09] <ejegg>	 ok atgo, safe travels
[16:43:18] <AndyRussG>	 atgo: OK! take care ;)
[16:56:17] <AndyRussG>	 ejegg: poof! (That's the sound of more unnecessary round trips disappearing as a result of that suggestion!)
[16:56:34] <AndyRussG>	 also, I'm not getting rebucketed with Peter's banner...
[17:12:44] <grrrit-wm>	 (PS8) Ejegg: Add is_YYYY_donor and latest donation to wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/175794
[17:12:46] <grrrit-wm>	 (PS1) Ejegg: WMF LYBUNT uses wmf_donor instead of silverpop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176006
[17:14:44] <ejegg>	 AndyRussG: let me know if you want me to change the campaign params.  Should it have been user bucketing = 2 maybe?
[17:16:47] <AndyRussG>	 ejegg: no... thanks the banner code is what has to change a bit still, I think
[17:17:07] <AndyRussG>	 Hi again the-wub, just sent u an e-mail :)
[17:17:41] <the-wub>	 hey, thanks. I just changed it. sorry was in a meeting
[17:17:48] <ejegg>	 Hi awight!
[17:18:05] <AndyRussG>	 the-wub: ah OK, np :)
[17:18:22] * AndyRussG waves at awight
[17:19:51] <ejegg>	 awight: got some lybunt-related reviewables.  If you want to take a peek, here's the one to start with: https://gerrit.wikimedia.org/r/175794
[17:20:12] <ejegg>	 the hook is the part I feel needs the most scrutiny
[17:21:39] <ejegg>	 Morning K4-713!
[17:22:34] <K4-713>	 ejegg: Hey! How goes?
[17:22:58] <awight>	 ejegg: awesome, headed into that storm in a few seconds.  First, I'm looking at recurring GC slowwness
[17:23:18] <ejegg>	 K4-713: going great
[17:23:44] <ejegg>	 I split that wmf_donor initalization script off like you wanted, and added a patch to point the new report there
[17:24:02] <ejegg>	 plus a tiny thing in civi core to allow falsy db defaults for custom fields
[17:24:57] <ejegg>	 How did your science experiments go yesterday?
[17:25:38] <K4-713>	 Hehe, they went great. :)
[17:26:02] <K4-713>	 ejegg: So, you need CR, huh?
[17:26:08] <K4-713>	 How's the dash coming?
[17:26:37] <K4-713>	 I think pizzzacat's off today, so we may have to drive that one in.
[17:26:53] <ejegg>	 Dash looks pretty good.  I had a couple suggestions that didn't get it, but I can add those
[17:26:59] <ejegg>	 *get in
[17:27:19] <K4-713>	 Down to the short strokes, then? Neat.
[17:27:32] <K4-713>	 I will totally be the CR Monster today.
[17:27:49] <K4-713>	 Jeff_Green: Did you get all those insane emails I sent last night? :)
[17:27:49] <ejegg>	 Rockin, some CR would be great if you've got a chance!
[17:28:28] <ejegg>	 K4-713: dev_civicrm has all the data up to some time in october.  think that would be good enough to test with?
[17:28:36] <K4-713>	 ejegg: Yep!
[17:28:42] <ejegg>	 Cool
[17:29:54] <K4-713>	 ejegg: Is there actually an easy way to roll back db changes in dev civi at this point?
[17:30:15] <K4-713>	 I remember that being kind of a pain, but that... was a long time ago.
[17:30:23] <ejegg>	 these particular ones are not too bad - I've got a 4 line script I've been using locally
[17:35:48] <AndyRussG>	 the-wub: sorry to bother u (I'm around later too if you're busy), we're still talking about B14_newBucketTest? It looks to me like it's still checking mw.centralNotice.bannerData.campaign (inline <script> tage at the end of the banner contents)
[17:36:00] <AndyRussG>	 Also still no re-bucketing...
[17:36:38] <K4-713>	 ejegg: I think you're accidentally updating the civicrm submodule here: https://gerrit.wikimedia.org/r/#/c/175794/
[17:37:21] <ejegg>	 oh, that change does depend on the submodule update
[17:37:55] <K4-713>	 Well, never mind then. :) What's going on in there?
[17:38:02] <K4-713>	 And, is that merged?
[17:38:11] <K4-713>	 ...guess it must be. Dur.
[17:38:20] <ejegg>	 CiviCRM wasn't letting me set a db default of 0 for the is_YYYY_donor columns: https://gerrit.wikimedia.org/r/#q,I4abdc4e608abf57b1443916f620b413791fc3d02,n,z
[17:38:27] <ejegg>	 oh, actually, nope!
[17:38:35] <ejegg>	 (nope, not merged)
[17:38:53] <K4-713>	 heh, okay.
[17:39:10] <grrrit-wm>	 (CR) Awight: "Good fix! TODO: upstream" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/176003 (owner: Ejegg)
[17:39:14] <grrrit-wm>	 (CR) Awight: [C: 2] Allow falsy values as custom field db defaults [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/176003 (owner: Ejegg)
[17:39:21] <K4-713>	 Ah, that one.
[17:39:22] <grrrit-wm>	 (Merged) jenkins-bot: Allow falsy values as custom field db defaults [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/176003 (owner: Ejegg)
[17:39:25] <ejegg>	 ty awight
[17:41:14] <the-wub>	 AndyRussG: oops, I must have copy-pasted the wrong version. try it now?
[17:41:57] <AndyRussG>	 the-wub: OK one sec..,
[17:43:11] <AndyRussG>	 the-wub: OK, now it works! :)
[17:44:07] <the-wub>	 great, thanks AndyRussG. Want me to make that change for the rest of the full-screen banners?
[17:44:40] <AndyRussG>	 the-wub: sure, I don't see any reason not to :)
[17:47:50] <the-wub>	 okay, done
[17:50:11] <Jeff_Green>	 K4-713: just the sane ones
[17:50:12] <AndyRussG>	 great!
[17:50:25] <AndyRussG>	 sanity... exists?
[17:50:32] <K4-713>	 Jeff_Green: I don't remember sending those.
[17:50:34] <K4-713>	 :)
[17:50:34] <Jeff_Green>	 K4-713: lutetium should be pretty much ready to go re. civicrm staging
[17:50:46] <K4-713>	 That's so... great.
[17:50:56] <K4-713>	 I remember when things were not so great.
[17:51:01] <K4-713>	 It was awful.
[17:51:08] <K4-713>	 This is better.
[17:51:11] <Jeff_Green>	 the dev_* db's are at least as recent as what it says in motd, I think I forgot to update last time I refreshed them
[17:51:12] <Jeff_Green>	 yeah
[17:51:33] <Jeff_Green>	 if we need to refresh it's pretty simple, and we can do it without disrupting production
[17:51:44] <K4-713>	 Jeff_Green: Are you required for that, or can we do it?
[17:51:56] <ejegg>	 awight: pull request sent upstream
[17:52:03] <Jeff_Green>	 K4-713: not sure. checking
[17:52:13] <awight>	 ejegg: rad!
[17:52:51] <awight>	 ejegg: wondering if they usually rely on db schema column default value?
[17:53:33] <ejegg>	 Not sure, let me see where else $field->default_value is used
[17:53:54] <Jeff_Green>	 K4-713: in theory you could, using the local civicrm user, but in practice you'd probably set off some alarms re. disk utilization and replag
[17:54:45] <K4-713>	 ejegg: This may sound... whatever, but you may need to handle people from the future.
[17:54:54] <awight>	 O_o
[17:55:00] <ejegg>	 K4-713: how far in the future?
[17:55:18] <K4-713>	 We've had future donors in the past.
[17:55:21] * K4-713 frowns
[17:55:27] <K4-713>	 Language is hard.
[17:55:29] <ejegg>	 like, add new is_YYYY_donor columns on demand?
[17:55:44] <K4-713>	 No, I mean, we may already have donations from the future in prod.
[17:56:06] <K4-713>	 Not... many.
[17:56:07] <ejegg>	 yeah, I know there's at least one from 2104
[17:56:13] <awight>	 :)
[17:56:19] <awight>	 I'm sure that was intentional
[17:56:23] <awight>	 inteniotnal
[17:56:35] <K4-713>	 Probably a small enough number that we can happily handle them manually.
[17:56:38] <ejegg>	 Miguel O'Hara?
[17:56:54] <awight>	 really?
[17:57:13] <ejegg>	 Spiderman 2099 was rad
[17:57:47] <awight>	 Money from that far in the future is probably hyperinflated, unfortunately.
[17:57:59] <ejegg>	 standard galactic credits
[17:58:42] <K4-713>	 Please make the currency converter compatible with the future.
[17:58:57] <K4-713>	 Blocking issue.
[17:58:59] <K4-713>	 :p
[17:59:21] <awight>	 We should use the Soros API so we know how hedge funds will be manipulating the world economy
[17:59:29] <K4-713>	 I just want to be able to say that the donation pipeline sees through time. That's all.
[17:59:54] * K4-713 coughs
[17:59:55] <K4-713>	 But.
[18:00:18] <atgo>	 wouldn't that be nice ;)
[18:00:27] <K4-713>	 It would solve so many problems.
[18:00:39] <K4-713>	 But it's just "Nice to Have".
[18:00:44] <K4-713>	 -_-
[18:02:19] <atgo>	 :P
[18:02:49] <ejegg>	 Hmm, let me just add a test for that hook
[18:03:28] <grrrit-wm>	 (CR) Katie Horn: [C: 2] Add is_YYYY_donor and latest donation to wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/175794 (owner: Ejegg)
[18:03:46] <K4-713>	 ejegg: Before I wander off for meeting, do you need anything else CR'd before you can test this?
[18:04:04] <K4-713>	 The DB update part, anyway.
[18:04:06] <ejegg>	 there's a dependent patch for the report
[18:04:13] <ejegg>	 oh, nope, I can do the db update now
[18:04:23] <K4-713>	 Sweet. Would the report help with that?
[18:04:46] <ejegg>	 not needed.  mostly we care about how long it takes anyway
[18:04:49] <ejegg>	 thanks!
[18:04:56] <K4-713>	 Cool! Back in a bit.
[18:05:41] <ejegg>	 oops, that hook was wrong :(
[18:07:35] <Jeff_Green>	 K4-713: looking at the ganglia question...I'm totally unclear what is generating those statistics
[18:08:44] <grrrit-wm>	 (PS1) Ejegg: Test and fix wmf_donor contribution hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176012
[18:11:38] <Jeff_Green>	 ah HA
[18:11:42] <Jeff_Green>	 AH HA.
[18:20:00] <atgo>	 hey awight ejegg|away K4|meeting do you know if donatewiki requires a manual deployment?
[18:20:28] <atgo>	 there's a question about the legal text from last week
[18:22:28] <atgo>	 holy cannoli it is snowing here.
[18:22:42] <AndyRussG>	 snow flakes are falling on my head
[18:22:45] <Jeff_Green>	 indeed it is
[18:22:57] <Jeff_Green>	 here they cancelled school before it even started
[18:23:11] <atgo>	 yeah i'm trying to drive from nyc to haverhill today
[18:23:12] <atgo>	 sigh.
[18:23:26] <AndyRussG>	 go carefully :)
[18:23:30] <atgo>	 yeah we are moving slow
[18:23:48] <Jeff_Green>	 atgo: ooh, that's not a fun drive in the snow the day before TG
[18:23:53] <atgo>	 the boy is from california. this is all new
[18:24:17] <atgo>	 but.. i laugh at the macy's day parade already?
[18:24:33] <atgo>	 ccogdill: is this good? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2190
[18:24:48] <Jeff_Green>	 this is why I used to get irate when rain would cause pileups in the Bay Area
[18:24:58] <atgo>	 hahaha i know Jeff_Green
[18:25:05] <atgo>	 iiii knowwwww
[18:25:38] * Jeff_Green still has a driveway snowplowing contract on my desk, can't decide whether to pull the trigger
[18:25:39] <ccogdill>	 atgo I’m working on it
[18:25:58] <ccogdill>	 awight gave me a solution that didn’t work for contacts w/dupes so there’s manual work involved
[18:26:05] <ccogdill>	 but #2190 is a lot less crucial than...
[18:26:19] <ccogdill>	 #1944 atgo. that’s the one we need ASAP
[18:27:25] <atgo>	 ccogdill:  i know.. unrelated work
[18:28:57] <ccogdill>	 okay cool, making sure you didn’t think they were the same
[18:36:48] <awight>	 atgo: what are u asking about donatewiki?
[18:36:55] <atgo>	 the legal text
[18:37:12] <awight>	 that is nowhere close to a full sentence :p
[18:37:20] <awight>	 is it deployed automatically?  I think so.
[18:37:39] <awight>	 wait.  which legal text
[18:37:44] <awight>	 where does it come from?
[18:37:52] <awight>	 translatewiki?
[18:40:47] <atgo>	 awight: will forward you an email
[18:41:57] <atgo>	 also... peter's 'it's not urgent" is no longer the case
[18:42:01] <awight>	 atgo: If it's coming from translatewiki, I'm pretty certain that updates happen daily at 0200 UTC
[18:42:17] <awight>	 I can check the specific message once I read email
[18:42:54] <atgo>	 awight: nevermind! just got confirmation :)
[18:44:20] <awight>	 atgo: ok, great!
[18:45:15] <AndyRussG>	 I think I erased from my memory how to run those Django scripts...
[18:45:41] <awight>	 AndyRussG: I'll get that for you, one moment, please ...
[18:46:02] <AndyRussG>	 awight: ah hi! Actually I was semi-kidding...
[18:46:24] <AndyRussG>	 Just a bit of selective intentional amnesia...
[18:46:37] <awight>	 aww sorry to hear it--the flash ram still has the information after reboot, huh
[18:47:17] <atgo>	 moar questions! AndyRussG awight ejegg|scrmOscrms do you guys have any idea about 2196? or no time to look yet?
[18:48:08] <awight>	 atgo: I was confused about that bug report.  Sounds like it's working as designed.
[18:48:24] <AndyRussG>	 atgo: yep I'm working on it now, I may have found such a bug...
[18:48:25] <awight>	 There *should* be a row in the bannerimpressions table, but with outcome=hide
[18:48:44] <atgo>	 hm.
[18:48:46] <atgo>	 thanks :)
[18:49:01] <awight>	 sorry, "result=hide"
[18:51:38] <AndyRussG>	 atgo: K4|meeting: awight: ejegg|scrmOscrms: no problem if I do standup by e-mail today? (parent-teacher interviews, couldn't control the schedule much)
[18:51:52] <atgo>	 yeah that's fine... i think we're all running around today
[18:54:42] <AndyRussG>	 atgo: K thanks...
[19:10:32] <ejegg>	 about to run the wmf_donor initialization script on lutetium.  Hopefully won't lock things up too bad for too long!
[19:10:37] <K4-713>	 AndyRussG: Definitely running around today.
[19:11:26] <AndyRussG>	 K4-713: ah OK :)
[19:12:21] <K4-713>	 AndyRussG: Did they ask you about the banner impression hide bug?
[19:12:27] <K4-713>	 Because I'm about to do that.
[19:12:38] <K4-713>	 Ask you, I mean. Not fix it. :p
[19:12:58] <AndyRussG>	 K4-713: yes, got the info, working on it now :)
[19:13:23] <K4-713>	 How big is the fix? Can you tell yet?
[19:14:34] <AndyRussG>	 Looks like a wee bug so far, may be exactly what Ellery suspected
[19:15:00] <AndyRussG>	 I haven't investigated enough to be sure of anything, tho
[19:18:03] <awight>	 K4-713: have you licked any CR cookies?
[19:18:12] <K4-713>	 Gah. That fonts-related apache error is really saddening me right now.
[19:18:33] <awight>	 I forget if we diagnosed that...
[19:18:52] <awight>	 Wasn't it the Bootstrap library?
[19:18:57] <K4-713>	 I think we decided that it might be some oddball user agent doing it. You know: "Helping" by trying to preload something.
[19:19:01] <K4-713>	 It's definitely not everybody.
[19:19:12] <awight>	 but it's only in Worldpay?
[19:19:13] <K4-713>	 Jeff_Green: Say.
[19:19:55] <K4-713>	 I think we were waiting for your special perms to figure this one out.
[19:20:23] <K4-713>	 There is this incredibly annoying apache error on payments, saying that a file doesn't exist. Our code looks for it nowhere.
[19:20:41] <K4-713>	 Wondering if we could get any insight into user-agenty type stuff.
[19:23:26] <awight>	 K4-713: it's only WorldPay.  yeah it's Bootstrap causing the browser to preload things:
[19:23:29] <awight>	 ./worldpay_gateway/forms/css/bootstrap.css:  src: url('../fonts/glyphicons-halflings-regular.eot');
[19:23:32] <awight>	 ./worldpay_gateway/forms/css/bootstrap.css:  src: url('../fonts/glyphicons-halflings-regular.eot?#iefix') format('embedded-opentype'), url('../fonts/glyphicons-halflings-regular.woff') format('woff'), url('../fonts/glyphicons-halflings-regular.ttf') format('truetype'), url('../fonts/glyphicons-halflings-regular.svg#glyphicons-halflingsregular') format('svg');
[19:23:37] <awight>	 Fix is to comment out these lines.
[19:23:54] <grrrit-wm>	 (CR) Awight: [C: 2] Don't use UNIX timestamp for wgNoticeOldCookieApocalypse config [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175907 (owner: Krinkle)
[19:23:57] <K4-713>	 awight: Look for that class being used.
[19:24:01] <awight>	 K4-713: it's not.
[19:24:10] <awight>	 K4-713: but like you said, some browsers are more helpful than others.
[19:24:10] <K4-713>	 yeah. Which is why it's not everybody.
[19:24:21] <K4-713>	 I still want to know what's doing it.
[19:24:30] <grrrit-wm>	 (Merged) jenkins-bot: Don't use UNIX timestamp for wgNoticeOldCookieApocalypse config [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175907 (owner: Krinkle)
[19:24:34] <awight>	 I think, either way we need to remove the lines cos we can't fix browsers.
[19:25:38] <grrrit-wm>	 (CR) Awight: "@ejegg: should we clear out the garbage data before deploying this?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176012 (owner: Ejegg)
[19:25:55] <K4-713>	 awight: If you want to, since you're currently looking right at it, go ahead.
[19:26:01] <awight>	 k
[19:26:03] <Jeff_Green>	 K4-713: ok
[19:26:13] <grrrit-wm>	 (CR) Ejegg: "No need, the original hook isn't deployed yet!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176012 (owner: Ejegg)
[19:26:43] <Jeff_Green>	 K4-713: what's the logged error?
[19:27:20] <K4-713>	 File does not exist: /srv/www/org/wikimedia/payments/extensions/DonationInterface/worldpay_gateway/forms/fonts
[19:27:34] <Jeff_Green>	 looking
[19:27:34] <K4-713>	 Jeff_Green: But at this point, it's totally academic.
[19:27:40] <K4-713>	 Still, I'm interested.
[19:27:49] <Jeff_Green>	 i like killing noise
[19:28:00] <K4-713>	 It's one of my favorite things.
[19:28:51] <grrrit-wm>	 (PS1) Awight: Comment out Bootstrap glyphicons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176030
[19:28:57] <awight>	 ejegg: hehe ok thanks
[19:29:09] <Jeff_Green>	 K4-713: where are you seeing that exactly?
[19:29:10] <grrrit-wm>	 (CR) Awight: [C: 2] Test and fix wmf_donor contribution hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176012 (owner: Ejegg)
[19:29:25] <K4-713>	 Jeff_Green: The aggregate error log.
[19:29:30] <K4-713>	 payments.error
[19:29:50] <grrrit-wm>	 (CR) Awight: [C: 2] WMF LYBUNT uses wmf_donor instead of silverpop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176006 (owner: Ejegg)
[19:29:52] <Jeff_Green>	 ah HA ok
[19:29:56] <grrrit-wm>	 (Merged) jenkins-bot: WMF LYBUNT uses wmf_donor instead of silverpop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176006 (owner: Ejegg)
[19:29:58] <grrrit-wm>	 (Merged) jenkins-bot: Test and fix wmf_donor contribution hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176012 (owner: Ejegg)
[19:32:03] <awight>	 ejegg: you happen to know in which circumstances contacts are deleted?
[19:32:25] <ejegg>	 awight: no, guessing dedupe is one?
[19:32:47] <ejegg>	 and that's always done by setting is_deleted = 1, not physical deletion?
[19:32:55] <awight>	 yep
[19:33:09] <awight>	 good enough for me :)  Yeah we wouldn't want to opt those people out!
[19:33:24] <grrrit-wm>	 (CR) Awight: [C: 2] Do not export email addresses for deleted contacts [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/175479 (owner: Ejegg)
[19:33:25] <ejegg>	 err, maybe we do?
[19:33:28] <grrrit-wm>	 (Merged) jenkins-bot: Do not export email addresses for deleted contacts [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/175479 (owner: Ejegg)
[19:33:37] <ejegg>	 Well, we don't want to email to them anyway
[19:33:55] <K4-713>	 awight: Ha. Some of the languages are being overridden on donate, for the legal thingy.
[19:33:59] <awight>	 ejegg: we don't want to put anyone on the suppression list just cos they have a dupe though, you're right
[19:34:00] <K4-713>	 But, not regular en.
[19:34:08] <ejegg>	 awight: sounds correct
[19:34:10] <awight>	 K4-713: wait what is being overridden?
[19:34:15] <K4-713>	 swivel
[19:35:55] <grrrit-wm>	 (PS1) Ejegg: Update bower_modules c3, fontawesome, numeraljs [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/176035
[19:36:02] <Jeff_Green>	 K4-713: ok i've managed to reproduce the error via hitting the URL https://payments.wikimedia.org/extensions/DonationInterface/worldpay_gateway/forms/fonts directly
[19:36:29] <Jeff_Green>	 so my guess is we have a bad link in the form listed in the referring URL
[19:36:36] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] "+2ing 3rd party libs update" [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/176035 (owner: Ejegg)
[19:38:25] <K4-713>	 Jeff_Green: Actually, it's more fun than that.
[19:39:12] <K4-713>	 Jeff_Green: There's a css class in a third party thing, that we don't use anywhere. That's referencing the font that's missing. So, only some browsers are trying for the preload.
[19:39:16] <K4-713>	 I was wondering which ones.
[19:39:26] <Jeff_Green>	 oh, sec
[19:39:37] <K4-713>	 Meanwhile, we're commenting that thing out, because we never intend to actually use it.
[19:39:41] <K4-713>	 But.
[19:39:41] <grrrit-wm>	 (PS2) Awight: Delete obsolete require_once lines [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/169584 (owner: Ejegg)
[19:39:47] <grrrit-wm>	 (CR) Awight: Delete obsolete require_once lines (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/169584 (owner: Ejegg)
[19:39:52] <grrrit-wm>	 (CR) Awight: [C: 2] Delete obsolete require_once lines [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/169584 (owner: Ejegg)
[19:39:54] <grrrit-wm>	 (Merged) jenkins-bot: Delete obsolete require_once lines [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/169584 (owner: Ejegg)
[19:40:11] <Jeff_Green>	 we could return a font that's 900px :-)
[19:40:11] <K4-713>	 Jeff_Green: I'm still curious what's trying to be so helpful.
[19:40:44] <grrrit-wm>	 (PS2) Awight: Nuke standalone_globalcollect_adapter_path use in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170442 (owner: Ejegg)
[19:40:49] <grrrit-wm>	 (CR) Awight: [C: 2] Nuke standalone_globalcollect_adapter_path use in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170442 (owner: Ejegg)
[19:40:54] <grrrit-wm>	 (Merged) jenkins-bot: Nuke standalone_globalcollect_adapter_path use in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/170442 (owner: Ejegg)
[19:41:17] <awight>	 ejegg: if you don't want https://gerrit.wikimedia.org/r/#/c/174617/ deployed, u should CR-2 it to make sure I don't accidentally merge :)
[19:41:57] <ejegg>	 awight: fine to deploy it, just so long as we edit that stylesheet!
[19:42:07] <ejegg>	 That's the one we don't need to talk to GC about
[19:43:07] <awight>	 ejegg: well, that would be good to do pre-launch, I guess
[19:43:26] <awight>	 also--how is wmfwiki involved?
[19:43:30] <ejegg>	 They should happen simultaneously, since they change the input display a bit
[19:43:42] <awight>	 is that just our local copy of css that GC hosts?
[19:43:47] <ejegg>	 We tell GC to include a stylesheet link
[19:43:52] <ejegg>	 we host it ourselves
[19:44:00] <awight>	 oh dear.  Why isn't that on payments...
[19:44:03] <ejegg>	 So our edits take effect immediately
[19:44:03] <awight>	 legacy...
[19:44:14] <K4-713>	 I don't think it could be, for some... reason that might not exist anymore.
[19:44:18] <awight>	 hrmph
[19:44:26] * awight borrows sternness
[19:44:36] <ejegg>	 Making it an actually deployed thing might be nice
[19:44:48] <K4-713>	 Yeah, it would mean we don't have two moving targets.
[19:45:04] <K4-713>	 Could still use the easy-to-edit one for sandboxing.
[19:45:05] <K4-713>	 I think.
[19:45:19] <awight>	 we can certainly pull deployed css files from paymentswiki.
[19:45:34] <K4-713>	 Well, yes.
[19:45:46] <K4-713>	 It would be very silly if we couldn't.
[19:46:03] <awight>	 So it seems insane to be using wmfwiki
[19:47:01] <ejegg>	 well, if we have to talk to them about a separate RTL css anyway, that's a great time to move the css to payments
[19:47:48] <awight>	 K4-713: " For historical reasons, Internet Explorer identifies itself as a Mozilla browser."
[19:47:54] <awight>	 http://msdn.microsoft.com/en-us/library/ms537503%28v=vs.85%29.aspx
[19:48:19] <awight>	 ejegg: oof I'm tempted to serve the rtl using the built-in janus stuff
[19:48:20] <K4-713>	 Oh. Oh... oh. I'm starting to have flashbacks.
[19:48:22] <K4-713>	 Yes.
[19:48:39] <K4-713>	 ...ow.
[19:48:46] <awight>	 sorry
[19:48:56] <K4-713>	 'sokay. I'm already over it.
[19:49:29] <grrrit-wm>	 (CR) Awight: [C: 1] "Looks like an improvement. TODO: I would love to decouple from wmfwiki if possible." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/174617 (owner: Ejegg)
[19:50:27] <ejegg>	 K4-713: the wmf_donor initialization script ran in less than 1/2 hr.  It would be locking the new wmf_donor table for up to 10 min for the biggest insert, so we'd want to run it with QC off.
[19:50:45] <awight>	 ejegg: could we run it before adding the custom hook?
[19:50:55] <AndyRussG>	 meganhernandez: do you want to start another test at 12:00 PST? Or is that too soon?
[19:51:07] <ejegg>	 awight: Sure, I could break the hook out
[19:51:22] <awight>	 oh, well no worries turning off QC for an hour or whatev
[19:51:39] * K4-713 eyebrows
[19:51:44] <awight>	 <_<
[19:51:49] <ejegg>	 awight: yeah, actually, i'd like to turn the qc off while initializine
[19:52:11] <ejegg>	 So new donations coming in after the initial select get processed via the hook
[19:52:14] <awight>	 umm.  http://payments.dev/extensions/DonationInterface/gateway_forms/css/Form.css
[19:52:17] <awight>	 0 bytes
[19:52:21] <K4-713>	 awight, ejegg: If you turn off qc at all now, you're going to have to ping everybody.
[19:52:28] <K4-713>	 They'll think their campaigns are broken.
[19:52:47] <K4-713>	 Technically speaking, though: You're fine. :p
[19:52:57] <ejegg>	 OK
[19:53:18] <K4-713>	 awight: Is that supposed to be a thing?
[19:53:20] <ejegg>	 Is there a best time of day for that?
[19:53:28] <K4-713>	 ejegg: You'll have to ask meganhernandez.
[19:53:32] <ejegg>	 OK
[19:53:49] <AndyRussG>	 phew finally got Djangostats running... I should have made notes so I wouldn't waste time on the same issue twice
[19:54:15] <meganhernandez>	 ok how about we start with turning off the QC and then we redo the buckets test once we have that back & ready?
[19:54:37] <K4-713>	 ejegg: You ready to do your thing now?
[19:54:43] <K4-713>	 Or do you need more time?
[19:54:45] <meganhernandez>	 or later AndyRussG when you’re around.  i’ll get some new banners ready in the meantime
[19:55:42] <ejegg>	 K4-713: Sure, I can do a crm deploy + script run now
[19:55:49] <K4-713>	 Cool.
[19:55:49] <meganhernandez>	 we have a campaign set up, but we already tested those this morning & have some losers we can throw out.  i could get in anoter content test if we do it later on.  or if we need to look right away, we can put the loser back up.  it should be short anyway
[19:55:57] <K4-713>	 ejegg: How long do you need?
[19:56:15] <ejegg>	 around 1/2 hr after I get the patch ready
[19:56:19] <grrrit-wm>	 (PS1) Awight: remote unused stylepath cruft [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176037
[19:56:21] <ejegg>	 which should just be 2 min
[19:56:42] <K4-713>	 meganhernandez: Just for context, turning off qc won't actually disrupt donations. Just... the part where we can find out about them.
[19:57:12] <meganhernandez>	 sure, does it work to start with QC & then do bucket test later ?
[19:57:17] <K4-713>	 Yep.
[19:57:27] <K4-713>	 Sounds like we need 30 minutes of blindness until we can turn it back on.
[19:57:35] <AndyRussG>	 meganhernandez: sure! I might be back earlier than 10:45 UTC, if u like I can ping you then...
[19:57:57] <K4-713>	 meganhernandez: Somebody will ping you when we flip the switch.
[19:58:01] <K4-713>	 On both sides.
[19:58:03] <meganhernandez>	 ok!
[19:58:43] <awight>	 ejegg: wrt the GC RTL css... I'm not seeing a way to serve an arbitrary css file through JanusCSS, unfortunately.
[19:58:55] <awight>	 I guess we leave the wmfwiki thing as-is
[19:58:59] <ejegg>	 awight: ah well
[19:59:01] <awight>	 ?
[19:59:27] <grrrit-wm>	 (PS2) Awight: remote unused stylepath cruft [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176037
[20:01:06] <grrrit-wm>	 (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/176039
[20:01:59] <grrrit-wm>	 (PS2) Awight: Fix Silverpop import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165224 (owner: Ejegg)
[20:02:09] <grrrit-wm>	 (CR) Awight: [C: 2] Fix Silverpop import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165224 (owner: Ejegg)
[20:02:14] <grrrit-wm>	 (Merged) jenkins-bot: Fix Silverpop import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165224 (owner: Ejegg)
[20:02:34] <ejegg>	 Thanks for clearing out all those old patches, awight!
[20:02:41] <awight>	 yeah, sorry to let them build up!
[20:03:35] <awight>	 ejegg: actually... check this out, http://payments.dev/load.php?debug=false&lang=ar&modules=mediawiki.legacy.commonPrint%2Cshared%7Cmediawiki.skinning.interface%7Cmediawiki.ui.button%7Cskins.vector.styles&only=styles&skin=vector&*
[20:03:58] <ejegg>	 arbitrary janus-ing, huh?
[20:03:59] <awight>	 ResourceLoader can serve straight CSS, plus it does minify and Janus
[20:04:07] <awight>	 yeah, we just have to define a RL module for the GC css
[20:04:18] <ejegg>	 cool
[20:04:25] <awight>	 Seems like a good 11th-hour fix :)
[20:04:33] <ejegg>	 gets direction from the lang=, huh?
[20:04:37] <awight>	 looks like it
[20:04:44] <awight>	 so... we fake the language :(
[20:04:53] <ejegg>	 nice.  wonder if we can tell gc to send that as a param?
[20:05:10] <awight>	 right...
[20:05:19] <awight>	 we'll need all those params
[20:05:44] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/176039 (owner: Ejegg)
[20:06:22] <ejegg>	 OK, I'm going to stop QCs and deploy civi unless anyone tells me not to.  I'll send out a quick email
[20:07:07] <awight>	 http://payments.dev/load.php?debug=true&lang=en&modules=mediawiki.ui.button&only=styles vs http://payments.dev/load.php?debug=true&lang=ar&modules=mediawiki.ui.button&only=styles
[20:07:16] <awight>	 yep, that approach will work.
[20:07:45] <awight>	 K4-713: any reason not to screw around with the GC iframe css the last work day before we launch?
[20:08:19] <K4-713>	 awight: You know what? Go nuts. Is there a sandbox option, though?
[20:08:24] <awight>	 oh good :)
[20:08:32] <awight>	 Yeah, we can set it for the testing environment only AFAIK
[20:08:34] <K4-713>	 I have managed not to even glance at those docs in three years.
[20:08:42] <awight>	 K4-713: only issue is that I don't have GC console access
[20:08:47] <K4-713>	 ...ah
[20:09:01] <K4-713>	 I see where this is going.
[20:09:07] <awight>	 hehehe
[20:09:36] <K4-713>	 Weird. I don't seem to have the right thing either.
[20:13:23] <ejegg>	 !log disabling queue consumers
[20:13:27] <morebots>	 Logged the message, Master
[20:14:21] <ejegg>	 !log updated crm from e13cae8c418d29ef444899e0a70bbe03f4b7079d to d0a51250d2bdbf3c818ec0486af284691c7a61ff
[20:14:23] <morebots>	 Logged the message, Master
[20:15:22] <ejegg>	 running the init script...
[20:16:14] <ejegg>	 ahh, phooey, permissions issues
[20:16:41] <awight>	 o no!
[20:16:45] <grrrit-wm>	 (PS1) Awight: WIP move GC iframe css into code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176044
[20:22:22] <grrrit-wm>	 (PS2) Awight: Move GC iframe css into code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176044
[20:22:31] <awight>	 ejegg: ok, when we're ready to play with the GC skin, ^^
[20:24:20] <ejegg>	 ahh, cool.  I should rebase the other CSS change on top of that
[20:24:33] <awight>	 We can just deploy that independently...
[20:24:44] <awight>	 It won't take effect until we make changes in the GC console.
[20:24:55] <awight>	 but yes :)
[20:25:07] <ejegg>	 ah, true, this is standalone
[20:25:42] <awight>	 ejegg: I didn't roll in the changes you're suggesting in your patch, cos I don't know what they should be... feel free to make that change on top of my patch
[20:28:25] <grrrit-wm>	 (CR) Awight: Fix input direction for rtl langs when sitedir=ltr (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/173435 (owner: Ejegg)
[20:28:27] <grrrit-wm>	 (PS3) Awight: Fix input direction for rtl langs when sitedir=ltr [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/173435 (owner: Ejegg)
[20:28:34] <grrrit-wm>	 (CR) Awight: [C: 2] Fix input direction for rtl langs when sitedir=ltr [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/173435 (owner: Ejegg)
[20:29:13] <K4-713>	 ejegg: Shark attack. http://ganglia.wikimedia.org/latest/graph.php?r=hour&z=xlarge&c=Fundraising+eqiad&h=silicon.frack.eqiad.wmnet&jr=&js=&v=250&m=ActiveMQ+QueueSize+donations&vl=Messages
[20:29:32] <ejegg>	 du-dun....   du-dun....
[20:29:41] <grrrit-wm>	 (CR) Awight: "@ejegg: wondering if this is currently causing breakage?" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg)
[20:29:55] <awight>	 so few!
[20:32:14] <grrrit-wm>	 (CR) Ejegg: "Not breaking now, but see https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2144" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg)
[20:33:07] <grrrit-wm>	 (Merged) jenkins-bot: Fix input direction for rtl langs when sitedir=ltr [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/173435 (owner: Ejegg)
[20:33:39] <grrrit-wm>	 (PS2) Awight: Send different OrderNumbers for each WP transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg)
[20:34:01] <grrrit-wm>	 (CR) Awight: [C: 2] "Seems like something we might want to deploy and test on staging." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg)
[20:34:58] <grrrit-wm>	 (CR) Ejegg: [C: -2] "Don't deploy yet: needs a tiny update to the audit parsing regex which finds matching log lines." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg)
[20:35:11] <awight>	 hot potato!
[20:35:20] <ejegg>	 heh
[20:36:14] <ejegg>	 OK, initial 8M row wmf_donor insert done, now updating latest donation date and lifetime totals
[20:36:32] <ejegg>	 then the is_YYYY_donor columns should be pretty quick
[20:56:16] <ejegg>	 !log enabled queue consumers
[20:56:20] <morebots>	 Logged the message, Master
[21:20:53] <grrrit-wm>	 (CR) Awight: "OK, removing my CR+2 to avoid accidents :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg)
[21:21:05] <ccogdill>	 hey ejegg - we’re getting messages from donors they they’re receiving TY emails 11-12 times
[21:21:14] <ccogdill>	 does this have to do with the work you were doing?
[21:21:22] <ejegg>	 ccogdill: it shouldn't have!
[21:21:35] <ejegg>	 but yikes, I'll turn off the TY job for now
[21:21:43] <awight>	 wowza!
[21:21:54] <awight>	 ccogdill: can you email us some identifiers?
[21:22:04] <ccogdill>	 identifiers? here’s a contact id https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=8093966
[21:22:07] <awight>	 thx
[21:22:25] <ccogdill>	 and https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=8093715
[21:22:28] <ccogdill>	 thanks ejegg :)
[21:22:43] <ejegg>	 !log disabled ty sending
[21:22:44] <morebots>	 Logged the message, Master
[21:23:30] <ccogdill>	 I’ll send you one more example: https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=8094164
[21:24:01] <awight>	 There it is: 21:21:43  WD thank_you: Updating successful TY send failed with details: Array ;40m[error]m
[21:24:51] <ejegg>	 awight: drat, this is the hook running on ty job saving the thank_you_date, huh
[21:26:39] <awight>	 ejegg: compounded by, the job is not checking for errors...
[21:26:48] <ejegg>	 Oof
[21:26:56] <awight>	 I thought that was already a known issue, but couldn't find a card.
[21:27:23] <ejegg>	 OK, for now I'll have the hook skip wmf_donor update on edit if no contact id
[21:27:26] <awight>	 This is also related, https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2141
[21:27:37] <awight>	 ejegg: wat?  How can there be no contact id?
[21:28:03] <ejegg>	 On edit, I think they're only setting the changed properties in the object the hook gets
[21:30:52] <awight>	 ejegg: yep.  that's a terrible thing that happens
[21:32:15] <awight>	 ejegg: um, when u're ready to start the TY job again, let's bulk mark people with no_thank_you='bug ID', and do so liberally... we should go out of our way to avoid sending a last "THANK YOU" to these poor folks.
[21:32:29] <ejegg>	 yeah, definitely
[21:33:09] <awight>	 I can do that part...
[21:33:31] <ejegg>	 That would be awesome!
[21:35:59] <awight>	 ccogdill: fyi, https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2198 -- We're going to err on the side of, not sending another TY to this group of people.  A few will probably fall through the cracks and not receive their TY.
[21:36:17] <ccogdill>	 any estimate on how many “a few” is?
[21:36:18] <awight>	 I'll use a $250 threshold, so anyone who donated more will still get the letter.
[21:36:21] <awight>	 not yet.
[21:36:23] <ccogdill>	 thanks for the update!
[21:36:28] <ccogdill>	 okay
[21:36:45] <ejegg>	 awight: guessing about 700, since that was what the queue built up to
[21:36:48] <ccogdill>	 but all TYs going forward should be as normal or ?
[21:37:00] <awight>	 ccogdill: yep, ejegg is fixing the issue
[21:37:04] <ejegg>	 ccogdill: yep, soon as I fix this one little bug (it was indeed my code)
[21:37:14] <awight>	 ejegg: I think you're right that it's the same group every time.
[21:37:14] <ccogdill>	 ejegg 700 not receiving their TY email? just trying to gauge how many donors we’ll hear from
[21:37:23] <ccogdill>	 okay awesome, thank you both for jumping on this
[21:37:26] <awight>	 ccogdill: probably only a handful
[21:37:35] <ccogdill>	 oh whew, 700 was scary :D
[21:37:45] <awight>	 ejegg: also, 21:21:47  Undefined variable: civi_queue_record thank_you.module:465              [notice]
[21:38:05] <ejegg>	 ooh, ok
[21:38:08] <awight>	 Maybe that's just fallout from the other issue
[21:38:25] <ejegg>	 I'll look in a sec
[21:40:40] <awight>	 rats. thank_you_add_civimail_records: "false"
[21:51:51] <K4-713>	 Hey guys.
[21:52:11] <awight>	 ejegg: ccogdill: looks like we were able to suppress TYs for exactly the 700 victims.
[21:52:24] <ccogdill>	 woohoo!
[21:52:29] <ccogdill>	 perfect, thanks guys
[21:52:43] * awight attempts reading between the lines in K4-713's salutation
[21:53:18] <K4-713>	 Hard to read between lines when there's only one of them.
[21:53:24] <K4-713>	 But I just blew it.
[21:53:42] <K4-713>	 How are we doing?
[21:53:45] <awight>	 I had a feeling that's what you were trying to say!
[21:53:54] <awight>	 just in a more polite fashion :p
[21:54:07] <K4-713>	 pretty much.
[21:54:40] <K4-713>	 You can add some "can I unblock anything" to that.
[21:55:01] <K4-713>	 I'm going to kick GC nightly for today first, now that regular qc is back up.
[21:55:12] <K4-713>	 Is that going to ruin anything you're up to now?
[21:55:35] <awight>	 nope
[21:55:44] <K4-713>	 Are we all... normal again?
[21:56:00] <ejegg>	 My hook busted TY letters
[21:56:09] <ejegg>	 furiously coding a fix
[21:56:26] <awight>	 pace yourself :)
[21:56:31] <awight>	 there's more where this came from
[21:57:24] <K4-713>	 So, wait. Are we not patched yet?
[21:57:36] <K4-713>	 If not, I assume the TY job is off.
[21:57:57] <awight>	 it's still off
[21:58:19] <K4-713>	 k
[22:05:24] <grrrit-wm>	 (PS1) Ejegg: Dix wmf_donor hook when editing contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176150
[22:06:17] <grrrit-wm>	 (PS2) Ejegg: Fix wmf_donor hook when editing contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176150
[22:06:25] <ejegg>	 awight: ^^^
[22:06:30] <awight>	 k
[22:07:00] <ejegg>	 Could have intelligently decided which edits merit a wmf_donor update, but didn't
[22:07:33] <ejegg>	 This just snags the whole contrib from db if any of contact id, date, or amount are missing
[22:08:01] <grrrit-wm>	 (PS3) Awight: Fix wmf_donor hook when editing contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176150 (owner: Ejegg)
[22:08:51] <grrrit-wm>	 (CR) Awight: [C: 2] "Thanks for the fast fix. I'm beginning to hate how the CiviCRM hooks work, TODO make them less terrible." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176150 (owner: Ejegg)
[22:08:57] <grrrit-wm>	 (Merged) jenkins-bot: Fix wmf_donor hook when editing contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176150 (owner: Ejegg)
[22:09:03] <ejegg>	 ty awight
[22:09:22] <awight>	 ejegg: it's so horrible... the handstands we've had to do to use Civi hooks...
[22:09:45] <K4-713>	 Have I ever mentioned how much I hate python?
[22:09:53] <ejegg>	 yeah, neither _pre nor _post has exactly what you want
[22:10:04] <K4-713>	 awight: If you have a minute, maybe you can explain something to me before I start throwing things.
[22:10:07] <awight>	 K4-713: are you battling whitespace?
[22:10:11] <K4-713>	 No.
[22:10:12] <awight>	 cos that would look funny.
[22:10:29] <K4-713>	 Like the last half of Fight Club.
[22:11:05] <grrrit-wm>	 (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/176152
[22:12:21] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/176152 (owner: Ejegg)
[22:13:39] <ejegg>	 !log updated crm from d0a51250d2bdbf3c818ec0486af284691c7a61ff to 96f66e6b6c947c4e4c32c4a4a32dc940dc3b1d60
[22:13:42] <morebots>	 Logged the message, Master
[22:14:12] <ejegg>	 awight: going to try editing one of my test donations
[22:14:32] <awight>	 hehe VOOM
[22:14:33] <K4-713>	 Jeff_Green: Hey... yt?
[22:14:50] <awight>	 ejegg: uh, oh.  Wait, did all contribution updates during that 15-min period fail?...
[22:14:56] <awight>	 Maybe we need to tell major gifts.
[22:15:00] <K4-713>	 Jeff_Green: I need a thing changed and I don't have my sudo hat anymore.
[22:15:10] <Jeff_Green>	 ya
[22:15:11] <ejegg>	 awight: it's in the post_ hook
[22:15:13] <Jeff_Green>	 what's up?
[22:15:19] <K4-713>	 Jeff_Green: Will PM
[22:15:23] <Jeff_Green>	 k
[22:15:38] <ejegg>	 awight: oh darn, but that still breaks the save
[22:15:41] <awight>	 ejegg: but for TY, we failed to set the wmf_contribution_tracking custom data because of hook
[22:15:44] <awight>	 yeah
[22:15:49] <ejegg>	 phooey
[22:16:01] <awight>	 wait, why did QC not fail...
[22:16:18] <ejegg>	 Is it saving with all the necessary data?
[22:16:30] <ejegg>	 ooh, I think that must be it
[22:17:15] <awight>	 ah
[22:17:46] * awight darkens, thinking about hooks which receive different input data depending on whim
[22:18:13] <ejegg>	 Well, contribution edits via UI send in all the data to the hook
[22:18:17] <awight>	 It's like they took the Drupal hook model and made it worse...
[22:18:18] <ejegg>	 got lucky on that one
[22:18:26] <awight>	 ejegg: woot!  ok
[22:26:42] <ejegg>	 awight: Was there a reason we turned off creating CiviMail records for TYs ?
[22:27:30] <awight>	 ejegg: the last I remember, we wanted to have a retention policy first?  But I don't know why we turned it off again... looking through logs for that discussion...
[22:28:00] <ejegg>	 oh, I'll find where they stopped in the civi activity logs
[22:28:26] <awight>	 good idea
[22:29:07] <awight>	 ejegg: https://wikitech.wikimedia.org/wiki/Server_Admin_Log#November_5
[22:29:39] <ejegg>	 huh
[22:29:55] <awight>	 I apparently hit the off switch, and logged it
[22:30:24] <ejegg>	 Yep, that's when they stop in civi
[22:31:08] <awight>	 http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-fundraising/20141105.txt
[22:31:11] <awight>	 fwiw
[22:31:13] <awight>	 haven't found the explanation yet :-/
[22:32:17] <awight>	 ejegg:  omg.  [20:30:24] <awight> ejegg: you mind if I turn off TY activity recording for a minute, to see if it's affecting performance
[22:32:22] <awight>	 sorry
[22:32:24] <ejegg>	 hehe
[22:32:30] <ejegg>	 so, was it?
[22:33:11] <ejegg>	 ohhhh.... you had plenty to think about that day
[22:33:12] <awight>	 [20:14:56] <awight> atgo: it's possible that some other things were going on, but the teal deer is that we currently aren't able to send thank-yous at normal speeds.
[22:33:15] <awight>	 donno
[22:33:37] <awight>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2145
[22:33:59] <awight>	 anyway, let's turn it on again and watch the job elapsed time...
[22:34:10] <ejegg>	 cool
[22:34:37] <ejegg>	 !log enabled CiviMail record creation for TY emails
[22:34:40] <morebots>	 Logged the message, Master
[22:35:08] <awight>	 ejegg: fyi the TY job is still off...
[22:35:22] <ejegg>	 oh right, you marked the folks we spammed?
[22:35:45] <awight>	 ejegg: yep, they're marked
[22:35:53] <ejegg>	 ok, turning the job back on
[22:36:30] <ejegg>	 !log enabled TY email sending
[22:36:32] <morebots>	 Logged the message, Master
[22:36:49] <ejegg>	 aargh
[22:38:15] <awight>	 ok
[22:38:18] <awight>	 let's use staging
[22:38:26] <ejegg>	 !log disabled TY email sending
[22:38:29] <morebots>	 Logged the message, Master
[22:38:38] <ejegg>	 awight: Yeah, lets.
[22:38:42] <awight>	 Thanks for hitting the switch so fast :)
[22:38:54] <ejegg>	 Only one email each for this batch
[22:39:06] <awight>	 ejegg: the only down side is a sort of huge one: staging is still not equipped to test any emaily things.
[22:39:16] <awight>	 we'll have to munge everyone's addresses for safety...
[22:39:43] <awight>	 meanwhile, I'll repeat the no_thank_you thing for this batch of donors :)
[22:40:46] <ejegg>	 thanks, awight!
[22:42:24] <awight>	 ejegg: ok, they're suppressed now. only 56 people, this time--nice reflexes :p
[22:42:33] <ejegg>	 :$
[22:42:43] <ejegg>	 CiviMail records may have bought us more time...
[22:43:17] <awight>	 yep
[22:43:26] <awight>	 but the cleanup is easy now that I have SQL to reuse :)
[22:43:57] <ejegg>	 thank you so very much for that
[22:44:09] <awight>	 It's a bad moon rising
[22:45:18] <awight>	 I had so much fail yesterday... one of the highlights was falling through a rotten plywood pigeoncrap hallway, trying to break into a friend's book store after "fixing" the front door lock.
[22:45:40] <ejegg>	 oof.  not hurt too bad, i hope?
[22:45:47] <awight>	 Another good one was getting boxed in at a parking lot-- and the perp left his keys in the driver-side door.
[22:45:55] <awight>	 Nah
[22:46:02] <ejegg>	 well, that was polite of him
[22:46:11] <grrrit-wm>	 (PS1) Ejegg: Quote date when checking for more recent contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176157
[22:46:14] <awight>	 mostly humorous, and indiana jonesesque
[22:47:49] <grrrit-wm>	 (CR) Awight: [C: -1] "Please use wmf_common_date_unix_to_sql to build the MySQL timestamp string." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176157 (owner: Ejegg)
[22:48:49] <AndyRussG>	 meganhernandez: I can keep an eye on any campaign tests you'd like to run now, I'll be here the rest of the day :)
[22:52:48] <grrrit-wm>	 (CR) Ejegg: "the Contribution object's receive_date seems to be formatted as a MySQL string already" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176157 (owner: Ejegg)
[22:53:45] <ejegg>	 awight: like '2014-11-26 20:59:48', right?
[22:53:50] <awight>	 mmmm ok
[22:54:27] <guillom>	 Hi
[22:54:41] <guillom>	 FYI: https://twitter.com/em4o/status/534873908219248640 "Donated to the wikipedia folks. This popup is still coming up. Argh!"
[22:54:49] <guillom>	 In case someone wants to respond
[22:54:50] <awight>	 ejegg: yah confirmed, thanks
[22:56:56] <awight>	 guillom: we're trying to lure conversation to here: https://meta.wikimedia.org/wiki/Talk:Fundraising
[22:56:58] <K4-713>	 guillom: Can you send that in an email to problemsdonating@wikimedia.org?
[22:57:00] <K4-713>	 ...ha.
[22:57:03] <awight>	 hehe
[22:57:10] <guillom>	 Make up your mind :P
[22:57:17] <awight>	 we're helpful --> over there! :)
[22:57:19] <K4-713>	 I think email is probably better for this one.
[22:57:24] <guillom>	 ok, sending now
[22:57:29] <K4-713>	 Thanks!
[22:57:34] <guillom>	 np
[23:01:37] <AndyRussG>	 Munich, hmm that's WMDE territory
[23:02:40] <AndyRussG>	 Haven't tested the donate hide cookie per se...
[23:03:24] <ejegg>	 AndyRussG: it was certainly hiding stuff for me while I was trying to test client-side choice outside of private browsing
[23:03:45] <ejegg>	 and sending the correct reason to recordImpression
[23:03:50] <AndyRussG>	 ejegg: OK, that's good to hear
[23:03:54] <AndyRussG>	 thanks :)
[23:04:51] <AndyRussG>	 Yea I'm sure I got stuff hiddent due to a "close"-reasoned hide cookie, don't suspect donate is different
[23:05:48] <awight>	 AndyRussG: maybe WMDE has hardcoded to the bannerController internals?
[23:06:31] <AndyRussG>	 awight: could be, could make JS die and then not hide properly?
[23:06:49] <awight>	 ooof that would break the rest of the site
[23:07:07] <AndyRussG>	 I dunno, would any banner code ever get run before we check for a hide cookie? tho I guess it could simply not be setting the hide cookie
[23:07:36] <AndyRussG>	 I tried to keep the internals stable, I think you can still even call the previous cookie methods no problem
[23:07:43] <AndyRussG>	 sorry I meant bucket methods
[23:08:51] * awight bites the bullet and actually donates to WMDE
[23:09:10] <AndyRussG>	 awight: whoa that's extreme debugging
[23:09:18] <AndyRussG>	 coulda just set the cookie :)
[23:15:04] <ejegg>	 awight: oooh, I had to change the ty landing page's img sources when I updated Special:HideBanners!
[23:16:03] <ejegg>	 But... we did that udp filter for hits on that with no 'reason=' and those all petered out after a while
[23:16:56] <AndyRussG>	 awight: ejegg: Don't see any js console errors from this: https://de.wikipedia.org/w/index.php?title=Wikipedia:Hauptseite&country=DE
[23:19:45] <awight>	 btw has anyone else been seeing this? "NS_ERROR_DOM_QUOTA_REACHED"
[23:20:02] <ejegg>	 awight: yep, stuffing local storage makes that happen
[23:20:13] <awight>	 hmm
[23:20:14] <AndyRussG>	 where?
[23:20:20] <ejegg>	 there's no good way to detect how close you are to the limit
[23:20:21] <awight>	 AndyRussG: just... all over wikipedia
[23:20:39] <AndyRussG>	 huh? Just visiting the site?
[23:20:46] <awight>	 yeah
[23:20:55] <AndyRussG>	 Hmmm
[23:20:58] <ejegg>	 AndyRussG: nothing to do with CN
[23:21:02] <AndyRussG>	 never seen such a beast
[23:21:16] <AndyRussG>	 Mmm
[23:21:26] <AndyRussG>	 I had been thinking maybe we shoulda used localstorage tho
[23:21:34] <ejegg>	 awight: I have to eat food with my dad soon-ish, but I'll be back on later
[23:22:00] <AndyRussG>	 BTW, the WMDE banner hides correctly with after I click on closing it
[23:22:03] <ejegg>	 Sending mail to myself locally works with the quote fix
[23:22:52] <awight>	 ejegg: ok, I'll enfire
[23:23:28] <ejegg>	 awight: wait, no, sorry
[23:23:40] <ejegg>	 i'm wrong
[23:23:47] <ejegg>	 different error, though.
[23:23:52] <awight>	 :) ok
[23:29:07] <AndyRussG>	 the DE fundraising banner looks fine... I don't see where they set the donate cookie tho
[23:31:56] <awight>	 :q
[23:32:07] <awight>	 vi fail
[23:37:08] <grrrit-wm>	 (PS2) Ejegg: Quote date when checking for more recent contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176157
[23:37:18] <AndyRussG>	 if vi don't succeed, try, try again
[23:37:28] <ejegg>	 OK, /now/ it's sending successfully locally
[23:37:41] <ejegg>	 and passing phpunit
[23:37:56] <ejegg>	 and not breaking manual contribution adds/edits
[23:38:55] <ejegg>	 K4-713: I'm going to have to do the dash stuff after a meal with my pops
[23:39:05] <awight>	 mmm.... ok I'll merge this, but in the future we should stick with the shared date formatting routines.  It was nasty dialing that code in.
[23:39:11] <awight>	 Lots of time zone issues in PHP.
[23:39:35] <K4-713>	 ejegg: No problem.
[23:39:47] <grrrit-wm>	 (CR) Awight: [C: 2] Quote date when checking for more recent contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176157 (owner: Ejegg)
[23:39:50] <grrrit-wm>	 (Merged) jenkins-bot: Quote date when checking for more recent contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176157 (owner: Ejegg)
[23:39:52] <ejegg>	 so, nastier still is that the date comes in differently in the hook arg and from the db
[23:40:07] <awight>	 I bet.
[23:40:10] <K4-713>	 ejegg: Do you need any CR or anything before the dash is doable?
[23:40:35] <K4-713>	 I've done surprisingly little review today, for being the CR Monster.
[23:40:38] <ejegg>	 K4-713: I still need to make some tweaks, unfortunately
[23:41:14] <K4-713>	 ejegg: No problem. I'll... not go do something foolish tonight, then. :p
[23:41:18] <K4-713>	 (at least not immediately)
[23:42:07] <grrrit-wm>	 (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/176177
[23:42:21] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/176177 (owner: Ejegg)
[23:42:32] <awight>	 whoa
[23:42:33] <grrrit-wm>	 (PS1) Awight: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/176178
[23:42:43] <grrrit-wm>	 (Abandoned) Awight: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/176178 (owner: Awight)
[23:42:57] <ejegg>	 go go speed racer
[23:43:21] * awight looks to K4-713 for understanding
[23:43:35] <awight>	 this guy is writing all my freaking code :p
[23:44:02] <ejegg>	 !log updated crm from 96f66e6b6c947c4e4c32c4a4a32dc940dc3b1d60 to 68703898b7ebfb2a038f307f17788739114806e4
[23:44:03] <awight>	 ejegg: if you... are still deploying, feel free to test live, but set the batch size to 1.
[23:44:07] <morebots>	 Logged the message, Master
[23:44:11] <awight>	 otherwise, I can do so.
[23:44:13] <K4-713>	 awight:  ...BWAHAHAH.
[23:44:14] <K4-713>	 sorry.
[23:44:24] <ejegg>	 yep, batch size=1 it is
[23:44:24] <awight>	 yeah.  I thought it would be like that
[23:44:27] <awight>	 k then
[23:45:25] <ejegg>	 !log set TY batch size=1
[23:45:28] <morebots>	 Logged the message, Master
[23:45:59] <ejegg>	 !log enabling TY mail send
[23:46:01] <morebots>	 Logged the message, Master
[23:46:31] <ejegg>	 OK, that worked!
[23:49:08] <ejegg>	 and wmf_donor row for the person we just thanked is still correct
[23:49:52] <ejegg>	 awight: think we can put the batch size back to normal?
[23:52:00] <awight>	 ejegg: mos def
[23:57:19] <ejegg>	 !log set TY batch size=700
[23:57:24] <morebots>	 Logged the message, Master