[00:14:03] (PS2) Ejegg: Add amount per second chart views [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175903 (owner: Ssmith) [00:19:16] (PS3) Ejegg: Add amount per second chart views [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175903 (owner: Ssmith) [00:26:42] (CR) Ejegg: [C: 2] "Gee grandma, what a big stylesheet you have! " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176030 (owner: Awight) [00:27:12] (Merged) jenkins-bot: Comment out Bootstrap glyphicons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176030 (owner: Awight) [00:33:13] (CR) Ejegg: [C: -1] "Please also delete the variable on Form.php line 39" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176037 (owner: Awight) [02:01:24] atgo: Hey. Want to help me re-enable campaigns? [02:01:27] :p [20:01:51] (CR) Ejegg: [C: 2] Move GC iframe css into code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176044 (owner: Awight) [20:02:20] (Merged) jenkins-bot: Move GC iframe css into code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176044 (owner: Awight) [20:12:28] (PS1) Ejegg: Add state and postal code to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/176514 [20:34:53] (PS4) Ejegg: Add amount per second chart views [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175903 (owner: Ssmith) [21:22:22] (PS3) Awight: remote unused stylepath cruft [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176037 [21:52:36] (PS5) Ejegg: Add amount per second chart views [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175903 (owner: Ssmith) [22:30:40] (CR) Awight: Add state and postal code to silverpop export (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/176514 (owner: Ejegg) [22:33:21] (PS2) Awight: Add state and postal code to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/176514 (owner: Ejegg) [22:35:11] (CR) Awight: [C: 2] "Looks good." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/176514 (owner: Ejegg) [22:35:14] (Merged) jenkins-bot: Add state and postal code to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/176514 (owner: Ejegg) [22:45:09] (CR) Awight: "n.b. this was already done on production, we're just merging for developers and historical interest." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/173768 (owner: Awight) [22:48:27] (CR) Ejegg: [C: 2] remote unused stylepath cruft [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176037 (owner: Awight) [22:48:57] (Merged) jenkins-bot: remote unused stylepath cruft [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176037 (owner: Awight) [22:57:30] * awight taps ejegg|away 's repeater [23:26:52] I'm here to complain about the annoying banners that cover the page content. [23:27:09] LOL [23:27:25] huh: please do give some feedback, http://bit.ly/1y9WUuL perhaps [23:28:10] awight: https://meta.wikimedia.org/wiki/Wikimedia_Forum#Fundraising_banner [23:30:00] "Hi Oliv0 and Arkanosis, Thank you for expressing your concerns. Using this type of banners is part of our new approach as they perform significantly better and hence we are able to show less banners to our readers. (The full screen banners are set to only show up once.) We are starting our English fundraising campaign this coming Monday, December 1, and will be using the same type of... [23:30:01] ...banners on English Wikipedia visible from the US, Canada, UK, Australia and NZ. We'll be posting information on the meta fundraising page later today to inform the community about the launch. Hopefully this will give some clarity on the topic. Thank you and kind regards, JRobell (WMF) (talk) 12:20, 26 November 2014 (UTC)" [23:30:22] huh: Thanks! I'm not part of the team that makes the banners, but what I hear is that there are changes being made, and I have no details about the changes. [23:31:14] awight: I just find them annoying (and I tend to browse logged-out), but if they only appear once, I guess that mostly solves the problem [23:31:31] unless people with cookies disabled have a nightmare of ads [23:31:41] huh: actually, it would be helpful if you could confirm the cookies-disabled behavior. [23:32:20] I've tried to flag that the reader might see infinite fullscreen banners, but there has been no independent double-checking of that. [23:33:05] what's the banner name? [23:33:11] oh, I guess it varies [23:33:33] I understand that the fix to do that, should be in the new banners. Again, that's not my department: We (fundraising tech) only get called in over there when they need extra debugging help or something. [23:33:46] huh: And, yeah: Banner name is going to vary possibly on the hour. [23:34:09] huh: this might be helpful: https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs?log=bannercontent [23:34:48] this looks like it might be it https://meta.wikimedia.org/w/index.php?title=Stewards_policy/ru&banner=B14_1117_enUS_mob_btn_lrg&uselang=en&force=1 [23:35:17] K4-713: was there an email saying that? [23:35:23] huh: that's a mobile banner [23:35:47] With cookies disabled, it seems to pop up on the majority of (but not all) page loads [23:35:53] awight: Yeah, and I'm pretty sure I saw it in one of the .js templates yesterday when I was poking around for something else. [23:36:07] K4-713: huh: yeah looks like the attempted fix is here: http://meta.wikimedia.org/wiki/MediaWiki:FR2014/Resources/ShowHideCheckFullscreen.js [23:36:08] Now, whether they are including the relevant template or not, is another issue. [23:36:10] but that might vary depending on what other targeted banners are activated and buckets; IDK [23:36:15] if ( navigator.cookieEnabled ) { [23:37:02] awight: Ah, yeah. Okay, so there was an issue where one of the .js templates was trying to do too much, so they broke out a bunch of stuff from one (included everywhere) to another one. [23:37:08] oh dear, I don't think that's supported by IE [23:37:17] It's entirely possible that not all template changes went everywhere, too. [23:37:22] Is that code actually used? [23:37:42] They almost certainly meant for it to be. [23:37:44] nvm it should be supported by IE [23:38:29] huh: It's used in, for example http://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B14_1129_5c_test_megjose_cookie [23:38:48] awight: if it's not supported, then you could add a test cookie and check for it e.g. https://stackoverflow.com/questions/8112634/jquery-detecting-cookies-enabled/8112653#8112653 [23:40:05] yeah, this looks good too, http://stackoverflow.com/questions/6125330/javascript-navigator-cookieenabled-browser-compatibility [23:40:39] huh: unfortunately, I'm not even involved in code review for the team writing the banner code [23:40:49] The best I can say is, we need to keep an eye on this as it's deployed. [23:42:15] awight: this one doesn't seem to check for cookies https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B14_113022_5c_fl_enUS [23:42:50] huh: agreed. It looks to my (uninformed) eye that they are testing a fix, but have not incorporated it into banners yet. [23:43:03] oh [23:44:04] it is in the latest banners - using http://meta.wikimedia.org/wiki/MediaWiki:FR2014/Resources/ShowHideCheckFullscreen.js [23:44:18] huh: http://meta.wikimedia.org/?banner=B14_1129_5c_test_megjose_cookie [23:44:35] the-wub: hi! I hope you're on Pacific time?? [23:44:55] I was assured we weren't using overlaid banners anymore, so haven't fixed those. maybe I should - but if people decide to use those then there will be bigger problems >:( [23:45:07] awight: yep :) [23:45:34] the-wub: I haven't seen anything concrete about that, so glad to hear. [23:45:43] the-wub: Yeah, that's news to me too. [23:46:25] hehe, I like the culture hack in http://meta.wikimedia.org/?banner=B14_1129_5c_test_megjose_cookie [23:46:38] It's most of the screen, but does not obscure content :) brilliant! [23:46:49] Do more people actually click annoying popups than "Please read: A personal appeal from Wikipedia founder Jimmy Wales"? [23:47:01] Apparently. [23:47:03] baahaha that was so annoying [23:47:06] Like, a lot more. [23:47:32] yeah, I'm not exactly keen on the size of these new ones either :( [23:48:23] I try not to have opinions on these things, since I'm about as far removed from design as one can get. [23:48:41] But... they do seem almost comically large. [23:48:43] the-wub: I think there was a chink in the opposition's armor--it was unclear whether the resistance was due to obscuring content, or looking greedy. This certainly begs the question! [23:49:36] For some people, obscuring content is definitely the dealbreaker. It's hard to tell what the breakdown is on that, though. [23:49:54] don't blame me. I was somewhere over the Atlantic when this new one was being made [23:50:07] That's what they all say? :) [23:50:08] Yeah it's interesting. My personal feelings are so far removed from what seems to be the editor consensus... [23:50:21] Same here. [23:50:38] So, you know, we should try to get that feedback earlier. [23:50:44] :) [23:50:49] (And, not because there was a bug in CN...) [23:51:22] There is some overlap between those two objections, though. The disconnect is definitely between the need for this massive fundraiser, and all the unpaid work that editors have funneled into the project. [23:51:38] One of them, I'd argue. There seem to be several. [23:51:45] And some are totally orthogonal to others. [23:52:08] It would be nice if the discussion were about the real issues, and not just the symptoms (big banner) [23:52:09] * K4-713 sighs [23:52:29] I think part of the problem is that nobody wants to think about this stuff unless it's in their way. [23:52:34] hehe. [23:52:35] Icky money. [23:52:43] * awight spits over the railing and rocks chair vigorously [23:53:36] yeah, I totally agree there are bigger issues to discuss. But there's been kind of an urgent need to at least partially resolve the 'big banners' thing before December [23:53:43] yep [23:53:52] +1 [23:53:55] The phrase "Backed in to a corner" keeps crossing my mind. [23:54:18] like K4-713 just said, too bad there was no light on us until a week ago. [23:54:54] Depressing. [23:55:21] * awight lifts cloak against the rising sun [23:56:08] Alright, I need to... go do People Stuff. [23:56:25] Ping if anything comes up. It just might take a minute for me to see it. [23:58:25] anyway, back to more technical matters. awight I saw that stackoverflow link about cookieEnabled. documentation is pretty poor on this, but yeah I think it's safest to actually test setting a cookie too [23:58:32] will do that now [23:59:07] the-wub: yah I think the SO answer was simpler, it was to check that document.cookie exists at all... [23:59:18] just cos .cookieEnabled is not in the official web API