[00:00:18] <the-wub>	 it's the 2nd answer there that concerns me more. if that's true then .cookieEnabled is stupid and broken
[00:00:28] <the-wub>	 yay javascript!
[00:01:19] <awight>	 the-wub: oh, wow.
[00:01:35] <awight>	 yep, good call.
[00:42:02] <huh>	 http://www.gossamer-threads.com/lists/wiki/foundation/532701
[03:59:11] <grrrit-wm>	 (CR) Awight: [C: 2] "Haven't tested myself." (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175903 (owner: Ssmith)
[04:00:35] <grrrit-wm>	 (CR) Awight: [C: 2] Add distance-to-goal chart views to BE board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175801 (owner: Ssmith)
[04:05:10] <grrrit-wm>	 (CR) Awight: [C: 2] Add totals earned chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175742 (owner: Ssmith)
[04:06:09] <grrrit-wm>	 (CR) Awight: [C: 2] Add board stats piece [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175161 (owner: Ssmith)
[04:06:58] <grrrit-wm>	 (CR) Awight: [C: 2] Big English header piece [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175055 (owner: Ssmith)
[04:07:40] <grrrit-wm>	 (Merged) jenkins-bot: Add distance-to-goal chart views to BE board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175801 (owner: Ssmith)
[04:07:45] <grrrit-wm>	 (Merged) jenkins-bot: Add amount per second chart views [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175903 (owner: Ssmith)
[04:31:48] <K4-713>	 awight: You look busy.
[04:34:24] <awight>	 K4-713: don't be silly.
[04:34:32] <K4-713>	 Try and stop me.
[04:34:38] <K4-713>	 :p
[04:34:41] <awight>	 I don't know what happened, maybe some stuff was backlogged in gerrit.
[04:34:49] <K4-713>	 Huh.
[04:34:52] <awight>	 it came loose and dumped all over my hea
[04:34:53] <awight>	 head
[04:34:58] <awight>	 I had to swat it away.
[04:35:01] <K4-713>	 Curious.
[04:35:15] <awight>	 Don't worry--I didn't actually test the code to see if it works or anything.
[04:35:40] <K4-713>	 Well, that's a relief!
[04:36:05] <awight>	 ejegg|away was just being overly scrupulous about a third key-turner, afaict...  He made some small changes to pizzzacat's work and didn't want to self-merge, I think.
[04:36:17] * awight continues pointing fingers elsewhere
[04:36:25] <K4-713>	 Sounds plausible.
[04:36:28] <K4-713>	 Hm.
[04:36:50] <K4-713>	 The thought occurs, that the last thing I heard was that people were thinking about adjusting the schedule.
[04:36:59] <K4-713>	 I... think I'll find out what happened with that.
[04:37:00] <awight>	 of Big English?
[04:37:12] <awight>	 must be.
[04:37:25] <K4-713>	 I don't want to [stay awake for|wake up for] 6am if nothing's going to happen.
[04:38:38] <awight>	 It's at least pushed back until Tuesday, that much I heard concretely.
[04:39:07] <K4-713>	 Confirmed.
[04:39:25] <awight>	 ok no 6am nothing then.
[04:39:30] <awight>	 ?
[04:39:42] <K4-713>	 Well, maybe small 6am something. But that's, you know: Standard.
[04:40:02] <awight>	 I think I mentioned that fwiw, I'm planning to work 40hr/wk for the month
[04:40:06] <awight>	 no more, no less :)
[04:40:19] <K4-713>	 Did you set something up to go *ding*?
[04:40:24] * awight looks around for team players to throw under the bus :)
[04:40:35] <awight>	 K4-713: the extremely expensive machine to go *ding*?
[04:40:43] <K4-713>	 That's the one.
[04:42:28] <K4-713>	 Er. Must go poke laundry.
[04:45:58] <awight>	 no, I'll set that up if the hospital administrator comes, though.
[04:47:16] <K4-713>	 :)
[05:13:58] <K4-713>	 awight: So, all that work you're totally not doing: Need anything? :)
[05:16:26] <K4-713>	 If so: Too bad. I don't want the machine to go *ding* too early. (ha)
[18:15:06] <awight>	 Is all the fun happening upstairs?
[18:17:06] <atgo>	 awight:  in 37
[18:17:08] <atgo>	 come join!
[18:17:12] <awight>	 ohboy
[18:17:12] <awight>	 thx
[18:17:37] <atgo>	 there's a relevant question for you
[18:37:07] <awight>	 K4-713: what did u want?  I should make a card for the hide impression thing?
[18:39:31] <K4-713>	 awight: I can do it.
[18:39:39] <K4-713>	 At least, I'll make the stub.
[18:41:30] <awight>	 thx!
[18:45:34] <atgo>	 hey ccogdill which is the card about the duplicate settlements/
[18:45:38] <atgo>	 ahh found
[18:45:41] <ccogdill>	 :)
[18:45:55] <atgo>	 but i do have a new way to make a view for all your cards!
[18:46:39] <atgo>	 awight: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2209
[18:50:12] <grrrit-wm>	 (PS1) Awight: Deprecate old GeoIP HEAD thing [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176705
[19:14:54] <atgo_>	 pizzzacat: how much more hassle is it to change add'l logos while you're doing logo shtuff?
[19:16:11] <pizzzacat>	 atgo_ pretty simple!
[19:16:16] <atgo>	 cool :)
[19:16:21] <pizzzacat>	 what are you thinking?
[19:16:25] <atgo>	 i'm going to add one more to ze sprint... but like the france one lmk if it's a pain
[19:16:32] <atgo>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2208
[19:16:37] <atgo>	 new branding for visa
[19:16:50] <pizzzacat>	 oh yeah, not a problem.
[19:16:52] <atgo>	 cool
[19:17:29] <K4-713>	 meganhernandez: Are you ready for the deploy of the banner impression hidecount fix?
[19:17:37] <K4-713>	 My finger is on the button.
[19:17:55] <meganhernandez>	 ready!
[19:18:18] <K4-713>	 :)
[19:18:46] <K4-713>	 LOL: Server confirmation code for that one was "mwjk".
[19:19:09] <K4-713>	 !log updated DjangoBannerStats to 3db799dc8705c728c
[19:19:12] <morebots>	 Logged the message, Master
[19:19:19] <K4-713>	 meganhernandez: Done.
[19:19:25] <K4-713>	 Monitoring...
[19:19:31] <awight>	 K4-713: that was supposed to be delivered tomorrow, when Matt visits.
[19:19:43] <K4-713>	 haha
[19:19:52] <K4-713>	 Mediawiki, Matt... either way.
[19:21:41] <K4-713>	 Wow, we're only doing on the 15?
[19:22:05] <awight>	 wat?
[19:22:11] <K4-713>	 imp loader.
[19:22:15] <awight>	 oh man.
[19:22:20] <awight>	 it's ghastly
[19:22:25] <K4-713>	 I guess it's probably based on file delivery...
[19:22:34] <awight>	 I want that repo to die under a house
[19:22:35] <K4-713>	 So, running the job early probably won't tell me anything.
[19:22:47] <K4-713>	 awight: Are you going to steal its shoes, too?
[19:22:52] <K4-713>	 Because that's probably a good idea.
[19:22:55] <awight>	 slippers
[19:22:58] <K4-713>	 :D
[19:22:59] <awight>	 cos they click real nice
[19:23:43] <K4-713>	 meganhernandez: Okay, a banner loader job ran with the new code.
[19:23:51] <K4-713>	 You should have things to check now.
[19:23:55] <awight>	 ewulczyn: ^^ :)
[19:25:05] <K4-713>	 "IGNORED IMPRESSION BECAUSE hideempty: 43408"
[19:25:08] <K4-713>	 looks promising...
[19:25:29] <awight>	 woot
[19:25:39] <K4-713>	 Though, the one before that had stuff in it, too.
[19:25:51] * K4-713 frowns
[19:26:10] <K4-713>	 "IGNORED IMPRESSION BECAUSE hidecookie: 0"
[19:26:12] <K4-713>	 :/
[19:27:03] <K4-713>	 Oh, but close, donate, and other are populated now.
[19:27:19] <K4-713>	 Actually, I think that might make the sense.
[19:27:41] * K4-713 goes to look what "other" means
[19:28:16] <Nemo_bis>	 ou
[19:28:38] <awight>	 grr.  K4-713 "other" means we haven't updated the freaking code to match arbitrary strings sent by the banner.  No longer cool.
[19:28:49] <K4-713>	 There's a lot in there.
[19:29:01] <awight>	 INO
[19:29:28] <awight>	 If we keep this code alive, we need to just sanitize and store whatever was in there.
[19:30:28] <K4-713>	 You know what would be neat?
[19:30:43] <K4-713>	 Aaaall the end counts of all the jobs, in fredge.
[19:30:50] * K4-713 looks wistful
[19:49:02] <awight>	 K4-713: a simple thing I don't remember: we still use LandingCheck?
[19:49:10] <awight>	 (what are subscriptions :)
[19:49:22] <K4-713>	 It's like a magazine... :p
[19:49:30] <awight>	 d'oh
[19:49:31] <K4-713>	 Ah, funny story. I'm not sure.
[19:50:44] <grrrit-wm>	 (PS1) Awight: Use the GeoIP cookie if available [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/176726
[19:50:51] <K4-713>	 awight: I *think* we do?
[19:51:08] <K4-713>	 Unless somebody made a serious push to roll it all in to FLP...
[19:51:09] <awight>	 well I feel a little better?
[19:51:23] <K4-713>	 the-wub: Are we still using LandingCheck on donate wiki?
[19:53:21] <awight>	 meh it's ok, I wrote the patch anyway.
[19:54:51] <the-wub>	 K4-713: I don't think so. we still use it on wikimediafoundation.org for things like the Privacy policy though
[19:55:00] <K4-713>	 awight: ^^
[19:55:40] <K4-713>	 the-wub: Thanks. I thought FLP sort of ate everything it needed to on donate.
[19:55:52] <K4-713>	 Oh, but wait.
[19:55:56] <K4-713>	 Let me check one more thing...
[19:56:46] <ejegg>	 patch looks good.  Want me to hold off merging ?
[19:57:06] <K4-713>	 I'm good.
[19:57:24] <grrrit-wm>	 (CR) Ejegg: [C: 2] Use the GeoIP cookie if available [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/176726 (owner: Awight)
[19:57:24] <K4-713>	 Just wanted to make sure that payments didn't have any old refs.
[19:59:23] <grrrit-wm>	 (PS1) Awight: Country URL param will still take precedence [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/176728
[19:59:27] <awight>	 ejegg: oops.  ^^
[20:00:11] <awight>	 ejegg: here's another one, https://gerrit.wikimedia.org/r/176727
[20:00:29] <ejegg>	 Ah, guess we'd want to keep that overridable
[20:00:41] <awight>	 I was um overreacting
[20:00:57] <K4-713>	 heh
[20:01:35] <K4-713>	 Careful, or I'll make us all switch to decaf.
[20:01:58] <grrrit-wm>	 (Merged) jenkins-bot: Use the GeoIP cookie if available [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/176726 (owner: Awight)
[20:03:40] <grrrit-wm>	 (CR) Ejegg: [C: 2] Country URL param will still take precedence [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/176728 (owner: Awight)
[20:04:24] <K4-713>	 awight, ejegg: Hey, so, I could swear that I saw changes go by for https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1957 that aren't in the card. Am I crazy?
[20:04:43] <ejegg>	 Lemme take a look
[20:06:03] <ejegg>	 K4-713: the css attached to the card targets elements in the iframe
[20:06:25] <atgo>	 K4-713: awight pizzzacat ejegg lunch is in the conference room!
[20:06:32] <ejegg>	 the changes in the commit make the elements we host match the look
[20:06:46] <ejegg>	 but the selectors just need to be a little different
[20:06:48] <K4-713>	 ejegg: For some reason, I thought we added the .css to payments instead of leaving it where it was.
[20:06:55] <K4-713>	 ...more or less.
[20:07:09] <ejegg>	 oh right, I should rebase this on top of awight's commit!
[20:07:14] <ejegg>	 and add that stuff
[20:07:22] <ejegg>	 ok, doing so
[20:07:32] <K4-713>	 Yeah, that one makes me a lot happier, because I can deploy all at once and it's... not a 2-part thing.
[20:07:49] <K4-713>	 I thought that happened, and it wasn't just a nice dream I had. :)
[20:08:06] <ejegg>	 well, this time it still will be, since we need to change to path in the GC console.
[20:08:11] <ejegg>	 but next time it'll be one step!
[20:08:26] <K4-713>	 Aw, okay.
[20:08:27] <awight>	 yeah, and we need to try this today if every :)
[20:08:28] <awight>	 ever
[20:08:35] <K4-713>	 I guess I should try to get my creds...
[20:08:42] <awight>	 It turns out. :(
[20:08:44] <awight>	 it's not in the console
[20:08:53] <awight>	 PPena gave me superuser, not in there at all.
[20:09:02] <awight>	 We have to call GC and rattle sabers
[20:09:12] <awight>	 you don't take the preztel.  Binky gives you the pretzel.
[20:09:16] <K4-713>	 That makes a clean deploy somewhat problematic.
[20:09:27] <awight>	 We can have them do the test skin first.
[20:09:29] <awight>	 can + should.
[20:09:30] <ejegg>	 We can still update the foundationwiki css
[20:09:37] <awight>	 I already emailed a request, nobody wrote back yet.
[20:09:47] <K4-713>	 Did we even have the RTL before?
[20:09:53] <ejegg>	 nope
[20:09:54] <awight>	 it was a second file :(
[20:09:56] <K4-713>	 k
[20:09:58] <awight>	 so, sort of
[20:10:05] <K4-713>	 awight: email subject?
[20:10:22] <K4-713>	 wait, nvm. I got it.
[20:10:32] <awight>	 yep. Testing CSS for hosted payments
[20:11:08] <awight>	 ejegg: if you can knock this one out, too... https://gerrit.wikimedia.org/r/176727
[20:11:53] <K4-713>	 awight, ejegg: Looks like I should deploy those patches in 1957 before they get to them....  True or false?
[20:12:16] <awight>	 K4-713: true!
[20:12:18] <ejegg>	 K4-713: about to update
[20:12:38] <K4-713>	 awight: Okay. It looked strange, you see, because the links you provided to go a whitescreen.
[20:12:43] * K4-713 squints
[20:12:45] <awight>	 wat
[20:13:07] <K4-713>	 Hilarioualy, a whitescreen with a geoip lookup.
[20:13:18] <K4-713>	 I'm dying.
[20:13:21] <awight>	 WAT
[20:13:25] <awight>	 I don't get whitescreens
[20:14:22] <grrrit-wm>	 (PS2) Ejegg: Update input and select styling for GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/174617
[20:25:17] <K4-713>	 the-wub: Hey, about https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1957 : It's not entirely clear what (if anything) needs to come out of those css files on foundationwiki when I do this deploy.
[20:28:13] <the-wub>	 K4-713: huh. I had no idea those pages on foundationwiki even existed
[20:28:58] <K4-713>	 the-wub: Yeah, that's where it's coming from now, I guess.
[20:29:20] <K4-713>	 So, when I update this on payments, I need to hit the button on foundation wiki too.
[20:29:42] <K4-713>	 Do you want all the old stuff to be replaced by the new changes?
[20:30:00] <the-wub>	 can I come over and talk to you about it?
[20:30:34] <K4-713>	 yes
[20:31:25] <K4-713>	 ...I just psyched myself out so completely.
[20:31:27] <K4-713>	 Wow.
[20:31:38] <ejegg>	 K4-713, the-wub : buncha stuff in there to definitely keep, like hiding instructions and transparent background
[20:31:42] <K4-713>	 The reason we're not seeing a thing from WP, is because we're not running any.
[20:31:48] * K4-713 switches self to decaf
[20:31:59] <atgo>	 haha K4-713 :P
[20:35:27] <awight>	 K4-713: ejegg: fyi I have a deployment window for DonationInterface stuff at 14:00 PST
[20:35:37] <awight>	 oops, DI and donatewiki stuff.
[20:45:46] <awight>	 atgo: u got a next task for me?
[20:47:56] <atgo>	 awight: check out the sprint? everything is there in priority order. i think pizzzacat1 has already grabbed 2132
[20:48:04] <awight>	 okdoke
[20:48:07] <atgo>	 there's also a ton of stuff PD
[20:49:45] <awight>	 ewulczyn: have you had a chance to look at https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2175 ?
[20:55:18] <grrrit-wm>	 (CR) Katie Horn: [C: -1] "Fundamental misunderstanding. Sorting it out..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/174617 (owner: Ejegg)
[20:58:13] <grrrit-wm>	 (PS1) Katie Horn: Merge branch 'master' into deploy [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/176743
[20:58:38] <grrrit-wm>	 (CR) Katie Horn: [C: 2 V: 2] "+2 for deploy" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/176743 (owner: Katie Horn)
[20:59:30] <awight>	 K4-713: when you can make time to entertain the team :), I'm looking for that ldsmag copycat fundraising banner.  It was soo good.
[20:59:40] <awight>	 But not in my email.
[21:01:32] <atgo>	 tech.. standup?
[21:02:07] <K4-713>	 in the middle of a deploy...
[21:06:22] <K4-713>	 !log updated payments to 00415dd54bec2d4cf0a
[21:06:26] <morebots>	 Logged the message, Master
[21:08:29] <awight>	 K4-713: woohoo!  The new CSS is live.
[21:08:40] <awight>	 I'm sad about their RTL answer, thjough
[21:10:00] <K4-713>	 I'm sad about a lot of things right now.
[21:10:04] <K4-713>	 Like, really a lot.
[21:11:33] <K4-713>	 But, let me load this thing up on staging and see what's happening.
[21:15:43] <atgo>	 awight: can you add an estimate to that card?
[21:16:25] <awight>	 atgo: the LocalisationUpdate card?  No
[21:16:30] <awight>	 cos it's not my mess :)
[21:16:34] <atgo>	 no the spike
[21:16:41] <atgo>	 WP audit
[21:17:13] <atgo>	 pizzzacat1: i'm dragging the logo update cards into "in dev"
[21:18:01] <pizzzacat>	 ah thanks atgo
[21:18:27] <awight>	 atgo: ok sure
[21:23:02] <K4-713>	 pizzzacat: Look for "@select_country" in the templates.
[21:23:46] <pizzzacat>	 ok, will take a look next
[21:25:30] <K4-713>	 It's sort of everywhere.
[21:25:47] <K4-713>	 pizzzacat: In fact, I'm not entirely sure what makes it not show up.
[21:26:09] <grrrit-wm>	 (PS1) Ssmith: Add new forms for WorlPay - Big English countries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176791
[21:26:10] <K4-713>	 ...but I suddenly have a theory.
[21:26:26] <pizzzacat>	 "WorlPay"
[21:26:38] <K4-713>	 GRARLpay.
[21:26:45] <pizzzacat>	 did I mention I was the 5th grade spelling bee champion
[21:26:51] <pizzzacat>	 did I ever mention that??
[21:26:56] <pizzzacat>	 I don't think I did
[21:27:02] <awight>	 it's on your resume.
[21:27:09] <pizzzacat>	 true
[21:27:26] <awight>	 want to write some documentation :p
[21:27:33] <pizzzacat>	 what is your theory K4-713?
[21:27:48] <K4-713>	 Buh.
[21:28:29] <K4-713>	 Hurrrrrgh...
[21:28:30] <K4-713>	 Okay.
[21:28:49] <K4-713>	 It's got something to do with what happens when the "Personal Information" templates kick in and override things
[21:29:15] <K4-713>	 ...almost sure.
[21:29:20] <K4-713>	 default.html has it.
[21:29:32] <K4-713>	 US.html does not.
[21:30:08] <awight>	 Can we just delete that?
[21:30:17] <K4-713>	 awight: I think so.
[21:30:36] <K4-713>	 My search is giving a seriously annoying number of false positives, from the _old subdirectory.
[21:30:44] <K4-713>	 But, it's in default.
[21:30:55] <K4-713>	 So, if RapidHTML thinks you don't have a language...
[21:31:00] <K4-713>	 Or, country.
[21:31:07] <K4-713>	 Not language. Language has nothing to do with it.
[21:31:21] <K4-713>	 Let me see what RapidHTML is looking at.
[21:31:23] <pizzzacat>	 so does this mean that we should add "hidden" to the default template?
[21:31:31] * K4-713 guesses "countrycode" instead of "country"
[21:31:35] <pizzzacat>	 or will that override things I don't know about
[21:31:37] <K4-713>	 pizzzacat: Nah.
[21:31:42] <awight>	 -:-
[21:31:47] <K4-713>	 I think it's grabbing the default when it shouldn't be.
[21:31:53] <pizzzacat>	 oh I see.
[21:32:27] <awight>	 K4-713: "countrycode" is definitely not a thing.  "currencycode" does exist
[21:33:01] <K4-713>	 "found 21 matches of "countrycode" in 5 files"
[21:33:25] <K4-713>	 double-checking that... looks like 3rd party API stuff.
[21:33:48] <K4-713>	 Okay, phew.
[21:36:14] <K4-713>	 Actually, you know what?
[21:36:26] <K4-713>	 I take it all back about it loading the default at the wrong time.
[21:36:40] <K4-713>	 There are, like... six overrides.
[21:36:43] <K4-713>	 That's it.
[21:37:03] <K4-713>	 So, let's whack it from the default.
[21:40:31] <pizzzacat2>	 ok sorry, was afk a second
[21:40:36] <K4-713>	 No worries.
[21:40:39] <K4-713>	 I'll... irl
[21:40:54] <marktraceur>	 #remotefriendly :P
[21:41:11] <marktraceur>	 (just kidding, you guys are amazing)
[21:41:56] <K4-713>	 Everybody is HERE.
[21:41:59] <K4-713>	 EVERYBODY.
[21:42:02] <K4-713>	 :p
[21:42:19] <K4-713>	 Well... my team, anyway.
[21:42:53] <marktraceur>	 300 points.
[21:42:55] <grrrit-wm>	 (PS1) Ssmith: Fix unwanted display of country dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798
[21:42:58] <K4-713>	 haha
[21:42:58] <marktraceur>	 Out of, like, 10.
[21:42:59] <K4-713>	 Woah.
[21:43:08] <marktraceur>	 K4-713: Consider the other contestants.
[21:43:13] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Fix unwanted display of country dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith)
[21:43:19] <marktraceur>	 Try finding a designer. :)
[21:43:34] <marktraceur>	 OK, bad timing, violetto is actually in the design channel, today is a good day.
[21:43:39] <K4-713>	 Hargh.
[21:43:43] <K4-713>	 I don't do banners.
[21:45:45] <K4-713>	 Wow. We're running something, aren't we?
[21:47:22] <marktraceur>	 K4-713: It would seem so
[21:49:39] <K4-713>	 the-wub: So, I have something weird to show you about the GC iframe.
[21:50:04] <K4-713>	 They've made the changes to staging, and it's pulling in the right thing... but everything looks exactly the same.
[22:24:15] <awight>	 the-wub: K4-713: hey, I'm looking at https://donate.wikimedia.org/w/index.php?title=MediaWiki:Donate_interface-informationsharing after my deployment and it hasn't moved.
[22:24:44] <awight>	 I see that it is correctly displaying the current i18n text in gateway_common/interface/i18n/en.json however
[22:24:58] <awight>	 Which makes me think, the message was never updated??
[22:25:05] <awight>	 that's crazy.
[22:35:38] <ejegg>	 awight: I think I need to mess with CRM core.  I'd like to call the civicrm_post hook with a new op 'merge' to let modules run stuff after a contact merge is complete.
[22:35:53] <awight>	 ejegg: I think that exists
[22:35:57] <ejegg>	 the civicrm_merge hook does nothing like what I need
[22:35:59] <awight>	 ah
[22:36:08] <awight>	 ejegg: u should coordinate with upstream :-/
[22:36:16] <ejegg>	 word
[22:36:19] <awight>	 #civicrm
[22:37:39] <awight>	 ejegg: or a ticket at http://issues.civicrm.org/ is probably more durable
[22:38:09] <ejegg>	 awight: cool.  I'll see if it exists in 4.5/trunk
[23:07:39] <grrrit-wm>	 (CR) Awight: "The tests need to be fixed..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith)
[23:13:26] <grrrit-wm>	 (CR) Awight: [C: 2] "Sorry it has to be this way." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176791 (owner: Ssmith)
[23:13:47] <grrrit-wm>	 (Merged) jenkins-bot: Add new forms for WorlPay - Big English countries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176791 (owner: Ssmith)
[23:32:01] <awight>	 Well... I wanted to fix the tests in https://gerrit.wikimedia.org/r/#/c/176798/ but cannot get PHPUnit working for the payments checkout
[23:33:38] <awight>	 nvm.  Testing using mw-core origin/master
[23:35:08] <grrrit-wm>	 (PS1) Awight: reintroduce country field as a hidden input [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176832
[23:35:26] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] reintroduce country field as a hidden input [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176832 (owner: Awight)
[23:44:05] <awight>	 K4-713: should we have a country dropdown for any of the other gateways?
[23:53:11] <K4-713>	 awight: Some of the payment types handle it correctly.
[23:53:34] <grrrit-wm>	 (PS2) Awight: reintroduce country field as a hidden input [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176832
[23:53:35] <K4-713>	 Or, at least, they did at one point.
[23:53:38] <awight>	 K4-713: yeah I can't watch :)
[23:53:49] <K4-713>	 awight: No, you totally can.
[23:53:50] <awight>	 I got it close enuf...
[23:54:14] <K4-713>	 There was a thing we tried to do in there, once...
[23:54:21] <K4-713>	 ...resubmit the form on change.
[23:54:35] <K4-713>	 I don't know why that either got reverted, or failed to happen.
[23:54:46] <awight>	 is like a stalactite-stalagmite pair
[23:54:55] <awight>	 making me claustrophobic
[23:55:09] <K4-713>	 awight: I think the word for that is "column".
[23:55:09] <awight>	 I think we should have that.
[23:55:23] <awight>	 err not that but that !-2
[23:55:35] <K4-713>	 Yeah, I always thought...
[23:55:53] <awight>	 We totally do have javascript available
[23:56:04] <awight>	 Sigh, maybe this isn't the time, again, though.
[23:56:23] <K4-713>	 It's like a really slow game of whack-a-mole.
[23:56:59] <grrrit-wm>	 (PS2) Awight: Fix unwanted display of country dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith)
[23:57:19] <K4-713>	 Hey, so...
[23:57:23] <K4-713>	 ...who's deploying the dash?
[23:58:21] <awight>	 http://www.txgenweb.org/postcards/texas/TexasCrickets.jpg
[23:58:35] <K4-713>	 Right?
[23:58:37] <awight>	 quiet buggers
[23:58:39] <K4-713>	 I heard that too.
[23:58:51] <K4-713>	 ejegg: ^^
[23:58:53] <awight>	 um I'd like to, cos there is some deployment voodoo I need to acquire
[23:59:00] <K4-713>	 You may already have been nominated.
[23:59:09] <K4-713>	 orly
[23:59:17] <grrrit-wm>	 (Abandoned) Awight: reintroduce country field as a hidden input [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176832 (owner: Awight)
[23:59:31] <K4-713>	 awight: Well, if you're accumulating voodoo, be my guest.
[23:59:31] <grrrit-wm>	 (PS3) Awight: Fix unwanted display of country dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith)
[23:59:43] <awight>	 ejegg: K4-713: btw this needs a third key-turn, https://gerrit.wikimedia.org/r/#/c/176798