[00:00:24] ejegg: u wanna train me in dash deployment? [00:00:24] looking [00:00:27] thx! [00:01:37] Wouldn't it be neat, if RapidHTML looked for required nodes and added those not present in the template as hidd... [00:01:39] awight: sure [00:01:41] ...I'll shut up now. [00:01:45] ejegg: n.b. I did not deploy the SilverPop thing yet, either. [00:01:56] K4-713: who do you work for :p [00:02:12] evil alien technology... [00:02:29] awight: re: dash deployment. We stopped checking the minified version into the master branch [00:02:45] oh good [00:02:53] and I assume it can't dynamically generate that stuff? [00:02:59] So for deploy we'll need to run gulp and create the dist folder [00:03:03] k [00:03:15] correct, gulp actually requires a newer version of node than we have on prod [00:03:19] ejegg: is this in README.md ? [00:03:30] Nope, guess that's a good place for it though! [00:03:40] Can you guys document your voodoo somewhere? [00:03:41] Sorry, I could have just checked. Adding now. [00:03:47] K4-713: see ^^ :) [00:04:02] :p [00:04:45] * K4-713 copies chatlogs into documentation carelessly [00:05:37] (PS1) Ejegg: Add missing css to gulpfile [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176839 [00:06:02] awight: oops, missed a .css [00:06:05] sure. [00:06:16] ejegg: so I need nodejs 0.10 to run gulp? [00:06:34] yeah, and 0.8.2 to run dash :P [00:06:35] (CR) Awight: [C: 2] Add missing css to gulpfile [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176839 (owner: Ejegg) [00:06:37] ok [00:06:48] (Merged) jenkins-bot: Add missing css to gulpfile [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176839 (owner: Ejegg) [00:08:33] ejegg: thanks for the NVM recommendation! [00:08:58] awight: oh right, that thing! [00:10:21] argh [00:10:42] que? [00:10:55] I just found something terrible from the past, in the hidden form fields. [00:11:05] hehehe [00:11:21] Actually, several things. [00:11:26] Lemme just share that I had a 800 line patch I almost submitted, about that. [00:11:37] Hidden things? [00:11:39] and decided to just forget it, keep the scope down. [00:11:46] not the hidden ones, in my case. [00:11:50] Creepy hidden things. [00:11:57] just... multiple copies of form generation routines. [00:12:15] Oddly, 'country' isn't one of them. [00:12:30] 'twas... [00:12:38] Form.php [00:12:44] and RapidHtml.php [00:12:57] Ah. So, usually, we group all the hidden at the bottom. [00:13:02] I tugged lightly on that thread and found some crazy things. [00:13:05] So they're all in the same place. [00:13:10] yes that sounds good [00:13:22] also like we'd need an actual templating engine [00:13:31] [00:13:34] nooo [00:13:37] I think I did that. [00:13:39] That TOTALLY doesn't sound ominous. [00:14:06] I blame... that Italo Calvino guy. [00:14:40] ejegg: node node_modules/gulp/bin/gulp.js ? [00:15:32] nevermind, same thing if I "npm install -g gulp; gulp" [00:16:35] k, it's looking healthier now. [00:16:41] ejegg: should I expect to see js errors? [00:16:50] e.g. /home/adamw/work/dash/src/components/home/home.js: line 1, col 1, 'define' is not defined. [00:19:19] awight: yeah, we should fix those at some point [00:19:54] ok, but they don't block anything. ? [00:20:12] I guess "error" can mean different things :) [00:21:48] ejegg: are we using the deployment branch? It seems like a *lot* has happened [00:22:00] back to Oct 27 [00:22:54] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176843 [00:23:03] (CR) Katie Horn: [C: -1] "One inline comment about deleting code that we will probably need later." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith) [00:23:04] awight: Yep, there's a lot to deploy! [00:23:08] k then [00:25:28] (PS4) Awight: Fix unwanted display of country dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith) [00:25:40] (CR) Awight: Fix unwanted display of country dropdown (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith) [00:28:15] (CR) Katie Horn: [C: 2] Fix unwanted display of country dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith) [00:28:31] K4-713: nice GC email [00:28:33] i see what you did there [00:28:36] :D [00:28:37] (Merged) jenkins-bot: Fix unwanted display of country dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176798 (owner: Ssmith) [00:28:54] atgo: I have to get my fun somewhere. [00:29:01] :P [00:29:02] ejegg: Hey, I'm getting some async fail if you wanna see. [00:30:14] K4-713: tomorrow they won't even remember if it was a K.O. or not. Mail again in the morning :) [00:31:12] awight: be right there [00:32:21] Ooo, straight up ignored my main question. [00:32:32] K4-713: looks like the old one to me [00:32:37] on prod [00:32:40] Yeah, that was sort of the point. [00:32:42] via donate [00:32:48] It's just on a different server now. [00:32:55] Instead of on-wiki somewhere weird. [00:33:02] Now, we can deploy both sides at the same time. [00:33:11] With the *same button*. [00:34:54] atgo: Well, hey: Looks like I've got some payments stuff to deploy. [00:34:58] rad [00:34:58] (PS1) Awight: Compiled things in dist/ [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176844 [00:35:08] atgo: Look what happened to pending deployment! [00:35:20] wooo [00:35:34] * K4-713 eats more wheaties [00:36:03] I guess I need to figure out what should happen in FormSettings, too. [00:36:12] (PS1) Awight: Update readme with deployment howto [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176846 [00:36:14] (PS1) Awight: Ignore the dist/ directory on the master branch [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176847 [00:36:21] pizzzacat: What are the ffnames for your new WP forms? [00:36:32] Or, do you just use the old one? [00:40:57] I just set them up to work with the country=XX [00:41:26] er. So, they're always ffname=worldpay? [00:41:34] d'oh. [00:42:00] which reminds me, I didn't check in my formsettings [00:42:12] oh was that the rong way? [00:42:18] Nah. [00:42:25] I was just trying to figure out the formsettings. :) [00:42:25] u mad [00:42:33] >_< [00:42:35] ...no. :) [00:42:39] ur so mad [00:42:46] Constantly. [00:43:04] Ah, do they work with the other test ones? wp-sn and such? [00:45:02] good catch, I did not think about how that needed extra fiddling [00:45:06] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176843 (owner: Awight) [00:45:17] (CR) Awight: [C: 2] Compiled things in dist/ [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176844 (owner: Awight) [00:45:25] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176843 (owner: Awight) [00:45:25] pizzzacat: I can do the limiting on the formsettings side. :) [00:45:29] (Merged) jenkins-bot: Compiled things in dist/ [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176844 (owner: Awight) [00:45:35] orly ok [00:45:43] thanks K4-713 [00:48:10] (PS1) Ejegg: WIP update wmf_donor fields after merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176851 [00:48:42] ejegg: uh oh: error: error: Your local changes to the following files would be overwritten by checkout: [00:48:49] local changes? [00:49:03] did u ahem livehack the deployment server by any chance? :) [00:49:14] didn't think I could do that [00:49:25] which files? [00:49:44] hrm [00:50:06] error: Unable to checkout 'b2fafc91ac5faa161a06f4f67a8af8eb60b1c6b4' in submodule path 'src/bow [00:50:09] er_modules' [00:50:39] ...? [01:00:52] Oh, lame. These aren't coming in here anymore. [01:00:53] https://gerrit.wikimedia.org/r/176854 [01:01:59] K4-713: there is a way... lemme see. [01:04:32] Starting another payments deploy. :) [01:06:29] (PS1) Katie Horn: Merge branch 'master' into deploy [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/176856 [01:06:55] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/176856 (owner: Katie Horn) [01:07:11] (Merged) jenkins-bot: Merge branch 'master' into deploy [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/176856 (owner: Katie Horn) [01:09:43] But seriously, would somebody https://gerrit.wikimedia.org/r/#/c/176854/ ? [01:09:57] awight, pizzzacat3, ejegg? [01:10:21] looking K4-713 :) [01:10:26] ty! [01:10:42] * K4-713 wanders off for a minute [01:10:58] oh I had a patch that added those countries [01:11:05] I can abandon it though, this one does more things [01:11:18] Aha! I failed to see it go by. [01:11:35] * K4-713 is terrible at wandering off [01:11:36] I like how you alphabetized [01:11:46] I thought about flipping one. [01:11:52] Just to... mess with awight, really. [01:12:05] that kind of thing could send him into a depression [01:16:28] He files a card, we mark it "Nice to Have"... [01:16:35] <-- evil [01:17:30] Couldn't even fix it as an incidental rider with something else for a while. Different repo. [01:18:59] [...] I blame... that Italo Calvino guy. <---- Ha! also my favourite book. [01:19:03] hey guys.. i'm getting sent the wrong country. i haven't cleared cache but i got country=EU from donate. [01:19:54] atgo_: F. [01:20:02] According to Mingle, that fix was deployed. [01:20:41] yeah that's why i bring it up :P [01:21:08] Also... country=EU? [01:21:13] hey pizzzacat another couple of form updates if you're able... https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2213 [01:21:15] yeah K4-713 [01:21:16] Anybody else like how that's not even a country? [01:21:16] i know [01:21:44] pizzzacat: I think we're going for three payments deploys today. [01:21:56] It's been a while since I've... 3D'd. [01:22:00] * K4-713 frowns [01:22:01] ha sure, looking now [01:22:14] I was wondering about the state label too [01:22:16] More than three, though, and I don't know what will happen. [01:22:26] in WorldPay it makes the form look weird without the label [01:22:32] ohhh really? [01:22:36] so I would actually, like, remove it from the options list [01:22:42] do you have a link pizzzacat? [01:22:51] sure one sec [01:23:15] Oh man. I was about to ask if we don't also have this problem with State. [01:23:21] Which is, you know, what we're talking about. [01:23:29] ejegg awight see the backscroll about country issues :( [01:23:56] aargh. Let's take a look at that geoip cookie [01:25:42] maybe i'm just located in a special land [01:25:58] all by myseeeelllfff [01:26:03] Euphonia? [01:26:08] Er. [01:26:37] What kinds of currencies would you like do donate with, from your special country? [01:26:46] atgo I added a screenshot to that card [01:27:17] K4-713 was there something else you needed code reviewed? [01:27:24] I don't think so. [01:27:27] ah ok [01:27:30] * K4-713 checks pockets [01:27:46] Nah, I'm good. [01:27:54] pizzzacat: Thanks for asking. :) [01:28:08] pizzzacat: is it possible/advisable to do a different thing for wp and gc? [01:28:10] I think the State issue is different [01:28:16] it's more aesthetic [01:28:17] Yep! [01:28:29] it's possible [01:28:36] and I don't really have a strong opinion [01:28:42] but [01:28:53] generally for accessibility it's good to have labels [01:29:11] so I would choose to remove the state label inside the dropdown rather than the one outside [01:30:14] I would opt for a non-selectable "(Select one…)" or somesuch [01:30:15] pizzzacat: it's not like that in the US though [01:30:29] for GC or WP? [01:30:40] in general [01:30:42] well gc at least [01:30:47] let me look for WP [01:30:56] I could just make them all the same [01:31:06] no biggie [01:31:06] ok so WP has labels, yeah [01:31:11] yeah [01:31:25] hm [01:32:00] I'd probably just add a label to the GC ones and then make GC and WP both have default non-state selections (which are disabled and therefore non-selectable) showing for the dropdown [01:35:35] pizzzacat: meganhernandez would love to test these things [01:35:45] so, i know this may be a bit of a pain, but any way there could be both versions? [01:36:14] in the short term, she'd prefer to keep consistent with the US currently and remove the label (leaving "state" in the dropdown) [01:36:38] we should also definitely get together the accessibility best practices though [01:36:43] that's new to me [01:37:19] !log updated payments to c0c4bfcdb4fa625fa52 [01:37:25] Logged the message, Master [01:38:00] atgo: ^^ that was a bunch of stuff. [01:38:47] rad! [01:38:56] geez. [01:39:01] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/overview [01:39:33] That third ice cream bar is just today, isn't it? [01:39:40] Or, was that also last week? [01:40:01] i think today [01:40:38] atgo yes I can do both ways [01:40:45] thank you [01:40:51] :) [01:40:54] is this a time sensitive thing? [01:41:10] having the AU at least with just the label in the field is for tomorrow [01:41:15] the rest can wait [01:41:16] also this feels like one of those things that UX should probably be involved with [01:41:33] yeah, we should get them involved for sure. i'd like to figure out how to do that and also best practices [01:41:34] before I finish up with this backscroll, lemme say: aawwww man [01:41:36] since we are getting in trouble frequently with those kinds of things [01:41:51] yeah [01:42:07] I'd love to set up a meeting with them before getting too deep, to save work [01:42:16] !log updated dash to b3f4be0bbd6c16be64030607fd9c59cb84111429 [01:42:20] Logged the message, Master [01:42:22] well we need to have an AU form for tomorrow... [01:42:57] I created the AU form, which should be being deployed by then [01:43:33] I think I just did that. [01:43:33] thank you [01:43:57] no K4-713 still the old way [01:43:59] for AU [01:44:07] unless i'm getting the wrong one [01:44:43] also pizzzacat just moved the card to PCR unless there's a reason not to? did the email get put onto its own line, too? [01:44:55] I am a little confused [01:45:02] with this conversation [01:45:09] want to talk IRL? [01:45:20] today I created new forms for all the Big English countries [01:46:26] And I just deployed those. [01:46:37] Mingle... is accurate. [02:01:50] (PS1) Ssmith: Remove AU State label and newline email [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176866 [02:01:53] (CR) jenkins-bot: [V: -1] Remove AU State label and newline email [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176866 (owner: Ssmith) [02:02:15] (PS2) Ssmith: Remove AU State label and newline email [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176866 [02:22:32] hey K4-713 awight ejegg if possible... https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2213 [02:22:35] to deploy :) [02:27:44] K4-713: (confirmed) dwdiff -W '&' a1 a2 [02:27:45] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=Sep2014Design&ffname=obt-bpay&recurring=&utm_medium=sitenotice&utm_campaign=none&utm_source=B14_1201_5C_newcontrol.no-LP.obt.bpay&referrer=&returnto=&language=en&country=AU¤cy_code=AUD&[-utm_key=252-]&{+utm_key=3+}&payment_method=obt.bpay&frequency=onetime&amount=3&amountGiven=&uselang=en [02:31:47] awight ejegg K4-713 any chance this can happen tonight? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2214 [02:31:58] and go in the same payments deploy as the other one [04:13:30] (PS2) Ejegg: WIP update wmf_donor fields after merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176851 [04:30:40] (PS1) Ejegg: Use country-specific address forms for BPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176875 [04:35:56] (PS2) Ejegg: Use country-specific address forms for BPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176875 [14:51:23] hm, the "DEAR WIKIPEDIA READERS" spiel is appearing as the description in some wikipedia results for google [17:04:57] (CR) Awight: [C: 2] Remove AU State label and newline email [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176866 (owner: Ssmith) [17:05:44] (Merged) jenkins-bot: Remove AU State label and newline email [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176866 (owner: Ssmith) [17:11:59] AndyRussG: https://github.com/wikimedia/wikimedia-fundraising-tools/blob/master/fundraising_ab_tests/campaign_log.py [17:13:21] here is your cat of the day: http://i.imgur.com/W0JfyHW.gif [17:15:30] the orange cat fights like a jellyfish feeds [17:16:32] ... [17:17:09] Ah. *Now* I get it. [17:17:50] AndyRussG: http://meta.wikimedia.org/w/api.php?action=query&list=centralnoticelogs&format=json [17:18:26] ejegg: I'm getting notices on the bpay form, after submit. Do you remember what fields were there before you changed the template? [17:18:58] I'm getting notices about street and city. [17:19:06] city was in the default [17:19:23] maybe street? let me check [17:19:24] I don't remember street, but it may have been a hidden field? [17:19:30] K4-713 have you heard from GC since yesterday (on the outage and Miami server email) [17:19:38] PPena: nnno? [17:19:43] Not that I noticed. [17:19:45] I'll look again. [17:19:48] ok [17:19:57] no I havent also, just checking [17:20:01] K4-713: nope, no street in default [17:20:01] will reply [17:20:21] PPena: They definitely seemed to think that the outage report answered all our questions. [17:20:23] It did not. [17:20:44] ejegg: I'm just going to test master for this same issue... [17:20:48] It was probably there too. [17:21:07] Not that anybody would get notices in prod. Everything actually works. [17:21:21] K4-713: I'm also interested in all the CSS crickets. [17:21:30] From GC? [17:21:34] yah [17:21:37] Yeah, that... is kind of Argh. [17:21:57] Also, we should have them swap out our sandbox for the old URL on foundation wiki so we can actually test things kind of. [17:22:38] ejegg: Ha. Preexisting condition. [17:22:41] :( [17:23:03] Obamacare says they can't give us notices for that! [17:23:17] (CR) Katie Horn: [C: 2] "Looks good, verified that it's being sent in the XML and therefore retrievable by both WR1 and pending WX nightly audit scripts." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176875 (owner: Ejegg) [17:24:44] Come. On. Jenkins. [17:24:54] When. I'm. Kicking. You. That. Means. Go. Faster. [17:26:45] (Merged) jenkins-bot: Use country-specific address forms for BPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/176875 (owner: Ejegg) [17:27:07] woot. Deploying. [17:29:08] (PS1) Katie Horn: Merge branch 'master' into deploy [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/176960 [17:29:28] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/176960 (owner: Katie Horn) [17:31:38] hnnnggggg. [17:31:41] This is getting worse. [17:32:06] K4-713: it's churning on npm: https://integration.wikimedia.org/zuul/ [17:32:14] I am looking at that. [17:32:28] That' [17:32:33] That's annoying: https://integration.wikimedia.org/ci/job/mwext-DonationInterface-npm/484/console [17:32:53] It spent 4 seconds doing anything we actually care about, and 3 min being cool. [17:33:06] Too cool to merge this patch right now. [17:33:19] hold on: I'm downloading javascript [17:33:44] (Merged) jenkins-bot: Merge branch 'master' into deploy [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/176960 (owner: Katie Horn) [17:33:53] wtf do we seriously need our own fresh install of GruntJS and JSHint and all the supporting garbage... [17:34:00] Nope. [17:35:03] oh sorry for the libel--it was actually git sloth [17:35:17] I thought somebody knew something I didn't. [17:35:21] (which is normal) [17:35:34] so is IRC still preferable to IRL for communication, I guess? [17:35:50] Sometimes! [17:35:54] This is also normal. [17:38:12] (CR) Ejegg: [C: 2] "Thank you!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176846 (owner: Awight) [17:40:57] !log updated payments to 30f15865bc4efe3b [17:41:02] Logged the message, Master [17:42:50] (CR) Ejegg: "And by 'deprecate', we mean 'annihilate'. How about leaving the setting in and using it instead of the hardcoded geoiplookup.wikimedia.or" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176705 (owner: Awight) [17:54:24] hey pizzzacat did this go out with dash yesterday? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2073 [17:58:48] atgo that is kind of ongoing, actually working on some things right now. for example, some of the css is wrong. [17:59:17] I guess we can set it as deployed [17:59:29] since the original issues are mostly gone [17:59:32] whatever is accurate :) [17:59:47] if you want to wait until you finish with the css that's fine too [17:59:52] ok will do [18:00:15] any idea when we are going to launch btw? [18:00:43] they're talking through buckets [18:01:04] it sounds like that's the blocker at this piont [18:01:04] They just sent an email, didn't they? [18:01:43] ? [18:02:37] Definitely just sent an email. :) [18:02:44] I didn't get an email [18:02:55] Ha, no, I mean campaign email. [18:03:12] ohh [18:05:17] oh nice [18:05:32] i wonder if i'll get one of those [18:07:23] we are getting tons of email donations right now [18:07:26] :) [18:08:45] hehe [18:09:20] pizzzacat: mind if i throw you some other little fixes while i'm looking at dash? [18:10:19] atgo would you mind doing this IRL? [18:10:46] sure! let me finish this bucket thing first [18:12:37] great! yeah there are some things I need to change for sure. [18:26:31] (CR) Awight: "The thought crossed my mind--however, it's currently set to false in config, so we have a chicken v. egg issue. I think the steps are," [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176705 (owner: Awight) [18:28:42] (PS1) Ejegg: Add script to update 1k+ group wmf_donor stats [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176972 [18:29:20] (CR) Ejegg: [C: 2] "Good plan" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176705 (owner: Awight) [18:29:26] ejegg: u might want to be in #wikimedia-dev :) there have been a few chances to use your name [18:29:30] (missed chances :p) [18:29:33] ohhh? [18:29:38] joining [18:37:21] awight: I'd like to manually update wmf_donor for the 1k+ donors with this sql script: https://gerrit.wikimedia.org/r/176972 . Care to take a look? [18:37:26] ejegg is Lato css in the gulpfile on prod? [18:38:00] ejegg: looking [18:38:09] pizzzacat: Yeah, I think so [18:38:30] how do I get into prod btw? [18:39:05] that old error that was happening on your machine with the navbar is still happening on some peoples' machines [18:39:24] and the font is not displaying correctly, which is actually probably the issue [18:39:30] since it pushes everything [18:39:48] ahh phooey [18:39:57] let me take a look at prod [18:41:01] pizzzacat: yep, looking the same for me on prod as it did before you fixed the fonts. Huh [18:44:52] ejegg but that had been fixed for you at some point for sure, right? [18:45:15] It definitely was fixed in debug mode [18:45:32] And I think my dist folder may have had extra files [18:45:51] 'cause I'm getting 404s on prod looking for the lato woffs in /font/ [18:45:54] singular [18:46:56] that's the issue [18:47:04] I wonder why the change was lost? [18:47:29] I just re-gulped and yeah, same issues with spacing that I had fixed before are not there [18:47:37] which is a separate css issue from this nav issue [18:49:28] hey ccogdill with your import, did you click the "update" as a dedupe rule? [18:50:30] i clicked “update” then used Adam’s “email in enuf” dedupe rule. [18:50:35] hm ok [18:50:40] he's going to take a look at it :) [18:51:41] does anyone have a sense of what the delay is right now for getting a thank you email/donation confirmation? [18:52:04] as in, how long is the lag time? [18:53:14] awight ^ ? [18:55:34] CaitlinVirtue: it looks like they're keeping up pretty well. I don't think lag should be more than 5 min [18:56:12] ok, thx. we'll keep on eye on the one in question and let you know if that's not the case [18:57:28] I looked at that one, CaitlinVirtue. It was only 10 minutes ago, so I don’t think there’s cause for concern [18:57:33] but good to keep an eye out! [18:58:20] great, thanks [19:06:58] CaitlinVirtue: ccogdill: yeah and there was a good spike in traffic this morning, so the backlog is higher than normal. [19:07:10] makes sense to me, thanks awight! [19:07:55] i figured as much with the increased traffic, i just wanted to get a sense of what the upper bound was or is projected to be in the coming days [19:09:45] CaitlinVirtue: we'd like to know, too :) ask us every day so we're forced to come up with some automated thing to let us know the current delay until thanking. [19:11:41] (PS1) Ssmith: Rebuild because fonts didn't run [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176987 [19:11:56] awight or ejegg? ^ [19:12:45] pizzzacat: you're fine self-merging deployment things [19:13:01] orly? how do I do it? [19:13:16] just the usual: review->+2 [19:13:21] ok! [19:13:22] thanks [19:13:34] (CR) Ssmith: [C: 2] Rebuild because fonts didn't run [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176987 (owner: Ssmith) [19:13:45] (Merged) jenkins-bot: Rebuild because fonts didn't run [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176987 (owner: Ssmith) [19:21:50] ejegg can we also (after mimosas) talk about what changes you added to the charts? [19:24:50] (CR) Awight: "pizzzacat: I noticed that src/bower_modules were flapping for me, too. Is this an intentional part of deployment? It might be difficult " [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176987 (owner: Ssmith) [19:25:02] pizzzacat: totally [19:26:54] (PS1) Ssmith: Have Big English reload every 5 minutes [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176991 [19:27:29] awight what did you mean they are "flapping"? [19:27:49] (CR) Ejegg: "I think this reverted bower_submodules to an older version without numeraljs. Deployment should be OK still if it's all been minified." [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/176987 (owner: Ssmith) [19:28:22] pizzzacat: that even though I did a git submodule update, I swear src/bower_modules changed itself to another version at some point! donno why [19:28:25] it looks like we need to get bower and npm up to speed and then deploy again [19:28:54] yeah like, did you accidentally regress src/bower_modules? [19:49:55] anyone feel like reviewing https://gerrit.wikimedia.org/r/#/c/176991/ ? [19:50:31] (CR) Awight: [C: 2] "What is the controlling process?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176972 (owner: Ejegg) [19:50:34] (Merged) jenkins-bot: Add script to update 1k+ group wmf_donor stats [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176972 (owner: Ejegg) [19:53:25] K4-713: hey uh what's going on here: https://git.wikimedia.org/commit/mediawiki%2Fcore/30f15865bc4efe3b2baefcd0482f31f9145e75bf -- why does that ChangeId not exist in gerrit? [19:54:01] Because I still push pure submodule updates. [19:54:06] but... [19:54:11] but what are u doing to deploy? [19:54:19] What do you mean? [19:54:21] this is the last thing in gerrit: https://gerrit.wikimedia.org/r/#/c/174845/ [19:54:35] Look at the tree. [19:55:17] wat. [19:55:23] I see that your commits are all here, https://git.wikimedia.org/log/mediawiki%2Fcore.git/refs%2Fheads%2Ffundraising%2FREL1_23 [19:55:25] Or rather: https://git.wikimedia.org/log/mediawiki%2Fcore/refs%2Fheads%2Ffundraising%2FREL1_23 [19:55:33] but are you not "git review"ing these? [19:55:39] That's what I just said. [19:55:44] ooohk [19:55:46] well. [19:55:47] They're reviewed in the submodule. [19:55:49] want to? :) [19:55:57] Not really, but I will if this bothers you. [19:56:04] I don't care. [19:56:23] Only noticed cos I was trying to do this: [19:56:31] (CR) Awight: "test comment!" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/174845 (owner: Ejegg) [19:56:35] woot. [19:56:48] The thing is, this way it's sort of clear what was reviewed elsewhere (submodule updates), and what needs to be reviewed on our branch (FormSettings changes). [19:56:52] That was much more gratifying than when the PA system is out of batteries [19:56:56] The line is not 100% like everywhere else. [19:57:07] It's... annoying. [19:57:30] I'm fine. I just wish gerrit could pick up the naughty stuff you're pushing and then it would all be in one place. [19:59:46] K4-713: more importantly--I see you let GC off the hook for the per-language CSS [20:01:42] (CR) Ejegg: "Totally manual. Just wanted this checked in someplace for review + reuse." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176972 (owner: Ejegg) [20:02:09] ejegg|brb: awesome. [20:02:50] awight: Temporarily. [20:06:52] (PS1) Ssmith: Update bower [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/177011 [20:07:58] (PS1) Ssmith: Update node modules [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/177012 [20:09:18] (PS1) Ssmith: Fix issue with label on USD/sec chart [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177014 [20:09:49] ejegg I have a couple patches in the deployment branch (semi oops but oh well) [20:09:58] ready to deploy [20:10:18] which I can take care of if you wanna review? [20:10:48] pizzzacat: I'll cherry-pick 'em over to master and review them there to preserve mergeability [20:11:01] ok, sorry for that. [20:12:47] wait, I already checked in a version of bower_modules with that stuff: https://gerrit.wikimedia.org/r/176035 [20:13:06] weird, I wonder why it wasn't updated on the deploy branch? [20:13:23] yeah I thought I had already done this too [20:13:23] It was, you just reverted :P [20:13:31] oh, how did I revert?? [20:13:39] yikes [20:13:59] totally did not mean to [20:14:50] s'okay, just go into the bower_modules directory, do git reset --hard b2fafc91ac5faa161a06f4f67a8af8eb60b1c6b4, then git add and commit (only need to on deployment branch) [20:15:42] pizzzacat: there's pizza [20:15:42] pizzzacat: oops [20:16:09] pizzzacat: I mean cd back into src after the reset, then git add bower_modules and commit [20:37:55] (PS1) Ssmith: Fix bower modules [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177018 [20:49:47] (CR) Ejegg: [C: 2] Fix bower modules [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177018 (owner: Ssmith) [20:53:04] (PS1) Ssmith: Format hourly totals to currency [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177023 [20:57:49] (PS1) Ssmith: fix navbar padding on collapse [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177024 [20:59:24] pizzzacat: I'm gonna move those over to master in one sec (sans gulpage) [20:59:54] pizzaejegg: hybrid entity? [21:00:09] pizzzacat: I suggest a lawsuit for identity theft [21:00:18] haa [21:00:48] so ejegg is everything basically set for moving forward? I've been adding tons of little patches to master [21:01:17] (PS1) Ejegg: Have Big English reload every 5 minutes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177025 [21:01:19] (PS1) Ejegg: Fix issue with label on USD/sec chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177026 [21:01:21] (PS1) Ejegg: Format hourly totals to currency [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177027 [21:06:05] (CR) Ejegg: [C: 2] Have Big English reload every 5 minutes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177025 (owner: Ejegg) [21:06:29] (CR) Ejegg: [C: 2] Fix issue with label on USD/sec chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177026 (owner: Ejegg) [21:06:42] (PS1) Ejegg: fix navbar padding on collapse [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177058 [21:15:58] (CR) Ejegg: [C: 2] Format hourly totals to currency [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177027 (owner: Ejegg) [21:16:31] (CR) Ejegg: [C: 2] fix navbar padding on collapse [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177058 (owner: Ejegg) [21:21:31] pizzzacat1 hi [21:21:52] pizzzacat1 K4-713 Dash says no fraud for USD in the past 15min…. like none, zero [21:21:59] can that be correct? [21:26:25] PPena: I [21:26:30] m seeing 4.1% [21:33:19] i think the prob was 'last 15 min' [21:33:29] myabe its too short of a timeline… wasnt showing [21:34:03] I can see ~ 4.1% for the last hr [21:39:33] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177081 [21:39:35] (PS1) Ejegg: Gulp Sherah's latest changes for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177082 [21:54:24] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177081 (owner: Ejegg) [21:55:09] (CR) Ejegg: [C: 2] Gulp Sherah's latest changes for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177082 (owner: Ejegg) [21:58:56] (PS3) Ejegg: Update wmf_donor fields after merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176851 [22:16:35] ejegg did you deploy while I was out getting coffee? [22:17:03] nope, but deployment branch has all your stuff merged now. [22:17:05] * pizzzacat tries to figure out through gerrit interface but it's gerrit interface [22:17:14] sweet, I'll go ahead then! [22:17:17] I swung 'em around through master first [22:17:33] so you might have to reset back a ways then pull [22:17:34] thanks for doing those! [22:18:32] reset in deployment? interesting [22:18:40] I hadn't considered this before [22:19:44] what's the idea with this actually ejegg? [22:20:55] pizzzacat: I just meant if you wanted to test the deployment branch locally [22:21:11] since you have some patches that are different versions from the ones that got merged [22:21:21] oh ok that makes sense. [22:22:55] (PS4) Ejegg: Update wmf_donor fields after merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176851 [22:36:27] (PS1) Awight: No need to quantize throttling any more. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177093 [22:42:02] (CR) Ejegg: [C: 2] No need to quantize throttling any more. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177093 (owner: Awight) [22:45:33] (PS5) Awight: Update wmf_donor fields after merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176851 (owner: Ejegg) [22:59:55] (CR) Awight: [C: 2] "Wow, that was tricky!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176851 (owner: Ejegg) [23:00:00] (Merged) jenkins-bot: Update wmf_donor fields after merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/176851 (owner: Ejegg) [23:12:45] ccogdill: hey... when you did the AU state import, does your error download include contact IDs already? That's what I'm seeing on my local Civi, at least. [23:13:02] The fastest thing is probably that I do text processing on that resulting CSV. [23:13:06] nope [23:13:12] ooof [23:13:17] mind if I see what it did include? [23:13:30] sure thing, should I come to you? [23:13:31] or u could copy to the filesrv... [23:13:33] sure [23:15:53] (PS1) Ejegg: Fix WMF post-merge recalc breaking when no donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/177103 [23:15:56] (CR) jenkins-bot: [V: -1] Fix WMF post-merge recalc breaking when no donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/177103 (owner: Ejegg) [23:16:56] (PS2) Ejegg: Fix WMF post-merge recalc breaking when no donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/177103 [23:18:28] (CR) Awight: [C: 2] Fix WMF post-merge recalc breaking when no donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/177103 (owner: Ejegg) [23:18:36] (Merged) jenkins-bot: Fix WMF post-merge recalc breaking when no donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/177103 (owner: Ejegg) [23:20:08] AndyRussG: here's an example from the Parsoid historical contents thing... http://api.wmflabs.org/v1/en.wikipedia.org/pages/Paris/html/626969947 [23:20:16] It can also output json... one moment please [23:20:58] awight: cool! Do you happen to have on hand the WMF browser testing page link again? I tried the one I thought it was, but it times out :( [23:21:50] AndyRussG: I think this is it, https://integration.wikimedia.org/ci/job/browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/ [23:26:35] hey awight [23:26:48] wasn’t sure where to put it so I chose what is certainly the wrong folder - oh well :) [23:26:49] smb://filesrv1/Fundraising/Adam Wight/20141202.CiviImportErrors [23:29:15] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/177108 [23:29:49] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/177108 (owner: Ejegg) [23:31:01] ccogdill: One weird thing about that file: look at the column headers. That can be fixed, but is all the data you need still there? [23:31:06] email and 4-digit thing... [23:32:15] !log updated crm from 68703898b7ebfb2a038f307f17788739114806e4 to cd936bb433e9f107d860fb6e3da44c2ca2cb7742 [23:32:20] Logged the message, Master [23:32:24] K4-713: i may have taken your utm_medium idea :) [23:32:54] That's what it's there for! Ha. [23:33:40] I think there are a few "K4Rules" in there. [23:33:48] ...have to be able to find your transactions. :p [23:44:26] K4-713: atgo-lunch: awight: ejegg: pizzzacat2: I'm just gonna make a few non-work-related Skype calls from the "batcave", if that's OK, shouldn't be long [23:44:50] awight: I'm going to deploy the silverpop zip + state thing. [23:45:04] ejegg: cool [23:45:28] AndyRussG: Totally. [23:48:39] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/177124 [23:49:00] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/177124 (owner: Ejegg) [23:54:45] !log updated tool from 113dfe160b750657626e07450003cc88d3939fbd to c8f63baf134e57680fd255874455d52efb70596f [23:54:47] Logged the message, Master [23:56:41] Let's see what happens when we run the silverpop export during this kind of load [23:56:48] (PS1) Awight: yikes: try to remove the DjangoBannerStats submodule [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/177126 [23:56:59] (CR) Awight: [C: 2] yikes: try to remove the DjangoBannerStats submodule [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/177126 (owner: Awight) [23:57:01] (Merged) jenkins-bot: yikes: try to remove the DjangoBannerStats submodule [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/177126 (owner: Awight) [23:58:23] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/177127 [23:58:32] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/177127 (owner: Awight) [23:58:35] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/177127 (owner: Awight) [23:59:05] grr: error: warning: unable to rmdir DjangoBannerStats: Directory not empty