[00:02:52] (PS1) Ssmith: Merge master into head and gulp changes for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177435 [00:03:22] (CR) Ssmith: [C: 2] Merge master into head and gulp changes for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177435 (owner: Ssmith) [00:03:35] (Merged) jenkins-bot: Merge master into head and gulp changes for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/177435 (owner: Ssmith) [01:01:00] awight: It doesn't look like we actually messed with the minfraud API beyond changing var->public [01:01:35] (PS1) Awight: Insert nulls for missing data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/177450 [01:01:40] Looking suspiciously like a drop-in upgrade [01:05:19] ejegg: ah good. I thought we added some suspect logic to mock outbound curl attempts [01:05:52] checking for minfraud stuff in tests [01:07:20] ejegg with that setTimeout issue, want me to just take care of it? [01:07:33] nope, just setting EnableMinfraud to false for tests, and the server array to just "minfraud.wikimedia.org" for good measure [01:08:31] pizzzacat: Let me push this patch and see if you like that fix [01:08:49] oh ok, didn't realize you had already done it! [01:09:06] I mixed it in with the caching thing [01:09:26] AndyRussG: hehe, we just went from 3111 queries to 11. Nice to subtract from the most significant end. [01:09:31] 'cause I wanted to have the auto-refresh allow cached stuff, but the manual refresh demand new data [01:09:52] awight: whoa! not bad! [01:10:37] (PS1) Awight: Move subselects into the main pager query [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177452 [01:12:25] (PS2) Awight: Move subselects into the main pager query [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177452 [01:13:44] (CR) Awight: [C: -2] "oops, I found a bug when a campaign targets all languages..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177452 (owner: Awight) [01:19:00] (PS1) Ejegg: Cache db query results for 5 minutes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 [01:19:05] (CR) jenkins-bot: [V: -1] Cache db query results for 5 minutes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [01:19:55] (CR) Ejegg: [C: 2] "Adding 3rd-party lib" [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/177390 (owner: Ejegg) [01:20:04] (CR) Ejegg: [V: 2] "Adding 3rd-party lib" [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/177390 (owner: Ejegg) [01:20:31] (CR) Ejegg: [C: 2] "Yep" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/177450 (owner: Awight) [01:21:58] [#wikimedia-fund] [01:25:19] shouldn't the ie9 lack of banners be like an emergency card? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2220 I just checked, it's like 9% of the global market, though I can't find the share for the US [01:25:43] <_< [01:25:44] >_> [01:26:32] Even if it were half of that, missing out on 4% of desktop users sounds like a lot :( though maybe windows users never donate... [01:29:32] awight: ejegg: let's make a temporary "development" branch in CentralNotice for stuff we're not sure that we'll merge until after the code freeze [01:29:58] That way we can keep master clean and ready to merge to wmf_deploy when there's urgent stuff that we're ready to send out there [01:30:05] does that make sense? [01:30:25] I don't think we need to change the branching model, since we already have a distinct deployment branch [01:30:34] We can just agree not to bulk merge from master? [01:30:50] awight: sure that also works [01:31:08] I agree not to merge :) [01:31:38] mmm well in that case we can merge to master and just cherry-pick to wmf_deploy? [01:32:05] I agree not to fork [01:32:40] lol [01:32:43] no fun at all [01:32:56] yeah cherry-pick works for me [01:34:23] K sounds good [01:35:40] (PS3) Awight: Move subselects into the main pager query [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177452 [01:35:53] (CR) Awight: Move subselects into the main pager query [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177452 (owner: Awight) [01:37:26] (PS1) Ejegg: Un-break usd_per_second graph [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177462 [01:39:31] (PS1) Ssmith: Change the way unlogged-in screen looks [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177463 [01:45:57] atgo: Should this card go in the current sprint? Globally IE9 is 9% but I don't know what its share is in the countries in Big English... https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2220 [01:49:45] AndyRussG: I think that was her idle laptop [01:50:54] well! I guess I should stop squandering my pings [01:54:43] can't hurt! [01:54:58] (CR) Ejegg: [C: -1] "one functional thing, various nitpicks" (7 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177463 (owner: Ssmith) [02:01:28] (PS1) Awight: Simplify Campaign editor banner list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177466 [02:05:08] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/177467 [02:05:12] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/177467 (owner: Awight) [02:05:14] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/177467 (owner: Awight) [02:05:16] !log update crm from cd936bb433e9f107d860fb6e3da44c2ca2cb7742 to adfbbecbf949932932a3b6bc8c20c15e2a8054b2 [02:05:22] Logged the message, Master [02:06:24] awight: where did u say there are batteries? [02:06:42] behind the unmarked door next to the free table [02:06:44] AndyRussG: ^ [02:06:52] awight: cool thx! [02:32:54] (PS1) Awight: Small fixups [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177474 [02:32:56] (PS1) Awight: Warn if a campaign's bucket assignments look funky [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177475 [02:47:17] (CR) AndyRussG: "Found no issues so far... Mmmm... would unit tests to make sure needed params _are_ controlling stuff be fun? Just a thought.... 8p" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176251 (owner: Awight) [02:49:27] (CR) Awight: Remove unused banner variance parameters (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176251 (owner: Awight) [02:50:15] (CR) Awight: "Agreed that TODO we should be testing the remaining params to Special:BannerLoader!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176251 (owner: Awight) [17:45:05] (CR) Awight: [C: 2] "Don't fully understand, but it looks safe and reasonable :)" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177462 (owner: Ejegg) [17:45:18] (Merged) jenkins-bot: Un-break usd_per_second graph [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177462 (owner: Ejegg) [17:45:43] (CR) Awight: "From the npm failure:" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [17:46:09] (CR) Ejegg: "It is now!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [17:46:41] (CR) Awight: "retest" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [17:46:55] ejegg: btw, zuul magic ^^ [17:47:04] magic word? [17:47:22] aww, or it was supposed to [17:50:17] (CR) Reedy: "recheck" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [17:50:57] And/or press the rebase button [17:51:06] ah, thanks! [17:51:21] wikimedia-fundraising-dash-jslint FAILURE in 1s (non-voting) [17:51:21] wikimedia-fundraising-dash-npm SUCCESS in 4s [17:56:41] HAH thank you [18:01:32] atgo_: thanks, excellent curation [18:01:39] :) [18:02:33] argh that site is drawing me in now [18:02:35] http://www.strongmindbraveheart.com/creepiness-inside-teddy-bear/ [18:04:17] hey pizzzacat1 can you throw estimates on 2227, 2228? [18:04:50] sure atgo_ [18:04:52] (CR) Ejegg: "There's a switch to turn it on and off, and 2 other places where code like the stuff you're replacing instantiates the renderer and create" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177466 (owner: Awight) [18:05:35] hey ejegg do you wanna check in on dash in a bit? or after metrics? [18:05:43] either way is fine by me [18:05:49] if u r bz [18:05:55] soon is good for me [18:06:04] ok cool! new orders comin' in [18:07:52] atgo I think we had talked about how 2227 would be a part of the larger widget that there is a prototype for already… but I could do it iteratively as well, to satisfy current needs [18:09:58] (CR) Awight: "ino... I'm okay with just this incremental step for now, but in general I think the preview compromises need a revisit. At one point we " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177466 (owner: Awight) [18:10:12] atgo on fundraising/fundraising/dash prototypes/DonationChart [18:10:18] on filesrv1 [18:10:23] (PS2) Awight: Cache db query results for 5 minutes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [18:10:39] (CR) Awight: "Great!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [18:10:45] (CR) Awight: [C: 2] Cache db query results for 5 minutes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [18:10:53] (Merged) jenkins-bot: Cache db query results for 5 minutes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177455 (owner: Ejegg) [18:11:26] pizzzacat: Did you want to have a coffee meeting? [18:11:38] Which at this point is probably just a breakroom chat. :/ [18:11:39] K4-713 right now? [18:11:49] It was on the calendar for 11 minutes ago. [18:12:01] oh weird! [18:12:01] I'm *so good* at calendars. [18:12:30] If you want to postpone for some random point in the future, that's fine with me too. [18:12:32] sure we can do that - does it work for you? you look bz [18:12:40] I can go now. [18:12:40] sure that works [18:12:41] haha [18:12:42] ok! [18:13:38] ejegg: pizzzacat1: donation amounts Y axes need labels... [18:14:03] nice job scaling btw!! [18:17:50] yeah pizzzacat1 you're making sense... let's just elaborate on the card to describe that. i didn't have all the info yesterday when i made that [18:18:07] and i have a few small requests from the conf room team about the chart update - will make a card for that, too [18:21:32] pizzzacat1: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2237 [18:27:03] atgo: the-wub: http://stackoverflow.com/questions/3207211/is-there-a-way-to-make-robots-ignore-certain-text [18:27:16] "!--googleoff: index-->