[00:46:24] (PS8) Awight: WIP Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 [00:47:15] (CR) jenkins-bot: [V: -1] WIP Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (owner: Awight) [00:56:47] (CR) Awight: [C: -1] "This is causing bad stuff, now "rerun" et al do not always trigger banner load." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (owner: Awight) [01:02:05] (PS3) Awight: DO NOT MERGE Dropping tmp_fundraising and Mobile Carrier Tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [01:02:09] (CR) jenkins-bot: [V: -1] DO NOT MERGE Dropping tmp_fundraising and Mobile Carrier Tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [01:02:13] (CR) Awight: "PS3: rebase" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [01:02:49] (PS4) Awight: Dropping tmp_fundraising and Mobile Carrier Tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [01:02:52] (CR) jenkins-bot: [V: -1] Dropping tmp_fundraising and Mobile Carrier Tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [01:04:18] (PS5) Awight: Dropping tmp_fundraising and Mobile Carrier Tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [01:05:22] (CR) Awight: [C: 1] Dropping tmp_fundraising and Mobile Carrier Tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [18:15:16] ejegg: K4-missing: I'd like to get this thing out soonish, to catch up with audit files: https://gerrit.wikimedia.org/r/178003 [18:15:51] hey PPena [18:15:54] ding [18:16:01] atgo hey [18:16:02] sup [18:16:12] this province thing - i assume we want to do that... quickly? [18:16:19] hmm not really [18:16:35] depending how hard that is… I got a handful of feedback on that [18:16:39] so no overwehlming [18:16:42] ok [18:16:49] but I guess something to adress [18:16:51] yeah it's not super hard, but nothing in the current work is in that same area [18:16:58] its not stopping ppl, but they want us to change it [18:17:02] so i'd rather keep it until there's more that is aligned with it [18:17:05] more birds with fewer stones :) [18:17:25] yepsis [18:17:36] awight: what did you do to mingle over the weekend? :P [18:17:54] atgo: I was gonna ask... if yr toes are bruised, sorry. [18:18:51] ejegg: and I hear people really care about this, like today: https://gerrit.wikimedia.org/r/#/c/177869/2 [18:19:01] I found one thing, fixed it here, https://gerrit.wikimedia.org/r/#/c/178058/ [18:19:08] I think... I wanted u to look at it. [18:19:24] hi awight [18:19:56] Hi! [18:20:06] so, there should already have been a label at [0], but I was overwriting it [18:20:27] lots of fun mixing 0 based and 1-based arrays [18:20:34] about to check in another patchset [18:21:07] yep that sounds right [18:21:17] that label..data format is heinous [18:21:18] will take a dive into the audit files as soon as I get that in [18:22:20] kthx! [18:22:41] yeah, that format on top of the 0-based hours and 1-based days really keeps you on your toes [18:23:00] next patchset will at least use the right bounds for the hour loops [18:28:34] AndyRussG: if you find yrself in a CR mood, https://gerrit.wikimedia.org/r/#/c/177758/ [18:28:54] awight: Hi! I'm always in a CR mood! [18:28:57] It has a slightly better chance of actually working [18:28:58] hehe [18:47:05] (PS3) Ejegg: Fix asymptote in $/sec graph [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177869 [18:47:07] (PS1) Ejegg: Completely disable graphs when not logged in [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178239 [18:48:47] pizzzacat: PS3 ^^^ should ignore spurious future donations [18:49:01] also, are you still having trouble running with the fake login in debug? [18:49:33] pizzzacat: I can rereview that asymptote patch... [18:49:44] AndyRussG: you didn't take your honeymug [18:49:48] she is so sad [18:50:01] atgo: huh? [18:50:11] remember you went to boba and we got mugs [18:50:17] and then we were like "be sure to get yours" and then you did not [18:50:54] ejegg yes I am still having trouble with it… [18:51:17] about to run it and try to figure it out again but I spent a big chunk of Friday doing that [18:51:19] atgo: I think I may have selective amnesia 'cause I'm not remembering ... (?!) [18:51:24] aww [18:51:29] But I'm sorry to have made boba sad [18:51:30] well... email me your address and i bet we can ship to you [18:51:34] pizzzacat: want to debug via hangout? [18:51:35] not boba, honey :P [18:51:51] ejegg, sure give me a second to save my current changes etc? [18:52:07] sure, I'm up for it whenever [18:52:14] cool [18:53:47] awight: where are you getting info about the better paypal mobile workflow? [18:53:48] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2250 [18:54:00] would like to confirm with prod team that this makes sense and is desired [18:54:32] atgo: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1941 [18:54:35] I believe [18:54:49] um hold on [18:54:56] atgo: uuhh... thanks... sure! If you remind me w/ more details I might remember (what was boba? for Thursday evening I did have an excuse for selective amnesia...?) [18:55:05] AndyRussG: just email me your address [18:55:07] :P [18:55:18] awight: this is not a 1-line fix, this is a new integration with Express Checkout [18:55:18] atgo: OK u bet! Thnaks :D [18:55:29] atgo: I see. one moment, please. [18:55:30] is it 1 line to do that...? [18:55:44] remember this is when we realized that omnipay had no way to deal with self-recurring? [18:57:34] atgo: ejegg: awight: a family member donated like a month ago and started getting FR banners again. On IE11... Has anyone heard other similar reports? Something worth looking into? [18:57:53] (PS1) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178242 [18:58:09] AndyRussG: that's weird.. did they clear cookies since then? on same machine, etc? [18:58:38] AndyRussG: if they can send you their cookies from wikimedia sites we can take a look [18:58:45] (Abandoned) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178242 (owner: Ssmith) [19:00:14] ejegg: atgo: In theory, cookies were not cleared, and it was on the same machine. he (my Dad) did send me the cookies in fact [19:00:17] brb! [19:04:00] PPena: do you remember us briefly looking into Mobile PayPal Standard Payments? [19:05:23] awight: we [19:05:25] oops [19:05:44] we've got lots to do as is in the sprint... paypal seems ok for now, maybe let's hunt this down another time? [19:06:25] Ino... this hunt is the purpose of me adding the card. [19:06:32] :P [19:06:33] Are we successfully using paypal on mobile? [19:10:22] (PS1) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178245 [19:11:28] (Abandoned) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178245 (owner: Ssmith) [19:13:03] (PS1) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] (X-by-Y-chart) - https://gerrit.wikimedia.org/r/178246 [19:14:13] ^ now it's in the right branch jeeze [19:14:28] good times, Gerrit [19:15:07] ha I read that recent email as "Bucket Test Rodeo" [19:15:25] yeehaw [19:16:20] :) [19:16:30] ok ejegg, I'm going to test the fake login patch one more time and then if it doesn't work we can hop into hangoutz [19:17:04] rockin [19:17:46] aaand it works ejegg... [19:18:01] I was having issues with my machine/mysql [19:18:17] that may have been the problem… ? [19:18:43] glad to hear that's resolved! [19:18:55] (CR) Ssmith: [C: 2] "Had some issues with my local that I've resolved; works great now." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177861 (owner: Ejegg) [19:19:10] ejegg: fyi I'm still getting js errors with the asymptote patch [19:19:16] (Merged) jenkins-bot: Fake login when running in debug mode [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177861 (owner: Ejegg) [19:19:32] I'll stuff more fake data into my civi db to cover up some of the issues :) [19:20:40] awight: aargh! What kind of errors? [19:20:53] ejegg: ok sorry, my db user didn't have access to the civicrm db [19:20:58] that's pretty basic. [19:21:06] Should have complained on the server, but whateve [19:21:38] (CR) Awight: [C: 2] Fix asymptote in $/sec graph [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177869 (owner: Ejegg) [19:21:45] (Merged) jenkins-bot: Fix asymptote in $/sec graph [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/177869 (owner: Ejegg) [19:21:51] yeah, there's still a bit to do in the way of error handling [19:22:06] Same with all the cruft I'm writing :-/ [19:22:31] 'nice to have' :P [19:30:32] awight i actually thought it was automated into a mobile mode if they recognized mobile device? [19:30:59] awight I remmeber us wanting to upgrade to Express Checkout [19:31:48] PPena: yeah the EC thing seemed like a good idea (for next year), but I vaguely remember this tiny change, where we send them _xclick, there was something like _xclick-mobile, which gave a better experience. Maybe I invented that after being abducted by aliens... [19:32:17] awight lol [19:32:27] awight shoul I ask our acc manager abt it? [19:32:58] PPena: that's wise. I think the keywords are "Mobile Standard Payments", and if there's anything we can do to streamline that workflow :-/ [19:33:01] thanks [19:42:20] awight: I take it we don't expect PayPal to be sending us version 4 audit reports any more? [19:43:43] ejegg: right. I was a little queasy though cos in theory it's nice to be able to process the old files. Oh well! [19:44:00] We'll still be able to process single-file v4 audit files, at least. [19:44:41] awight: looking at your patch documenting installation etc [19:44:47] pizzzacat: awesome [19:45:02] I have done the submodule update differently, does that mean you don't need to do an npm install? [19:45:13] seems to be! [19:45:16] since it grabs from the repos [19:45:19] yep [19:45:32] cool [19:45:38] I guess we should still mention the normal npm install thing if people want to develop, though... [19:45:42] (CR) Ssmith: [C: 2] document how to install and run [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178049 (owner: Awight) [19:45:45] (CR) jenkins-bot: [V: -1] document how to install and run [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178049 (owner: Awight) [19:45:49] oof [19:46:15] one tiny change - port is in defaults.js or a separate config file you can point to with -c [19:46:26] config.js is the actual config-reading logic [19:46:32] right! [19:48:01] (PS3) Awight: document how to install and run [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178049 [19:48:03] (CR) jenkins-bot: [V: -1] document how to install and run [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178049 (owner: Awight) [19:48:05] (PS4) Awight: document how to install and run [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178049 [19:48:13] kdone [19:48:34] (CR) Ejegg: [C: 2] document how to install and run [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178049 (owner: Awight) [19:48:40] thanks for the dox! [19:49:12] (CR) Ssmith: [C: 2] "Good idea. Should we be doing this for all widgets/the fredge db as well?" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178057 (owner: Awight) [19:49:17] (Merged) jenkins-bot: CiviCRM database name is configurable [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178057 (owner: Awight) [19:49:51] pizzzacat: imo yes ^^ [19:50:01] ok [19:50:09] err, fredge is already a config param, isn't it? [19:50:25] and actually I donno what is meant by "do this for all widgets" [19:50:26] it is. but it's not being used in the widgets [19:50:35] so like you are in big-english.js [19:50:47] if you go to fraud.js it's just hardcoded [19:50:48] well, if it's the default db, you don't have to qualify table names [19:50:56] oh, ok [19:51:08] (CR) Ejegg: [C: 2] "Looks good! On an unrelated note: python, why u no have switch statement?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/178003 (owner: Awight) [19:51:10] it just assumes fredge if another isn't specified [19:51:19] ? [19:51:27] * pizzzacat looks again at config [19:52:29] that isn't apparent to me by looking at the config, since in the widgets/fraud.js file there is no db param used [19:52:42] ejegg: you're supposed to use higher-level dispatch lookups :p [19:53:10] pizzzacat: the default db connection used in data.js points to the fredge db configured in defaults [19:53:20] pizzzacat: I think you're good, cos grep -r fredge results in just the config file [19:53:47] I see that now, it just wasn't obvious from reading the code (ie I didn't realize that was how it worked though it seems obvious now, because how else would it have worked) [19:54:09] thanks for filling me in y'all [19:54:34] (CR) Ejegg: [C: 2] "Plug the outlets! Lock up the cleaning products!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/178004 (owner: Awight) [19:54:36] (Merged) jenkins-bot: Safety thing prevent overwriting files [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/178004 (owner: Awight) [19:55:31] (CR) Ssmith: [C: 2] "super nice optimization! had to read docs to get the actual difference. thanks for catching this!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178239 (owner: Ejegg) [19:59:47] (Merged) jenkins-bot: Completely disable graphs when not logged in [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178239 (owner: Ejegg) [20:01:59] (CR) Ejegg: [C: 2] "Appears to be in order" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/177713 (owner: Awight) [20:05:28] (PS2) Awight: Warn if a campaign's bucket assignments look funky [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177475 [20:08:47] anyone for lunch? [20:08:59] pizzzacat: is there conf room lunch? [20:09:09] I have no idea? [20:09:40] gonna check [20:11:17] they said yes, some food is coming soon [20:11:30] mmm nom [20:11:30] <:o) [20:12:00] nooom [20:18:16] (PS1) Awight: WIP Add banner includes bucket dropdown [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/178260 [20:18:48] Hey guys. I turned off fredge qc. [20:18:59] ...will delete dumb message in a minute. [20:19:09] Oh, that same thing again? [20:19:15] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178261 [20:19:16] yep. [20:19:21] Third-ever time. [20:19:25] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178261 (owner: Awight) [20:19:27] I thought we deployed a fix for that. [20:19:29] awight seems to be deploying his fix [20:19:34] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178261 (owner: Awight) [20:19:34] Aha. [20:19:37] yep [20:19:37] . [20:19:43] Well, maybe I won't delete the message, then. [20:19:46] Immediate test. :) [20:19:58] hey awight is there a card for that fix? [20:20:06] one moment please :) [20:20:17] danke :P [20:20:26] !log updated crm adfbbecbf949932932a3b6bc8c20c15e2a8054b2 to c9b733f0963a04ab1174ede0d5641e9b884747c8 [20:20:29] Logged the message, Master [20:20:38] that was cool. random confirm code=wmf5 [20:22:30] hey awight ejegg civi is being funky for both Michael and me [20:22:37] funky how? [20:22:39] really slow searches and errors returning for results [20:22:53] ccogdill: can u give an example search? [20:23:01] for the past 20 minutes at least [20:23:17] I’m searching by email address in Advanced Search so probably can’t send over IRC [20:23:28] that's enuf info, I think [20:23:41] I can send a screenshot of the error if that helps too [20:23:49] oh yes please do [20:24:01] k will email! [20:24:45] awight: pizzzacat looks like noms are her [20:24:46] e [20:54:51] atgo: awight: ejegg: Here're Minglh updates: [20:55:25] - Completed and cleaned up 2136 (already deployed) [20:55:36] - Filled in 2185 [20:55:49] -Filled in 2229 as best I could for nw [20:55:50] now [20:56:26] AndyRussG: you missing standup? [20:56:33] Turning fredge qc back on [20:56:37] ok [20:56:46] ....d'oh. [20:56:53] awight: Disabling. [20:56:56] argh [20:57:03] looking at wreckage... [20:57:16] Same thing, looks like. [20:57:23] eff. [20:58:19] awight: You want to take another crack at this, or should I just kill the message and re-enable? [20:58:25] K4-713: nah lemme fix it [20:58:36] unless they're raring for the data? [20:58:48] atgo: no... starting 5 min, no? [20:58:59] oh cool :) [20:59:02] ooooh mingle [20:59:04] awight: I know of nobody who is... frothing over right now. [20:59:07] ... [20:59:13] I stand by that statement. [20:59:31] It's just the trailer for my standup [21:00:03] * AndyRussG sings, "It's time to put on makeup, it's time to light the lights" [21:00:13] * AndyRussG now flees [21:19:05] hey AndyRussG.. if ccogdill can get a hold of some donors and ask them to look into the cookie, what should they be looking for? [21:19:10] to see if they have that particular cookie [21:19:38] centralnotice_hide_fundraising, i think [21:19:59] ccogdill: ^ [21:20:54] I don’t think I have that cookie ejegg [21:21:05] me neither... but i definitely have whatever the right one is [21:21:48] hmm, we're definitely looking for centralnotice_hide_{category} [21:21:53] atgo: ejegg is right, I think... Also tell us pls what browser, browser version, operating system and when they donated [21:22:02] ejegg: could the donation method used also impact maybe? [21:22:11] atgo: also ^ [21:22:14] we can also check that all of the banners have the correct category [21:22:35] nevermind ejegg I found it [21:22:40] me toooo [21:22:42] was just hiding under mediawiki.org [21:22:46] :D [21:23:05] AndyRussG: it's possible - the cookie is set on the thank you page, so if one method isn't redirecting properly it might have that problem [21:23:05] we have windows 7, IE 11 for one donor [21:23:16] enables cookies, re-visited TY page and still seeing them [21:23:46] ccogdill: can you also put that here: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2259 [21:24:22] ccogdill: interesting, I thought it should also exist for *.wikipedia.org [21:24:36] or rather, .wikipedia.org. [21:24:38] (PS1) Ssmith: Merge master and gulp for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/178274 [21:24:56] Let me check the thank you page [21:25:04] hmm maybe it does [21:26:49] I have a bunch of centralnotice cookies under en.wikipedia.org, but none are the hide_fundraising one. it seems the fullscreen cookie is there [21:27:08] ooh, that seems like a problem [21:28:51] atgo: ccogdill: ejegg: sounds similar to my Dad... Also on IE11 in fact [21:28:58] grr IE [21:29:05] ahHA [21:29:07] ! [21:29:40] ccogdill: atgo: ejegg: also need to confirm that the user didn't clear out their cookies or browser history any time since they donated [21:29:43] Huh, the thank you page seems to be loading the HideBanners in all the right places. [21:29:54] ejegg: are you in IE11? :P [21:30:03] Ooh, IE might not be allowing 3rd party cookies because we don't have a P3P header! [21:30:12] AndyRussG we definitely confirmed that with the donor I’m talking about [21:30:29] he revisited the TY page multiple times after making sure he didn’t clear his cookies [21:31:08] grrrrrrrr IE [21:31:27] ccogdill: OK thanks...! [21:31:45] atgo: was just making sure latest version of the TY page had image tags loading HideBanner from all the domains [21:32:30] ejegg: I'm wondering if we could write a test banner which would check and report cookies, explicitly... [21:32:49] then the victims just send us a screenshot... [21:32:49] awight: interesting! [21:33:17] and show the useragent just for good measure [21:33:32] totally. [21:33:44] heck, even the banner allocation data from RL [21:34:28] yeah I think the especially interesting stuff to instrument is what happens between the user's browser and our banners... e.g. getting their cookies is difficult and technical to do over the phone... [21:34:40] but it has to all fit on one page :p [21:34:44] right [21:35:24] is there a reason that we don't like ejegg's p3p header idea? [21:35:43] https://www.mediawiki.org/wiki/Special:CentralAutoLogin/P3P [21:35:49] atgo: we don't like that it might be the bug :p [21:35:56] aha [21:36:02] atgo: nobody is saying not to pursue that lead though [21:36:16] dumping the donor's cookies is part of debugging whether p3p is the issue [21:36:19] ejegg: awight: sending you the cookies I got from my Dad [21:36:25] thanks! [21:36:28] awesome. [21:37:59] http://arstechnica.com/tech-policy/2012/02/google-tricks-internet-explorer-into-accepting-tracking-cookies-microsoft-claims/ [21:38:22] So, was wp sending P3P stuff till recently? [21:38:28] I'll ask around [21:38:35] ejegg: thought you meant worldpay :P [21:40:56] ejegg: awight: quick pointer to where donate cookies should be set from? [21:41:37] AndyRussG: those are coming from Special:HideBanners [21:41:51] which is sourced from several domains on the thank you page [21:44:30] (PS1) Awight: Make fredge data validation exceptions recoverable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178276 [21:44:32] K4-713: fredge fix ^^ [21:44:43] awight: You need CR, then? [21:44:54] I have... completely ruined everything on my local. [21:44:59] (PS1) Awight: debugging task to import a single fredge message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178277 [21:45:01] *thumbs up* [21:45:19] TOTALLY OKAY OVER HERE. [21:45:26] :p [21:45:53] turns out the message is actually coming over the wire wrong, the db_insert placeholders needed fixin but were not the issue in this case. [21:46:21] ejegg: the ty page is in DI, right? [21:46:22] orly [21:46:29] AndyRussG: nope, in CN [21:46:35] K4-713: yeah donno how I missed that the first time. [21:46:38] * AndyRussG double takes [21:46:40] ah woops [21:46:47] K4-713: And, NO CLUE what's causing that in DI [21:46:54] it's a little scary [21:46:55] hhhuh. [21:47:01] Are you completely sure that's what's... [21:47:12] Because I pulled a message straight out of AMQ and it looked fine. [21:47:16] Hang on, let me just... [21:47:19] oh? [21:47:24] well it could have been both... [21:47:33] but that's weird. [21:48:06] ejegg: ? I know about Special:HideBanners, but I don't see a Special:ThankYou... [21:49:23] awight: I take it all back. [21:49:25] That's insane. [21:49:35] me too. [21:50:37] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/178279 [21:51:28] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/178279 (owner: Awight) [21:51:34] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/178279 (owner: Awight) [21:52:08] !log updated tools from 06e69f0bd1a1f74eb8055f5300b48ad3b78eedea to 88b57fea517d2232e8ae906df550f426b6574f24 [21:52:09] (CR) Katie Horn: [C: 2] "Interesting..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178277 (owner: Awight) [21:52:11] Logged the message, Master [21:52:28] (Merged) jenkins-bot: debugging task to import a single fredge message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178277 (owner: Awight) [21:53:31] ccogdill: heads-up, we're processing that PayPal audit file from last week. [21:53:47] awesome [21:53:56] no more TY lags after that? [21:53:58] ccogdill: like we thought, a few new donations are coming in, and will receive a late thank-you [21:54:03] ccogdill: nothing planned :p [21:54:26] (CR) Ssmith: [C: 2] Merge master and gulp for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/178274 (owner: Ssmith) [21:54:33] haha okay [21:54:33] (Merged) jenkins-bot: Merge master and gulp for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/178274 (owner: Ssmith) [21:54:34] ccogdill: I can get u an exact count, if that's helpful [21:54:35] thank you awight [21:54:37] awight: Are you going to pull that message off manually and make a file or something? [21:54:47] K4-713: I already did, you want? [21:54:53] Nope! [21:54:58] that’s okay awight, if it’s as low as you thought it was there’s no need [21:54:59] I was just... hovering over The Button. [21:55:00] but I'm leaving the msg in there, to live-debug this thing [21:55:07] orly [21:55:07] ccogdill: ok [21:55:26] * K4-713 wonders how many conversations awight can have simultaneously before the lag starts being noticable [21:55:53] awight: Just met me know when fredge is back online [21:55:54] He can also CR at the same time [21:56:04] See, now that worries me. [21:56:05] :p [21:56:30] Unless it all goes -1 for whitespace. [21:56:53] ccogdill: yeah it was < 100 new donations [21:56:59] yeah no sweat [21:57:24] K4-713: I still need CR on https://gerrit.wikimedia.org/r/#/c/178276/ [21:57:27] sheesh guys [21:57:37] K4-713 your chart is working :) [21:57:48] AHA [21:57:50] I missed that one. [21:57:55] Also: WOOT. [21:58:07] OK everyone, seriously. Look less busy, we have positions to fill... [21:58:21] YAY, there's stuff that makes sense there! [21:58:30] yay stuff making sense! [21:58:54] ok cool [21:58:58] i mean, OH COOL [21:59:38] WHY DID I START YELLING. [21:59:40] according to that graph, we'll be okay even if it's night for the rest of the month [21:59:41] ...sorry. [21:59:50] Ha, kind of. [22:00:00] Night on... one of the first week days. [22:01:04] ...there is one tiny thing I want to change, there... [22:01:21] but I'm not super excited about that. [22:01:30] It's doing the thing. [22:02:01] Yeah, if you zoom in on the first couple of days, night was well above the line. [22:02:06] It's going to get closer and closer. [22:02:39] Also, check it out: You can see the emails. [22:02:47] K4-713: the super multitask challenge: change diapers, code review, file bugs and make silly jokes [22:04:06] AndyRussG: hey u have no more diapers. Let's change the challenge to, help with homework OR change diapers. [22:04:20] OR play with pet guinea pigs or jellyfish. [22:04:35] Either way I'll still win 8p [22:04:41] or find pet jellyfish (escaped / eaten / dissolved) :( [22:04:45] I bet! [22:04:56] I mean lose [22:05:02] I meant you'll still win! [22:05:24] * K4-713 looks sad [22:05:25] See I start multitasking and that happens! [22:05:39] K4-713: ? [22:05:47] You ate the jellyfish? [22:05:56] Noway. [22:06:01] jellyfishremorse? [22:06:07] Jellyfish are not vegetables. [22:06:12] ...I think. [22:06:25] I mean, I'm not a doctor. [22:06:52] (CR) Katie Horn: [C: 2] Make fredge data validation exceptions recoverable (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178276 (owner: Awight) [22:07:33] oh no, katie's gonna be sick! [22:07:43] I hope you don't dissolve like the j-lo fish did [22:07:56] I may already... [22:07:59] ...have. [22:08:01] Slightly. [22:08:34] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178286 [22:08:44] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178286 (owner: Awight) [22:08:48] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178286 (owner: Awight) [22:09:09] Okay, back to my jerky IDE jerkily deciding to ruin everything. [22:09:19] !log update crm from c9b733f0963a04ab1174ede0d5641e9b884747c8 to 77e99a530b7c3910ca521923d97830df08a4d1b1 [22:09:22] Logged the message, Master [22:09:27] K4-713: still have yr finger on the button or shall I? [22:09:33] I had it in "make a colossal mess" mode. [22:09:38] Ah, I think I still have it... [22:09:51] it's worth another try [22:10:14] awight: I think it's happy again. [22:10:39] ohgood... I wonder if we get a failmail. [22:10:56] awight: Looks like yes. [22:11:06] cool. [22:11:15] hey the link even works. [22:11:18] case closed [22:11:34] except for identifying the original source of heinous data [22:11:48] amazon going nuts, one out of several thousand times? [22:11:59] right [22:12:00] RIGHT [22:12:10] BACK TO THE YELLING [22:12:31] (that was a terrible movie) [22:12:56] donno the reference. [22:13:46] but they're feeding me all this peaceful French music crap over the radio and I just want to shake everyone, IT'S NOT OKAY. kick the Le Pen scum back to the caucasus... [22:14:34] I was just telling somebody the other day: The easiest way to send me in to a rage, is to give me the impression that you're trying to calm me down. [22:14:43] exactly [22:14:51] just calm down >_> [22:15:00] Canon in D? KATIE SMASH. [22:15:08] I actually had to look over my shoulder [22:15:20] kick him in the pachelbelly! [22:15:25] Tacobell. [22:15:31] Tacobell cannon? [22:15:39] that would be a funny fast-food hack. [22:15:46] That would be way better. [22:15:50] "maintain" in-store PA [22:15:57] the name's buttle, not tuttle. [22:20:46] AndyRussG: I didn't find any commits that changed P3P headers, but the CentralAuth extension definitely adds one for its own cross-domain login cookie. [22:21:12] ejegg: Hmmmm [22:21:32] snagging an IE11 VM from modern.ie to verify [22:21:50] ejegg: K thanks [22:21:53] ejegg: we have a crossbrowsertesting acct, too [22:23:32] awight: oh yeah, that oughtta work! [22:24:25] ejegg: U saw that my Dad only had reason=close hide cookies, I guess... [22:25:05] K4-713: https://www.youtube.com/watch?v=JdxkVQy7QLM [22:25:42] AndyRussG: right, that gets sourced from all the domains including the one you're on. So it should indeed get set as a 1st party cookie in IE [22:26:20] ejegg: Yeah! I mean, if all the close cookies weres et correctly... [22:28:54] atgo: This is amazing. [22:29:02] :P [22:31:05] (PS1) Katie Horn: Logging changes for DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/178337 [22:32:30] Hey, can somebody ^^? [22:32:41] on it! [22:32:45] ty! [22:33:06] I'm... going to get some red bull and try not to think about cello music. [22:35:25] (CR) Ejegg: [C: 2] Logging changes for DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/178337 (owner: Katie Horn) [22:36:42] awight could I bother you about something cmdliney? [22:36:44] (Merged) jenkins-bot: Logging changes for DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/178337 (owner: Katie Horn) [22:36:48] irl I mean? [22:43:24] pizzzacat: sudo scutil --set HostName larryx.local [22:46:21] https://github.com/raychatter/bash-git-prompt [22:46:29] rainbowy goodness [22:46:38] the original is less rainbowy [22:46:42] but that's zzzzzz [22:52:54] Okay, totally going to do a payments deploy. [22:52:58] Should be... wait. [22:53:04] Better. [22:53:31] Shouldn't actually do anything anybody but dedicated log tailers would notice. [22:53:48] * greg-g looks around [22:53:57] Nah, you're okay. :p [22:54:01] :P [22:58:11] (PS2) Awight: Add banner includes bucket dropdown [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/178260 [22:58:17] (PS1) Katie Horn: Merge branch 'master' into deploy [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/178357 [22:59:33] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/178357 (owner: Katie Horn) [23:05:12] atgo_: u have any sprint work to kick towards me? [23:05:25] ejegg: K4-713: pizzzacat: AndyRussG: or can I help with anything? [23:05:25] what do you mean, sir? [23:05:30] will work for beer. [23:05:34] beeeeeer [23:05:39] woah [23:05:39] the fridge btw... it has beer. [23:05:41] who? [23:05:53] there are 5 cards in ze backlog [23:05:58] O_o [23:06:00] awight: got some sample WPUS reports? [23:06:06] atgo: 1 card [23:06:06] awight: thanks.... yea ^ atgo speaks truth [23:06:15] ejegg: yessir, privchanning [23:06:26] I was actually just thinking about saying "hey team - calling in as your SM here... what do you think about de-scoping the sprint a little bit?" [23:08:24] gah [23:10:13] hmm.. i'm going to work on burndown charts moving forward :P [23:10:31] Must roll back, something went funny. [23:11:00] yipes [23:11:18] It wasn't that funny. [23:11:53] ...like, four errors. [23:12:09] And three of them were the same person. [23:12:11] fast work! [23:12:22] Nah, it's just edgecasey. [23:12:30] Hrm. [23:12:48] Great. It's complaining about the generic log function. [23:13:28] ...probably something getting called by the DonationData object being constructed. [23:15:45] !log revlocked payments wiki to 30f15865bc4efe3b2b [23:15:49] Logged the message, Master [23:23:59] ejegg: looking at the P3P code in CentralAuth, it does set something, but it's not actually a valid policy :) [23:24:21] [23:24:23] // Note this policy is not valid: it has no valid tokens, while [23:24:23] // a valid policy would contain an "access" token and at least [23:24:23] // one statement, which would contain either the NID token or [23:24:23] // at least one "purpose" token, one "recipient" token, and one [23:24:24] // "retention" token. [23:24:26] $url = Title::makeTitle( NS_SPECIAL, 'CentralAutoLogin/P3P' )->getCanonicalURL(); [23:24:29] header( "P3P: CP=\"This is not a P3P policy! See $url for more info.\"", true ); [23:24:33] [23:24:39] Well, if it's good enough for CentralAuth... [23:24:53] K4-713: ejegg: atgo: ^ I dunno... Legal implications? [23:25:06] And google: http://arstechnica.com/tech-policy/2012/02/google-tricks-internet-explorer-into-accepting-tracking-cookies-microsoft-claims/ [23:25:11] huh? [23:25:34] Yeah, me too. [23:25:37] PPena: I need some more infos about https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2222 [23:25:38] ejegg tracked down the IE 11 issue :) [23:25:41] AndyRussG: I'd say re-using what our login code already sends shouldn't be too risky? [23:25:43] PPena: did you get a thank-you email? [23:26:00] The problem is that IE 11 doesn't accept third-party cookies that don't set a P3P policy [23:26:17] http://en.wikipedia.org/wiki/P3P [23:26:26] It's a privacy thing [23:26:40] There is code to do it that we coud copy from CentralAuth [23:26:48] I think it's all IE since v6 or 7, actually [23:27:05] AndyRussG: sorry I haven't looked around enough to understand the problem yet, but... these are not third-party cookies? [23:27:16] we actually visit each subdomain. [23:27:29] awight: they are when you source 'em as an img tag from the ty page [23:27:33] ah ok [23:27:44] yeah, the close cookies are OK [23:27:47] ejegg rocks [23:27:59] GAH. Amazon is doing something funny in the constructor. [23:28:03] ^^unrelated to anything [23:28:05] K4-713: aha [23:28:08] * ejegg has just had to deal with IE for too many years [23:28:27] Hmmmm 8p [23:28:42] PPena: nvm! I just saw you already pasted the order IDs, thanks! [23:29:04] atgo: K4-713: so we could copy CentralAuth code, but that just sets a "fake" privacy policy statment, or something like that (see code quoted above) [23:30:06] whatever you guys think is right is fine by me [23:30:07] :) [23:31:56] Hmm. [23:32:07] I... don't like it. [23:32:49] I don't suppose you can git blame and track down an issue number... [23:33:30] In fact, please do that thing I just said. :) [23:34:16] looking [23:34:45] I just want to see the discussion behind it. [23:34:49] Btw, our logs are awesome. I just found everything I could have hoped for and more... [23:34:52] the answer was 42. [23:34:58] I could have tol you that. [23:35:09] Did you realize that was a joke in base 13? [23:35:09] one moment please, processing question... [23:35:13] no. [23:35:24] no it's not. [23:35:28] Yes. [23:35:35] 54 base 10 [23:35:37] why a joke [23:35:45] Remember what the wrong question was? [23:35:52] mm no [23:35:54] 6*9 in base 13, is... [23:35:59] awww man [23:36:16] I thought it was just what is 6x7 [23:36:41] youch [23:37:12] so... god has 13 fingers? [23:37:35] I don't know about that. [23:37:42] Yeah, Hawking is all amped up about his movie + sez Feynman is right, we're doomed if computers ever become as "intelligent" as us [23:37:43] The important thing is, we don't. :) [23:38:02] there will be a lot of "made you look" [23:38:02] wth...? [23:38:11] atgo: 42? [23:38:19] ahh yes [23:38:20] * awight puts on tin foil singularity-weathering cap [23:38:30] K4-713: change ID adding P3P to CentralAuth is Ibf6e271f4d018be2a53289f2c0092e88bbcc01ee [23:38:38] buh [23:38:39] not seeing a bug id [23:38:45] * K4-713 sighs [23:38:53] You know what I miss about my last job? [23:38:59] Very, very little. [23:39:15] atgo: do you remember why we dusted off https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 ? [23:39:22] But, in that tiny set? Every commit *had* to be cross-referenced with a bug, or it got rejected. [23:39:30] awight: because losing recurring donations [23:39:43] atgo: are we? there's no more info attached to the card... [23:39:47] Is there an email or something? [23:39:49] yeah i have no idea [23:39:58] ccogdill: ^^ u know things about this? [23:39:58] someone put it in the "prepare for big en" supertask [23:40:08] I think out of raw paranoia [23:40:15] Me? [23:40:21] <_< [23:40:42] it was K4-713! [23:40:47] WOOT. [23:40:48] uhh about recurrings turning into one-times? [23:40:49] What did I do? [23:40:59] awight? I think this got fixed awhile back but I could be wrong [23:41:13] 1570 is a low number. [23:41:14] ccogdill: well I don't think we ever 'fixed' anything, just didn't see it happen again [23:41:19] I run my handy little recurring query bi-weekly to make sure we’re not seeing high failures [23:41:32] well, I guess that’s good enough for me [23:41:38] Harumph. [23:41:40] i'm happy to let this one go [23:41:49] ccogdill: this issue would only be surfaced by a donor calling us... 2 months after their first donation, and complaining that we weren't taking enuf of their money [23:41:53] Tonight, on Unsolved Mysteries... [23:41:54] I don't know the odds of that [23:41:59] low-ish? [23:42:12] So... the thing is... no query on Earth is going to be able to tell us if this is going wrong. [23:42:17] ino [23:42:18] ccogdill: this is the one where it happens when they make the donation in the first place [23:42:25] so it never goes in as "recurring" [23:42:26] yep [23:42:27] and you won't see dropoff [23:42:36] OK i can spend an hour looking at logs for other instances of this... [23:42:40] that seems reasonable. [23:42:40] * atgo has actually learned something [23:42:50] awight: yeah, let's timebox this one, too [23:42:52] Unless they email you to complain, we would never even notice a problem, because it happens so early. [23:42:54] oh I see [23:43:00] Ha. [23:43:02] Paranoid. [23:43:02] well I haven’t been seeing complaints about this in a long time [23:43:23] * awight mulls what kind of snacks are going to be helpful for this. [23:43:26] The problem with this, though, is that it is likely to take at least a month. [23:43:34] sure [23:43:36] awight: if you can't find more examples then let's just let it go [23:43:37] ...for people to go "why didn't you bill me after a month". [23:43:42] yeah it would be sad to have a wave of this in Jan/Feb [23:43:50] I would cry. Secretly. [23:43:50] although... now it's too late :) [23:43:53] that happened last December [23:43:55] in a way [23:43:59] grrmph [23:44:17] awight: did you make a card to follow up on the NZ merchant issue? [23:44:26] atgo: no, will do now [23:44:27] thanks [23:44:41] PPena: can you try WP in CAD again? [23:44:49] last time it was because you tried again too quickly :P [23:44:50] sure [23:44:54] oki [23:44:55] yep [23:45:04] we can confirm there's an issue with NZD that we'll look into [23:46:14] atgo CAD worked! [23:46:23] great [23:46:30] did you test GB and AU as well? [23:46:38] (remember, you have to wait 15 min now) [23:46:44] or 5. i can't remember [23:46:51] it's 5, we tell donors 15. sorry. [23:47:07] thx for the card awight [23:47:18] of course [23:47:18] ...rats. [23:47:32] * awight is slightly crept out by atgo's realtime feed [23:48:08] atgo ok will try GB and AU [23:48:21] did u check was the problem was before? was it timming too? [23:48:30] the CAD was too quickly, yes [23:48:35] thanks to awight looking that up [23:48:51] but NZ is broken, so we'll work on it [23:54:15] awight: is the file with the error from ccogdill's email about civi sensitive or can i put it in a mingle card? [23:54:37] sorry for not making that card yet, atgo :/ [23:54:42] it's all good :) [23:54:54] atgo: sensitive enuf... fileserver would be better thx [23:54:56] ok [23:55:10] atgo: thanks for the cards! IMO this is two issues, but we can deal with that later... [23:56:51] hmmm ok [23:56:56] that seems like a weird coincidence [23:56:59] but stranger things have happened [23:57:58] K4-713: this card seems like.. it's going to be forever. like it's an ongoing thing, you know? not sure what we should do with it... https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2063 [23:58:26] atgo: well, we just made changes to how civi contact merge works. [23:58:26] atgo: Well, at this point, yeah. :/ [23:58:36] Well Something Else. [23:58:41] rrrgh [23:58:43] :) [23:58:48] I spared you a jink [23:59:10] I am genuinely concerned with how frequently I seem to be reading people's minds lately. [23:59:17] haha [23:59:49] I wonder if I could use wellness money to go to x-men school. [23:59:56] Seems legit.