[00:00:04] dang, PS2 passed tests? [00:00:30] ejegg: Do you test those locally? [00:00:54] yeah, and it failed with time() but worked after your patch [00:01:00] neat [00:01:29] I'm sort of unsurprised that it would mostly let people through and fail intermittently. [00:01:35] though it could pass with time() on a really slow machine or if the test lands on the edge of a second [00:01:37] That's... totally what we're seeing in prod. :/ [00:02:03] aaight, I'm getting this thing out the door. [00:03:11] ... [00:03:24] If I had a dollar for every time I typed "fir" instead of "git" at the command line... [00:03:47] they should add that to sl [00:03:50] awight: quoted now on Twitter, "And looking forward to IE9 soon!" [00:03:57] jk [00:04:19] (CR) Ejegg: Test that two GC API requests send different info [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/178713 (owner: Ejegg) [00:04:48] ln -s /usr/bin/git /usr/bin/fir [00:05:48] :) [00:06:09] "fir pull" sounds like some kind of lumberjack contest up a mountain somewhere. [00:06:26] ...I won that once. [00:06:28] goes well with all the log tailing we do [00:07:25] (PS1) Katie Horn: Merge branch 'master' into deploy [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/178719 [00:07:49] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/178719 (owner: Katie Horn) [00:09:18] (Merged) jenkins-bot: Merge branch 'master' into deploy [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/178719 (owner: Katie Horn) [00:09:20] ejegg: oww, I'm sad about PS2 passing [00:10:15] That's totally what was happening in prod, too! [00:10:16] awight: yeah, that shouldn't happen. Trying again locally w/o K4's update [00:10:22] Different or same second. [00:10:31] Totally makes sense. [00:12:00] K4-713: why still have the time-based potential race... [00:12:20] u trust the clock to tick more than pseudorandom gibberish? [00:15:56] K4-713: they had to be in the same second, and the second one had to get there after the first one had staged up order id, but before the curl response had come back from GC [00:17:48] No, that's not quite right. Same second led to identical merchant ref, while the 2nd starting between 1st one's staging and 1st one's response processing led to identical order id [00:18:23] !log updated payments to 21afbcf24c0e2124f78 [00:18:26] Logged the message, Master [00:19:09] Well, either way, this should be different now. [00:19:14] Either way. [00:19:30] I say that as if there were only two possible items in the hairball. [00:23:13] K4-713: you want to see something RL to ease the stress? [00:23:20] yes [00:57:21] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178736 [00:57:28] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178736 (owner: Awight) [00:57:33] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178736 (owner: Awight) [00:58:40] !log update crm from 94997a37a6531f2f1d5074895d5fa2da947e03f0 to d22dce0a375be3c5f32afc472fff550a5edf6a1e [00:58:46] Logged the message, Master [01:08:04] has anyone been having issues with the node-syslog package? [01:08:38] it was working fine for me for the past several days… then I installed a new lib today and it's complaining [01:08:44] just like you saw before trying to run under any version except 0.8.2 [01:08:50] I haven't, but that's totally unhelpful for me to say because I didn't try anything, either. [01:08:55] I'm using 8.2 [01:09:07] haha thanks K4! thanks. [01:09:23] Any time I can say something totally unhelpful, you know where I am. :) [01:09:32] pizzzacat: in node_modules, does git status say node-syslog has been updated? [01:09:36] heheh [01:09:42] I wonder if your other package also depended on it [01:09:53] and changed the version when you installed [01:10:44] hm that would be weird! oh and nevermind, it was a bower package anyway. but no, the status doesn't say it's been updated [01:11:03] argh, what a pain. Which error is it failing with? [01:13:19] one sec I think I might know what's going on [01:14:48] K4-713: I'm sad because https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2275 [01:15:31] ejegg it looks like the patch to add node-syslog wasn't merged in node_modules? [01:15:41] https://gerrit.wikimedia.org/r/#/q/project:wikimedia/fundraising/dash/node_modules,n,z [01:15:42] oh snap, really? [01:15:52] looks that way [01:16:04] let me see. [01:16:06] (CR) Ssmith: [C: 2] Update node modules [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/177012 (owner: Ssmith) [01:16:26] * awight shields eyes [01:16:33] just CR'd it [01:16:50] awight: What? [01:17:24] Is there something I'm missing... the stupid files come in random order... so I'm stuck reprocessing one file from August [01:17:25] There should be large bits of code that run multiple files. [01:17:29] command line params, even. [01:17:33] oh... [01:17:36] looks like I specifically need 1.1.7 [01:17:41] And, they totally shouldn't come in random order. [01:17:56] they do because of dumb filename [01:17:57] The directory read should parse out the dumb file format into an actual date. [01:18:03] ...in an array. [01:18:06] hrm [01:18:08] ok [01:18:08] In real order. [01:18:25] it's sounding increasingly annoying to make the two audit formats coexist in the same module. [01:18:48] It... really shouldn't matter, so long as the thing using the parser is consistent. [01:18:49] pizzzacat: if you do a git log node-syslog in node_modules, do you see this: bc283830cac9628533227c08e0fbaeed0e0e1b1b ? [01:19:02] 'Rebuild node-syslog for node 0.8.2' [01:19:07] That's why I wanted the audit file parser to be as dumb as possible. [01:19:20] So the controlling job could... decide things. [01:19:33] I guess I haven't actually seen the new stuff. [01:20:19] ok cool. I just need to make worldpay_audit_get_recon_file_date parse both formats [01:20:45] aaaaaaaaha [01:20:55] I'm getting sadder. [01:20:56] That might be slightly interesting. [01:21:16] I'd really prefer if the magic were done OO-style rather than this drupal hook wizardry [01:21:31] then, I could just slightly override the objects and pass them both to the controlling process. [01:22:39] Enough to rewrite for this? [01:22:46] :( [01:23:21] one last question (i think): if a file cannot be processed cos logs are missing. Is that file stuck in purgatorio forever? [01:23:44] There should be a command line param for that too. [01:23:49] Unless I failed to write one. [01:24:04] I thought the mechanism waited a number of days and then sent it to completed, though. [01:24:12] Staleness should be taken into account somewhere. [01:24:13] ok that sounds good. [01:24:24] That was one of the big things I wanted to fix about that beast. [01:24:35] Cos I'm seeing that this one stale file is using the only processing slot available... [01:24:42] I'll play with cmdline opts [01:24:43] and stuff [01:24:48] I don't like that "only slot" premise, either. [01:24:53] me neither! [01:24:55] Default should be three for some reason. [01:25:02] It certainly wasn't "one". [01:25:15] That's insane. [01:25:54] (CR) Ssmith: [V: 2] Update node modules [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/177012 (owner: Ssmith) [01:28:37] ^ will this auto-merge? [01:29:17] pizzzacat: let me test that locally before we hit submit [01:29:31] I know the one that's in there now is working on prod [01:30:25] (PS1) Awight: Parse datestamp in both WorldPay audit file formats [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178742 [01:30:32] K4-713: if it looks fun ^^ [01:30:39] "fun" [01:30:42] :) [01:30:47] ok sounds good ejegg thanks! [01:30:49] Will Not Define [01:30:50] It's all relative, isn't it? [01:31:07] pizzzacat: I think maybe that package is system-dependent [01:31:14] Well there's always wearing the placard, if this doesn't sound fun :p [01:31:22] awight: Ha. [01:31:24] I try to run yours and I get 'invalid ELF header', basically a bad executable [01:31:31] ejegg is that different than previously? [01:31:46] pizzzacat: take a look at http://git.wikimedia.org/summary/wikimedia%2Ffundraising%2Fdash%2Fnode_modules.git [01:32:24] I had to rebuild node-syslog for 0.8.2/ubuntu-y systems on 10/21 [01:32:27] wtf is a binary doing in there [01:32:33] awight: yah, I dunno [01:32:47] * K4-713 pokes both eyes out to avoid looking at date formats in audit files [01:32:55] I'm happier this way. [01:32:58] I should have said, "wtf is an elf doing in there?" [01:33:10] the dates are insane. [01:33:11] elves get everywhere [01:33:19] Being all logical and pretty. [01:33:22] borrowers maybe, but I sprayed for elves [01:33:29] if you don't lock your door, they'll come in and fix shoes [01:33:45] noooo not my street cred! [01:34:01] And make cookies and walk on the top of the snow without falling in to it and things. [01:34:27] Also: [01:34:32] sometimes i mix up elves and tomtens [01:34:34] Vulcans = space elves [01:34:37] ejegg so does this mean there's something special that has to now be done with that package? [01:34:58] pizzzacat: I think we need to keep the linux version checked in so we can deploy [01:35:19] pizzzacat: but you'll have to keep your own special version around to run locally :( [01:35:35] (CR) Katie Horn: [C: 2] Parse datestamp in both WorldPay audit file formats [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178742 (owner: Awight) [01:35:55] ejegg: pizzzacat: that sounds really bad. [01:36:11] ok.. unclear which is which at this point…. I dunno [01:36:12] maybe it can run without the binary? [01:36:28] this is harshin' the flow of the node package goodness [01:36:52] so, I'm unable to run locally at the moment. [01:36:58] :( [01:38:16] There is node-posix also... [01:38:18] would be nice to be able to run npm as part of deploy... [01:39:50] blerg [01:40:18] it feels kind of wrong testing things on my local if I need a different version of something [01:40:33] which brings me to something I was going to bring up anyway: staging? [01:41:11] Can we check in both versions of node-syslog and switch between them somehow? [01:41:16] and, +1 to staging. [01:41:57] yeah, staging would be nice [01:42:03] yeah! staging!! [01:42:04] well, maybe we are running in staging [01:42:13] it is on the frdev subdomain! [01:42:23] so maybe we just need a prod environment [01:42:45] haha [01:43:04] how do we set this up? [01:43:14] awight: hmm, not sure where we'd switch, but that would be cool! [01:44:45] looking into platform detection etc [01:45:26] ok, looks like I can do something with process.platform [01:45:39] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178749 [01:45:56] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178749 (owner: Awight) [01:46:00] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/178749 (owner: Awight) [01:46:50] !log update crm from d22dce0a375be3c5f32afc472fff550a5edf6a1e to 3d657972029ea221b321470102c99ad74027b6f7 [01:46:57] Logged the message, Master [01:52:28] K4-713: much more health after that date patch. [01:52:49] Oh good. [01:54:17] Something has become completely ruined on my local. [01:54:21] Neat. [01:54:53] K4-713 I feel yo pain [01:55:13] I was going to do a thing with a form. [01:55:25] Now I think I'm just going to go home and sulk. :p [01:55:26] haha haha. ha. [01:55:34] that tends to happen. [01:55:40] Oh, I remember. [01:55:47] That happened to me a lot in 2011. [01:55:58] RapidWhatnow? [01:56:19] But, ah... the whole... thing is... hosed. [01:56:44] And I can no longer brain. [01:56:44] :'-( [01:56:55] I am feeling the same way at this point. [01:57:04] and I've only just thought about forms [01:57:05] jk [01:57:08] it's node [01:57:10] Well, then let's stop brain. [01:57:21] I am stopping braining. [01:57:26] There's no percentage in trying to continue to brain after you can't. [01:57:40] all the brains are not belong [02:42:52] (PS1) Ejegg: Try to make node-syslog work on both mac and linux [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/178759 [11:36:34] Ugh, so much crap in operations/mediawiki-config/docroot/foundation/donate/2007/ [15:06:03] Nemo_bis: rm -rf [15:25:37] marktraceur: that bad? [15:47:52] Probably not :) [15:53:50] marktraceur: you could do "rm -rf --partial 60% --randomly-select-what-to-remove" [15:54:32] Whenever I get bored I do one of those at like 2% just to see what happens [17:50:07] hey awight [17:56:30] atgo: bon matin [17:56:56] pregunta: your email last night about banner bugs... was that something you encountered or were you following up on bugs that you heard about? [17:57:23] I was playing on wikipedia [17:57:52] really unexceptional browsing, too... [17:58:10] I closed a banner, then opened a blue link in a tab and saw another banner. [17:58:19] then clicked the close box more furiously [17:58:47] awight: that sounds not so great [17:58:54] Though fury is sometimes OK [17:59:06] but even that didn't work! [17:59:14] Oh noes [17:59:32] It must be a very edgey case [17:59:40] Didja check the cookies etc etc, see which banner it wuz? [17:59:58] I unfortunately did that only after refreshing the page, so no [18:00:01] BTW chrism doesn't have the rights to merge this but gave it a +1, should we bug someone else, or can u merge? https://gerrit.wikimedia.org/r/#/c/178714/ [18:00:09] but meganhernandez says there are only 2 banners that were running [18:00:27] AndyRussG: I don't have +2 there [18:00:34] hehe [18:01:01] awight: Ah OK, I'l hunt around for a merger [18:01:12] AndyRussG: https://gerrit.wikimedia.org/r/#/projects/integration/config,dashboards/default:recent [18:01:32] Looks like, Hashar, Krinkle, Zfilipin [18:01:40] and ur hide cookies? R all your hide cookies yours? [18:01:53] mm eh? [18:02:02] i can't reproduce [18:02:04] trying [18:02:06] ino. [18:02:09] neither can I [18:02:15] awight: just one time for you, too? [18:02:19] hm. [18:02:20] no, twice. [18:02:22] HMPH. [18:02:41] I wasn't having net issues, but that's my only theory so far. [18:02:55] If we can't contact all the subdomains to get cookies, that part just doesn't happen. [18:03:14] awight, we should still set the local cookie [18:03:20] right in bannerController [18:03:47] as long as window.hideBanner is called [18:03:47] that's true [18:03:49] awight: ccogdill had a couple of reports of that, too [18:03:52] I didn't have those either [18:04:09] It's easy to discount the bug reports tho... [18:04:25] awight: were you using IE? [18:04:26] Especially since they probably all come in at 10pm local time and have chronic misspellings. [18:04:27] * AndyRussG runs [18:04:27] i know we have the one 2/3 screen banner that doesn't call hideBanner [18:04:32] AndyRussG: lol [18:04:41] ejegg: that wasn't the one [18:04:46] I did have the fullscreen cookie [18:05:07] well, I just reproduced. [18:05:10] right, neither is the one jessicarobell mentioned in her email [18:05:15] awight: cool! [18:05:18] details? [18:05:23] yep, that totally happened. [18:05:25] awight some of the complaints I have may be people who tried to close the fullscreen banner and then saw the top banner [18:05:33] awight: which banner? [18:05:39] I'll email the sequence, and banner identity [18:05:45] which would present to the donor like an error but isn’t. but one donor checked for the cookie and didn’t get it after closing [18:06:05] awight: thanks! [18:08:07] sent [18:08:32] ccogdill: ah. yeah I don't know why we wouldn't respect the close box on the fullscreen banner. [18:08:41] that's double annoying and I don't want to donate... [18:08:52] I think everyone's hackles are up about that. [18:08:55] bien hecho awight! [18:09:02] lemme try again... [18:09:49] yep. closebox, new tab click, is the magic formula for me. [18:10:16] awight: didn't get your e-mail... (?) [18:10:31] oh it's even worse. just the reminder strip close box is not setting cookies for me. [18:10:38] AndyRussG: are you not getting fr-tech or fr-online emails? [18:10:46] AndyRussG: you might not be on the fr-online list. I'll fwd it to you [18:10:55] atgo: yeah I think fr-online needs an Andrew [18:10:56] awight: ooh, let's look at that reminder script code [18:11:01] awight: I am getting fr-tech an fr-all? [18:11:08] oh i thought fr-online consumed fr-tech [18:11:12] according to k4 [18:11:15] (afirmation, not question) [18:11:29] hm. ok [18:11:32] AndyRussG: I'm pretty sure you're getting fr-tech [18:12:00] AndyRussG: you got "dump_database [18:12:02] email? [18:14:25] awight: unrelatedly, we didn't get WP FR audit working, right? [18:15:31] atgo: no, FR and some subset of Amex I guess will require manual dumps, there is no automated file available. [18:15:44] ugh [18:15:48] sounds good, thanks [18:15:57] atgo: yeah. I could work on that if it becomes a priority, but it sounds crappy. [18:16:05] nope, it's all good [18:16:10] i mean, not good [18:16:10] Too bad that was the main thing we wanted to use them for :-( [18:16:15] but...acceptable [18:16:21] awight: ooh, that nag close button source is suspect [18:16:35] ejegg: aha! yeah [18:16:39] $('.B14_120723_5C_tp_tw2-nag-close').click(function(event) { [18:16:39] $('#B14_120723_5C_tp_tw2-nag').remove(); [18:16:39] event.stopPropagation(); [18:16:41] }); [18:16:45] awight: no I didn't [18:16:50] no hideBanner at all [18:17:01] AndyRussG: oh bad news, u aren't on any fr- lists yet then?! [18:17:16] AndyRussG: flee while you still can ;) [18:17:24] awight: I am on fr-tech [18:17:25] and fr-all [18:17:40] ejegg: sounds like by design? [18:17:56] ugh, I hate that design [18:17:58] AndyRussG: "Corrupted nightly reconciliation file"? [18:18:24] the-wub: u have input wrt what the nag close box is expected to do? [18:18:27] haha ejegg [18:18:41] awight: ah yes I did get that 'un [18:18:43] making it impossible to figure out which are real bugs in the system is srsly gonna be a time sink [18:18:51] AndyRussG: ah. must just be a lag on the other, then [18:19:09] ejegg: the only solution is to document the features, imo [18:19:37] I think I'm on fr-tech and fr-all but not fr-online [18:19:47] meganhernandez: on this note, is the semi-fullscreen banner close box intended to not give the reader a hide cookie? [18:19:56] We're trying to map out bug vs design... [18:20:12] semi full screen does not give a hide cookie [18:20:29] it has a seen full screen cookie so peopel only get that 1 time [18:21:00] hmm, that sounds difficult to communicate to readers. [18:21:24] "Did you click the close box--was it a really big banner or a medium or small banner?" [18:21:52] meganhernandez: what about the "nag" strip close box? [18:22:02] we noticed it does not give hide cookies, either. [18:22:04] we need to double check with the-wub about that [18:22:07] awight: the "nag" close isn't meant to set a hideBanner cookie either [18:22:08] k, thanks [18:22:18] it sounds like that’s where the issue is coming from in your email [18:22:34] can we change either of these things, or is this final + intentional? :) [18:22:52] meganhernandez: yeah confirmed that was what got me [18:23:44] this was the behaviour meganhernandez requested [18:24:14] i think keeping full screen is good as it is [18:24:24] so you don’t get it again but will get a reminder blue banner [18:24:28] OK at the very least, let's document all these decisions. [18:24:33] emailed [18:24:35] i think it’s ok for the nag to close like the blue banner closes [18:24:38] It will make donor services's job easier [18:24:51] and I won't waste another 2 hours of everyone's time panicking... [18:24:51] i didn’t remember how it worked to be honest [18:25:03] yes, documentation ftw! [18:26:08] (awight: meganhernandez: the-wub_: yeah also just checked that everything works as described above...) [18:26:34] yeah atgo and i started talking about this. there are a couple cookie documentation pieces that need to come together — buckets & banners. i think different people hold pieces of those puzzles [18:27:01] tech take documenting buckets & central notice & peter take documenting banner cookies? does that make sense? [18:27:04] looking over the bannerController code again, it's hard to see anything problematic there, unless the jQuery cookie library or the JSON shim are failing [18:27:22] thanks AndyRussG, the overlaying (getting a sticky skinny on top of the top screen) that awight got did seem really weird though. Do we think that was just a thing that happened once? [18:28:30] meganhernandez: makes sense to me [18:28:40] meganhernandez: the-wub_: sure, I would think anything you and peter are writing, u should document, and tech can doc everything in the banner controller. [18:29:39] jessicarobell: it can sometimes happen if you scroll down and then up again rapidly. I haven't been able to fix it. [18:30:53] awight: ejegg: maybe also a short blurb of specific documentation for how things are expected to interact in a given campaign? the individual JS snippets that live on Mediawiki are pretty self-explanatory, but to see how the banners and snippets are expected to interact as a whole sequence is a campaign is what's harder to track down and to understand the expectations about [18:31:02] meganhernandez: the-wub_ jessicarobell ^ [18:31:40] ok thanks for clarifying that the-wub. [18:32:26] the-wub_: much smaller nag bug, if you refresh the page after already scrolling, the nag does not return. [18:32:44] AndyRussG: yay! [18:34:29] I dunno, I'm just imagining a 5 to 6 line blurb associated with any campaign (or maybe linked, for campaigns that have the same functionality) [18:34:44] * AndyRussG waits for awight to say "Mixins"! [18:34:48] baahaha [18:34:57] AndyRussG: heheh [18:34:59] I'm transparent [18:35:55] or we could rewrite wikimedia using git [18:35:59] mediawiki I meant [18:36:04] * K4-713 blinks [18:37:05] the-wub_: I can reproduce the nag overlaid on top banner thing: scroll down, wait for the nag to begin animation, then hit the key. [18:37:35] the-wub_: I recently used jQuery's animation .stop method at a side job, it works well for cases like this... [18:38:06] hehe, not much of a side job: http://web.stanford.edu/~gailw/Smithsonian.html [18:39:03] AndyRussG: yeah wait a minute, whose tail are you pulling anyway :p [18:39:53] I don't pull tails [18:40:35] Or not much anyway [18:42:54] back shortly! [18:48:25] Holy Email Spam, Batman! Anybody else getting what looks like one phabricator email from everything you ever committed up to 2013? [18:48:27] ...wait. [18:48:55] awight: Just fyi, integration/config merge is restricted on purpose since merging there has no effect. It has to be deployed. We have a policy of merging at/after deployment (deployment is from local workstation directly to jenkins) [18:50:18] K4-713: quick, go fix your email preferences... https://phabricator.wikimedia.org/settings/panel/emailpreferences/ [18:50:28] K4-713: Audit -> A commit is created -> Ignore [18:51:24] awight: But I like getting a detailed description of all the bugs I've been shoveling in to everything since my hire date. :) [18:51:26] Krinkle: that makes sense, thx. No rush on deploying this change, we just wanted to make sure it had enough +1s to look serious. [18:52:07] K4-713: blargh. It was causing me deja vu. Also, I thought the name was funny, "diffusion", I imagined it was actually "dilution" [18:52:36] confusion. [18:52:46] profusion? [18:52:56] All. All of these things. [18:53:10] Just look out for conflation. [18:54:49] Though, I feel like "handling a profusion of conflation confusion" should be on my CV somewhere. [19:02:05] ccogdill: hey, is Civi working at a usable speed, today? [19:02:31] I haven’t been in there much, but it’s been fast for what work I’ve done [19:02:38] let me check with Michael too [19:02:50] sure, thx! [19:03:39] yeah awight it seems fine to us [19:03:46] and why not diPHusion? [19:04:01] jessicarobell was having trouble getting to run reports yesterday - we don’t often do reports in civi so that may still be an issue [19:06:13] haven't been on civi yet but let me check if it has speeded up. thanks awight [19:10:46] awight: I'll defer that browsertest change to Hashar or Zjelko though. I'm not really familiar with those jobs [19:11:10] I think the reports issue yesterday was actually normal, bad Civi behavior. There's this nasty thing where the report is run even on the first, "set criteria" page, and you lose 4 minutes for nothing... It's very disconcerting, Giant Rabbit is fixing it, but not until next year. [19:11:27] Krinkle: fine by us, thanks for all the help! [19:12:53] K4-713: haha, nice one. Yeah, the import starts way back when. Got a notification for virtually every commit I ever touched, lol. Flood. [19:12:55] awight: it loads pretty much at the same pace as yesterday. so pretty slow, but working. thanks! [19:13:21] * Krinkle saves "handling a profusion of conflation confusion" to memory. [19:14:24] Krinkle: My first reaction to the email flood was "These commits don't look familiar at all! Some wires must have been crossed somewhere..." [19:14:40] Nope. [19:14:49] Just... total amnesia. [19:15:03] K4-713: My thoughts were similar. I was thinking what idiot wrote this ridiculous code and dare to put my name on it :P [19:15:38] I'm actually quite sure some of them are not mine. [19:18:35] Krinkle: The ones I spot-checked seemed legit, eventually. But I also don't have permission to get anywhere with the links in the emails. Maybe I should bug somebody about that... [19:22:31] K4-713: who can edit fr-* lists, again? Andrew is missing from -online and maybe -all [19:22:45] I've been working this out with Jeff for like 15 minutes. [19:22:49] On it. [19:23:13] jessicarobell: yeah, reports are effed. Sorry! There are exciting improvements coming next year as you know, stay tuned... [19:23:37] great awight! looking forward :) [19:28:00] should this cookies doc be on collab or wikitech or? [19:28:28] (PS1) Awight: Remove unused SystemStatus code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/178889 [19:28:31] awight: K4-713 meganhernandez the-wub_ ^ [19:28:38] atgo: public? [19:28:45] i'd think... that's wikitech, right? [19:28:45] wikitech or meta [19:28:49] ? [19:28:50] oh. hm [19:29:01] ... which..? i'm still blurry on what goes where [19:29:06] Cookies. Doc. [19:29:23] from thread about cookies. and desire for documentation. [19:29:32] nom nom [19:30:35] btw, check out this easter egg: https://payments.wikimedia.org/index.php?title=Special:SystemStatus [19:30:49] let's go with meta, since that's where CN actually lives [19:30:51] not a whitescreen! u must look closely for the status/. [19:31:01] awight: What about it? [19:31:08] Is that important :p [19:31:09] ok, thanks the-wub_ [19:31:12] Yes. [19:31:14] https://gerrit.wikimedia.org/r/178889 [19:31:16] wat. [19:31:27] so that is "we can read the config file" ? [19:31:30] there is so much community noise right now. i’m fine for banner cookie documentation to live with our team for now so we don’t have to worry about explaining everything while all these eyes are on fundraising stuff & we’re in the middle of it. it’s confusing to explain even for just our team [19:31:33] I think we have a rather large alarm that goes off if that stops. [19:31:43] And it checks sometimes. [19:31:47] I agree that cookie doc is technical... [19:32:16] K4-713: just an icinga endpoint? [19:32:24] awight: You'd have to ask Jeff_Green. [19:32:47] But, yes. It's a very basic "does payments exist" check. [19:32:54] I don't think it proves very much. pinging the machine or hitting any URL at all would be the same [19:33:09] I think we thought that at one point, too. [19:33:36] And then everything disappeared and we didn't get an alarm. [19:34:36] But, we're probably going to both feign amnesia about the exact circumstances. [19:34:40] total tangent. https://meta.wikimedia.org/wiki/Fundraising#mediaviewer/File:Donationamountbreakdown.png -- I still think we should relabel that report, "Donation Count Breakdown" to distinguish it from proportion of revenue. [19:35:20] awight: I do have the intense hunch, though, that nobody would do that deliberately unless we had a reason. :p [19:36:20] for your cat of the day, here is a photo that my boyfriend says looks like me bowling. http://i.imgur.com/QeU09nP.jpg [19:36:21] ok fair enough. I have mental blockage [19:36:32] pizzzacat: RAD [19:36:42] awight: I suppose if you're incredibly bored (HOW), you could rip it out and see what starts screaming like a banshee. [19:36:52] haha pizzzacat [19:36:54] That could be fun. [19:37:00] Everybody seems so relaxed anyway. [19:37:38] pizzzacat: I may have a similar affliction. [19:37:44] making a collab page for the time being. [19:38:01] (PS2) Awight: Remove unused SystemStatus code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/178889 [19:38:05] too bad my amazing form doesn't help me do good bowling [19:38:07] ...wow. [19:38:13] atgo: wat. private? [19:39:04] awight: Are you 100% sure that is unused? [19:39:44] no [19:39:48] * K4-713 silences phone [19:39:52] I just left a note in PS2 to not be a jerk [19:39:56] :) [19:40:22] I at least want to get Jeff_Green to comment before I touch that one. [19:40:46] I really want to say that this is... handling LVS stupidity, more than pinging actual machines would do. [19:41:06] yes it's a good idea [19:41:14] Do you remember that time all the actual boxes were happy, but nobody could get to payments anyway? [19:41:14] but we don't need a whole special page devoted to it [19:41:32] Wat about, we just hit GatewayFormChooser. [19:41:46] Those hand out contribution tracking IDs. [19:41:48] we could even parse the results if bored? [19:42:01] formchooser? oh, kindof cool. [19:42:44] Actually, just the form chooser would... probably result in a bunch of alarming-looking logs. [19:42:54] Anyway, why is this important to do right now? [19:43:04] Weird time to potentially cause a mad scramble. [19:43:05] not important, it became loud though [19:43:39] (CR) Awight: [C: -2] "Removing argument :p" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/178889 (owner: Awight) [19:48:33] re; Special:SystemStatus [19:49:30] it tell us the machine is up, nginx and apache are doing approximately the right things, and php is basically working [19:49:42] (PS1) Ejegg: Only try to use node-syslog on linux [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178898 [19:49:43] which is a lot better than just ping or ring and run on tcp/443 [19:51:12] awight: we're using stupid third party tools to interpret the response, and the more we expect the tools to do the more likely they'll do it wrong [19:51:16] Jeff_Green: if you get the chance, next year or whatever, let's point that to Main_Page or whatever else is whitelisted... [19:51:24] why? [19:51:35] cos the empty code annoys me... [19:51:40] so it's really low-priority [19:51:51] I'm just trying to finish the convo now that we're having it [19:52:29] so where would you point it? [19:53:05] I think we started with index.php but that ran a bunch of backend cycles regarding auth, and annoyed people with mediawiki log chatter [19:54:45] (CR) Ssmith: [C: 2] Only try to use node-syslog on linux [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178898 (owner: Ejegg) [19:54:49] O i don't know [19:54:54] pizzzacat: nice solution. [19:55:00] Jeff_Green: whaatever is whitelisted [19:55:11] awight it was ejegg! [19:55:24] it was todelly borked on my machine [19:55:31] awight: another option would be to make it do something smarter before responding OK [19:55:39] node-syslog doesn't play nice with my os [19:55:48] which afaik was the original intent [19:55:52] which is weird because it was working before.. so very curious.. [19:56:03] awight: finally noticed on the node-syslog homepage: 'does not support darwin os'. No idea how pizzzacat was running till now [19:57:15] Jeff_Green: hey that is a great idea. [19:57:15] (Merged) jenkins-bot: Only try to use node-syslog on linux [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178898 (owner: Ejegg) [19:57:49] ejegg: hah. ELF hats [20:00:04] (CR) Awight: "Good suggestion from JGreen: enhance this function instead, to do something actually meaningful." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/178889 (owner: Awight) [20:35:58] (PS1) Awight: Make WMF Audit config available from the admin menu [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178914 [20:36:18] awight: ...ha, I forgot I left that one for you. [20:36:35] :p [20:36:37] nbd [20:36:58] I ended up poking all the vars through manually in drush. [20:37:13] oh! [20:37:16] sorry man [20:37:16] At some point, it wouldn't even load with the URL. [20:37:23] I can believe it [20:37:30] Drupal is so fragile... [20:38:12] (CR) Katie Horn: [C: 2] Make WMF Audit config available from the admin menu [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178914 (owner: Awight) [20:38:25] bored? [20:38:31] Oh, hell no. [20:38:36] ok, good [20:38:44] :) [20:38:55] you still in pursuit of the ffname static? [20:39:07] More like wrestling with extreme urges to procrastinate. [20:39:21] oh heh [20:39:24] ...something is wrong on my local, to the point I can't accurately load any payments forms. [20:39:31] OH that still [20:39:33] sorry. [20:39:53] I wish I were there to be amused [20:39:55] All the regular decoration is there, and the css seems to have crawled off to do something more fun. [20:40:07] you see anything with debug=true? [20:40:39] Nope. That would be too easy. [20:41:16] My css comes from http://payments.local/extensions/DonationInterface/modules/css/gateway.css [20:41:29] It's not even trying. [20:41:39] Oh! [20:41:44] Something has been fundamentally ruined. [20:42:16] Like, all I have is the stuff that comes with the skin. [20:42:35] origin/master ? [20:42:45] which bit? [20:42:49] you've updated the payments mw-core to 1.23 [20:42:49] DI? [20:42:52] yes [20:43:02] mmmphuk [20:43:08] But... wait. This might be a weirdo checkout that I don't actually... [20:43:20] Let me verify what port goes to what directory locally. [20:43:46] you not getting js/skinOverride.js either? [20:44:02] CORE/fundraising/REL1_23 [20:44:10] that sounds right [20:44:23] yep. [20:44:48] I mean, if I was, the skin should be overridden. [20:44:55] Eh. I'll get it. [20:45:11] It's just going to take a minute, and I think I've been drafted to help with a shop thing in a minute. [20:45:23] Shopify is great. [20:45:31] limited, but really pleasant. [20:45:35] Oh, it's not technical. [20:45:42] ...not yet, anyway. [20:45:53] They need a person to put a shirt on. [20:46:01] And I was like: "Hey, I wear shirts." [20:46:16] $wgResourceLoaderDebug = true ? [20:46:24] baa [20:46:26] nice [20:54:26] (PS1) Awight: Log missing transaction identities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178920 [21:10:56] ejegg que te pasó? [21:11:03] ejegg que te pasó? [21:11:27] awight: is this what you're talking about with WP? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2278 [21:11:30] cyber wind tunnel [21:11:50] atgo: yes, I thought I would make a card preemptively [21:11:54] nice :) [21:12:13] Then I went ahead and started doing the work, since it really should have been part of #2239 [21:12:32] yeah i like the sound of that [21:12:46] like.. it working is sort of a necessary part of it being done :O [21:12:47] :P [21:13:41] i'll work with pizzzacat on the new dash widget, then maybe the gc form double click prevention [21:15:11] (PS1) Awight: Use currency codes from DonationInterface without copypasta [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178966 [21:22:40] (CR) Katie Horn: [C: 2] "Well, sure." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178966 (owner: Awight) [21:25:46] K4-713: you feel like CR CentralNotice or something?... [21:26:01] Definitely not. :p [21:30:47] Really great abstraction layers btw, like wmf_audit_get_log_by_date [21:31:43] I'm glad it's working out. [21:32:04] I mean, I hope it... does. :/ [22:04:49] (PS1) Awight: Parse XML charset declaration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178972 [22:20:10] (PS1) AndyRussG: QUnit: provide fixtures via a RL module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/178974 [22:22:03] Hi all, sorry for the much longer than expected absence... got caught in snow storm traffic.. :( [22:24:02] AndyRussG: the patch looks exciting! [22:24:02] snow! [22:29:20] (PS1) Awight: Always log the message that would be sent to Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178981 [22:30:41] awight: the most exciting part is that it works, believe it or don't :) [22:30:54] Woohoo! [22:31:33] We should now rewrite all mediawiki as dynamic PHP-class-based RL modules [22:31:51] just because [22:31:55] AndyRussG: not a blocker, but it would be nice to declare QUnit.tests inside of the $.each [22:32:16] AndyRussG: talk to Krinkle|detached about that, I think he's halfway there. [22:32:25] awight: huh? You mean separate it out into different tests? [22:32:37] I was thinking of doing that in a separate patch [22:32:41] cool [22:32:47] Lemme add Krinkle|detached as a reviewer [22:33:42] Sure, I think he was also a bit disturbed that I never managed to split into tests using ajax to fetch the fixtures, this will bring him holiday cheer. [22:34:40] awight: is that what you meant by "QUnit.tests inside of the $.each" ? [22:34:52] I guess I didn't check out what the standard way of doing tests w/ fixtures is... [22:35:04] in qunit... [22:35:16] if there is one! [22:35:32] Not that I saw. [22:35:40] I think u just invented it :) [22:36:18] hmmm... (/me makes plans to pervert more parts of MW for unplanned purposes) [22:36:32] awight: ^ (see above question... :) ) [22:36:41] skunk alert! 8p [22:37:07] I'd be worried if I were paying attention. [22:37:16] AndyRussG: which question, $.each? yeah, definitely the page I was on. [22:38:03] atgo: atgo_: you should see outside my window! snow, snow-covered tree branchs... classic [22:38:15] why are there 2 of me? that's weird. [22:38:21] awww sounds pretty [22:38:28] i hear there are some flakes in nyc too but it's not sticking [22:41:42] awight: was your system of try/throw also required due to the ajax fixture provision, and is it thus changeable now? or is that still unavoidable? [22:41:53] carafe is back to being a carafe! no more banner text in it :) [22:42:11] raise a carafe! [22:42:23] hahaha [22:42:28] We lost the walrus over the weekend. [22:42:35] ps - we are definitely going to have a team viewing of we wish you a merry walrus, right? [22:42:52] it's going to be released on the 17th [22:42:59] though.. only in the UK [22:43:18] "We lost the walrus over the weekend" is not even the weirdest thing I've said in IRC this week. [22:43:19] K4-713: I think audit files are not moved to completed if they contain missing transactions, but these are resolved via log hunt. Does that sound reasonable? [22:43:29] maybe the_wub can relay it to us? [22:43:40] K4-713: but uh that should happen. [22:43:52] awight: Here's my thinking. [22:43:57] awight: just added your card to the sprint [22:44:02] thx [22:44:02] No, nothing moved to complete unless it's actually complete. [22:44:08] *moves [22:44:14] oic that makes mucho sense [22:44:30] it's different than the other audit parser, but more thorough. [22:44:32] Also, we can't add it immediately after the log hunt, because we don't know if it actually gets in there or not. [22:44:55] If we didn't have the option to go through qc, we could change that. [22:45:02] But, that can't go anywhere for a while. [22:45:32] yes, thanks for explaining [22:45:40] Totally. [22:46:22] atgo_: K4-713: woot!!! [22:46:41] * K4-713 jumps [22:46:44] What happened? [22:46:53] woot? [22:47:02] (PS1) Awight: Comment about archiving logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178989 [22:47:03] K4-713: atgo_: about carafe becoming a carafe [22:47:07] oh, yeah [22:47:09] that's super rad. [22:47:22] The door... is a jar. [22:47:41] Meanwhile, I noticed yesterday that there are many knowledge graph entries with *no* wikipedia link [22:47:49] orly [22:47:49] try "jon stewart" for example [22:48:10] hm. [22:48:15] I emailed Erik in a panic but didn't have the heart to wmf-all that info [22:48:18] are we sure that's our content? [22:48:21] Wow. [22:48:24] no, it's not [22:48:29] we're obsolete :) [22:48:31] because it's got imdb in here [22:48:48] K4-713: awight: huh? I'm getting the Wikipedia link fine here for that search [22:48:56] AndyRussG: in the infograph [22:48:57] I am not. [22:49:03] not search results [22:49:06] Yeah the infograph on the right side [22:49:13] that paragraph is decidedly... biased [22:49:14] Yes there, I'm getting Wikpedia link [22:49:16] Jon Stewart [22:49:16] Political satirist [22:49:16] Jonathan Stuart Leibowitz, widely known as Jon Stewart, is an American political satirist, writer, producer, director, television host, actor, media critic, and stand-up comedian. Wikipedia [22:49:17] "Accused of misinforming its core audience of young adults about international news, this series doesn't hide the fact that it's not a news program and only uses newsworthy stories as a jumping-off point to satire. In addition to celebrity and politician interviews, Stewart and his staff perform skits to get their points across. " [22:49:18] I'm actually getting an infograph of The Daily Show with links to imdb. [22:49:38] yeah i'm getting what you're getting K4-713 [22:49:42] the hell. [22:50:02] AndyRussG: interesting, I get redirected to daily show like K4-713 [22:50:02] Lemme move from google.ca to google.com [22:50:06] hah! [22:50:19] also, it's so good that they replaced yesterday's featured article with one fo the cutest things in the world. [22:50:30] Nope that's not doing it... I still get the Wikipedia link [22:50:33] I must be in bucket B [22:50:45] atgo_: seriously, that was harsh [22:50:50] srsly [22:51:07] AndyRussG: hehe you must have accidentally done something intellectual from your laptop [22:51:23] That blurb seems to be coming from mostly tivo.com. [22:51:24] :P [22:51:49] K4-713: ooh wow with no attribution? [22:51:51] AndyRussG: I get the same WP blurb + link as you do. Trying from another browser [22:51:53] little backroom deal there [22:52:04] Is that even us at all? [22:52:08] Can't... [22:52:10] ...confirm. [22:52:39] Yeah, that's not us at all. [22:52:39] same in another browser, and with incognito / private. Geolocated results? [22:53:07] K4-713: I'm thinking they must not have to attribute that, though. [22:53:26] Guess not. [22:53:36] Or, somebody is going to bite them pretty hard. [22:54:03] New fate: Killed by tivo. [22:54:11] haha [22:54:12] I mean, I sort of always knew. [22:54:24] well, as long as people are still searching for things that are not TV, we'll be fine [22:54:27] ... [22:54:36] See? [22:54:39] Doomed. [22:55:04] In any case, wasn't the concern that due to the infoboxes we'd not get traffic? So this is better! Like that, when you want to read the first sentence of a Wikipedia article, you'll be forced to click on the link and go to our site [22:55:53] I think maybe some people were taking for granted that the infograph was just us. Which was... probably never going to be true forever. [22:56:14] Nothing is forever [22:56:19] Run ye banners while ye may. [22:56:34] ...ah. Prawning time. [22:56:42] totally geolocated [22:56:44] Now if we could inject the banner at the top of the infobox [22:56:54] ejegg: and even within the US [22:56:56] ejegg: weird! [22:56:59] I turned on the full vpn and searched [22:57:10] and got the 'misinforming' blurb [22:57:15] hehehe [22:58:03] System Error: please watch a reliable source of language virus such as Fockks news instead [22:58:07] maybe if you're searching from the wikimedia offices, the google assumes you want a fresh point of view? [22:58:17] (PS1) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 [22:58:19] (PS1) Ssmith: Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 [22:58:40] :D if you like leftist satire, you might also like to see savagely uninformed critique of your show [23:01:27] (CR) jenkins-bot: [V: -1] Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [23:27:26] (Abandoned) Ejegg: Try to make node-syslog work on both mac and linux [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/178759 (owner: Ejegg) [23:42:37] (PS3) Awight: Add more browsers to cross-browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/178710 (owner: AndyRussG) [23:42:55] (CR) Awight: [C: 2] Add more browsers to cross-browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/178710 (owner: AndyRussG) [23:43:35] (Merged) jenkins-bot: Add more browsers to cross-browser tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/178710 (owner: AndyRussG)