[00:01:30] hahaha [00:01:33] at least it's possible [00:01:42] i actually really like the 1 task : many projects thing [00:01:48] it's a little confusing but i think it's goign to work great for us [00:02:09] hell yeah [00:06:11] K4-713: at what point after the cc icons are disabled are we ok with re-enabling? [00:06:24] the user might need to change their choice etc [00:07:01] the card says "until the request returns with something" [00:07:31] so on success in the ajax I'm assuming? [00:10:15] it's kind of hard testing locally [00:17:42] (PS1) Ssmith: Fix double click issue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179353 [00:17:44] (PS1) Ssmith: Prevent double clicks on gc cc forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179354 [00:18:04] (Abandoned) Ssmith: Fix double click issue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179353 (owner: Ssmith) [00:20:10] ^screwed up the merge [00:24:42] blah everything out of order when I try to squash/interactive rebase [00:24:55] I am going to be a farmer [00:24:59] bye [00:25:02] hey ejegg K4-713 - for the new GC CSS, i know you were also looking at tying that in with the RTL issue [00:25:07] pizzzacat: things will grow with all this wayter! [00:25:09] water. [00:25:40] not sure what the new GC CSS is! [00:25:54] :p so much water [00:26:27] yeah ejegg and K4-713 were looking at it [00:26:51] oh I see now you didn't address that to me [00:26:57] atgo: they can't put a language on the css url, unfortunately [00:27:05] gotcha [00:27:18] so we can't do it in the iframe, but we can still do it for the rest of the form, right? [00:27:40] atgo: we can, but I didn't mix that in with the current patch [00:27:52] the current patch for which? [00:28:20] the current patch adding the css from the campaign to both gc gateway css and iframe css [00:28:36] I'll keep looking at that in the morning [00:28:47] cool [00:28:48] sounds good [00:29:07] Gotta head out for now. Have a good evening, y'all, and try to stay dry! [00:29:11] ciao! [00:29:20] i haven't even opened a door that leads outside today.. [00:30:50] aww haha I did…it wasn't a great idea [00:31:13] I'm glad it's not snow! [00:32:50] pizzzacat: Ah, sorry. IRL got me. [00:33:29] To answer your question: Yes, we want to re-enable the cc radio buttons after the iframe loads. [00:34:24] Hopefully not before the content actually loads, or... during. [00:36:16] atgo: I think ejegg answered everything you were asking. Anything left? [00:36:32] yeah i think i'm good - thanks [00:36:34] ok, I submitted a patch and hopefully I got that right [00:36:52] pizzzacat: You said you were having trouble testing? [00:36:55] if the RTL thing was going to be the same work again when we wanted it, then i'd say we should tie it to this. but it sounds like it's basically totally separate [00:36:58] just made it happen in the success function [00:37:01] and the error [00:37:11] K4-713 I think I got it sorted [00:37:39] I was getting errors from the form trying to connect to the actual services, or something [00:37:44] aaaha. [00:37:51] Are you coming in tomorrow? [00:38:05] It's slightly easier to use the sandbox if you don't have to VPN in. [00:38:15] ejegg|away: re: RTL, the only possibility I saw was that we somehow encode language into the merchantreference, which is available in the resourceloader URL if we ask for that. [00:38:41] ejegg|away: on the other hand, K4-713 is slowly twisting their thumb about the doc text that said we can switch css on language. [00:38:53] awight: Very slowly. [00:39:06] I basically stopped. [00:39:06] I noticed. I'm full out of popcorn. [00:39:38] Think of it as a dramatic pause. [00:39:57] Pinteresque [00:40:17] yeah it makes sense, it will be more effective once they think the coast is clear again. [00:40:26] pizzzacat: This is sort of what I got stuck on earlier. [00:40:49] The issue is, the gc form loading in the iframe takes... a silly amount of time sometimes. [00:41:06] ...aw. [00:41:22] * K4-713 twiddles [00:41:23] K4-713: awight i think it's ok to let the iframe being RTL go if it's not super simple [00:41:33] but we should at least be able to improve the top half relatively easily [00:41:35] right? [00:41:48] atgo: Yeah, I think they're still trying to work out if their system supports what their docs said they did. [00:41:53] cool [00:41:58] Until they do that, we're stuck with "no". [00:42:03] i mean, not cool, but whatevs [00:43:07] Yeah, I can't believe... [00:43:14] ...what kind of collect did you say? [00:43:16] :D [00:43:29] That joke never, ever, ever gets old. [00:43:40] ejegg|away: I'm getting no dice on the https from boron, either. [00:45:12] sorry, internet [00:45:20] yo [00:45:23] the wind is blowing it away [00:45:37] My bandwidth is sublimating! [00:45:39] Sad. [00:45:57] Anyway. I was going for: [00:45:59] ha [00:46:08] The iframe content takes silly amounts of time to load sometimes. [00:46:25] were you asking me if I was coming in tomorrow? because yes I plan to [00:46:31] I see [00:46:37] And, right now, the place you're re-enabling the cc radio buttons will do it right after the form starts trying to load. [00:47:13] I tried that, and it looks pretty funky. :/ [00:47:24] hmm so the success callback approach isn't sufficient here? [00:47:30] Sadly, no. [00:47:39] because there''s one more step [00:47:42] The data coming in with that ajax call is just the URL to try to load. [00:47:43] ok. [00:47:49] word [00:48:09] But. [00:48:21] The one on the error condition should totally stay put. :) [00:48:49] awight: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1847 ?? [00:49:07] ok. [00:50:19] atgo: what what [00:50:28] <_< [00:50:28] We really should have a way to fake this whole thing on dev installs. [00:50:50] awight: where'd that come from? [00:50:57] looks like there has to be a callback with generatePaymentForm() [00:50:59] atgo: my skunky wish list [00:51:05] * K4-713 copies my last statement, pastes in to every outstanding mingle card [00:51:21] womp womp [00:51:22] haha K4-713 :) [00:51:55] * awight tries to be cool and pastes "my skunky wish list" onto all mingle cards... [00:52:03] That's more like a tag. [00:52:04] btw your cat of the day, team: http://img.pandawhale.com/post-42136-kitten-looking-around-corner-g-vTFg.gif [00:52:10] awwww [00:52:46] That kitty looks deeply conflicted. [00:52:50] http://media.catmoji.com/post/vv4f/catzilla.jpg [00:53:27] awight: is there some urgency for that one/ i get that it's super important/helpful.. but there's a bunch of stuff that it would've been great to get in the sprint plan yesterday that we didn't accept [00:53:32] that / was supposed to be a ? [00:53:42] atgo: u can pile in anything you wish [00:53:46] I was gonna ask... [00:53:55] but thought sneaking off and just doing random things would be more helpful :p [00:53:59] hahaha [00:55:01] here's my deal... i'm concerned about next quarter and trying to make sure we're in a position to only promise what we can deliver [00:55:18] but in order to do that, we sort of need to scope those projects, which is mostly what i've got as high-priority right now [00:55:19] * K4-713 shudders at the word "promise" [00:55:32] yeah... me too K4-713 [00:55:40] that's probably too strong :) [00:55:41] atgo: sounds real. Can you point at the cards? [00:55:47] but you know what i'm trying to get at? [00:55:58] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards?favorite_id=12220&view=Sprint+planner [00:56:02] fwiw this is groundwork for the 4.4 upgrade. [00:56:08] here's what i was thinking for the sprint, it's mostly review docs and whatnot [00:56:10] not super fun, i know :P [00:56:20] yeah those look boooring :p [00:57:28] yeah, i gotcha [00:57:47] no... seriously, I'm happy to work off of that list. [00:58:11] i get the want for CI, too [00:58:31] CI is a must-have for Civi 4.4, if I mentioned... [00:58:45] to do the upgrade? [00:58:53] we can't upgrade without protection against regressions... [00:58:56] yah [00:58:59] yeah, that makes tons of sense [00:59:11] if it's ok to revisit that in a couple of weeks, that would be super helpful to me [00:59:36] because astropay + china + refactor [00:59:49] = PM worry [01:00:11] hah [01:00:53] I'm still recommending we don't attempt new integrations... [01:01:14] in general? [01:01:17] yeah [01:01:24] ? [01:01:27] we have serious technical debt issues. [01:02:00] and, as has been said: there are already new toys laying around that no one plays with ;) [01:02:06] yeah word [01:02:18] so the technical debt is something the whole foundation wants to address [01:02:30] (yay! also.. scary!) [01:02:43] and.. are you talking about adyen? [01:02:51] This is a silly time/place for this conversation, I fully understand that your job is to make sure things proposed by both tech and non-tech move forward ... [01:03:13] ha ok [01:03:34] i am super happy to talk about this more though! [01:03:40] adyen, worldpay, coinbase... [01:03:51] actually, all the new integrations we've done in the past 2 years [01:04:03] we're actively using 2 of those... and adyen i'd like to figure out [01:04:06] wat. [01:04:23] $700/week for coinbase and we can't solve the simplest issue: people hate us for the mandatory address fields. [01:04:28] yeah. that one is silly [01:04:38] and worldpay just... smells bad. [01:04:41] hahaha [01:04:45] so does Honey, but i love her anyway. [01:05:00] and her ability to literally sleep all day. that dog hasn't moved today. [01:05:20] atgo: can you rank the sprint planner cards, or choose a top 3 to pull into the now? [01:05:42] yeah they're more or less ranked.. let me grab a couple [01:05:52] that paypal link for nirzar thing is an easy win, too [01:06:01] ok, fraud, alipay, and CUP? [01:06:27] are those things interesting enough? :) [01:06:46] we could look for something a bit less boring, to throw into the mix, too [01:06:55] i know this is a ton of documents [01:07:20] atgo: still, I'm bothered, and non-IRL makes this part of the conversation difficult, but I not quite buy the argument that any unused capacity (me) should be applied to the next sprint, if these are things we were already planning to not do... [01:07:24] does that make sense? [01:07:34] yeah, i get that [01:07:51] i think that's also a note for better shrimp prawning though, too [01:07:55] meh [01:08:01] how about this, let's do fraud + alipay + CI? [01:08:14] prawning was just yesterday [01:08:39] I mean... I'm looking at a thing at 5pm on thursday with nobody here, which will require lots of kicking of the can between parties before it's usable. It still makes sense for me to squander the remaining hour on CI. [01:08:49] ok [01:08:53] sigh [01:08:57] that's fine [01:09:07] i'm just worried about the future :) [01:09:11] baahaha [01:09:12] that's my job [01:09:13] I noticed [01:09:19] me too. [01:10:28] yes [01:10:37] CI will save us from ourselves and everyone else. [01:10:37] it's good that we both worry about different sides of the same coin :) [01:10:52] yeah, i'm totally on board for the importance [01:10:53] Maybe save some people from us, too. [01:10:59] Rar. [01:11:03] ROOOOAR [01:11:11] I was being subtle. [01:11:19] i'm over sublety [01:11:40] mew. [01:12:22] honey just turned around and flopped in the exact same place. [01:12:24] to be a dog... [01:13:08] so in conclusion, CI yes, let's also look at Alipay if there's time? [01:13:20] sniff... [01:13:37] sniff? [01:13:42] * K4-713 restrains self from licking that cookie [01:13:46] baa [01:13:48] it's yours [01:13:54] I saw you touch it [01:13:55] CI? [01:14:09] no, K4-713 totally just volunteered to scope Alipay [01:14:14] Alipay. It's just that I told people so emphatically that it was *so easy* through GC. [01:14:14] * awight flags down the bus [01:14:22] So. Easy. [01:14:25] ha then let's just do it! [01:14:30] K4-713: your bus is here! [01:14:33] If it's not, I want to be the first to know. :p [01:15:23] there's also another China thing that might also be easy... called CUP [01:15:29] No. [01:15:33] hahahaha [01:15:39] well let's start with alipay [01:15:46] get that one out of the way [01:15:52] atgo: your job is not easy. [01:15:56] esp if it's as easy as you say K4-713 [01:16:00] awight: :P [01:16:01] * K4-713 dies laughing briefly [01:16:16] is it beer o'clock yet? [01:16:29] ...14 minutes. [01:16:57] shhh [01:17:13] hobbitses. [01:17:42] but for reals, in conclusion, sprint look OK? [01:18:52] I think so. [01:18:53] atgo: I think the 1-week thing is really challenging [01:18:58] ...but, yes. That. [01:19:05] yeah, i was thinking we should check in on that next week [01:19:10] now that it's been a few [01:19:17] (PS1) Awight: add a .gitreview [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179366 [01:19:33] it was something to try, but if it's not working for the team then we don't have to keep it [01:22:26] (PS1) Awight: Squashed merge from upstream/master to master [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179371 [01:23:11] thanks guys [01:23:42] and for a change in subj, awight i saw you moved the IE11 fix with the p3p headers to deployed - good enough that we should let ccogdill know? [01:23:59] AndyRussG: ^^ sorry, I moved your card unilaterally [01:24:08] I kind of agree with the 1-week sprint. don't hate it but I think 2-week ones made more sense [01:24:18] * pizzzacat has been lurking [01:24:23] hehe [01:24:30] ooh yay! [01:24:43] ccogdill: I can't say if it's fixed yet :) [01:24:48] ccogdill: lets confirm with AndyRussG first :) [01:24:51] oohh okay [01:25:04] ccogdill: yeah, AndyRussG was saying he got some hide cookies, but I'm not sure if it was *all* the hide cookies. [01:25:21] lemme undeploy that... [01:33:50] (PS1) Awight: Update repos [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179372 [01:33:52] (PS1) Awight: Enable new modules [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179373 [01:40:16] hide them all! [01:40:19] (PS2) Awight: add a .gitreview [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179366 [01:40:21] (PS1) Awight: manage vendor subdir as a submodule [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179374 [01:45:46] (PS1) Awight: populate with current modules [wikimedia/fundraising/civicrm-buildkit/vendor] - https://gerrit.wikimedia.org/r/179377 [01:46:16] (PS1) Awight: include vendor content [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179378 [01:50:33] (PS1) Awight: Squashed merge from upstream/master [wikimedia/fundraising/civicrm-buildkit/vendor/totten/amp] - https://gerrit.wikimedia.org/r/179379 [01:50:35] (PS1) Awight: add .gitreview [wikimedia/fundraising/civicrm-buildkit/vendor/totten/amp] - https://gerrit.wikimedia.org/r/179380 [01:53:03] (PS1) Awight: replace totten/amp with local fork [wikimedia/fundraising/civicrm-buildkit/vendor] - https://gerrit.wikimedia.org/r/179381 [02:01:26] awight: ccogdill: atgo: looks like it was caching [02:02:13] ejegg|away seemed to have understood the assembly... er, I mean, minified Javascript... oh, no, sorry, it was varnish code... that handles that [02:02:38] and so I think they're cached for a day (?) and should regenerate soon [02:04:56] hrm? [02:07:35] (PS1) Awight: WIP MySQLPrecreated db implementation which does not require admin rights [wikimedia/fundraising/civicrm-buildkit/vendor/totten/amp] - https://gerrit.wikimedia.org/r/179384 [02:21:34] atgo: I meant, regarding the IE hide cookie issue. It seems it'll continue to fix itself as the cache refreshes [02:21:48] And also I made a silly joke [02:28:40] haha ok :) [02:28:50] so we can check in on it tomorrow or monday? [18:36:04] K4-713: ... [18:36:09] it's possible.. ihad my laptop muted [18:36:15] i'm not sure [18:36:21] wah wah [19:00:33] ccogdill: meeting?! [19:00:41] I'm running up there now if so [19:00:42] eek yes, coming now! [19:00:47] ok sure [19:03:08] hey ejegg [19:03:14] you joining the MG meeting? [19:03:18] it was cancelled and uncancelled [19:04:13] oh, I must have the wrong link then! [19:04:23] finding new hangout [19:22:33] awight|fleeting: ejegg: FYI the IE donate hide cookie issue is now solved on production [19:22:41] atgo: ^ [19:23:02] rad! [19:27:50] AndyRussG: awesome! [19:28:05] ejegg: yea thanks for looking into the caching stuff [19:28:32] Didja see bblack's description of vcl? "the assembly language of HTTP" ... 8p [19:29:14] heh [19:34:37] oooh just reproduced the "banner flash and disappear" bug too.. on IE9, with this campaign: http://en.wikipedia.org/wiki/Main_Page?country=DE&uselang=de [19:35:10] also confirmed that current FR banners don't display on IE9, nor do the WMFDE's fancy slider ones [19:37:08] wow! [19:40:57] Yeah could be the same bug, or similar, some DOM injection thing... [19:43:56] (PS5) Ejegg: Update input and select styling for GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/174617 [19:43:58] (PS3) Ejegg: Clean up GlobalCollect style sheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179052 [19:46:55] ^^ should get rid of the iframe scrollbars. It's also applied to the staging css on foundationwiki [19:47:07] ok cool, I'll try it out [19:48:23] Wow, GC facelift day. [19:49:34] (PS6) Awight: Update input and select styling for GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/174617 (owner: Ejegg) [19:49:40] (CR) Awight: [C: 2] Update input and select styling for GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/174617 (owner: Ejegg) [19:49:47] (PS4) Awight: Clean up GlobalCollect style sheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179052 (owner: Ejegg) [19:49:52] (CR) Awight: [C: 2] Clean up GlobalCollect style sheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179052 (owner: Ejegg) [19:50:26] thanks awight! [19:50:33] no, thank you :p [19:51:00] ejegg: the CC fields are centered in a funny way, but still somehow better than before. [19:51:17] What can we do with an iframe working against us... [19:51:32] awight: yeah, not sure why we make the iframe 318px [19:51:35] Hmm, I just noticed that GC uses labels, and we use placeholders. sigh [19:51:47] ejegg: probably, it's the only size GC supports :) [19:52:00] ehh, good enought for now! [19:52:10] (Merged) jenkins-bot: Update input and select styling for GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/174617 (owner: Ejegg) [19:52:15] (Merged) jenkins-bot: Clean up GlobalCollect style sheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179052 (owner: Ejegg) [19:52:56] ejegg: hey, while atgo-brb isn't looking... feel free to chip away at my PCR from yesterday, it's a pain to maintain this mess all on review branches... [19:53:33] Ah, I don't think anybody is going to argue with PCR. [19:53:38] If they do, send 'em to me. [19:53:43] * K4-713 puts on mean face [19:53:53] Ah, civi-buildkit? Looks interesting. [19:53:56] I don't understand... [19:54:09] I reserve atgo-brb's right to argue... [19:54:10] Code Review = Good. [19:54:13] :p [19:54:20] Even if we can't do anything with the result for a while. [19:54:24] unless it's extremely helpful UX fixes to CentralNotice [19:55:00] * awight smokes a fake cigarrette, after considering odd french spelling for a bit [19:55:03] Unreviewed changes are... basically automatically going to rot. And that's bad. [19:55:26] * awight sighs very loudly [19:55:49] ... [19:56:12] I feel that there is a huge difference between unmerged, and pending deployment. [19:56:15] Massive. [19:59:50] awight: The weird thing about this conversation is that I came in to it heartily backing you up. Now it sounds like we're arguing. So confused. :p [20:00:07] Nah [20:00:21] I'm just considering whether this is a good time to punt any other CR over the fence. [20:00:27] My room is a mess. [20:00:35] That's all the rooms. [20:00:41] We're all over the place. [20:01:00] I feel like we're about to have a party with everybody we know in a really f'd up house. :D [20:01:18] on the bright side, I think we're actually good to go with this CI thing. [20:01:25] F yes. [20:01:30] Seriously? [20:01:41] I thought that was going to not be even next week. [20:01:57] I had a despondent moment last night, but now that I scrape together everything that was just laying around, it's... running. [20:02:24] Huh [20:02:45] That's pretty cool. [20:03:08] The big missing piece of glue was, I had to modify totten's provisioning thing to accept pre-created dbs, and we left that patch unresolved. but it works locally. [20:03:12] which is good enuf for me :p [20:03:15] heh [20:03:32] That definitely counts as progress, yes. [20:03:39] Usable progress, even. [20:03:57] hehe thanks awight :P [20:04:05] yipeS! [20:04:06] atgo-brb: Are you coming in soon? [20:04:12] hehehe you'd better [20:04:14] yeah about to leave my house [20:04:24] in like 5... just packing up [20:04:33] Okay. I have a thing I want to merge and deploy, but I want you to see it in action first. [20:04:41] atgo-brb: join our mutiny! [20:04:55] Aw. This was actually on the wall. [20:05:00] oh neat [20:05:05] merge and deploy on a friday, eh? [20:05:10] urgent enough you wan to screenshare or...? [20:05:19] FUNDRAISING, WOO. [20:05:20] (CR) Ejegg: [C: 2] Log missing transaction identities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178920 (owner: Awight) [20:05:25] Ah, no. It can wait. [20:05:34] (Merged) jenkins-bot: Use currency codes from DonationInterface without copypasta [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178966 (owner: Awight) [20:05:51] ...Didn't I do that yesterday? [20:06:00] * K4-713 frowns [20:06:30] Oh, it had a dependency [20:06:33] Also, why is gerrit trying to run flash? [20:06:36] which I just +2ed [20:06:40] ?? flash?? [20:06:58] eee [20:07:49] ejegg: I think it's been that way forever. It's to help you copy text. [20:07:53] isn't that evil? [20:08:11] [20:08:13] Er... [20:08:16] because I was suddenly too lazy to double-click a field, I actually want that to break, and single-click to have a novel behavior. [20:08:32] (PS1) Awight: Fredge and Donations dbs are in Drupal schema for now [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179534 [20:08:36] What the Flash? [20:09:52] (PS1) Awight: update vendor submodule [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/179535 [20:10:01] K4-713: it's to make single-clicking do something novel. [20:10:13] (CR) Ejegg: [C: -1] "missing assignment to $xmlstart" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178972 (owner: Awight) [20:10:14] Yeah, I was just looking at that too. [20:10:29] ...foodnow. [20:10:56] (CR) Awight: Parse XML charset declaration (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178972 (owner: Awight) [20:11:49] (PS2) Awight: Parse XML charset declaration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178972 [20:14:34] (CR) Ejegg: [C: 2] Parse XML charset declaration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178972 (owner: Awight) [20:14:51] (PS2) Ejegg: Always log the message that would be sent to Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178981 (owner: Awight) [20:24:25] (CR) Ejegg: [C: -1] "Looks like there is a progress indication string of '!', 'X', and '.' characters being output. Maybe call wmf_audit_echo with $verbose=tr" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178981 (owner: Awight) [20:48:48] For some reason in IE9 the fundraising div is getting set to display:none... [20:51:25] (CR) Awight: "That's a really tough call. I want the msg contents to show up in our ordinary job logging, actually. I don't see a convenient resolutio" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178981 (owner: Awight) [20:51:31] ejegg: good point [20:51:40] ejegg: dragging K4|food into the conversation... [20:51:42] awight|lunch: ncurses! [20:51:52] heh [20:51:54] WHAT [20:51:56] hur? [20:52:09] with animations in your terminal [20:52:10] K4-713: hey uh...https://gerrit.wikimedia.org/r/178981 comment thread [20:52:30] aha ANSI foiled again [20:52:55] Hm. [20:53:08] I'm not sure what you mean by " Maybe call wmf_audit_echo with $verbose=true when not in test mode?" [20:53:49] Those char strings are... *incredibly* valuable to have all the time, though. [20:53:51] That's wrt the "message to send" logging, here, https://gerrit.wikimedia.org/r/#/c/178981/2/sites/all/modules/wmf_audit/wmf_audit.module,unified [20:54:17] K4-713: assuming you agree that we should be logging entire msgs... (?) [20:54:25] Sorry, my brain is on another planet right now. [20:54:28] The only compromise I can imagine is to have one of the streams be non-realtime [20:54:31] This is going to take a second. [20:54:33] K4-713: It just looked like you had a nice visual summary going on [20:55:10] so either the hashes are queued in a buffer (annoying when run from the terminal), or the full message dump goes into a buffer. [20:55:41] Generally, I'll observe that it seems sketchy for us to suppress all logging while we're emitting hash characters. [20:55:47] Well, first off, if you run this from the terminal and not jenkins, all the file perms go sideways. [20:55:55]