[03:18:26] (CR) Ejegg: [C: 2 V: 2] MySQLPrecreated db implementation which does not require admin rights [wikimedia/fundraising/civicrm-buildkit/vendor/totten/amp] - https://gerrit.wikimedia.org/r/179384 (owner: Awight) [17:40:23] (PS2) Ejegg: Backend for x-by-y widget with 'group by' [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179340 [18:14:32] ejegg|away: pizzzacat: I'm seeing $0/second needed... is that just a rounding error? [18:15:24] looks like it. no worries [18:18:05] glad I could help [18:18:07] :p [18:18:58] pizzzacat: hello, disembodied voice! Can you make my grandmother's potato harvest successful? [18:19:33] I will sacrifice whiskey and cat food in your honor. [18:19:34] *~* it is so *~* [18:19:38] woohoo! [18:26:16] if anyone has time to review master in dash, it would be greatly appreciated! [18:26:26] pizzzacat: will do! [18:26:34] :D [18:26:45] thanks ejegg! [18:27:01] I am loathe to try working with different patch changes at the same time [18:27:06] it's always grief later [18:27:20] I think we can ignore the x-by-y branch [18:27:26] heh, that loader looks like totoro [18:27:54] since we are now basically just working in master and I had accidentally pushed changes from that branch to master anyway because gerrit doesn't auto-detect branches like github [18:28:13] I'm quite excited about that stupid loader [18:30:48] (CR) Ejegg: "Want to do the loader in a more knockout-y way, with an if binding and a 'loading' property instead of $.show()/hide(), and a text binding" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179200 (owner: Ssmith) [18:32:42] ejegg sure I can do that [18:40:04] hmm and actually maybe it should be a separate binding since it needs to be usable elsewhere [18:40:12] will look into it [18:40:28] pizzzacat: Oh, you mean like a loader per graph? [18:43:26] hey tech! heads up: dropped this (hopefully simple) form update into the sprint: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2288 [18:46:12] atgo: looks simple enough, I think. Is it just GlobalCollect in Canada? [18:46:27] yeah at least for the time being [18:46:47] (PS1) Awight: (FR #2288) Use i18n for State field label [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179970 [18:47:10] awight: did you look at the email from GR this morning? i'd love your eyes on it at some point [18:48:09] ejegg I wasn't thinking that, was just thinking to add a custom binding to bindings.js [18:53:34] (PS1) Awight: (FR #2288) Improved i18n for Canada [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179972 [18:56:09] atgo: the permissions thing is still a much bigger can of worms than we want to eat--otherwise, it looks fine. [18:57:39] (CR) Ejegg: [C: 2] (FR #2288) Use i18n for State field label [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179970 (owner: Awight) [18:58:13] (Merged) jenkins-bot: (FR #2288) Use i18n for State field label [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179970 (owner: Awight) [18:58:18] (CR) Ejegg: [C: 2] (FR #2288) Improved i18n for Canada [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179972 (owner: Awight) [19:00:09] awight: what do you mean? [19:00:22] i'm confused about the difference between bullets 2 and 3 as well [19:00:46] atgo: 'bout permissions? It's not going to be as simple as anyone thinks... [19:00:54] good point--I have no idea what bullet 3 is about [19:00:54] this feature is worthless without it [19:01:06] this feature is worthless with it :p [19:01:36] i dunno, i think that they'll use it [19:01:45] it gives ownership of a report [19:01:58] I understand what the permissions are for. Just letting u know that it's really much nastier than just "Adding permissions" [19:02:17] AFAIK there is not a mechanism in Civi to have ownership of things. [19:02:32] Only bulk permissions like "can see contributions". [19:02:36] hmm ok [19:02:38] well... we'll see [19:02:46] (Merged) jenkins-bot: (FR #2288) Improved i18n for Canada [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179972 (owner: Awight) [19:02:55] GRabbit is good at thinking about security stuff, but I think the estimate may be blown. [19:03:18] (CR) Ejegg: [C: 2] "Looks good for 2015-01-01" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179557 (owner: Awight) [19:03:56] (Merged) jenkins-bot: Deploy once Lithuania is on the Euro. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/179557 (owner: Awight) [19:05:58] as in it should be more? [19:06:14] atgo: yeah. I have no idea, I'm just flagging that line as suspect. [19:06:19] ok.. thanks [19:06:24] i'm concerned with the last one [19:06:33] seriously 3-5 hours to make a change to a radio button? [19:06:35] like.. what? [19:06:47] it's the same functionality that it has right now, just with a less-awful UI [19:07:02] :( I'm not paying too much attention to the budget details [19:07:20] yeah that's my court, but does 3-4 hrs make sense for that? [19:07:30] If they're writing tests :p [19:07:35] ahh [19:15:55] * AndyRussG waves [19:20:48] hi AndyRussG! [19:20:54] atgo: hey :) [19:20:56] awight: hi, how's it going! 2 quick questions... - is it essential that CN's AllocationFixtures have an additional nested (integer-indexed) array for each block of data? and - how close do you think we are to deprecating BannerChooser (and therefore not have to maintain BannerChooserTest)? [19:21:03] ejegg: hi! ^ [19:22:38] * AndyRussG practices hit-and-run IRC! [19:22:45] (back soooon :) ) [19:22:51] Hi AndyRussG! Everyone seems to be satisfied how client-side banner choosing works now, so I'd imagine we can phase out the slots whenever we want [19:22:59] ejegg: cool! [19:23:13] Yeah seems good so far [19:23:14] (I'll get backscrool) [19:24:52] Jeff_Green: I needa peek at the slow query logs, again :-/ this time, the excitement was from a few minutes ago. [19:25:15] awight: aargh, more lybunt? [19:27:58] ejegg: nah, this one is a search of all contribs from H [19:28:03] from July til now [19:28:28] oh, I see the email [19:38:17] (PS1) Awight: Send useragent header for banner bot [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/179976 [19:40:18] (CR) Ejegg: [C: -1] "All looks good except the typo jslint caught in bannerController.js (lines 223-4)" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176251 (owner: Awight) [19:42:42] (PS5) Awight: Remove unused banner variance parameters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176251 [19:42:49] (CR) Awight: "wow, horrifying fail!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176251 (owner: Awight) [19:44:48] AndyRussG|away: yep, I agree with ejegg that we're ready to deprecate slots [19:45:33] AndyRussG|away: nothing about the fixtures is immutable, change at will! I'm not even sure what extra level of hierarchy you're referring to... [19:46:25] awight: think it's all the single-element arrays inside the top-level array [19:46:50] awight: ok. one moment [19:47:01] (CR) OliverKeyes: [C: -1] "Email address rather than URL, for easier mapping of problems to people?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/179976 (owner: Awight) [19:47:20] ejegg: oic, yeah no idea why I did that! [19:49:28] (PS2) Awight: Send useragent header for banner bot [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/179976 [19:49:55] (CR) Ejegg: [C: 2] Remove unused banner variance parameters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/176251 (owner: Awight) [19:50:24] \o/ [19:50:44] (CR) OliverKeyes: [C: 1 V: 1] "LGTM." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/179976 (owner: Awight) [20:18:28] awight:did you figure out when the db connection was getting switched in the previously-deployed version of the campaign pager? [20:19:16] I only see mDb getting set in the IndexPager constructor [20:19:54] awight: I copied the slow log but forgot to tell you :-) [20:19:55] and reallyDoQuery calls buildQueryInfo (which calls getQueryInfo) right before calling mDb->select. [20:19:58] it's in your homedir on barium [20:23:29] ejegg: yes, in the last iteration was constructing a database object, but never using it. code only worked locally by accident! [20:23:36] Jeff_Green: thanks! [20:23:41] np [20:24:01] awight: Ah, that's right, we weren't even using getDatabase [20:24:14] ejegg: hehe. my bad. [20:34:16] (CR) Ejegg: [C: 2] "SQL looks good, concat max option now set on same connection as select. Still produces identical HTML as the multi-select version." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177758 (owner: Awight) [20:55:29] awight: OK, thanks! ejegg|food thanks for +2ing those CN patches... [21:29:14] (PS1) Awight: i18n the remaining State fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180017 [21:54:49] (CR) QChris: [C: 1] "Does merging trigger magic, or is ok to CR+2 in this repo?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/179976 (owner: Awight) [22:09:27] (CR) Ssmith: "Awight, there is another patch after this one - and yes this is still in development - any reason you're asking?" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [22:35:58] (CR) Awight: "Sorry to bother u--I was looking for things to review, and came across this. Seems like it should either be marked a WIP, or it should ha" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [22:38:26] (CR) Ejegg: "awight: good point, will move the backend patch ahead of this one" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [22:47:27] (PS3) Ejegg: Backend for x-by-y widget with 'group by' [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179340 [22:47:29] (PS2) Ejegg: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [22:47:31] (PS4) Ejegg: Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [22:47:41] (CR) jenkins-bot: [V: -1] Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [22:55:50] ejegg: hey, can u do a quick sanity check of https://gerrit.wikimedia.org/r/180017 [22:55:59] I'm gonna do a payments deploy... [22:56:08] sure [22:56:18] thx! [22:58:21] (CR) Ejegg: [C: 2] i18n the remaining State fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180017 (owner: Awight) [22:58:53] (Merged) jenkins-bot: i18n the remaining State fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180017 (owner: Awight) [23:04:06] (PS1) Awight: Default to mark refunds as completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/180030 [23:07:07] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180033 [23:07:09] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180034 [23:07:11] (PS1) Awight: Prevent double clicks on gc cc forms [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180035 [23:07:13] (PS1) Awight: Clean up a little logspam [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180036 [23:07:15] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180037 [23:07:17] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180038 [23:07:19] (PS1) Awight: (FR #2288) Use i18n for State field label [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180039 [23:07:21] (PS1) Awight: (FR #2288) Improved i18n for Canada [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180040 [23:07:23] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180041 [23:07:25] (PS1) Awight: i18n the remaining State fields [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180042 [23:07:42] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180033 (owner: Awight) [23:07:49] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180034 (owner: Awight) [23:07:58] (CR) Awight: [C: 2] Prevent double clicks on gc cc forms [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180035 (owner: Awight) [23:08:04] (CR) Awight: [C: 2] Clean up a little logspam [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180036 (owner: Awight) [23:08:10] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180037 (owner: Awight) [23:08:16] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180038 (owner: Awight) [23:08:21] (CR) Awight: [C: 2] (FR #2288) Use i18n for State field label [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180039 (owner: Awight) [23:08:29] (CR) Awight: [C: 2] (FR #2288) Improved i18n for Canada [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180040 (owner: Awight) [23:08:33] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180041 (owner: Awight) [23:08:38] (CR) Awight: [C: 2] i18n the remaining State fields [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180042 (owner: Awight) [23:08:53] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180033 (owner: Awight) [23:08:55] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180034 (owner: Awight) [23:08:57] (Merged) jenkins-bot: Prevent double clicks on gc cc forms [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180035 (owner: Awight) [23:08:59] (Merged) jenkins-bot: Clean up a little logspam [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180036 (owner: Awight) [23:09:02] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180037 (owner: Awight) [23:09:08] flash flood alert! [23:09:28] * ejegg clings to a branch [23:09:45] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180038 (owner: Awight) [23:09:47] (Merged) jenkins-bot: (FR #2288) Use i18n for State field label [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180039 (owner: Awight) [23:09:49] (Merged) jenkins-bot: (FR #2288) Improved i18n for Canada [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180040 (owner: Awight) [23:10:10] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180041 (owner: Awight) [23:10:12] (Merged) jenkins-bot: i18n the remaining State fields [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180042 (owner: Awight) [23:15:46] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180044 [23:15:59] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180044 (owner: Awight) [23:17:46] (PS1) Awight: enable WorldPay form in Israel [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180046 [23:19:37] * AndyRussG is nearly washed away... [23:21:08] (CR) Katie Horn: [C: 2] enable WorldPay form in Israel [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180046 (owner: Awight) [23:21:34] (PS2) Ssmith: Add loader gif [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179200 [23:22:18] Numbers on the dash are looking exciting [23:22:24] NaN :p [23:27:50] (PS1) Katie Horn: Globalcollect form and iframe content css changes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180049 [23:29:02] (CR) Awight: "What's with the inline style? Can't u push that into the stylesheet?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180049 (owner: Katie Horn) [23:29:14] (CR) jenkins-bot: [V: -1] enable WorldPay form in Israel [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180046 (owner: Awight) [23:31:40] (CR) Awight: "recheck" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180046 (owner: Awight) [23:34:53] (CR) Ejegg: [C: -1] "Loader div show/hide looks good! Please swap out the jQuery ellipses update with updates to a bound observable." (2 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179200 (owner: Ssmith) [23:38:08] < $4k remaining... [23:42:58] woohoo! [23:43:22] !log update payments from 21afbcf24c0e2124f783cc3c2c65621569675d6f to f3fd79aaaf730f8fd18a72f83c11e9cc111a0aab [23:43:27] Logged the message, Master [23:44:14] <:o) <:o) <:o) <:o) <:o) [23:44:33] <:o) <:o) <:o) <:o) <:o) [23:45:54] .me high-fives pizzzacat [23:45:56] oops [23:46:02] I guess that means I missed. [23:46:19] heh [23:46:29] it's ok, I missed too [23:48:15] haha [23:48:37] pizzzacat: These negative numbers are messing with the axies. :) [23:48:43] That happens to me sometimes too. [23:48:54] * K4-713 fidgets [23:49:18] ejegg: how does this thing work? I see SQL in the html, here: src/components/boards/bigEnglish/bigEnglishBoard.html [23:49:29] for real? [23:49:41] awight: oops, that one still has the dummy SQL [23:49:46] oh heh ok [23:49:59] the data route does return the SQL though [23:50:32] But I mean... the frontend doesn't speak raw SQL, or does it? [23:50:34] unfortunately, that SQL still has ?s in place of the tokens [23:50:48] awight: Right, the backend doesn't read in any SQL from the front [23:51:00] k [23:51:08] but pizzzacat wanted to be able to show users what the queries look like [23:51:35] oh I see the query now, widgets/big-english.js [23:51:37] very nice! [23:52:19] yeah, only trick with the token substitution would be deciding what to quote. Though I guess we can just quote everything [23:52:29] yeah that works [23:54:41] K4-713 yeah I was just thinking about this... [23:55:24] I should just have it stop at 0 [23:57:17] pizzzacat: Whole new set of bugs! Can you make the page fill up with dancing hamsters when the goal is met? :D [23:57:54] ooooh [23:58:04] yes [23:58:11] is that a "bug"??? [23:58:21] that it didn't do that?? [23:58:42] I mean... I think so. :p [23:58:55] That didn't get in the acceptance criteria? [23:58:56] me too… I am so sorry [23:59:01] heheh [23:59:10] vmp [23:59:11] er [23:59:18] Let me just GIBBERISH.