[00:09:20] (PS1) Awight: Revert "Prevent double clicks on gc cc forms" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180081 [00:09:39] K4-713: ^^ [00:09:58] Is that for sure what's doing it? [00:10:03] hey awight are you going to undo the israel form you just pushed out in your rollback? [00:10:08] K4-713: is there another guess? [00:10:09] atgo: no [00:10:12] cool thanks [00:10:12] want me to? [00:10:13] Let me test here. [00:10:13] ok [00:10:16] thx [00:11:04] K4-713: we can fix, but... later [00:11:24] awight: I want to make sure the change takes the problem away, is all. [00:11:27] k [00:12:36] (CR) Katie Horn: [C: 2] "tested and verified" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180081 (owner: Awight) [00:13:00] awight: That was totally it. [00:13:15] wow, master is too crazy for me to even confirm locally [00:15:28] ccogdill: fyi, we just introduced a bug where the credit card choice buttons can become disabled. it happens when you get a form validation error for the initial block of info, name address etc. [00:15:41] ccogdill: trying to roll back now, but you'll probably hear about this. [00:16:00] did this just happen? [00:16:28] and when you say it happens when you get a from validation error, does that mean it’ll happen if you mis-type that info on the 1st try? [00:16:40] r u here, I can show you [00:17:00] ccogdill: if you do anything wrong on the 1st try, the form locks up and the credit card buttons become unusable. [00:17:10] okay that makes sense [00:17:13] I’m at home [00:17:19] This will have started affecting people around 3:45 today [00:19:28] (PS1) Awight: Revert "Prevent double clicks on gc cc forms" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180085 [00:19:37] (CR) Awight: [C: 2] Revert "Prevent double clicks on gc cc forms" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180085 (owner: Awight) [00:20:02] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180086 [00:20:11] (PS1) Ssmith: Fix negative number issue [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180087 [00:21:04] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180086 (owner: Awight) [00:21:25] (Merged) jenkins-bot: Revert "Prevent double clicks on gc cc forms" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180081 (owner: Awight) [00:22:05] (CR) Awight: [C: -1] "Should be on -master branch?" [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180087 (owner: Ssmith) [00:26:25] (PS1) Ejegg: Substitue values in SQL returned for display [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180090 [00:30:11] (Merged) jenkins-bot: Revert "Prevent double clicks on gc cc forms" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/180085 (owner: Awight) [00:32:00] hey guys - heading home because no computer charger (oops)... will get back online on my personal machine when i get there [00:32:20] (PS1) Awight: safe-ish lint fixups [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180091 [00:34:25] !log payments updated from f3fd79aaaf730f8fd18a72f83c11e9cc111a0aab to 3dde7be76284aa37b74038dfb4473671999dfcff [00:34:29] Logged the message, Master [00:35:13] ccogdill: ok, we just reverted the credit card radio bug... [00:36:07] okay thanks awight! [00:40:30] (PS1) Awight: satisfy jslint complaints about "define" and "require" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180094 [00:47:12] (PS1) Ssmith: Fix negative number issue [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180096 [00:49:50] (CR) Ejegg: [C: 2] "alphabetized, even!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180094 (owner: Awight) [00:53:05] (CR) Ejegg: [C: -1] "need to update dataChanged computation to keep the graphs updating when the total raised changes after goal is met. Maybe just return sel" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180096 (owner: Ssmith) [00:59:15] (CR) Ejegg: [C: 2] safe-ish lint fixups [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180091 (owner: Awight) [01:02:06] (PS1) Awight: more lint silence [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180100 [01:02:08] (PS1) Awight: require numeraljs before using [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180101 [01:05:03] (CR) Awight: [C: -2] "This doesn't work." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180101 (owner: Awight) [01:05:42] pizzzaBrbCoffee: heads-up, you'll probably want to rebase in a few cos I'm yanking the carpet back n forth... [01:10:47] (CR) Ejegg: "try 'numeraljs'" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180101 (owner: Awight) [01:22:06] awight ? [01:22:22] rebase what, and what does that mean about the carpet? [01:22:54] he's just making all sorts of tiny changes to master [01:23:03] to clean up the stuff lint's complaining about [01:23:33] ok, what should I rebase? should I wait? [01:24:13] should I do it now or keep working on this fix and worry about it later? [01:27:33] awight ejegg ? [01:27:59] pizzzacat: I was hoping to +2 em all real quick so you could rebase now [01:28:25] but after the big cleanup thing I'm seeing 'source data is missing a component' errors [01:28:33] I suspect it may be a pre-existing issue [01:28:48] but I have no idea why this cleanup would have exposed it [01:28:50] what is the issue? [01:29:21] pizzzacat: try pulling down https://gerrit.wikimedia.org/r/#/c/180100 [01:29:49] and see if you get an error logged to console. [01:30:10] I think it happens when we initially call makeCharts before we have data [01:31:19] if I run it, I don't see an error [01:31:25] oh wait [01:31:29] console as in browser? [01:31:34] yeah [01:31:53] I do get one that says source data is missing [01:31:56] I think it may have been happening sporadically before [01:32:13] as a separate issue to what we're trying to look at right now you mean? [01:32:58] Yeah, I can't see anything in awight's commit that should cause that [01:33:16] ok just making sure. yeah I think it's just my dataset. [01:33:35] it's a c3 error [01:33:55] yeah, but I think we're causing it by sending mismatching arrays [01:33:56] current date doesn't work with everything I have in my dataset [01:34:07] oh so it is the issue? I'm confused [01:34:59] ehh, I can sometimes get the same error a couple revisions back. So it's totally not awight's commit. [01:35:05] sorry for the confusion [01:36:01] (CR) Ejegg: "Thanks for all the cleanup!" (4 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180100 (owner: Awight) [01:36:13] (CR) Ejegg: [C: 2] "Thanks for all the cleanup!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180100 (owner: Awight) [01:37:42] (PS2) Awight: require numeraljs before using [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180101 [01:38:09] (CR) Awight: require numeraljs before using [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180101 (owner: Awight) [01:39:10] ejegg awight I am going to wait until these changes are finished to proceed - then what am I rebasing? [01:39:22] my newFix branch on top of master? [01:39:29] yep! [01:39:34] ok thanks [01:39:37] and probably the x-by-y branch too [01:40:33] thinking to kill that branch since it's already in master [01:40:42] and your stuff was added to master right? [01:40:46] for that chart [01:41:06] so no need anymore [01:41:11] oh yeah, guess i was in master for that one [01:41:44] (CR) Ejegg: [C: 2] require numeraljs before using [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180101 (owner: Awight) [01:42:10] pizzzacat: think that's the lot of them [01:42:49] 'git pull --rebase origin master' when ready! [01:44:02] ok thank you! [01:46:22] anyone else missing the distance to goal chart? [01:46:41] I found it under the couch cushions! [01:46:55] er, i mean nope, not missing it here [01:47:30] There are 4 more lint errors but I'm done screwing up other people's lives for the day :) [01:48:07] awight: I'll try to knock em out. WIll be nice to have lint voting again [01:48:20] i mean, 'bye'! [01:51:40] weird, it's back. didn't touch anything. [01:51:44] ghosts [01:51:47] everywhere [01:56:36] (PS1) Ejegg: Wait for data before showing graphs [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180111 [02:03:05] (PS2) Ssmith: Fix negative number issue [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180096 [02:03:41] ejegg I think that fixes everything [02:03:45] cool! [02:04:06] always nervous when I'm not testing against the realistic data [02:04:15] easier to miss things [02:04:28] anyway. thank you! [02:04:41] pizzzacat: this one should kill the 'source data' errors: https://gerrit.wikimedia.org/r/180111 [02:07:27] well I definitely don't see them now when I run it, but it wasn't ever really consistent, it was just when something else was broken it wouldn't work [02:07:56] so I didn't break anything more! [02:08:13] :) [02:08:41] (CR) Ssmith: [C: 2] Wait for data before showing graphs [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180111 (owner: Ejegg) [02:08:47] (Merged) jenkins-bot: Wait for data before showing graphs [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180111 (owner: Ejegg) [02:09:06] (CR) Ejegg: [C: 2] Fix negative number issue [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180096 (owner: Ssmith) [02:09:43] yay do you want me to merge/gulp/deploy? [02:09:52] sure, if you wanna! [02:10:13] sure! [02:11:35] is it just go into deployment branch, merge master, gulp, deploy? [02:12:00] yeah, just make sure you've got the latest master first [02:12:03] you are usually the one who merges [02:12:08] yep yep [02:12:47] then of course the gulp n merge need checking in / reviewing, either seperately or together [02:16:36] (PS1) Ssmith: Merge from master, gulp [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180113 [02:16:39] (CR) jenkins-bot: [V: -1] Merge from master, gulp [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180113 (owner: Ssmith) [02:17:02] (CR) Ssmith: [C: 2] Merge from master, gulp [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180113 (owner: Ssmith) [02:17:05] (CR) jenkins-bot: [V: -1] Merge from master, gulp [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180113 (owner: Ssmith) [02:17:55] pizzzacat: ah, guess you needed the latest on deploy branch too [02:18:37] probably going to have to redo the merge and gulp [02:18:49] ejegg what do you mean the latest? [02:18:59] oh I didn't pull? jeeze [02:19:49] you can go back to where you were: git reset --hard 08aa8905454f08d843542b4562f1ffe4f318e6d6 [02:20:04] and delete dist/scripts-29749b3e.js [02:20:10] then pull [02:20:12] ok when I can read that through my tears of sadness and disappointment I'll do it [02:20:14] then redo the merge [02:20:15] :p [02:20:19] heh [02:21:10] it says I don't have that dist file [02:21:16] oh, ok [02:21:18] after i do the reset [02:21:37] cool, I forgot whether that would go away [02:21:50] so you can just pull and remerge [02:22:18] ok so my top should be the UTC fix one? [02:22:33] Lemme see [02:22:59] yep, the merge/gulp of UTC and the syslog fix [02:23:00] just wanting to double check.. because of how many times I'm screwing this up [02:23:05] word [02:23:44] (Abandoned) Ssmith: Merge from master, gulp [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180113 (owner: Ssmith) [02:25:11] ejegg that fix of yours inadvertently makes the ugly charts (pre-load) problem go away too! [02:25:36] ah, cool! [02:25:56] (PS1) Ssmith: Merge, gulp, ready to deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180114 [02:26:01] (CR) jenkins-bot: [V: -1] Merge, gulp, ready to deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180114 (owner: Ssmith) [02:26:27] (CR) Ssmith: [C: 2] Merge, gulp, ready to deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180114 (owner: Ssmith) [02:26:32] (CR) jenkins-bot: [V: -1] Merge, gulp, ready to deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180114 (owner: Ssmith) [02:26:56] ejegg linting failed… [02:27:14] yeah, we haven't killed all the lint 'errors' yet [02:27:21] but it's not voting still [02:27:27] ok cool, so ignore and verify then? [02:27:29] looks like npm died there [02:27:50] RIP [02:27:54] oh, did you change node_modules? [02:28:32] no I didn't... [02:28:51] just need to take that out of the commit then [02:29:16] it's got node_modules pointing to a version that gerrit can't find yet [02:29:33] oh so I need to update the submodules? [02:29:56] or just ignore it in the commit? can I do that in an amend? [02:29:57] nono, just amend the commit without the node_modules part [02:30:00] word [02:32:02] can I do git rm —cached -r node_modules? [02:32:13] try git reset HEAD^ node_modules [02:33:09] ok then commit? or how does that work? [02:33:18] then commit --amend [02:33:19] since I don't have something to "add" [02:33:23] ok cool [02:33:37] checks out [02:33:46] woot [02:33:47] (PS2) Ssmith: Merge, gulp, ready to deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180114 [02:34:10] (CR) Ssmith: [C: 2] Merge, gulp, ready to deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180114 (owner: Ssmith) [02:34:12] yaay [02:34:16] (Merged) jenkins-bot: Merge, gulp, ready to deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180114 (owner: Ssmith) [02:34:22] hoorah [02:38:07] all set - deployed [02:38:24] cool! [02:38:31] I'mma head out for now [02:41:39] me too, see you later! [17:57:22] Anyone licked the RTL issues Amir just brought up? [18:02:25] awight: Nope! [18:02:31] Going, going, gone. [18:02:55] I win :-/ [18:04:13] * AndyRussG didn't know u could do that to RTL issues over IRC [18:05:18] There are boiled newt's legs IRL here [18:06:29] Hmmm hard to visualize [18:06:50] I'll stop trying now [18:24:30] http://www.sbs.com.au/news/article/2014/12/14/comment-will-editing-disputes-mean-end-wikipedia [18:27:24] hi all, here is your cat of the day(tm) https://38.media.tumblr.com/22ffab503bfeaaa340ed259775a21c53/tumblr_nglehvwKNG1t2ph9to1_400.gif [18:29:16] This year's mashups! http://bootiemashup.com/bestofbootie2014/ [18:33:26] K4-713: you sent an email, was I supposed to read it? Cos i did not receive. [18:33:32] On first glance, I'll take the cat rather than the mashups..... [18:33:36] awight: Huh? [18:33:48] K4-713: nvm! [18:34:31] Weird. Okay. :) [18:37:15] pizzzacat: that cat resembles me this morning. [18:37:19] awight: I'm seeing that CentralNoticeTestFixtures::defaultCampaign and defaultBanner are legacy and public, but I don't see them used outside CentralNoticeTestFixtures on any legacy tests [18:38:09] I guess they were orignally just made public in case they'd be used elsewhere, but until now never were? [18:38:28] I thought someone would relate to it [18:38:39] AndyRussG: isn't it used here, tests/ApiCentralNoticeBannerChoiceDataTest.php [18:38:49] tests/BannerChoiceDataProviderTest.php [18:38:59] it was a terrible was to do this though, feel free to rewrite! [18:39:03] s/was/way [18:39:12] awight: nothing terrible :) [18:39:30] Yes I see they're used there, but those are new tests for the new banner choice system [18:40:14] I'm just refactoring a bit and not wanting to unwittingly run over any of the previously existing tests/thinking [18:41:46] oh hrm [18:41:58] No I don't think those variables were used in the legacy world [18:42:05] the legacy tests are... sorta worthless, though [18:47:03] awight: mmm well maybe they could be nudged into something of greater value (a bit later) [18:47:25] (PS1) Ejegg: fix moar lint [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180223 [18:47:28] AndyRussG: Don't worry about breaking them, just delete if that's easier! [18:47:52] Heh OK... uhh now that I see they don't actually use the fixtures data, I think it's OK :) [18:48:07] Makes sense! [18:48:48] awight: the first thing to do I think will be to move the defaults into a common property of the fixtures data, to be shared in PHPUnit and QUnit [18:49:31] ejegg: I was wondering how requirejs imports the globals. I don't understand where the global Chart variable in chartjs gets turned into a root-level thing... [18:49:32] Then I think add to each scenario different input values to try and expected output values to receive [18:49:59] awight: hmm, yeah, that's some voodoo for sure [18:50:17] well, jslint's still complaining there [18:50:20] AndyRussG: awesome. Yeah the default settings are a bit suspect, cos they are also shadowed in the application code, so we're probably hiding bugs. [18:50:21] That'll make it possible to test various buckets, more code paths and intermediate stages in the algorithm in QUnit [18:50:53] shadowed? u mean they try to copy the api defaults or something? [18:51:01] awight: [18:51:02] else if (typeof module === 'object' && module.exports) { [18:51:02] module.exports = Chart; [18:51:04] } [18:51:13] whaa ok then [18:51:29] so 'exports' is the root object [18:54:37] ejegg: mebbe rename the function parameter back to "Chart" [18:54:52] almost clean! I'll prepare the patch to make jslint voting... [18:54:56] Sorry pizzzacat and ejegg [18:55:03] it's for your health :p [18:55:10] eh? [18:55:16] * pizzzacat reads back [18:55:20] I'm about to make your lives absolutely miserable [18:55:21] hehe, was hoping we'd get back there [18:55:30] jslint errors will prevent your patches from merging :) [18:55:33] have a nice day. [18:55:47] (PS2) Ejegg: fix moar lint [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180223 [18:55:48] Chart is part of the chartjs library [18:55:58] which is required in the modules when needed [18:56:04] * pizzzacat keeps reading to see if that helps [18:56:12] pizzzacat: yeah, we were just referring to it in the global scope [18:56:18] pizzzacat: yeah, jslint was squawking about us relying on magic, asssuming that window.Chart was a thing. [18:56:46] rather than by the name we gave it in the args of our 'define' function [18:57:16] clean! [19:01:54] awight just explained irl thanks awight [19:04:22] (CR) Awight: [C: 2] "Runs locally." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180223 (owner: Ejegg) [19:04:28] (Merged) jenkins-bot: fix moar lint [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180223 (owner: Ejegg) [19:05:53] There's a zuul config patch to make the job voting, https://gerrit.wikimedia.org/r/180226 [19:06:02] thanks! [19:07:20] hey ccogdill [19:08:10] hey atgo [19:08:58] i'm writing a question to WP about processing in Israel [19:09:26] and wanted to know if you had any questions in particular besides about refunds in the console [19:09:30] ccogdill: ^ [19:09:52] yeah, manual settlement [19:09:59] but I know that’s also related to the order ID issue [19:11:09] (Abandoned) Ssmith: Fix negative number issue [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/180087 (owner: Ssmith) [19:11:19] yeah [19:11:26] i'm ccing you on the email [19:11:32] atgo: !! /me flounders a bit [19:11:34] whatchu need [19:11:35] so feel free to jump in with further follow up [19:11:52] awight: zuul changes - should they be deployed by the merger? [19:11:57] yep [19:12:10] U can do it if you feel like a 1-hr segue :) [19:12:23] Last I tried, setting up Jenkins and JJB was a beast. [19:12:24] hmmm. Lemme look up what's involved [19:12:41] JJB? Some kinda Javabeans? [19:12:48] http://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder [19:12:53] o [19:13:06] seeriously, it is as evil as beans [19:13:50] just for fun, I'll see where I hit the evil bits [19:13:59] wow, godspeed. [19:14:14] hashar will be very happy. [19:15:04] I've been able to build JJB configs locally, and install Jenkins, but never test on my local instance. [19:15:09] awight: hmm? [19:15:10] that felt like a blocker...\ [19:15:29] build the configs, but not test? [19:15:34] atgo: ooh. I'm about to deploy #2278, then will be ready to work for beer [19:15:38] ejegg: exactly [19:15:44] * atgo goes to buy beer [19:15:59] * awight dances on one swollen foot [19:16:00] raaad thank you for pushing that one out [19:16:47] there [19:16:50] whoops [19:17:01] there's the hebrew stuff and looking into CUP [19:17:13] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/180235 [19:17:16] awight: Deploying Zuul config change now [19:17:20] or also megan would like to run a test without the city/state, so investigating if that's possible [19:17:21] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/180235 (owner: Awight) [19:17:29] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/180235 (owner: Awight) [19:17:46] or if we have to trick GC or WP in some way to run it [19:18:06] !log update crm from 28b68e23b670fe52a401659bde800b64d05e25bf to f1e558592ee98ff8fc84d19ff2c0435619e11242 [19:18:13] Logged the message, Master [19:18:21] Krinkle: great, thx! [19:18:23] ejegg: ^^ [19:19:05] Krinkle: btw, do you know if anyone has been able to test Jenkins jobs locally? [19:19:40] I'm willing to do so, but the mw.org docs don't quite get me where I need to be with the local instance... [19:19:41] (PS3) Ssmith: Add loader gif [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179200 [19:20:12] (CR) jenkins-bot: [V: -1] Add loader gif [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179200 (owner: Ssmith) [19:20:14] awight: No, and nobody should aspire to do so. [19:20:26] awight: Instead, jenkins-jobs should run whatever you would run locally. [19:20:36] awight: e.g. "jshint ." is simple enough. [19:20:42] or "npm install && npm test" [19:20:52] (which doesn't isntall anything globally) [19:21:39] Krinkle: mmm, I see what you're saying, but for writing a new task... [19:22:09] Any logic should exist in the repo. Jenkins only serves as a thin shim to run that logic logic. [19:22:13] Krinkle: on that note, if you're in a CR mood, https://gerrit.wikimedia.org/r/#/c/158554/ [19:22:30] awight: So a new test should probably be a grunt task, not a full blown Jenkins job. [19:22:34] Which can run as part of 'npm test' [19:22:49] That would be a nice approach... [19:22:52] That also makes it easier to run for collegues. They shoudln't have to know about which 10 commands to run, there should be one. [19:22:59] agreed. [19:23:20] Could also be a bash script, or make file, or npm-test, or composer-test. Any form of abstraction you prefer. [19:23:37] I'd recommend using npm-test and/or composer-test as those are most flexible and have templates for them in Jenkins. [19:23:45] Well, the CR I just lobbed in your direction is the exact opposite of what you suggest :) [19:23:58] (CR) Ssmith: [C: 2] Substitue values in SQL returned for display (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180090 (owner: Ejegg) [19:24:09] (Merged) jenkins-bot: Substitue values in SQL returned for display [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/180090 (owner: Ejegg) [19:24:18] awight: yeah, those scripts should not exist in integration/jenkins [19:24:33] We ran into an issue where I want to introduce CI for CiviCRM+Drupal, and we have to leverage a whole provisioning thing, "civicrm-buildkit" [19:24:37] awight: Though db-level abstraction is a tough one to easily do locally. [19:24:41] right. [19:24:59] The catch is the fact that the scripts in that patchset need to run with root privs, and interface with the CI system [19:25:03] (CR) Ssmith: "No bother, Awight, just wondered if there was something I was missing." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [19:25:09] awight: I think antoine knows about those scripts, I'm not touching at the moment. No familiarity or ability to test them. [19:25:12] so I think they actually are appropritate for integration/jenkins [19:25:17] Krinkle: yep, that's fine [19:25:27] I just have to figure out which rope to pull to wake him up :) [19:25:44] Well, nothing is appropriate for integration/jenkins, that repo is going away. But for the moment, what is in there, can continue iteration. [19:25:56] that works [19:26:03] I'd like these scripts to die... [19:26:04] We're finding a new home for everything that is more maintainable and re-usable. [19:26:12] but they are unborn as of yet [19:26:34] But it won't be a one-for-all home. They'll have different solutions (mostly local to the source repos) depending on the thing. [19:28:27] Sounds better. [19:28:44] Yeah I was chatting with Antoine a few months ago, I like the .travis way of doing things... [19:29:07] I'm interested in whether marktraceur's opinion of that has changed, too. [19:29:30] The idea being pretty much what you were saying, that all the logic to provision and test a repo is self-contained along with the code. [19:29:49] anyone want to translate this jslint complaint: "Build step 'Execute shell' marked build as failure" ? [19:29:55] baaa [19:30:04] <:o) [19:30:51] awight translated it. it means he is a big jerk. (his words) [19:31:05] hehe [19:31:06] K4-713: where is that wiki page you made about refactor? [19:31:27] It's on mediawiki.org... [19:31:41] hiding in broad daylight! [19:31:55] http://www.mediawiki.org/wiki/Extension:DonationInterface/Refactor_2015 [19:32:00] thanks! [19:32:04] I didn't, like, link it from anywhere or anything. [19:32:10] ...or categorize. Oops. [19:32:22] i just added it to our mingle card, so at least it's there [19:32:58] awight: We have a similar system now with npm test. [19:33:01] And grunt. [19:33:08] (Abandoned) Ejegg: Update node modules [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/177012 (owner: Ssmith) [19:34:09] (PS4) Ssmith: Add loader gif [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179200 [19:34:55] marktraceur are you referring to jslint? [19:34:59] marktraceur: hrm. I've been meaning to look at npm test, noticed it was running on some repos with little to no js [19:35:20] so I guess it's just a harness for miscellaneous testing [19:36:10] K4-713: sorry, I unorphaned the refactor page by adding a Special:PrefixIndex template at the bottom of https://www.mediawiki.org/wiki/Extension:DonationInterface#See_also [19:38:22] pizzzacat: No, jslint gets run by grunt, but there are other things too. [19:39:26] totally. thought maybe you were talking about the thing I was talking about earlier, sry! [19:43:34] pizzzacat: K4-713: u want me to mess around with #2276? [19:44:01] awight: Ah, sure. [19:44:12] k [19:44:17] I need to acquire a food. [19:46:40] pizzzacat: want to head out to meet daryl? [19:47:06] yes [19:47:09] one sec [20:43:42] awight|notafood: got a quick explanation of fixtureDeviceId? Sorry for the bother... [20:58:52] AndyRussG: hmm, searching.. [20:59:43] AndyRussG: oh, that is cruft from when the devices were not added correctly under sqlite, so we had to create one to use in tests. [20:59:51] U might want to check if that's still the case. [21:13:35] awight|stoodup: ah OK thanks... [21:15:27] K4|away: so, the new thing should be a submethod of 'ew' rather than a new method [21:15:30] right? [21:17:49] ejegg: Ah, I would need to confirm with the GC docs if it's an ewallet or not. [21:18:02] Where did you get it? [21:18:52] oh, does that make a technical difference? Thought it was just our classification [21:19:11] yeah, the classification in globalcollect.adapter has to match GC's docs [21:19:12] hey awight! so with the WP fixes out, just confirming, we can run some US donors through? [21:19:13] There are differences in the internal... stuff. [21:19:18] but after that, it can be whatever we want. [21:19:22] atgo: yep! [21:19:29] oh yes, product category: eWallet [21:19:38] Yep, okay then. [21:19:42] cool [21:19:48] will make some cards [21:20:16] ejegg: There are probably some horrible things going on in staging. Like... changing the INSERT_ORDERWITHPAYMENT transaction structure. [21:20:27] ...switching on payment type. [21:20:44]