[00:14:47] <atgo>	 yeah i just yelled at them
[00:14:49] <atgo>	 nicely
[00:16:49] <K4-713>	 :)
[00:41:21] <atgo>	 K4-713: i'm not sure what to do if they don't respond...
[00:41:36] <K4-713>	 Check email at 5am?
[00:41:39] <atgo>	 but i have to run and get home to meet a dogwalker... so we'll see
[00:41:46] <K4-713>	 k
[00:41:47] <awight>	 Wow, vagrant has gotten real messy since the last time I looked.  It requires 64-bit machines and an NFS server...
[00:41:48] <atgo>	 ugh... i mean, i think we can just do it another time? like monday?
[00:41:59] <K4-713>	 I'm okay with that.
[00:42:01] <atgo>	 ok
[00:43:00] <awight>	 It's partially incompatible with FDE...
[00:54:45] <awight>	 K4-713: sounds fun
[00:56:25] <K4-713>	 ?
[00:56:38] <awight>	 I heard some choice groaning
[00:56:40] <K4-713>	 The groaning I'm doing, or the stuff leaking out of my headphones?
[00:56:42] <awight>	 hehe
[00:56:43] <K4-713>	 haha
[00:56:46] <K4-713>	 Yes, that.
[00:56:49] <awight>	 yeah, and saw payments-init flying by
[00:56:52] <awight>	 anyway.
[00:57:02] <awight>	 What, does everyone have seasonal affective disorder?
[00:57:02] <K4-713>	 Nah, I'm scrutinizing DonationInterface some more.
[00:57:19] <awight>	 Let's save the bathwater!
[00:57:56] <K4-713>	 I just went "graaaaaarnnngh" because I thought about... the entire way we get data from the gateway adapters.
[00:58:10] <K4-713>	 Which is The Suck.
[00:58:49] <grrrit-wm>	 (PS1) Awight: Merge REL1_23 into fundraising/REL1_23 [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180375
[00:59:03] <awight>	 ejegg: K4-713: ^^ we should probably jump on that
[00:59:13] <K4-713>	 Er.
[00:59:17] <awight>	 surprise!
[00:59:28] <ejegg>	 oh?
[00:59:29] <K4-713>	 blah
[00:59:48] <awight>	 for a good time, try git log origin/fundraising/REL1_23..origin/REL1_23
[00:59:53] <K4-713>	 You do realize that even low load for December is still pretty freaking high, right?
[01:00:25] <grrrit-wm>	 (Abandoned) Awight: Merge REL1_23 into fundraising/REL1_23 [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/180375 (owner: Awight)
[01:00:39] <K4-713>	 Abandoned?
[01:01:11] <K4-713>	 Could have -1 until we had a more strategic moment.
[01:01:35] <awight>	 I'll just redo the merge
[01:01:48] <awight>	 it's: git merge origin/REL1_23
[01:01:54] <K4-713>	 okay
[01:02:03] <awight>	 and I'm sure there will be more excitement by then
[01:02:04] <K4-713>	 ...speaking of wtf, did you see the dash for today?
[01:02:08] <awight>	 nah
[01:02:31] <awight>	 when do new goals get announced btw
[01:02:41] <K4-713>	 I have zero insight into that.
[01:02:55] <awight>	 soaking in it...
[01:03:02] <awight>	 <-> it in
[01:03:03] <K4-713>	 I could probably go stand politely at somebody's desk until they talk to me, though.
[01:03:06] <awight>	 hah
[01:03:13] <K4-713>	 Smiling. Creepily.
[01:03:17] <awight>	 no hat in hand
[01:03:20] <K4-713>	 Nope.
[01:03:25] <K4-713>	 Coffee, though.
[01:03:53] <K4-713>	 Is Red Bull more creepy than coffee?
[01:04:03] <K4-713>	 ...probably.
[01:04:10] <K4-713>	 I'll do Red Bull.
[01:06:23] <awight_>	 I donno that it matters, it's one small job satisfaction thing :p
[01:06:36] <awight>	 in a sea of troubles
[01:07:26] * awight sings the boat song
[01:07:33] <K4-713>	 It matters to me. I need to know how high I need to jump when something goes off.
[01:08:05] <K4-713>	 Or, how interested I should be in coming down from the ceiling. Same reasons.
[01:08:55] <K4-713>	 If we get to go back to normality, it would be nice to hear about it.
[01:09:15] <awight>	 this is insane.  another vagrant hack:  $ git config --global url."ssh://<username>@gerrit.wikimedia.org:29418/".insteadOf "https://gerrit.wikimedia.org/r/p/"
[01:17:19] <ejegg>	 K4-713: I think I was using the wrong main table in my x-by-y query.  To get failed donation, I need to start with contribution_tracking, then left join the civi contrib and the payments fraud tables, right?
[01:17:27] <ejegg>	 *donations
[01:17:31] <K4-713>	 buh
[01:17:35] <K4-713>	 Give me a second to parse that.
[01:17:52] <ejegg>	 or just point me to some SQL for failed donations :)
[01:17:54] <K4-713>	 Okay, not really.
[01:18:06] <K4-713>	 What kind of failure are you looking for?
[01:18:17] <awight>	 I think u only need to be careful to left join on civicrm_contribution
[01:18:19] <ejegg>	 Not sure exactly...
[01:18:32] <K4-713>	 First off: there is a possible 3:1 ratio of donation attempts to contribution tracking IDs.
[01:18:43] <K4-713>	 Unless we're off by one there, and then it's either 4 or 2 to 1. :p
[01:18:48] <ejegg>	 heh
[01:18:52] <K4-713>	 Anyway. Not 1:1.
[01:19:35] <K4-713>	 Next thing: Failures that happen at the gateway often happen early enough to prevent our antifraud filters from firing.
[01:19:43] <K4-713>	 Because, if it's already failed, why burn the query?
[01:19:52] <ejegg>	 right, makes sense
[01:20:07] <awight>	 do those still appear in payments_initial?
[01:20:12] <K4-713>	 Yes.
[01:20:18] <K4-713>	 Everything appears in payments-initial.
[01:20:23] <K4-713>	 (I think)
[01:20:32] <ejegg>	 So definitely left join on both civi contrib and payments fraud.
[01:20:36] <K4-713>	 (We have never actually spot-checked for completeness)
[01:20:49] <ejegg>	 Just have to decide whether contribution_tracking or payments_initial is my main table
[01:21:05] <K4-713>	 I'd say payments-initial.
[01:21:13] <ejegg>	 ok, thanks!
[01:21:20] <K4-713>	 Because of the 3:1 with contribution_tracking.
[01:21:21] <awight>	 unless you also want failures, where they never attempted to pay :)
[01:21:25] <K4-713>	 And we don't want to collapse on donors.
[01:21:27] <K4-713>	 ...
[01:21:29] <K4-713>	 ...wait.
[01:21:39] <K4-713>	 That's a silly mental image.
[01:22:23] <K4-713>	 What I really meant was "We don't want to collapse discrete payment attempts into one, because they were all done by one person"
[01:22:36] <ejegg>	 got it :)
[01:23:03] <K4-713>	 (damn these high heels)
[01:23:33] <ejegg>	 hmm, so if somebody fails 2x with a ctid, then succeeds the 3rd time around, we still include those 2x in our 'failed' statistic?
[01:23:38] <K4-713>	 Yep!
[01:23:42] <ejegg>	 ok
[01:23:49] <K4-713>	 The gateways sure charge us for 'em, so we will want to see those.
[01:24:02] <ejegg>	 ahh
[01:24:40] <K4-713>	 Also, when we pull numbers from their end, they don't group at all.
[01:24:54] <K4-713>	 So, if we want a hope of matching up, we need to go by discrete attempts.
[01:25:59] <K4-713>	 Hopefully, we'll be able to eventually report on status codes sometime soon, too.
[01:29:42] <awight>	 K4-713: hey, does your change https://gerrit.wikimedia.org/r/#/c/180049/ finish https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1957 ?
[01:29:57] * awight emits a QR-encoded belch
[01:30:10] <K4-713>	 awight: We were trying to get Megan to comment on where we ended up.
[01:30:15] <awight>	 k
[01:30:33] <awight>	 Maybe I'll move that to In dev so I stop trying to grab it?
[01:30:41] <K4-713>	 I don't think we're done, though, because some of the fields are weirdly long.
[01:30:44] <K4-713>	 Sometimes.
[01:30:59] <K4-713>	 I think that's all that was going on, though...
[01:31:01] <K4-713>	 :/
[01:31:18] <awight>	 my inline-block fix might help with that.
[01:31:21] <awight>	 maybe
[01:31:24] <K4-713>	 orly
[01:31:38] <awight>	 https://gerrit.wikimedia.org/r/180317
[01:35:07] <K4-713>	 awight: Sort of!
[01:35:13] <K4-713>	 Can I show you the thing I'm seeing?
[01:35:42] <K4-713>	 There's like, a whole bunch of stuff that isn't quite lining up.
[01:35:46] <grrrit-wm>	 (PS2) Awight: Comment about archiving logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178989
[01:54:13] <grrrit-wm>	 (CR) Ejegg: [C: 2] Comment about archiving logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178989 (owner: Awight)
[01:54:15] <grrrit-wm>	 (Merged) jenkins-bot: Comment about archiving logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/178989 (owner: Awight)
[03:03:40] <Krinkle>	 Hey guys. Firefox is copying you as well now :)
[03:03:41] <Krinkle>	 http://i.imgur.com/3UvBNni.png
[03:09:13] <pizzzacat>	 holy crap
[03:09:18] <pizzzacat>	 HOLY CRAP
[03:09:39] <pizzzacat>	 I mean I'm not surprised that they're copying us. my reaction is over the size.
[03:10:15] <pizzzacat>	 the red button makes me itchy.
[13:48:54] <BrunoAssis>	 Hi folks! Won't we have fundraising banners this year? If not, why so?
[18:16:06] <K4-713>	 the-wub: Hey, did you just volunteer to help clean up translations in DonationInterface? :D
[18:16:56] <the-wub>	 K4-713: kinda :)
[18:17:12] * the-wub joins the chanting of "refactor! refactor!"
[18:17:22] <K4-713>	 Hah
[18:17:27] <K4-713>	 Did I tell you about this?
[18:17:32] <K4-713>	 https://www.mediawiki.org/wiki/Extension:DonationInterface/Refactor_2015
[18:17:47] <K4-713>	 We're listing all the messes we might want to clean up, given half a chance.
[18:17:57] <K4-713>	 i18n is in the Misc section.
[18:18:18] <K4-713>	 Please expand those points or add items to any of it as you see fit.
[18:18:30] <K4-713>	 ...particularly if they would help you do form-related things in DI.
[18:18:34] <the-wub>	 ooh excellent, I hadn't seen that page yet. will take a look
[18:18:55] <K4-713>	 Also... if you have any insights as to how the translation-only changes will impact donate wiki...
[18:19:09] <K4-713>	 Because you're probably the only one who still has that rattling around.
[18:19:56] <the-wub>	 yeaah... good point
[18:24:12] <K4-713>	 Geeze. That list.
[18:24:26] <the-wub>	 btw, I saw https://phabricator.wikimedia.org/T7873. That's kinda blocking me from doing much with DonationInterface at the moment :(
[18:24:41] <the-wub>	 oops, https://phabricator.wikimedia.org/T78739
[18:24:58] <K4-713>	 I was going to say: What? :)
[18:25:19] <K4-713>	 Ah, yes. Well...
[18:26:32] <K4-713>	 Arf. I should add something else to the refactor list, about... fake mode.
[18:26:58] <K4-713>	 I don't want any actual payments creds running around in vagrant.
[18:27:13] <K4-713>	 That means we're going to need to have 3rd party stand-ins for all the things.
[18:27:29] <K4-713>	 fooey.
[18:27:54] <the-wub>	 yeah that would be great. obviously I'd mostly (entirely?) be helping on frontend stuff
[18:32:01] <atgo-hom_>	 hey the-wub, is the cvv helper something you think of as a must-have for israel?
[18:33:24] <the-wub>	 atgo: not at all. but it sure would be nice-to-have for WP everywhere
[18:45:27] <awight>	 pizzzacat: http://www.mediawiki.org/wiki/API:Client_code
[18:45:43] <awight>	 ton of standalone libraries there, I still don't know if any of them help with continuation
[18:46:58] <awight>	 seems like, no.  I guess continuation of our apis is not standardized enuf
[18:47:04] <pizzzacat>	 yeah I was looking through that earlier, which is what led me to that fancy website
[18:47:31] <pizzzacat>	 it occurs to me that maybe the fact that I am having trouble fully getting to the meat of it,
[18:47:36] <pizzzacat>	 others might too
[18:47:43] <awight>	 yay, improve the docs!
[18:47:53] <pizzzacat>	 I would love to once I get it....
[18:54:44] <atgo>	 cool, thanks the-wub
[19:13:39] <grrrit-wm>	 (PS1) Ejegg: Add .gitreview [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/180551
[19:25:59] <awight>	 ccogdill: I was gonna take a look at your WP US refund, to see if it got into Civi through the nightly audit.  Anything I should know?
[19:26:09] <awight>	 ejegg: woohoo!
[19:26:17] <ccogdill>	 I just did it today awight so I don’t think it will be there yet
[19:26:23] <ccogdill>	 I can give you an order ID though?
[19:26:31] <ccogdill>	 When Pats did a test refund it did not reach Civi
[19:26:32] <awight>	 that would be great, thx
[19:26:46] <awight>	 ccogdill: when was PPena's refund?
[19:27:40] <awight>	 like, recently or months ago?
[19:27:57] <grrrit-wm>	 (CR) Awight: [C: 2] Add .gitreview [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/180551 (owner: Ejegg)
[19:28:01] <ccogdill>	 a couple weeks ago awight
[19:28:04] <ccogdill>	 let me find that one
[19:28:26] <awight>	 ccogdill: ah ok, the code to import these refunds was only deployed yesterday
[19:29:05] <ccogdill>	 ohhh
[19:29:10] <ccogdill>	 well that’s good news!
[19:29:15] <ccogdill>	 okay then I’ll find my order
[19:29:16] <ccogdill>	 Id
[19:30:54] <ccogdill>	 awight I’ll check for it tomorrow
[19:31:07] <ccogdill>	 I’m already tracking it on our DS docs so no need to have you check into it
[19:31:14] <awight>	 ccogdill: awesome, thx
[19:31:15] <ccogdill>	 I’ll let you know tomorrow if Civi got the memo!
[19:31:18] <awight>	 hehe
[19:31:22] <ccogdill>	 :)
[19:35:07] <grrrit-wm>	 (PS1) Ejegg: Add Stomp and Minfraud libraries [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/180561
[19:36:21] <grrrit-wm>	 (CR) Ejegg: "recheck" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/180551 (owner: Ejegg)
[19:37:02] <ejegg>	 oh right, we need zuul config for jenkins-bot to do anything
[19:38:12] <awight>	 yep
[19:38:58] <awight>	 awkward--that repo inherited the settings which prevent us from merging manually
[19:39:19] <ejegg>	 yeah, I asked for tha.  oops!
[19:40:55] <grrrit-wm>	 (CR) Awight: [C: 2] Add Stomp and Minfraud libraries [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/180561 (owner: Ejegg)
[19:45:51] <ejegg>	 looks like php-composer-validate is the only one that makes sense
[19:46:02] <awight>	 hrm
[19:46:56] <awight>	 maybe phpline
[19:46:57] <awight>	 lint
[19:47:13] <ejegg>	 ah, yeah
[19:47:38] <awight>	 would composer validate actually recurse into the modules?
[19:48:23] <ejegg>	 oops, composer-validate is for the containing project with the composer.json file
[19:48:56] <awight>	 sounds like something we should enable there, though!  I just ran against the crm project and it failed :)
[19:49:03] <ejegg>	 oh snap!
[19:49:27] <ejegg>	 ok, while I'm submitting zuul stuff...
[19:50:33] <grrrit-wm>	 (PS1) Awight: correct composer.json [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/180569
[19:51:02] <awight>	 ouch, I was worried about that: Name "wikimedia/SmashPig" does not match the best practice (e.g. lower-cased/with-dashes). We suggest using "wikimedia/smash-pig" instead. As such you will not be able to submit it to Packagist.
[19:51:17] <ejegg>	 ooh, wanna change it?
[19:51:27] <awight>	 I guess.  smashpig or smash-pig, there's the rub
[19:51:37] <awight>	 I think hyphen is more emphatic :)
[19:51:45] <awight>	 cro-magnon
[19:51:56] <ejegg>	 but there's no hyphen in the .org!
[19:52:00] <awight>	 baa
[19:52:07] * awight visits
[19:52:15] <awight>	 aww, parked?
[19:52:42] <awight>	 smash-pig is available
[19:53:12] <ejegg>	 no, pgehres is the one who has it parked!
[19:53:57] <awight>	 I was hoping...
[20:08:08] <awight>	 ejegg: well, the camlcase thing is just a warning, so I'll leave it alone for now, but yeah let's rename soon.
[20:08:16] <ejegg>	 ah, cool
[20:08:32] <ejegg>	 also warns we should call it donation-interface
[20:09:25] <grrrit-wm>	 (PS1) Awight: fix up composer.json [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/180577
[20:09:26] <awight>	 bah humbug
[20:09:36] <ejegg>	 Huh, trying to run phpcs locally and getting zero output, even with -vvv
[20:09:49] <awight>	 maybe "phpcs ."?
[20:10:04] <ejegg>	 yeah , doing phpcs -p -vvv .
[20:10:14] <ejegg>	 -p should be 'progress indicator'
[20:10:32] <ejegg>	 ehh, i'll give it a couple min
[20:10:40] <awight>	 ejegg: did u see the invocation in jjb/macro.yaml?
[20:10:47] <awight>	 it's quite elaborate
[20:12:52] <ejegg>	 ah, will try that
[20:19:45] <ejegg>	 d'oh!  it was hung up waiting for xdebug
[20:19:59] <awight>	 hah
[20:20:14] <ejegg>	 did an lsof to see if it was even opening the files
[20:20:34] <ejegg>	 and saw a connection to localhost:9000
[20:28:55] <ejegg>	 awight: where do you suppose --standard=/srv/deployment/integration/mediawiki-tools-codesniffer/MediaWiki is checked out from?
[20:29:04] <awight>	 oof
[20:30:03] <awight>	 https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/tools/codesniffer
[20:30:14] <ejegg>	 ah, of course!
[20:30:16] <ejegg>	 ty
[20:31:00] <awight>	 I'm looking for the code that checks out /srv/deployment/integration, no dice yet
[20:43:52] <ccogdill>	 hey atgo, are we still doing WP vs GC at 1pm?
[20:56:47] <atgo>	 ccogdill looks like it
[20:58:10] <atgo>	 AndyRussG pizzzacat ejegg|lunch skip standup for shrimp prawning?
[20:58:28] <pizzzacat>	 sure thing
[20:58:29] <AndyRussG>	 atgo: yeah I was just gonna ask, cool thanks :)
[20:58:34] <ejegg|lunch>	 aounds good
[20:58:41] <AndyRussG>	 prawn prawn shrimp shrimp
[20:58:43] <AndyRussG>	 happy happy fun fun
[21:33:05] <atgo>	 hey awight i know i've asked you this like 500 times, but are we OK on audit for WP Streamline now as well?
[21:34:16] <awight>	 atgo: Well, it's never really been tested but afaik yes.
[21:34:22] <atgo>	 ok, cool
[21:34:29] <atgo>	 we will be testing soon :)
[21:35:24] <awight>	 atgo: what I see is that we did process a small amount of traffic through that gateway, but only two contributions came in through the audit script, and both were test transactions.
[21:35:38] <awight>	 So yeah--we need more volume to know for certain.
[21:35:43] <atgo>	 alright
[21:38:48] <atgo>	 hey ejegg are you still going to the SoS meetings?
[21:38:53] <ejegg>	 atgo yep!
[21:38:57] <atgo>	 cool :)
[21:39:05] <ejegg>	 Sorry, there hasn't been much to report back about
[21:39:14] <ejegg>	 specifically for fr-tech, i mean
[21:56:13] <grrrit-wm>	 (CR) Ejegg: [V: 2] Add .gitreview [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/180551 (owner: Ejegg)
[21:57:02] <grrrit-wm>	 (CR) Ejegg: [V: 2] Add Stomp and Minfraud libraries [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/180561 (owner: Ejegg)
[22:01:31] <awight>	 Jeff_Green: can u dump the slow query log for today?  More Civi woes.
[22:04:19] <Jeff_Green>	 sure
[22:04:34] <atgo>	 no worries ejegg
[22:04:57] <atgo>	 btw, ejegg, do you have everything you need for alipay scoping? running into any holes?
[22:04:57] <grrrit-wm>	 (CR) Ejegg: [C: 2] correct composer.json [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/180569 (owner: Awight)
[22:05:12] <ejegg>	 atgo: Oh, let me move that card...
[22:05:22] <ejegg>	 I created 4 cards under the supertask
[22:05:30] <ejegg>	 which I think should cover it
[22:06:10] <Jeff_Green>	 awight: it's in your homedir on barium
[22:10:42] <atgo>	 awesome!
[22:11:44] <ejegg>	 I'll take a look at that new info PPena provided about other ways of getting unionpay
[22:11:56] <atgo>	 ahh yeah... we had to remove it because of NDA.
[22:12:47] <atgo>	 ejegg: i just forwarded to you and fr-tech
[22:12:51] <ejegg>	 thanks!
[22:14:00] <atgo>	 oooh ejegg it looks like it might be through WP... my bad on the title there
[22:14:19] <ejegg>	 ok, cool
[22:14:21] <awight>	 ejegg: hey, I imagined you said somewhere that there was a payment method we were looking at, with a 35% success rate... did I imagine that?
[22:14:29] <K4-713>	 Just read the word "redirectly" in an email.
[22:15:00] <atgo>	 awight: that's what we're talking about
[22:15:11] <awight>	 oh
[22:15:21] <awight>	 I still missed that, no worries
[22:15:25] <ejegg>	 awight: take a look at sec 2.4 of 'Merchant Guide UPI.pdf' under GC/UPI
[22:16:09] <atgo>	 ejegg: i'm updating the card in mingle to include GC and WP
[22:16:22] <ejegg>	 nice
[22:17:03] <grrrit-wm>	 (PS1) AndyRussG: WIP Minor improvements in text fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/180650
[22:21:48] <AndyRussG>	 arg and blrrg and blrrg and grrr
[22:22:06] <K4-713>	 That good, huh?
[22:22:15] <AndyRussG>	 Well, could be worse...
[22:22:24] <K4-713>	 :)
[22:24:53] <atgo>	 ejegg: is there any preferred order of attack for Alipay
[22:24:54] <atgo>	 ?
[22:25:15] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Minor improvements in text fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/180650 (owner: AndyRussG)
[22:26:22] <ejegg>	 atgo: probably admin setup -> forms -> DI logic -> crm
[22:26:32] <AndyRussG>	 jenkins-bot: yeah, I know...
[22:26:33] <atgo>	 danke
[22:32:26] <ejegg>	 I hope the FSF has a really long-term lease.  If they leave 51 Franklin St, the revision avalanch would knock out github
[22:32:58] <awight>	 hah
[22:33:02] <awight>	 their license is so annoying
[22:33:28] <awight>	 at least, the "example" license attached to the end has caught me off-guard and caused confusion and anger.
[22:37:26] <atgo>	 hey awight is #1847 the one you were talking about that's blocked on Hashar's review?
[22:39:07] <awight>	 atgo: yep
[22:39:13] <awight>	 I should move it to "blocked"...
[22:39:34] <atgo>	 just did :P
[22:40:29] <atgo>	 awight:  are 2289 and 2265 not duplicates?
[22:40:34] <atgo>	 seem like symptoms of the same problem?
[22:47:43] <grrrit-wm>	 (PS1) Awight: Rewrite all "LIKE" queries on civicrm_prevnext_cache [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/180656
[22:48:26] <ejegg>	 awight: looks thrilling :)  Reviewing now
[22:48:28] <awight>	 atgo: no, they're different
[22:48:36] <awight>	 sadly!
[22:48:44] <awight>	 ejegg: thx
[22:48:46] <awight>	 it's horrible.
[22:49:31] <ejegg>	 ooh, gotta love that getCount where you pass in an operator
[22:49:39] <awight>	 bastards!
[22:50:02] <awight>	 This code is a great example of, don't make it complicated until you actually have complexity you need to support.
[22:51:48] <K4-713>	 awight: What code?
[22:51:56] <K4-713>	 Who's solving problems that don't exist? :)
[22:52:10] <ejegg>	 CiviCRM
[22:52:15] <K4-713>	 omg
[22:52:21] <K4-713>	 They have plenty of problems that do exist.
[22:54:05] <awight>	 hah!  K4-713 yeah I'm talking about this monstrosity, https://git.wikimedia.org/blob/wikimedia%2Ffundraising%2Fcrm%2Fcivicrm/HEAD/CRM%2FCore%2FBAO%2FPrevNextCache.php;jsessionid=1nku2l6o2dmd01sg59wmhy0l7s
[22:54:33] <K4-713>	 ...the whole thing?
[22:54:51] <K4-713>	 :p
[22:56:32] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Rewrite all "LIKE" queries on civicrm_prevnext_cache [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/180656 (owner: Awight)
[22:56:51] <awight>	 oh.  I should fix that
[23:00:15] <grrrit-wm>	 (PS2) AndyRussG: WIP Minor improvements in text fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/180650
[23:01:09] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Minor improvements in text fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/180650 (owner: AndyRussG)