[00:02:28] awight: gateway.css 272-273 I suggest width 100%, margin 10px 0 0 0 [00:04:31] rad, I'll try that in a sec [00:15:00] (PS3) Awight: Improve payments form layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180997 [00:18:17] (PS2) Awight: Get rid of unused colspan=2 cruft [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180902 [00:18:19] (PS4) Awight: Improve payments form layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180997 [00:22:38] (PS5) Awight: Improve payments form layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180997 [00:31:23] hey K4-713 [00:40:26] This seems to be the last issue making the vertical layout uneven, http://www.w3.org/TR/CSS2/box.html#collapsing-margins [00:40:49] margins of sibling elements collapse, but across td's they add [00:42:59] (PS6) Awight: Improve payments form layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180997 [00:43:01] (PS1) Awight: Even out vertical layout on small devices [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181008 [00:43:06] got it [00:54:03] (CR) Ejegg: [C: 2] Improve payments form layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180997 (owner: Awight) [00:54:38] ejegg: hehe there are prerequisites for days [00:54:47] mmm, colspan [00:55:11] ejegg: here's the score, https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1957 [00:55:25] thanks for suggesting I fix the vertical spacing, too! [00:55:41] completionist, ya know? [00:55:49] that was like a bowl of soup after the icebath i've been in all day [00:55:52] hehe [00:56:01] jeez [00:56:22] I'm liking the theory that we can actually slow down enuf to finish things, this year [00:56:47] yeah! [00:58:46] (CR) Ejegg: [C: 2] "yep, that helps" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180317 (owner: Awight) [00:59:15] ejegg: fwiw, I think ^^ isn't an issue in production only because the appeals usually push the payment form all the way to the right [00:59:34] oh, that would make sense [00:59:58] ah, deleted the demo too! [01:00:08] I was wondering about that [01:00:09] idk wtf that was [01:00:27] well, i could clean up a couple more selectors with that gone [01:00:38] note to self [01:00:58] hehe, _old directory [01:01:58] that's personal information forms for people 36 and over [01:02:05] baaahaha [01:02:35] nice, getting rid of some inline css too! [01:06:18] (CR) Ejegg: [C: 2] "Thanks for the cleanup!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180902 (owner: Awight) [01:08:12] (PS2) Awight: Prevent background color from bleeding to right margin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180317 [01:08:20] (PS3) Awight: Get rid of unused colspan=2 cruft [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180902 [01:08:25] (PS7) Awight: Improve payments form layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180997 [01:08:32] (PS2) Awight: Even out vertical layout on small devices [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181008 [01:08:54] ooh, weren't those in the gate+submit pipeline? [01:09:36] rebase issue... [01:09:50] oh [01:13:27] (CR) Awight: [C: -1] Use Composer-managed Stomp and Minfraud classes (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 (owner: Ejegg) [01:13:33] ejegg: tiny thing about require_once [01:13:45] but also, I don't know if we can really do the full composer autoloading... [01:13:49] ah, let's see [01:14:25] I guess the only issue is that it would be annoying to develop under? [01:14:45] oh, would it? [01:14:54] (i mean, less annoying than updating wgautoloadclasses by hand) [01:15:04] I just saw all that stuff being autoloaded by the composer generated stuff [01:15:14] I know, it's a huge temptation... [01:15:16] and figured we didn't need to list it twice [01:16:19] With SmashPig it was a bit simpler, cos the PSR-4 lookup doesn't require a rebuild of the classmap files... [01:16:30] but here, it seems like an awkward development workflow: [01:16:43] ah, right [01:16:48] well... ok I guess the only trick is to rebuild the classmap if you change any classes [01:16:53] that's reasonable [01:17:34] I have slight misgivings about the mediawiki "fast path" pass... [01:17:42] what is that? [01:17:54] we will instantiate an additional autoloader in the load chain... [01:18:06] even if nothing from this extension is being used (not much of a use case though) [01:19:08] hmm, not a lot of other examples. Seems Wikidata is the only other extension with a composer autoloader [01:19:29] yikes [01:19:35] rarefied atmosphere [01:19:56] flow has a vendor folder, but it's just 2 files [01:20:04] I guess we don't have to care about performance, cos we're only talking about payments.wmo [01:20:40] that manually merged, monster composer.json didn't sound that enticing... [01:20:56] nope [01:21:12] and just wouldn't make sense for this dual-use munition [01:21:45] we could make vendor a normal subdir if we had to [01:21:58] I think our setup in crm makes more sense then the one the ops were telling us about [01:22:25] the submodules' composer.json files are scanned recursively, so Composer does all the heavy lifting of generating a combined vendor dir [01:22:34] I handed hashar a phab task asking for zuul to check out submods, so I guess we'll see what he thinks of that [01:22:47] ja [01:23:32] oh, it looks like you already picked up on this, but another issue with Composer's classmap autoloading is that multiple classes per file totally destroy it [01:23:43] ooh, that's no fun [01:23:56] if you reference both contained classes, for some reason it will load the file twice, which causes a fatal err [01:24:03] ugh [01:24:17] I don't know why it would try that, cos the second class should already be in memory :( [01:24:38] just keeping track of what it's autoloaded itself, I guess [01:24:50] no time for class_exists [01:24:56] arrgh [01:25:05] you must be right [01:25:15] hey, what's happening here... https://gerrit.wikimedia.org/r/#/c/180317/ [01:25:17] dead in the water [01:25:45] cos of the rebase during gate+submit? [01:25:54] I don't even know what to tell Jenkins, now [01:26:00] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180317 (owner: Awight) [01:26:01] maybe that [01:26:38] ejegg: I think the multiple classes in a file thing kills classmap autoloading, for now... [01:27:07] on the bright side, did u see that they finally killed the master classmap file in core? [01:27:15] very heartening. [01:27:35] Oh really? Hadn't even discovered that issue. I need to do more digging [01:28:22] https://gerrit.wikimedia.org/r/#/c/180317/ [01:28:43] fnord. [01:28:47] will toggle score [01:28:50] oh sorry [01:28:54] wrong URL [01:29:05] https://gerrit.wikimedia.org/r/#/c/163304/ [01:29:06] that one [01:29:13] (CR) Ejegg: Prevent background color from bleeding to right margin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180317 (owner: Awight) [01:29:23] (CR) Ejegg: [C: 2] Prevent background color from bleeding to right margin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180317 (owner: Awight) [01:29:33] toggled anyway, just to see if it submits [01:29:36] it's dead, Jim [01:30:22] ooh, flurry of activity! [01:30:25] awight: ejegg: of course, recordimpression also does an extra round-trip on mobile for redirect... [01:30:38] aaack [01:30:47] ah sorry didn't mean 2 startle [01:30:48] We should be able to set those via config [01:30:51] (Merged) jenkins-bot: Prevent background color from bleeding to right margin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180317 (owner: Awight) [01:30:51] hehee [01:30:54] yeah [01:30:55] (Merged) jenkins-bot: Get rid of unused colspan=2 cruft [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180902 (owner: Awight) [01:30:57] (Merged) jenkins-bot: Improve payments form layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180997 (owner: Awight) [01:31:01] AndyRussG: did you every figure out where the list of redirect exemptions lives? [01:31:29] ejegg: I got a start: https://github.com/wikimedia/operations-puppet/blob/production/modules/mediawiki/files/apache/sites/redirects/redirects.dat [01:31:35] and https://github.com/wikimedia/operations-puppet/blob/production/modules/mediawiki/files/apache/sites/redirects.conf [01:31:45] ... have something to do with it, I think... [01:31:54] "The oyster knife of URL manipulation" [01:32:23] with that and the assembly language of http, we can do anything! [01:32:34] Heh, yeah I was about to say, heah [01:32:36] wikiartpedia.biz <-- sketchy!! [01:32:53] that's the kind of domain name that causes people to reinstall their browser [01:33:02] luvit [01:33:15] redirects to wp [01:34:00] what is PHP then? the stone-age proto-hammer of... hmm... [01:34:14] hah [01:34:21] this can't be right: RewriteCond %{HTTP_HOST} =wikimedia.org [01:34:22] RewriteRule ^/research$ https://wikimedia.qualtrics.com/SE/?SID=SV_6R04ammTX8uoJFP [R=301,L,NE] [01:34:33] oic, /research [01:34:38] Perl with a thin coating of phosphorus [01:34:46] heh [01:35:31] that qualtrics url is live! purge cookies!! [01:36:05] re: round-trips to meta on moble, I was thinking of asking on mobile what the preferred strategy might be. Option 1 (likely simpler) is, I think, like ejegg suggested, turn off the mobile redirect for BannerLoader (and so also for RecordImpression) [01:36:52] The second option I think would to somehow fix the call so that in mobile view it calls the mobile URL directly [01:37:47] Any preferences? or other options? in addition to ease and speed of fix, also wrt to cleanliness/best longer-term solution? [01:37:51] (CR) Awight: "Per IRC, i think the multiple classes per file thing is a blocker for Composer classmap autoloading. I can't find any documentation of th" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 (owner: Ejegg) [01:38:06] ejegg: awight: ^ [01:38:36] AndyRussG: let's only do #2 after all attempts at #1 fail [01:38:41] AndyRussG: oh, interesting. Yeah, turning off the redirect sounds best [01:38:44] there's gotta be an api exception [01:39:04] I guess, it's a DNS lookup either way [01:39:25] there might be some value in hitting the same cluster however, I know nothing about that [01:39:38] see you tomorrow! [10:52:36] (CR) Pcoombe: [C: 2] "Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/180864 (owner: Awight) [11:10:33] (CR) OliverKeyes: "QChris: FR code should be Properly Reviewed to maintain compliance with various payment processing standards. No idea if the tools constit" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/179976 (owner: Awight) [18:02:25] hey ccogdill! katie is here... where are you guys? the invite says 67 [18:02:33] oh! [18:02:42] Megan is wandering around trying to find a better room [18:02:43] let me see [18:03:02] thanks atgo [18:08:53] atgo: K4-713: should I go to the retro? [18:09:26] Hi BTW [18:09:27] andyrussG I’ll invite you! [18:09:43] ccogdill: OK thx! [18:09:50] just sent :) [18:09:59] up to you if you want to come or not, says Anne [18:39:42] (CR) Ejegg: [C: 2] "Vertical spacing looks good! TODO: one more patch to get CC images back centered in the buttons in the narrow view" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181008 (owner: Awight) [18:40:07] (Merged) jenkins-bot: Even out vertical layout on small devices [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181008 (owner: Awight) [19:31:34] hey ejegg! we're heading to the room now [19:32:39] ok, be back on in a minute [19:55:09] meganhernandez: any idea how long this worldpay test will take? [19:55:47] i set it up for 2 hours, but can take it down if there are issues. i think tech&caitlin wanted at least a few hundred donations to test it out [19:56:08] okay cool [20:27:49] relevant for A/B testing: http://xkcd.com/1462/ [20:30:14] (PS1) Ejegg: Re-center CC icons in narrow screen view [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181125 [20:30:21] Man it's not cool for my Eclipse json editor to use up 100% CPU just 'cause I'm editing the #$%~@ file [20:30:32] oof [20:30:57] type, "string": { [20:31:09] sleep 2m [20:31:17] maybe it's mining bitcoins in the background? [20:31:29] lol good point! [20:31:31] Once it pays for the devs' time, it'll be responsive again [20:32:18] Heh you may have discovered a new fundraising method for after page hits hit page-hit bottom [20:34:11] Anyone know a javascript bitcoin miner I can sneak into a banner? [20:35:10] wow, they exist! [20:37:11] Actually I bet that would have success as a Mediawiki gadget [20:37:23] Use your CPU power to mine bitcoins for the WMF! [20:38:35] Brrgggll I'm definitely gonna uninstall this Eclipse plugin [20:49:38] (PS1) AndyRussG: Test fixtures: move defaults to shared json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181128 [20:51:38] (PS2) AndyRussG: WIP Test fixtures: move defaults to shared json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181128 [20:55:40] re: standup, just sent an e-mail, hopefully back in time tho [20:55:57] It's not trivial for bitcoin mining to produce more than it costs in power [21:26:41] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/181147 [21:26:51] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/181147 (owner: Awight) [21:26:57] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/181147 (owner: Awight) [21:27:27] !log update crm from ae7b2381667dd65d68812c58f61e3ea66fa9fa6f to 80241fd2a43f03796b416d728661470f875a590a [21:27:34] Logged the message, Master [21:32:49] (PS2) Awight: Re-center CC icons in narrow screen view [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181125 (owner: Ejegg) [21:33:40] (CR) Awight: [C: 2] Re-center CC icons in narrow screen view [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181125 (owner: Ejegg) [21:37:00] (Merged) jenkins-bot: Re-center CC icons in narrow screen view [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181125 (owner: Ejegg) [21:37:18] the-wub_: hey, do you have DonationInterface set up locally? [21:38:04] awight: no. I tried vagrant, but it errored out on me when provisioning [21:38:39] aargh [21:38:48] yeah the vagrant DI/payments setup is not ready [21:38:56] hey awight if you're going to pull the trigger on the CSS, let fr-online know beforehand so we can all look at it in every browser/machine possible? [21:39:00] Good to hear that's something you wanted to try, though [21:39:51] the-wub_: IMO that's a pretty major thing for me to fix, so that it's simple for you and other devs not embedded in fr-tech to try our extension... [21:40:09] atgo-meeting: I wasn't planning to pull the trigger--when is a reasonable time to do it? [21:40:27] awight: yeah I saw your Phabricator task the other day. it would be really helpful. [21:40:30] Now works for me, but I read something about GC vs WP test etc [21:40:34] the-wub_: awesome [21:40:39] hmm.. maybe not when a big campaign is running. let me ping megan [21:40:51] i know K4-713 would ike to get it out of the way soon so you guys don't have to work around it [21:41:02] the-wub_: I had it working for a minute, but it was never merged, cos I took over the mediawiki-core site... [21:41:08] Yeah, ah... after the test. [21:41:23] when does that end? Just the 1-hour thing happening now? [21:41:41] iono. Ask cn admin. :) [21:41:45] oh, that's over actually, as of 12:53 [21:41:59] meganhernandez: :( [21:42:01] <_< [21:42:02] >_> [21:42:23] K4-713: ok shall I, then? [21:42:34] hang on... she didn't pull it down AFAIK [21:42:48] atgo-meeting: ok, I'm looking in meta:CN [21:42:54] megan says it's still up [21:43:02] is she mistaken? [21:43:04] Had one minutes ago. [21:43:12] 21:41:56 [21:43:25] she's going to take it down at 2pm [21:43:27] sound gouda? [21:43:32] it's up until 22:00 https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&method=listNoticeDetail¬ice=C14_enUS_dec_dsk_test_FR [21:43:53] the-wub_: cool [21:44:21] * awight wires the leyden jar into wolf corpse [21:44:47] Did someone say... CentralNotice? [21:48:16] hehe [21:48:24] just user stuff :) [21:48:59] AndyRussG: I'm gonna deploy a big CSS change to DonationInterface, so we were making sure to avoid interrupting an ongoing test... [21:50:16] awight: Ah OK... :) enjoy, lemme know if I can help w/ anything also of course [22:17:08] awight: the WP/GC test is down, FYI [22:17:35] are we concerned enough about this rollout that we should take down all campaigns? [22:17:48] nah :) [22:18:55] I'm ready whenever you are [22:18:57] cool. lmk when it's done.. perhaps we should ping a lot of FR and ask them to poke it? [22:19:10] PPena: can I contact AstroPay with questions, yet? [22:19:25] awight ABSOLUTELY [22:19:32] PPena: rad, thx [22:19:35] awight got the email? [22:19:47] PPena: also i just emailed you to try to set up a meeting with them week 1 of january [22:19:52] awight: does that still seem like a good idea? [22:19:57] PPena: I could use a refresh on the email [22:20:03] atgo-meeting: donno, I have some Qs for them [22:20:09] rad [22:20:09] in theory, yeah sure [22:20:29] not particularly easy or difficult so far [22:20:57] awight you can always, under any circunstance, contact any of our current or prospect vendors. Like… always :) [22:21:07] :) hehe ok I wasn't sure about that [22:21:12] ok will follow up over email awight atgo-meeting [22:21:16] danke! [22:21:35] awight they should be your bff's ;) [22:24:41] haaa [22:27:23] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181180 [22:27:25] (PS1) Awight: Globalcollect form and iframe content css changes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181181 [22:27:27] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181182 [22:27:29] (PS1) Awight: Satisfy structure tests [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181183 [22:27:31] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181184 [22:27:33] (PS1) Awight: Prevent background color from bleeding to right margin [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181185 [22:27:35] (PS1) Awight: Get rid of unused colspan=2 cruft [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181186 [22:27:37] (PS1) Awight: Improve payments form layout [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181187 [22:27:39] (PS1) Awight: Even out vertical layout on small devices [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181188 [22:27:41] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181189 [22:27:43] (PS1) Awight: Re-center CC icons in narrow screen view [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181190 [22:27:45] (CR) Awight: [C: 2] Re-center CC icons in narrow screen view [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181190 (owner: Awight) [22:27:47] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181189 (owner: Awight) [22:27:52] (CR) Awight: [C: 2] Even out vertical layout on small devices [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181188 (owner: Awight) [22:27:57] (CR) Awight: [C: 2] Improve payments form layout [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181187 (owner: Awight) [22:28:01] (CR) Awight: [C: 2] Get rid of unused colspan=2 cruft [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181186 (owner: Awight) [22:28:06] (CR) Awight: [C: 2] Prevent background color from bleeding to right margin [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181185 (owner: Awight) [22:28:11] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181184 (owner: Awight) [22:28:16] (CR) Awight: [C: 2] Satisfy structure tests [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181183 (owner: Awight) [22:28:21] (CR) Awight: [C: 2] Globalcollect form and iframe content css changes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181181 (owner: Awight) [22:28:26] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181182 (owner: Awight) [22:28:32] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181180 (owner: Awight) [22:29:02] ooh, lots of changes [22:29:07] yeeugh [22:30:07] Looks like Zuul is gonna die on us [22:33:25] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181192 [22:33:27] (PS1) Awight: update ContributionTracking submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181193 [22:33:36] (CR) Awight: [C: 2] update ContributionTracking submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181193 (owner: Awight) [22:33:41] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181192 (owner: Awight) [22:35:04] the-wub: K4-713: atgo-meeting: fyi I'm waiting for Zuul to merge, but it looks like a zombie. [22:35:13] o_O [22:35:33] light it on fire. [22:35:37] "idle", 31 jobs queued [22:35:42] I don't have the right propellant [22:36:20] TIL I saw how to slay Zuul [22:36:56] hehe yeah I feel like my behavior might have not been unrelated to its untimely demise [22:38:05] aaargh. nobody is on duty, it seems [22:38:09] oh well, Monday then [22:38:11] ? [22:40:17] ok well we're fucked cos these are all going to land in the deploy branch some time tomorrow morning. [22:40:28] yay! [22:40:35] ejegg: K4-713: heads-up, there is going to be all kinds of staleness in the DonationInterface deployment branch [22:40:52] Grand. [22:41:06] Maybe I'll just do a rando deploy at midnight. [22:41:08] aww, ok [22:41:10] fack [22:41:20] :D [22:41:24] yeah unless... I go change the repo permissions so we can manually submit [22:41:28] \o/ [22:41:50] * K4-713 growls slightly [22:42:03] let me... somehow draw a parallel to how we have all kinds of technical debt in various places, which burn intensely when it gets in the way [22:42:33] what's the interest rate (on the technical debt)? [22:42:49] seeriously. it's like 90% [22:42:53] no, more [22:42:58] Hmmm could be worse [22:43:07] cos anything you build on top of it is like twice as shitty as even the original code [22:43:13] compounded daily. [22:43:19] That's... important. [22:44:11] meanwhile, Krinkle is trying to take off on a sleigh or something and I've just tied it down to a giant rusting heap of crap [22:44:16] sorry. [22:44:51] The numbers on /zuul also need a legend an manual, they're not what you think they are [22:44:57] hah! [22:45:04] engage decoder rings [22:45:19] PPena: can u pass me that AP email, btw? [22:45:43] yeah sorry [22:45:46] gimme a sec [22:45:49] no worries [22:45:57] After I fix this incident I'm writing a mail to engineering with easy steps of what to do. They'll be ugly steps, clearly exposing that CI is broken. These are just the steps we've figured out given the system as it is. [22:46:06] ok awesome, thx [22:46:14] actually ccing you on my email to them, so you can follow up with Q's awight [22:46:15] I think that might light fires in some of the right places [22:46:21] PPena: great! [22:51:49] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181180 (owner: Awight) [22:51:52] (CR) jenkins-bot: [V: -1] Globalcollect form and iframe content css changes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181181 (owner: Awight) [22:51:55] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181182 (owner: Awight) [22:51:58] (CR) jenkins-bot: [V: -1] Satisfy structure tests [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181183 (owner: Awight) [22:52:00] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181184 (owner: Awight) [22:52:02] (CR) jenkins-bot: [V: -1] Prevent background color from bleeding to right margin [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181185 (owner: Awight) [22:52:04] (CR) jenkins-bot: [V: -1] Get rid of unused colspan=2 cruft [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181186 (owner: Awight) [22:52:06] (CR) jenkins-bot: [V: -1] Improve payments form layout [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181187 (owner: Awight) [22:52:08] (CR) jenkins-bot: [V: -1] Even out vertical layout on small devices [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181188 (owner: Awight) [22:52:10] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181189 (owner: Awight) [22:52:12] (CR) jenkins-bot: [V: -1] Re-center CC icons in narrow screen view [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181190 (owner: Awight) [22:52:30] fuck [22:52:55] Agh, all the -1s... [22:53:10] wth [22:53:56] aaah jesus, the jobs changed since those were committed. I have to submit in a different order [22:54:00] * awight darkens [22:54:23] (Abandoned) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181192 (owner: Awight) [22:54:25] (CR) jenkins-bot: [V: -1] update ContributionTracking submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181193 (owner: Awight) [22:55:21] (PS2) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181189 [22:55:23] (PS2) Awight: Even out vertical layout on small devices [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181188 [22:55:25] (PS2) Awight: Re-center CC icons in narrow screen view [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181190 [22:55:27] (PS2) Awight: Prevent background color from bleeding to right margin [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181185 [22:55:29] (PS2) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181184 [22:55:31] (PS2) Awight: Improve payments form layout [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181187 [22:55:33] (PS2) Awight: Get rid of unused colspan=2 cruft [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181186 [22:55:35] (PS2) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181182 [22:55:37] (PS2) Awight: Satisfy structure tests [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181183 [22:55:40] (PS2) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181180 [22:55:41] (PS2) Awight: Globalcollect form and iframe content css changes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181181 [22:56:01] (CR) Awight: "recheck" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181180 (owner: Awight) [22:56:16] (CR) jenkins-bot: [V: -1] Prevent background color from bleeding to right margin [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181185 (owner: Awight) [22:56:23] (CR) jenkins-bot: [V: -1] Improve payments form layout [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181187 (owner: Awight) [22:56:25] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181184 (owner: Awight) [22:56:27] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181189 (owner: Awight) [22:56:30] (CR) jenkins-bot: [V: -1] Get rid of unused colspan=2 cruft [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181186 (owner: Awight) [22:56:32] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181182 (owner: Awight) [22:56:43] (CR) jenkins-bot: [V: -1] Even out vertical layout on small devices [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181188 (owner: Awight) [22:56:45] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181180 (owner: Awight) [22:56:47] (CR) jenkins-bot: [V: -1] Globalcollect form and iframe content css changes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181181 (owner: Awight) [22:56:50] (CR) jenkins-bot: [V: -1] Satisfy structure tests [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181183 (owner: Awight) [22:57:07] oof [22:57:28] * awight updates his resume [22:57:44] oh dear [22:59:31] (CR) jenkins-bot: [V: -1] Re-center CC icons in narrow screen view [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181190 (owner: Awight) [23:00:21] the-wub: ? [23:00:42] the-wub: u mean, ^ ? [23:01:01] AndyRussG: just general sympathy at awight's troubles [23:01:02] the-wub: BTW I'm just now studying the issue w/ the IE fix [23:01:56] Ah right... well, I think he's just joining the dark side, but it must be temporary [23:02:19] Joining? [23:02:31] AndyRussG: yeah, that IE thing is super weird. I couldn't find any other reports of issues with print media rules [23:02:57] (PS3) Awight: Satisfy structure tests [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181183 [23:03:04] K4-713: can you give me rare deployment review of ^^ [23:03:15] @_@ [23:03:21] AndyRussG: do you need me to schedule a time for everyone to talk over the new cookie implementation [23:03:23] I had to... change something [23:03:23] ? [23:03:43] atgo-meeting: sure! that's a great idea [23:03:56] the-wub: where I'm at so far: the fix worked on my local machine because the centralNotice div is contained in a siteNotice div, which is hidden by other CSS in the print version [23:04:02] awight: DonationInterface.php? [23:04:09] um [23:04:10] something [23:04:13] (PS3) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181189 [23:04:15] (PS3) Awight: Even out vertical layout on small devices [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181188 [23:04:17] (PS3) Awight: Re-center CC icons in narrow screen view [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181190 [23:04:19] (PS3) Awight: Prevent background color from bleeding to right margin [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181185 [23:04:21] (PS3) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181184 [23:04:21] However somehow in production it doesn't go there [23:04:23] (PS3) Awight: Improve payments form layout [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181187 [23:04:25] (PS3) Awight: Get rid of unused colspan=2 cruft [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181186 [23:04:27] (PS3) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181182 [23:04:29] (PS3) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181180 [23:04:31] (PS3) Awight: Globalcollect form and iframe content css changes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181181 [23:04:33] K4-713: yeah, I took out references to the testing RL modules [23:05:19] (CR) Katie Horn: [C: 2] Satisfy structure tests [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181183 (owner: Awight) [23:05:44] thx! [23:05:47] yep! [23:05:53] the-wub: ..and a real fix would be even outside the scope of CN, but rather a fix in ResourceLoder in core [23:06:20] PPena: just to confirm, we're considering "AstroPay Direct" for integration? [23:06:21] AndyRussG: aha! yes, fundraising banners move CentralNotice right to the top of the . so maybe we won't see the issue on normal banners in production? [23:06:44]