ejegg: tell me more about pay4 tunnel not working... [00:27:43] (PS1) Awight: missing semicolon [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181218 [00:27:54] lemme see [00:28:28] Oh, it was port numbers [00:29:12] You just need to tunnel local 443 to remote [00:29:21] which ssh complains about when yr not root [00:29:43] oooh. right cos the wiki emits absolute URLs [00:29:51] yep, that was it [00:30:10] if you can reproduce enless spinning still... mind trying that patch above? [00:30:18] so I was just too lazy to copy my ssh config over to root an tunnel from there [00:30:39] that is actually an annoying hurdle [00:30:39] oh, will do [00:30:49] Maybe we can change the LocalSettings for staging! [00:31:31] geez, i really doubt that semicolon could be doing it [00:31:38] hah [00:31:41] me too [00:31:48] one sec [00:31:50] sorry to waste yr time [00:32:38] Do you get console errors? [00:33:13] no, but when I put a breakpoint on the ajax success [00:33:34] it says mw.generatePaymentForm is undefined if I add a watch for it [00:33:43] and I can't step into it [00:33:58] would certainly expect a console error [00:34:53] h [00:34:54] mm [00:35:03] seems to not be loaded at all? [00:36:09] yeah, not loading gc.interface.js for some reason [00:37:03] ejegg: hehe yeah we just got that too [00:37:19] did you figure out why? [00:37:35] not yet [00:37:45] ooooh mg [00:37:46] yep [00:37:57] dying to know! [00:38:02] it's when I erased gateway_forms/rapidhtml/RapidHtmlResources.php line 175 [00:38:06] there's an "else" there [00:38:17] oooh [00:38:23] I did not see that at all! [00:40:22] (PS1) Awight: fix bad conflict resolution in https://gerrit.wikimedia.org/r/#/c/181183/ [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181220 [00:41:46] oooh, deploy-branch-only issue. nasty [00:41:51] yyyeah [00:42:38] not as nasty as how I had to change the order of commits :) [00:42:57] cos there were master merges which happened before the "structure" tests became mandatory! [00:43:13] blecch, what fun [00:45:20] totally works locally now [00:45:26] good news [00:45:37] ARGH! I've been bifurcated. [00:45:39] there's are other small styling things though [00:45:50] not as serious as extra digits [00:45:55] (CR) Ejegg: [C: 2] "Fixes things for me!" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/181220 (owner: Awight) [00:46:00] but e.g. the ifon is still boned [00:46:31] What do the phones look like in prod right now? [00:46:36] donno [00:46:38] don't have [00:46:59] I'd bet if you go there from a banner, it's... thefreakingsame as the changes. [00:47:23] I'm 70% expecting that, but I did a lot of destruction in there [00:47:31] it might be worse with my patches [00:47:44] atgo: Can you use your fancyphone to grab a screenshot of what's in prod now? [00:48:20] yes [00:48:27] what? [00:49:05] globalcollect payments form, as seen from clicking a banner [00:54:13] K4-713: ejegg: ok, deploying in that case [00:55:04] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181221 [00:55:14] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181221 (owner: Awight) [00:55:24] awight: Oh, hang on. [00:55:31] (CR) Awight: [V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181221 (owner: Awight) [00:55:38] K4-713: ok [00:55:44] atgo: Did we get the screenshot of a payments form as-is right now? [00:55:50] From your phone, from a banner? [00:55:51] just sent to fr-tech [00:55:53] K4-713: yep it's broken in a similar way [00:56:03] * K4-713 turns back to green [00:56:06] not quite the same... mine is bigger and badder :p [00:56:31] K4-713: ok is that gangrene or go? [00:56:58] Why not both. [00:56:59] ccogdill: heads-up, we're giving this one more shot [00:57:00] awight: I'm tailing all the things that tell the tales. [00:57:03] k [00:57:08] okay [00:57:41] !log payments updated from 3dde7be76284aa37b74038dfb4473671999dfcff to ce7fb9af37c4bba2a84668387b61729df4f9723c [00:57:44] Logged the message, Master [00:57:54] okay, here we go. [00:58:05] * atgo crosses fingers [00:58:06] thanks for translating :) [00:58:37] looks really good on a droid [00:58:45] I should set a clock for 10 minutes or something. [01:00:01] nice even vertical spacing on the fields, gc loading the iframe [01:03:22] everything looks good to me! [01:03:38] I've still got six minutes on the clock. [01:03:40] the only thing is that my dropdowns loook tiny/wonky [01:03:44] ...clock? [01:03:50] I'm... very sorry about your dropdowns. [01:04:07] It was like that when I got here. [01:05:50] atgo: Yeah, sometimes I want to set a clock for monitoring purposes. [01:05:57] is tiny-font a thing for errybody? [01:06:07] Like, when there's a cache involved, or, we don't see anything bad until people get to the end of the pipe. [01:07:11] atgo: I don't have... tiny... font? [01:07:14] * K4-713 frowns [01:07:21] Then again, my dropdowns are also substantial. [01:07:22] it's not impossibel, but it's tiny [01:07:28] everything is shrunken for me :P [01:07:33] maybe that's expected [01:07:41] &voodoo=true [01:07:46] Take that off. :) [01:08:17] we have anti-consensus for IRC channel [01:08:28] er [01:08:40] Everybody voted evenly for all the things? [01:11:28] That's cool. Sack race tiebreaker, I guess. [01:13:24] hey K4-713 [01:13:29] got second IRL? [01:13:41] I will give you several hundred. [01:17:31] ejegg: ok fyi there has been a decision to rollback for fun [01:17:46] so the deployment branch will be insanely out-of-sync for the weekend. beware! [01:18:45] !log payments rolled back to 3dde7be76284aa37b74038dfb4473671999dfcff [01:18:53] Logged the message, Master [01:23:31] ok, thanks for the info [01:23:52] i gotta take off. Have a good weekend, y'all [06:02:25] (PS1) Awight: Link to the regular wiki editor for banner content [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181234 [06:09:37] (PS1) Awight: Instrumentation to report when alterImpressionData is not found [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181236 [06:16:21] (PS1) Awight: WIP for discussion [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181237 [06:45:39] (PS1) Awight: WIP clean up database switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181238 [06:46:18] (CR) jenkins-bot: [V: -1] WIP clean up database switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181238 (owner: Awight) [06:48:29] (PS2) Awight: WIP clean up database switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181238 [07:29:35] (PS1) Awight: Provide BannerShowHideCountDate as a mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181239 [07:29:37] (PS1) Awight: Impression data can be manipulated outside of the alterImpressionData hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181240 [10:49:27] (PS3) Awight: WIP clean up database switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181238 [10:49:29] (PS1) Awight: WIP Preload JS comes with no baggage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 [10:50:11] (CR) jenkins-bot: [V: -1] WIP Preload JS comes with no baggage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 (owner: Awight) [10:57:20] (PS2) Awight: Preload JS comes with no baggage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 [10:57:55] (CR) jenkins-bot: [V: -1] Preload JS comes with no baggage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 (owner: Awight) [11:01:14] (PS3) Awight: Preload JS comes with no baggage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 [13:44:05] (PS1) Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/181251