[00:00:43] ewulczyn: OK. The fix was deployed at 19:53. I'd say it's a mini-emergency, we're really annoying a lot of people, and we need the diagnosis before writing an accurate fix... [00:01:03] awight: Do you have a second to talk about banner mixins? [00:01:10] Your last email confuses me. [00:02:21] K4-713: sure, phone? [00:02:26] uhh [00:02:29] hehehe [00:02:35] Scaring me. :p [00:02:45] i'm going to go do family things... will be listening for IRC dings if you need me :) [00:02:46] I wore this suit for nothing??? [00:03:16] K4-713: yes, now is good [00:03:25] any medium [00:05:06] I mean, here is good if that works for you. [00:05:10] yep [00:05:34] So, the solution you have in 2310... [00:05:56] Can that be interpreted as progress of an iterative nature? [00:06:01] I think so. [00:06:11] But no idea if it's going to fix the issue [00:06:15] Right. [00:06:34] Well, it seems to me that it won't hurt, but it will probably let us know more about where we want to go. [00:06:58] The whole preload thing can also run on-wiki js? [00:07:01] I think so, too [00:07:03] no [00:07:10] Just mixins. [00:07:12] no onwiki anything [00:07:13] yep [00:07:24] Yeah, okay. That seems to me like a massive improvement. [00:07:38] The email was mostly to ask whether my design is any good [00:07:42] it's pretty loose [00:08:25] if AndyRussG disagrees with my unschooledness, then I should go back and rewrite this homework :p [00:11:30] Seems important to not cast any more leaden badness, cos new banners will rely on that bad so fast... [00:11:55] On the bright side, being in src control will allow us to refactor if it becomes necessary. [00:12:17] It won't be like, an infinite sea of randomness that relies on some global internal [00:12:27] * awight looks stern [00:14:55] every time you talk about mixins i think about cold stone [00:15:07] mmmm [00:15:08] gross [00:15:22] what's gross about ice cream?! [00:15:26] I need to rename this to something more delicious [00:15:43] "banner cannoli" [00:17:04] COLDSTONE [00:17:21] Cake Batter Ice Cream > most things ever [00:18:52] awight: But, okay. I was confused as to what you were not happy about, seeing as how it was all pointing to your own stuff. [00:19:15] And, it seemed like a step up from... what's more chaotic than a wild west knife fight? [00:19:20] That's what we have now. [00:19:23] ...whatever it is. [00:19:25] hehe [00:19:30] um now we have nothing [00:19:34] and underwater wild west knife fight [00:19:44] Soon it will be upgraded to "Old-Timey Fisticuffs" [00:19:45] nothing uses (preload or any other) mixins [00:20:04] I'm actually going "great plains canolli" for this release [00:20:07] Oh no, I mean all the on-wiki js. [00:20:15] Compared to having mixins at all. [00:20:16] ah yes [00:21:00] onwiki js = "ferret loose in the club" [00:21:28] At least one. [00:21:40] Or possibly snakes on a plane. [00:21:48] I'm so sick of... [00:22:24] ~ sick of these ~ snakes on a ~ plane [00:22:30] learner's dictionary style [00:22:54] these ~ onwiki javascript snippets in our ~ notices? [00:23:06] baaaha [00:23:16] ccogdill should have a macro for this [00:23:26] seriously [00:23:30] Did you get a ~-ton of ~ banners all ~ month? [00:23:36] BAHA [00:23:44] sorry, macro for what, awight? [00:23:49] javascript errors? [00:24:08] ccogdill: sorry-context. Just having fun with a little technical upgrade thing [00:24:11] Inexcusable cussing, Sam Jackson style. [00:24:20] We think you have the hardest job. [00:24:20] ...replaced with '~'. [00:24:25] should have guessed ;) [00:24:33] Would you like some more people cussing at you? [00:24:45] I get enough on a daily basis through Zendesk hah [00:24:54] I checked out of IRC for awhile - did the GC changes stick this time? [00:25:07] ccogdill: I'm thinking, we could do a search and replace so people get back whatever kind of language they dish out. [00:25:18] ccogdill: um yes AFAIK the style changes are sticking. [00:25:20] hehe should I make a card? [00:25:23] :) [00:25:26] wee let me try! [00:26:13] awesome awight, looks great! [00:26:33] I'm just the messenger! [00:26:44] K4-713: do we... have revision history for payments LocalSettings? [00:27:03] I just discovered that..... hundreds of lines of WorldPay cruft are up in there [00:27:51] Cruft? [00:28:09] Did we de-louse that thing in such a way that it's not necessary? [00:28:18] our bifurcating Store IDs... [00:28:24] yes. [00:28:29] * awight signs the cross [00:30:31] Honestly, this document makes no sense at all [00:31:37] You could be talking about anything I ever touched. [00:32:51] It's an email thread from WP [00:34:19] Oh. [00:34:23] Yeah, okay. [00:34:33] Oh, look at the time! [00:34:40] I was only doing a half day today. :p [00:47:58] (PS5) Ssmith: Backend for x-by-y widget with 'group by' [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179340 (owner: Ejegg) [00:48:00] (PS3) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 [00:48:02] (PS5) Ssmith: Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 [00:48:04] (PS1) Ssmith: connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 [00:48:06] (CR) jenkins-bot: [V: -1] Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [00:48:08] (CR) jenkins-bot: [V: -1] connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 (owner: Ssmith) [00:48:24] (CR) jenkins-bot: [V: -1] Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [01:50:12] (CR) Awight: [C: -1] "Tiny issue--we need "white-space: nowrap" or something, cos the Hebrew translation of the CVC label pushes the info icon down, and it's hi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181422 (owner: Ejegg) [16:51:17] (CR) Ejegg: "Yep, that translation's just too long. Without nowrap, one of the words gets cut off." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181422 (owner: Ejegg) [17:01:24] (PS4) Ejegg: Tooltip explanation of CVV field for WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181422 [17:02:50] (CR) Ejegg: "The old one translated literally to '3 digits on the back of the card'. This PS updates it to 'Security code'." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181422 (owner: Ejegg) [17:12:59] * AndyRussG waves [17:13:06] Hi AndyRussG [17:13:21] ejegg: :) hey, how's it going? [17:13:46] pretty good. How about with you? [17:14:18] not bad! Now back in Mexico City, at my parents-in-laws' apartment [17:14:50] Oh cool! Good place to spend Xmas [17:15:33] Heh, yeah... In fact tomorrow morning we're all going to Taxco, which is where my parents in law were born, to spend Xmas with family there [17:16:06] big group of relatives, huh? [17:16:12] they do have wifi tho :) the "important" thing there is the midnight supper tomorrow [17:16:18] yeah! huge [17:17:16] huh, i've heard of singing at church on midnight Christmas eve, but not midnight supper [17:17:26] BTW thanks for +2'ing the CentralNotice hide impressions log patch, sorry I didn't see that that was more important than the IE9 stuff [17:17:48] oh sure [17:18:39] (PS5) Ejegg: Tooltip explanation of CVV field for WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181422 [17:19:21] hmm yeah I'm pretty sure it's a standard tradition around here [17:19:55] are u spending the holidays at home with family? [17:20:56] my folks live right nearby in Cambridge, so yeah. My sisters are both coming to town [17:22:07] cool! [17:23:23] (CR) Ejegg: [C: 2] (FR #2293) Force LTR on credit-card fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181522 (owner: Awight) [17:23:39] (Merged) jenkins-bot: (FR #2293) Force LTR on credit-card fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181522 (owner: Awight) [17:48:34] oh heyyy [17:48:47] yo [17:49:12] yo yo [17:49:21] whut up? [17:49:29] pregunta: are we in control of the dropdown for the iDEAL banks? [17:49:30] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=rtbt-ideal&recurring=&payment_method=rtbt.rtbt_ideal&utm_source=fr-redir.default~default~default~default~control.rtbt.rtbt_ideal&utm_medium=spontaneous&utm_campaign=spontaneous&utm_key=&referrer=&language=en&country=NL&returnto=Thank_You%2Fen&amountGiven=¤cy_code=EUR&frequency=onetime&amount=3&uselang=en [17:49:34] i think... not [17:49:37] since it's iframe [17:49:48] but want to confirm? [17:49:59] atgo: Nothing is in an iframe except for credit cards. [17:50:04] oh ok [17:50:27] We have total control of this one. What's wrong with it? [17:50:50] PPena: ^ [17:50:53] nothing is wrong with it [17:50:55] exactly [17:51:01] * K4-713 squints [17:51:19] so... basically sometimes one of the banks goes into maintenance, and in that case the-wub disables all of iDEAL if the window is > 5 hours (i think?) [17:51:22] i'm not entirely familiar [17:51:26] ugh [17:51:30] so PPena is asking about if it's possible to disable the one [17:51:35] uuuuuuuugh. [17:51:37] but that would be tech and not peter, right? [17:51:39] atgo K4-713 exactly :) [17:51:48] and presumably pretty involved? [17:51:54] that list is checked in [17:51:56] So, we can add/remove banks all the time. But it's... yeah. Involved. [17:52:08] Even if we took it out to local settings or something, that's a deploy. [17:52:19] K4-713 atgo Peter is the one who received the maintenance notices and sets up the maintenance time on the payment form [17:52:35] yeah PPena it's not realistic for us to disable one bank at a time for maintenance [17:52:38] tech would only need to make the feature availble (being able to disable 1 bank versus the entire method) [17:52:49] Right. And that's a lot. [17:52:50] sounds like that's not feasible [17:53:02] I see [17:53:07] we cant just hide one bank [17:53:11] We'd basically have to build the admin panel that awight tried to sneak in to the DI refactor conversation. [17:53:12] or something like that [17:53:17] we can, but it's a giant pain [17:53:28] and not worthwhile for maintenance windows [17:53:38] atgo K4-713 no, no want no pain… la la la [17:53:39] if a bank were to die entirely, then yes [17:53:43] :P [17:53:52] atgo K4-713 if we can have something that Peter can use and disable 1 bank at the time, great [17:53:56] we don't [17:53:58] if not… then we may need to live with that [17:54:02] Sadly, that's... hard. [17:54:06] yeah, i think that's how it's going to have to be [17:54:07] we could do something super hacky like take a querystring param to disable certain things [17:54:14] That's still hard. [17:54:19] atgo K4-713 thanks for letting me know [17:54:29] atgo K4-713 what abt the second question? [17:54:35] ? [17:54:40] second question... knab and friesland are reloading the page instead of going to the bank [17:54:49] K4-713: i just tried it and it's happening to me, too [17:54:54] That sounds like something is measurably wrong. [17:55:04] Should probably make a card. [17:55:08] yeah [17:55:13] that's probably on our side, right? [17:55:24] or should PPena go talk to GC about it? [17:55:35] It's almost certainly us. [17:55:42] cool. making a card [17:55:50] atgo K4-713 thanks ladies [17:55:55] If I had to guess, I'd think that those banks require fields that none of the other ones do, and might not be on the form. [17:56:02] atgo K4-713 they are not big banks, so not a rush [17:56:56] Are we about to have a meeting about all these things? [18:14:24] (PS1) Ssmith: add new libs [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/181602 [18:22:36] (PS2) Ssmith: connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 [18:22:38] (CR) jenkins-bot: [V: -1] connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 (owner: Ssmith) [18:34:55] (PS6) Ssmith: Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 [18:34:57] (CR) jenkins-bot: [V: -1] Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [18:36:42] (PS3) Ssmith: connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 [18:36:46] (CR) jenkins-bot: [V: -1] connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 (owner: Ssmith) [19:09:20] (PS2) Ejegg: Add select2 lib [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/181602 (owner: Ssmith) [19:13:37] (CR) Ejegg: [C: 2] Prevent double clicks on gc cc forms (take 2) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180313 (owner: Awight) [19:14:37] (Merged) jenkins-bot: Prevent double clicks on gc cc forms (take 2) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180313 (owner: Awight) [19:21:28] (CR) Ejegg: [C: 2] Make the entire li around CC type buttons clickable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180330 (owner: Awight) [19:21:47] (CR) Ejegg: [C: 2] Disable clicking credit card type radio LI [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180340 (owner: Awight) [19:25:16] (Merged) jenkins-bot: Make the entire li around CC type buttons clickable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180330 (owner: Awight) [19:25:18] (Merged) jenkins-bot: Disable clicking credit card type radio LI [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180340 (owner: Awight) [19:35:01] ccogdill: Question, when you have a second. [19:35:21] sure k4-713, what’s up? [19:36:22] ccogdill: Can you tell the difference between chargebacks and refunds in the civi frontend? [19:36:24] And if so... how? [19:38:28] umm, I don’t believe so? :/ somehow I recall that Civi doesn’t process recognize chargebacks [19:39:26] damn [19:39:32] I swear we used to. [19:39:45] I’m checking that now [19:39:48] pulling a gc report [19:40:04] We absolutely 100% should be doing this all the time. [19:41:01] so while GC is thinking, I can answer what the “how” should be - “Chargeback” is a contribution type in Civi just like Refund or Cash is [19:41:42] okay [19:42:05] Also: Oh dear, it looks like something is going wrong. [19:42:11] With the TY mail send job. [19:42:14] This is new. [19:43:49] !log disabled Thank You email send job [19:43:49] i'll take a look at that too [19:43:52] Logged the message, Master [19:43:58] I've got the contribution id here. [19:44:33] Yep. There's... no data in there. [19:44:37] Except for a contact. [19:46:19] yikes k4-713 - is this endemic across all recent donations? [19:46:27] no idea. [19:46:29] and to return to the CB question, yeah, Civi doesn’t get them [19:46:32] see order ID 1341130858 [19:46:37] CB processed 12/10 by GC [19:46:41] Okay, civi should totally get them. [19:46:53] Is it in there as a refund, at leasy? [19:46:55] *least [19:47:08] And, is that GC? [19:47:34] no refund in civi [19:47:38] and yeah that’s a GC transation [19:47:49] That is a major issue. [19:48:06] there was a card for this once, I swear... [19:48:15] I think the same is true for PP [19:48:22] and of course WP, because WP. [19:49:14] ccogdill: Do you have any idea how the "stock" contributions make it in to civi? [19:49:20] Rosie [19:49:31] does an import I think? [19:49:37] Something got hosed. [19:49:49] It's breaking our ability to send thank you emails to anybody. [19:49:59] a stock import broke it? [19:50:02] Yep [19:50:10] does this have anything to do with what awight and I talked about yesterday? [19:50:12] Like, just a few minutes ago. [19:50:15] No idea. [19:50:17] oh [19:50:33] well fwiw Rosie did a big coinbase import of 3 weeks of BTC donations yesterday [19:50:55] Adam asked if they needed TYs because they were past the grace period, and we said yes. Then asked him to change the grace period to 60 days [19:50:58] Was there an import at about 11:38 today? [19:51:02] I can ask her [19:51:07] (PS1) Pcoombe: Don't apply new input styles to radio buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181622 [19:51:08] there's a log [19:51:19] on the 'import checks' page [19:52:07] shows nothing today [19:52:10] ejegg: Is that under "Import Contributions" or somewhere else? [19:53:35] k4-713 - Rosie hand enters them [19:53:39] orly [19:53:49] ohh [19:53:56] That was my first guess. [19:54:06] how could that break anything? [19:54:09] * K4-713 looks slightly relieved [19:54:13] also they don’t get civi TYs [19:54:19] she sends them herself [19:54:31] Right, but whatever tells the TY job to skip that record, was missing. [19:54:38] ohh... [19:54:49] well she says she saw an error when she entered the last stock donation [19:54:59] Yeah [19:55:00] ? [19:55:12] Is it corrected now? [19:55:29] not sure what the error is yet… [19:55:39] so are TYs looking broken for any other method? [19:56:01] does she usually set a 'no thank you reason' ? [19:56:04] TYs are off, because yes, we're stuck on this one bad contribution record. [19:56:40] she took a screenshot! [19:57:19] I’ll email you guys the screenshot [19:57:25] Cool. [19:57:35] and ejegg, no she doesn’t because she hand enters the TY date when she sends them [19:57:44] Hurm. [19:57:54] Does she usually enter a gateway transaction ID? [19:57:59] ccogdill: hmm indeed [19:58:27] Yeah, because... if there's an email address, we're definitely going to send that email automatically within a few minutes. [19:58:30] It's always been that way. [19:58:41] Unless there's a thing they do, to prevent that. [19:59:08] I think there must be [19:59:15] I'd like to think so too. :) [19:59:16] she would have noticed if that field populated [19:59:28] she says she’s never seen this error before today [19:59:31] anyway, email was sent [19:59:36] (from me to you) [20:00:24] Aw. That screenshot cuts off all the... useful stuff. [20:00:28] Uhm, okay. [20:00:43] I'm thinking the error prevented all the data from saving the way she wanted it to. [20:00:43] does point to an error in viewing rather than entry though [20:01:01] I was afraid of that [20:01:19] ccogdill: Can you have her look at the record for... ah, I'll send you the details. [20:02:40] k [20:03:06] some earlier stock donations seem to have been entered after the manual TY mail was already sent [20:03:29] That would solve the problem of the automatic thanker trying to pick them up [20:04:10] I'd think we'd just not send for "Stock". [20:04:16] If that's what MG wants. [20:04:52] At the very least, we should probably not do it if there isn't a gateway transaction ID. [20:05:08] that’s definitely what they want. they get a slightly different letter, I think [20:05:12] Or... anything else that TY requires, on the grounds that it's probably manual entry anyway. [20:05:38] yeah, not crashing on missing TXN ID would be good [20:05:47] ccogdill: Okay, we can do that long term. [20:06:11] But we're going to have to come up with a workaround in the next few minutes for this one. [20:06:26] ...which is strange, because I don't think I've ever seen this problem before. [20:06:36] ccogdill: for now, if you're manually entering a contribution, how about writing 'Will send by hand' in the no thank you reason ? [20:06:37] And I don't think Rosie's workflow is new. [20:07:13] (or really anything) [20:07:58] yeah she’s been doing this for over a year, I believe. [20:08:01] we can suggest that to her [20:08:13] I never manually enter things :) except processing refunds, which is different [20:09:55] ccogdill: I *definitely* never manually enter things. [20:09:59] :D [20:10:09] MG is special [20:10:26] aye [20:16:09] (PS1) Ejegg: Reset CC radios, disable 'continue' with CC buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181628 [20:18:58] ccogdill: Rosie's not on any kind of chat, is she? [20:19:40] If we leave this job off for much longer, it's going to start causing alarms to go off. [20:19:42] gchat? [20:19:51] that’s how she and I were talking [20:20:04] Hum. Maybe she's just not on my list. [20:20:19] she’s online [20:25:44] ejegg: That stack trace mean anything to you? [20:26:06] let me see... [20:27:10] not immediately, looking at Civi code [20:27:25] Yeah, me too. [20:27:26] It's a race [20:27:29] :) [20:27:49] I like how searching for anything produces hundreds of results. [20:28:14] which of the 47 Contribution.php files was this? [20:28:28] baha [20:28:57] so Rosie is confused on what to do next [20:29:00] I'm looking at something in the DAO.php... [20:29:05] Yeah, we don't know either. [20:29:08] But I have an idea. [20:29:19] How about we delete that contribution and try to re-enter. [20:29:25] that makes sense to me [20:29:25] ejegg: ^^ objections? [20:29:37] nope, no objections here [20:29:40] great. [20:29:46] k! message relayed [20:30:27] ha, I've got her in a window too. [20:30:39] She just wasn't showing up / in my buddy list before. [20:31:06] K4-713: the $searchValue = NULL look like the smoking gun to you too? [20:31:41] I didn't get quite that far, but... I'd go for that. [20:31:51] Okay, contribution deleted and re-entered and now it all seems okay. [20:31:52] she just did it [20:31:56] Re-enabling TY... [20:31:57] yay! [20:32:04] * K4-713 crosses fingers [20:32:37] *holds breath* [20:32:52] I don’t know how to do the nifty dot thing you guys do :( [20:33:29] ? [20:33:35] haha not important [20:33:42] just start your message with /me [20:33:45] Type "/me does thing" [20:33:48] ah! /me tries [20:33:50] wait [20:33:53] * ccogdill tries [20:33:55] new line. :) [20:33:57] woohoo! [20:33:58] hah thanks ejegg [20:34:07] :) [20:34:13] * K4-713 does the happy dance [20:34:20] TY job is back on. [20:34:25] And working. [20:34:27] That was fun. [20:34:28] weee! [20:34:35] so we can send to all the ones we missed? [20:34:37] !log Re-enabled Thank You send job [20:34:40] Logged the message, Master [20:34:51] ccogdill: Yep, it catches up automatically. [20:35:02] is there anything Rosie needs to do differently with these in the future? [20:35:07] or was this a fluke [20:35:11] and cool! [20:35:26] just needs a 'no ty reason' or a ty date as soon as it's entered [20:35:57] Well, this particular error weirdness is very mysterious. [20:36:09] okay well I’ll ask her to do that anyway [20:36:20] But, it does bring up a good point, of: Yes, we will aggressively thank everything. [20:36:25] EVERYTHING. [20:36:52] haha aggressive gratitude [20:38:34] huh, my local Civi has no 'stock' fields or options. Some bit of setup is not checked in! [20:40:14] so k4-713 - anything else to do regarding the chargeback issue for now? [20:40:33] Other than me be sad about it? No. [20:40:55] ejegg: Yeah, that's probably because those are intended to be manually configured in civi. [20:40:58] okay [20:41:00] So, people... do that. [20:48:04] K4-713: I submitted my time off requests via adp. Is it OK that I put in for tomorrow as well as new year's eve? [20:48:19] Yup! [20:48:24] Woohoo! [20:51:24] I am also out tomorrow. [20:51:43] i def have some last minute shopping to do [21:46:41] Could anyone with access to collab wiki maybe e-mail me Peter's cookie doc please? https://collab.wikimedia.org/wiki/Fundraising/cookies [21:47:14] I'd like to check it out before the meeting this afternoon, and it looks like my access to collab wiki is in the holiday slow lane [21:47:18] will do! [21:47:26] ejegg: thanks! [21:48:16] ejegg: btw do you have any thoughts on cookie/localstorage best practices? [21:48:31] or links? [21:48:33] thanks in advance [21:48:39] localstorage is tough, since it looks like mw already hogs a ton of that [21:49:30] for a cookie, it would be great if we could only send it on CN-specific requests [21:50:10] but I'm not sure which cookies the jquery cookie functions have access to [21:55:12] ejegg: right... yeah that's a key point... thanks 4 copying the docs BTW [21:57:16] what bits of mw use localstorage? [21:58:23] I'm not sure [21:58:38] but when I browse enwiki with firebug enabled [21:58:55] I get a lot of DOM storage limit warnings/errors [21:59:52] Hum! [22:00:44] I mean, my innocent feeling is that localstorage is intended to be used more or less like what we want to do for banner history [22:01:17] there's a lot of data they want to cache client side [22:05:24] Hum again... [23:11:24] AndyRussG, see PM, ping :) [23:42:53] (PS4) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 [23:43:11] (CR) jenkins-bot: [V: -1] Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [23:43:23] bah [23:43:47] hey ejegg, awight was telling me about this "Chart is not defined" thing [23:44:05] that's not passing linting because of requireJS? [23:44:18] https://integration.wikimedia.org/ci/job/wikimedia-fundraising-dash-jslint/334/console [23:44:40] even though I am including chartjs in the require [23:44:41] oh, let me take a look [23:44:49] cool thanks [23:45:47] you're requiring it as a variable called chartjs, not a variable called Chart [23:46:03] so the only way you get a variable called Chart is using the global scope [23:46:14] which the style guide nixes [23:46:23] oh, so it wants me to name it Chart? [23:46:40] to create a new scope? [23:46:45] or something? [23:47:06] yeah, just use the same name in the function() declaration way up on line 8 as you use to refer to it [23:47:10] ok [23:47:20] not a new scope, just using the scoped var instead of the global one [23:47:28] I thought chartjs contained a Chart variable that was being referenced [23:47:52] but in that case maybe I would've been using chartjs.Chart.whatever [23:48:01] yah, exactly [23:48:17] so wait [23:48:36] same fix as https://gerrit.wikimedia.org/r/#/c/180223/2/src/components/widgets/fraud-gauge/fraud-gauge.js,unified [23:48:48] just change it to Chart [23:48:48] oh I reread what you said [23:48:50] got it [23:48:53] ok thanks!! [23:48:57] yw [23:49:31] (PS5) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 [23:51:03] yay it worked finally [23:52:39] ok, now I have a couple comments to put on it :P [23:54:05] (CR) Ejegg: [C: -1] "couple little things" (2 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [23:59:29] (CR) Ejegg: [C: 2 V: 2] Add select2 lib [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/181602 (owner: Ssmith)