[17:06:11] hey the-wub :) [17:06:19] and K4-713 [17:06:25] welcome back! [17:06:26] yo [17:06:42] everybody is WFH today ha [17:06:52] hey atgo :) [17:07:02] just a heads up to both of you - i just unblocked this one: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2285 [17:07:07] which we should take care of before jan 1 [17:07:50] or shut down Lithuania, but iirc it should be pretty straightforward to fix & awight has a patch in there [17:12:33] * AndyRussG|away waves at atgo the-wub K4-713 [17:12:37] hii! [17:12:39] Hi also ejegg|away [17:12:51] (I'm sort of away only) [17:13:14] Mmm I'm WFPILH [17:13:24] = "work from parents-in-laws' home" [17:13:40] atgo: Er... [17:13:54] Oh, currency change. [17:14:29] (PS1) AndyRussG: Use mw.Uri in bannerController to allow ugly URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182074 [17:14:52] atgo: I'm not sure the patch in there is going to do much, actually. [17:14:59] hm ok [17:15:45] This is mostly going to be a the-wub thing. Though, we will have to make sure that we have a form that will handle euros in Lithuania... but that's it. [17:16:03] yeah ok [17:16:06] we should... coordinate [17:16:35] iirc, the national currencies thing only kicks in when we don't have a currency set already, which is already a heck of an edgecase. [17:16:46] You should be able to test on payments now, though. [17:16:54] Just change the currency in the URL. [17:17:09] If it works, we're ready now. [17:17:45] ...well, as far as actual code changes are concerned. The rest is on-wiki on donate and banners. [17:18:14] K4-713: https://donate.wikimedia.org/w/index.php?title=Special:FundraiserLandingPage&country=LT&uselang=en&utm_medium=spontaneous&utm_source=fr-redir&utm_campaign=spontaneous [17:18:18] show's LTL, not euro [17:18:27] That's donate wiki. :) [17:18:43] So, click through to payments and change the currency. [17:18:47] ok.. so i'm not sure how to short cut to euros [17:18:56] because this is what i get [17:18:57] In the URL. [17:19:03] ah [17:19:05] Once you get to payments. [17:19:30] and euro is EUR? [17:19:34] yep [17:20:09] error [17:20:19] ...more specific? [17:20:56] well... this first when i changed thec urrency and reloaded: https://www.evernote.com/shard/s59/sh/35703f40-6d84-46ac-a444-6b345e07410a/3beb45a13f85564dd3aae9351d0ea318 [17:21:05] then entered things and got the popup error [17:21:09] when clicking radio button [17:21:28] Uhh. [17:21:57] Which popup error. [17:23:05] well... now it's working [17:23:19] I was going to say: This is really strange. [17:23:30] When I got there myself, I got the euro symbol by the currency. [17:23:52] oooh [17:23:59] lower case eur breaks it [17:23:59] ok [17:24:09] haha, yes. [17:24:11] That would do it. [17:24:13] so we're cool, the-wub just has to update the banners and such? [17:24:18] Looks like. [17:25:34] ok great [17:36:02] sorry atgo & K4-713, was in a call with Megan. thanks for the Lithuania currency changes, I'll go update the banner and donatewiki code now [17:36:12] no problem :) [17:40:24] atgo: Thanks for looking at #2317...! I see you took it out of the current sprint. However, it's blocking more cross-browser tests (#2282), so is it OK if we put it back? It's ready for code revew, in any case [17:40:30] oh ok! sure [17:40:37] Thanks! :) [17:43:55] atgo: I think #2310 is done and ready to be moved too, if everyone agrees, if u like I can add a summary in a little bit [17:44:29] sure [17:45:05] K :) [17:46:36] hey K4-713, do you know if awight is going to be back on the MWF schedule in jan? [17:47:03] Not sure. I think he was talking about it, but I don't think we have a 100% decision there yet. [17:47:18] Oof. [17:47:21] ok [17:47:28] I am having extreme difficulty waking the hell up today. [17:47:51] * AndyRussG sends K4-713 coffee vibes [17:47:52] This concerns me, because my whole family was sick over the holiday, with slightly different things. [17:47:56] ha... i had that this morning. And then a moment of panic that we had cleaners coming 10 min after i woke up [17:48:02] so.. WIDE AWAKE NOW [17:48:04] I think I may be lining up for Flu #2. [17:48:07] ugh.. [17:48:42] okay atgo, Lithuania changes on my end are done. donate.wikimedia.org/?country=LT made a test donation and it worked fine [17:48:43] ...in which there are very high fevers and a lung-busting amount of coughing. So much so that my sister in law had to go to the ER. [17:48:53] Do Not Want. [17:49:12] :( [17:49:16] thanks the-wub! [17:49:18] It's at least more variety than awight (whole family sick with the same thing) [17:49:41] verified, i'll move the card [17:49:59] K4-713: hope you feel better soon [17:50:18] I'm ducking out for an hour and a half, back in time for the meeting......... [17:51:06] * K4-713 considers the possible benefits of mixing Red Bull and Emergen-C [17:51:24] K4-713: go back to bed [17:51:29] it's worth not getting sicker :/ [17:51:32] I'm already in there. [17:51:43] haha... i'm suggesting without the laptop :P [17:51:52] Laptop is warm. [17:52:00] ...that's... really sad. [17:52:02] :p [17:55:26] :P [17:57:49] hey all, I can't make the standup call. will send an email update [18:26:36] (CR) Ejegg: "Is there any chance people could start redirecting the 'ugly' urls to mobile sites? Are they used anywhere else to avoid the extra trip o" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182074 (owner: AndyRussG) [18:39:17] Here is your cat of the day, everyone: https://38.media.tumblr.com/99a9992825431f143d18fd674a1087be/tumblr_ng44qaLnlU1rw1wnno1_250.gif [18:42:09] K4-713: that was crazy. I barely understand what that means... *truncates the parameters*??? [18:42:38] time to send in the refund paperwork for Jenkins [18:42:42] Yeah... so, I put in 200 days, and only the last 20 days exist in the queue after running. [18:42:50] Something is eating a digit. [18:43:07] * K4-713 shrugs [18:43:11] * awight goes mad [18:43:11] I knew that going in, sort of. [18:43:22] I mean, I'd suspected. [18:43:24] that's quite the feature [18:43:50] Also, the gc garbage queue was totally misnamed in the queue truncator. [18:44:03] underscores turned in to dashes at some point. [18:44:11] * K4-713 shrugs again [18:44:41] * awight hankerchiefs away some tears [18:45:10] We're *almost* caught up with the technical debt :p [18:50:49] oh, is the BEFORETIME calculation wrong? [18:51:00] BEFORETIME=$((`date -u +%s000`-($DAYS_TO_KEEP*24*60*60*100))) [18:51:09] maybe should be *1000 instead? [18:51:36] this is in the config for the jenkins job [18:54:39] awight: When you say "Caught up with the technical debt", is it in the sense that it's gone all the way around the world and is now in the same general location? [18:55:34] ejegg: hum. [19:01:54] K4-713: I was thinking, more like the IMF notifying entire countries that they can't spend money on trains, art, or health care ever again [19:03:00] Ah! Yes, then we are on the same page. [19:03:09] (CR) Ssmith: [C: 2] Backend for x-by-y widget with 'group by' [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179340 (owner: Ejegg) [19:03:36] (Merged) jenkins-bot: Backend for x-by-y widget with 'group by' [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/179340 (owner: Ejegg) [19:04:36] interest on the debt is unfortunately many times our GDP [19:05:00] and it has to be paid in a special currency [19:07:29] (PS6) Ssmith: Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 [19:09:19] (CR) Ejegg: [C: 2] Add the x-by-y chart widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178994 (owner: Ssmith) [19:18:12] hey K4-713 - do you want to do hangoutcheckin today or move it to tomorrow/wednesday when we might be physically present? [19:19:09] atgo: Ah, tomorrow (or wednesday) would probably be better for both of us. [19:19:16] yeah sounds good :) [19:20:28] atgo: Do we have a solid agenda for this next meeting? [19:20:36] you/me checkin? no [19:20:43] i was about to start pulling things together for myself [19:20:54] but.. will wait until later since it's going to be wed now [19:23:26] atgo: No, I mean for the thing that's starting in 7 minutes. [19:23:48] i'll add a few notes [19:24:00] but my hope is to get you and ellery on the same page about the approach [19:24:26] Ah, okay. [19:25:03] (PS8) Ejegg: Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [19:25:22] (CR) jenkins-bot: [V: -1] Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [19:25:32] atgo: Also, we definitely can't keep things in etherpad. We should be surprised when they are there twice in a row. [19:25:44] i made a collab page for this and you guys all went back to the etherpad. [19:25:50] Huh. [19:26:03] Who linked the etherpad in the meeting? [19:26:32] probably also me :P [19:26:58] i made this: https://collab.wikimedia.org/wiki/Fundraising/banner_history_cookie [19:27:22] then in the meeting, everyone went back to etherpad... if you guys want to use it then someone needs to be on tap to update the corresponding wiki page [19:27:59] atgo: thanks 4 doing that collab page, I just got access so I'll check it out [19:28:44] I kinda would be happier if all our notes were totally public unless there was a good reason for them not to be... I understand that etherpad may not be the best medium tho [19:28:58] (PS9) Ejegg: Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [19:29:08] * AndyRussG waves at ejegg and awight [19:29:19] Hi AndyRussG [19:29:23] :) [19:29:35] atgo: So, usually... I think what I normally see is individual meetings being wiped/added to collab, and then removed from the etherpad. [19:29:40] atgo: so the meeting that was starting in 1 min now is in 1 hour? [19:29:44] no, it's in 1 min. [19:29:59] With a link added, so people don't lose it, and there's no data duplication to... have to manually diff and update. [19:30:05] K4-713: that's fine [19:30:15] are you expecting me to do that updating to collab? [19:30:25] No, but I'm wondering who did. [19:30:25] atgo: ah OK, yeah I see my calendars have time zone dementia, be there in a sec [19:30:38] i made the first pass, then everyone went back to the etherpad and i did not clean up the notes. [19:30:49] Ah. [19:31:01] running people down about where they're keeping notes is not the highest priority thing in my day :P [19:31:40] So, maybe we wipe the collab page and take the contents after today's meeting, and then wipe the etherpad so this doesn't happen again. :) [20:10:29] I'm gonna deploy the Lithuania EUR patch, fyi... [20:10:35] anyone else have Payments fodder? [20:14:24] awight: gopher it. [20:14:34] I have nothing. [20:14:37] (PS1) Awight: Deploy once Lithuania is on the Euro. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182095 [20:14:55] (CR) Awight: [C: 2] Deploy once Lithuania is on the Euro. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182095 (owner: Awight) [20:15:23] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/182096 [20:15:34] (Merged) jenkins-bot: Deploy once Lithuania is on the Euro. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182095 (owner: Awight) [20:15:47] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/182096 (owner: Awight) [20:19:02] !log payments updated from ce7fb9af37c4bba2a84668387b61729df4f9723c to e81f473acc5b31b49dd27714c40f9b71c3462e26 [20:19:08] Logged the message, Master [20:22:10] Sorry about my laptop temp issues... funny how after only one week back in Mexico City it's started doing that again! the heat sink really loves the air quality... [20:23:21] maybe the wall current is 40Hz :) [20:26:26] hehe [20:29:15] No, it's 65 Hz... I tasted it myself [20:32:32] pica! [20:32:39] demasiado [20:46:27] (PS10) Ssmith: Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 [20:46:35] (CR) jenkins-bot: [V: -1] Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [21:41:27] awight: thanks for moving and filling in the conclusion of [21:41:30] #2310 [21:41:47] #2318 is the other card you were talking about? [21:41:52] looks good, BTW! [22:01:02] AndyRussG: yes, #2318. I completely agree with your points about fixing this code, but maybe we can debate the incremental vs wholesale upgrade... [22:01:26] awight: OK sounds good :) [22:01:43] Currently, my thinking is that we should only fix the hiding logic with minimal changes, that make it compatible with future improvements. [22:02:02] Yeah sounds perfect actually [22:02:02] (or for more negatives :), make it less incompatible with the future) [22:02:08] heh [22:02:31] I was gonna say, incremental first step could be just some minor cleanup, like say variable names... [22:02:47] yeah those are historical trainwrecks [22:03:48] * AndyRussG imagines the train crashing and breaking into pieces that are words, and the surviving ones, like "wait", "count" and "hide" getting stuck back together haphasardly [22:04:39] ok I'll go ahead and clean up these patches, then [22:05:01] Any thoughts about how to make the cookies forward- and backward- compatible? [22:05:16] (PS11) Ssmith: Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 [22:05:19] urgh. Maybe I should just leave those alone for now [22:06:43] awight: well, I think they'll eventually get rolled into local storage with banner history gum [22:07:13] eew [22:07:16] I'd say even leave the cookies as is for now, and we can worry about compatibility when we change storage mechansm? [22:07:39] Ah sorry, I meant banner history blister spore viri [22:07:41] (CR) Ejegg: [C: 2] Updated chart for basic design. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/178995 (owner: Ssmith) [22:08:05] awight is there a time that works better for you for this dash persistence meeting? [22:08:06] Have you heard the phrase "ABC gum"? That's what I'm thinking of now [22:08:38] pizzzacat: If I can be helpful, I'm glad to attend today [22:09:16] awight, just wanted everyone who wants to be in on the requirements to be there at the same time :) [22:09:31] it gets hairy when we aren't all on the same page [22:10:43] in the past it has led to some very game-changing twists and turns [22:10:49] is all! [22:10:57] so up to you :) [22:11:03] heheh [22:11:10] (re: abc gum) [22:14:36] pizzzacat: I hear that. Let me... not get involved in requirements. I only got on this mailing list in order to take crumbs off of ejegg|afk's plate, which immediately did not happen! [22:15:22] ohh ok! no worries at all then awight. thanks for being interested! [22:16:32] :p I'm not [22:16:34] hehehe [22:30:19] (PS4) Awight: Preload JS comes with no baggage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 [22:30:21] (PS1) Awight: Delete BannerDiet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182107 [22:30:23] (CR) jenkins-bot: [V: -1] Preload JS comes with no baggage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 (owner: Awight) [22:30:25] (CR) jenkins-bot: [V: -1] Delete BannerDiet mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182107 (owner: Awight) [22:52:58] (PS4) Ejegg: connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 (owner: Ssmith) [22:53:04] (CR) jenkins-bot: [V: -1] connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 (owner: Ssmith) [22:58:30] (CR) Ejegg: "Looking forward to the next steps on this! Noticed a couple little things" (2 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 (owner: Ssmith) [23:28:05] (PS5) Ssmith: connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 [23:28:11] (CR) jenkins-bot: [V: -1] connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 (owner: Ssmith) [23:32:09] (PS6) Ssmith: connect front and back ends for x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/181528 [23:46:57] (CR) AndyRussG: "> Are they used anywhere else to avoid the extra trip on mobile?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182074 (owner: AndyRussG)