[00:09:52] ejegg: can I deploy that AliPay stuff? [00:10:26] awight: I /think/ so! [00:10:39] anything we'd want to wait for? [00:10:41] hehe ok then, buckle up [00:10:42] nah [00:11:07] GC hasn't figured out how to make every tiny thing its own configuration which needs to be enabled at their end. We should hook them up with WP. [00:11:18] hehe [00:14:20] (PS1) Awight: log which transaction we're about to initiate [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182964 [00:14:22] (PS1) Awight: Add Alipay form [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182965 [00:14:24] (PS1) Awight: Annotation in generated forms links to source file [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182966 [00:14:30] (CR) Awight: [C: 2] Annotation in generated forms links to source file [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182966 (owner: Awight) [00:14:35] (CR) Awight: [C: 2] Add Alipay form [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182965 (owner: Awight) [00:14:40] (CR) Awight: [C: 2] log which transaction we're about to initiate [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182964 (owner: Awight) [00:15:23] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/182967 [00:15:33] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/182967 (owner: Awight) [00:15:41] got the ali vm booted up and ready to test. hope there's at least $1 worth of CNY in the test account today [00:16:14] * awight goes through the futon cushions [00:18:09] aww man. I killed Zuul again?? [00:18:30] Why is it always us. [00:18:32] :p [00:18:42] hmm, a certain clothing retailer is testing ali payments today... lol @ shared test account [00:18:47] * awight sings ghostbusters theme [00:18:56] wat. that's insane [00:19:06] highly secure [00:19:06] pffffffpfpfblt. [00:19:12] yep [00:19:22] but hey, free money! [00:19:30] * K4-713 goes muahahaha [00:19:35] (CR) Awight: [V: 2] log which transaction we're about to initiate [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182964 (owner: Awight) [00:19:43] (CR) Awight: [V: 2] Add Alipay form [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182965 (owner: Awight) [00:19:52] (CR) Awight: [V: 2] Annotation in generated forms links to source file [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/182966 (owner: Awight) [00:20:31] (CR) Awight: [V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/182967 (owner: Awight) [00:20:43] (PS2) Awight: Add Alipay form settings [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/182936 (owner: Ejegg) [00:20:49] (CR) Awight: [V: 2] Add Alipay form settings [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/182936 (owner: Ejegg) [00:22:58] !log updated payments from 62c81d4574e5e994ff8f3cac7115eff335bd5265 to c23cf16407ef200da446d81fb990abbe429fd378 [00:23:02] Logged the message, Master [00:34:00] hrm, they're asking for a second password to make the payment after signing in. Nothing in the test docs about this [00:34:09] aaaaagh [00:36:23] (CR) Awight: "> Nice!! Maybe eventually we should have a public flag for hiding, too, à la bannerData.hideResult? Just thought, not sure it's the best r" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181240 (owner: Awight) [00:37:19] (PS4) Awight: WIP clean up database switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181238 [00:38:06] ok, found some more updated docs online and got the payment through. [00:39:16] wow [00:39:42] 25483391:4122236940 [00:40:10] it hung up at the globalcollect re [00:40:25] never redirected? [00:40:28] oop, no it didn't [00:40:40] connection issues on this side [00:40:44] there's a logline that it's 'complete:process' [00:40:53] cool! [00:43:16] ejegg: strange, nothing's gone through the queue consumer yet. [00:43:41] ah dang [00:43:49] right, there was a CRM part too [00:43:59] let me just get that implemented... [00:44:13] oh, I'm looking in the wrong place for the QC logs actually, these don't cover today. [00:48:27] ejegg: ok I went through the QC logs and don't see anything with this contribution_tracking id. that's odd. [00:48:51] I'm pretty sure I need to add the payment instrument mapping [00:49:09] just coding that up now [00:49:27] that's probably true. but it still should have hit the QC [00:49:53] hrm [00:50:02] * AndyRussG waves :) [00:50:33] Anything from either of the other ewallets we do via gc? [00:50:52] They're extremely rare... [00:50:58] ok [00:52:45] Hey guys. [00:52:54] Everything but credit card settles late. [00:53:31] oh. but. So no queue message, just the WR1? [00:53:36] yep [00:53:53] * awight toggles the coin return lever [00:54:08] I mean, it probably dumped some really convincing looking breadcrumbs in the limbo queue. [00:54:14] But, nothing actually... reads that. [00:54:24] It just sits there for some small number of days and gets archived. [00:56:43] AndyRussG: hey, so is https://gerrit.wikimedia.org/r/#/c/181238 just a misunderstanding on my part? I couldn't figure out when we would ever want to use a database other than CNDatabase::getDb [01:14:07] (PS5) Awight: Clean up database switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181238 [01:21:39] (PS3) Awight: Schema migration adds the contribution_source table [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/173768 [01:29:05] (PS8) Ssmith: Move filters from modal & add save/preview [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/182239 [01:29:36] patch set #49829929994888 [02:16:24] (PS3) Awight: WIP Finish moving validation out of GatewayForm and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 [02:20:27] (CR) Awight: "ignore PS3, it's damaged." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (owner: Awight) [02:43:00] (PS1) Ejegg: Add Alipay payment instrument [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/182991 [18:34:34] ejegg: Hey, I was just looking at your last commit. [18:35:03] The CRM stuff for Ali? [18:35:11] Did you by any chance find some janky way to test a WR1 import on your local? [18:35:17] nope, fraid not [18:35:36] I have this very strong suspicion that it will explode if we don't add the new payment instrument somewhere else. [18:35:59] Actually, I think I might have when I was looking at your initial audit stuff [18:35:59] hmm, let me see [18:36:23] Well, you'd have to fake one of the lines. [18:36:30] Which is terrible because fixed with argh. [18:36:30] right [18:36:37] er: width. [18:37:27] OK, let me try to get that going locally [18:37:54] Meanwhile, I will try to figure out what the hell I'm talking about. [18:39:08] AHA. [18:39:10] Not crazy. [18:39:55] ooh, where is it missing? [18:39:59] ejegg: Check out /crm/sites/all/modules/wmf_civicrm/wmf_civicrm.install [18:40:53] I add it to payment_instrument in update_7026 [18:41:02] oh snap, did I miss that in the checkin? [18:41:25] I think so. [18:41:33] At least, I didn't see it. [18:41:50] Actually, it's possible I've been blinded. [18:41:53] I think it's ok: https://gerrit.wikimedia.org/r/#/c/182991/1/sites/all/modules/wmf_civicrm/wmf_civicrm.install [18:41:54] wth [18:42:32] someone throwing flashbangs around the wmf offices? [18:43:27] Amnesia flashbangs. [18:43:31] heh [18:43:36] ....which is my new pen name. [18:43:37] Forever. [18:43:55] * K4-713 goes off to buy a domain [18:44:10] whoa. you saw it here first, on ORC [18:44:13] i'll call my agent at harlequin [18:44:19] Perfect. [18:45:02] I think everybody can go home now. [18:45:24] Eureka! now, if we could only remember the question. [18:45:35] What? [18:45:41] ... [18:45:57] Who *are* you people? [18:46:16] Hey it's not funny. That stuff really happens, and not when you want it to. [18:46:29] Are you sure you didn't want it to? [18:46:41] How would you remember if you were better off? [18:47:34] there's this reealy sketchy and hopefully debunked theory about that... http://en.wikipedia.org/wiki/J_curve#Political_science_.28Model_of_revolutions.29 [18:47:49] imperialist apologists... [18:48:03] And, on a related topic, I'm going to try to figure out where in the world I got with https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1595 . [18:48:38] * awight sneaks off to refactor history [18:49:02] You already did that! [18:49:02] whoa, you'll wreak havoc if you try to push that to the master timeline! [18:49:10] -f [18:49:29] does git have a handydandy flag for merging across alternate dimensions? [18:49:35] Because I'm probably going to need that. [18:51:38] ejegg: hey didyu happen to look for that AliPay transaction this morning? [18:52:00] rats, contribution_id: NULL [18:52:52] aw shoot [18:53:06] Where? [18:53:21] oh, is that b/c we didn't have the CRM part up when the audit ran? [18:53:22] ejegg: oh, actually, the WR1 job runs at a weird time [18:53:36] ... /me maths [18:53:42] What happened? [18:53:42] 0100 UTC which is... [18:53:48] Late afternoon. [18:53:58] Which is right after the new files generate. [18:54:12] interesting, ts=20150106002855 [18:54:25] That was 30 min before yesterday's job [18:54:35] so I guess we shouldn't be surprised. [18:54:44] Which job? [18:54:50] The download job, or the processing job? [18:54:50] the WR1 muncher [18:54:56] They're friends. [18:55:08] * awight squints [18:55:32] right. I was looking at the parser [18:55:59] just a couple minutes' difference, happily [18:56:05] hum. [18:56:18] So, what's the current status? [18:56:19] OK, I found it in the wr1 log with a legit contrib id [18:56:24] Huh. [18:56:26] Really? [18:56:37] Wait. [18:57:06] wat [18:57:09] ejegg: Are you talking about the log from the jenkins job? [18:57:11] or, maybe not [18:57:17] nope, the completed wr1 file [18:57:20] okay. [18:57:28] What was the record type? [18:57:31] but it may be a different contrib [18:57:34] ooh [18:57:37] First three characters from the relevant line. [18:57:43] CCECMC [18:57:43] +ON [18:57:52] If it's the one that says the payment just initiated, we don't want that one in the db. [18:58:14] For everything that isn't credit card, we wait for it to settle. [18:58:48] ah, ok [18:59:17] +ON looks like it's just the initiation. [18:59:24] Anything else takes, you know... days. [18:59:27] Usually. [19:00:17] gotcha [19:00:37] Looks like we're waiting for... +IP. [19:00:44] (Abandoned) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/182343 (owner: Awight) [19:01:12] ejegg: Did you get in to the wr1 parser iterator thing in the fr_tools repo at all? [19:01:49] I don't think you *need* to do that for this to work, but it might be enlightening. [19:01:51] Or not. [19:02:01] looked it over a while back, but didn't touch it with this change [19:02:36] Yeah, I think Payment-method is still at the same fixed-width position, so the payment instrument map takes care of that. [19:04:00] I'd totally try to fake it locally by changing that +ON to a +IP. [19:04:50] Though, that might not work at all. I wouldn't be at all surprised if they shift all the characters one to the left or something. [19:04:54] yeah, it may not have been the right one [19:05:17] * awight clouds over [19:07:00] hey awight: I don't have permission to view https://phabricator.wikimedia.org/T85169 and I've been asked to comment on it. [19:07:08] Awkward. [19:07:25] omg [19:08:07] Also, why are there REPLY HANDLER ACTIONS for a no-reply email address? [19:08:08] K4-713: I commented as much [19:08:14] :[ [19:08:39] awight: Thanks. :) [19:08:39] yeah I'm still headscratching about the phabricator git notifications. [19:08:45] no perms to see my own patches, etc [19:08:55] I hear it's not a problem, though :p [19:09:06] (Abandoned) Awight: Use Composer-managed STOMP library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163637 (owner: Awight) [19:09:21] I don't think I have permission to see anything other than 1,000 emails telling me not to reply to them. [19:09:47] hehehe. [19:09:52] The name's Buttle, not Tuttle! [19:10:08] (PS2) Awight: remove test manifest in deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163130 [19:10:51] (CR) Awight: [C: 2] Add Alipay payment instrument [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/182991 (owner: Ejegg) [19:10:53] (CR) Ejegg: [C: 2 V: 2] remove test manifest in deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/163130 (owner: Awight) [19:10:55] (Merged) jenkins-bot: Add Alipay payment instrument [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/182991 (owner: Ejegg) [19:12:47] (PS2) Awight: fix comment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/95739 [19:14:07] (PS2) Awight: log total number matched [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/99266 [19:14:59] (PS2) Awight: cancel_date is actually created from subscr_date during consumption normalization [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/104141 [19:15:58] (PS3) Awight: shutdown handler to capture fatal error info [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/94087 [19:16:19] (PS4) Awight: Differentiate rapidhtml failure cases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/95874 [19:16:51] For some reason, this. http://www.hrwiki.org/wiki/Lookin_at_a_Thing_in_a_Bag [19:16:58] I feel like homestar a lot. [19:17:05] I mean, probably. [19:17:58] (PS2) Awight: missing semicolon [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/181218 [19:23:13] (PS2) Awight: Ignore the dist/ directory on the master branch [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176847 [19:25:16] ejegg: K4-713: so heyy uh. Shall we deploy ee's patch to DonationInterface, which includes stomp and minfraud via composer? [19:25:28] oooo [19:25:36] Ahh... [19:25:39] Ehrm. [19:25:49] How much have you tested locally? [19:25:50] Seems like a good time, cos I won't be here tomorrow to see the bloodbath [19:25:56] didn't you -1 that? [19:26:02] Sneaky. [19:26:05] :p [19:26:05] I think that was for safety :) [19:26:14] no... isn't it merged to master? looking. [19:26:32] oops uh [19:26:50] yeah it's just the autoloading for DI classes that blocked for me [19:27:00] Right [19:27:12] I need to look deeper into composer, I think [19:27:33] it's making a map in the vendor dir that includes both 3rd party deps and the locally defined files [19:27:43] Well, ok how about royal-we split that patch into a separate thing for each library [19:27:59] we can set the autoload for DI classes aside for now [19:28:02] if u agree [19:28:31] Will that work? [19:28:38] definitely [19:28:50] autoload frameworks are cumulative [19:29:36] And it doesn't matter that both have an idea of where to find the DI classes? [19:29:44] mmm ummm what? [19:30:00] if we leave out that line in composer.json, we don't have to go there [19:30:09] The autoload in vendor points to the DI classes as well [19:30:24] it should be rebuilt then? [19:31:01] Oh, but won't that break things for CRM using DI as a dependency? [19:31:20] I'm just a little confused about composer libs that are also supposed to work standalone [19:32:08] me too. I think the idea is that the top-level project is the only place we set up autoloading. [19:32:23] So for crm, it will be crm/vendor/autoload..., for DI, DI/vendor/autoload [19:32:38] when we're using DI under crm, it's still loading using crm/vendor/autoload [19:32:56] ... which is built according to the schema in DI/composer.json [19:33:09] Right [19:33:16] It's definitely not clean [19:33:38] So DI's composer.json needs to mention its own classes in the map [19:33:49] no. wait. maybe [19:33:55] But isn't DI/vendor/autoload also reading from DI's composer.json? [19:34:02] crap [19:34:19] yeah, that's where this breaks down for me [19:34:52] Is there a card for this? [19:34:59] hehehe [19:35:05] I see. :p [19:35:14] nope, just a thing we thought would make us look cool [19:35:20] voom! [19:35:31] * K4-713 goes back to looking at a thing in a bag [19:35:32] ejegg: This is gross, but I think we can rely on the MediaWiki autoloader running before the Composer one. [19:35:33] put your hat back on, little cat z! [19:35:43] ok [19:36:09] will split the patch and see how that works [19:36:18] MEanwhile... yeah we have to fix any php files which declare more than one class. [19:36:28] then we're good to go with composer autoloading. [19:36:41] also... MW 1.25 or something will have the same issue [19:37:03] yeah, not sure how that's supposed to work with extensions [19:37:18] It seems ill thought through [19:38:21] ejegg: don't let me hijack yr other stuff unless this is fun. I'm happy to pry at this patch if you're busy. [19:38:24] https://www.mediawiki.org/wiki/Composer might inform [19:38:44] nice [19:39:06] ooh it's out of date [19:39:31] wow, there are a lot of mw extensions at packagist though! [19:39:55] i definitely want to look at a couple of those first [19:40:24] this is sketchy: https://www.mediawiki.org/wiki/Composer/For_extensions still refers to copy+editing composer-example.json [19:40:58] hrm [19:41:22] https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FPubSubHubbub [19:41:41] yuck. They "autoload" the main file, which then makes $wgAutoLoadClasses assignments. [19:42:03] https://www.mediawiki.org/wiki/Manual:External_libraries [19:42:27] says you need to put any libs for wmf-deployed extensions into mediawiki-vendor [19:42:52] * K4-713 blinks [19:42:57] Zero merge conflicts. [19:42:59] yeah but when we went down that rabbithole last month, the conclusion was that DI doesn't count [19:43:07] * awight shudders at the changed past [19:43:33] I... how the hell did I do that? [19:44:05] clean, self-contained patches? [19:44:13] (PS4) Awight: Warn if a campaign's bucket assignments look funky [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177475 [19:45:48] Oh wait. I get it. It probably just doesn't work anymore. [19:45:55] * K4-713 looks somewhat relieved [19:47:34] (PS5) Awight: Warn if a campaign's bucket assignments look funky [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177475 [19:47:38] (CR) Awight: Warn if a campaign's bucket assignments look funky (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/177475 (owner: Awight) [19:47:48] (PS4) Awight: Add banner includes bucket dropdown [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/178260 [20:02:52] (PS3) Ejegg: Use Composer-managed Stomp and Minfraud classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 [20:03:07] (CR) jenkins-bot: [V: -1] Use Composer-managed Stomp and Minfraud classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 (owner: Ejegg) [20:05:19] oh yeah, that won't merge till https://phabricator.wikimedia.org/T84942 happens [20:12:09] (CR) Ejegg: "Can't merge till https://phabricator.wikimedia.org/T84942 happens, or we add the libs to mediawiki-vendor" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 (owner: Ejegg) [20:42:05] hey K4|lunch awight|fud - if someone donated from their paypal account, but not through our flow (they just sent $ to our email address), would that show up in civi? [20:42:46] through recon [20:45:26] (CR) Ejegg: "Still a bit confusing how the groups are mixed with the filters." (3 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/182239 (owner: Ssmith) [21:17:10] atgo: yes, it should show up [21:21:00] ejegg|biab: good call on the zuul-cloner dependency. But, maybe we shouldn't be running contrib lib code during CI anyway? [21:26:43] fwiw, Reedy just deployed some mobile CentralNotice config changes for us... [21:32:02] (PS1) Awight: Normalize minor include file naming [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183144 [21:32:20] (CR) jenkins-bot: [V: -1] Normalize minor include file naming [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183144 (owner: Awight) [21:34:12] whoa. phplint thinks there is a thing in PHP where a static function with a name similar to the class name is actually a constructor. wth? [21:34:18] PHP Fatal error: Constructor CountryCodes::countryCodes() cannot be static in gateway_forms/includes/CountryCodes.php on line 254 [21:34:57] (PS2) Awight: Normalize minor include file naming [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183144 [21:35:15] (CR) jenkins-bot: [V: -1] Normalize minor include file naming [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183144 (owner: Awight) [21:36:26] (PS3) Awight: Normalize minor include file naming [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183144 [21:43:38] (CR) Awight: "I was wrong about this repo declaring multiple classes per file--this is only done in the test dirs, not a problem for the Composer classm" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 (owner: Ejegg) [21:45:58] (PS2) Awight: Default to mark refunds as completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/180030 [21:47:57] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/183146 [21:48:09] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/183146 (owner: Awight) [21:48:11] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/183146 (owner: Awight) [21:49:09] !log update crm from 80241fd2a43f03796b416d728661470f875a590a to 8ded33737337d0c842d8c194b5cb15b25fc99c2e [21:49:15] Logged the message, Master [21:49:59] ejegg: fyi, I just deployed #2298 [21:50:14] thanks! [21:50:48] Oh, we need to run the drush db update [21:50:58] to add that new option to the group [21:50:59] I did! [21:51:15] oh, awesome [21:51:16] I haven't confirmed anything yet... [21:51:44] (PS2) Awight: add Adyen to reconciliation search criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/112941 [21:52:26] (PS3) Awight: Add Adyen and WorldPay to reconciliation search criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/112941 [21:53:30] (PS1) Awight: We don't actually depend on the devel module. Remove it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/183149 [21:53:51] (Abandoned) Awight: update devel module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/113882 (owner: Awight) [22:03:07] (Abandoned) Awight: [WIP] add Date Diet mixin based on BannerShowHideCountDate.js [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120167 (owner: Awight) [22:07:59] (Abandoned) Awight: unmatched tag glitch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124908 (owner: Awight) [22:09:15] (CR) Awight: [C: -1] "TODO: split and rework" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/64236 (owner: Awight) [22:09:41] (PS7) Awight: move getGatewayClass into GatewayAdapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/64873 [22:09:46] (CR) jenkins-bot: [V: -1] move getGatewayClass into GatewayAdapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/64873 (owner: Awight) [22:28:07] (PS2) Awight: bump PayPal "classic api" version [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 [22:28:42] (PS3) Awight: bump PayPal "classic api" version [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 [22:42:56] (PS7) Awight: Test for missing message translations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163338 [22:44:20] (PS2) Awight: Killall original_ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164393 [22:44:24] (PS2) Awight: kill original_ [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/164394 [22:44:34] (PS2) Awight: sort fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/164395 [22:45:47] (CR) Awight: [C: -1] Fail the message if a currency or amount are given alone, rather than as a pair. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/164499 (owner: Awight) [22:46:11] (Abandoned) Awight: WIP useless rough draft tests for more banner choosing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173533 (owner: Awight) [22:52:35] (PS1) Awight: One QUnit test per allocation fixture [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 [22:53:56] (PS9) Awight: WIP Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 [22:59:10] (Abandoned) Awight: real submodule pointer for node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/151136 (owner: Awight) [22:59:44] (Abandoned) Awight: Merge remote-tracking branch 'origin/REL1_22' into fundraising/REL1_22 [core] (fundraising/REL1_22) - https://gerrit.wikimedia.org/r/160026 (owner: Awight) [23:14:15] (PS10) Awight: Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 [23:16:25] (Abandoned) Awight: Prototype of an encrypted client-side credit card form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/97658 (owner: Awight) [23:22:53] (PS2) Awight: comment large_donation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163133 [23:23:02] (PS3) Awight: comment large_donation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163133 [23:42:01] (PS1) Awight: Merge REL1_23 into fundraising/REL1_23 [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/183167 [23:47:31] (CR) Awight: [C: 2] "Self-merging cos everyone who cares has already +one'd." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/179976 (owner: Awight) [23:48:03] hey team! i may be heading out soon because sick... just a heads up [23:48:19] aww, sorry to hear it's the bad one [23:50:41] awight: want to see some cute?