[00:18:39] (PS1) Awight: WIP looking at single responsibility issues in RapidHtml [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183172 [00:22:24] (PS4) Awight: WIP Finish moving validation out of GatewayForm and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 [00:40:54] (PS5) Awight: Finish moving validation out of GatewayForm and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 [00:41:13] (CR) jenkins-bot: [V: -1] Finish moving validation out of GatewayForm and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (owner: Awight) [00:52:32] Here is your cat of the day: https://www.youtube.com/watch?v=6pKPkf9dJKw [01:01:49] All I'm getting out of this PHPUnit thing is: don't put your name all over software if it's gonna be broken in a horrific, indefinite, and arrogant way. [01:02:29] haha [01:02:46] I went to one of his talks once, just to get a good look at the guy. [01:02:51] :) [01:03:41] So, would you believe that I still can't take advantage of the composer-included smashpig libs in civi? [01:03:56] ... [01:04:00] argh? [01:04:04] Yeah. [01:04:04] lemme see [01:06:34] wait pizzzacat was that the cat of the day or the preview for bad movie night? [01:06:49] both! [01:07:41] K4-713: require_once __DIR__ . '/../../vendor/autoload.php'; [01:07:48] SURPRISE :) [01:08:06] Worst birthday ever. [01:08:10] totally transparent dependency management [01:08:13] Good things it's not my birthday. [01:08:28] well you could call a mistrial and not age [01:08:43] I did that a while ago. [01:09:31] who doesn't love a PHP project that you build with ant [01:12:51] atgo: that was really spooky. You're right. [01:13:46] huh [01:16:50] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (owner: Awight) [01:21:34] (PS1) Awight: Split test adapters into a file per class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183181 [01:24:16] (PS1) Awight: Split test gateway forms into a single file per class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183182 [01:24:34] (PS6) Awight: Finish moving validation out of GatewayForm and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 [01:24:53] (CR) jenkins-bot: [V: -1] Finish moving validation out of GatewayForm and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (owner: Awight) [01:27:37] (PS7) Awight: Finish moving validation out of GatewayForm and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 [01:27:54] (CR) jenkins-bot: [V: -1] Finish moving validation out of GatewayForm and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (owner: Awight) [01:29:06] (PS8) Awight: Finish moving validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 [01:29:23] (CR) jenkins-bot: [V: -1] Finish moving validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (owner: Awight) [01:34:48] (PS9) Awight: Finish moving validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 [01:35:11] (CR) jenkins-bot: [V: -1] Finish moving validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (owner: Awight) [18:01:07] I really should take my personal work notes somewhere public instead of just stashing them on my desktop in 1,000 files called variations of TODO.txt. [18:08:24] hey K4-713 i ran away, but we're in the usual room [18:20:31] atgo: Oh, I wasn't going to crash that one. [18:20:43] I was going to crash the first half of the follow-up tech thingy. [18:20:56] Then I have to bail out for something else. [18:24:43] Any requests for the scrum of scrums? [18:38:59] ejegg: Sorry, had to run off to a meeting thing. [18:39:18] I still haven't spoken, if you have anything to add [18:39:20] Ah, maybe mention that we're going to try to cram as much refactoring in to January as we possibly can? [18:39:27] ok, will do! [18:39:31] Thanks! [19:18:26] atgo: got a quick request for tech, would you rather I put it in mingle or phabricator at this stage? [19:18:34] mingle please :) [19:18:37] thanks for asking [19:18:58] okay, no problem [19:21:44] hey ejegg K4-713: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2180 [19:22:00] just realized - we didn't have thi sin the sprint last timebut then we extended the sprint [19:22:55] har [19:23:14] oho! [19:23:35] we determined we weren't actually using the dying endpoint [19:23:43] oh yay that's right [19:24:04] Yeah... the good news is that if minfraud was borked, we'd be failing 100% of all the methods that use it. [19:24:09] K4-713: Did you find someplace on their site to update the api version they think we're using? [19:24:27] I did, but we're all the way on the newest thing on their end. [19:24:34] oh yeah, weird [19:25:10] It's also a different thing. [19:51:51] (PS1) Ejegg: Add promise lib [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/183308 [20:00:19] (Abandoned) Ejegg: Add promise lib [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/183308 (owner: Ejegg) [21:12:09] TIL pizzzacat steals all drinking vessels [21:14:15] :'-( [21:14:22] it's true I'm a thief! [21:17:41] Dish Bandits. [21:24:44] hey K4-713 if you want help with the thing for CV just lmk [21:25:07] I guess they just want 2-3 bullet points... can you OTS for the second? [21:25:14] for *a second. [21:25:20] ...not that one specific second. [21:25:33] Brain typos are weird. [21:27:41] yes' [22:04:20] (PS1) Ejegg: Add promise library [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/183378 [22:05:10] (PS1) Ejegg: Persistence schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 [22:05:12] (PS1) Ejegg: Add promise to package.json and update node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 [22:05:25] (CR) jenkins-bot: [V: -1] Add promise to package.json and update node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 (owner: Ejegg) [22:07:31] (PS1) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 [22:08:03] (CR) jenkins-bot: [V: -1] Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (owner: Ejegg) [22:15:46] (PS2) Ejegg: Persistence schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 [22:15:48] (PS2) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 [22:15:50] (PS2) Ejegg: Add promise to package.json and update node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 [22:15:52] (CR) jenkins-bot: [V: -1] Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (owner: Ejegg) [22:15:56] (CR) jenkins-bot: [V: -1] Add promise to package.json and update node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 (owner: Ejegg) [23:21:29] (PS3) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 [23:21:38] (CR) jenkins-bot: [V: -1] Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (owner: Ejegg)