[00:10:55] !log updated payments settings [00:11:02] Logged the message, Master [00:34:14] relevant to some of your interests: https://doughbies.co/?utm_source=PH [00:35:45] oho [00:36:58] aww, nothing near me [00:52:26] back in my day we called that startup "your mom" [00:53:05] or in my case "your neighbor's mom" because my mom would never make cookies [01:43:22] (CR) Ejegg: [C: 2] "Hooray for less-ugly organization of ugly code :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183181 (owner: Awight) [01:46:37] (Merged) jenkins-bot: Split test adapters into a file per class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183181 (owner: Awight) [01:46:58] (CR) Ejegg: [C: 2] Split test gateway forms into a single file per class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183182 (owner: Awight) [01:47:13] (Merged) jenkins-bot: Split test gateway forms into a single file per class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183182 (owner: Awight) [02:08:05] (CR) Ejegg: [C: -1] "I like this direction! But still WIP?" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (owner: Awight) [02:17:36] (CR) Ejegg: [C: 2] "Looks like most of these windows aren't exposed on our fortress, but still nice to have em patched" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/183167 (owner: Awight) [02:19:38] (CR) Ejegg: [V: 2] "Looks like most of these windows aren't exposed on our fortress, but still nice to have em patched" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/183167 (owner: Awight) [02:38:09] (CR) Ejegg: [C: -1] "I think this comment is inaccurate. It sure looks like those are the db IDs" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163133 (owner: Awight) [02:40:55] (CR) Ejegg: [C: 2] We don't actually depend on the devel module. Remove it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/183149 (owner: Awight) [02:41:54] (CR) Ejegg: [C: 2] Add Adyen and WorldPay to reconciliation search criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/112941 (owner: Awight) [03:04:55] (CR) Ejegg: "Oh, man... we're using it like it is, with inaccurate results. Looks like the fetchAllAssoc with the orderBy is sorting everything except" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163133 (owner: Awight) [17:27:14] (PS1) Ejegg: Differentiate delete buttons for large donation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/183542 [17:28:29] (CR) Ejegg: "So, they /are/ database IDs. The delete button was acting on the wrong threshold because of this: https://gerrit.wikimedia.org/r/183542" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/163133 (owner: Awight) [17:31:00] (CR) Ejegg: [C: 2] sort fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/164395 (owner: Awight) [17:34:07] hey awight :) [17:34:16] atgo: morning! [17:34:44] how's it going? [17:34:52] ejegg: no, not db IDs but UI ids [17:35:03] atgo: I'm... refactoring DonationInterface :p [17:35:11] haha [17:35:16] Thanks for testing Israel! [17:35:20] no problem! [17:35:28] so that one seems to wokr, but NZ and GB don't [17:35:45] I guess I should still test with my card, cos there were some hints that my debitness was the real issue. [17:35:51] ah [17:35:52] hm.. maybe [17:35:58] ok iz all borken then [17:36:18] the weird thing about GB is that in fredge it's saying the country is US [17:36:23] whoa [17:36:25] hang on.. let me see if i can figure out how to do things again [17:36:42] I wonder if that causes fraud points [17:36:50] as well as just being wrong [17:36:57] well we are processing, but it's not coming back from gc [17:37:03] | 5353300 | 25488914 | worldpay | 25488914.0 | | process | failed | cc | visa-debit | US | 3 | GBP [17:37:14] awight: the HTML ids are all built with the UI ids. The visible numbers are purely sequential UI ids, but the input ids are all db ids [17:37:18] i tried to sql yesterday :P [17:37:20] blah [17:37:34] i meant the HTML ids are all built with the DB ids. [17:39:07] ejegg: I see what u mean. I should improve the comment in https://gerrit.wikimedia.org/r/#/c/163133 to explain that I felt it necessary to introduce two different numerical IDs [17:39:19] why the hell do I do that. the UI should have freeform string IDs [17:42:06] (CR) Ssmith: [C: 2] Ignore the dist/ directory on the master branch [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176847 (owner: Awight) [17:42:21] pizzzacat: thanks! [17:42:24] (Merged) jenkins-bot: Ignore the dist/ directory on the master branch [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/176847 (owner: Awight) [17:43:08] awight: do you need any more info from me to help with WP? [17:43:36] atgo: what is currently first priority? We're still waiting for action from there side, to explain the CVN issues. [17:43:38] awight: :) super tough patch to review [17:43:44] * awight reddens. "their" [17:43:54] oh awight they responded [17:44:08] pizzzacat: haha. At least you didn't embarrass me with comments :D [17:44:19] atgo: me looks [17:45:08] atgo: got it [17:45:24] He even explained why :) [17:46:54] woo! [17:47:00] ...woo? [17:47:11] Was it me? [17:47:15] awight got an email from wordlpay :P [17:47:19] Woo! [17:47:48] Remind me to write a bot that cheers when anybody on the team signs on. [17:47:59] hehe that would be super [17:48:51] Or says things like "We're SAVED!" or "THANK GOODNESS YOU'RE HERE." [17:49:02] K4-713: can we have individualized fight songs? [17:49:07] Hell yes. [17:49:38] you know... there would be little remaining reason to WFH if we could have loud music and kids. [17:50:02] I have another friend that wrote a bot that screams whenever somebody in their channel says the (randomized from a list) word of the day. [17:50:35] So, they'd just be chatting away until somebody says "stakeholder"... [17:50:40] AAAAARGH! [17:51:03] No explanaiton. [17:51:10] ...no explanation either. [17:51:16] :/ [17:51:20] yes that made a big impression on me [17:51:26] awight: I had something I wanted to talk to you about. [17:51:33] I did see a few Pee Wee's episodes [17:51:36] K4-713: si [17:51:37] The funny thing is, I'm not entirely sure what it was. [17:51:41] d'oh! [17:51:49] I think it has to do with the slugfest on the calendar today. [17:52:00] We could have public IRC "tea w/ drama" [17:52:36] Too bad you're not going to be in the room for that one... we're deciding what we can cram in for the next three weeks of relative quiet. [17:52:56] Let's... etherpad? [17:53:03] We already wiki'd. [17:53:06] btw, it's been great to have the outline wiki'd [17:53:07] I saw [17:53:17] thanks, really easy to follow the way you fixed it! [17:53:25] Woot. [17:53:35] * awight sneaks off to implement the plan [17:53:39] So, yeah: Think about what grinds the most gears. [17:53:45] ...that we can do in three weeks. [17:54:01] I do sort of want to save the actual slugfest for the meeting. [17:54:05] I am severing the wires between UI and Adapters [17:54:11] orly [17:54:15] that is all. [17:54:18] I will be very interested to see how that ends up. [17:54:23] awight: we need a crm part of the 'kill original_' project too, right? [17:54:24] Happy to personally rank things, though. [17:54:38] ejegg: sure, it's the last thing to do, though [17:54:40] ...because data validation is a serious PITA when all the 3rd parties have different rules. [17:54:43] ok, cool [17:55:08] (PS1) Ejegg: Killmoar original_ [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/183547 [17:55:13] .. anything else that receives data flow from the queues? [17:55:19] :) [17:55:26] That's a serious contender. [17:55:57] (CR) Awight: [C: 2] Killmoar original_ [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/183547 (owner: Ejegg) [17:56:00] (Merged) jenkins-bot: Killmoar original_ [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/183547 (owner: Ejegg) [17:56:17] I think the one thing we have that's a total lock, is the kind of form refactoring that pizzzacat would be in charge of. [17:56:29] Everything else is up for spirited debate. [17:57:07] And, it's going to be fun trying not to land eachother in merge hell while we do this. [17:57:25] ejegg: see the card, I think the CRM patch should warn as well as kill [17:58:30] OK, but there are a few places in CRM that depend on original_ fields in messages now. Deployment may need to be a bit of a tango [17:59:10] K4-713: coffeetown USA? [17:59:22] yep! [18:01:49] awight: FYI while you were gone... [18:03:38] https://phabricator.wikimedia.org/sprint/board/994/ [18:05:02] so stop using mingle :P [18:05:03] New rule: all band names starting with A refer to the same sprint [18:05:35] So we can mix the playlist up a bit [18:15:36] (PS4) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 [18:24:22] atgo: oh GREAT. just got the memo [18:24:29] :P [18:25:29] Good call on alphabet-based organization btw. GRabbit tried something like this just as I left, it developed into hilarious alliterations of code names :D [18:53:53] yay! [18:53:56] it's more fun [18:57:16] (CR) Ejegg: [C: -1] "db error handling is getting ugly with all the nesting and callbacks. will try wrapping query method in promises" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (owner: Ejegg) [19:09:50] hey ejegg (when) are you going to be in town for all hands? [19:10:17] also... guys... the east coast is cold. [19:10:20] good question! Let me check (and put it on my calendar) [19:10:37] Hooray for accurate calendars. [19:10:37] OMG so cold right now [19:10:54] ejegg: Also, we have a checkin in 20 minutes, and I actually have stuff this time. [19:11:00] OK, cool [19:11:18] I'll be on the call in 20 [19:11:27] Groovy. :) [19:13:00] atgo: 1/20 - 1/28 [19:13:14] rad! [19:25:57] awight: fwiw, i was able to donate to israel [19:35:31] atgo: hum. Okay, let's green light this thing in IL, then. Would you mind testing the remaining countries, if you haven't already? [19:35:43] i did yesterday [19:35:47] that's what i was saying earlier [19:35:55] so nothing else works, you said? [19:36:04] check out oid 25488914.0 [19:36:08] that should've been GB [19:36:12] cool [19:36:17] and 25488827.0 NZ [19:36:31] but it looks like US, whee! I would call that borken [19:36:32] yeah i know... weird [19:36:37] but the NZ one is NZ/NZD [19:36:37] oh, you were successful in NZ? [19:36:43] no it failed [19:36:50] on WP's side [19:37:04] ok thx [19:43:05] atgo: I can't find 25488914 or 25488827 anywhere in the payments logs. I don't know what that means, maybe I should start drinking coffee. [19:43:16] ha... that is super weird [19:43:45] here's the "id" from payments_initial in fredge 5353248 [19:43:52] that's for NZ [19:44:06] awight: select * from payments_initial where gateway = 'worldpay' order by id desc limit 10; [19:44:13] I see it stuff in the db... just no logs [19:44:33] there's a contribution_tracking entry, but no contribution [19:45:42] oops, of course there's no contribution. GC allegedly fails :) [19:45:55] Did K4|meeting check that for you yesterday? [19:46:07] hur? [19:46:16] K4|meeting: I'm seeing things [19:46:39] atgo is giving me ctids from yesterday, and I can't find in any WP logs [19:47:21] K4|meeting: did you find logs for the GB donation attempt that looks like it's from the US? [19:48:12] Just wondering why atgo said that "well we are processing, but it's not coming back from gc" [19:48:31] sounds like you did sleuthing already? [19:48:44] awight: Ah, I was totally unhelpful for that one. [19:48:47] So far. [19:48:50] me too. [19:48:51] oh because (and maybe i'm full of it) the column validation_action says "process" and then "payments_final_status" says failed [19:48:52] ok thx [19:49:08] i thought that K4|meeting had said that the valid... was us and the paym... was WP [19:49:08] atgo: ok sorry for the public shaming! [19:49:12] no worries : [19:49:13] :) [19:49:16] i know nothing [19:49:59] ...wait. [19:50:12] We didn't start defaulting to US for the sake of amazon, did we? [19:50:21] wat [19:50:24] I'll look [19:50:35] Oh, hang on. I think that's nonsense. [19:51:06] We'd have to default to US in q2civi, which is... so far downstream of the payments logs I'm embarrassing myself. [19:51:28] Because amazon's issue was sending no country back in their update messages. [19:51:32] Sometimes. [19:51:55] K4|meeting: yeah we don't do such a thing from gateway_common or worldpay_adapter, at least. [19:52:12] hurm. [19:52:17] This is peculiar. [19:52:26] If it makes you all feel better, not finding these transactions in the logs is making me at least as bewildered and embarrased as everyone else. [19:52:32] maybe GC... [19:52:32] Neat. [19:52:41] haha, ah... wait. [19:52:47] So, they're not in any of the logs? [19:52:50] nope [19:52:59] * K4|meeting squints [19:53:12] How did we find them anywhere, then? [19:53:46] that's what I'm saying [19:53:51] ... [19:54:14] Hang on, I'm going back to my desk to continue pulling on this mysteriousness. [19:54:17] atgo is in the database \o/ [19:54:54] from fredge! [19:55:03] here's the query: select * from payments_initial where gateway = 'worldpay' order by id desc limit 10; [19:55:05] atgo: how did you find those IDs, though? [19:55:07] oooh [19:55:16] k4 may have helped me [19:55:59] atgo: well fwiw I agree with your work [20:06:18] awight: I got lost. [20:06:31] And now it's lunchtime. [20:06:31] hehe [20:06:34] 5th floor? [20:06:46] "*NOW* where am I?!?" [20:06:57] no worries, I'm going to poke at this abcess a bit then do something else so I don't go crazy [20:07:04] neat [20:07:10] ...kbye [20:09:02] Jeff_Green: I think I found a log-replication hole... or maybe I just don't understand where all the files live. [20:09:29] ok [20:09:44] payments-worldpay-20150107.gz ends at Jan 6 22:11:41, but the active logfile starts at Jan 8 [20:10:00] actually, payments-initial is a better example cos it has constant traffic [20:10:12] where are you looking? [20:10:32] pmming... [20:15:43] K4|lunch: atgo-away: okay Jeff_Green talked me off the roof. The log box is the correct place to look for rotated files, not the /archive nfs mounts on other machines. [20:16:26] fwiw, /archive aren't nfs mounts. they're local copies that are periodically rsync'd [20:16:43] ohwow. p2p [20:16:45] done that way for data redundancy [20:16:59] you don't truts centralized servers? :p [20:17:09] true! [20:17:21] you can pretty much wildcard everything after trust in that statement [20:17:37] wait, actually I trust rsync. that could be my achilles heel [20:18:14] hah/ [20:19:02] you have found a way to reconcile yrself with the final slash interpretation? [20:19:11] I just try to ignore the pain [20:19:30] ha [20:19:34] I don't want to be this angry at something I love [20:19:59] at least it's fairly consistent with the weirdness [20:44:41] atgo-away: thanks for all the info--I've mailed WP with the failure details. [20:44:44] K4|lunch: ^ [20:54:57] (PS1) Awight: sprinkle comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183629 [20:54:59] (PS1) Awight: WIP make paymentmethod non-static [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183630 [20:55:16] (CR) jenkins-bot: [V: -1] sprinkle comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183629 (owner: Awight) [20:55:43] (CR) jenkins-bot: [V: -1] WIP make paymentmethod non-static [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183630 (owner: Awight) [21:02:38] awesome! [21:16:10] atgo: I should add new misc cards to "Fundraising Tech Backlog" [21:16:10] ? [21:16:19] yeah! [21:16:33] we can make a board for them there for organizational purposes at some point, too [21:16:39] it's looking really good. [21:16:55] Can't wait to add a "Bug:" line to commits, too! [21:17:06] viva la infrastructure! [21:23:02] (PS1) Ejegg: Add HK to Alipay form settings [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/183640 [21:32:18] K4 and I are again tackling technical difficulties, please stand by [22:30:22] the more i think about it, the more i think it makes sense to have a planned place to start and then have blocked other tasks based on that [22:31:07] that sounds good. [23:01:17] (PS10) Awight: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) [23:01:49] (CR) jenkins-bot: [V: -1] Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) (owner: Awight) [23:02:37] atgo: Buh, how do I get a... points field. [23:02:52] yeah so that... can only happen if the task is in a project that is a sprint [23:03:04] which i've already asked them to change [23:03:21] we can just make the project a sprint though if that's helpful [23:04:18] Awrf. [23:04:30] Well... would it hurt anything? [23:09:47] nope i don't think so.. it does make loading run slower but they're planning on a fix for that already [23:09:50] i'll do that [23:10:14] (PS11) Awight: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) [23:12:53] ooh that tagging the other task thing was awesome [23:14:51] god making it a sprint makes it so much slower [23:15:16] the mingle sauce... [23:15:53] * atgo hangs head [23:16:02] anyway, now you can add story points [23:20:54] atgo: I was about to ask: Wait, is it the sprint extension that's pouring wet concrete all over the place? [23:20:57] ...yes. Yes it is. [23:21:03] yeah it's annoying [23:21:06] hmmm... [23:21:07] fff [23:21:11] Oh well. [23:21:20] I'll just be reloading it all the time in some other tab. [23:21:32] I'm sure that will help with, you know, overall performance. :D [23:21:34] hahaha [23:21:43] yeah i'm following the bug about it so we'll see what happens [23:22:01] apparently they've got a fix but they're trying to define a process for deployment [23:22:29] https://phabricator.wikimedia.org/T78679 [23:32:09] i wonder if there's some way we could trick it... [23:34:40] (CR) Ejegg: [C: -1] "Don't merge yet, trying out a more featureful promise library" [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/183378 (owner: Ejegg) [23:38:02] atgo: Trick it into not sucking? [23:38:09] * K4-713 looks skeptical [23:38:15] yeah [23:38:19] so like.. hang on. let me play [23:38:26] I'm in no hurry. [23:38:35] Weird. [23:40:10] so.. here's a (very big PITA) way [23:40:34] we could make this project not a sprint, but assign the tasks into another project that is a sprint [23:40:45] then the tasks still have the property, but it's not slowed down [23:41:06] for example, if you go to the fundraising backlog board it's all zippy [23:41:06] https://phabricator.wikimedia.org/project/board/41/ [23:41:08] I'm glad that nobody else is interested in the overhead of estimating how difficult tasks are [23:42:07] i think it makes sense to do roughly when we're pulling them into the workflow, but not suuuper far in advance, since the estimate could change a lot if the surrounding code changes... [23:42:41] but anyway, if you look at that board and then look at T86097, it has points on it [23:43:31] but the whole project isn't slowed [23:46:08] awight: :p [23:46:57] Don't you know, that when you estimate something, ***you might get caught being wrong in public?!?*** [23:47:26] hehehe [23:47:35] actually I am an authority on this [23:47:36] And then it's all dogs and cats living together. [23:48:33] If I were WFO, I would show you something really weird. [23:48:59] I can't get any debug statements to prove that we ever call executeIframeForCreditCard in the GC page class. [23:49:07] but... we do [23:49:23] Hey, that's cool. [23:49:58] Pretty soon, all of our code will execute non-deterministically [23:50:12] Outed. [23:50:34] It's because I did that merge across alternate dimensions, isn't it? [23:51:04] but they calculated such a low chance of the Earth being swallowed up into a black hole... [23:51:06] Could do an ajax call to a slightly different reality now. [23:51:19] Hopefully it's one that has good credit card security. [23:51:43] ...oops, gotta go. [23:51:49] Good luck with that. [23:52:03] I don't think I'm going to get back in a useful way. [23:52:18] It's one long meeting and then exit stage left. [23:52:26] So... see you all tomorrow, I guess.