[00:07:32] <grrrit-wm>	 (CR) Ejegg: [C: -1] "Just missing some slashes in the dirs." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163338 (owner: Awight)
[00:14:41] <grrrit-wm>	 (PS1) Awight: TestingGenericAdapter can do normal validation, not just fakey [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184009
[00:18:21] <K4-713>	 ejegg: Yeah, I think you'll find that the lightbox stuff haven't been touched in a way more interesting than Find and Replace type things, since 2011 or something.
[00:19:26] <ejegg>	 on the chopping block it goes
[00:19:41] <K4-713>	 Yay!
[00:20:04] <K4-713>	 ...I mean CHAAAARGE.
[00:39:27] <grrrit-wm>	 (PS1) Awight: WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010
[00:40:21] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight)
[00:42:28] <grrrit-wm>	 (PS8) Awight: Test for missing message translations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163338
[00:46:28] <ejegg>	 anyone know what donationinterface_langonly exists for?
[00:46:45] <awight>	 ejegg: it's for...
[00:46:46] <ejegg>	 just noticed the same MessagesDirs there
[00:46:54] <awight>	 maybe foundationwiki
[00:47:13] <awight>	 something needs the messages... lemme see, it's in the config repo...
[00:47:33] <ejegg>	 ok.  want to update the wgMessagesDirs in that file for symmetry?
[00:47:41] <ejegg>	 If not, I'll totally +2 right now
[00:48:10] <awight>	 ejegg: initialisesettings.php line 11054, it's needed for donatewiki
[00:48:18] <awight>	 yes, def do want to fix, one moment please
[00:50:40] <ejegg>	 versatile extension - normal, langonly, and drupal flavors!
[00:51:08] <grrrit-wm>	 (PS9) Awight: Test for missing message translations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163338
[00:51:49] <awight>	 I don't think this is ok actually
[00:51:56] <ejegg>	 no?
[00:52:01] <awight>	 why did I make it a 2d array...
[00:53:28] <ejegg>	 That's totally allowed
[00:54:10] <ejegg>	 Yeah, looks completely legit to me
[00:54:18] <ejegg>	 And seems to work
[00:54:57] <ejegg>	 I'm gonna head out for the evening
[00:55:52] <ejegg>	 see y'all later!
[01:07:59] <awight>	 ejegg|away: yep, confirmed, 2d is okay there.
[01:45:04] <grrrit-wm>	 (PS1) Ori.livneh: MWException -> Exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/184021
[01:45:16] <grrrit-wm>	 (PS1) Ori.livneh: MWException -> Exception [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022
[01:45:56] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] MWException -> Exception [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (owner: Ori.livneh)
[01:47:27] <grrrit-wm>	 (CR) Awight: "Interesting--thanks for doing this favor for us! Would you mind dropping a link to the justification, though?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (owner: Ori.livneh)
[01:48:52] <grrrit-wm>	 (PS1) Ori.livneh: MWException -> Exception [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/184047
[01:52:00] <grrrit-wm>	 (PS1) Ori.livneh: MWException -> Exception [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/184049
[01:53:37] <awight>	 K4-713: yeesh.  I just discovered the validate_boolean function will return true for any string...
[01:53:51] <awight>	 it's a long road.
[02:23:53] <grrrit-wm>	 (PS2) Awight: WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010
[02:24:10] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight)