[16:02:19] (CR) Ejegg: [C: 2] Test for missing message translations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163338 (owner: Awight) [16:04:38] (CR) Ejegg: [C: 2] TestingGenericAdapter can do normal validation, not just fakey [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184009 (owner: Awight) [16:04:58] (Merged) jenkins-bot: Test for missing message translations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/163338 (owner: Awight) [16:05:39] (Merged) jenkins-bot: TestingGenericAdapter can do normal validation, not just fakey [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184009 (owner: Awight) [16:05:59] (CR) Ejegg: "recheck" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/183886 (owner: Ejegg) [18:14:39] (PS1) Ejegg: Add mysql-promise library [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/184385 [18:15:20] (Abandoned) Ejegg: Add promise library [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/183378 (owner: Ejegg) [18:15:49] (PS3) Ejegg: Persistence schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 [18:15:51] (PS5) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 [18:15:54] (PS3) Ejegg: Add mysql-promise to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 [18:16:02] (CR) jenkins-bot: [V: -1] Add mysql-promise to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 (owner: Ejegg) [18:16:06] (CR) jenkins-bot: [V: -1] Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (owner: Ejegg) [18:25:23] (CR) Ejegg: [C: 2] Default to mark refunds as completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/180030 (owner: Awight) [19:31:27] Hey AndyRussG! How goes? [19:33:51] Wow, phab just timed out. [19:34:20] Error: Sprint Too Cool. [19:58:47] K4-713: Hi! Fine, thanks! Back here in snowland :) [19:59:05] How are u? [19:59:12] Pretty good. [19:59:23] Actually writing some code. [19:59:26] :o [20:02:04] K4-713: woohoo! Do you miss that a bit, with all ur meetings? [20:02:12] Definitely. [20:03:15] But, it's no longer this... urgent sense that actual work done can be expressed in lines of code committed. [20:03:32] That's been the most difficult thing to get over, actually. [20:04:11] Heheh measure everything! And what can't be measured, doesn't count.. [20:04:16] Yeah I understand [20:04:59] That's also one of those things where knowing it's not accurate and getting to the point where you really believe it's not the whole picture, have a tremendous gap between them. [20:08:51] Maybe it's harder when it has to do with judging one's own performance, if you're used to having some measure to use to push yourself? I dunno, just a thought... [20:09:00] Yeah, it was totally me. [20:09:06] 100%. [20:09:50] Beating myself up for performance metrics that nobody else things are reasonable is sort of a hobby. :) [20:14:46] Hmmm [20:16:50] Failing to notice when I'm doing it, is another hobby. [20:17:26] I think I came out of the kit that way. [20:17:54] Hmmm sounds like you're noticing pretty good... Heh I just had something like that yesterday in a discussion with my older daughter who didn't want to do her homework.... not easy.... [20:18:23] Oh, I never notice at the time. [20:18:34] You could try to see all the codeless meetings as a way to learn using other modes of thought that aren't so technical, and but that do in the end complement technical stuff... [20:19:16] It's usually later when I'm saying out loud to a human being "I don't know how I'm going to do all [these things] by [this time]!" which causes them to say "Woah, who the hell is expecting that to be doable?" and I'm like "...Oh." [20:19:47] Happily, I have settled in to some of it. [20:20:30] Hmmm :) yeah I guess that's _the_ classic computer programming pain point [20:21:00] That and not bricking your "new" smartphone when trying to install Replicant on it [20:21:09] Eee. [20:21:21] That sounds decidedly unhelpful. [20:21:37] * AndyRussG continues to try very hard not to continue trying to unbrick [20:30:21] (PS1) Ssmith: sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 [20:30:27] (CR) jenkins-bot: [V: -1] sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 (owner: Ssmith) [20:49:16] Aw dang. [20:49:23] Just found a pretty great bug. [20:49:32] where? [20:49:39] The gc wr1 audit script. [20:49:57] It's falsely identifying chargebacks as belonging to recurring payments, when they're not. [20:50:28] ...which would explain why chargebacks allegedly stopped working. [20:50:38] Oh snap [20:50:51] yep [20:50:58] Well, I'll fix it when we move, I guess. [20:51:10] Happily, we can rerun all the audit files from... forever. [20:52:18] Gah. I bet somebody changed something in wmf_common that caused it to stop returning an actual null for contribution_recur_id. [20:52:24] Like... the string 'NULL'. [20:52:38] Have I ever mentioned how much I hate computers? :p [20:52:56] Well, wait. Loosely-typed languages. [20:56:13] If it's a problem in the common module, I'll have to fix this before I can continue. [20:56:14] Boo. [21:18:56] Yeah I love those "gotcha you darn bug" moments [21:55:50] there should be more treats in the 3rd floor kitchen [21:56:31] right now it's a scant peanut butter chocolate cake, mochi, lemon bars, lemon cupcakes, lemon candy, and pumpkin bread [21:56:41] like how am I supposed to live on that [21:57:34] I didn't know I was participating in Operation Omnomnomnom. [21:58:18] it's like CandyLand thanksgiving in there [21:58:43] That's my next album. [21:59:47] The weird thing is, this has happened before. [22:00:20] Some kind of snacky-treat-related convergence zone. [22:01:08] ccogdill: Oh, you're there. [22:01:20] I figured out why chargebacks stopped showing up. [22:01:26] in civi? [22:01:33] Hopefully about to fix it. Yes. [22:01:37] that’s good! [22:01:42] awesome, thanks [22:01:48] The exact reason is making me sad, though. [22:02:52] But it shouldn't be hard to correct. [22:03:38] ccogdill: Do you have a sense for when they stopped getting in there automatically? [22:03:47] no idea k4-713 [22:03:53] I thought they never did it quite right [22:03:59] No way. [22:04:09] They used to do it perfectly... unless it was a recurring transaction. [22:04:16] The problem now is that the code thinks they're all recurring. [22:04:28] But I guarantee it used to work for non-recurring. [22:04:34] Refunds and chargebacks. [22:18:16] (PS9) Ssmith: Move filters from modal & add save/preview [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/182239 [22:20:05] (PS10) Ssmith: Move filters from modal & add save/preview [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/182239 [22:32:03] (PS1) Katie Horn: wmf_common functions no longer returning actual nulls [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184499 [22:32:54] (CR) Ssmith: Persistence schema (2 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 (owner: Ejegg) [22:34:01] question to the field: does anyone (@ejegg maybe) know if the text fields in the prospect tab are searchable in civi? [22:34:16] @ejegg for the above [22:34:42] * K4-713 frowns [22:34:57] CaitVirtue: I really, really wish I knew what you were talking about. [22:35:22] I mean, I feel like this is right in the zone of things I should at least have a mental picture for. [22:43:27] CaitVirtue: let me see - I think you generally /can/ make custom fields searchable [22:43:40] Where is this tab, even? [22:44:06] should be in the contact view in Civi [22:44:15] ejegg: Also, I have something silly for you to review and maybe deploy in civi. [22:44:28] Relating to the 'NULL' thing? [22:44:31] yep [22:44:37] cool! [22:44:54] Happily, it's not the text 'NULL'. It's just an empty string. [22:45:02] Which... damn it, civi. [22:45:14] It's totally a real null in the DB. [22:45:45] ah cool, taking a look [22:46:17] Do you know if awight is any closer to sorting out CI for this project? [22:46:25] looks extremely un-risky [22:46:39] I try. [22:46:41] Well... sometimes. [22:46:43] :D [22:46:57] (CR) Ejegg: [C: 2] wmf_common functions no longer returning actual nulls [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184499 (owner: Katie Horn) [22:47:10] Sometimes my commits look like a burlap sack full of cats. [22:47:43] K4-713: He was blocked on something with our internal infrastructure, but for the life of me I can't remember exactly what [22:48:02] I can wait until tomorrow. [22:49:49] CaitVirtue: Yes, all the custom fields in the 'Prospect' group are set to be searchable [22:52:15] ejegg: How likely is it that I can convince you to do a civi deploy? [22:53:29] 1.0 [22:53:38] i.e., sure I'll do it [22:53:46] I was going to say: I really hope that's binary. [22:53:48] hah [22:54:09] And not like... out of 100. [22:55:01] heh, I think stats people go from 0 to 1 [22:56:00] Oh, right. [22:56:23] You'd think I wouldn't forget about that. [22:57:16] ejegg: How much in civi is currently undeployed/ [22:57:18] ? [22:57:25] I mean, other than the thing I just did. [22:57:29] very little, since we did that thing on Friday [22:57:36] lemme see if there's anything else at all [22:57:43] I don't remember friday happening. [22:57:52] Oh wait. [22:58:01] the alipay exception [22:58:02] There it is. [22:58:28] There was a kind of cloud hanging over awight and myself. [22:58:46] Lots of frowning. [22:59:32] sorry to hear that, i guess [23:00:00] good news, there's only the one change! [23:00:56] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/184508 [23:04:04] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/184508 (owner: Ejegg) [23:06:01] !log updated crm from d8a1160bca99354a856b1595cedf5c33f9ac255c to bb05adf9279bd7a795906ca476e1850a85c21711 [23:06:05] Logged the message, Master [23:06:40] K4-713: wanna re-run that audit? [23:08:45] Yay, neato! Ah, I am going to have to move some files around first, I think. [23:09:10] I'm going to probably re-run... everything. [23:09:17] All of December. [23:09:23] At least. [23:09:25] ooh, that'll take a little while [23:09:28] yep [23:09:37] Probably will want to do it in stages. [23:09:40] ccogdill: yt? [23:10:05] hmm? [23:10:23] ah yes I’m here. took a second to decode that one ;) what’s up k4-713? [23:10:54] No, i meant: Is this "your turtle"? [23:10:57] ...just kidding. [23:11:15] if so, yes [23:11:18] I want the turtle [23:11:23] Good answer. :) [23:11:24] Ah, is donor services entering chargebacks in to the system at all? [23:11:35] no [23:11:40] Excellent. [23:11:46] I think Michael and I have refunded a couple in civi in passing [23:11:56] a really small number, just when we stumbled across them [23:11:56] That fix for the chargeback /refund problem is in. [23:12:07] yay! that’s great news [23:12:13] So, I'm going to start probably manually running nightly scripts and see how it reacts. [23:12:21] Then re-tackle all of December. [23:12:30] okay [23:12:36] might as well do it now when things are quiet [23:12:46] Actually, if you're not entering chargebacks at all, I can look at when GC entered the last one properly and start there. [23:13:10] Should make life easier for PPena when we try to reconcile. [23:13:56] ccogdill: Do you want me to ping you when I start the process, or just tell you when it's done? [23:14:02] Nobody should get emailed or anything. [23:15:01] mmm I think just when it’s done? [23:15:11] Can do. :) [23:15:13] Thanks! [23:15:15] thank you! [23:15:19] this is great to have fixed [23:15:21] January is the best [23:16:01] I love it. [23:16:07] So. Much. [23:20:40] Hmm, CaitVirtue may not be able to search those fields after all [23:21:11] expanding the Custom Fields group on the advacnced contact search gives Exception: "A fatal error was triggered: One of parameters (value: ) is not of the type Integer"