[00:16:58] hey k4-713 do you have a second? [00:17:07] More or less. What's up [00:17:08] ? [00:17:24] mysql is giving me fits - I can’t figure out in what table I can find a US donor [00:17:28] *donor’s state [00:17:40] I tried civicrm_address but it seems like we use some numeric code for state there [00:17:59] and I can’t find a contact id in civicrm_country to Join with civicrm_contribution [00:18:03] is this making any sense? :/ [00:20:04] Aaaha. [00:20:23] Yes, this is one of those things that drives me nuts every single time I look at it. [00:20:31] haha okay glad it’s not just me... [00:20:41] * K4-713 grabs emergency red bull [00:20:45] eek [00:20:56] emergency bread bowl? [00:21:14] :D [00:21:16] maybe I should just figure out the numeric code for the states I’m looking for? I only need 5. legal needs a tally for a few states in FY 13 [00:21:35] Nah, let me get you the real answer. [00:21:45] show tables; [00:21:49] pfff haha [00:21:53] so many tables [00:22:19] That's what I get for looking out the actual window while typing. [00:22:41] haha I thought you were giving me step by step instructions. fooled me! [00:24:24] ccogdill: Aha, just as I thought: There's a civicrm_state_province table. [00:24:46] * ccogdill facepalms [00:25:07] Oh, but wait. I should probably look to make sure it's... you know: Reasonable in there. [00:25:14] :) [00:25:32] Yep, looks relatively sane. [00:26:07] There shouldn't be too many ways to screw up a state table. [00:26:12] okay cool. would you be able to tell me where I find the CID in that table? [00:26:19] CID? [00:26:22] is it id or contact_id or? [00:26:30] er... [00:26:33] Hang on. [00:26:45] So, how far did you get? [00:26:57] I can find this out, I was lazily hoping you already knew [00:27:02] I will describe and see! [00:29:53] Well, if you've got the state_province_id hanging around in some query already, just join civicrm_state_province.id to that. [00:31:59] ccogdill: I think I see the source of some confusion. [00:32:11] hmm okay so in a table like civicrm_state_province, the contact ID doesn’t make an appearance at all? that’s how I was planning on joining that but doesn’t seem to work. [00:32:14] is that the confusion? [00:32:24] So, the state table and the country table, only have one entry per country or state, respectively. [00:32:33] oh… [00:32:41] Contacts reference the ids in those tables, which seems to be the other way 'round from what you were thinking. [00:32:51] I see [00:34:26] So, it'll go civicrm_address.country_id = civicrm_country.id, and civicrm_address.state_province_id = civicrm_state_province.id [00:35:05] ccogdill: Do you have a query I can abuse? [00:35:27] I think it’s probably totally off base :D I’m trying to figure out how to reconfigure it [00:35:36] ? [00:35:48] here’s what I was working with when I incorrectly assumed I could join on contact ID: select * from civicrm_contribution LEFT JOIN civicrm_state_province ON civicrm_contribution.contact_id = civicrm_state_province.id WHERE civicrm_contribution.receive_date >'2013-06-30' AND civicrm_contribution.receive_date <'2014-07-01' AND civicrm_state_province.abbreviation = 'NY'; [00:36:45] Aha: You're missing the address table in the middle there. [00:36:49] yeah [00:36:53] BUT. [00:37:11] When you throw that in, you have to limit the query results to just the preferred address. [00:37:31] Or, you run the risk of getting people showing up many multiple times just because they have multiple addresses in the system. [00:37:47] ohh I hadn’t thought of that [00:37:58] That one bit me directly several times. [00:38:58] Which is even better when it causes, say, a donation total to froth over to more money than you got from anywhere in the relevant time slice. [00:39:25] (PS4) Ejegg: Persistence schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 [00:39:27] (PS6) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 [00:39:29] (PS4) Ejegg: Add mysql-promise to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 [00:39:31] (PS1) Ejegg: Add body-parser to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184532 [00:39:34] (PS1) Ejegg: Add body-parser [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/184533 [00:39:59] haha yes, I could see that making legal a little nervous. [00:40:20] 19:10 hahahaha [00:40:20] 19:11 nice IDE [00:40:20] 19:11 jeeze [00:40:47] (PS2) Ssmith: sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 [00:40:50] ack, sorry [00:40:51] (CR) jenkins-bot: [V: -1] Add body-parser to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184532 (owner: Ejegg) [00:40:53] (CR) jenkins-bot: [V: -1] Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (owner: Ejegg) [00:40:55] (CR) jenkins-bot: [V: -1] sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 (owner: Ssmith) [00:41:03] misbehaving mouse again :P [00:42:08] Misbehaving Mouse was a great cartoon. [00:42:24] he was so cruel to ignatz cat [00:43:21] (CR) jenkins-bot: [V: -1] Add mysql-promise to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 (owner: Ejegg) [00:46:18] okay k4-713 I figured out the initial query, just not sure how to limit to preferred address. do I use HAVING? [00:46:29] I didn't. [00:46:33] You can just... [00:46:44] Sorry, wait 1. [00:46:51] no problem [00:46:54] select cc.*, state.abbreviation [00:46:54] from civicrm_contribution cc [00:46:54] LEFT JOIN civicrm_address ca ON ca.contact_id = cc.id AND is_primary = 1 [00:46:54] LEFT JOIN civicrm_state_province state ON ca.state_province_id = state.id [00:46:54] WHERE cc.receive_date >'2013-06-30' [00:46:54] AND cc.receive_date <'2014-07-01' [00:46:55] AND state.abbreviation = 'NY'; [00:47:14] If awight were here, he would yell at me for limiting like that in the join. [00:47:23] hehe [00:47:25] he’ll never know [00:47:45] yours is so much cleaner looking than mine :( [00:48:35] That join weirdness is a weird habit I will never kick. SQL Compact left scars. [00:49:42] If you're ever running queries like this on a microsoft handheld device, that's the only way you'll ever get anything but a beach ball. [00:50:08] But, the system has to live there. [00:50:18] * K4-713 looks haunted [00:50:44] (CR) Ejegg: "Want to just kill the groups-mixed-with-filters bit in the js too?" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/182239 (owner: Ssmith) [00:51:16] In other news, it looks like we haven't been getting chargebacks through GC for BASICALLY A YEAR. [00:51:28] well that seems about right [00:51:35] * K4-713 weeps gently [00:51:46] but we get them now! [00:51:52] Will, yes. [00:51:57] Haaargh. [00:52:17] I just have to, you know, spoofeed the whole year through Jenkins. [00:52:23] Er. Spoonfeed. [00:52:44] oh no, there isn’t an easy solution there? :/ [00:52:47] I need another bread bowl. [00:52:54] Not... one that will work. [00:54:05] sigh [00:54:10] ...I'm sure it will be fine. [00:54:14] well thank you for the sql help! [00:54:14] <_< [00:54:15] >_> [00:54:57] ccogdill: Absolutely. [00:55:05] I'm still thrilled that you want to do things this way. [00:55:36] So, anything that makes it more likely that you'll keep doing that, I'm in for. [00:56:01] me too! just looking forward to the day I actually know what’s in all those tables... [00:56:13] ... [00:56:29] a girl can dream [00:56:36] I think that's the day you burst into flames and become some kind of SQL phoenix. [00:56:54] It hasn't happened to me. Frankly I'm sort of afraid of it. [00:57:16] awight would probably agree with me. [00:57:34] but a SQL phoenix does sound like a great aspirational FR avatar [00:58:10] Definitely looks pretty neat in my head. [00:58:25] If it happens to me before anybody else, you'll have to let me know what it looked like. [00:59:08] when you burst into flames and are reborn? I bet it would be pretty awesome [00:59:18] maybe your hair just comes out orange and red [01:00:02] It does that sometimes anyway. [01:00:04] :) [01:12:39] Hum. Something tells me this isn't going to work either. [01:12:56] spoon not big enough? [01:13:14] or the actual code change? [01:13:36] Perhaps my spoon is too big. [01:13:47] Ah... the messages look all whack. [01:14:08] Maybe we whacked them, though. [01:14:11] :/ [01:14:44] Yeah, I'm thinking this is going to be completely dismissed as nonsense. [01:15:30] ejegg: One of those things where the first layer of bugs reveals more issues. [01:15:40] It was totally obscuring other bugs. [01:15:54] Oh, was the audit ever working for refunds or chargebacks? [01:15:59] Hell yes. [01:16:03] Nobody believes me. [01:16:07] But it really, really was. [01:16:17] There's a whole queue for it and everything. [01:16:57] I think the problem with trying to keep a grip on chargebacks is that basically, nobody tells you directly that they're doing them. [01:17:42] I mean, they don't come to us and do one. [01:17:53] right, it's all via their bank [01:17:53] So, we don't really know when there are more than we know about, because we don't know about them. [01:18:24] And with the seriously variable volume, I'm not sure what to put an alarm on, or what that would look like. [01:19:34] hum... [01:19:39] Anyway, let's see if I can break everything. [01:20:23] Well, that's nice. Nothing broke. [01:20:30] This should (probably) be easy to fix. [01:20:56] ejegg: You going to be around for a bit, or should I just give up on today and go for tomorrow? [01:21:33] yeah, i'll be here for a while [01:21:57] Okay, cool. Because I'm already 90% sure I already know what's going on. [01:22:28] You know when we changed what we were stuffing in MERCHANTREFERENCE, and the realized that the wr1 files were pumping that through and not the order_id? [01:22:42] The refund/chargeback message generator did not get that memo. [01:22:48] ah, that would make sense [01:22:58] So, I should just... be able to flip some keys and go. [01:22:58] (CR) Ssmith: [C: 2] Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (owner: Ejegg) [01:37:34] (CR) Ejegg: [C: 2] Move function into the base class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183752 (https://phabricator.wikimedia.org/T86256) (owner: Awight) [01:38:23] (Merged) jenkins-bot: Move function into the base class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183752 (https://phabricator.wikimedia.org/T86256) (owner: Awight) [01:39:11] (CR) Ejegg: [C: 2] Differentiate rapidhtml failure cases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/95874 (owner: Awight) [01:40:01] (Merged) jenkins-bot: Differentiate rapidhtml failure cases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/95874 (owner: Awight) [02:11:03] (PS7) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 [02:11:05] (PS2) Ejegg: Add body-parser to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184532 [02:11:07] (PS1) Ejegg: WIP crud for boards and widget instances [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184539 [02:12:22] (PS1) Katie Horn: More non-optimal fixes for the nearly-decomissioned wr1 script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184540 [02:12:31] ejegg: You still there? [02:12:37] If so: Why? [02:12:38] :p [02:12:46] heh, just bored I guess [02:13:04] anyway, taking a look at that so-called suboptimality [02:13:59] lol globalcollect_audit_get_contributions_from_whatever_this_is [02:16:06] Every time I look at that script, I am both happy and furious with myself. [02:16:49] The new one, is... newer. [02:16:54] * K4-713 frowns [02:17:15] just as entertaining, i hope! [02:17:49] I'm not sure that's possible without years of... marinating in production. [02:25:35] doesn't that function with a long name return an indexed array? [02:26:12] I mean a numeric array [02:26:18] Er. [02:26:27] Let me triple-check, here... [02:26:33] just looking at how it's used on line 132 [02:26:46] and 140 [02:27:36] That's... strange. [02:27:52] When I ran it directly, to test, it gave me one record. [02:28:37] huh, lemme look at the underlying 'getchild' fns it calls [02:30:50] yeah, looks like those are returning the result of wmf_civicrm_dao_to_list [02:35:25] ejegg: Well, fooey. [02:35:42] Please -1, then. [02:35:52] I'm, ah... giving up for today. [02:36:06] see ya tomorrow! I should stop staring at screens too [02:36:10] And then I'm going to ask awight how the CI thing is going. [02:36:24] Because not being able to test my stuff is making me want to jump out the window. [02:36:37] (CR) Ejegg: [C: -1] "globalcollect_audit_get_contributions_from_whatever_this_is returns an array" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184540 (owner: Katie Horn) [02:36:56] well, you can still run phpunit locally! [02:37:30] Yeah, I figured. But there seems to be no documentation I can find. [02:37:52] ...also contributing to the "exit via window" impulse. :p [02:38:50] i recommend the elevator! [02:39:12] That is probably better in the long run, yes. [02:39:12] unless you have a 4 story geyser to descend upon [02:39:37] * ejegg tries to remember which video game [02:39:44] I WAS JUST THINKING THE SAME THING. [02:40:47] Okay, now that's really going to bother me until I figure it out. [02:41:21] I mean, I was thinking specifically about a side-scroller, and not Majora's Mask. [02:42:04] yeah, definitely 2d [02:43:03] And you could, like, swim up the thing if you didn't jump on the top. [02:43:13] right! [02:43:21] please let me know if it comes to you [02:43:30] Seriously, me too. [02:43:34] I don't care if it's 4am. [02:43:49] heh [02:43:57] I really want to say Mario was involved. [02:44:34] yeah, smb2 was my first thought, but I can't quite picture it [02:45:37] might have been new super mario brothers wii even. I'mma need to track that down [18:00:17] Meanwhile... where's our sprint, again? [18:00:51] Aah, I guess what happened is that it's no longer a sprint [18:03:57] (PS2) Awight: Document BannerRenderer [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182897 [18:04:40] (PS6) Awight: Provide BannerShowHideCountDate as a mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181239 [18:23:17] (PS11) Ssmith: Move filters from modal & add save/preview [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/182239 [18:24:27] (CR) Ejegg: [C: 2] Move filters from modal & add save/preview [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/182239 (owner: Ssmith) [18:29:58] pizzzacat: can I put yr phone outside the window and down? [18:31:38] awight I will come get it [18:31:51] someone needs attention :p [18:38:26] awight: instead of a sprint, it's a saunter? [18:39:05] (CR) Ejegg: "couple suggestions" (3 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 (owner: Ssmith) [18:40:36] hehe. task promoted from Skulking -> Arrogated [18:44:29] (PS1) Awight: WIP Updates to JP Morgan report formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184700 [18:45:16] (PS2) Awight: WIP Updates to JP Morgan report formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184700 (https://phabricator.wikimedia.org/T86682) [18:51:08] (PS6) Awight: Clean up database switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181238 [18:51:44] (Abandoned) Awight: WIP mixin for the newer diet algorithm [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/143108 (owner: Awight) [18:58:57] (Abandoned) Ejegg: Add body-parser to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184532 (owner: Ejegg) [19:02:28] (Abandoned) Ejegg: Add body-parser [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/184533 (owner: Ejegg) [19:06:58] (PS1) Awight: updates [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/184704 [19:07:22] (PS1) Awight: update vendor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184705 [19:10:52] ejegg: that was strange. I just got this when doing a local drush updatedb, in wmf_civicrm 7024: SQLSTATE[42000]: Syntax error or access violation: 1061 Duplicate key name [error] [19:10:56] 'entity_id1' [19:11:24] huh, 7024? Lemme see [19:12:36] I have no idea why it would be adding a key by that name... [19:12:44] no idea where entity_id1 is coming from [19:12:46] yeah [19:12:59] you gave column names for everything... [19:13:02] yikes. [19:13:03] and 1061 is a line within that update, but it's in the middle of an array definition [19:13:15] I think that's a mysql errno [19:13:19] o [19:13:21] yeah [19:14:09] had you run a draft version of the update or something? [19:14:16] nah [19:14:31] I'll go run it on staging for thrills... [19:15:05] you weren't logging mysql statements, were you? [19:15:51] I wish [19:16:36] hmm, we should leave that logging code in and make it conditional on a global define... [19:16:58] i just have mysql log everything on my dev box [19:17:15] that's even better! /me goes to do that [19:17:53] ejegg: just "general_log = 1"? [19:18:05] i think so. lemme see [19:18:25] and the general_log_file... [19:18:29] yep! [19:18:54] woohoo! [19:19:04] total information awareness! [19:20:48] facebook is watching... [19:21:02] ejegg: ok sorry for the slander--it was actually my prevnext alter [19:21:38] oh rly? [19:21:51] why 7024 then? [19:21:58] cos I misread the output :) [19:22:03] heh [19:22:04] it was 7025 [19:47:42] (PS1) Awight: Fix unit tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184720 (https://phabricator.wikimedia.org/T86686) [20:05:27] (PS1) Awight: Merge contrib to master [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/184729 [20:42:51] hey pizzzacat i hear you were having wifi issues this morning... got a quick tip for resolving before i go to IT? [20:43:22] atgo-away not really…. still having issues, but if I use ethernet it's ok [20:43:28] yeah that's where i'm at [20:43:30] I think the network is just crappy right now maybe [20:43:42] yeah joel's doing some work... said it might be spotty today but he could fix it quicker if it was really bad [20:45:00] (PS2) Ejegg: WIP crud for boards and widget instances [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184539 [20:45:14] (CR) jenkins-bot: [V: -1] WIP crud for boards and widget instances [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184539 (owner: Ejegg) [20:46:15] pizzzacat: did you get the persistence tables working locally? [20:46:36] yes ejegg I did. [20:46:47] cool! [20:51:06] (PS3) Ssmith: sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 [20:51:08] (CR) jenkins-bot: [V: -1] sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 (owner: Ssmith) [20:51:44] (PS4) Ssmith: sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 [20:52:01] (CR) jenkins-bot: [V: -1] sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 (owner: Ssmith) [20:52:04] ejegg ^ fixed that (last?) patch [20:52:44] do you think we can get this repo stabilized today? [20:52:58] yeah, that would be great [20:53:04] there are some jslint issues in some of the persistence patches [20:53:13] sweet :) [20:53:39] ah, looks like some jslint for that last patch too! [20:53:59] I'll fix up all the lint stuff for persistence and let you know when they're good to review [20:54:22] (CR) Ssmith: [C: 2] Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (owner: Ejegg) [20:55:34] oh, just saw your description request. will add that [20:56:56] coolio [20:58:57] (PS5) Ssmith: sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 [21:02:08] (CR) Ejegg: [C: 2 V: 2] Add mysql-promise library [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/184385 (owner: Ejegg) [21:02:26] (PS5) Ejegg: Persistence schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 [21:02:28] (PS8) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 [21:02:30] (PS5) Ejegg: Add mysql-promise to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 [21:02:32] (PS3) Ejegg: WIP crud for boards and widget instances [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184539 [21:11:52] (PS6) Ejegg: Persistence schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 (https://phabricator.wikimedia.org/T86095) [21:11:54] (PS9) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (https://phabricator.wikimedia.org/T86095) [21:11:56] (PS6) Ejegg: Add mysql-promise to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 (https://phabricator.wikimedia.org/T86095) [21:11:58] (PS4) Ejegg: WIP crud for boards and widget instances [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184539 (https://phabricator.wikimedia.org/T86095) [21:27:33] K4-713: hokay [21:27:41] Thing now? [21:27:45] yar [21:27:48] k [21:29:49] https://etherpad.wikimedia.org/p/DIFormRequirements [21:32:50] * K4-713 makes funny ghost noises [21:47:53] hey ejegg - where are we at with alipay? for some reason i can [21:47:58] not find the phab tasks for it [21:48:04] just the parent one, with no subtasks [21:48:10] i thought we'd moved 1 or 2 over [21:48:33] atgo: it seems to be working now [21:48:38] oh! awesome! [21:48:47] We had to update the audit [21:49:00] ohh is that part of what K4 is doing? [21:49:08] and we may be a couple cents off due to the CNY->EUR conversion [21:49:13] yeah that's ok [21:49:21] nope, K4-713 is working on something unrelated [21:49:35] cool [21:49:55] atgo: this is way off-topic, but can you remind me why we don't use Adyen? [21:50:00] bing! [21:50:04] atgo: bing [21:55:23] hey PPena - just pinged you on gchat... should i come to you for this meeeting? [22:05:57] atgo: I'm thinking about kicking the Civi 4.4 upgrade a bit. [22:10:21] hey ejegg if we're good for alipay for an internal test, could you drop a link into the thread with fr-all? [22:10:44] actually.. could you send to me first? [22:10:53] sure! [22:14:23] pizzzacat: https://etherpad.wikimedia.org/p/DIFormRequirements [22:20:17] (PS1) Awight: Merge contrib into contrib-v4.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/184786 [22:20:34] (Abandoned) Awight: Merge contrib into contrib-v4.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/184786 (owner: Awight) [22:20:51] (PS1) Awight: Merge contrib into contrib-v4.4 [wikimedia/fundraising/crm/civicrm] (contrib-v4.4) - https://gerrit.wikimedia.org/r/184787 [22:22:57] Anyone want to review a couple donations form settings changes? [22:23:04] cure! [22:23:06] Add HK for Alipay: https://gerrit.wikimedia.org/r/183640 [22:23:06] ahem [22:23:07] sure [22:23:26] Remove unused stuff: https://gerrit.wikimedia.org/r/183886 [22:23:34] (CR) Awight: [C: 2] Add HK to Alipay form settings [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/183640 (owner: Ejegg) [22:23:36] oh wait, that last one is already +2ed [22:23:43] just needs a submit I guess [22:24:37] Going to deploy those two if there are no objections [22:24:48] sounds good [22:25:49] thanks for CR! [22:36:03] also deploying the 1.23 release patches you merged in, awight [22:37:06] yipes. ok, should be safe [22:37:41] !log updated payments from c23cf16407ef200da446d81fb990abbe429fd378 to 46bd1611c56d6e31594d01aa345c35dd45dcf676 [22:37:46] Logged the message, Master [22:37:49] (PS1) Awight: Update to CiviCRM upstream 4.4.11 [wikimedia/fundraising/crm/civicrm] (contrib-v4.4) - https://gerrit.wikimedia.org/r/184789 [22:49:54] (CR) Ssmith: [C: 2] Persistence schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [22:50:02] (Merged) jenkins-bot: Persistence schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183379 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [22:52:24] (CR) Ejegg: [C: 2] sidebar nav changes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184422 (owner: Ssmith) [22:52:49] awesome typo: privelledged [22:52:56] shrivelled and privelled [23:07:07] (PS1) Awight: Merge contrib-v4.4 into dev-v4.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/184798 [23:07:17] (CR) jenkins-bot: [V: -1] Merge contrib-v4.4 into dev-v4.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/184798 (owner: Awight) [23:08:48] (PS1) Awight: Merge contrib-v4.4 into dev-v4.4 [wikimedia/fundraising/crm/civicrm] (dev-v4.4) - https://gerrit.wikimedia.org/r/184800 [23:28:00] K4-713: are you really having a phpunit fest? [23:28:10] I want to be. [23:28:23] But instead, I'm working on that one slide deck. [23:28:29] hah ok then [23:28:44] It only "looks" like I'm googling images of cartoon robbers. [23:28:51] I did not check. [23:28:53] but hahaha [23:29:09] so you must have noticed that Phabricator has a {meme tag? [23:29:15] WAT [23:29:22] This potentially changes my life. [23:29:24] you can be the first [23:29:29] eeeeeeeeeeEEEEEEEEe. [23:29:43] K4-713: https://secure.phabricator.com/book/phabricator/article/remarkup/ [23:29:50] Wow. First that article we noticed doesn't exist at lunch, and now this. [23:29:59] teehee [23:31:48] (CR) Ssmith: [C: 2] Add mysql-promise to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [23:31:56] (Merged) jenkins-bot: Add mysql-promise to package.json and node_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183380 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [23:36:06] (PS10) Ejegg: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (https://phabricator.wikimedia.org/T86095) [23:36:08] (PS5) Ejegg: WIP crud for boards and widget instances [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184539 (https://phabricator.wikimedia.org/T86095)