[00:00:51] awight: why the upgrade and not refactor? [00:01:30] It's blocking stuff... but I had not balanced the two against each other [00:11:21] atgo-away: thanks for reminding me that there is still fun work to do... the civi upgrade is gonna be a real dust-up [00:12:33] K4-713: ejegg|biab: pizzzacat: btw, is anyone else working on the DonationInterface refactor, or just the usual sprintly stuff? [00:13:31] My plan hasn't changed: I need to get out from under the WX thing, which I'm definitely not accomplishing when I'm busy writing mildly inflammatory slides. [00:13:38] Then, I'm all in. [00:14:11] lol thx [00:14:29] I'm feeling doubtful about this "all of January" timebox, is all [00:14:55] I am doing regular sprintly stuff [00:15:00] mostly [00:15:16] pizzzacat: I saw your note about finding a template engine... that's exciting [00:15:20] and yeah, I was wondering about January, since like, next week is a holiday and all-staff and team day [00:15:38] Yeah.... yeah. [00:15:42] we have all the time we want :) as long as it's the last two weeks [00:15:47] yeah, it just so happens that the templating engine most people are using around here is the one I have the most experience with, so that's cool [00:15:51] * awight unfurls the red banner [00:15:54] You can have January, in which half your time has already been spoken for. [00:15:59] YOU'RE WELCOME. [00:16:07] haha womp womp [00:16:11] pizzzacat: remind me: knockout can be executed from PHP? [00:16:14] *trombone* [00:16:36] awight I'm talking about mustache actually [00:16:45] oh?? that's the one people like? [00:16:55] indeed [00:17:01] isn't that the one missing all the control structures... /me looks [00:17:02] well it is becoming the standard [00:17:04] of the foundation [00:17:12] aww sketchy [00:17:36] have people been doing actual things with it, or just tiny proof-of-concept stuff? [00:17:52] I tried it for a medium complexity thing and it was a total failure... maybe that was just me though [00:17:53] not sure really [00:18:12] well I have always used handlebars on top of it [00:18:40] I dunno, we don't have to use it necessarily (I am still figuring out what needs to be done with whatever we choose) [00:18:55] mustache oversimplifies... for example, when you're inside a loop, you can't reference any data from an outer scope [00:19:14] good point, maybe we're only doing simple things. [00:20:47] http://handlebarsjs.com/ [00:27:52] (PS14) Awight: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) [00:30:13] (PS3) Awight: WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [00:31:01] (CR) jenkins-bot: [V: -1] WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [00:41:00] (PS1) Krinkle: tests: Move npm-test to repo root [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/184819 [00:42:40] (CR) Ssmith: [C: 2] Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [00:42:57] (Merged) jenkins-bot: Create local user records on login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/183381 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [00:44:35] awight: ...is there going to be anything left in GatewayPage? [00:44:49] * K4-713 grabs the lighter fluid [00:45:20] (CR) jenkins-bot: [V: -1] tests: Move npm-test to repo root [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/184819 (owner: Krinkle) [00:50:05] hehe [00:55:43] (CR) Krinkle: "recheck" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/184819 (owner: Krinkle) [00:57:17] (PS4) Awight: WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [01:03:09] (CR) jenkins-bot: [V: -1] WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [02:08:15] (PS1) Ejegg: CRUD for boards and widgets [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184833 (https://phabricator.wikimedia.org/T86095) [02:09:03] (Abandoned) Ejegg: WIP crud for boards and widget instances [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184539 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [02:56:05] (PS2) Ejegg: CRUD for boards and widgets [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184833 (https://phabricator.wikimedia.org/T86095) [07:02:26] (PS15) Awight: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) [07:19:31] (PS5) Awight: WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [07:19:33] (PS1) Awight: assign credit and blame [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184841 [07:19:35] (PS1) Awight: Use member field instead of passing value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184842 [07:19:59] (CR) jenkins-bot: [V: -1] WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [07:35:48] (PS1) Awight: Cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184844 [08:37:01] (PS1) Awight: Wipe out credit card validations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 [08:37:03] (PS1) Awight: Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 [08:37:05] (PS1) Awight: Burn a small book of unused code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184849 [08:37:19] (CR) jenkins-bot: [V: -1] Wipe out credit card validations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 (owner: Awight) [08:37:33] (CR) jenkins-bot: [V: -1] Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 (owner: Awight) [08:37:49] (CR) jenkins-bot: [V: -1] Burn a small book of unused code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184849 (owner: Awight) [08:39:39] (PS2) Awight: Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 [08:39:53] (CR) jenkins-bot: [V: -1] Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 (owner: Awight) [08:45:26] (PS2) Awight: Burn a small book of unused code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184849 [08:45:47] (CR) jenkins-bot: [V: -1] Burn a small book of unused code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184849 (owner: Awight) [08:45:59] (PS2) Awight: Cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184844 [08:46:14] (PS2) Awight: Use member field instead of passing value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184842 [08:46:24] (PS2) Awight: assign credit and blame [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184841 [08:54:21] (PS1) Awight: eliminate premium_language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184852 [08:54:44] (CR) jenkins-bot: [V: -1] eliminate premium_language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184852 (owner: Awight) [09:34:48] (PS6) Awight: WIP DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [09:38:55] (PS7) Awight: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [09:44:01] (PS8) Awight: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (https://phabricator.wikimedia.org/T86249) [09:44:16] (PS9) Awight: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [09:44:37] (PS10) Awight: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [09:47:00] (PS2) Awight: Wipe out credit card validations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 [09:48:47] (PS3) Awight: Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 [09:49:06] (CR) jenkins-bot: [V: -1] Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 (owner: Awight) [18:25:48] hi awight! I was about to do the thank you email updates, just to refresh my memory of the process [18:25:52] ejegg: awesome [18:26:03] lemme see if there's fledgling docs... [18:26:18] yep, something exists on collab [18:26:22] * awight chafes at how our docs are split across collab again [18:27:16] I think we can get rid of the warning about master and deployment branches being terribly divergent, at least [18:27:23] hah [18:27:30] that would be smart [18:28:13] ejegg: gross. https://collab.wikimedia.org/wiki/Fundraising/Engineering#Generate_new_Thank_You_email_templates [18:28:31] yep, I just removed that first paragraph [18:28:37] is anything else out of date? [18:28:40] hehe [18:29:03] oh snap, scrum of scrums is now-ish [18:29:04] I can't remember, but we should have made "unconsumed tokens" an error... Not sure if I did that or not. [18:29:15] do you want me to poke release engineering about civi stuff? [18:29:20] mmm [18:29:21] sure [18:29:24] it's pretty block-shaped [18:29:30] lemme find that ticket [18:30:10] https://phabricator.wikimedia.org/tag/wikimedia-fundraising-civicrm/ [18:30:17] thanks! [18:30:18] https://phabricator.wikimedia.org/T86374 [18:30:29] want me to do the crm deployment? [18:30:39] meh it's not a huge rush [18:30:41] all yours :p [18:32:53] (Abandoned) Awight: upstream CiviCRM 4.4.5 [wikimedia/fundraising/crm/civicrm] (contrib-v4.4) - https://gerrit.wikimedia.org/r/133875 (owner: Awight) [18:35:57] AndyRussG: fwiw, I'm gonna remove myself as an automatic reviewer for EducationProgram, but if you ever want CR I'm happy to do so! [18:36:25] awight: Ah OK [18:36:43] Hmmm wanna +2 this? I don't have the rights... https://gerrit.wikimedia.org/r/#/c/184940/ [18:37:10] why no rights? [18:37:13] who... does? [18:37:24] (Sage asked me to see about getting it directly on today's train to production...) [18:37:38] I have +2 rights to merge to master, but it won't let me +2 to the wmf14 branch 8p [18:37:55] Thanks!! [18:38:40] AndyRussG: aha. https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki,access [18:38:50] looks like you need the "wmf-deployment" group [18:39:33] Hmmm [18:39:40] I guess I'll definitely need that for CN deploys [18:49:50] (PS5) AndyRussG: Remove defaults for choices in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182695 [18:50:24] (CR) AndyRussG: Remove defaults for choices in test fixtures (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182695 (owner: AndyRussG) [18:51:33] (CR) jenkins-bot: [V: -1] Remove defaults for choices in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182695 (owner: AndyRussG) [18:58:56] hehehe, I was wondering why my browser stopped working... VE open in another tab. [18:59:37] awight: awwww [18:59:48] * AndyRussG likes VE [19:00:06] I fooled it into adding a template not in its dictionary, yesterday... [19:00:37] VE is awesome, but I don't have the horsepower for 1.5MB of minified js :( [19:01:58] Hmmm that is more than a tad [19:02:38] it's the sort of event loop you want to back your spaceship away from real fast, once you're done editing [19:02:59] awight: are you wfh? [19:03:25] atgo-away: yeah, I fell out of bed at 10:30 like "whaaaa?" [19:03:46] atgo-meetings: is K--- still in a tubeful of angry mob? [19:03:53] bart was a disaster...e veryone seems to have made it now [19:04:07] ejegg: awight astropay call? [19:04:10] I had a meeting with her I just was not awake for [19:04:14] aargh ok perfect [19:06:09] oh right! [19:11:21] awight: you sound fine to us [19:33:19] I hope my video still actually looked like that the whole time :D [19:35:42] AndyRussG: lmk if my mixin changes look good to you... I didn't go full refactor even though I would have liked to. [19:40:12] awight: K I will...! Yeah let's design do go full reactor on designing a nice API ;) [19:40:12] (PS16) Awight: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) [19:40:44] AndyRussG: hehe "go full reactor" is my new favorite dev-slang [19:40:54] Hmmm [19:40:55] hide your graphite! [19:41:15] Yeah go full solar panel just doesn't have the same ring to it [19:41:42] There's no unobtanium floating on _my_ desk or burried underr my tree [19:41:49] I'm holding out for this one: http://www.ncbi.nlm.nih.gov/pmc/articles/PMC2043399/ [19:42:05] ejegg: h! could you U point me to exactly where you saw issues about LocalStorage filling up please? I think u said it was in firebug? thanks!!! [19:42:32] AndyRussG: you can simulate that by going into "pron mode" [19:42:55] wat the termite gut? [19:43:12] I get the localstorage issues even browsing normally [19:43:17] sorry--if you go incognito in firefox, then watch the js console, you'll see the localstorage full warnings [19:43:21] hrm [19:43:28] yeah, console [19:43:35] ah OK the console... [19:44:01] Never noticed or seen it in the built-in console, lemme try w/ Firebug... [19:46:06] (PS2) Awight: eliminate premium_language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184852 [19:48:21] awight: ejegg: Hmmm I'm cavorting all about enwiki in pron mode with my Firebug console out... No sign of LocalStorage errors [19:48:25] Using Iceweasel [19:48:35] hmm, let me see if I'm still getting 'em [19:49:17] Got one as soon as I hit 'edit' [19:50:31] mmm not me [19:50:35] Lemme login [19:51:27] Nope [19:51:32] Firbug console, right? [19:51:45] Can u copypaste pls? [19:52:36] maybe something has pre-filled ejegg's localstorage with a large object? [19:52:53] but didn't it happen in pron mode? [19:53:02] ah good point [19:53:04] I don't see any bug reports neither [19:53:24] lemme squeeze a complaint out of my browser, I've seen plenty [19:54:24] "Persistent storage maximum size reached" [19:54:30] "NS_ERROR_DOM_QUOTA_REACHED" [19:54:46] oh, I'm browsing logged in, which may matter [19:55:09] and not in private mode [19:55:54] I wonder if iceweasel has different defaults [19:55:58] I'm getting that error logged out, after clicking the "Edit" tab [19:56:17] It's giving line numbers, lemme get that from debug mode [19:56:29] I blame ULS :p [19:56:54] hey ejegg! for the HK alipay just sent an email... are we doing HKD or CNY there? [19:58:20] atgo-meetings: good question! We're currently only configured for CNY, but I think adding HKD is just a settings change. [19:58:25] hah, I haven't gotten an error yes, with debug=true [19:58:28] yet [19:58:38] hmm ok [19:58:45] i wonder which we should do.. PPena? [19:58:58] ejegg: it's certainly a problem if it happen, logged in or anon [19:59:06] (PS1) Ejegg: Update thank you email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184982 [20:00:16] awight: oops, looks like I'm adding some incomplete translations there [20:00:32] think I have to sync my local language tables up to production [20:01:05] (CR) Ejegg: [C: -1] "Oops, adding incomplete translations" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184982 (owner: Ejegg) [20:03:46] is there documentation on FormChooser anywhere? [20:03:53] Ha, no. [20:03:56] :( [20:03:59] Want to write some? [20:04:05] I'd be happy to [20:04:07] but [20:04:09] WOOT. [20:04:11] first [20:04:13] I [20:04:14] Also, are you eating today? [20:04:16] need to [20:04:17] like [20:04:20] understand it [20:04:27] because I always forget how to use it [20:04:35] which is lame [20:04:38] I can write up a thing that sort of encompasses the general idea. [20:04:46] sweet! [20:04:58] and yes I should eat [20:05:02] And then for the precise mechanics, if you can fill it in or make the... more goodly wordness. [20:05:02] getting foods? [20:05:19] Oh, I really hope so. [20:05:21] yes I'm looking forward to a different type of activity actually [20:05:27] Neat! [20:05:29] my brain is dying [20:05:29] Jeff_Green: that hang in the silverpop export is currently occurring. Do you mind checking if there's anything locking in geonames? [20:05:46] sure [20:05:50] pizzzacat: You're going to invalidate my vaguely inflammatory slide before anybody really sees it. [20:05:56] woot! a captured naiad [20:06:04] haha [20:06:16] pizzzacat: It'll be great. [20:06:32] I'll put it up on the screen and shout "JUST KIDDING" and move on. [20:06:33] before we get to that slide are you going to dramatically start handing out Ibuprofens? [20:06:49] ejegg: the only queries i see are silverpop export [20:06:59] weird [20:07:05] thanks for taking a look! [20:07:16] pizzzacat: I can probably do that without violating any laws. [20:07:22] Anyway: food. [20:07:32] yes [20:07:34] cheese graters can be dangeous [20:07:41] o_O [20:07:59] ejegg: awight: https://phabricator.wikimedia.org/T67364 [20:08:34] ejegg: see boron:~/spop for details [20:09:00] cool, taking a look [20:11:18] is that 5 processes all running the same query? [20:11:33] looks like they're all on different connections [20:12:35] it sure looks like it [20:12:50] and one has been around for 8 days! [20:13:26] hmm, why aren't we aborting those? [20:14:15] let me see if we're doing something dumb like setting query timeout to infinite [20:24:15] oh, there is no such thing as mysql query timeout! [20:24:40] so, we need to make sure we're cancelling queries on script termination [20:39:44] wat [21:07:38] pizzzacat: I think we just missed standup because our sandwiches took so long. [21:10:21] I don't think we do standup on prawning days? [21:15:17] (CR) Ssmith: [C: 2] CRUD for boards and widgets [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184833 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [21:15:33] (Merged) jenkins-bot: CRUD for boards and widgets [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/184833 (https://phabricator.wikimedia.org/T86095) (owner: Ejegg) [21:20:45] * awight waves the soggy shrimp sandwich of liberty [21:20:58] shit [21:21:21] U splatterred shrimpy mayonaise [21:21:39] Now I'm free! [21:23:20] http://www.tripadvisor.ca/ShowUserReviews-g45084-d519455-r34948568-Mosaic-Bigfork_Montana.html [21:25:54] good find, LOL at bait shrimp :) probably still beats putine though [21:39:03] atgo-meetings ejegg if GC has HKD we should do it as well [21:39:44] OK, I'll try it out [21:50:57] (PS6) AndyRussG: Remove defaults for choices in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182695 [21:58:49] (CR) AndyRussG: "Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182695 (owner: AndyRussG) [22:02:16] (PS7) Awight: Remove defaults for choices in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182695 (owner: AndyRussG) [22:02:51] (CR) Awight: [C: 2] Remove defaults for choices in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182695 (owner: AndyRussG) [22:03:35] (Merged) jenkins-bot: Remove defaults for choices in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/182695 (owner: AndyRussG) [22:55:15] (PS4) Awight: Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 [22:55:17] (PS1) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 [22:55:44] (CR) jenkins-bot: [V: -1] Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (owner: Awight) [22:55:46] (CR) jenkins-bot: [V: -1] Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 (owner: Awight) [22:57:24] (PS5) Awight: Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 [22:57:40] (CR) jenkins-bot: [V: -1] Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 (owner: Awight)