[00:18:03] awight: looks like I was crying wolf on the CRM original_ dependency. as long as normalize is called first, it'll populate original_currency and original_gross from their non-prefixed counterparts [00:19:12] that makes sense. But should still be killed [00:23:16] how do you assign points to cards in Phab? [00:46:34] (PS1) Ssmith: Fix some style things with nav [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/185102 [00:49:43] (PS6) Awight: Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 [00:53:06] (PS2) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 [00:57:03] (CR) jenkins-bot: [V: -1] Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (owner: Awight) [00:57:43] (CR) Ejegg: "One suggestion" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/185102 (owner: Ssmith) [01:01:04] awight: did you see my comment on PS13 of your validation cleanup? Think you need a new var in the loop where you build the extra checks [01:01:30] https://gerrit.wikimedia.org/r/#/c/63823/13/gateway_common/gateway.adapter.php,unified [01:04:18] ejegg: Sorry for the churn on those, I'm relying on V+2 instead of "WIP", out of apathy. [01:04:49] ejegg: oh, yeah great point thanks for catching the var mixup [01:04:58] it would hardly work like that [01:05:14] it would work for the last group! [01:06:04] * awight checks whether my entire sand castle is resting on that patch [01:06:06] i imagine rebasing is a lot of the churn. i'll do some gnawing at the base of those pillars [01:06:44] yes! thanks [01:25:27] Please merge https://gerrit.wikimedia.org/r/#/c/184819/ - without it, all builds for fundraising/REL1_23 will fail [01:25:47] Ha. I was just looking for that. [01:25:51] Krinkle: Thanks. [01:26:06] (CR) Awight: [C: 2] "Sure, thanks for remembering us!" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/184819 (owner: Krinkle) [01:26:16] I would do it myself (as being a backport from master), but don't have permissions there [01:26:23] Cool :) [01:26:28] awight beat me to it. [01:26:48] (CR) Ejegg: [C: -1] "session_velocity needs a code fix, one phpdoc suggestion for DataValidator" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [01:26:49] glad to see us all dogfooding improvements [01:28:02] (PS3) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 [01:28:25] (CR) jenkins-bot: [V: -1] Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (owner: Awight) [01:29:31] awight: Is all that in the sprint? [01:29:58] I mean... I keep thinking about the whole week, and... I definitely saw commits go by. [01:30:58] K4-713: nothing... happened. But yeah I was working sort of as usual [01:31:07] Aha. [01:31:11] Just rounded to zero :) [01:31:11] Does that mean untracked? [01:31:17] Blahaha [01:31:25] You're supposed to go the other way. [01:31:43] well I could add a subtask to "move validation", call it "pound the fleas out of validation" [01:43:38] (CR) Ejegg: [C: 2] "Especially not after midnight" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 (owner: Awight) [01:47:48] awight: yt? [01:48:26] I was just running this on my local, and I'm still getting two test failures. https://gerrit.wikimedia.org/r/#/c/184720/ [01:49:10] K4-713: which failures? [01:49:37] the same two as... before the patch? [01:49:48] Er. [01:49:52] ...wait 1. [01:50:00] * awight runs locally [01:50:49] huuuuuh. Yes. [01:51:04] 1) ProcessMessageTest::testRefundMismatched and 2) WmfTransactionTestCase::testGetContributionMany [01:51:30] oh, I'm not familiar with those rogues [01:51:34] orly [01:51:34] lemme see [01:51:41] Those are the only two I ever get that hard-fail. [01:52:01] Sort of a lot of errors, though. [01:52:05] Both ways. [01:52:16] sounds systemic [01:52:22] Sure does. [01:52:30] you did the composer update, and submodule update --recursive? [01:52:37] Well, yes. [01:52:51] Or I wouldn't be able to load anything via apache. [01:53:07] wish I was there. Can you mail me the output? [01:53:29] I'll send both. [01:54:03] the overall errors would be nice, too [01:54:17] Also, wtf is an "S"? [01:54:29] skipped... [01:54:36] Oh. That. [01:54:54] * K4-713 sighs [01:55:01] I only got one of those after your patch. [01:55:03] short for "slouch-ass developer touched this test" [01:57:56] Tests: 62, Assertions: 137, Errors: 9, Skipped: 1. [01:58:02] Wheee [01:58:07] hum. [01:58:10] well at least I can locally reproduce some of the evil [01:58:19] Well, for one thing, it seems I missed a schema change. [01:58:29] ok that's good [01:58:49] that reminds me... that was the problem :) [01:59:11] I'll include that on the wiki instructions [01:59:41] har [02:00:07] Also... link plz. [02:00:44] that was partly j/k about how I did not write these updates to the howto [02:00:50] yet [02:01:11] My request remains unchanged. [02:01:13] :p [02:02:58] Ooof. I only missed, like, 16 of them or something. [02:04:04] My schema update fixed one test :) [02:04:53] I was about to say: That was sort of anticlimactic for me. [02:05:16] My update fixed... two. [02:05:19] Of 12. [02:05:59] Still two failures. [02:06:25] Base table or view not found: 1146 Table 'drupal.wmf_campaigns_campaign' doesn't exist [02:06:42] ...which seems like it should have been taken care of by the drush dbupdate, right? [02:06:45] wtf [02:07:08] that should be internal to wmf_campaigns, like you either have it installed or not. [02:07:28] looking in mysql just for fun. [02:07:36] could have been you got an old schema migration--try uninstalling and reinstalling the wmf campaings extension [02:07:41] or just disable it [02:08:04] hurf [02:08:09] okay [02:08:39] Hey, it's already disabled. [02:08:41] That's cool, too. [02:09:07] * K4-713 enables, tries it all again [02:10:00] Enabling the thing killed three errors. [02:10:15] That's... [02:11:11] enabling, or reinstalling? [02:11:16] Just enabling. [02:11:21] that is [02:11:24] indeed [02:11:35] It certainly is. [02:11:43] Okay, next up: [02:11:46] 1) ProcessMessageTest::testDonation [02:11:46] Only variables should be assigned by reference [02:11:57] Is... [02:12:02] so ahem. I would say this unit test thing is back in development. Can we find you a workaround? [02:12:04] ...is this because I'm running strict? [02:12:05] such as --filter... [02:12:28] K4-713: I run strict on this laptop, I'll have to confirm tomorrow that I was on the desktop, too [02:13:24] K4-713: oh heh I think I see an issue, where the phpunit.xml still references disabled extensions. [02:14:01] Does your local instance look like it's bleeding to death when you load it in a browser? [02:14:10] If not, you're not rolling strict. :) [02:14:32] hehehe [02:14:58] yeah good point--my work machine must not have that, since I started screwing around with hhvm. [02:15:19] K4-713: so will this keep you in business until tomorrow? phpunit --filter WmfCampaignTest [02:15:22] for example [02:15:34] er. [02:15:41] Let me see how many filters I need... [02:15:47] you can write your tests and run them without the helpful other suites [02:16:11] "Helpful" in the sense that I was helpful in the prawning today? [02:16:20] :) [02:16:22] Ha, look at that. Yes. [02:16:25] Exactly like that. [02:16:35] we can look back on this as Civi's "red and yellow period" [02:16:40] bahaha [02:17:04] http://www.pablopicasso.org/old-guitarist.jsp [02:17:13] The one time I went to civi camp, I kept injecting "WORK IN STRICT" as often as anybody would talk to me. [02:17:25] ...they stopped talking to me. [02:18:07] http://www.giuseppe-arcimboldo.org/127312/Summer-large.jpg [02:18:17] It is slowly improving, sort of [02:18:19] Woah. [02:18:38] I want to fry everything about that dude. [02:18:47] there was some entertainment recently with totten announcing "okay, everybody just pitch in half an hour and we'll get the crappy formatting to go away" [02:19:11] Did that... work? [02:19:20] K4-713: ^ thank you for putting that in my head the next time I look at some arcimboldo [02:19:26] K4-713: baaahahaha [02:19:29] no [02:19:33] not even a little bit [02:20:07] it turned into people suggesting scripts they had used, and other people going "don't you dare run that, I spent a month mopping up last year from that same shit" [02:21:02] K4-713: so but wait--you were saying you would need multiple filters to workaround this borkenness? [02:21:13] Nope. Just the one seems fine. [02:21:21] ...only three tests in there. [02:22:12] (CR) Katie Horn: [C: 2] "Improvement!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184720 (https://phabricator.wikimedia.org/T86686) (owner: Awight) [02:22:23] hehe thx for the kind word [02:22:29] It was just the one. [02:22:34] But there was an exclamation point. [02:22:46] K4-713: but WmfCampaignTest was just an example [02:22:57] Right. I can nonsense it up. [02:23:04] uhh I don't think I'm saying what I am trying to [02:23:05] :p [02:23:14] please nonsense away! [02:23:31] * awight tucks noun away for the "N" sprint [02:23:44] Reminds me of this exchange in the muppet show... [02:24:12] Sam Eagle: "WILL YOU STOP THIS FOOLISHNESS." [02:24:12] Gonzo: "Sure. What kind of foolishness would you like to see?" [02:25:49] * awight is sad again that They had to assassinate JH over Muppets in Space [02:26:32] This pinto overheats even without E_STRICT [02:26:59] For a second I thought you said "piano", which also made as much sense as anything else. [02:27:24] Also? I think Muppets in Space was post-JH. [02:27:38] I thought he croaked midproduction? [02:27:43] He would have had more original music, I think. [02:28:18] * awight harrumphs at the lack of WP link in the "knowledge graph" [02:30:34] I'll have to find a way to piece together a new conspiracy theory. It should be easy [02:30:44] Probably, They found his manuscripts :p [02:32:42] awight: Hey, so... the thought occurs, that this is using whatever db nonsense is in the instance's main database, yeah? [02:32:51] y [02:33:03] * awight becomes irrational [02:33:08] Right. [02:33:17] That's... what I was afraid of. [02:33:30] Wait. Not afraid. [02:33:33] The other thing. [02:33:46] where you try to cover up for a misbehaved friend? [02:34:16] Everything that has happened this week has contained 100x more inertia than I expected. [02:34:57] I also see a long chain of blockers for everything. Maybe that's the same thing. [02:35:02] It is. [02:35:07] It is the exact same thing. [02:35:29] it sounded better the way u said it [02:35:30] I'm going to go home and re-evaluate my whole deal. [02:35:39] shit. [02:35:50] No, it's okay. [02:35:52] See you tomorrow? [02:36:00] I'll do it with MarioKart 8. [02:36:07] back in the saddle! [02:36:07] And probably whisky. [02:36:15] But mostly the first thing. [02:36:38] I think I'm about to discover that my ass has glued itself to the sofa today [02:36:48] ew [02:37:04] not like that, just figurative mucilage [02:37:11] Also ew. [02:37:14] haha [02:37:57] no: boiled hooves!! what is unclear about it [02:38:07] But, about the MarioKart: I played for the first time last week, and discovered to my delight that the slide mechanics are exactly as I expected them to be. [02:38:25] There was one in there that just didn't seem right. [02:38:40] Don't worry, I'll find some part of the CRM tests which is not tumor, and cut that out so we can use it. Tomorrow. [02:39:33] * awight stares back at the 3d imaging lenses in the wall [02:39:44] The issue I'm having, is that the thing I most need tests for, is totally dependent on having something normal in the db to retrieve. [02:39:51] Or, a way to... you know, fake it. [02:39:57] Either way, is fine. [02:40:12] The last video game I played, I fished maybe $4.00 out of the plastic next to the coin slot [02:40:29] And put your elbow directly in a pizza? [02:40:35] K4-713: perfect, let's make test fixtures happen. [02:40:46] We should add that to the sprint. [02:40:49] K4-713: hehe nah this was at Lucky 13, they only serve popcorn [02:40:50] atgo will love that. [02:40:58] lol ok anything to irk her [02:41:04] Any by "love" I probably mean "have us both killed for" [02:41:33] or worse. give us more time to follow our own leads on this refactor goose chase [02:42:01] I think we've just decided to inject some amount of lunacy pretty much all the time. [02:42:08] Like, *always* be doing something dangerous. [02:42:20] ...until October. [02:42:47] meanwhile, in DI land I also have multiple nondeterministic test results, seems like lack of isolation between tests but only when I run the suite of 200 [02:42:52] We talked about this after prawning. [02:42:58] ...huh. [02:43:04] that actually sounds like a fun way to live [02:43:21] on the edge of a knife [02:43:22] Yeah. I'm warming up to the idea in a big way. [02:43:39] Except for the Big EN quarter. [02:43:49] Then we go back to monitoring/bugfixing mode. [02:44:05] We might still consider having two clusters, and routing low levels of traffic through the staging servers [02:44:11] but meh [02:44:22] Which I never bothered to properly define, beyond "[thing] makes K4 nervous; therefore do not do [thing] until January." [02:44:38] That's an interesting idea. [02:44:41] that's a pretty good start [02:45:00] Not making me nervous? ha. [02:45:01] do not scare the K4 back into her burrow in the winter [02:45:05] yeah [02:45:24] aww I miss my loaner guinea pig. [02:45:31] Loanpig. [02:45:37] heh. [02:45:45] indebtpig [02:45:59] One of these days, I'll skip town for some reason I don't know about yet. [02:46:03] O_o [02:46:06] Then you can borrow Emmet and Marty. [02:46:09] okay that sounds like... a plan? [02:46:23] I'm hoping it's vacation, or something fun. [02:46:28] me too, now [02:46:43] make sure it's a surprise! [02:47:08] Bwahahahaha [02:47:19] Huh? [02:47:34] Oh no! He's been bifurcated! [02:47:52] * awight concentrates on seeing single again [02:47:59] All the cool kids do surprise vacations. [02:48:32] You heard me! Don't pretend you're not me [02:48:48] Just definitely don't exceed r > 3.4, http://upload.wikimedia.org/wikipedia/commons/7/7d/LogisticMap_BifurcationDiagram.png [02:48:49] OK that works [02:48:51] * K4-713 wonders which one is the evil one [02:49:01] Both! [02:49:02] wait for the glitch [02:49:24] Both [02:50:34] I'll... what's the inverse of bifurcate? Unifurcate...? again when I set up an IRC to connect both my computerr and phone to :) [02:51:49] hee [02:52:07] Okay, I'm really going now. [02:52:13] Bye! [02:52:17] We can talk db fixtures for civi tomorrow. [02:52:32] Bye! [02:52:44] Later! Later/later. [03:35:37] (PS4) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 [03:35:52] (CR) jenkins-bot: [V: -1] Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (owner: Awight) [04:11:11] (PS5) Awight: WIP Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 [04:11:30] (CR) jenkins-bot: [V: -1] WIP Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (owner: Awight) [04:12:28] (PS11) Awight: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [16:22:25] (PS2) Ejegg: Update thank you email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184982 [16:58:13] (CR) Ejegg: [C: 2] eliminate premium_language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184852 (owner: Awight) [16:58:35] (Merged) jenkins-bot: eliminate premium_language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184852 (owner: Awight) [17:08:46] (PS1) Ejegg: Add route listing all available widget instances [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/185197 (https://phabricator.wikimedia.org/T86095) [17:11:55] (CR) Ejegg: "Looks good, but would conflict a bunch with your more comprehensive patch. holding off merge for now" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 (owner: Awight) [17:15:21] Hi awight! [17:15:49] care to rubber-stamp these email updates? https://gerrit.wikimedia.org/r/184982 [17:15:56] oh, cool [17:16:02] * awight dusts wig [17:16:26] that monotonic ID at the end is real nice... [17:17:35] tangentially... do you agree we should move the l10n_currency thing into PHP? [17:18:03] hm? [17:18:18] how's it happening now? [17:18:25] {{ (currency ~ " " ~ amount) | l10n_currency(locale [17:18:26] ) }} [17:18:32] it seems really out of place... [17:18:44] oh, like it should be a single token [17:18:47] like should be {{ native_amount }} [17:18:48] yeah [17:19:14] Especially with that janky string concat workaround for passing multiple arguments... [17:19:19] sure, why not? [17:19:34] yeah, that's pretty odd-looking [17:19:59] hehe I wonder how many times the ja first/last name have been toggled [17:21:05] oh, look at that! [17:21:06] heh [17:21:14] (PS3) Awight: Update thank you email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184982 (owner: Ejegg) [17:21:20] (CR) Awight: [C: 2] Update thank you email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184982 (owner: Ejegg) [17:21:22] (Merged) jenkins-bot: Update thank you email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184982 (owner: Ejegg) [17:21:32] thanks! deploy time... [17:21:44] * awight beams at seeing the new languages [17:22:08] exciting to have new countries OKed to go [17:24:07] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/185201 [17:24:37] (CR) Ejegg: [C: 2] "+2 for deploy" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/185201 (owner: Ejegg) [17:25:57] !log updated crm from bb05adf9279bd7a795906ca476e1850a85c21711 to d648ededf5c9fc2b0ebf989300ca2037956418e3 [17:26:06] Logged the message, Master [17:28:41] (PS12) Awight: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [17:29:29] (PS17) Awight: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) [17:30:11] (PS7) Awight: Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 [17:30:32] (PS6) Awight: WIP Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 [17:30:49] (CR) jenkins-bot: [V: -1] WIP Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (owner: Awight) [17:41:52] (CR) Ejegg: [C: -1] "Still needs one fix for ip_is_listed call (send list itself, not gateway ID)" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [17:44:12] (PS1) Awight: Delete bad references [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/185206 [17:47:05] (PS13) Awight: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [17:47:25] (CR) Awight: "Ooh wow, I confused patchsets there..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [17:47:27] (CR) jenkins-bot: [V: -1] DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [17:48:05] (PS14) Awight: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 [17:52:00] K4-713: hi! Question about payments' intended behavior for rogue countries... [17:52:09] oh my. [17:52:17] What do you mean, first? [17:52:22] Currently, it doesn't look like an invalid country or 'XX' will trip any alarms [17:52:22] Before you get in to it here. [17:52:25] in DonationInterface [17:52:56] So... things that aren't even countries, or... [17:53:03] I know! [17:53:14] satellite space stations... [17:53:18] <_< [17:53:18] >_> [17:53:31] ahem s/will/will not [17:53:48] oh god. nvm I can write [17:53:52] I guess if we set country = all in a form whitelist that might apply to whatever payment method they're after, you could get as far as a form. [17:54:16] the DataValidator happily passes 'XX'... [17:54:25] Yeah, I'm not surprised. [17:54:40] That makes more sense than trying to keep that bit informed about what a country is. [17:54:53] so ahem shall I tack on some new one-line work to close this hole? [17:54:53] DataValidator is meant to take everything's word for it. [17:55:03] Or this is OK to process payments from Mars? [17:55:15] I suppose that isn't on the State Dept hit list, yet. [17:55:24] Right now, if the gateway puts up with that crap and we have it all whitelisted...\ [17:55:30] ...which is sort of how I think it should be. [17:55:50] OK cool. Thanks for confirming. [17:56:19] I will not change the behavior [17:56:24] Occasionally, nanny-coding just... means we keep more lists around that probably change and need to be maintained and cause somebody's head to explode eventually when it suddenly becomes reasonable. [17:56:25] BUT. [17:56:47] The funny thing is, the way I'd like to address this isn't actually... changing anything fundamental. [17:57:01] well what I was going to do was say country_allowed = !in(forbidden countries) && is_valid_iso_code [17:57:25] until I realized I would be changing behavior. [17:57:44] I'd sort of like to have a form for various levels of half-expected nonsense. [17:57:57] So people have the opportunity to, you know... correct for it. [17:58:10] (CR) Ejegg: [C: 2] "+2 "somewhere very else"" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [17:58:40] (Merged) jenkins-bot: DataValidator uses GatewayAdapter object [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184010 (owner: Awight) [17:58:42] sure! like publishing our root password somewhere just cos we're so confident we can't be hacked [17:58:49] Uhh... [17:58:53] (PS8) Ejegg: Don't feed the instructions results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184848 (owner: Awight) [17:58:57] (PS18) Awight: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) [17:59:30] we can make a new donations page which is made of paper maiche and stuffed with candy, and allows country switching :p [18:00:10] hi pizzzacat! [18:15:51] new thing for dash persistence: https://gerrit.wikimedia.org/r/185197 [18:15:51] hi [18:15:51] so you can retrieve widget configs that aren't on a board [18:15:52] pizzzacat: Hey. You want a quick coffee checkin thing before metrics? [18:15:52] * pizzzacat just opened computer aaaa [18:15:52] * K4-713 hijacks all plans [18:15:53] K4-713 it's ok if we do it later, too - [18:15:53] I mean, I don't have any pressing things at the moment [18:15:53] pizzzacat: Let me look at my calendar to see if I have any time left in the week. :) [18:15:54] ok. don't forget "after hours offsite" as a potential time slot too [18:15:54] I do! I do have time! And some of it even lines up with yours. [18:15:54] wowzers [18:15:55] ejegg thank you - this will be the library! [18:15:56] *in the library [18:15:56] yay [18:15:57] awight: The funny thing about country, is that I am completely certain that there's a form that presents a country dropdown under... unknown circumstances. [18:15:57] I just don't know what/why. [18:15:57] I've seen it, though. [18:15:57] K4-713: I can second that unfounded allegation [18:15:57] was that the old lightbox thing? [18:15:57] Nope. [18:15:57] I can still get it on payments. [18:15:57] awight: While you're in there, maybe hunt around a bit for that yeti. [18:15:58] I'm going to leave this for later... Maybe with a task as breadcrumb [18:15:59] I really want to say that it's at least one of the credit card forms. [18:15:59] Do yetis like bread? [18:15:59] sf sourdough is their favorite [18:15:59] Well, then that should be fine. [18:15:59] They smell like they're made of yeast [18:16:05] ejegg: creepy that I don't see a submit button for https://gerrit.wikimedia.org/r/#/c/184848/ [18:16:05] yeah, I was just puzzling over that [18:16:05] guess I gotta remove + reapply the +2 [18:16:05] blah [18:16:05] so much for working ahead [18:16:05] aargh, still no submit [18:16:06] oh, merged now [18:16:06] but grrrit-wm seems to have gone silent [18:16:40] I don't always see merge notifications... Maybe half the time, I've never understood the pattern. [18:17:00] oh, yeah it's dead [18:17:13] too bad, I was proud of that patch title [18:17:17] "Burn a small book of unused code" [18:17:21] sigh [18:18:30] 'Move more validation' is looking pretty good. Got any further plans for it? [18:19:31] oh wait, still needs that loop var fixed [18:19:59] will do [18:24:13] awight: The title on this commit is vaguely alarming: https://gerrit.wikimedia.org/r/#/c/184847/ [18:24:46] Just tell me one thing: You didn't axe the luhn check, did you? [18:25:04] K4-713: nope, I saw just in time where we use it [18:25:17] Because, hilariously, we use that to verify that silly people didn't enter a vaild cc number in their name field. Yep, that thing. [18:25:36] Anything to provide future selves some entertainment!! [18:26:53] I guess if the PCI dudes tell us that we need to do more things that open up opportunities such that we will need this code again, we can... go back there. [18:27:05] But that is also on my mind. [18:27:31] I'm fine with rewriting--but I think having unmaintained stuff is dangerous for exactly that reason... [18:27:47] Better to start from scratch than with ingredients of unknown provenance :) [18:28:38] Hmm. [18:28:40] Maybe. [18:28:55] I will agree with you because of the lack of the things that would make me want to argue. [18:29:03] Like... relevant unit tests and documentation. [18:29:09] hehe [18:29:18] wait til you see my book burning patch, then :p [18:29:36] I think I saw that one go by. [18:30:32] Tests burn real bright. [18:30:37] With colors. [18:34:02]