[00:08:28] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184841 (owner: Awight)
[00:08:49] <grrrit-wm>	 (Merged) jenkins-bot: assign credit and blame [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184841 (owner: Awight)
[00:42:18] <grrrit-wm>	 (PS1) Ejegg: Exit normally on sigterm to close db connections [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/185351 (https://phabricator.wikimedia.org/T86822)
[00:49:58] <grrrit-wm>	 (CR) Awight: [C: 2] "Nice work!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/185351 (https://phabricator.wikimedia.org/T86822) (owner: Ejegg)
[00:50:01] <grrrit-wm>	 (Merged) jenkins-bot: Exit normally on sigterm to close db connections [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/185351 (https://phabricator.wikimedia.org/T86822) (owner: Ejegg)
[00:50:13] <ejegg>	 thanks!
[00:50:45] <awight>	 I would worry that the less kill-y signal might not be enough to blast through other hanging threads, but we'll see
[00:51:12] <ejegg>	 ooh, are we threading much in other python tools?
[00:51:28] <awight>	 not explicit threads, but system calls and stuff...
[00:51:43] <awight>	 I'm sure this is fine, it just feels funny to downgrade a signal
[00:51:51] <ejegg>	 hmm, guess we should keep an eye out
[00:52:00] <awight>	 maybe we should still send the SIGTERM after the db exit handler?
[00:52:25] <ejegg>	 yeah, that might be the thing to do
[00:52:31] <awight>	 meanwhile :) I'm battling a test isolation issue in DI
[00:52:38] <awight>	 it's driving me up and down the wall
[00:52:49] <ejegg>	 oh, that missing field?
[00:53:41] <awight>	 yeah seems like tests are interacting, but it doesn't look like it's the data!!
[00:53:45] <awight>	 Still investigating...
[00:54:01] <awight>	 The other one is the "function must be a string" nonsense coming from jenkins--I can't reproduce that locally.
[00:54:04] <awight>	 Fun
[00:54:12] <awight>	 More like Friday kinda fun
[00:54:35] <ejegg>	 heh, feeling like the end of the workday here too
[00:54:52] <awight>	 faux real
[00:55:16] <ejegg>	 ah, os.kill(os.getpid(), signum) is what I want
[01:04:58] <grrrit-wm>	 (PS1) Ejegg: Re-emit SIGTERM after closing connections [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/185352
[01:05:00] <awight>	 ejegg: the missing field thing was a double bug :)
[01:05:21] <ejegg>	 ah, very curious to see the fix
[01:07:29] <grrrit-wm>	 (PS1) Awight: Inherit from DonationInterfaceTestCase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185353
[01:08:30] <grrrit-wm>	 (PS1) Awight: Don't fallback from unknown currency [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185354
[01:08:56] <grrrit-wm>	 (PS1) Awight: Only normalize if there's data. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185355
[01:10:41] <grrrit-wm>	 (CR) Awight: [C: 2] "I don't understand the double killing, but it looks like a good idea :)" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/185352 (owner: Ejegg)
[01:10:43] <grrrit-wm>	 (Merged) jenkins-bot: Re-emit SIGTERM after closing connections [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/185352 (owner: Ejegg)
[01:11:41] <grrrit-wm>	 (PS7) Awight: Burn a small book of unused code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184849
[01:12:06] <ejegg>	 awight: signal(SIGTERM, SIG_DFL) just unhooks the handler (sets it back to default behavior) so we don't loop
[01:13:06] <awight>	 aaah
[01:18:15] <grrrit-wm>	 (CR) Ejegg: [C: 2] Inherit from DonationInterfaceTestCase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185353 (owner: Awight)
[01:18:48] <grrrit-wm>	 (Merged) jenkins-bot: Inherit from DonationInterfaceTestCase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185353 (owner: Awight)
[01:20:59] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Good catch!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185354 (owner: Awight)
[01:21:20] <grrrit-wm>	 (Merged) jenkins-bot: Don't fallback from unknown currency [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185354 (owner: Awight)
[01:27:01] <ejegg>	 aargh, that normalization fix looks wrong at first glance, but I bet we really are storing stuff in 'normalized' before we normalize
[01:29:49] <ejegg>	 well, I'll look at it tomorrow. G'night all
[01:30:47] <awight>	 bye!
[01:31:07] <awight>	 ejegg|away: yes... you can never be too normal.
[01:32:42] <grrrit-wm>	 (PS2) Awight: More validation testing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185248
[01:33:14] <grrrit-wm>	 (PS3) Awight: More validation testing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185248
[17:02:57] <K4-713>	 wth does "Award Token" do in phabricator?
[17:03:05] <K4-713>	 I'm about to just start pressing buttons.
[17:04:03] * K4-713 giggles
[17:04:25] <K4-713>	 Uhh, that's clearly a Toucan Token.
[17:04:53] <K4-713>	 Not even remotely a pterodactyl.
[17:05:44] <K4-713>	 awight: I gave you a toucan.
[17:05:54] <K4-713>	 I don't even know what that does for you.
[17:06:54] <ejegg>	 they're supposed to be good at locating colorful cereal
[17:07:08] <K4-713>	 But these guys are apparently terrible at animals.
[17:07:53] <the-wub>	 I'm a fan of the medals being "Orange/Grey/Yellow"
[17:08:50] <K4-713>	 If they had a whale in there...
[17:09:00] <K4-713>	 ...everybody would get one.
[17:09:08] <K4-713>	 From me.
[17:09:17] <K4-713>	 It would be totally unclear if that meant I was happy or upset.
[17:10:25] <AndyRussG>	 It might be clear that you intend it not to be clear ;)
[17:10:34] <awight>	 K4-713: looks like a meaty bird, thanks
[17:10:44] <K4-713>	 Toucan Token.
[17:10:46] <AndyRussG>	 What, the whale?
[17:10:48] <K4-713>	 I mean, it's got to me.
[17:10:52] <K4-713>	 *be
[17:10:53] <K4-713>	 Right?
[17:10:59] <K4-713>	 There's no other... possible...
[17:11:12] <awight>	 That is so lame that they're trying to pass a toucan off as amazing protobird
[17:11:12] <AndyRussG>	 (whale flies straight into frying pan)
[17:11:25] <awight>	 The devs are probably open to feedback.
[17:11:28] <awight>	 And improved icons.
[17:11:33] <K4-713>	 I feel like I'm being expertly trolled. Like, specifically me.
[17:11:34] <awight>	 hwalls!
[17:12:01] <K4-713>	 "We made a joke we didn't call too much attention to, and then blew it. HAHA K4."
[17:12:12] <awight>	 Is this not the raddest icons ever--http://upload.wikimedia.org/wikipedia/commons/thumb/b/b3/Wikipedia_Library_owl.svg/80px-Wikipedia_Library_owl.svg.png
[17:12:25] <K4-713>	 Yes.
[17:12:35] <K4-713>	 I told her yesterday.
[17:12:39] <awight>	 oh woot
[17:12:43] <awight>	 I missed the chance.
[17:13:28] * awight registers with fear that I've had a r/w production SQL console open through all these near-copypasta incidents
[17:14:39] <awight>	 ^D^D^D!
[17:15:12] <K4-713>	 Rebuilding everything that happened since the last backup is fun.
[17:15:21] <K4-713>	 ...isn't it?
[17:15:35] <awight>	 K4-713: hey you want to do some CR, or not until the WX parser has totally frosted your synapses? :p
[17:15:46] <K4-713>	 Sadly, that's not the problem.
[17:15:55] <awight>	 hehe
[17:16:03] <K4-713>	 It's sad, because if that was the problem it would mean I'd have had a chance to work on it.
[17:16:06] <awight>	 you woke up and were still in meetingtown?
[17:16:13] <K4-713>	 Oh, speaking of Things:
[17:16:37] <awight>	 maybe next weekend, Shell Beach
[17:16:39] <K4-713>	 ejegg: I changed that one patch I had in for restoring chargeback functionality.
[17:16:55] <K4-713>	 Which... seems like something we should try to wrap up before PPena gets too far into the finance reconciliation.
[17:17:20] <ejegg>	 I saw you fixed the array thing and I +2ed
[17:17:23] <K4-713>	 awight: I woke up at 5 and drove in.
[17:17:26] <ejegg>	 Was there something else?
[17:17:33] <K4-713>	 Oh, did you?
[17:17:35] <K4-713>	 Neat.
[17:17:37] <ejegg>	 and, shall I deploy?
[17:17:48] <K4-713>	 If you have the bandwidth to do so, that would be *great*.
[17:17:48] <awight>	 K4-713: blyeak
[17:17:53] <ejegg>	 fa sho
[17:17:56] <K4-713>	 awight: I am a sad panda.
[17:18:13] <awight>	 K4-713: I considered calling about that, but it would have been 1am and made you sadder
[17:18:31] <awight>	 plus, I would have died.  And probably paid BART for the privilege of going through a tunnel anyway.
[17:18:44] <K4-713>	 Actually, that would have been okay. I was having a f'd up dream that one of my guinea pigs turned into an evil genuis.
[17:18:51] <awight>	 whooohahaha!
[17:18:55] <K4-713>	 Not... the one that looks like a mad scientist.
[17:18:58] <K4-713>	 The other one.
[17:18:59] <grrrit-wm>	 (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/185455
[17:19:00] <awight>	 Dr. Yacub
[17:19:01] <K4-713>	 And he bit me.
[17:19:05] <awight>	 fack.
[17:19:09] <K4-713>	 And started doing Things in the attic.
[17:19:12] <ejegg>	 did you get superpowers?
[17:19:12] <awight>	 that is real
[17:19:30] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/185455 (owner: Ejegg)
[17:19:45] <K4-713>	 But I couldn't get to the attic to see what Things, because the staircase (that doesn't actually exist in my house) kept moving.
[17:19:56] <ejegg>	 spooky!
[17:20:07] <K4-713>	 Also he could talk.
[17:20:20] <K4-713>	 That did not register as odd at the time.
[17:20:26] <awight>	 Greatest attic book ever btw: http://static.guim.co.uk/sys-images/Guardian/Pix/pictures/2011/3/10/1299758090372/Satoshi-Kitamura-008.jpg
[17:20:41] <K4-713>	 Woah.
[17:20:53] <awight>	 he has one of those not-staircases
[17:20:59] <K4-713>	 It was kind of like that, only, like... Indiana Jones levels of dusty.
[17:21:26] <awight>	 did... the evil superpig say anything?
[17:21:37] <K4-713>	 Many, many things.
[17:21:41] <K4-713>	 Most of which I can't remember.
[17:21:55] <ejegg>	 !log updated civicrm from d648ededf5c9fc2b0ebf989300ca2037956418e3 to 4fa10ec9e3afbf65e6cbd523138cdc4b4485c482
[17:22:01] <morebots>	 Logged the message, Master
[17:22:08] <K4-713>	 Mostly along the lines of "THIS IS MY HOUSE NOW."
[17:22:11] <awight>	 I think you should slow down a recording of their ordinary so-calle squeals
[17:22:40] <K4-713>	 omg
[17:22:59] <K4-713>	 Did you ever play Day of the Tentacle?
[17:23:04] <K4-713>	 He sounded like Purple.
[17:23:34] <K4-713>	 I've only just realized. That's amazing.
[17:24:38] <awight>	 You should set your alarm for 4AM more often, just enough to startle the next chapter out of your tormented brain.
[17:27:48] <K4-713>	 I really hate to say it, but there may be something to that.
[17:29:09] <grrrit-wm>	 (PS8) Awight: WIP Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082
[17:29:14] <K4-713>	 Oh, fuff. There's still something wrong.
[17:29:14] <grrrit-wm>	 (CR) Ejegg: [C: 2] Only normalize if there's data. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185355 (owner: Awight)
[17:29:29] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (owner: Awight)
[17:29:44] <awight>	 K4-713: that ^^ 185355 for example you might want to CR post-facto
[17:29:51] <K4-713>	 Not... evilpig. I mean the chargebacks. I guess at this point I'm just assuming they're unrelated.
[17:30:17] <K4-713>	 hmm
[17:32:30] <grrrit-wm>	 (Merged) jenkins-bot: Only normalize if there's data. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185355 (owner: Awight)
[17:34:33] <grrrit-wm>	 (CR) Ejegg: [C: 2] More validation testing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185248 (owner: Awight)
[17:34:50] <grrrit-wm>	 (Merged) jenkins-bot: More validation testing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185248 (owner: Awight)
[17:36:04] <ejegg>	 I'm gonna deploy tools for the python sigterm/close connections fix if there are no objections
[17:36:48] <ejegg>	 also, Jeff_Green: would you mind checking for processes querying geonames again?  I think we want to kill them all
[17:36:55] <K4-713>	 Awesome. This makes no sense.
[17:37:09] <ejegg>	 That thing with the silverpop export leaving queries running
[17:37:22] <Jeff_Green>	 ejegg: sure. this reminds me--I think we need to disable that export script
[17:37:49] <ejegg>	 I think I fixed it so it will close connections when jenkins kills it at least
[17:37:55] <Jeff_Green>	 that's good
[17:38:03] <ejegg>	 we kinda need it if they're going to send any mass emails
[17:38:18] <Jeff_Green>	 it's effectively taking down the production db
[17:38:42] <ejegg>	 After we kill any existing queries hanging onto geonames, I'm hoping the next run goes better
[17:38:49] <Jeff_Green>	 annoyingly I wasn't getting paged, but load was rediculously high for days
[17:38:50] <Jeff_Green>	 ok
[17:39:21] <Jeff_Green>	 it's been running for 29234
[17:39:26] <Jeff_Green>	 just one instance today though
[17:39:45] <ejegg>	 hmm, guess that's this morning's
[17:39:51] <ejegg>	 mind killing that?
[17:40:00] <ejegg>	 I'll update tools and try running again
[17:40:05] <Jeff_Green>	 done
[17:40:16] <ejegg>	 and we can see if it overloads the db when it's only running once
[17:42:09] <ejegg>	 awight: I'll deploy your bannerbot useragent too
[17:42:47] <grrrit-wm>	 (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/185465
[17:43:01] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/185465 (owner: Ejegg)
[17:43:10] <awight>	 ejegg: awesome.  That will make some people happy.
[17:44:07] <ejegg>	 !log updated tools from 88b57fea517d2232e8ae906df550f426b6574f24 to 84442d51a841af4265ff103827cda83d5dd9dc54
[17:44:11] <morebots>	 Logged the message, Master
[17:44:37] <ejegg>	 OK, gonna re-run the silverpop export
[17:45:54] <ejegg>	 we don't periodically update that geonames db, do we?
[17:45:56] <grrrit-wm>	 (PS9) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082
[17:46:13] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (owner: Awight)
[17:46:18] <awight>	 ejegg: Not that I've ever heard of
[17:46:27] <Jeff_Green>	 ejegg: no change to that db since we last blew it up, in june
[17:46:32] <ejegg>	 cool
[17:46:59] <awight>	 K4-713: so, here's an example of what I was talking about, Jenkins gets a completely different answer than I do locally: https://integration.wikimedia.org/ci/job/mwext-DonationInterface-testextension-zend/328/console
[17:47:21] <K4-713>	 Hum.
[17:47:24] <awight>	 If you get the chance, maybe you could see if it happens locally for you? 185082
[17:47:30] <K4-713>	 What's in your localsettings, locally?
[17:47:37] <ejegg>	 function name must be a string, huh?
[17:47:39] <K4-713>	 Sure, I can do that.
[17:48:00] <K4-713>	 ...heh.
[17:48:17] <K4-713>	 What's going on in DataValidator.php on line 368?
[17:48:41] <K4-713>	 If it's the kind of voodoo I think it is...
[17:49:13] <ejegg>	 weird, he's already throwing an exception if !is_callable($callable)
[17:49:14] <awight>	 oh definitely
[17:49:18] <awight>	 right!
[17:50:04] <ejegg>	 wait, but you can do that with arrays?
[17:50:16] <K4-713>	 And, you're passing this locally?
[17:50:25] <K4-713>	 wh
[17:50:42] <awight>	 hehehe
[17:50:50] * awight turns into a guinea pig
[17:51:20] <awight>	 I think that array thing has been legal... forever.  like PHP 4
[17:53:39] <ejegg>	 yep, that commit passes all the DI tests on my machine
[17:53:47] <awight>	 that's sick
[17:54:32] <ejegg>	 still zend
[17:55:00] <awight>	 good point.  but yeah
[17:55:41] <ejegg>	 5.5 vs 5.3 is all I can think of, but you say that array trick is much older
[17:56:16] <awight>	 I tried a test file with just that feature, on barium
[17:56:24] <awight>	 exact same release, afaict
[17:56:46] <awight>	 My last hope is that K4-713 has the right wall voltage
[17:56:50] <ejegg>	 dang
[17:57:16] <K4-713>	 Gah, sorry: I have too many brain tabs open.
[17:57:26] * K4-713 take s a deep breath
[17:57:40] <K4-713>	 The thing is, today is really the last day before next friday.
[17:58:00] * K4-713 re-reads last statement; hates everything
[18:01:22] <K4-713>	 awight: I'm getting...  9 failures.
[18:01:52] <K4-713>	 They're all "Untranslated messages present"
[18:02:25] <K4-713>	 But it looks like some kind of escaping disaster.
[18:02:45] <ejegg>	 http://www.recessframework.org/page/php-callables-is-callable-call-user-func-array-reflection
[18:03:01] <ejegg>	 down at "Dynamically Invoking Instance and Static Methods"
[18:03:14] <K4-713>	 awight: I'll stuff it in an email
[18:03:21] <ejegg>	 they mention exactly our situation
[18:03:52] <ejegg>	 and say we need call_user_func
[18:07:54] <ejegg>	 yeah, their example checks out for me on barium
[18:08:03] <ejegg>	 must be a 5.3 thing
[18:08:40] <awight>	 ejegg: try the array syntax on barium, though!
[18:09:00] <awight>	 Thank you for finding the blog, I'm sure this will work...
[18:09:05] <awight>	 pure evil.
[18:09:25] <ejegg>	 Yeah, I did class Blah { static function thing() { echo "thing";} }
[18:09:40] <ejegg>	 $callableArray = array( "Blah", "thing");
[18:10:01] <ejegg>	 then call_user_func($callableArray) echos "thing"
[18:10:17] <awight>	 Just for fun, try $callableArray()
[18:10:17] <ejegg>	 but just $callableArray() dumps me back to console with no echo
[18:10:20] <awight>	 oh
[18:10:22] <awight>	 huh
[18:10:29] <awight>	 that's even ruder than a fatal error
[18:10:31] <ejegg>	 lemme see why no error message
[18:10:54] <awight>	 come to think of it, I might have not had a side-effect to look for
[18:11:11] <awight>	 yep.
[18:11:26] <grrrit-wm>	 (PS10) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082
[18:12:51] <awight>	 Woohoo!
[18:12:57] <ejegg>	 nice...
[18:13:12] <awight>	 Good thing CI saved me from blowing up the cluster!
[18:13:19] <awight>	 ...today...
[18:13:20] <ejegg>	 hehe
[18:13:37] <K4-713>	 I wish it would save me from making 12 more useless commits in the crm repo.
[18:13:43] <K4-713>	 But, you know: I'm gonna.
[18:14:16] <ejegg>	 I'm gonna knock that latest patch around a bunch locally, do some stepping through.
[18:14:26] <awight>	 cool.
[18:14:29] <ejegg>	 I'd really like to deploy this stuff before we go further
[18:14:47] <awight>	 K4-713: thanks!  Feel free to refactor wmf_civicrm.  It's open season.
[18:15:05] <K4-713>	 Again, I site the "no more days between now and next friday" thing.
[18:15:16] <K4-713>	 I have lame manager stuff to do before then.
[18:15:19] <awight>	 http://laststandonzombieisland.files.wordpress.com/2013/07/dronepermit-633x352.jpg
[18:15:45] <K4-713>	 I thought it was wabbit season.
[18:16:13] <ejegg>	 gotta hack em as they fly over, sweet talk them into a soft landing so you can scavenge parts
[18:18:18] <awight>	 the predator whisperer
[18:19:02] <grrrit-wm>	 (PS11) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082
[18:19:15] <awight>	 noticed I was changing some minor behavior
[18:22:03] <grrrit-wm>	 (PS12) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (https://phabricator.wikimedia.org/T86945)
[18:22:11] <grrrit-wm>	 (PS8) Awight: Burn a small book of unused code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184849 (https://phabricator.wikimedia.org/T86945)
[18:22:18] <grrrit-wm>	 (PS3) Awight: Wipe out credit card validations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 (https://phabricator.wikimedia.org/T86945)
[18:22:20] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Wipe out credit card validations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 (https://phabricator.wikimedia.org/T86945) (owner: Awight)
[18:23:02] <K4-713>	 Oh yeah. awight, ejegg: Any reactions to the review thing I want to do?
[18:23:07] <K4-713>	 Nobody said anything.
[18:23:28] <grrrit-wm>	 (PS9) Awight: Burn a small book of unused code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184849 (https://phabricator.wikimedia.org/T87043)
[18:23:41] <grrrit-wm>	 (PS3) Awight: Cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184844 (https://phabricator.wikimedia.org/T87043)
[18:24:13] <ejegg>	 K4-713: seems like a decent idea
[18:25:22] <K4-713>	 I mean, I guess I assumed that if anybody hated it, I'd have heard something by now.
[18:25:42] <atgo-away>	 awight: ejegg can you put estimates on the cards in "in analysis"?
[18:25:47] <atgo-away>	 in ze sprint
[18:26:09] <K4-713>	 Would that mean they had been analyzed?
[18:26:11] <ejegg>	 sure thing
[18:26:36] <K4-713>	 I'm... actually not trying to be a jackass at the moment.
[18:26:43] <K4-713>	 Legitimate question.
[18:27:33] <K4-713>	 atgo-away: Also, you missed a thing with a Toucan.
[18:27:47] * awight puts it on my head proudly
[18:27:49] <atgo-away>	 yes, that's the missing piece :)
[18:27:52] <atgo-away>	 toucans?
[18:28:03] * awight though angry about its non-pterodactyl talons
[18:28:03] <K4-713>	 So, there's this "Award Token" button.
[18:28:12] <K4-713>	 One of the tokens is *clearly* a toucan.
[18:28:16] <K4-713>	 Because: Toucan token.
[18:28:21] <atgo-away>	 oh yeah.. i don't get those tokens at all
[18:28:21] <atgo-away>	 https://www.youtube.com/watch?v=f5O0EHwfPno
[18:28:29] <K4-713>	 But if you hover over it, it claims to be a Pterodactyl.
[18:28:33] <K4-713>	 ...maddening.
[18:28:39] <atgo-away>	 that's... cool
[18:33:54] <atgo-away>	 ejegg: off hand, do you know if there'd be a way to speed up the alipay stuff at all? apparently it's painfully slow
[18:33:59] <atgo-away>	 i assume that's on their side
[18:39:46] <awight>	 atgo: I wanted to ask about points for refactor tasks--maybe we want to keep these points out of the sprint?
[18:40:01] <atgo>	 why?
[18:40:31] <ejegg>	 atgo: do you know what part is slow?
[18:40:45] <ejegg>	 We're doing next to nothing on our side
[18:40:55] <ejegg>	 just asking GC for a URL
[18:41:25] <ejegg>	 Then they do have to bounce off that GC URL before they get to Alipay, but we can't get around that
[18:41:38] <atgo>	 yeah that's weird...
[18:41:41] <atgo>	 maybe we should hassle GC about it
[18:42:02] <atgo>	 brb... going to grab a coffee
[18:51:57] <grrrit-wm>	 (CR) Ejegg: [C: -1] "Couple small behavior changes" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (https://phabricator.wikimedia.org/T86945) (owner: Awight)
[18:54:26] <grrrit-wm>	 (PS4) Awight: Wipe out credit card validations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 (https://phabricator.wikimedia.org/T86945)
[18:55:50] <grrrit-wm>	 (CR) Ejegg: [C: 2] Reinstate some missing schema upgrades [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/185337 (https://phabricator.wikimedia.org/T86686) (owner: Awight)
[18:56:22] <grrrit-wm>	 (PS3) Ejegg: obsessive safety checks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/185338 (https://phabricator.wikimedia.org/T86686) (owner: Awight)
[18:56:34] <grrrit-wm>	 (CR) Ejegg: [C: 2] obsessive safety checks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/185338 (https://phabricator.wikimedia.org/T86686) (owner: Awight)
[19:02:18] <grrrit-wm>	 (PS13) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (https://phabricator.wikimedia.org/T86945)
[19:03:34] <grrrit-wm>	 (PS14) Awight: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (https://phabricator.wikimedia.org/T86945)
[19:04:37] <grrrit-wm>	 (CR) Awight: Lots of validation cleanup (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (https://phabricator.wikimedia.org/T86945) (owner: Awight)
[19:07:09] <awight>	 K4-713: ejegg just merged an important commit, which you should have before rebuilding the Civi db...  https://gerrit.wikimedia.org/r/185337
[19:09:22] <atgo>	 awight: why don't you want to put points on refactor stuff?
[19:12:23] <awight>	 atgo: thinking it's not product evolution
[19:12:57] <awight>	 Also, we're letting this work constantly unfold, so estimates will not mean anything as the rabbithole opens
[19:27:44] <atgo>	 hmmm
[19:27:52] <atgo>	 well, whatever you guys want to do/agree on is fine with me
[19:28:06] <atgo>	 if we're not going to estimate them, let's at least put a 0 estimate instead of default so that the graphs can graph
[19:28:19] <atgo>	 also, my bank blocked my card because i was donating in israel :P
[19:28:28] <pizzzacat>	 haha whaat
[19:28:39] <pizzzacat>	 why??
[19:28:39] <atgo>	 yeahhh
[19:28:45] <atgo>	 it looked fraud-y
[19:28:47] <pizzzacat>	 just because it was weird
[19:28:48] <pizzzacat>	 yeah
[19:28:54] <atgo>	 which i get... a bunch of small amounts in a short time frame
[19:28:59] <pizzzacat>	 well I guess that's nice of them...
[19:29:05] <pizzzacat>	 to be so on top o fit
[19:29:10] <atgo>	 yeah. would've been nicer if they,d you know, let me know they did it
[19:29:16] <atgo>	 but they are going to whitelist wikimedia :P
[19:29:45] <pizzzacat>	 ha two birds with one call
[19:34:38] <awight>	 pizzzacat: tell them your paychecks are supposed to be x100, too...
[19:34:53] <awight>	 What is this, a paycheck for *ants*?
[19:35:12] <atgo>	 :P
[19:36:09] <pizzzacat>	 I'm sure that will totally work
[19:42:29] <ejegg>	 php passing arrays by shallow-copied-value is hard to get used to
[19:48:22] <AndyRussG>	 ejegg: indeed!
[19:49:19] <AndyRussG>	 (Just stick a & on the front in the receiving code to get by-ref... mmm I'm sure you knew that...)
[19:57:34] <ejegg>	 dang, silverpop export seems to be dying again.  WTF, query 23?  How can something that normally takes 6 minutes sometimes decide to take forever?
[20:00:20] <atgo>	 ejegg: boooooo
[20:00:57] <awight>	 I'm really surprised that the hung queries cause cpu load
[20:03:16] <awight>	 ejegg: which one is it, again?  -- Lookup timezone by country and post code -- for countries that span
[20:03:32] <ejegg>	 yes, i think so
[20:03:34] <ejegg>	 one sec
[20:03:34] <awight>	 or -- Lookup timezones by country (mostly for those that do not have
[20:03:37] <awight>	 blah
[20:04:00] <awight>	 aww, too bad we can't explain the query, cos of tmp tables
[20:04:17] <ejegg>	 lookup timezone
[20:04:34] <ejegg>	 oh, i was just trying to get the process id
[20:04:47] <awight>	 what the... db is that?
[20:04:53] <ejegg>	 looks like there's a 'show explain for N' command in mariadb
[20:05:03] <awight>	 cool
[20:05:30] * awight suppresses urge to run over and beat up the database
[20:05:55] <ejegg>	 ah, guess i have to be in there as the export user to see their processes
[20:09:53] <ejegg>	 phooey, mariadb 10.0?
[20:10:03] <ejegg>	 that seems future-y
[20:12:37] <awight>	 sad
[20:15:44] <ejegg>	 after some food i'm gonna run all the queries in my own session to get an explain out of it
[20:59:54] <grrrit-wm>	 (PS1) AndyRussG: WIP Remove defaults for setup in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/185542
[21:00:36] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Remove defaults for setup in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/185542 (owner: AndyRussG)
[21:24:24] <atgo>	 FYI - https://phabricator.wikimedia.org/project/view/1004/
[21:31:20] <awight>	 Cat's cradle
[21:31:30] <awight>	 C-Lo
[21:31:35] <awight>	 C-note :(
[21:31:48] <awight>	 Catastrophic
[21:32:00] <awight>	 Actually, Catatonic considering the number of working days we'll have
[23:21:18] <grrrit-wm>	 (CR) Aaron Schulz: [C: 2] MWException -> Exception [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/184049 (owner: Ori.livneh)
[23:21:37] <grrrit-wm>	 (Merged) jenkins-bot: MWException -> Exception [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/184049 (owner: Ori.livneh)
[23:37:49] <grrrit-wm>	 (CR) Awight: [C: -2] "Please don't merge yet, it will probably melt down. We use an older branch of core. We need to test this patch carefully." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (owner: Ori.livneh)
[23:57:56] <ejegg>	 K4-713: yeah, guess it's not so early now.  Maybe we can deploy from the bowling alley Tuesday?