[00:03:23] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Much nicer. I really like having all the default fields + checks visible on one screen." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (https://phabricator.wikimedia.org/T86945) (owner: Awight)
[00:03:47] <grrrit-wm>	 (Merged) jenkins-bot: Lots of validation cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185082 (https://phabricator.wikimedia.org/T86945) (owner: Awight)
[00:15:08] <AndyRussG>	 ejegg: I'm also trying to think of a deploy time before all hands... I was thinking Monday but it's a holday there, right?
[00:16:23] <ejegg>	 yep, martin luther king day
[00:17:59] <AndyRussG>	 Certainly a worth holiday... But if you'll be around, I could help out if u need a hand with anything, if it's stuff I can check...
[00:18:29] <AndyRussG>	 ...and in that case maybe you'd like to help me do my first CN deploy that day too?
[00:19:21] <ejegg>	 mmm, think i'll actually be off all day
[00:20:13] <K4-713>	 ejegg: Guh... next week is probably going to be a wash.
[00:20:22] <AndyRussG>	 Ah oh well... :)
[00:20:35] <K4-713>	 I mean, from a "deploying our stuff in a sane way" perspective.
[00:20:51] <K4-713>	 Probably better to give up now so we aren't trying to do several things at once, and miss the point.
[00:22:18] <AndyRussG>	 K4-713: Mmm OK :)
[00:42:23] <K4-713>	 Hey, who re-ordered the brainstorming deck?
[00:42:34] <K4-713>	 That's... strange.
[00:46:02] <AndyRussG>	 ?
[00:49:09] <K4-713>	 My slides moved.
[00:49:19] <K4-713>	 Some of them are now very far away from eachother.
[00:49:23] <K4-713>	 And I had a group of three.
[00:49:29] <K4-713>	 ...had.
[00:49:45] <AndyRussG>	 you could still group them abstractly
[00:57:39] <awight>	 K4-713: ejegg: here are the notes I was hoping to have validated--https://phabricator.wikimedia.org/T86251
[00:59:58] <awight>	 K4-713: also, I've always been slightly disturbed by the gatewaypage vs resultswitcher thing, I don't know why... does it make sense to you if we push the control logic from both of those forms down to the adapter subclass?
[01:00:14] <grrrit-wm>	 (CR) Ejegg: [C: -1] "Nudge re: comments from PS13" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) (owner: Awight)
[01:00:16] <awight>	 like, handleRequest and handleResponse
[01:00:20] <K4-713>	 awight: ...arghbargle.
[01:01:04] <awight>	 ejegg: ah thx!
[01:01:26] <awight>	 K4-713: if never is a good time, don't worry :)
[01:01:36] <ejegg>	 awight: notes on that ticket look solid
[01:01:39] <K4-713>	 I... have an opinion.
[01:02:06] <K4-713>	 awight: It's just that at this exact moment, I'm not sure I'd trust myself to correctly identify a cheese sandwich.
[01:02:28] <awight>	 hehe.  do you have any type of cheese whatsoever
[01:02:33] <K4-713>	 And not, like provolone vs cheddar.
[01:02:38] <awight>	 No limburger???
[01:02:45] <K4-713>	 Like... cheese sandwich vs wagon wheel.
[01:02:46] <awight>	 It's only the single most popular cheese
[01:03:08] <ejegg>	 where?
[01:03:18] <awight>	 britsh... isles?  well I don't know
[01:03:57] <K4-713>	 No, that's my name. Mr Wensleydale.
[01:04:01] <awight>	 K4-713: Eventually, I'd like to see everything broken into tiny classes that do one thing, but that will take some architecture work
[01:04:21] <K4-713>	 That might hurt.
[01:04:24] <K4-713>	 Like, a lot.
[01:04:59] <K4-713>	 Particularly when you're trying to get the different pieces to log a cohesive... chain of events that happened to one thing.
[01:05:35] <K4-713>	 The nice thing about splitting the resultswitcher away from the regular form controller, is that there is no question about what part of the workflow you're looking at.
[01:05:37] <awight>	 My plan for that was sort of along the SmashPig line of thought--logging should be an external helper service that we inform of the current context.
[01:06:12] <K4-713>	 Amazon tried to ball them up together, and we *always* think "OMG SO MANY PEOPLE SHOWED UP WITH MISSING PARAMS"
[01:06:13] <K4-713>	 No.
[01:06:25] <K4-713>	 They weren't passed in *when they came back*.
[01:06:29] <awight>	 K4-713: yeah, I did that... out of ignorance and fear.
[01:07:32] <K4-713>	 So... I like one URL where people aren't really supposed to be unless they are... vetted. Particularly if more secure things are supposed to happen on one, than on the other.
[01:07:48] <K4-713>	 Like... forbidding people from doing anything if there isn't a good session.
[01:08:20] <K4-713>	 Having said that, so very much of that logic should be floated down to the adapter.
[01:08:25] <K4-713>	 I mean, probably.
[01:08:26] <awight>	 I totally agree that the two URLs should be routed separately.  I just wanted to pack the logic up in one place for now
[01:08:36] <K4-713>	 Yeah, okay. That.
[01:08:58] <awight>	 I want the adapter class to present the entire interface for dealing with a transaction
[01:09:10] <K4-713>	 That would be the sane thing to do, yes.
[01:09:16] <awight>	 in theory, Civi could spin up an adapter object, and do a back-end donation...
[01:09:21] <K4-713>	 aye
[01:09:45] <K4-713>	 ...except for the "user returns to the supplied returnto URL" bit.
[01:10:00] <K4-713>	 Though...
[01:10:12] <awight>	 That would be part of the deal--the response controller would return a PaymentResponse object that said "SUCCESS"
[01:10:18] <K4-713>	 I just thought of a reason we're going to have to be careful about moving that logic in, too.
[01:10:27] <K4-713>	 Orphan slaying already hijacks that in batch mode.
[01:10:32] <K4-713>	 We should, you know... not break that.
[01:10:36] <awight>	 and the calling code would map success to something != returnTo page
[01:10:59] <awight>	 although--calling code from this crappy CRM example *would* redirect to Amazon for the initial request.
[01:11:04] <K4-713>	 mhm
[01:11:23] <awight>	 thx for mentioning the orphan slayer, I'll mention that in the task
[01:11:32] <K4-713>	 Groovy.
[01:11:36] <awight>	 I will pass along your mention
[01:11:42] <K4-713>	 I'm slightly surprised I'm not talking absolute crap right now.
[01:11:56] <K4-713>	 >_>
[01:11:57] <K4-713>	 <_<
[01:11:59] <awight>	 I'm also fried.  Just had a baby shouting MAMA at me for an hour
[01:12:23] <K4-713>	 huh
[01:12:43] <awight>	 I wasn't even good enuf to push the stroller, in her eyes
[01:12:54] <K4-713>	 Dang.
[01:13:12] <K4-713>	 Our 6-month reviews will be less harsh.
[01:13:45] <awight>	 oh.  yeah that sure took the mustard out of our cheese sauce.
[01:14:16] <K4-713>	 Is... there usually...
[01:16:36] <awight>	 only in the finest fondue wallholes
[01:17:23] <K4-713>	 Oooh.
[01:17:34] <K4-713>	 That's why mine is just melted cheese with wine on the side.
[01:18:05] <awight>	 mmmm
[01:34:47] <AndyRussG>	 "mama" is the geneic term in babyspeak
[01:35:20] <awight>	 I tried explaining that to her ;)
[01:35:48] <AndyRussG>	 Later they differentiate by calling the Mom "mama" and the Dad "Mama Papa", like a distorted instance of "Mama".
[01:35:54] <AndyRussG>	 She'll get it, don't worry ;)
[01:47:46] <awight>	 that happens to me!  She gets flustered, in her head it probably sounds like "mama--goddamit--boppa"
[01:48:51] <AndyRussG>	 linguistic universals! Ha
[01:49:14] <awight>	 Nim Chimsky :(
[01:49:19] <awight>	 so wrong...
[01:49:58] <AndyRussG>	 Langacker!
[02:41:40] <grrrit-wm>	 (PS1) Awight: new PaymentResponse class for passing donor UI hints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598
[02:41:42] <grrrit-wm>	 (PS1) Awight: WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599
[03:46:44] <grrrit-wm>	 (PS1) Awight: WIP fix and continuation of previous patch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185603
[03:46:46] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP fix and continuation of previous patch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185603 (owner: Awight)